From nobody Sun Nov 24 02:30:53 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1726278282723265.08405286410243; Fri, 13 Sep 2024 18:44:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spHpL-0004Pz-4p; Fri, 13 Sep 2024 21:43:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spHpJ-0004Om-0Y for qemu-devel@nongnu.org; Fri, 13 Sep 2024 21:43:53 -0400 Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spHpG-00021O-HV for qemu-devel@nongnu.org; Fri, 13 Sep 2024 21:43:52 -0400 Received: from loongson.cn (unknown [10.2.5.213]) by gateway (Coremail) with SMTP id _____8CxxuhP6uRmZ5cHAA--.16580S3; Sat, 14 Sep 2024 09:43:43 +0800 (CST) Received: from localhost.localdomain (unknown [10.2.5.213]) by front1 (Coremail) with SMTP id qMiowMAxQNZO6uRmMmcGAA--.31125S2; Sat, 14 Sep 2024 09:43:43 +0800 (CST) From: Bibo Mao To: Song Gao Cc: Richard Henderson , qemu-devel@nongnu.org Subject: [PATCH] target/loongarch: Avoid shifting with bool type variable Date: Sat, 14 Sep 2024 09:43:42 +0800 Message-Id: <20240914014342.2095136-1-maobibo@loongson.cn> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qMiowMAxQNZO6uRmMmcGAA--.31125S2 X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=114.242.206.163; envelope-from=maobibo@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1726278287687116600 Content-Type: text/plain; charset="utf-8" Variable env->cf[i] is defined as bool type, it cannot be used with left shifting operation. There is existing api read_fcc(), it can be used when dumping fp registers into coredump note segment. Resolves: Coverity CID 1561133 Signed-off-by: Bibo Mao Reviewed-by: Richard Henderson --- target/loongarch/arch_dump.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/loongarch/arch_dump.c b/target/loongarch/arch_dump.c index 4986db970e..d9e1120333 100644 --- a/target/loongarch/arch_dump.c +++ b/target/loongarch/arch_dump.c @@ -97,11 +97,7 @@ static int loongarch_write_elf64_fprpreg(WriteCoreDumpFu= nction f, =20 loongarch_note_init(¬e, s, "CORE", 5, NT_PRFPREG, sizeof(note.fpu)); note.fpu.fcsr =3D cpu_to_dump64(s, env->fcsr0); - - for (i =3D 0; i < 8; i++) { - note.fpu.fcc |=3D env->cf[i] << (8 * i); - } - note.fpu.fcc =3D cpu_to_dump64(s, note.fpu.fcc); + note.fpu.fcc =3D cpu_to_dump64(s, read_fcc(env)); =20 for (i =3D 0; i < 32; ++i) { note.fpu.fpr[i] =3D cpu_to_dump64(s, env->fpr[i].vreg.UD[0]); base-commit: 28ae3179fc52d2e4d870b635c4a412aab99759e7 --=20 2.39.3