From nobody Sun Nov 24 05:51:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1726248521159397.6302439039034; Fri, 13 Sep 2024 10:28:41 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1AE8B142F; Fri, 13 Sep 2024 13:28:40 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 12A6D1558; Fri, 13 Sep 2024 13:27:08 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 1010F137D; Fri, 13 Sep 2024 13:27:02 -0400 (EDT) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 33B8813CE for ; Fri, 13 Sep 2024 13:27:01 -0400 (EDT) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5365cc68efaso2613791e87.1 for ; Fri, 13 Sep 2024 10:27:01 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25cee784sm908091066b.177.2024.09.13.10.26.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2024 10:26:57 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 49ED85F95B; Fri, 13 Sep 2024 18:26:56 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726248420; x=1726853220; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9JqMmYhvvimxL2nuuWz1bK1OoVqJiadEwbZ7PDjZqjg=; b=vgl81DfuYzgLY8nanF8uyT9Knn4zKW0A0Lurp8rxVh9dVFeKRKviBGQo3q1y/phCwO imXxUNEsT+dhgIHPG2TXSMDUgQNP7KRXTtIezzZzv0FisoN0+wUJoVAaPSChiUxmmA4H 1lnAQkUFoe7H+9F+w+CWsrc/4v6NcuzhMuL1kg52rpvnvSO4oRPjLgNaF7KFT0gU1IT+ 5Zt5jBgcOgVjurEcolJCse6h5cN0RgLs/o/yCNl2vskrd50qtPHPxhmWpUFpk400P9ay TjIk4Dxy2i6j9XbgG684N2pPyXXkVHEUhu8RBsaT6ArLmHY8pjxxK7e22bdjqhaFBqgb V+jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726248420; x=1726853220; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9JqMmYhvvimxL2nuuWz1bK1OoVqJiadEwbZ7PDjZqjg=; b=NoZzQ815KFtm18BSLO3YqSYSULLxDG9MC6QUPw2/VmeBGFIfIyE3f4SicHqq+IjVUx WggFCzcxGvqR1ckOe7nJdt7PCTOfgiTU7MjC24Iat4/0C9wf57KSn9NsXa7b6V1PVirc Xf1fiZzp1fGYWPmexAYVqzeLDHhIYj1XdLna+jG/IOyWHs9qlFIYrJ1m70vx7rWL8du2 KtYV55dg+qZqgV1yzTZFK1xAfMSKAzPm1XS0mXSINlZ0p5YbJtNLJHY1Dq1+wHdFghD3 Q638xt9h+EpzIh7IcQ42+oPAF9h2EwqRLUnsfIaE99z+SpW+coSKfyvgbW9KffXcRTna k+IA== X-Forwarded-Encrypted: i=1; AJvYcCWSA6Vfn0NcdQ9+pMdG9HOR/FeBSaX3rjEYGiy15pqTopYXZjm2gXRLkQ9iJOirLYxyBAUwVw==@lists.libvirt.org X-Gm-Message-State: AOJu0YxIRfRGh4aqr17q1Bidpylx/sDtLde1SycbQ25ChaMK6CHbZzk2 Ricy7N7bp0fnYA+3F2okYv2USmV1k6c0p507BqRsofBni8draYA0iqMf5UVSxn0= X-Google-Smtp-Source: AGHT+IH3bdwzTkX6RkmqwIfCijpBrDjsCtcg6FVo/vS7CoFIj8tfb4Cb0f4MAOqNFH3FazC4AeWmRA== X-Received: by 2002:a05:6512:2344:b0:52c:850b:cfc6 with SMTP id 2adb3069b0e04-53678feb625mr4600483e87.38.1726248418837; Fri, 13 Sep 2024 10:26:58 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH 02/17] deprecation: don't enable TCG plugins by default with TCI Date: Fri, 13 Sep 2024 18:26:40 +0100 Message-Id: <20240913172655.173873-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240913172655.173873-1-alex.bennee@linaro.org> References: <20240913172655.173873-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: EK7LTPOUNHOIFU6EINZ3UU6FQID4PCMK X-Message-ID-Hash: EK7LTPOUNHOIFU6EINZ3UU6FQID4PCMK X-MailFrom: alex.bennee@linaro.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: Richard Henderson , devel@lists.libvirt.org, Thomas Huth , Mahmoud Mandour , Paolo Bonzini , David Hildenbrand , Ilya Leoshkevich , qemu-ppc@nongnu.org, Zhao Liu , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yanan Wang , Eduardo Habkost , qemu-s390x@nongnu.org, Alexandre Iooss , Pierrick Bouvier , Nicholas Piggin , Daniel Henrique Barboza , Marcel Apfelbaum X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1726248522335116600 Content-Type: text/plain; charset="utf-8" The softmmu memory instrumentation test sees so many more accesses than a normal translated host and its really not worth fixing up. Lets deprecate this odd configuration and save on the CI cycles. Message-Id: <20240910140733.4007719-13-alex.bennee@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Benn=C3=A9e --- docs/about/deprecated.rst | 8 ++++++++ configure | 11 +++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index f7c7c33d39..5aa2e35314 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -196,6 +196,14 @@ benefits from having plenty of host memory it seems re= asonable to encourage users to use 64 bit builds of QEMU for analysis work whatever targets they are instrumenting. =20 +TCG Plugin support not enabled by default with TCI (since 9.2) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +While the TCG interpreter can interpret the TCG ops used by plugins it +is going to be so much slower it wouldn't make sense for any serious +instrumentation. Due to implementation differences there will also be +anomalies in things like memory instrumentation. + System emulator CPUs -------------------- =20 diff --git a/configure b/configure index f376fa24b3..3778b61c40 100755 --- a/configure +++ b/configure @@ -629,6 +629,9 @@ meson_option_parse() { exit 1 fi } +has_meson_option() { + test "${meson_options#*"$1"}" !=3D "$meson_options" +} =20 meson_add_machine_file() { if test "$cross_compile" =3D "yes"; then @@ -1048,8 +1051,12 @@ if test "$static" =3D "yes" ; then plugins=3D"no" fi if test "$plugins" !=3D "no" && test $host_bits -eq 64; then - plugins=3Dyes - subdirs=3D"$subdirs contrib/plugins" + if has_meson_option "-Dtcg_interpreter=3Dtrue"; then + plugins=3D"no" + else + plugins=3Dyes + subdirs=3D"$subdirs contrib/plugins" + fi fi =20 cat > $TMPC << EOF --=20 2.39.2