From nobody Sun Nov 24 04:53:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1726199205; cv=none; d=zohomail.com; s=zohoarc; b=D4vfc/+b3qf4f9VWLjuw9DlA4CFUiDyPlckwesTv/nBG/keBPM8QLdVuFUq/b9UyEITWcZxBg+jKmy/eh2JQZfSyuXTwpxIbbOitT3x4JFkQgU1PiKjQeIG9qRZlQGN0ZNRtQAdKPOe7hgRNSvFwO2CQqyA9y8TevVfN1ecuado= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726199205; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fEpDPUaFL8zPvYOx/0hsO+TqHl11ExTE7h8t0M0WvV0=; b=RtIrtJq4VqpLlrv/OvlvuSI7LJoCUVLjJP2crrI/KjSIy055RYFD9ww9wAdb6+mOensQyappKk2sbnRjLuxERnSNeEFLxZX5JZW1HP8Al7Xb/ZonKsCSmfVDj441fHB+XXiRapkb/JqZbwGgYQqEij850z6S1TjSllGZIMhynsY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1726199205029499.1444142620569; Thu, 12 Sep 2024 20:46:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1soxFr-00073a-87; Thu, 12 Sep 2024 23:45:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soxFo-0006ju-O0 for qemu-devel@nongnu.org; Thu, 12 Sep 2024 23:45:52 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soxFn-0008Is-10 for qemu-devel@nongnu.org; Thu, 12 Sep 2024 23:45:52 -0400 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-207115e3056so16596335ad.2 for ; Thu, 12 Sep 2024 20:45:50 -0700 (PDT) Received: from localhost ([157.82.202.230]) by smtp.gmail.com with UTF8SMTPSA id 41be03b00d2f7-7db1fddd501sm2490342a12.71.2024.09.12.20.45.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 20:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1726199149; x=1726803949; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fEpDPUaFL8zPvYOx/0hsO+TqHl11ExTE7h8t0M0WvV0=; b=M9Q6W+G5kOXC/nbVgCiRbWvTw9f4OH0L9bmn+73h8ah9uLugww15CPlgD5G5XZewfG xUK4PcOSnaV42OSgN7026OqoVmuXYYYi+/EEelQ4Vcuu/0n0eKH7Ko+29bGBuAEJE0ca M0GdV0L0aNdhfyms3ARB3iOJ6gnkYuBdQYKmC60aviuV7/ahqF9lWdDp4BC2iitOUjNI 1pIu+TVBlKzrU2JfWttPyp3ZXGT9BlwGjkgVs0h2ern5G++vqTetX22ThzmLGP0nBaMd CFbA8ZRAiBYXlafFwIQlMlS7ELo3MUOY7NE7OioyuyolcdaYx6ANF5/6cF8gpvjQz0JW VOOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726199149; x=1726803949; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fEpDPUaFL8zPvYOx/0hsO+TqHl11ExTE7h8t0M0WvV0=; b=wmcf6OmDULvClT3J0qIHmiMiv9UH/6fZaNUz8BnHcbhrf2xzoK/32mgr4cV9l6ehPa Rq3UlgO/8QYuJwVMvFEb0yRkl0+eP4nKXxt7DU8lmoFykoFIpwl9ikAxgyWoayQh5uqa rn5q2BYnEqEnUxoxDPKkQbsDSz8XLJPPR25JX3IdmwVB2f75BskNpGTFmdbuVKBz6hcB VS6tHYeicg66Zg3kOKp+e6q1s071Q6LWcaeGtcU3MyO7WiLTqil3Rkauc+Ss8BtlJDTw oLOAQ5ldR90ts8m5uwZDZMAKXl/+3KKImqTZa6B7tmrGqn7p5wEMY4FGz6EKXawoF3Ur AWbQ== X-Gm-Message-State: AOJu0YxmmnULJzCtANfmT4+EUCTuWiT22jIj2migLZ4e8ShadwBZTiWD CAYl55868/IBY9mC2gRkGC2lblv+dMaGUpvSklyEwStois065DwSNjjoGnD/QNg= X-Google-Smtp-Source: AGHT+IH6cv5ySpOeZrGoMc1rthujaqfIP9yc75kRGlGZsMln8GOcu8qwRvK+hCqd7sMyQAdzgMIKXw== X-Received: by 2002:a17:902:ecd2:b0:205:3e68:7359 with SMTP id d9443c01a7336-2076e491acdmr62386475ad.53.1726199149406; Thu, 12 Sep 2024 20:45:49 -0700 (PDT) From: Akihiko Odaki Date: Fri, 13 Sep 2024 12:44:41 +0900 Subject: [PATCH v16 13/13] hw/qdev: Remove opts member MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240913-reuse-v16-13-d016b4b4f616@daynix.com> References: <20240913-reuse-v16-0-d016b4b4f616@daynix.com> In-Reply-To: <20240913-reuse-v16-0-d016b4b4f616@daynix.com> To: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , Sriram Yagnaraman , Jason Wang , Keith Busch , Klaus Jensen , Markus Armbruster , Matthew Rosato , Eric Farman Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Akihiko Odaki X-Mailer: b4 0.14-dev-fd6e3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::62d; envelope-from=akihiko.odaki@daynix.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1726199205635116600 It is no longer used. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Markus Armbruster --- include/hw/qdev-core.h | 4 ---- hw/core/qdev.c | 1 - system/qdev-monitor.c | 12 +++++++----- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index 77bfcbdf732a..a3757e6769f8 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -237,10 +237,6 @@ struct DeviceState { * @pending_deleted_expires_ms: optional timeout for deletion events */ int64_t pending_deleted_expires_ms; - /** - * @opts: QDict of options for the device - */ - QDict *opts; /** * @hotplugged: was device added after PHASE_MACHINE_READY? */ diff --git a/hw/core/qdev.c b/hw/core/qdev.c index f3a996f57dee..2fc84699d432 100644 --- a/hw/core/qdev.c +++ b/hw/core/qdev.c @@ -706,7 +706,6 @@ static void device_finalize(Object *obj) dev->canonical_path =3D NULL; } =20 - qobject_unref(dev->opts); g_free(dev->id); } =20 diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c index 6af6ef7d667f..3551989d5153 100644 --- a/system/qdev-monitor.c +++ b/system/qdev-monitor.c @@ -624,6 +624,7 @@ DeviceState *qdev_device_add_from_qdict(const QDict *op= ts, char *id; DeviceState *dev =3D NULL; BusState *bus =3D NULL; + QDict *properties; =20 driver =3D qdict_get_try_str(opts, "driver"); if (!driver) { @@ -705,13 +706,14 @@ DeviceState *qdev_device_add_from_qdict(const QDict *= opts, } =20 /* set properties */ - dev->opts =3D qdict_clone_shallow(opts); - qdict_del(dev->opts, "driver"); - qdict_del(dev->opts, "bus"); - qdict_del(dev->opts, "id"); + properties =3D qdict_clone_shallow(opts); + qdict_del(properties, "driver"); + qdict_del(properties, "bus"); + qdict_del(properties, "id"); =20 - object_set_properties_from_keyval(&dev->parent_obj, dev->opts, from_js= on, + object_set_properties_from_keyval(&dev->parent_obj, properties, from_j= son, errp); + qobject_unref(properties); if (*errp) { goto err_del_dev; } --=20 2.46.0