From nobody Sun Nov 24 05:32:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1726064825; cv=none; d=zohomail.com; s=zohoarc; b=IPlZNcMTa14s9rYgQWsjIQ1D7R9MGe4pTLrR08RSNtsWASA9wMEN0v12f15vmOJa2TNduh97BUapMTKqt5uco149e3GOpjAv3+KOiikJQ6hhKkMSRVJlJAH2b8ljuay+GCyGWVPExLRcdruVMoktrl6rV1zanW4caETsdGwfsVU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1726064825; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GPyTDcszhoeWdCN/K5slNupruBYEwdvgfkSRmPx2RVM=; b=Thi9yilLGUDUWWlaHUzjvprW4dPaJLBY0sI76crSZCx4YCyvR7xagalbozSY/R8ffI6NTPlmzU5QMntBQdRKCIZpeC7xJNcFZs0o0RfmrlUxfJ6U+LoCjif/sLKOfJoCYxNPVmKZ/TUpSatqybsmAq0KRQ39wveWEBWmEzlAFno= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172606482527851.41390579357676; Wed, 11 Sep 2024 07:27:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1soOI2-0004fo-Vh; Wed, 11 Sep 2024 10:25:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1soOHS-0004Eq-Vy; Wed, 11 Sep 2024 10:25:21 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1soOGt-0008FS-ST; Wed, 11 Sep 2024 10:25:14 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1F4DC219EA; Wed, 11 Sep 2024 14:16:55 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AFE3B13A7C; Wed, 11 Sep 2024 14:16:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dp5jHVWm4WaXVQAAD6G6ig (envelope-from ); Wed, 11 Sep 2024 14:16:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1726064215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GPyTDcszhoeWdCN/K5slNupruBYEwdvgfkSRmPx2RVM=; b=Qx2gfTqlQD6J+pLrr70ungu9P82jluubzT3mTLx1IMpVYZ8HMoxJ9O6Jve0APpFWt+9GgP +J2+kMn1UUaW+PLNXUfuH7GPx0an+bsUG62oWfgVI7EL1m/zURyqy4hHOpPQ7S6kUJ5/FG NIokYSBugpFwrtzB+MllCrGxEGlOAEk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1726064215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GPyTDcszhoeWdCN/K5slNupruBYEwdvgfkSRmPx2RVM=; b=E0BCvly8WGO6t7/uJngp80xKTcM8wMrTJiSdV/9VPtUgN21IuXDM9KKwKJcs0Yn+5akt29 AwISTjj9/6wAP1BA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1726064215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GPyTDcszhoeWdCN/K5slNupruBYEwdvgfkSRmPx2RVM=; b=Qx2gfTqlQD6J+pLrr70ungu9P82jluubzT3mTLx1IMpVYZ8HMoxJ9O6Jve0APpFWt+9GgP +J2+kMn1UUaW+PLNXUfuH7GPx0an+bsUG62oWfgVI7EL1m/zURyqy4hHOpPQ7S6kUJ5/FG NIokYSBugpFwrtzB+MllCrGxEGlOAEk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1726064215; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GPyTDcszhoeWdCN/K5slNupruBYEwdvgfkSRmPx2RVM=; b=E0BCvly8WGO6t7/uJngp80xKTcM8wMrTJiSdV/9VPtUgN21IuXDM9KKwKJcs0Yn+5akt29 AwISTjj9/6wAP1BA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Nicholas Piggin , Daniel Henrique Barboza Subject: [PATCH] target/ppc: Fix lxvx/stxvx facility check Date: Wed, 11 Sep 2024 11:16:51 -0300 Message-Id: <20240911141651.6914-1-farosas@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.32 X-Spamd-Result: default: False [-0.32 / 50.00]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.02)[52.29%]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[nongnu.org,gmail.com]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:email] Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1726064827678116600 The XT check for the lxvx/stxvx instructions is currently inverted. This was introduced during the move to decodetree. From the ISA: Chapter 7. Vector-Scalar Extension Facility Load VSX Vector Indexed X-form lxvx XT,RA,RB if TX=3D0 & MSR.VSX=3D0 then VSX_Unavailable() if TX=3D1 & MSR.VEC=3D0 then Vector_Unavailable() ... Let XT be the value 32=C3=97TX + T. The code currently does the opposite: if (paired || a->rt >=3D 32) { REQUIRE_VSX(ctx); } else { REQUIRE_VECTOR(ctx); } This was already fixed for lxv/stxv at commit "2cc0e449d1 (target/ppc: Fix lxv/stxv MSR facility check)", but the indexed forms were missed. Cc: qemu-stable@nongnu.org Fixes: 70426b5bb7 ("target/ppc: moved stxvx and lxvx from legacy to decodtr= ee") Signed-off-by: Fabiano Rosas Acked-by: Ilya Leoshkevich Reviewed-by: Claudio Fontana --- target/ppc/translate/vsx-impl.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/ppc/translate/vsx= -impl.c.inc index 40a87ddc4a..a869f30e86 100644 --- a/target/ppc/translate/vsx-impl.c.inc +++ b/target/ppc/translate/vsx-impl.c.inc @@ -2244,7 +2244,7 @@ static bool do_lstxv_PLS_D(DisasContext *ctx, arg_PLS= _D *a, =20 static bool do_lstxv_X(DisasContext *ctx, arg_X *a, bool store, bool paire= d) { - if (paired || a->rt >=3D 32) { + if (paired || a->rt < 32) { REQUIRE_VSX(ctx); } else { REQUIRE_VECTOR(ctx); --=20 2.35.3