From nobody Sun Nov 24 09:03:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1725991324; cv=none; d=zohomail.com; s=zohoarc; b=F4CVwxLA0f+khkFqwT81zXOYCZXM7LbhiOhOHDhsB8YVfrjmnPCIiXCeld3BkIR5DtkVNEHaG5X9nExicjvU1wDt+5HDEr5vXp7cE/WGNwFZcrLSQCvK9eDWW/Z/3BthbPc4GujEjt/EneLgHNFy99XRN2p6Z34s9lkpQlwTlGU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1725991324; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1QCStA1c9//s/ovz1sMs7IM3L4XXAB6/ay1DdRsZ7no=; b=CUACZxVx76IwnMoOZidxm4XnlLJ4qR7E0PfSuCuz4J0dk/+IvTysyCUEFYGBhCVePtiuzbhd2oErfrdVa2ZtcUgZdbasiP5GuOXKxhzmCr/JH+EcKUtCFDG9n+DDHLMJA4Ocoy5QMHhPvYKf2RSU3dxh0GwWAqpOn+sOBqHrzH4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1725991324431791.8070700106927; Tue, 10 Sep 2024 11:02:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1so59A-0008QF-S4; Tue, 10 Sep 2024 13:59:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1so599-0008Hx-18 for qemu-devel@nongnu.org; Tue, 10 Sep 2024 13:59:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1so596-0006Sx-DC for qemu-devel@nongnu.org; Tue, 10 Sep 2024 13:59:21 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-50-_5h7gSm_MLCf3HZf3h-WgQ-1; Tue, 10 Sep 2024 13:59:18 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3403619560A3; Tue, 10 Sep 2024 17:59:17 +0000 (UTC) Received: from t14s.redhat.com (unknown [10.22.32.182]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 83B17195605A; Tue, 10 Sep 2024 17:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725991159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1QCStA1c9//s/ovz1sMs7IM3L4XXAB6/ay1DdRsZ7no=; b=XnX4XAqbg3eqfjJUDKvaKh7NIpaN7xuBW7uEEbzgNKiUShdkdyHj162iKzVRbgoq/ONUzY vNosPYtlyGXezaBaUynbaNhLeFreXrtbQFnMuFrp9lHOlzJSdDo9DfmcpeTyUcgBgfmcKV 2tW9V4qa9USs1ndM9LyrY2ptPqXh/hw= X-MC-Unique: _5h7gSm_MLCf3HZf3h-WgQ-1 From: David Hildenbrand To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, David Hildenbrand , Paolo Bonzini , Thomas Huth , Halil Pasic , Christian Borntraeger , Eric Farman , Richard Henderson , Ilya Leoshkevich , Janosch Frank , "Michael S. Tsirkin" , Cornelia Huck Subject: [PATCH v1 12/14] s390x: introduce s390_get_max_pagesize() Date: Tue, 10 Sep 2024 19:58:07 +0200 Message-ID: <20240910175809.2135596-13-david@redhat.com> In-Reply-To: <20240910175809.2135596-1-david@redhat.com> References: <20240910175809.2135596-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.145, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1725991326474116600 Content-Type: text/plain; charset="utf-8" Let's add a way to return the value (successfully) set via s390_set_max_pagesize() previously. This will be helpful to reject hotplugged memory devices that would exceed this initially set page size. Signed-off-by: David Hildenbrand Acked-by: Michael S. Tsirkin --- target/s390x/cpu-sysemu.c | 16 ++++++++++++++++ target/s390x/cpu.h | 1 + 2 files changed, 17 insertions(+) diff --git a/target/s390x/cpu-sysemu.c b/target/s390x/cpu-sysemu.c index 1915567b3a..bee5d6c2ee 100644 --- a/target/s390x/cpu-sysemu.c +++ b/target/s390x/cpu-sysemu.c @@ -278,11 +278,27 @@ uint64_t s390_get_memory_limit(void) return memory_limit; } =20 +static uint64_t max_pagesize; + void s390_set_max_pagesize(uint64_t pagesize, Error **errp) { + ERRP_GUARD(); + + if (max_pagesize) { + error_setg(errp, "Maximum page size can only be set once"); + return; + } if (kvm_enabled()) { kvm_s390_set_max_pagesize(pagesize, errp); } + if (!*errp) { + max_pagesize =3D pagesize; + } +} + +uint64_t s390_get_max_pagesize(void) +{ + return max_pagesize; } =20 void s390_cmma_reset(void) diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index 7a51b606ed..37845e0d9d 100644 --- a/target/s390x/cpu.h +++ b/target/s390x/cpu.h @@ -897,6 +897,7 @@ void s390_crypto_reset(void); int s390_set_memory_limit(uint64_t new_limit, uint64_t *hw_limit); uint64_t s390_get_memory_limit(void); void s390_set_max_pagesize(uint64_t pagesize, Error **errp); +uint64_t s390_get_max_pagesize(void); void s390_cmma_reset(void); void s390_enable_css_support(S390CPU *cpu); void s390_do_cpu_set_diag318(CPUState *cs, run_on_cpu_data arg); --=20 2.46.0