From nobody Sun Nov 24 08:56:40 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1725991217; cv=none; d=zohomail.com; s=zohoarc; b=Itp/FVigJ4scuF2Q7tgjrZsUzkhBAqMNloxG+adgBOreEWwtz+BPquDuuP7niyjxvkdRBlXcyga3B4AKjxF+40CYeJ0szRDcxKDD2eJ3s0TKcIaJkSmc2qLgjqoM37H1gSQxSjAkiqHqhrjJnGlcJ+idjOJFNKJON1ImhVylSK0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1725991217; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pogIUR4Y7jHUWwoFlDhVvmypKP+F9B3m0FkodcPAihs=; b=Qm9swrc9jf9xeDfHGRIZD1efpRyVoZYAH098eWyExxLLt2SR4MmsDqmq8dm+FQH4qdZbCZSlSfZ5Z3gJEkJOs9jcXXKnatUWSAsRzGCgpyIAiFcCy/b6aTg1jrozYLFROGA/9H87m7HkTcd7Hyl4jAYPkb18jB7s72bAr7H7YEs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172599121725678.53379452668196; Tue, 10 Sep 2024 11:00:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1so592-0007kg-V4; Tue, 10 Sep 2024 13:59:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1so58u-0007Ge-Nt for qemu-devel@nongnu.org; Tue, 10 Sep 2024 13:59:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1so58t-0006Ra-2x for qemu-devel@nongnu.org; Tue, 10 Sep 2024 13:59:08 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-568-dfDGacG7PHSpZBSlscVjYw-1; Tue, 10 Sep 2024 13:59:03 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2BDB51955F2E; Tue, 10 Sep 2024 17:59:02 +0000 (UTC) Received: from t14s.redhat.com (unknown [10.22.32.182]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC28119560AD; Tue, 10 Sep 2024 17:58:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725991146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pogIUR4Y7jHUWwoFlDhVvmypKP+F9B3m0FkodcPAihs=; b=KwuPhLMM58AfrRNbYEPGm+Z9jB0mX8gRRxWSwUSZRTyMSpBiIdOu1OTqxog/Rv/Oua2Ia7 +RDJba2TyeIV6ejTzBCPBfcV0LI+A2qtQgBpYrYKI56ZR6/Z2yiinAghpgfoxsTCEF64VY /qYpy2bbKCZpIt4TEEifkQzWxPWHhjc= X-MC-Unique: dfDGacG7PHSpZBSlscVjYw-1 From: David Hildenbrand To: qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, David Hildenbrand , Paolo Bonzini , Thomas Huth , Halil Pasic , Christian Borntraeger , Eric Farman , Richard Henderson , Ilya Leoshkevich , Janosch Frank , "Michael S. Tsirkin" , Cornelia Huck Subject: [PATCH v1 09/14] s390x/s390-skeys: prepare for memory devices Date: Tue, 10 Sep 2024 19:58:04 +0200 Message-ID: <20240910175809.2135596-10-david@redhat.com> In-Reply-To: <20240910175809.2135596-1-david@redhat.com> References: <20240910175809.2135596-1-david@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.145, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1725991217779116600 Content-Type: text/plain; charset="utf-8" With memory devices, we will have storage keys for memory that exceeds the initial ram size. The TODO already states that current handling is subopimal, but we won't worry about improving that (TCG-only) thing for now. Signed-off-by: David Hildenbrand --- hw/s390x/s390-skeys.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c index bf22d6863e..8716c2e73e 100644 --- a/hw/s390x/s390-skeys.c +++ b/hw/s390x/s390-skeys.c @@ -251,9 +251,7 @@ static bool qemu_s390_enable_skeys(S390SKeysState *ss) * g_once_init_enter() is good enough. */ if (g_once_init_enter(&initialized)) { - MachineState *machine =3D MACHINE(qdev_get_machine()); - - skeys->key_count =3D machine->ram_size / TARGET_PAGE_SIZE; + skeys->key_count =3D s390_get_memory_limit() / TARGET_PAGE_SIZE; skeys->keydata =3D g_malloc0(skeys->key_count); g_once_init_leave(&initialized, 1); } --=20 2.46.0