From nobody Sun Nov 24 09:55:42 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1725944148; cv=none; d=zohomail.com; s=zohoarc; b=SOErp6rB+uutqOMePjM4MaM3OKinsT9BskZwmBSj/G7vA7DlVnOOxudIWxbAhLk9jR9dnGKbLesmZNxyCVK4IFAzIALPL1Z3nP8YN1Y8g+awq8io7lNwqwEoJ0f7Yi1mTZ7372MzgTIJfrfmocj97MTLFf7NlFDOIOHTUvPlq0w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1725944148; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xw0KbrgvvvrtCjxJXIgOiVXG0kyfqQmRrStgJmdBHPI=; b=eO2twQa9UJs/lrmLY3f7k5+wIVmX0UOOCtZZ79V/R7VcYaAixNvi944qYZ356nY+1o4t2QU31JZseYnrc5IYy/CDxPjTgJ4n47H8gyS1iY/liorPp9XsmoN+MXlG1n2Q7Bu25fJmMCUNY/IGLpDUIPFWtifSQwbtNdcEq1H8jXA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172594414872265.50229983907718; Mon, 9 Sep 2024 21:55:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1snsty-00044d-0N; Tue, 10 Sep 2024 00:54:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snstx-00043k-6P; Tue, 10 Sep 2024 00:54:53 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1snstv-0002xD-85; Tue, 10 Sep 2024 00:54:52 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-205909af9b5so39802985ad.3; Mon, 09 Sep 2024 21:54:50 -0700 (PDT) Received: from toolbox.alistair23.me (2403-580b-97e8-0-82ce-f179-8a79-69f4.ip6.aussiebb.net. [2403:580b:97e8:0:82ce:f179:8a79:69f4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e352d8sm40944425ad.72.2024.09.09.21.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Sep 2024 21:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725944089; x=1726548889; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xw0KbrgvvvrtCjxJXIgOiVXG0kyfqQmRrStgJmdBHPI=; b=fXAM6kkQC1Msuw3wGSZHoKZvMar0rHakr9stpSGp0YX3YkTqhBYxEOHur+W8kiaofY Xw2kGK0BN7HFxrnUMVnVW6HMEwSFvs37rlI/DHv4LPjevpmBQDkecITBx9EZNVa+Xs/A cV/V+Xhguuxk0vH+w+pjeSyayEgHqQINA9mMk1tr6rBLna4cWOEintYwhwOWk1Zp+Z+L OEY0VTxCnK0q4mvI6NJSsQgsYhk3+h7Xh0aeriBNj1dHWtGd3W+8gsyMr5iO8bv6IANe q+/yOYK1C87VQNCGcl6Z0lADR9/kglaH+3HFKW+BSLsH74BxK1YZNGIANqgmzG+U3zwL j7eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725944089; x=1726548889; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xw0KbrgvvvrtCjxJXIgOiVXG0kyfqQmRrStgJmdBHPI=; b=QRQg/aHZA9uclpi5duu/WxbXVM+2I+ll4wpa260aHJEC77IML+WfiP62JyDHomYWWv ioR76o5whnL3ISJaMGWxdQDscx/6RU4ynigU5CmYyqmrx6L9dZ3ZPFyNqvwFtHpLZOEb 880ufZIFzhG6PGPBcu+9wbwASu3QDwMhiBtwaeFVe/Er5Rx3RLFY4qPauDMXax13w7kT fjJulLHkMuWl/av841zokE6aCVTK2cx5m94AFhvfJo/L3axCTOR9i5LvBV4tg8jGjH1c oXHHV+IpDxRJMymC7fEfrAw8XsVMX9Gimj+tWFyCB4/iegH8zIccVecLuNCHaiZ44eGi UY5g== X-Forwarded-Encrypted: i=1; AJvYcCW5LeV3XwW6i5xN8H8vUzGagAnqqEE9pUDKOKHum5s/2h0dosQhyh0J6WYLT+GeYXEhBmjvD4XGECAS@nongnu.org X-Gm-Message-State: AOJu0YwJggsQR7LDAnrooPy4/+iIC8NRbCvIsFtkP2TsKJqmgAW8kBBX wqZjeMHeBb1Vnvu/iUSDTHwjweLDfobdwhVYG7sdAYNmqmI2GpkuhTYNYA== X-Google-Smtp-Source: AGHT+IFVvKHeXREYFwzfiMgzMiMLC1L9kwi4a+ues6mEIxR3Guj3Uhzvedx6mB3nU3jD+lXiV5oW6A== X-Received: by 2002:a17:903:2409:b0:207:3c2f:37b7 with SMTP id d9443c01a7336-2073c2f37dbmr49444495ad.32.1725944088881; Mon, 09 Sep 2024 21:54:48 -0700 (PDT) From: Alistair Francis X-Google-Original-From: Alistair Francis To: qemu-devel@nongnu.org, alex.bennee@linaro.org, peter.maydell@linaro.org Cc: Bin Meng , palmer@dabbelt.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, alistair23@gmail.com, qemu-riscv@nongnu.org, Alistair Francis , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , atishp@rivosinc.com, dbarboza@ventanamicro.com, Alistair Francis , Thomas Huth Subject: [PATCH v4 2/2] hw/char: sifive_uart: Print uart characters async Date: Tue, 10 Sep 2024 14:54:19 +1000 Message-ID: <20240910045419.1252277-3-alistair.francis@wdc.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240910045419.1252277-1-alistair.francis@wdc.com> References: <20240910045419.1252277-1-alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=alistair23@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1725944149784116600 Content-Type: text/plain; charset="utf-8" The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped characters [1]. Let's update the SiFive UART to use a async sifive_uart_xmit() function to transmit the characters and apply back pressure to the guest with the SIFIVE_UART_TXFIFO_FULL status. This should avoid dropped characters and more realisticly model the hardware. 1: https://gitlab.com/qemu-project/qemu/-/issues/2114 Signed-off-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza Tested-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/char/sifive_uart.h | 16 +++++- hw/char/sifive_uart.c | 94 ++++++++++++++++++++++++++++++++--- 2 files changed, 102 insertions(+), 8 deletions(-) diff --git a/include/hw/char/sifive_uart.h b/include/hw/char/sifive_uart.h index 7f6c79f8bd..0846cf6218 100644 --- a/include/hw/char/sifive_uart.h +++ b/include/hw/char/sifive_uart.h @@ -24,6 +24,7 @@ #include "hw/qdev-properties.h" #include "hw/sysbus.h" #include "qom/object.h" +#include "qemu/fifo8.h" =20 enum { SIFIVE_UART_TXFIFO =3D 0, @@ -48,9 +49,13 @@ enum { SIFIVE_UART_IP_RXWM =3D 2 /* Receive watermark interrupt pendin= g */ }; =20 +#define SIFIVE_UART_TXFIFO_FULL 0x80000000 + #define SIFIVE_UART_GET_TXCNT(txctrl) ((txctrl >> 16) & 0x7) #define SIFIVE_UART_GET_RXCNT(rxctrl) ((rxctrl >> 16) & 0x7) + #define SIFIVE_UART_RX_FIFO_SIZE 8 +#define SIFIVE_UART_TX_FIFO_SIZE 8 =20 #define TYPE_SIFIVE_UART "riscv.sifive.uart" OBJECT_DECLARE_SIMPLE_TYPE(SiFiveUARTState, SIFIVE_UART) @@ -63,13 +68,20 @@ struct SiFiveUARTState { qemu_irq irq; MemoryRegion mmio; CharBackend chr; - uint8_t rx_fifo[SIFIVE_UART_RX_FIFO_SIZE]; - uint8_t rx_fifo_len; + + uint32_t txfifo; uint32_t ie; uint32_t ip; uint32_t txctrl; uint32_t rxctrl; uint32_t div; + + uint8_t rx_fifo[SIFIVE_UART_RX_FIFO_SIZE]; + uint8_t rx_fifo_len; + + Fifo8 tx_fifo; + + QEMUTimer *fifo_trigger_handle; }; =20 SiFiveUARTState *sifive_uart_create(MemoryRegion *address_space, hwaddr ba= se, diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index 7fc6787f69..16a70c7ad7 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -64,6 +64,71 @@ static void sifive_uart_update_irq(SiFiveUARTState *s) } } =20 +static gboolean sifive_uart_xmit(void *do_not_use, GIOCondition cond, + void *opaque) +{ + SiFiveUARTState *s =3D opaque; + int ret; + const uint8_t *characters; + uint32_t numptr =3D 0; + + /* instant drain the fifo when there's no back-end */ + if (!qemu_chr_fe_backend_connected(&s->chr)) { + fifo8_reset(&s->tx_fifo); + return G_SOURCE_REMOVE; + } + + if (fifo8_is_empty(&s->tx_fifo)) { + return G_SOURCE_REMOVE; + } + + /* Don't pop the FIFO in case the write fails */ + characters =3D fifo8_peek_bufptr(&s->tx_fifo, + fifo8_num_used(&s->tx_fifo), &numptr); + ret =3D qemu_chr_fe_write(&s->chr, characters, numptr); + + if (ret >=3D 0) { + /* We wrote the data, actually pop the fifo */ + fifo8_pop_bufptr(&s->tx_fifo, ret, NULL); + } + + if (!fifo8_is_empty(&s->tx_fifo)) { + guint r =3D qemu_chr_fe_add_watch(&s->chr, G_IO_OUT | G_IO_HUP, + sifive_uart_xmit, s); + if (!r) { + fifo8_reset(&s->tx_fifo); + return G_SOURCE_REMOVE; + } + } + + /* Clear the TX Full bit */ + if (!fifo8_is_full(&s->tx_fifo)) { + s->txfifo &=3D ~SIFIVE_UART_TXFIFO_FULL; + } + + sifive_uart_update_irq(s); + return G_SOURCE_REMOVE; +} + +static void sifive_uart_write_tx_fifo(SiFiveUARTState *s, const uint8_t *b= uf, + int size) +{ + uint64_t current_time =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); + + if (size > fifo8_num_free(&s->tx_fifo)) { + size =3D fifo8_num_free(&s->tx_fifo); + qemu_log_mask(LOG_GUEST_ERROR, "sifive_uart: TX FIFO overflow"); + } + + fifo8_push_all(&s->tx_fifo, buf, size); + + if (fifo8_is_full(&s->tx_fifo)) { + s->txfifo |=3D SIFIVE_UART_TXFIFO_FULL; + } + + timer_mod(s->fifo_trigger_handle, current_time + 100); +} + static uint64_t sifive_uart_read(void *opaque, hwaddr addr, unsigned int size) { @@ -82,7 +147,7 @@ sifive_uart_read(void *opaque, hwaddr addr, unsigned int= size) return 0x80000000; =20 case SIFIVE_UART_TXFIFO: - return 0; /* Should check tx fifo */ + return s->txfifo; case SIFIVE_UART_IE: return s->ie; case SIFIVE_UART_IP: @@ -106,12 +171,10 @@ sifive_uart_write(void *opaque, hwaddr addr, { SiFiveUARTState *s =3D opaque; uint32_t value =3D val64; - unsigned char ch =3D value; =20 switch (addr) { case SIFIVE_UART_TXFIFO: - qemu_chr_fe_write(&s->chr, &ch, 1); - sifive_uart_update_irq(s); + sifive_uart_write_tx_fifo(s, (uint8_t *) &value, 1); return; case SIFIVE_UART_IE: s->ie =3D val64; @@ -131,6 +194,13 @@ sifive_uart_write(void *opaque, hwaddr addr, __func__, (int)addr, (int)value); } =20 +static void fifo_trigger_update(void *opaque) +{ + SiFiveUARTState *s =3D opaque; + + sifive_uart_xmit(NULL, G_IO_OUT, s); +} + static const MemoryRegionOps sifive_uart_ops =3D { .read =3D sifive_uart_read, .write =3D sifive_uart_write, @@ -197,6 +267,9 @@ static void sifive_uart_realize(DeviceState *dev, Error= **errp) { SiFiveUARTState *s =3D SIFIVE_UART(dev); =20 + s->fifo_trigger_handle =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, + fifo_trigger_update, s); + qemu_chr_fe_set_handlers(&s->chr, sifive_uart_can_rx, sifive_uart_rx, sifive_uart_event, sifive_uart_be_change, s, NULL, true); @@ -206,12 +279,18 @@ static void sifive_uart_realize(DeviceState *dev, Err= or **errp) static void sifive_uart_reset_enter(Object *obj, ResetType type) { SiFiveUARTState *s =3D SIFIVE_UART(obj); + + s->txfifo =3D 0; s->ie =3D 0; s->ip =3D 0; s->txctrl =3D 0; s->rxctrl =3D 0; s->div =3D 0; + s->rx_fifo_len =3D 0; + + memset(s->rx_fifo, 0, SIFIVE_UART_RX_FIFO_SIZE); + fifo8_create(&s->tx_fifo, SIFIVE_UART_TX_FIFO_SIZE); } =20 static void sifive_uart_reset_hold(Object *obj, ResetType type) @@ -222,8 +301,8 @@ static void sifive_uart_reset_hold(Object *obj, ResetTy= pe type) =20 static const VMStateDescription vmstate_sifive_uart =3D { .name =3D TYPE_SIFIVE_UART, - .version_id =3D 1, - .minimum_version_id =3D 1, + .version_id =3D 2, + .minimum_version_id =3D 2, .fields =3D (const VMStateField[]) { VMSTATE_UINT8_ARRAY(rx_fifo, SiFiveUARTState, SIFIVE_UART_RX_FIFO_SIZE), @@ -233,6 +312,9 @@ static const VMStateDescription vmstate_sifive_uart =3D= { VMSTATE_UINT32(txctrl, SiFiveUARTState), VMSTATE_UINT32(rxctrl, SiFiveUARTState), VMSTATE_UINT32(div, SiFiveUARTState), + VMSTATE_UINT32(txfifo, SiFiveUARTState), + VMSTATE_FIFO8(tx_fifo, SiFiveUARTState), + VMSTATE_TIMER_PTR(fifo_trigger_handle, SiFiveUARTState), VMSTATE_END_OF_LIST() }, }; --=20 2.46.0