From nobody Sun Nov 24 04:24:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=linaro.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1725534746720147.24621732839898; Thu, 5 Sep 2024 04:12:26 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 73410162E; Thu, 5 Sep 2024 07:12:25 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 2C3B115F2; Thu, 5 Sep 2024 07:12:04 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 97289155C; Thu, 5 Sep 2024 07:12:01 -0400 (EDT) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 40276155F for ; Thu, 5 Sep 2024 07:12:00 -0400 (EDT) Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a86a37208b2so98793666b.0 for ; Thu, 05 Sep 2024 04:12:00 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8a6236d164sm120320466b.111.2024.09.05.04.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2024 04:11:57 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 1CB4B5F8BA; Thu, 5 Sep 2024 12:11:57 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1725534719; x=1726139519; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=b417LV8FGVx5zaVIcJGwBkFTzJWOlPL6Soqk2rPRDSI=; b=xeBjY2VoN2xCjBm55Lcmyp5N8xwxTVnFyMu0F0L0+fdqXyj+1G1/EAe0hVnmP5j3kj kaespQuKXI34mkiqIRK4GSAljRiE8/BU1ICDe0gAxSZIpTa6QfmstbnRxp2KBrONCyRc vwmyrdSe+l335IEQAxd4PQ4Nm0hVRmu7fm5r3E8z0d4uqw/EGISgOkCfQVSE99C5xB+k A+YbgZXUmGzR1AJWQXfRjjQ5Stoam/pSzVlFMTwo+kKGqHfGDM85EdllFc/Vtbt+tqHd AUsJIWkiskyxvUFQ4JwmyZCX7Eqwh+cJ13xfn4dsuYs3n2quZiU+xexwNNg7MGKhDZOE cCkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725534719; x=1726139519; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b417LV8FGVx5zaVIcJGwBkFTzJWOlPL6Soqk2rPRDSI=; b=xB9QbXbcDK4OuD2sEghZyJ+nFqdyftKV7+snvxfAlS5TlG76YOWlQLPtKTm3Wbnq2m Ygx1nP95/G1sGQVp5HN8z0wXn5DBBwptG/lNZYtLQmth8WmpKBAYWCE5HwGb3H5p4vVN 0ldts183UqkvTkNtPiC2qs78CLfe4Y8l3SLr6fVzWaKJQ5Wsey7tC+lE+TmHkdMfxkyc pEsBuu0hv7GtNHdudsAf3iY/DaFtj6jLxjmCS7lNIybbFPlpyM2EXqabfUhyP4j5pQw3 2KHZHQ8qZF2u3Q3m//BhJ+piB6dDCQfUr2ueGOykuzBH1YtMuHIeDgfqB2EowlP6BkzD jubg== X-Forwarded-Encrypted: i=1; AJvYcCVkDZJ6cQBhWgN4QNAgXLWAGHt6kG7C1qL/tFdwNluEw2L4ts+I70rLN9bFvQmXIPEdJVGEhQ==@lists.libvirt.org X-Gm-Message-State: AOJu0YzJOL4SK9TSrS33fNJnhdsa6waByLHbrphhcp54jD7XATnqu23U qnUpdK1pJhv5mEqjoVEGUndxuS6/0uMRgRHH3yRYAPlJGCYtPJT3C8lIOShbY60= X-Google-Smtp-Source: AGHT+IEeQIs1vsHHsmoMsrHPSI1h8y2kIou4QPh9fWLXUEcd0S3XirML9B3WSyLLFMpAd9/I3RRUZg== X-Received: by 2002:a17:907:9725:b0:a88:b90a:ff30 with SMTP id a640c23a62f3a-a897fa74dbcmr1825424666b.50.1725534718385; Thu, 05 Sep 2024 04:11:58 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [RFC PATCH] deprecation: don't enable TCG plugins by default on 32 bit hosts Date: Thu, 5 Sep 2024 12:11:53 +0100 Message-Id: <20240905111153.786500-1-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 4XDZM74ZZXPH73U6HRMUJKJIDQJFQCTY X-Message-ID-Hash: 4XDZM74ZZXPH73U6HRMUJKJIDQJFQCTY X-MailFrom: alex.bennee@linaro.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0 CC: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , Thomas Huth , "reviewer:Incompatible changes" X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1725534749514116600 Content-Type: text/plain; charset="utf-8" The existing plugins already liberally use host pointer stuffing for passing user data which will fail when doing 64 bit guests on 32 bit hosts. We should discourage this by officially deprecating support and adding another nail to the 32 bit host coffin. Signed-off-by: Alex Benn=C3=A9e --- docs/about/deprecated.rst | 11 +++++++++++ configure | 11 ++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 88f0f03786..8a4e249717 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -184,6 +184,17 @@ be an effective use of its limited resources, and thus= intends to discontinue it. Since all recent x86 hardware from the past >10 years is capable of the 64-bit x86 extensions, a corresponding 64-bit OS should be used instead. =20 +TCG Plugin support not enabled by default on 32-bit hosts (since 9.2) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +While it is still possible to enable TCG plugin support for 32-bit +hosts there are a number of potential pitfalls when instrumenting +64-bit guests. The plugin APIs typically pass most addresses as +uint64_t but practices like encoding that address in a host pointer +for passing as user-data will loose data. As most software analysis +benefits from having plenty of host memory it seems reasonable to +encourage users to use 64 bit builds of QEMU for analysis work +whatever targets they are instrumenting. =20 System emulator CPUs -------------------- diff --git a/configure b/configure index d08b71f14b..8acb311527 100755 --- a/configure +++ b/configure @@ -424,6 +424,7 @@ fi # Note that this case should only have supported host CPUs, not guests. # Please keep it sorted and synchronized with meson.build's host_arch. host_arch=3D +host_bits=3D64 linux_arch=3D case "$cpu" in aarch64) @@ -434,12 +435,14 @@ case "$cpu" in armv*b|armv*l|arm) cpu=3Darm host_arch=3Darm + host_bits=3D32 linux_arch=3Darm ;; =20 i386|i486|i586|i686) cpu=3D"i386" host_arch=3Di386 + host_bits=3D32 linux_arch=3Dx86 CPU_CFLAGS=3D"-m32" ;; @@ -458,11 +461,13 @@ case "$cpu" in mips*) cpu=3Dmips host_arch=3Dmips + host_bits=3D32 linux_arch=3Dmips ;; =20 ppc) host_arch=3Dppc + host_bits=3D32 linux_arch=3Dpowerpc CPU_CFLAGS=3D"-m32" ;; @@ -480,11 +485,13 @@ case "$cpu" in =20 riscv32 | riscv64) host_arch=3Driscv + host_bits=3D32 linux_arch=3Driscv ;; =20 s390) linux_arch=3Ds390 + host_bits=3D32 CPU_CFLAGS=3D"-m31" ;; s390x) @@ -495,6 +502,7 @@ case "$cpu" in =20 sparc|sun4[cdmuv]) cpu=3Dsparc + host_bits=3D32 CPU_CFLAGS=3D"-m32 -mv8plus -mcpu=3Dultrasparc" ;; sparc64) @@ -505,6 +513,7 @@ case "$cpu" in x32) cpu=3D"x86_64" host_arch=3Dx86_64 + host_bits=3D32 linux_arch=3Dx86 CPU_CFLAGS=3D"-mx32" ;; @@ -1028,7 +1037,7 @@ if test "$static" =3D "yes" ; then fi plugins=3D"no" fi -if test "$plugins" !=3D "no"; then +if test "$plugins" !=3D "no" && test host_bits =3D 64; then plugins=3Dyes subdirs=3D"$subdirs contrib/plugins" fi --=20 2.39.2