From nobody Sun Nov 24 08:04:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1725365925; cv=none; d=zohomail.com; s=zohoarc; b=DkxepeheUgQgaHDKTPIjDmnUbKMJ2S727kDPRv2MQD0yfQ0/uH34RxjcR2LUqsE0JQVuKV9Fi8h2/lH46RQ4akXhBXbJl53li0sXs7EU8W8xozEdN5BBrCrv9mZa7BXmfyTn6dE9E4VKDd79H+Ae8Tvy+MzyApfx8Z1/xULHPck= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1725365925; h=Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=pbn98pDookGBOMEgjMFvFxlB9fzdz6bxbkPPyk8nZqM=; b=J9RWIcQWP7ru968wL5KqGtP67hnjQJpk64XNEUYdZeUIJRuhihvE1jBM0byXp9VtC1C0o0ht2s/Z5u5p+EpgiU9n7/XD7PPwkeSrLVg1/2l4emzKpMWO2fs7FX3exbXjOYn7yQJxfnYOGhGJ3ajo4zn6ke0A3h9vzsxRaDc7BmE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1725365925280270.16364800545716; Tue, 3 Sep 2024 05:18:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1slS0c-0001Ao-Lu; Tue, 03 Sep 2024 07:47:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slS0W-0000nn-Vs for qemu-devel@nongnu.org; Tue, 03 Sep 2024 07:47:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1slS0U-0007cz-Sb for qemu-devel@nongnu.org; Tue, 03 Sep 2024 07:47:36 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-H9KocZ5mO2u3OD4kIZSlSA-1; Tue, 03 Sep 2024 07:47:32 -0400 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E42F91954B1C; Tue, 3 Sep 2024 11:47:30 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.86]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8722D1955BE1; Tue, 3 Sep 2024 11:47:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725364053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pbn98pDookGBOMEgjMFvFxlB9fzdz6bxbkPPyk8nZqM=; b=h9idH0w8sik6iMDsZAfsgCYRAWnxyph13EdmtaPpasM8RPTxjFO5ZoJPV8cfNkRNayvos/ J9R0zPkB9Fcz99J7KwljhBYsxB2VD32TxgHKAyjx30FDDwhL4vd2weTtYlJ8qFwrhq9ukA dyAaAMG8+ezrsnd+WRI45exbmwCKaAk= X-MC-Unique: H9KocZ5mO2u3OD4kIZSlSA-1 From: Thomas Huth To: Peter Xu , Fabiano Rosas , qemu-devel@nongnu.org Subject: [PATCH] tests/qtest/migration: Add a check for the availability of the "pc" machine Date: Tue, 3 Sep 2024 13:47:26 +0200 Message-ID: <20240903114726.199881-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.142, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1725365927357116600 Content-Type: text/plain; charset="utf-8" The test_vcpu_dirty_limit is the only test that does not check for the availability of the machine before starting the test, so it fails when QEMU has been configured with --without-default-devices. Add a check for the "pc" machine type to fix it. Signed-off-by: Thomas Huth Reviewed-by: Fabiano Rosas --- tests/qtest/migration-test.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 6c06100d91..8fee18dfbe 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -4026,8 +4026,10 @@ int main(int argc, char **argv) if (g_str_equal(arch, "x86_64") && has_kvm && kvm_dirty_ring_supported= ()) { migration_test_add("/migration/dirty_ring", test_precopy_unix_dirty_ring); - migration_test_add("/migration/vcpu_dirty_limit", - test_vcpu_dirty_limit); + if (qtest_has_machine("pc")) { + migration_test_add("/migration/vcpu_dirty_limit", + test_vcpu_dirty_limit); + } } =20 ret =3D g_test_run(); --=20 2.46.0