From nobody Sun Nov 24 08:46:28 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1723626387; cv=none; d=zohomail.com; s=zohoarc; b=bbPUCNf7MB51GB3D8EVouVkWv3Ku9cJTpoVAfWsiBhPALJjDalQobygRnUhCsVRMIFnNFtcOnUTiyfxJLldMRIdezqBYrW8EtMaQnkCP/aZWPUGByh51x2CUaEEzkDuvcIQUS/jhaBuK7FK2grL61yZGDqiPrs0WBhNEQzVnZcM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1723626387; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dAH/j84FY7Wc+VtBJ3ycwmQeODrkvSqYKa9+WHsM3SI=; b=cUejrtOrott7F22l6UYVECXba0mMwG8imzYZjQDkLtpYdK27MpnL6S4R5X/RsURi3sfFVhbY+ZyrpMjIJlKsUVMRxwPYHWIJGDQZdWqUbgfynpVk4M9UswN+uV2f83VXZZHCBvyKqsOK4T6jAXTUkz+tYms29uRa+YG2wgNGh/g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1723626387603895.2950657578477; Wed, 14 Aug 2024 02:06:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1se9xP-0004E3-UJ; Wed, 14 Aug 2024 05:06:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se9xM-0004BO-GX for qemu-devel@nongnu.org; Wed, 14 Aug 2024 05:06:12 -0400 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1se9xH-0000lO-Vb for qemu-devel@nongnu.org; Wed, 14 Aug 2024 05:06:10 -0400 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5b01af9b0c9so6706988a12.3 for ; Wed, 14 Aug 2024 02:06:07 -0700 (PDT) Received: from localhost.localdomain (124.170.88.92.rev.sfr.net. [92.88.170.124]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bd1a5dfc9fsm3662421a12.66.2024.08.14.02.05.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 14 Aug 2024 02:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723626365; x=1724231165; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dAH/j84FY7Wc+VtBJ3ycwmQeODrkvSqYKa9+WHsM3SI=; b=sDxjV0XZbxz4Aez71ZWat00sB7pTQ/bsAZsmKAluz0mkR1meVXHWYQh/C8d+BqNr0g dvgyYXDNJ38c1lJ3LLxU0HxPAxo8siUBLKmkXx6n3duL7uLKDAU7MXwomt0bwaRIMTHi kw3TbkvlHjeedyBez5n6SIvriRrvYrMW/iszCoOp77rMQqJ1qXZ5v6vnRZ09Yo0dv4GZ MmkRXMCXuncT0AxeYLrR/FCqGi/gQnul7h/nzu9/NO8OYvJVqn+vjP72WceMt99pXN7i TtLw/yic9SnjfHLNMaHq/hBlJ4FtBgmRL0IbmpTAK9PfPKN1an9KaaJdc4IitMxvq24P EGnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723626365; x=1724231165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dAH/j84FY7Wc+VtBJ3ycwmQeODrkvSqYKa9+WHsM3SI=; b=W6susaT4fbQ5VQ2BopRQy6kjhu1LwTYjOhh9dBNcz/Ui408jQyHELq15WGLYoicL17 /ux40gucNmXpA2HDPioIIjNGUOfBinJfhUvRgB4dOS87viP6IC2BKL8SxYpeyNu+VriQ dEMV+KIuZvQTieCJNx3qWpO9WVfWPu+KhS/QegDizrJZKERZNbLN8oYyNeJgHvp5ZvyE L4oDxtfAAYnAKvh0Nb1AKPZJPyIrt3XXBlJv3z2jIb6ByqOecdLb3vFgBcJGsrx8uFZr tb85bsAxckum/dnRqO3fw17hfDN+ywmurjYGk392mw5xEekRw3TYYejMwOcFMJeHrsrL GHng== X-Gm-Message-State: AOJu0YwW8tRWUWhWwER6izNrLd3Qog5W7eS5PR23u/0oEP+KVXuaXI0X oKrGd+IF/1i8R0KkVE2q69N5OnNCX76paspYakdT7Pf9+92faXMnh2kW5TvbHNvpc2T1f62dZid BtBQ= X-Google-Smtp-Source: AGHT+IEhCBqE5I6mkt89E/BFuyeApctM8sWjPK7edK9H7MJabMjMd0J5tbp2KVb0FTf/6cXxga8x8g== X-Received: by 2002:a05:6402:11c6:b0:5a3:27bd:e264 with SMTP id 4fb4d7f45d1cf-5bea1c7724amr1791774a12.9.1723626364643; Wed, 14 Aug 2024 02:06:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Richard Henderson , Thomas Petazzoni , Waldemar Brodkorb , Aleksandar Rikalo , Jiaxun Yang Subject: [PATCH-for-9.1 v4 1/3] target/mips: Pass page table entry size as MemOp to get_pte() Date: Wed, 14 Aug 2024 11:04:50 +0200 Message-ID: <20240814090452.2591-2-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240814090452.2591-1-philmd@linaro.org> References: <20240814090452.2591-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::533; envelope-from=philmd@linaro.org; helo=mail-ed1-x533.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1723626389566116600 In order to simplify the next commit, pass the PTE size as MemOp. Rename: native_shift -> native_op directory_shift -> directory_mop leaf_shift -> leaf_mop Suggested-by: Richard Henderson Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/sysemu/tlb_helper.c | 58 ++++++++++++++--------------- 1 file changed, 27 insertions(+), 31 deletions(-) diff --git a/target/mips/tcg/sysemu/tlb_helper.c b/target/mips/tcg/sysemu/t= lb_helper.c index 3ba6d369a6..60147ba0af 100644 --- a/target/mips/tcg/sysemu/tlb_helper.c +++ b/target/mips/tcg/sysemu/tlb_helper.c @@ -592,13 +592,13 @@ static void raise_mmu_exception(CPUMIPSState *env, ta= rget_ulong address, * resulting in a TLB or XTLB Refill exception. */ =20 -static bool get_pte(CPUMIPSState *env, uint64_t vaddr, int entry_size, +static bool get_pte(CPUMIPSState *env, uint64_t vaddr, MemOp op, uint64_t *pte) { - if ((vaddr & ((entry_size >> 3) - 1)) !=3D 0) { + if ((vaddr & (memop_size(op) - 1)) !=3D 0) { return false; } - if (entry_size =3D=3D 64) { + if (op =3D=3D MO_64) { *pte =3D cpu_ldq_code(env, vaddr); } else { *pte =3D cpu_ldl_code(env, vaddr); @@ -607,8 +607,9 @@ static bool get_pte(CPUMIPSState *env, uint64_t vaddr, = int entry_size, } =20 static uint64_t get_tlb_entry_layout(CPUMIPSState *env, uint64_t entry, - int entry_size, int ptei) + MemOp op, int ptei) { + unsigned entry_size =3D memop_size(op) << 3; uint64_t result =3D entry; uint64_t rixi; if (ptei > entry_size) { @@ -624,14 +625,12 @@ static uint64_t get_tlb_entry_layout(CPUMIPSState *en= v, uint64_t entry, static int walk_directory(CPUMIPSState *env, uint64_t *vaddr, int directory_index, bool *huge_page, bool *hgpg_directory_hit, uint64_t *pw_entrylo0, uint64_t *pw_entrylo1, - unsigned directory_shift, unsigned leaf_shift, int ptw_mmu_idx) + MemOp directory_mop, MemOp leaf_mop, int ptw_mmu_idx) { int dph =3D (env->CP0_PWCtl >> CP0PC_DPH) & 0x1; int psn =3D (env->CP0_PWCtl >> CP0PC_PSN) & 0x3F; int hugepg =3D (env->CP0_PWCtl >> CP0PC_HUGEPG) & 0x1; int pf_ptew =3D (env->CP0_PWField >> CP0PF_PTEW) & 0x3F; - uint32_t direntry_size =3D 1 << (directory_shift + 3); - uint32_t leafentry_size =3D 1 << (leaf_shift + 3); uint64_t entry; uint64_t paddr; int prot; @@ -643,14 +642,14 @@ static int walk_directory(CPUMIPSState *env, uint64_t= *vaddr, /* wrong base address */ return 0; } - if (!get_pte(env, *vaddr, direntry_size, &entry)) { + if (!get_pte(env, *vaddr, directory_mop, &entry)) { return 0; } =20 if ((entry & (1 << psn)) && hugepg) { *huge_page =3D true; *hgpg_directory_hit =3D true; - entry =3D get_tlb_entry_layout(env, entry, leafentry_size, pf_ptew= ); + entry =3D get_tlb_entry_layout(env, entry, leaf_mop, pf_ptew); w =3D directory_index - 1; if (directory_index & 0x1) { /* Generate adjacent page from same PTE for odd TLB page */ @@ -658,7 +657,7 @@ static int walk_directory(CPUMIPSState *env, uint64_t *= vaddr, *pw_entrylo0 =3D entry & ~lsb; /* even page */ *pw_entrylo1 =3D entry | lsb; /* odd page */ } else if (dph) { - int oddpagebit =3D 1 << leaf_shift; + int oddpagebit =3D 1 << leaf_mop; uint64_t vaddr2 =3D *vaddr ^ oddpagebit; if (*vaddr & oddpagebit) { *pw_entrylo1 =3D entry; @@ -669,10 +668,10 @@ static int walk_directory(CPUMIPSState *env, uint64_t= *vaddr, ptw_mmu_idx) !=3D TLBRET_MATCH) { return 0; } - if (!get_pte(env, vaddr2, leafentry_size, &entry)) { + if (!get_pte(env, vaddr2, leaf_mop, &entry)) { return 0; } - entry =3D get_tlb_entry_layout(env, entry, leafentry_size, pf_= ptew); + entry =3D get_tlb_entry_layout(env, entry, leaf_mop, pf_ptew); if (*vaddr & oddpagebit) { *pw_entrylo0 =3D entry; } else { @@ -711,7 +710,7 @@ static bool page_table_walk_refill(CPUMIPSState *env, v= addr address, =20 /* Native pointer size */ /*For the 32-bit architectures, this bit is fixed to 0.*/ - int native_shift =3D (((env->CP0_PWSize >> CP0PS_PS) & 1) =3D=3D 0) ? = 2 : 3; + MemOp native_op =3D (((env->CP0_PWSize >> CP0PS_PS) & 1) =3D=3D 0) ? M= O_32 : MO_64; =20 /* Indices from PWField */ int pf_gdw =3D (env->CP0_PWField >> CP0PF_GDW) & 0x3F; @@ -728,11 +727,10 @@ static bool page_table_walk_refill(CPUMIPSState *env,= vaddr address, =20 /* Other HTW configs */ int hugepg =3D (env->CP0_PWCtl >> CP0PC_HUGEPG) & 0x1; - unsigned directory_shift, leaf_shift; + MemOp directory_mop, leaf_mop; =20 /* Offsets into tables */ unsigned goffset, uoffset, moffset, ptoffset0, ptoffset1; - uint32_t leafentry_size; =20 /* Starting address - Page Table Base */ uint64_t vaddr =3D env->CP0_PWBase; @@ -759,23 +757,21 @@ static bool page_table_walk_refill(CPUMIPSState *env,= vaddr address, } =20 /* HTW Shift values (depend on entry size) */ - directory_shift =3D (hugepg && (ptew =3D=3D 1)) ? native_shift + 1 : n= ative_shift; - leaf_shift =3D (ptew =3D=3D 1) ? native_shift + 1 : native_shift; + directory_mop =3D (hugepg && (ptew =3D=3D 1)) ? native_op + 1 : native= _op; + leaf_mop =3D (ptew =3D=3D 1) ? native_op + 1 : native_op; =20 - goffset =3D gindex << directory_shift; - uoffset =3D uindex << directory_shift; - moffset =3D mindex << directory_shift; - ptoffset0 =3D (ptindex >> 1) << (leaf_shift + 1); - ptoffset1 =3D ptoffset0 | (1 << (leaf_shift)); - - leafentry_size =3D 1 << (leaf_shift + 3); + goffset =3D gindex << directory_mop; + uoffset =3D uindex << directory_mop; + moffset =3D mindex << directory_mop; + ptoffset0 =3D (ptindex >> 1) << (leaf_mop + 1); + ptoffset1 =3D ptoffset0 | (1 << (leaf_mop)); =20 /* Global Directory */ if (gdw > 0) { vaddr |=3D goffset; switch (walk_directory(env, &vaddr, pf_gdw, &huge_page, &hgpg_gdhi= t, &pw_entrylo0, &pw_entrylo1, - directory_shift, leaf_shift, ptw_mmu_idx)) + directory_mop, leaf_mop, ptw_mmu_idx)) { case 0: return false; @@ -792,7 +788,7 @@ static bool page_table_walk_refill(CPUMIPSState *env, v= addr address, vaddr |=3D uoffset; switch (walk_directory(env, &vaddr, pf_udw, &huge_page, &hgpg_udhi= t, &pw_entrylo0, &pw_entrylo1, - directory_shift, leaf_shift, ptw_mmu_idx)) + directory_mop, leaf_mop, ptw_mmu_idx)) { case 0: return false; @@ -809,7 +805,7 @@ static bool page_table_walk_refill(CPUMIPSState *env, v= addr address, vaddr |=3D moffset; switch (walk_directory(env, &vaddr, pf_mdw, &huge_page, &hgpg_mdhi= t, &pw_entrylo0, &pw_entrylo1, - directory_shift, leaf_shift, ptw_mmu_idx)) + directory_mop, leaf_mop, ptw_mmu_idx)) { case 0: return false; @@ -827,10 +823,10 @@ static bool page_table_walk_refill(CPUMIPSState *env,= vaddr address, ptw_mmu_idx) !=3D TLBRET_MATCH) { return false; } - if (!get_pte(env, vaddr, leafentry_size, &dir_entry)) { + if (!get_pte(env, vaddr, leaf_mop, &dir_entry)) { return false; } - dir_entry =3D get_tlb_entry_layout(env, dir_entry, leafentry_size, pf_= ptew); + dir_entry =3D get_tlb_entry_layout(env, dir_entry, leaf_mop, pf_ptew); pw_entrylo0 =3D dir_entry; =20 /* Leaf Level Page Table - Second half of PTE pair */ @@ -839,10 +835,10 @@ static bool page_table_walk_refill(CPUMIPSState *env,= vaddr address, ptw_mmu_idx) !=3D TLBRET_MATCH) { return false; } - if (!get_pte(env, vaddr, leafentry_size, &dir_entry)) { + if (!get_pte(env, vaddr, leaf_mop, &dir_entry)) { return false; } - dir_entry =3D get_tlb_entry_layout(env, dir_entry, leafentry_size, pf_= ptew); + dir_entry =3D get_tlb_entry_layout(env, dir_entry, leaf_mop, pf_ptew); pw_entrylo1 =3D dir_entry; =20 refill: --=20 2.45.2 From nobody Sun Nov 24 08:46:28 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1723626407; cv=none; d=zohomail.com; s=zohoarc; b=Yk3uIPtNyeQ07lrJiZglIQlTJ5vzc5bCZhL2PMl1Gw5uegCPSEakn5VYppPlQOTmt37fQtlmMoPzl4IHDAxpUr66PxbgcDAPPLCyIuvhUSUzfDeYI0qIUtuBwLASod0p/DhgZBEqdZqhkIE2to5eVqlIA3aQnTS7l4EXT8EhOdc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1723626407; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KKHnEDZFkWOqzMoUUCQs4Gmx/1ICFTXsIFwtO9oeg58=; b=UYwTQhuyIhkB/Z7h03SUXCC8kQfCAeybRM6xHqr+R//xum9KLj/deBrp4qwoAT+/bGixdDAUYXL9s7SzqhRaaD0AzBWsm5eK1ZWDXvzkmrTi4Jfe0/ezdi6yQpvqv1lA5LaA4nSGUu7YUKoJVgoVQrKjRmHp0uvuysB3cpYX/Cc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1723626407099139.44402266088503; Wed, 14 Aug 2024 02:06:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1se9xc-0004zV-R8; Wed, 14 Aug 2024 05:06:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se9xb-0004oA-Df for qemu-devel@nongnu.org; Wed, 14 Aug 2024 05:06:27 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1se9xZ-0000of-Io for qemu-devel@nongnu.org; Wed, 14 Aug 2024 05:06:27 -0400 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a7a83a968ddso642481366b.0 for ; Wed, 14 Aug 2024 02:06:25 -0700 (PDT) Received: from localhost.localdomain (124.170.88.92.rev.sfr.net. [92.88.170.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f414f06bsm145948166b.159.2024.08.14.02.06.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 14 Aug 2024 02:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723626380; x=1724231180; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KKHnEDZFkWOqzMoUUCQs4Gmx/1ICFTXsIFwtO9oeg58=; b=FHck7vWffXFyNSg5W1peTmr8pBEEfnTYpIqN9sndq41T8eCvZnLBR3TqCRIymdlP1S 9SuQxQNoi/XcBUwyuTUjJCJcKwhsNCXUPyfkcUiOcimPY23B5Ijh6CFfyNtztzPlnymT 5XieCruYBCgF5lmz4DCecqZ8x6a/mYzc06nn+n1YqDA/S8It9XQKXeC0BF6nGQ5SBGo9 O7jKLQkFr7bs7YhYayViMzzRzgqWAYn6KSKqVnl7vxzgMZPoMOpmUyg1hIJ4pIMlddMf aDmNAW2R7wUjTQp9f2Y6B9omqtpdI8iYB0mh18MWwk+IWXBWExtM8VGqsl1Pxt1HAnnk aloA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723626380; x=1724231180; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KKHnEDZFkWOqzMoUUCQs4Gmx/1ICFTXsIFwtO9oeg58=; b=wFuykThEg3QskKYl58lgmfHBDe5nqqZApQ78pIB0fxHNgJ5d5BrePUENhmHtGhRnwr uL5Wo2o0F772wKDSleRhW59HywV2sq8vjaKYuxJ26r7TVlK/BXVJCMvcw/F7IPhRLjD1 aCP25OKoksv4Sfjtvf4ZJPRcUsUVVWzDCZiL9ZF+b6r3/csom0k05r7gg0l2gy+BfgDv 6qf8fuxjNIKZorlgerSmuZZ0QssmQ1CtBsIJCsP1YtAaEIrW4FXteZZsHCuTwrekK/u6 0eyRiyKVL/ql+tosj78OS/oNZGbHJkiEZ8MdBwlH1J9VBRkY8ofYywiTUip/75zOV0Cm kaTA== X-Gm-Message-State: AOJu0YzZ7Iublm6RcyBg2x9R53xYNQkeLyYAcmCFdYwSF1GiW8HMp+JP uaErmkDBNiR04wrt0aasF3nUIezHrTyJwIZ3sGZYUytzG6FBI3S83ijMS6nxRPf9/lDQZc4qUUF HkIM= X-Google-Smtp-Source: AGHT+IGxB+22R0Ln8KkhLOLQsrx487K4X1eS/M2nIVp2u9luJn4SJPjSdV4aFwtEhAj4D9CCKyiNAQ== X-Received: by 2002:a17:907:1b0d:b0:a77:c30c:341 with SMTP id a640c23a62f3a-a83663fa418mr137716866b.0.1723626379702; Wed, 14 Aug 2024 02:06:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Richard Henderson , Thomas Petazzoni , Waldemar Brodkorb , Aleksandar Rikalo , Jiaxun Yang Subject: [PATCH-for-9.1 v4 2/3] target/mips: Use correct MMU index in get_pte() Date: Wed, 14 Aug 2024 11:04:51 +0200 Message-ID: <20240814090452.2591-3-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240814090452.2591-1-philmd@linaro.org> References: <20240814090452.2591-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=philmd@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1723626407401116600 When refactoring page_table_walk_refill() in commit 4e999bf419 we missed the indirect call to cpu_mmu_index() in get_pte(): page_table_walk_refill() -> get_pte() -> cpu_ld[lq]_code() -> cpu_mmu_index() Since we don't mask anymore the modes in hflags, cpu_mmu_index() can return UM or SM, while we only expect KM or ERL. Fix by propagating ptw_mmu_idx to get_pte(), and use the cpu_ld/st_code_mmu() API with the correct MemOpIdx. Reported-by: Thomas Petazzoni Reported-by: Waldemar Brodkorb Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2470 Fixes: 4e999bf419 ("target/mips: Pass ptw_mmu_idx down from mips_cpu_tlb_fi= ll") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/sysemu/tlb_helper.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/target/mips/tcg/sysemu/tlb_helper.c b/target/mips/tcg/sysemu/t= lb_helper.c index 60147ba0af..0e94e00a5f 100644 --- a/target/mips/tcg/sysemu/tlb_helper.c +++ b/target/mips/tcg/sysemu/tlb_helper.c @@ -593,16 +593,21 @@ static void raise_mmu_exception(CPUMIPSState *env, ta= rget_ulong address, */ =20 static bool get_pte(CPUMIPSState *env, uint64_t vaddr, MemOp op, - uint64_t *pte) + uint64_t *pte, unsigned ptw_mmu_idx) { + MemOpIdx oi; + if ((vaddr & (memop_size(op) - 1)) !=3D 0) { return false; } + + oi =3D make_memop_idx(op | MO_TE, ptw_mmu_idx); if (op =3D=3D MO_64) { - *pte =3D cpu_ldq_code(env, vaddr); + *pte =3D cpu_ldq_code_mmu(env, vaddr, oi, 0); } else { - *pte =3D cpu_ldl_code(env, vaddr); + *pte =3D cpu_ldl_code_mmu(env, vaddr, oi, 0); } + return true; } =20 @@ -642,7 +647,7 @@ static int walk_directory(CPUMIPSState *env, uint64_t *= vaddr, /* wrong base address */ return 0; } - if (!get_pte(env, *vaddr, directory_mop, &entry)) { + if (!get_pte(env, *vaddr, directory_mop, &entry, ptw_mmu_idx)) { return 0; } =20 @@ -668,7 +673,7 @@ static int walk_directory(CPUMIPSState *env, uint64_t *= vaddr, ptw_mmu_idx) !=3D TLBRET_MATCH) { return 0; } - if (!get_pte(env, vaddr2, leaf_mop, &entry)) { + if (!get_pte(env, vaddr2, leaf_mop, &entry, ptw_mmu_idx)) { return 0; } entry =3D get_tlb_entry_layout(env, entry, leaf_mop, pf_ptew); @@ -823,7 +828,7 @@ static bool page_table_walk_refill(CPUMIPSState *env, v= addr address, ptw_mmu_idx) !=3D TLBRET_MATCH) { return false; } - if (!get_pte(env, vaddr, leaf_mop, &dir_entry)) { + if (!get_pte(env, vaddr, leaf_mop, &dir_entry, ptw_mmu_idx)) { return false; } dir_entry =3D get_tlb_entry_layout(env, dir_entry, leaf_mop, pf_ptew); @@ -835,7 +840,7 @@ static bool page_table_walk_refill(CPUMIPSState *env, v= addr address, ptw_mmu_idx) !=3D TLBRET_MATCH) { return false; } - if (!get_pte(env, vaddr, leaf_mop, &dir_entry)) { + if (!get_pte(env, vaddr, leaf_mop, &dir_entry, ptw_mmu_idx)) { return false; } dir_entry =3D get_tlb_entry_layout(env, dir_entry, leaf_mop, pf_ptew); --=20 2.45.2 From nobody Sun Nov 24 08:46:28 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1723626409; cv=none; d=zohomail.com; s=zohoarc; b=NZEegLT137QHafkmEqBzxa+7kF5Ao0I8SknVQhh+OcWnqmyYTHUecxT+bkO6uMYYP/x8mAE4e6rYNeUlNk7Qh3qAXyTt7JXN8jlQ/07t3a3WI3BRxxxmFdOGbRDn9Ka89bRanGX2pGJF93WL5/O996PFDN0+juXIS9isrFm1qoo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1723626409; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2c0XRHjU0y3cm6Z6eyIislTDkEC9zABvUTWrSeWCGjw=; b=Mhbz9HTNiDcmCaiy7STTPuO7/9YZRL8mZlpndu9ThwjwD40Ip7h34P1aI7g1FmtYIrLy++Q8QF1XuXigFt+zKZ7n/8gLNfsMsNpksmRZi+QsNcpD1/dq2Q0ig4uIRod9Qk6YKxiRvF/KZPaMRbajau88ouOY44jfOyGDC3E3fW0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1723626409635351.2843117053611; Wed, 14 Aug 2024 02:06:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1se9xr-0006mI-Lj; Wed, 14 Aug 2024 05:06:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1se9xn-0006Ng-Gk for qemu-devel@nongnu.org; Wed, 14 Aug 2024 05:06:41 -0400 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1se9xl-0000rl-Lj for qemu-devel@nongnu.org; Wed, 14 Aug 2024 05:06:39 -0400 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a7a8e73b29cso598502266b.3 for ; Wed, 14 Aug 2024 02:06:37 -0700 (PDT) Received: from localhost.localdomain (124.170.88.92.rev.sfr.net. [92.88.170.124]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f414e561sm145162166b.169.2024.08.14.02.06.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 14 Aug 2024 02:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723626395; x=1724231195; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2c0XRHjU0y3cm6Z6eyIislTDkEC9zABvUTWrSeWCGjw=; b=eVh4jqt/xFRlje2e6kzP2sUjTyUyn0IY/5FuUkG50Aa3PJks691O8RUBVgn93ELb1J 0PnVCg7nd7Rwtxm0/KV92zbmE7IvSERXxRylojn3dy2OASbyXKqcGAqOkkpo784Nd++l 7dcftOGeLGbe3F9+OLh7hhyL4zjZVHUp06MQlb6m7dW8zKWWTawuVB2tmivYPVUeJtGA +Lm1zIPEQNOfFl40F8Yez43MmgJuVHufNCu7N0RyAzOE2lkGTRJvFq200tahQ+EZEtWw j8d7C9Up6vIwndF/E7HnckMor7Siq//yKZ1D9yqmqEOQ1i7KyWITeVW2LU0wYn0OZ8eY Zt2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723626395; x=1724231195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2c0XRHjU0y3cm6Z6eyIislTDkEC9zABvUTWrSeWCGjw=; b=pPC8HnrCbXh3azS7TfS2jwfcE/vd9t6mGUSpQmbh7SLfxui4bWhB3GSa7anS9JtQE2 VOyQa0yrAznv2SICP36HIJzYyuBP6ybOfbh1qAQ5Q72B8VQsHWdqYd5sUiJKYS1jEJsX i5freVydxTFc6IoWX135F+opf/zecbauqbmRDxhuj7sg7h1GdI1ZbDa42eux+2vX5M1S wTpuK2tjC5JjKcm6q1Oqfvp29HSRgy/nBRbvtkDzUQQz0Pz0n3lZc51/tzThzR8QzSDD Zmi+jM5EBHbxJBDt7rArWJICicO1OTy1PLVVIr2smU7XUeFnX+luC7uHxl2ZGS4ESeFi h0AA== X-Gm-Message-State: AOJu0Yzml+Q056CLAGbTeB5ltxxyxPnuVdGnXjZpVCM/ovx0kmk44WcP U/xKr3AU1otLkP9Sv4JWqGYHGFMa3Pd6YnN+D036F6r+Ei61O+hoL7Gu6ejx+z7sgrxiAgssHaj FAYw= X-Google-Smtp-Source: AGHT+IHq4qL/d5eYhN2Fp+NlLv2g2obI6vIsS6Y1taMn2w782x6PyhFJr5tVEgU6bx5LFyKw8x5a5g== X-Received: by 2002:a17:907:3ea6:b0:a72:8a62:65e7 with SMTP id a640c23a62f3a-a8367047e66mr142634666b.57.1723626395466; Wed, 14 Aug 2024 02:06:35 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Richard Henderson , Thomas Petazzoni , Waldemar Brodkorb , Aleksandar Rikalo , Jiaxun Yang Subject: [PATCH-for-9.1 v4 3/3] target/mips: Load PTE as DATA Date: Wed, 14 Aug 2024 11:04:52 +0200 Message-ID: <20240814090452.2591-4-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240814090452.2591-1-philmd@linaro.org> References: <20240814090452.2591-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=philmd@linaro.org; helo=mail-ej1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1723626411648116600 PTE is not CODE so load it as normal DATA access. Fixes: 074cfcb4da ("Implement hardware page table walker for MIPS32") Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/tcg/sysemu/tlb_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/mips/tcg/sysemu/tlb_helper.c b/target/mips/tcg/sysemu/t= lb_helper.c index 0e94e00a5f..3836137750 100644 --- a/target/mips/tcg/sysemu/tlb_helper.c +++ b/target/mips/tcg/sysemu/tlb_helper.c @@ -603,9 +603,9 @@ static bool get_pte(CPUMIPSState *env, uint64_t vaddr, = MemOp op, =20 oi =3D make_memop_idx(op | MO_TE, ptw_mmu_idx); if (op =3D=3D MO_64) { - *pte =3D cpu_ldq_code_mmu(env, vaddr, oi, 0); + *pte =3D cpu_ldq_mmu(env, vaddr, oi, 0); } else { - *pte =3D cpu_ldl_code_mmu(env, vaddr, oi, 0); + *pte =3D cpu_ldl_mmu(env, vaddr, oi, 0); } =20 return true; --=20 2.45.2