From nobody Sun Nov 24 10:43:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1723568784; cv=none; d=zohomail.com; s=zohoarc; b=fOyYLODsV64b+ax+Q0Ed0NJH5VuEvb9zYtY6jIGwmLeiQLUwXdhvBiWNIgrpbWviY64fX7SM7MnA6DMjAdZtRP2WC38jjIszdtlNgaoAXp5OXuVFbX+IEyojkVqIQywMdopmWpg7hGQfo0HHs3j6JGoIwTbDgmJdIadveiijJvA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1723568784; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=e5IupmQd5DA2WBQItPa15ZG/dQuCisWLsaX6Mj1XqWk=; b=c6qiWgBLrPZU5iw6Yjk+kRTn2YpfQVL6i6If4BB/e+zVS8iB8x8eQwqUqc81lLcvwsdsrw4UFQaeclOhWmGjVmqNkgrU5miKTsM3c+ElONeavu4S4/HsV3IZCflFP6/Qck2rmGJrSZ4gqb2xh/Rcz/yM4ZD9h9WAi81K4JVZ9Tg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1723568784239124.3024893609097; Tue, 13 Aug 2024 10:06:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sduyK-0005b4-V7; Tue, 13 Aug 2024 13:06:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyG-0005K6-RR for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyF-00037C-5p for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:08 -0400 Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-631-ocsJMI25Mg64RbkLHE5ZDQ-1; Tue, 13 Aug 2024 13:06:04 -0400 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2f0276170f9so52537091fa.2 for ; Tue, 13 Aug 2024 10:06:04 -0700 (PDT) Received: from avogadro.local ([151.95.101.29]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5be9feb7528sm147091a12.82.2024.08.13.10.06.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 10:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723568766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e5IupmQd5DA2WBQItPa15ZG/dQuCisWLsaX6Mj1XqWk=; b=iPWGfHs1xalyCKngNe6Jjyctrt/wGGZH7UwFncNX2W/cUWsvUw16Bk6KfuKbiw30ELPyRV VVLgjbri/6Atgvx7De6xWTg0Rh+TQBGISeuoXz2UdIUpHdmiDuHn/ure4xbMZgFND0Mfp5 dkAk0k/mIIaBcbUFjbJaUqPZHsXSudg= X-MC-Unique: ocsJMI25Mg64RbkLHE5ZDQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723568762; x=1724173562; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e5IupmQd5DA2WBQItPa15ZG/dQuCisWLsaX6Mj1XqWk=; b=AKMcWJ/ta6oEUtOWMmVvQt1DdBkL6wmmSZYTUzssaoRNyuyu4VW+vglDpE/xVqbuae PZBXXfpYXuzei4H3tFnfHp7U6uGudpsbq4BHtZUkVw/ckjzKwc+UFwyr/6Iq9ZHk7At4 EiHwnEWeAOeveTa9GmqJpCWIvlqZGKdyFr91Oes7SEFuldhL6zNfgZabgjXv2E9jIhp8 73TlcRP3ttdSjj172LCAAizwG1HxjSsWGwslpjc61QRCd0LKkICxZPhqHz5bHAQ5CUlr IfSFXGnRUtpsV9o3d1WhIXj9g9lgn0diYxBJcXF9NlZda9xom0lzD8awF7uslXuD7q5U JmDw== X-Gm-Message-State: AOJu0YwM6RfU45f8UlksTT1Z1LkmLm0ZEPN+x2tn+mpXB0EBp3pqLsE1 D0/AmQTm8ESYJhTOekIG8u7iRlV+cLEYn6RwYiO+KPYn1CFcFZOphPZqhqjjv4bKAYH4Hj6ZJ1M NudSfiW20Bo8dNeVApq/Vu7PaP6hRi+DWvSplaQLfIOzgA6ooDS/1NCg7jxFnDJMhxAFuYAuWBw vJS9VaMWQtu24LUhIakSgpouvO9siltAVQtvdS X-Received: by 2002:a05:651c:154a:b0:2ef:2b05:2ab3 with SMTP id 38308e7fff4ca-2f3aa1b3775mr338911fa.10.1723568762495; Tue, 13 Aug 2024 10:06:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHH6Ro6X0imBx16c8+0bX9MVI0UyhzZv0KOmNjhbCtmXS9h2LM7UppiCMZ7/VcCfr+H11eUHg== X-Received: by 2002:a05:651c:154a:b0:2ef:2b05:2ab3 with SMTP id 38308e7fff4ca-2f3aa1b3775mr338661fa.10.1723568761759; Tue, 13 Aug 2024 10:06:01 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Alyssa Ross Subject: [PULL 1/6] target/hexagon: don't look for static glib Date: Tue, 13 Aug 2024 19:05:50 +0200 Message-ID: <20240813170556.104193-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240813170556.104193-1-pbonzini@redhat.com> References: <20240813170556.104193-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.125, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1723568786737116600 Content-Type: text/plain; charset="utf-8" From: Alyssa Ross When cross compiling QEMU configured with --static, I've been getting configure errors like the following: Build-time dependency glib-2.0 found: NO ../target/hexagon/meson.build:303:15: ERROR: Dependency lookup for glib= -2.0 with method 'pkgconfig' failed: Could not generate libs for glib-2.0: Package libpcre2-8 was not found in the pkg-config search path. Perhaps you should add the directory containing `libpcre2-8.pc' to the PKG_CONFIG_PATH environment variable Package 'libpcre2-8', required by 'glib-2.0', not found This happens because --static sets the prefer_static Meson option, but my build machine doesn't have a static libpcre2. I don't think it makes sense to insist that native dependencies are static, just because I want the non-native QEMU binaries to be static. Signed-off-by: Alyssa Ross Link: https://lore.kernel.org/r/20240805104921.4035256-1-hi@alyssa.is Signed-off-by: Paolo Bonzini --- target/hexagon/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build index b0b253aa6bf..9ea1f4fc594 100644 --- a/target/hexagon/meson.build +++ b/target/hexagon/meson.build @@ -300,7 +300,7 @@ if idef_parser_enabled and 'hexagon-linux-user' in targ= et_dirs arguments: ['@INPUT@', '--defines=3D@OUTPUT1@', '--output=3D@OUTPU= T0@'] ) =20 - glib_dep =3D dependency('glib-2.0', native: true) + glib_dep =3D dependency('glib-2.0', native: true, static: false) =20 idef_parser =3D executable( 'idef-parser', --=20 2.46.0 From nobody Sun Nov 24 10:43:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1723568861; cv=none; d=zohomail.com; s=zohoarc; b=cTd7qfQQWMME+d5IfqHzO6tw/zIFFb1JqCDUCEXenacNK3BNQ7WQQx4E2yEXmLTyXAeQ4w0q06b3xkgX3KmdyBj756Q2IhzrtlpFg0yFsX7qdETbdzb80lAglFahiYKcZKYYNuTahp+/P0nNRI/zym7ZStLx4XEguQeWnd6BrG8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1723568861; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pZXlzV39Bim9cmuseTRKv20dsdOW1fHZ/3mxSLQ2cMk=; b=R0K2pJZyGfF+MQi53u7xv1B2OWA9qafjGaEOPstr7JRzmf2UwEQIdKucGRxyAziPCcAMhSjpTGi0XBUZ1+FTdxE311W9MiNe8mBU+6NDU6jJzH0VPh5QKVILvGVHxBEQ3yL9veV/wny9zA1SUx0JwIvipm/oiI08fTbLcxHaXhM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1723568861970911.2985036048079; Tue, 13 Aug 2024 10:07:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sduyL-0005ds-Ht; Tue, 13 Aug 2024 13:06:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyJ-0005TV-6R for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyH-00037U-IG for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:10 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-642-YraP02siNiqVeUZJZFXBEw-1; Tue, 13 Aug 2024 13:06:07 -0400 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a7aa56d8b14so408128566b.1 for ; Tue, 13 Aug 2024 10:06:07 -0700 (PDT) Received: from avogadro.local ([151.95.101.29]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f3f48ed5sm84047766b.29.2024.08.13.10.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 10:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723568769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pZXlzV39Bim9cmuseTRKv20dsdOW1fHZ/3mxSLQ2cMk=; b=REKM8EGoH7nPwn/8cVfy8/tGRh0hWh6E0HXSqKJMPj8XyHcGBnEqHVroOlAeCsETe1ubb3 BkwqytkoXMYJhph9RASW9xb0IDuoY9JlOWuhVtPruii2k1IONSFrntB7ea8zOKAgPVf3Tw 3Om889GCZdmZdWL6K0N60MRnfHBLLWs= X-MC-Unique: YraP02siNiqVeUZJZFXBEw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723568766; x=1724173566; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pZXlzV39Bim9cmuseTRKv20dsdOW1fHZ/3mxSLQ2cMk=; b=TwZVaXh/2Ltp64m+GyZo+K8Iu2vrx3ByXDojqdEVTp6zEksdGvyg31vpkUyMB1EeBM UFefW26q75MCqCarwxQWhobnGBOOO/O6GA/+JQ7lyYTLx68UiuT/4KQbx7nMFpRC0Uy8 XnxU3CcBfyKxGtLn1bB0ZIsiEL24PPzAS2nP5IHLimfA2iP+YzTsUR/3hem0FojXp6+M t4WN+DaDuBdBHB2ieuVyfoVVCTd8iXynBqAHCG/CdbGMa7//cARpg4obka1O9+1vgWPT rfPMq7+G6T42XSedLO5BgtUbw7BfRcnIjoz0W2Z32mrKDj22j/Lbawi4cxfklc8F/r7O vQJA== X-Gm-Message-State: AOJu0YxqXTxCAAQbujPXzaTbKvUh9eBXWzH/FvVoSTValBUdqzte2LlV e0Ykz8KfxZJ4CHoX8feylTCUmLxLlm9tfHcRT4Cnfday6bz6LNMAZXkxET6TvIbcqCXgcgVBnXx v8/jB2r8BpnyzVUWAeY6uKilbsozR3QGBiv/laKe5MmtCPwy64WXrq4977/xdHr5rd38QPJB+3R 6GvdD+L60HGEGNd/0JtI5A9KngxL1lfxMtcP1M X-Received: by 2002:a17:906:d7e7:b0:a7a:a30b:7b95 with SMTP id a640c23a62f3a-a8366c26253mr2075566b.2.1723568765648; Tue, 13 Aug 2024 10:06:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHFJVHGFkd4orfaHBg8BfzfVJxoPcxESAT8xVw5ZnHb10zCowPxZJzQdayqmuf+e+sfZI4whQ== X-Received: by 2002:a17:906:d7e7:b0:a7a:a30b:7b95 with SMTP id a640c23a62f3a-a8366c26253mr2071566b.2.1723568765084; Tue, 13 Aug 2024 10:06:05 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-stable@nongnu.org Subject: [PULL 2/6] target/i386: Do not apply REX to MMX operands Date: Tue, 13 Aug 2024 19:05:51 +0200 Message-ID: <20240813170556.104193-3-pbonzini@redhat.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240813170556.104193-1-pbonzini@redhat.com> References: <20240813170556.104193-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.125, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1723568862751116600 Content-Type: text/plain; charset="utf-8" From: Richard Henderson Cc: qemu-stable@nongnu.org Fixes: b3e22b2318a ("target/i386: add core of new i386 decoder") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2495 Signed-off-by: Richard Henderson Link: https://lore.kernel.org/r/20240812025844.58956-2-richard.henderson@li= naro.org Signed-off-by: Paolo Bonzini --- target/i386/tcg/decode-new.c.inc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index b22210f45d9..03138b3876d 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -1979,7 +1979,10 @@ static bool decode_op(DisasContext *s, CPUX86State *= env, X86DecodedInsn *decode, op->unit =3D X86_OP_SSE; } get_reg: - op->n =3D ((get_modrm(s, env) >> 3) & 7) | REX_R(s); + op->n =3D ((get_modrm(s, env) >> 3) & 7); + if (op->unit !=3D X86_OP_MMX) { + op->n |=3D REX_R(s); + } break; =20 case X86_TYPE_E: /* ALU modrm operand */ --=20 2.46.0 From nobody Sun Nov 24 10:43:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1723568850; cv=none; d=zohomail.com; s=zohoarc; b=Jjmg/KuQ3/Z6YRCR+kvzChMmF/KVfzIK7gPWcwdDxZSbztH83zXTfpK2HNfmk6o1g6x2WSScS66pcWt7AXNVL8TYgu8fQptCeymNxReIPewnm8d+xEPR2RsgyQvF02dalrTEMyJ58NaXP80tsKDPONpEC580pGBDwaXuekPJG8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1723568850; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=B3AoGWxUBf1bbBzxz0nTsWOl3v83/0it+wu2Qc+Vsvg=; b=LerwbMrEvPGreSHxldm2R44J1k8nLEQbCTfypOHbfMVvP/Rl6k6klYV9WIoSXsH0FvMupzwDc9Kr+lfr+NeG6VT5n+iI4EVkccGirdVX27llOHulwH/RWEpRKqxGO4ixCwRsWu10OzG17hcc43fKECx6rINY16zcdxeuOrHmH0U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1723568850286209.87459793694222; Tue, 13 Aug 2024 10:07:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sduyP-0005rp-7u; Tue, 13 Aug 2024 13:06:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyM-0005jJ-WD for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyL-00037q-Ai for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:14 -0400 Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-UdQqbakUO0SHUM2SD4mJsQ-1; Tue, 13 Aug 2024 13:06:11 -0400 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ef3157ae4cso63359621fa.2 for ; Tue, 13 Aug 2024 10:06:11 -0700 (PDT) Received: from avogadro.local ([151.95.101.29]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f3f475ccsm85779966b.14.2024.08.13.10.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 10:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723568772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B3AoGWxUBf1bbBzxz0nTsWOl3v83/0it+wu2Qc+Vsvg=; b=UkNkCRRbUF+xS5cUTKYDzwyiHTvV2vu7rfQS/KrdPZ8Qh75a8cDaDEODoZ2papDnoSYVBv WfCbAkvC9yZQn+T4UeY1bm9U39bTj9ytWBrfXBg+SbFbfUSEemsXEpvJXcE4GVUtrNEHdI /TbxLrl2Rxp5cc/6llgxWPT9DF7KlxA= X-MC-Unique: UdQqbakUO0SHUM2SD4mJsQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723568769; x=1724173569; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B3AoGWxUBf1bbBzxz0nTsWOl3v83/0it+wu2Qc+Vsvg=; b=uAVnKcZdibFKlXZWTyuD848p3s0TV0AnShALHmB6XE0npdj293bhoxkoW4NKkD4FLf 2fwfGC5xSIVTRbPm4s7jHtnu6Xn/IWuRJgPji1gUgXt+lGRl+z2aIY82YrB5el4TnK1B XMTxA9iM6gX1KkjO52rrt2AsBTN0CkUwPnuPHDDksLn2V5J7mgYFe4UHiBIZL3xCGvkh jnYK+nkznGpgurnjH/W57J5bIvcR7Plge7E0DpL3cXTcNIcyZwD8ashMRDyfrf5xz5Ry kexwOsUDbQg4nEhBhgfR2M8xO75B1fKyUG8+MU8KuqKl8U2ZtWALXmYUz6zyjeFodVa4 VrKg== X-Gm-Message-State: AOJu0YwpBuolLkiBU73vNoumssZBXCirA2mb0T34YRB78ALdEyDpW9MI rA0UuwCs+gVdHKg94/AWDsk4qg2vcz58jXN255RXWztOGfVLJN/SgAjekhE15kBUP1yURSwA/t/ SCI7dyD3uOiQz9yw3sr5dRGDHzCVd29pTfhYzEXRmlMKyF0BSZ5Eea1NaAE5Anwx+wexYevyZ05 Scm5aINcwg2ksI/J4JAG8JWimn982JYlJEL9gC X-Received: by 2002:a2e:9bc5:0:b0:2f1:67de:b536 with SMTP id 38308e7fff4ca-2f3aa1f0788mr272781fa.24.1723568769424; Tue, 13 Aug 2024 10:06:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFAoqzXz2rHYrg6dCsSt2rB7weXlmJF3lJ8VjM9C3avp14WxvKPU4E4ZWwzdtpME24ZTuY6KA== X-Received: by 2002:a2e:9bc5:0:b0:2f1:67de:b536 with SMTP id 38308e7fff4ca-2f3aa1f0788mr272501fa.24.1723568768858; Tue, 13 Aug 2024 10:06:08 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 3/6] target/i386: Use unit not type in decode_modrm Date: Tue, 13 Aug 2024 19:05:52 +0200 Message-ID: <20240813170556.104193-4-pbonzini@redhat.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240813170556.104193-1-pbonzini@redhat.com> References: <20240813170556.104193-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.125, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1723568852736116600 From: Richard Henderson Rather that enumerating the types that can produce MMX operands, examine the unit. No functional change. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Link: https://lore.kernel.org/r/20240812025844.58956-3-richard.henderson@li= naro.org Signed-off-by: Paolo Bonzini --- target/i386/tcg/decode-new.c.inc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index 03138b3876d..30be9237c31 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -1799,13 +1799,13 @@ static void decode_root(DisasContext *s, CPUX86Stat= e *env, X86OpEntry *entry, ui } =20 =20 -static int decode_modrm(DisasContext *s, CPUX86State *env, X86DecodedInsn = *decode, - X86DecodedOp *op, X86OpType type) +static int decode_modrm(DisasContext *s, CPUX86State *env, + X86DecodedInsn *decode, X86DecodedOp *op) { int modrm =3D get_modrm(s, env); if ((modrm >> 6) =3D=3D 3) { op->n =3D (modrm & 7); - if (type !=3D X86_TYPE_Q && type !=3D X86_TYPE_N) { + if (op->unit !=3D X86_OP_MMX) { op->n |=3D REX_B(s); } } else { @@ -2040,7 +2040,7 @@ static bool decode_op(DisasContext *s, CPUX86State *e= nv, X86DecodedInsn *decode, /* fall through */ case X86_TYPE_nop: /* modrm operand decoded but not fetched */ get_modrm: - decode_modrm(s, env, decode, op, type); + decode_modrm(s, env, decode, op); break; =20 case X86_TYPE_O: /* Absolute address encoded in the instruction */ --=20 2.46.0 From nobody Sun Nov 24 10:43:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1723568870; cv=none; d=zohomail.com; s=zohoarc; b=lN/KbTNzg0zSFDy0rfPxsex1Y5JpPKKTRqzzkZEYPxqqJOTYrAqTAR9T+yP2UBcPE9eq9b9nwS0ay80oeCdOZYBsDQC32y9C+qFOIbZoie9TpBSzBgaVCw5xwXQ1l2/+rHdmb8WQz1yNRiYbHlWqG4qyrmPRRK/bUFK6bDyjeRE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1723568870; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HtuZZEJtTULFZZPJE3He16hpHtco94gG0U5/hl5SQmY=; b=L1zgU1oVR2Kx+Tllcs+Pc5w1GJx1L8k9GxuxK2ne4ezFIqNz4g39Bp5RbqvX1oknJmRSRYHMR4ecOExQyLvQfvyPuiXlDqokAg5zijRgy/X33bQf76Al3HqKKU5c2himq4oqbeEUJLI2IxLGkKZ0xd9a4xkOy6d2bloIeHfP0QM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1723568870754323.33792435774683; Tue, 13 Aug 2024 10:07:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sduye-0006xH-RY; Tue, 13 Aug 2024 13:06:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyY-0006Vx-9o for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyP-00038B-79 for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:26 -0400 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-4qC13e5zPDeOYU7MPEU9yA-1; Tue, 13 Aug 2024 13:06:15 -0400 Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-5a766a51b0dso4662124a12.1 for ; Tue, 13 Aug 2024 10:06:14 -0700 (PDT) Received: from avogadro.local ([151.95.101.29]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bd1a5e04e1sm3036790a12.77.2024.08.13.10.06.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 10:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723568776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HtuZZEJtTULFZZPJE3He16hpHtco94gG0U5/hl5SQmY=; b=a0ntNwS9faLIx2z/MIvyq3wOGOUiupeb9pUvukWVl6ssV6DN7VM4qFTJZVj/zTnfbc/zut wBouWMhWoUYu0/VQeNRMgQWU2Je6huYiXejZ/o1aTfVnYp9HADf5vWJihioeGDvlsCJJE9 b7lOB/7zLcLH5EvLNK6tM8BQdEy3aA4= X-MC-Unique: 4qC13e5zPDeOYU7MPEU9yA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723568772; x=1724173572; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HtuZZEJtTULFZZPJE3He16hpHtco94gG0U5/hl5SQmY=; b=WDutkj29O/9tJ27c1Z52eEW8wb/1bKDXpY5LoafaW2YiMuhBRPxHzDNrLyA2E2jDO4 jJT8PdYZQa+tJjOkVZpy/H+HaVq2ETE7oL2wFQpzOiV2PYh7IXhwZzDgGQJ7rNNGCPLZ luWr8CcMoUoBX0PHlXtgwhX5YP6MSWE1cJuhTsorUTxEsR+8fQedKA1HE+UR5hj4uZAb HoeBTqPAPUq/uWL+fXGWCxiM0goXTDrR5/qeqWtct3oCbrTdVcgFhpxAHmJPrw3Md2gD r/2SX1aqYrTBGNqEKu/ZKpvvpp5rcc0TZzy+QT/z+hhU0Soigpd65yB1WnTOYLDqBfFh U+cw== X-Gm-Message-State: AOJu0YzMBIKf1CGCH8ogbxmsBT8pI3poZD87tJSz4kH5zBse/koNYTJl /iX8NW+e1ZM6ukQqGTSM645xZ2HYGGHNIIAeuvNkSs5lkj1ICrzQUFG22CO0XFvk2BMrM7C7SBO tQ9CqD7/4ASeBY/tF7lewiWWFuc8tehVZv9igYeJ29bQykiyV81Gk5V4wSfds3/SpcGyUALbmJO N4eREB4lP9qiiAzrrIBo7jBdlnQS31lo14vrgy X-Received: by 2002:a05:6402:42d1:b0:5a3:5218:3f91 with SMTP id 4fb4d7f45d1cf-5bea1cadcf2mr142082a12.24.1723568772236; Tue, 13 Aug 2024 10:06:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFWEI+p9XKYUaVzRx7R4YDk8Ris67+PTxP6sFpaocDfGTlPRq7Jdzaj4RDuATDXjQGvuM4Onw== X-Received: by 2002:a05:6402:42d1:b0:5a3:5218:3f91 with SMTP id 4fb4d7f45d1cf-5bea1cadcf2mr142033a12.24.1723568771511; Tue, 13 Aug 2024 10:06:11 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 4/6] target/i386: Assert MMX and XMM registers in range Date: Tue, 13 Aug 2024 19:05:53 +0200 Message-ID: <20240813170556.104193-5-pbonzini@redhat.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240813170556.104193-1-pbonzini@redhat.com> References: <20240813170556.104193-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.125, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1723568872817116600 From: Richard Henderson The mmx assert would fire without the fix for #2495. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Link: https://lore.kernel.org/r/20240812025844.58956-4-richard.henderson@li= naro.org Signed-off-by: Paolo Bonzini --- target/i386/tcg/emit.c.inc | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index 016dce81464..22a06897fb7 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -33,8 +33,13 @@ #define TCG_TARGET_extract_tl_valid TCG_TARGET_extract_i32_valid #endif =20 +#define MMX_OFFSET(reg) \ + ({ assert((reg) >=3D 0 && (reg) <=3D 7); \ + offsetof(CPUX86State, fpregs[reg].mmx); }) =20 -#define ZMM_OFFSET(reg) offsetof(CPUX86State, xmm_regs[reg]) +#define ZMM_OFFSET(reg) \ + ({ assert((reg) >=3D 0 && (reg) <=3D 15); \ + offsetof(CPUX86State, xmm_regs[reg]); }) =20 typedef void (*SSEFunc_i_ep)(TCGv_i32 val, TCGv_ptr env, TCGv_ptr reg); typedef void (*SSEFunc_l_ep)(TCGv_i64 val, TCGv_ptr env, TCGv_ptr reg); @@ -168,7 +173,7 @@ static int vector_elem_offset(X86DecodedOp *op, MemOp o= t, int n) static void compute_mmx_offset(X86DecodedOp *op) { if (!op->has_ea) { - op->offset =3D offsetof(CPUX86State, fpregs[op->n].mmx) + mmx_offs= et(op->ot); + op->offset =3D MMX_OFFSET(op->n) + mmx_offset(op->ot); } else { op->offset =3D offsetof(CPUX86State, mmx_t0) + mmx_offset(op->ot); } --=20 2.46.0 From nobody Sun Nov 24 10:43:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1723568857; cv=none; d=zohomail.com; s=zohoarc; b=A1MB+ccIOqz75v17n3JqtymWWUYxoAmk2L7u7TSWUBcz206QViEKZYEeD6/wzExSgO+I30ktA383t4YUIm3aVR44m/Uwgih/gKma2yhvGSDZpYNv9doKJ28A3D+E0lbdsIxzAwhG5pS40N5DQ+Si0sh5X3A54zwQ3tonpZQSNw0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1723568857; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=83GI1fDfDMGezYy05oq4L94LxUNct25QLDIJmFGGzPE=; b=DUV/bPd+cR5kv7b2TBxVWMOzmdqcmIBSaplwkj/e7MABqV1PgpcJMThRVv085NtzkNlsoOQ0b0yeykNJg55PYwXRKZzctBcSqLqoNoI9M7YHzeWjC1eGYJqWhnfX0HRbkIlx97QWOq+s7twC9FBSSHvBxZgsbl9i0YxTMjM92z0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1723568857211845.0461138503804; Tue, 13 Aug 2024 10:07:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sduyX-0006RY-Db; Tue, 13 Aug 2024 13:06:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyV-0006FA-8w for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyR-00038N-Ih for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:23 -0400 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-78-YDsk1ZeDNxOZ1ays2ZKOEg-1; Tue, 13 Aug 2024 13:06:17 -0400 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-5bb8fc3df4aso4310808a12.0 for ; Tue, 13 Aug 2024 10:06:17 -0700 (PDT) Received: from avogadro.local ([151.95.101.29]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bd190ad1bcsm3114523a12.30.2024.08.13.10.06.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 10:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723568779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=83GI1fDfDMGezYy05oq4L94LxUNct25QLDIJmFGGzPE=; b=E0+/QDUPRXG7s1BRegkDiLooxO91XWq5iI4RMmd30Fj/EnxuPlGk00aq4hoEh+6bzJpv/e dNnvxllqY9/eAGa1q2t3cCqIKab+n2fqShvh1D5ow7dBDQDBDFxZwEyvESYlvLZLh/wBSo 8NEHb7rGXVUTWjwf6udryJriRwPauS0= X-MC-Unique: YDsk1ZeDNxOZ1ays2ZKOEg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723568776; x=1724173576; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=83GI1fDfDMGezYy05oq4L94LxUNct25QLDIJmFGGzPE=; b=qUXqImvyEnHCAgugzPX4I5NGvXbtypmnIcSymNkBbABtp5HhETDGUL1yyuMxbebVbn lsjuix2fX4TswoMNe68wCPTsGAICKY7cZ93N2NeFtSDHF1yjYNC/GlaMN7X7ed0Oygd3 4JwG9B1xO4FXWyySL6OWFuj0GM9YZAL1nxzCwv43jCdigU0UmGQMOCauvxDD/Pvlqy/C 37oBcmHUN+I5/dOrYcAQCB8SNoA0rQGIQRhUYdXqo9ktYHnd+NkY0ZFp2f/XQxWx3wKd tpw2UvY1Xtu+Y3IC3JvrnFtKGQ+KuqK0RcTsNTm/C+SSGCiLmZ62TUQAQa7e0HpgkLUq tUOQ== X-Gm-Message-State: AOJu0YyuIwS62AfRvADe4YaPbzSGNVOOd88ko94Huygj5gFrFamT3drN GpheusZXEg8K6ntsYmc9UlLHSwKK7CMjch1Ja7QLDG+DlXMqe5qBLK7cJatqZjkztOpsDspHmMg 5qDHtDM3Hj0jLkg2BlfufMLCekBBotkcjGSCbx3YTvYyqTMSZYBaxlfO6/xNfTq2W74qG7b0YxK F9jkIqL9HR+Vp/nlChyoat2hQJPU/tQJbH7O0E X-Received: by 2002:a05:6402:2354:b0:5a2:a0d9:c1a2 with SMTP id 4fb4d7f45d1cf-5bea1cad0damr102262a12.26.1723568776191; Tue, 13 Aug 2024 10:06:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFzsM50zCb89/RGNNWmZqNRMHD0zqp5+0Wk7Sa/qvkIIWqFubrprvfAZomrRgjuwBQlsXB67g== X-Received: by 2002:a05:6402:2354:b0:5a2:a0d9:c1a2 with SMTP id 4fb4d7f45d1cf-5bea1cad0damr102238a12.26.1723568775739; Tue, 13 Aug 2024 10:06:15 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Alexander Ivanov , Claudio Fontana , "Denis V. Lunev" , qemu-stable@nongnu.org Subject: [PULL 5/6] module: Prevent crash by resetting local_err in module_load_qom_all() Date: Tue, 13 Aug 2024 19:05:54 +0200 Message-ID: <20240813170556.104193-6-pbonzini@redhat.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240813170556.104193-1-pbonzini@redhat.com> References: <20240813170556.104193-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.125, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1723568858836116600 Content-Type: text/plain; charset="utf-8" From: Alexander Ivanov Set local_err to NULL after it has been freed in error_report_err(). This avoids triggering assert(*errp =3D=3D NULL) failure in error_setv() when local_err is reused in the loop. Signed-off-by: Alexander Ivanov Reviewed-by: Claudio Fontana Reviewed-by: Denis V. Lunev Link: https://lore.kernel.org/r/20240809121340.992049-2-alexander.ivanov@vi= rtuozzo.com [Do the same by moving the declaration instead. - Paolo] Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- util/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/module.c b/util/module.c index 32e263163c7..3eb0f06df16 100644 --- a/util/module.c +++ b/util/module.c @@ -354,13 +354,13 @@ int module_load_qom(const char *type, Error **errp) void module_load_qom_all(void) { const QemuModinfo *modinfo; - Error *local_err =3D NULL; =20 if (module_loaded_qom_all) { return; } =20 for (modinfo =3D module_info; modinfo->name !=3D NULL; modinfo++) { + Error *local_err =3D NULL; if (!modinfo->objs) { continue; } --=20 2.46.0 From nobody Sun Nov 24 10:43:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1723568859; cv=none; d=zohomail.com; s=zohoarc; b=NLVq0XGvEMZ92lrQjV5vgIA/BtpOWVsVFRU/4rtcpKytuvUyftETaufZjMgdKJXz3KUrpQAzKOVgIQQSHDbsBV4hhx5zmfwgIl902uwh/BV93bIhsjT5xGakdZ1s+umwBEFZwj8rkdls1TvC1mrzP8gH+nwMiCNOzFE2uLbRXeQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1723568859; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=/JEbOJkwY4yqdkYnOaF1sKBNaU2b+I2B2V004N9EQqg=; b=leUGdXJ+Bk5A/Xgm4KI3Z/RnlJBz+f3wcLa3QwMuamoDfA3YYXb80sdPf613nC1nmxjZ8kb82x9zvRcloeOtzxESch0yBThNH38QUhD003uY5D/2ZJQxCw/uaNnpZNVCEOzT3mN+nqjx3eB9FrBGF970uN9txrTSiSATzmoH978= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1723568859803748.7907519380507; Tue, 13 Aug 2024 10:07:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sduyc-0006jU-NB; Tue, 13 Aug 2024 13:06:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyX-0006SF-EX for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sduyV-00039G-Rs for qemu-devel@nongnu.org; Tue, 13 Aug 2024 13:06:25 -0400 Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-QC1UtPEqPNmN_KYOl4PMjg-1; Tue, 13 Aug 2024 13:06:21 -0400 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ef3157ae4cso63360911fa.2 for ; Tue, 13 Aug 2024 10:06:21 -0700 (PDT) Received: from avogadro.local ([151.95.101.29]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a80f411bb19sm82352666b.122.2024.08.13.10.06.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 10:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723568783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/JEbOJkwY4yqdkYnOaF1sKBNaU2b+I2B2V004N9EQqg=; b=P/ZyoYIF0f0qTnhLEp/bsWKWoNlRAscDt7Shk9btFvuB0Cm1KuK+7ZWalr1nssZeDD7nXx 5Gz+sTALMoLythwNXSei3k9ao2+kpzSanYkLKZ+NK/4g4TZ3XCV+viGyeGNiOt+7zP0+yU Ggsh7yqK5b3Y6GPHTmXaW500ux0ZfcQ= X-MC-Unique: QC1UtPEqPNmN_KYOl4PMjg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723568780; x=1724173580; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/JEbOJkwY4yqdkYnOaF1sKBNaU2b+I2B2V004N9EQqg=; b=DGZzLsqj279QzaScmqcMEQzBZG3q0+Zg6KJMQE3g9ybVLqvbrLkI2ldzpCa9YvS46C RIbemc84sL87QVT6s7DnE+lF3i6Rc1HzImFc1i4xTBQ0bD9C8TKcFBFm1yb5/aYuYWdf vep7XH/AWfrelCSwEuw+BqC0hjrsEy0ZBTDd2ViGREp+vFsfEaITVukVN+vVcxw5wYAz f2cJNrabvjjP8s7OhPw8z3vjO64GfGPsKDOCpTRa74L2A5r+xdhTUkBN263eRi2+UgNz mQ4dnDqtSCbyHxcLn4B6FSpbBgzeVNiTOwk6D9KhL4TGbQrqWrZLI4TiU46fUc+ikFmF E+XQ== X-Gm-Message-State: AOJu0YxOkJMUesQkg+2+knwz3H4nkEeI33sq7uc7a5O+AEN4QEhFlyGI qZKfu0ukoxqilM+9XCSUD0SNNMBIwpISvDYVkVn4Lzamek2qS5+kBVDIg79fMa2hYbpj+wxsK2s A9PSnaZjqN8yYivtwGV9Q16cz/v087e6Fl/OXqPU9isL3GovV9Es/i+0Z/yItg1yKB0/E3ztFpT H+SIvwYxvUS37Npt6H8+qYQth70feKZnY/ix9Q X-Received: by 2002:a05:651c:11d1:b0:2ef:23af:f202 with SMTP id 38308e7fff4ca-2f3aa3014d8mr93721fa.46.1723568779880; Tue, 13 Aug 2024 10:06:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQAFehb92Po3sTasJDsUkCvOWxmJMfRoc0itBsiOHITjOISKaOgfB86PrU5W0jHZEsND2EJw== X-Received: by 2002:a05:651c:11d1:b0:2ef:23af:f202 with SMTP id 38308e7fff4ca-2f3aa3014d8mr93331fa.46.1723568779307; Tue, 13 Aug 2024 10:06:19 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 6/6] po: update Italian translation Date: Tue, 13 Aug 2024 19:05:55 +0200 Message-ID: <20240813170556.104193-7-pbonzini@redhat.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240813170556.104193-1-pbonzini@redhat.com> References: <20240813170556.104193-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.125, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1723568860726116600 Content-Type: text/plain; charset="utf-8" Reported-by: bovirus Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2451 Signed-off-by: Paolo Bonzini --- po/it.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/po/it.po b/po/it.po index c6d95172070..363b9bddf2f 100644 --- a/po/it.po +++ b/po/it.po @@ -65,7 +65,7 @@ msgid "Detach Tab" msgstr "_Sposta in una nuova finestra" =20 msgid "Show Menubar" -msgstr "" +msgstr "Mostra _barra dei menu" =20 msgid "_Machine" msgstr "_Macchina virtuale" --=20 2.46.0