From nobody Sun Nov 24 14:47:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1722852104; cv=none; d=zohomail.com; s=zohoarc; b=hMk9OZs9q0S3DsH5dkwVeDhGXHdYMpu8yUUuXC75mFmALkLBjsW8mJKQp4YQQ25XUVvL/7R4j661aHjiHooENpbrM7kB89ySED+1qrOYrZfizJBqgrBiyUI7fGwQHmz7wxABMmalE+7nTGsz9/8BB/Nnzz6ODH4yTvf4XRAiGEc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1722852104; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Ja+2Rln8Aybt08irPb0En7wqcDpJy8xF+oHU5uY2BGc=; b=FDoMAKd1RwdEtFoe3g7Vk79foTMT7sH6BlBuBew2LAPuqij7KfXC1HuPvOohiLh0dK7vsNZubJ+mI52E5jS9ht9HQ6cATA57BVnbsPt5oh9FQ0cnW5+mr9OgsR36spj1nsyfg+gfRhv+9yos+Wta2lpKP5x3rEV8hxMCWDXpD5w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1722852104137482.34098991278313; Mon, 5 Aug 2024 03:01:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sauVM-0003s5-Nl; Mon, 05 Aug 2024 05:59:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sauVL-0003qA-Se for qemu-devel@nongnu.org; Mon, 05 Aug 2024 05:59:51 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sauVJ-0001IP-Uv for qemu-devel@nongnu.org; Mon, 05 Aug 2024 05:59:51 -0400 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-7163489149eso7335091a12.1 for ; Mon, 05 Aug 2024 02:59:48 -0700 (PDT) Received: from localhost ([157.82.202.230]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2cffb091391sm6585975a91.18.2024.08.05.02.59.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Aug 2024 02:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1722851988; x=1723456788; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ja+2Rln8Aybt08irPb0En7wqcDpJy8xF+oHU5uY2BGc=; b=PR4hW9QPK0dzYJTjZYV6le8ybfVCM3qyW8m39wXtU7hPSXWjd6YkhIlDwofzromvf8 qolASZeGsKiSgfadai9jdIO6kADT4QNbGGJW6YA8muA2KacyjefEVJo7yE4WGS+8V2Dc fRXKSFz4PJDLtHlzN5CKlEi+R32KWCfqX8crJEvFJTFaLnXGGRGoK/ngS60WGPQRoTMg vhHADDjLKMuzMeyI2GubbPGtq/o8L72mGPoZoC0sprHth9RFhkGEEvSgo9GLjxx537mt 75MY3l6mwh6EIb/Ue3UQSkAxOp98MJoUhwhwUbvUg1Lrqat2jhJcJ/0CFvdbZwWwtnKm 6igw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722851988; x=1723456788; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ja+2Rln8Aybt08irPb0En7wqcDpJy8xF+oHU5uY2BGc=; b=FzLyH4tG79OuP3QPjWyROEtq9V+rhLX1XCZt+OcbJY3QQ4po9P4Va90/BhioFgQ3cj 4rNUZFgXWQ/Zl5tRwHQgwP3lb4RgimmVjdsrS1nNBFyylYUbO0tPThQgf+DPlTF9z8qO PtnSsTCOTEWjxOaE6bCePSWwcdAquPRW629cZvu+8s7B3KBldyNtE5RDtvy+ka0x+srI dxnrvMXBqRbWvkxH/p1xb+YluWjX+jmoGUPzx+hhmo6JGdAECY54owpPn3kQP04im+xR lZUiahdtAi/j6GSRPVOqc0lmVWDcG7IRUVP4wbOt651ByU0rFIgXcLMWWiuoklBAZSYQ 8YYQ== X-Gm-Message-State: AOJu0Yz9H9WRgIY1ex+1u025DEDZ8gXole+C54WE/3JuPS+CPxEwA/GX tSjOFgKbFhh99aeVdz4r+4nN9VHMG51z0/++pHeJ2/v3lNH1ZS3kjMm/Z1RZBJE= X-Google-Smtp-Source: AGHT+IGGBZglPco7tYVVxnP+o2Oc+ABIwTtZHlRnXSY1Jbw+66g391+XRrGjB6ZfjoDLSCMYNYDCOw== X-Received: by 2002:a17:90b:489:b0:2c9:6a2d:b116 with SMTP id 98e67ed59e1d1-2cff940e469mr13438243a91.7.1722851987778; Mon, 05 Aug 2024 02:59:47 -0700 (PDT) From: Akihiko Odaki Date: Mon, 05 Aug 2024 18:59:02 +0900 Subject: [PATCH for-9.2 v13 05/12] pcie_sriov: Do not manually unrealize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240805-reuse-v13-5-aaeaa4d7dfd2@daynix.com> References: <20240805-reuse-v13-0-aaeaa4d7dfd2@daynix.com> In-Reply-To: <20240805-reuse-v13-0-aaeaa4d7dfd2@daynix.com> To: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Marcel Apfelbaum , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , Sriram Yagnaraman , Jason Wang , Keith Busch , Klaus Jensen , Markus Armbruster Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Akihiko Odaki X-Mailer: b4 0.14-dev-fd6e3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::536; envelope-from=akihiko.odaki@daynix.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1722852104764116600 A device gets automatically unrealized when being unparented. Signed-off-by: Akihiko Odaki --- hw/pci/pcie_sriov.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/pci/pcie_sriov.c b/hw/pci/pcie_sriov.c index e9b23221d713..499becd5273f 100644 --- a/hw/pci/pcie_sriov.c +++ b/hw/pci/pcie_sriov.c @@ -204,11 +204,7 @@ static void unregister_vfs(PCIDevice *dev) trace_sriov_unregister_vfs(dev->name, PCI_SLOT(dev->devfn), PCI_FUNC(dev->devfn), num_vfs); for (i =3D 0; i < num_vfs; i++) { - Error *err =3D NULL; PCIDevice *vf =3D dev->exp.sriov_pf.vf[i]; - if (!object_property_set_bool(OBJECT(vf), "realized", false, &err)= ) { - error_reportf_err(err, "Failed to unplug: "); - } object_unparent(OBJECT(vf)); object_unref(OBJECT(vf)); } --=20 2.45.2