From nobody Sun Nov 24 15:27:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1722563383; cv=none; d=zohomail.com; s=zohoarc; b=cGgmJIX5o9IyI+5KgoxdONyA50iZDGka/CDAYYKR7acaSKtEhU+5gqbAHpnE7IptCsHyzmgIOCYjLTVKCqquVm04sqkuKwzjaK3fuvA7yFn2K3NL7jAYDWB8De/d32gFXBqLKLjrQSAgg48B3fwp/6zUuU/W84hef8blZGyBgf8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1722563383; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=W+ocFGmg17RpHpMuCKxkl0vQ5+ZuyZySzGSS1ZlXAEk=; b=ZZgJYG21phBlNMhk0MJhd+IcRUek8uA3fnzUYwpXy0K1Tp2b2nJNxkJCvoDYVeXosYQ/sdjRQX889dZjzvN03WO/qeVLtsEJEmDNJJAJdC7Qr8D0pUXBkIaCuexAAhM4UzCxk4/O84/vrtI1PxK5tKW4i6jcqOokepHJIdFd3js= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172256338355811.455132060417782; Thu, 1 Aug 2024 18:49:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sZhPY-0000p2-8k; Thu, 01 Aug 2024 21:48:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZhPW-0000jR-8c for qemu-devel@nongnu.org; Thu, 01 Aug 2024 21:48:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sZhPU-0001xu-P7 for qemu-devel@nongnu.org; Thu, 01 Aug 2024 21:48:49 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-WMtS9pGePhGtwsjZdxflOA-1; Thu, 01 Aug 2024 21:48:45 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 610F91956064; Fri, 2 Aug 2024 01:48:42 +0000 (UTC) Received: from green.redhat.com (unknown [10.2.16.72]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BA397195605A; Fri, 2 Aug 2024 01:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722563328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W+ocFGmg17RpHpMuCKxkl0vQ5+ZuyZySzGSS1ZlXAEk=; b=YdgkARPPIBvZqxW9C2k5Vclg4muDY2B0BmxZYbuV5czzs0WLVTnS6k0QXzi3bXofnTGwuS OBwdwGuC7SCxBiW8fBLHwW6weHkVfynVj6BGduDRuOrPMfpj7MRpvbEX3wZMTFl55YGFSr tDsSe5QqWne336D3RorQdquf12vXC/Q= X-MC-Unique: WMtS9pGePhGtwsjZdxflOA-1 From: Eric Blake To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, den@virtuozzo.com, andrey.drobyshev@virtuozzo.com, vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com, berrange@redhat.com, Alexander Ivanov Subject: [PATCH v2 3/3] nbd: Minor style fixes Date: Thu, 1 Aug 2024 20:32:08 -0500 Message-ID: <20240802014824.1906798-8-eblake@redhat.com> In-Reply-To: <20240802014824.1906798-5-eblake@redhat.com> References: <20240802014824.1906798-5-eblake@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.131, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1722563383806116600 Content-Type: text/plain; charset="utf-8" Touch up a comment with the wrong type name, and an over-long line, both noticed while working on the previous patches. Signed-off-by: Eric Blake --- nbd/server.c | 2 +- qemu-nbd.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/nbd/server.c b/nbd/server.c index 7c37d9753f0..3debc416dd0 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -1973,7 +1973,7 @@ static void nbd_export_request_shutdown(BlockExport *= blk_exp) blk_exp_ref(&exp->common); /* - * TODO: Should we expand QMP NbdServerRemoveNode enum to allow a + * TODO: Should we expand QMP BlockExportRemoveMode enum to allow a * close mode that stops advertising the export to new clients but * still permits existing clients to run to completion? Because of * that possibility, nbd_export_close() can be called more than diff --git a/qemu-nbd.c b/qemu-nbd.c index 3ad50eec18e..c0bd16217cd 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -589,7 +589,8 @@ int main(int argc, char **argv) pthread_t client_thread; const char *fmt =3D NULL; Error *local_err =3D NULL; - BlockdevDetectZeroesOptions detect_zeroes =3D BLOCKDEV_DETECT_ZEROES_O= PTIONS_OFF; + BlockdevDetectZeroesOptions detect_zeroes =3D + BLOCKDEV_DETECT_ZEROES_OPTIONS_OFF; QDict *options =3D NULL; const char *export_name =3D NULL; /* defaults to "" later for server m= ode */ const char *export_description =3D NULL; --=20 2.45.2