From nobody Fri Oct 18 05:23:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1721938400; cv=none; d=zohomail.com; s=zohoarc; b=T1W569FBWXMnppUI1+wwjUz+bsUwh+ttPYQBxzeKEs7oAM0f5wJvV+KZsdYOz9DStCmw0fInxE7Bap00stEpdJ9U8v/B+OZVvQPfKhubrM1BHsmuP8PAopXTqG5dFbC/bV55mqAzQzTuzFOGpbtOlB5Y7EHiimTP3oEjvIa7nq4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1721938400; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VVqa5+LoCMu6Kp9TvnjLZk6BG0y9wPquSFjCq1RQVM4=; b=b6oBKLDReaZlLBN5HTM8q60Kkxs4bEgBQLLMfj3EdGgdjsAfNn0XL3SyxxyRcGcSAWkIBRLverLbgoNVSe5RcSewrOaj4V4ZIcdusBTNR34uMYw/2Xe+DJfexB8yYVbU5QvvInVzo81WeK+bjtX73zNAKb88hHX1sQRnwV8fzQM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17219384001431014.011130943512; Thu, 25 Jul 2024 13:13:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sX4p7-00072n-S4; Thu, 25 Jul 2024 16:12:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sX4p5-0006t4-KW for qemu-devel@nongnu.org; Thu, 25 Jul 2024 16:12:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sX4p4-00068q-4i for qemu-devel@nongnu.org; Thu, 25 Jul 2024 16:12:23 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-WN0vu4GoMsKw4MU5KJY9zA-1; Thu, 25 Jul 2024 16:12:17 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E646519560B1; Thu, 25 Jul 2024 20:12:15 +0000 (UTC) Received: from localhost (unknown [10.2.16.100]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AA7A319560AE; Thu, 25 Jul 2024 20:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721938341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VVqa5+LoCMu6Kp9TvnjLZk6BG0y9wPquSFjCq1RQVM4=; b=PO1ubuo4tR1qsQK0pcgFaw+pnqtsrxbhbnupdoFBoq8Aqc3AOufXub2KQUsythKd78xX3q mFgg+oFj2U+Y9D7X+0j1fDFVaxXQK4J8i1c8HcNZFY7+lvQ6Yqy4TdT+nRKWxakHuM05nh gP/c83FfVncCODiZIVkIjkJlzIV+yg8= X-MC-Unique: WN0vu4GoMsKw4MU5KJY9zA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Hanna Reitz , Stefan Hajnoczi , qemu-block@nongnu.org, Fam Zheng , Kevin Wolf , Richard Henderson , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 1/1] util/async.c: Forbid negative min/max in aio_context_set_thread_pool_params() Date: Thu, 25 Jul 2024 16:12:11 -0400 Message-ID: <20240725201211.460318-2-stefanha@redhat.com> In-Reply-To: <20240725201211.460318-1-stefanha@redhat.com> References: <20240725201211.460318-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.144, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1721938402572116600 From: Peter Maydell aio_context_set_thread_pool_params() takes two int64_t arguments to set the minimum and maximum number of threads in the pool. We do some bounds checking on these, but we don't catch the case where the inputs are negative. This means that later in the function when we assign these inputs to the AioContext::thread_pool_min and ::thread_pool_max fields, which are of type int, the values might overflow the smaller type. A negative number of threads is meaningless, so make aio_context_set_thread_pool_params() return an error if either min or max are negative. Resolves: Coverity CID 1547605 Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20240723150927.1396456-1-peter.maydell@linaro.org Signed-off-by: Stefan Hajnoczi --- util/async.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/async.c b/util/async.c index 0467890052..3e3e4fc712 100644 --- a/util/async.c +++ b/util/async.c @@ -746,7 +746,7 @@ void aio_context_set_thread_pool_params(AioContext *ctx= , int64_t min, int64_t max, Error **errp) { =20 - if (min > max || !max || min > INT_MAX || max > INT_MAX) { + if (min > max || max <=3D 0 || min < 0 || min > INT_MAX || max > INT_M= AX) { error_setg(errp, "bad thread-pool-min/thread-pool-max values"); return; } --=20 2.45.2