From nobody Sun Nov 24 21:04:08 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1721030893; cv=none; d=zohomail.com; s=zohoarc; b=W2B5WJ+e2mteA2vfhhPFEQ20AQu8jOI6o4MMeACon2M7s5KZjQ+kFjvFe40Q9T44ioy6YYeFHx1ZQ2E9Q3xIzSgcDHCGQdgsSPij3mdhJV1Grb/z0nZT8oFWS6DJ/PpO4M9zThPR43eZuNu0w8UCPDJ4u1rPX7h7+/sf0KaAytQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1721030893; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ua/67R9QOTTlElNTTAMNwz0Gc1hUtKtdRcJIBNjA0XM=; b=UPA9LDC9463fNSZWlTg8OZySqjDu3qlPP/qm4oqcw8CMhGszEdkrvtHgenYtT21gqM438HtWNMKrJZ8vV908ptE4HiKN2Z+/UhAwL2+V4niCjx62csM0Qa7ICUiqTQqQrpc06XZluEQ3vXwGF4WEVMHjKVIK/q1hRcP20/wSsiM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1721030893276641.063487278865; Mon, 15 Jul 2024 01:08:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sTGjg-0002VG-Cb; Mon, 15 Jul 2024 04:07:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTGjd-0002SS-Cs; Mon, 15 Jul 2024 04:07:01 -0400 Received: from mgamail.intel.com ([192.198.163.8]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sTGja-00047o-QE; Mon, 15 Jul 2024 04:07:00 -0400 Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2024 01:06:36 -0700 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.36]) by fmviesa009.fm.intel.com with ESMTP; 15 Jul 2024 01:06:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721030819; x=1752566819; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=cr4JZh2ySHCLoxlwCyTJncZxcFpDBYjniajzxyU5f7w=; b=X65XGRPwa3e72+NIh9GKlcmQ1Nt04zWpRH/ZdS0pDvytslJaS0yJwUo3 Rqq82GPwVzLJ8fZ570WYOlzudSDibomrKVUVI27HtEvnh+zkVmfh20AkP fYZrfQH5AdXj97FiMNTyPAnfER+n55OV8C39avBKaxBcHW6sJ3AVu/gso P3r/zTkBuiqs4Eee1s6OG45truttfAXBgvNOqKmIzpScv35LieG8TRaEW 7eqQS341CfNb0R7G7IFds7SC1wMk13Zg+Rhs4yQwrepvoy3fG4C89tFpG AudTGtB9ijSIp6u/2XTV6he3GqCvXbjEFfj/L3K+6Hm+VRhUlDpAU35GS A==; X-CSE-ConnectionGUID: 3pRdSiAuQr2tHeqKj2Ei/w== X-CSE-MsgGUID: EZ+sMNkDTqSzMK6Ec+EpZA== X-IronPort-AV: E=McAfee;i="6700,10204,11133"; a="35935645" X-IronPort-AV: E=Sophos;i="6.09,209,1716274800"; d="scan'208";a="35935645" X-CSE-ConnectionGUID: 98Xu5bW2SkmFPUCdK1+h/w== X-CSE-MsgGUID: aO1aHOwzTyKIcfBKFXYx6g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,209,1716274800"; d="scan'208";a="49512580" From: Zhao Liu To: Michael Tokarev , Laurent Vivier Cc: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Markus Armbruster , Eric Blake , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Zhao Liu Subject: [PATCH 2/7] hw/usb/host-libusb: Get rid of qemu_open_old() Date: Mon, 15 Jul 2024 16:21:50 +0800 Message-Id: <20240715082155.28771-3-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240715082155.28771-1-zhao1.liu@intel.com> References: <20240715082155.28771-1-zhao1.liu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.8; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1721030894753116601 Content-Type: text/plain; charset="utf-8" For qemu_open_old(), osdep.h said: > Don't introduce new usage of this function, prefer the following > qemu_open/qemu_create that take an "Error **errp". So replace qemu_open_old() with qemu_open(). Signed-off-by: Zhao Liu Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/host-libusb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/usb/host-libusb.c b/hw/usb/host-libusb.c index 80122b41259a..691bc881fbcd 100644 --- a/hw/usb/host-libusb.c +++ b/hw/usb/host-libusb.c @@ -1212,9 +1212,8 @@ static void usb_host_realize(USBDevice *udev, Error *= *errp) if (s->hostdevice) { int fd; s->needs_autoscan =3D false; - fd =3D qemu_open_old(s->hostdevice, O_RDWR); + fd =3D qemu_open(s->hostdevice, O_RDWR, errp); if (fd < 0) { - error_setg_errno(errp, errno, "failed to open %s", s->hostdevi= ce); return; } rc =3D usb_host_open(s, NULL, fd); --=20 2.34.1