From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720168966; cv=none; d=zohomail.com; s=zohoarc; b=P68C0LtDz749no7UnjvIJkb4F4VrcAtNC7gY/roeX5as7at2OXY55NtmlQOP2Qx0MsWS/zq0oP4JsWZB4PZArKiDboy/YqqLha1RM1yR6wQ6QpqribzyIo9GomhEXY3A8nYTtUSpbdLEpnk3x6qr3oFSQ9yxu3oZzFf17JqmrZg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720168966; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0F1ubdjTjfUgOjFoVtYGFPGbIziBRq1wNHSOYJr4Cqo=; b=W6q+SZF7Rc9N5zJm+LbN4IjRt262fAGk+yWx3A9NxFlt3Obz8xed/zQYDlETYi8Iew2rUoiczZJmJGKB52X1ZDhGCe3ZuKBAe4PALTcHh/ZNvEYCjEJp2OLkhA0ihjNOT5LWm3afquPASoPdcmveE0RUm86/mJ7yaGZVgCun3V0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720168966256889.2896221185556; Fri, 5 Jul 2024 01:42:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeV2-0008Tp-JY; Fri, 05 Jul 2024 04:41:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeV0-0008Q2-7L for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:40:58 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeUv-0003Aj-Dw for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:40:57 -0400 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-58b0dddab8cso2259777a12.0 for ; Fri, 05 Jul 2024 01:40:50 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58cb2b83380sm3333502a12.74.2024.07.05.01.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:48 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id C44435F8AF; Fri, 5 Jul 2024 09:40:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168850; x=1720773650; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0F1ubdjTjfUgOjFoVtYGFPGbIziBRq1wNHSOYJr4Cqo=; b=T0alJLfwWI7MZDT8YXo9MU695xBz8ct2IHYZ4eQ6NGR2phNvQCWTjJrCVBmwKJbR8e FU+6bZIhSFclENE2ghVmSyla5qj5ZxMRO8Lk4rt6r4sNGR8DbZe/bBuRDP26JsIJFGyy xXeHbkNsmzOsDsiAyMEU6CFerQkueorPwq6aqVl2Ng9wwarvbhpn3rOw/uiMEkxmW3gT HYecYY/UbSCDSQoumE6r6Sw78txq0T58M+CtQ9oAZKXea3Kz1a5O9eKhuWX57DvZAbaV fLfDti3/0Jz1mnz9aFvZClVyNBbElkC7bPv/pBOFX9oQSEr50crPCpQU3KUoxiuwKO+u sWiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168850; x=1720773650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0F1ubdjTjfUgOjFoVtYGFPGbIziBRq1wNHSOYJr4Cqo=; b=TTYKKh94aGYnsgnxHJFQH5Kje0Pq8GEql+Ojwjs+Px71axREGlAm8kYP3gB0e1w5FG T4KQrLfIMyJVKiK0WhrT8G7H2+W0SUkomWTAkocvXaux55BER/TMHjChS1/kLqEe2xJG ah7zh9jwxib25mXe2Xi8G9Vjp8NcMJ0uGZ4EYVh5Wk6Ihv1XW4lFeGpZQ+nUHgtGWAQx uOEtxbAbHE+BtXnUrMPGZyU0qCPDm3PCIXCxC8oFPublYqMTLJwJz8WbmX7UknNMZ50a 2VwLoFEUP2tG4pZgfefoOGX4TwS5NZmDaZtn6hOx1WSE5IcG7o7CMPPPtGeCTMooP8VA 5yxA== X-Gm-Message-State: AOJu0YxZTrndpoCvJ3pb6xBzm1ERreO0ck0cnPQpvp+ryuxonWE/TMgm bU3Eld96IojbfsyWpne/zB7StKH5kE6pOk8gYLv4KpZseCvg1jpv12ArGl1DsWA= X-Google-Smtp-Source: AGHT+IFW3Y03zwSxGnaJubf7MbKYPWgM/N2gBI0ZffN4L/lJ6xltOb1sdohV+6nFHC6coxWP2TCfpQ== X-Received: by 2002:a05:6402:1d4e:b0:57c:5fcf:b570 with SMTP id 4fb4d7f45d1cf-58e5aecb1d7mr2823840a12.32.1720168849351; Fri, 05 Jul 2024 01:40:49 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 01/40] tests/lcitool: fix debian-i686-cross toolchain prefix Date: Fri, 5 Jul 2024 09:40:08 +0100 Message-Id: <20240705084047.857176-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720168966628100001 I guess we never noticed and tried to build with this cross image. Fix the toolchain prefix so we actually build 32 bit images. Message-Id: <20240628124258.832466-2-alex.bennee@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e --- tests/docker/dockerfiles/debian-i686-cross.docker | 2 +- tests/lcitool/refresh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/docker/dockerfiles/debian-i686-cross.docker b/tests/dock= er/dockerfiles/debian-i686-cross.docker index f1e5b0b877..f4ef054a2e 100644 --- a/tests/docker/dockerfiles/debian-i686-cross.docker +++ b/tests/docker/dockerfiles/debian-i686-cross.docker @@ -169,7 +169,7 @@ endian =3D 'little'\n" > /usr/local/share/meson/cross/i= 686-linux-gnu && \ =20 ENV ABI "i686-linux-gnu" ENV MESON_OPTS "--cross-file=3Di686-linux-gnu" -ENV QEMU_CONFIGURE_OPTS --cross-prefix=3Dx86_64-linux-gnu- +ENV QEMU_CONFIGURE_OPTS --cross-prefix=3Di686-linux-gnu- ENV DEF_TARGET_LIST x86_64-softmmu,x86_64-linux-user,i386-softmmu,i386-lin= ux-user # As a final step configure the user (if env is defined) ARG USER diff --git a/tests/lcitool/refresh b/tests/lcitool/refresh index b25e3ac4dd..ac803e34f1 100755 --- a/tests/lcitool/refresh +++ b/tests/lcitool/refresh @@ -167,7 +167,7 @@ try: =20 generate_dockerfile("debian-i686-cross", "debian-11", cross=3D"i686", - trailer=3Dcross_build("x86_64-linux-gnu-", + trailer=3Dcross_build("i686-linux-gnu-", "x86_64-softmmu," "x86_64-linux-user," "i386-softmmu,i386-linux-user"= )) --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720168913; cv=none; d=zohomail.com; s=zohoarc; b=MimEtvt33ATb4EUDZm5THfpPY9gYCZC1LtP/sB25Gjaw6ytWignyYr4fqk0Dyk6WROFtd1ErFZAhKwcjxvH4mBh0ou/UitDxdIM1ajfGpAuyK/8qPurBZO1fEVooH4KqMYAdtrEFvP76dZrOKTtDp22b9Sfk+GF+AudUFkywS0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720168913; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bmUkQvx1dTB8+ePPVm90+LdKbwFZU9qtx5zavLenp5Q=; b=kQDYz3S2BulS90H6F7y8IyRKEbWKdJlNHOPJSUlZ71/agLf/Qz1lRdUnWeQ0lAl1ue09nNAGa8deOmFoMsfVgxjwQ7Y/uVJvRCPGpZ91KLHyE2E5ihyy6chjVfzLMVKrflC2xns+XzN+lbPsDHzthEza7t4PR2ODYrX7lEtuSLc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720168913625777.5160114572761; Fri, 5 Jul 2024 01:41:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeV0-0008Pq-1f; Fri, 05 Jul 2024 04:40:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeUx-0008O9-HX for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:40:55 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeUt-0003An-MZ for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:40:54 -0400 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a77c25beae1so122073566b.2 for ; Fri, 05 Jul 2024 01:40:51 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab0b56e6sm656502566b.202.2024.07.05.01.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:48 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id DA1F95F92A; Fri, 5 Jul 2024 09:40:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168850; x=1720773650; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bmUkQvx1dTB8+ePPVm90+LdKbwFZU9qtx5zavLenp5Q=; b=k4sZbqJFw1RUoUrV6XWEpXc/BpKiGMgIxOXbwv+s/ZyRIQGltrv1fIEq81K95a21Kw 6R4MwrNvK6XVhkFthDDBmfkEvsw/W8OxICBy3GKyrWoCHTVk/P2I9L1QVBBL9iC0CIv9 sfOXBPh3cJyI+aOobKa1PnRzxkNCyeMYveVtFiMKfQYPW9dZNd5qXYG9IbfozLS/HkQq WwyvqShHVlgqWxY+HqH79m6BnBrQ+MBi5iCUA2aqeq27FmsitNLAE+DTYdvRo/ezfokc Rb5iI82TuWUZS3kc26LdH8uN8hQYmBBy9Ggd/8wHprmqnUVAp6DHGtuBKM2FE71Nc+nE eRBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168850; x=1720773650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bmUkQvx1dTB8+ePPVm90+LdKbwFZU9qtx5zavLenp5Q=; b=MmTyxzDoE9sr58UWvEKFWI6KYNJ+5IwYyDko3vuRkzuhPZwU4k2gyd9ty1O7Q/t0X7 PXNuFGZzm09PRTeWLz57B2NPwCpzXbeWW5DETEQqBqbhKldj6rgRJB6J8z6P6U54l36m oSuiHRh94qelNjYRpOk1KKr0TUoVkIc0fp8swRww31O7N4UNfnm9g1i444Mj1yKPCLMY VR9rv/U2h1oSWIlvHAT56gZpBujs0sSfia3SH/4Qxs8da8juUx5hzOftzwgKHL4iM32s ROr0qUvxmF2FpzWSg571pJmS2Y6UB3JgS4YDhSBzZ8XDRGUoCNiDQho4N0a5TD8/m1RP GfmQ== X-Gm-Message-State: AOJu0YyDQV3V3GD/TTW8Aky9SagDyR3+fvWaYJYNc9Wt+WWfJI8jOwGX PAtOoA3bCOyBlJZKjP9QAmoEb8BrVUrYrO67FqJF1qDmot/L8c2wM7RW75RoJqg= X-Google-Smtp-Source: AGHT+IE3NrdBl5Ki9NzL085dznEQEjUe3VQGIfwJKOG7VhYN56mjbWrRb1W3GeIKHIy2b9hSvND/8A== X-Received: by 2002:a17:907:969e:b0:a77:ab40:6d7f with SMTP id a640c23a62f3a-a77ba482a47mr330935666b.43.1720168849744; Fri, 05 Jul 2024 01:40:49 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 02/40] testing: restore some testing for i686 Date: Fri, 5 Jul 2024 09:40:09 +0100 Message-Id: <20240705084047.857176-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720168914330100003 The commit 4f9a8315e6 (gitlab-ci.d/crossbuilds: Drop the i386 system emulation job) was a little too aggressive dropping testing for 32 bit system builds. Partially revert but using the debian-i686 cross build images this time as fedora has deprecated the 32 bit stuff. As the SEV breakage gets in the way and its TCG issues we want to catch I've added --disable-kvm to the build. Reported-by: Richard Henderson Suggested-by: Thomas Huth Signed-off-by: Alex Benn=C3=A9e --- v2 - add --disable-kvm - currently blocked by https://gitlab.com/qemu-project/qemu/-/issues/2413 --- .gitlab-ci.d/crossbuilds.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 47bdb99b5b..3de0341afe 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -37,6 +37,17 @@ cross-arm64-kvm-only: IMAGE: debian-arm64-cross EXTRA_CONFIGURE_OPTS: --disable-tcg --without-default-features =20 +cross-i686-system: + extends: + - .cross_system_build_job + - .cross_test_artifacts + needs: + job: i686-debian-cross-container + variables: + IMAGE: debian-i686-cross + EXTRA_CONFIGURE_OPTS: --disable-kvm + MAKE_CHECK_ARGS: check-qtest + cross-i686-user: extends: - .cross_user_build_job --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720168892; cv=none; d=zohomail.com; s=zohoarc; b=dlZLAyizWe6+jtSM2/3qWSQQ1WrL9vL2iJZkDgUeSk1S2RrrkJlqr8kPD8ThAkZ0zaU2oDFQ1KGqv7tAOhBArEr/mLYuzYid6Ln8q2jhTpM/zfugPDXVTiK3Rab4FDbCjOKzgFsvY6tNb687r2csOF2HMQvdSD73evOggq0vY1c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720168892; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lFrU6v/HY4VIQITgassfFHdNS/uhlHYlsqE77XfqPZs=; b=cHSG6KR5LM901DnhKKxSLb/KgeXG4ipIeokBjC01vg5xUZLgT5yZ2HqTtlgaXrA8zJK79l6j99zmhWgYOOmFurud6gd1ecokSBdHzxBfQORh5F2CAA0FkXE5qNKpWM3VgPO/tBUvBU+N2NKmkabAnM2faHNzzWepUB9QPM5Yo0Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720168892527966.8108257333464; Fri, 5 Jul 2024 01:41:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeV1-0008Q9-3O; Fri, 05 Jul 2024 04:40:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeUy-0008Oz-Lt for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:40:56 -0400 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeUv-0003Ay-6s for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:40:56 -0400 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-58b447c513aso1603325a12.2 for ; Fri, 05 Jul 2024 01:40:51 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58ad8730dcfsm5113394a12.7.2024.07.05.01.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:49 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id F102B5F92B; Fri, 5 Jul 2024 09:40:47 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168850; x=1720773650; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lFrU6v/HY4VIQITgassfFHdNS/uhlHYlsqE77XfqPZs=; b=AzkkqL450gSHHsGVLbtLqWdfec+mJ03Lhh673oDIwb8ypGeUDu8dBt+148Zd99sy5j 4mvM6Vi+xIZc1rya7pJ9fR3p4xbn5FD6w+iXuB9nzBjbCGhWEQ2fmdDsbnxsf6biHZ+3 B85HTqa+YAxRSj6YsdKYFdht55i9R+ZAPnBb+qZbhrcIKgDKruV/QWOrpyylfx9ekCSP pAPjHg7OzZE4BncJdw/HWwdu1rt8uak/S5FQL76sFPpjGadNuDYYUiS2LHpqGmF0Zwn2 hZKRBJEok2eiaXCRF4/1OW1oozmBYzZn1vJvbZ/W0oEyNKGXOn4r3yte2bSI6FFsAuqh +BEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168850; x=1720773650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lFrU6v/HY4VIQITgassfFHdNS/uhlHYlsqE77XfqPZs=; b=AXaFWGVwFp48+n9RkUEp9kSoaH7jEgSlpHB9X19nknDd391Wj4OwaUgw5oxPFdn3kW kSUM/j+H95Dql94DKoHbrfR9SvoEcImJKoSmieC9CdwfLHsLnyIseZvvkMMmsAh/Koda XmCqle2ZtaddZ2EB6X3LiNiC7iKKA40O1e8vvK9RzWO0REKPp5KkC3TACAVsh71CdJaJ +xxByx5QL5ZEQWcR4C8jjMh+xNJwSiJhVAClzBsmUoovJncAuCCWI31nyUxbjqABvf/S 4O7YdKVhKrEhKn2cRPkmLLMA3P5QCflZpZn6RtD/o7bHe/FASejdQ5MdJYbpJRC7YSUU WKdA== X-Gm-Message-State: AOJu0Yy/zf2AN84Z5rU+nARZZIq3rv4MIQiw9wT+ZNyXH+2iEfoM2XJ0 DPyMswFyfGjzE3AIBChj5OGOAZoj0oiiuwBar49LGET9vr3q8jTgJ4e7zt859KY= X-Google-Smtp-Source: AGHT+IEo1flafWU6+cEdwievaIimim5rz1ZpyRSPd/NRdT7yRN98lzK6pWrUpa6eCwXBYCDy2jZVZQ== X-Received: by 2002:a05:6402:278e:b0:58b:fd23:7065 with SMTP id 4fb4d7f45d1cf-58e5aec8d0amr2298950a12.16.1720168850164; Fri, 05 Jul 2024 01:40:50 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 03/40] tracepoints: move physmem trace points Date: Fri, 5 Jul 2024 09:40:10 +0100 Message-Id: <20240705084047.857176-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720168894290100002 They don't need to be in the global trace-events file and can have a local trace header. Also add address_space_map tracepoint for tracking mapping behaviour. Message-Id: <20240628124258.832466-5-alex.bennee@linaro.org> Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- v2 - dropped qatomic_set which came from another patch --- system/physmem.c | 4 +++- system/trace-events | 6 ++++++ trace-events | 5 ----- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/system/physmem.c b/system/physmem.c index 261196cde0..14aa025d41 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -53,7 +53,7 @@ #include "sysemu/hostmem.h" #include "sysemu/hw_accel.h" #include "sysemu/xen-mapcache.h" -#include "trace/trace-root.h" +#include "trace.h" =20 #ifdef CONFIG_FALLOCATE_PUNCH_HOLE #include @@ -3193,6 +3193,8 @@ void *address_space_map(AddressSpace *as, MemoryRegion *mr; FlatView *fv; =20 + trace_address_space_map(as, addr, len, is_write, *(uint32_t *) &attrs); + if (len =3D=3D 0) { return NULL; } diff --git a/system/trace-events b/system/trace-events index 69c9044151..2ed1d59b1f 100644 --- a/system/trace-events +++ b/system/trace-events @@ -21,6 +21,12 @@ flatview_destroy(void *view, void *root) "%p (root %p)" flatview_destroy_rcu(void *view, void *root) "%p (root %p)" global_dirty_changed(unsigned int bitmask) "bitmask 0x%"PRIx32 =20 +# physmem.c +address_space_map(void *as, uint64_t addr, uint64_t len, bool is_write, ui= nt32_t attrs) "as:%p addr 0x%"PRIx64":%"PRIx64" write:%d attrs:0x%x" +find_ram_offset(uint64_t size, uint64_t offset) "size: 0x%" PRIx64 " @ 0x%= " PRIx64 +find_ram_offset_loop(uint64_t size, uint64_t candidate, uint64_t offset, u= int64_t next, uint64_t mingap) "trying size: 0x%" PRIx64 " @ 0x%" PRIx64 ",= offset: 0x%" PRIx64" next: 0x%" PRIx64 " mingap: 0x%" PRIx64 +ram_block_discard_range(const char *rbname, void *hva, size_t length, bool= need_madvise, bool need_fallocate, int ret) "%s@%p + 0x%zx: madvise: %d fa= llocate: %d ret: %d" + # cpus.c vm_stop_flush_all(int ret) "ret %d" =20 diff --git a/trace-events b/trace-events index dd318ed1af..9cb96f64c4 100644 --- a/trace-events +++ b/trace-events @@ -37,11 +37,6 @@ dma_complete(void *dbs, int ret, void *cb) "dbs=3D%p ret= =3D%d cb=3D%p" dma_blk_cb(void *dbs, int ret) "dbs=3D%p ret=3D%d" dma_map_wait(void *dbs) "dbs=3D%p" =20 -# exec.c -find_ram_offset(uint64_t size, uint64_t offset) "size: 0x%" PRIx64 " @ 0x%= " PRIx64 -find_ram_offset_loop(uint64_t size, uint64_t candidate, uint64_t offset, u= int64_t next, uint64_t mingap) "trying size: 0x%" PRIx64 " @ 0x%" PRIx64 ",= offset: 0x%" PRIx64" next: 0x%" PRIx64 " mingap: 0x%" PRIx64 -ram_block_discard_range(const char *rbname, void *hva, size_t length, bool= need_madvise, bool need_fallocate, int ret) "%s@%p + 0x%zx: madvise: %d fa= llocate: %d ret: %d" - # job.c job_state_transition(void *job, int ret, const char *legal, const char *s= 0, const char *s1) "job %p (ret: %d) attempting %s transition (%s-->%s)" job_apply_verb(void *job, const char *state, const char *verb, const char = *legal) "job %p in state %s; applying verb %s (%s)" --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720168893; cv=none; d=zohomail.com; s=zohoarc; b=JfSRdQvozxTEovVciZnXagP2W4Py5wlYhc1bH6Ui/bmNu3Oeon9vs/VqPqL6k5ByAoYVjcaia7aYStD98lPa8Pag+D0Klb2YQjMuowmIgIo6y0PGGsyeXwiongDLO0l+Ng+r44JHBdLincG+WLkDt87/IXlmWxSSVmMeCPD+Ano= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720168893; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mE9NVMNgeMpdIBYLHPdIh0Aogurvyr2VaxgmAxGfLmI=; b=M+MW5C3oobAntm951h5dg47lELIdR3K/OldNWf/8PbBFL2fBcG2c+W6ASEYnWICxPQ0GzyVXug8kR32BOL1IdT54lixx+l2Lk5uM6cNkz1OJrHraRTiEbMtoc7w1e7snXPDdoL7K4ldnPAxM3JTMwV8p3M5spHQ1xYaWHi6ipoM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720168893912731.7306996838628; Fri, 5 Jul 2024 01:41:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeV8-0008WR-2V; Fri, 05 Jul 2024 04:41:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeV2-0008UV-LR for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:00 -0400 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeUv-0003BH-UX for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:00 -0400 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-58f9874aeb4so577454a12.0 for ; Fri, 05 Jul 2024 01:40:53 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab08cab4sm676033266b.144.2024.07.05.01.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:49 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 12DF15F931; Fri, 5 Jul 2024 09:40:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168852; x=1720773652; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mE9NVMNgeMpdIBYLHPdIh0Aogurvyr2VaxgmAxGfLmI=; b=G1CCYvkluMc7MQspvClMYeqWFpbSeBpFY8c+csuObflsApuFr4ulIdMLt8ZbqlaSJ4 lyTYIgBBwu10G2DnMSMVyjhN85Us3bkgU8we2Heb4z+iW3in9WGwecpc3Z5mTi4mt3Oz A6tR0c32r/G1hU2as75ceCAVVhPwurkq73QJbvJcWBn6XYLcPw7gaB19/P+sDW3YSGBi rOdyZdiGV8y4BqzjqeBoCaolrQJvaogSB5JX7B+5/s1w6+/+Uk2LTOnzJx2pj+QDV05K xUW5Z+GUORuU5fgo7qVMT82L4T5qeNzK1Yc0gjn8/nDJ63BPuCeqGy2bWvQg+9sO6Cpy Ua5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168852; x=1720773652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mE9NVMNgeMpdIBYLHPdIh0Aogurvyr2VaxgmAxGfLmI=; b=EwjRX9TT8apUvDAJOFEHhmYVlOuI3jJ3+Gq4S2r0nxoSi5nJml1ObNcfoTckjOKL29 sWZ1v14FEwJa2a/iWkcyklsh/P507PyvQHHrD4k9trE/QFzL7MJFP1/0XbbtNpqHuE8i pVgikAF+O8bUg4y/jTBzrneHmOaLWU3Y39XOyyBW8VNJONGVfVSHtKexnxPhdgWdeA13 krkbVTPHTrjqpHBwaEU/jHi5O9WnCy6XIOf1AVAqyTlogGdXPIGNed6MGC1KUnCs3+AN 1zbUR2kzWcQ7Qa74JwX3SZnF3tdnIqB4EYTNOupaSPWSltIxq/UbR9cjCvO8etfQjT7s Movw== X-Gm-Message-State: AOJu0YxMRVjD57OX5tqekZVSeMNDPHZUheiZ0F2oqWmO0eGMJvp6yEII nwd89EFqLl988DbgIkOi+PW9Bjb8aH3V67+pqLEYpBtZ5EGAEk2f/uKe/eqawwA= X-Google-Smtp-Source: AGHT+IEeO1/sqUuuC8SZJQjdD45rKtJMDlDVFybbCtYFEltmJ4hvWjwoT48+3pL0h/SFkNCRkNu6Ag== X-Received: by 2002:a17:906:13db:b0:a77:cca9:b21c with SMTP id a640c23a62f3a-a77cca9b865mr68617566b.34.1720168852016; Fri, 05 Jul 2024 01:40:52 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 04/40] hw/core: ensure kernel_end never gets used undefined Date: Fri, 5 Jul 2024 09:40:11 +0100 Message-Id: <20240705084047.857176-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720168894277100001 Really the problem here is the return values of fit_load_[kernel|fdt]() are= a little all over the place. However we don't want to somehow get through not having set kernel_end and having it just be random unused data. The compiler complained on an --enable-gcov build: In file included from ../../hw/core/loader-fit.c:20: /home/alex/lsrc/qemu.git/include/qemu/osdep.h: In function =E2=80=98load_= fit=E2=80=99: /home/alex/lsrc/qemu.git/include/qemu/osdep.h:486:45: error: =E2=80=98ker= nel_end=E2=80=99 may be used uninitialized [-Werror=3Dmaybe-uninitialized] 486 | #define ROUND_UP(n, d) ROUND_DOWN((n) + (d) - 1, (d)) | ^ ../../hw/core/loader-fit.c:270:12: note: =E2=80=98kernel_end=E2=80=99 was= declared here 270 | hwaddr kernel_end; | ^~~~~~~~~~ Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Manos Pitsidianakis --- hw/core/loader-fit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/loader-fit.c b/hw/core/loader-fit.c index 9f20007dbb..7ccc9d5fbc 100644 --- a/hw/core/loader-fit.c +++ b/hw/core/loader-fit.c @@ -267,7 +267,7 @@ int load_fit(const struct fit_loader *ldr, const char *= filename, void *opaque) const char *def_cfg_name; char path[FIT_LOADER_MAX_PATH]; int itb_size, configs, cfg_off, off; - hwaddr kernel_end; + hwaddr kernel_end =3D 0; int ret; =20 itb =3D load_device_tree(filename, &itb_size); --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169094; cv=none; d=zohomail.com; s=zohoarc; b=hKIlVHlU25aOASuqFTE86TyqlRt2BB4yxkURkdA96nTsD3flbayLAI6bYmcCyHe7IbSY7l6oHSlgp6Qvurt5Ky5Ra4/vFzrsbDUzgOT606pPKnEmzzm9+KPoYHixwptuOUAuDOVOl/ipLCb3Ku4AVZ4Vq/UiYdoGAsnTXvctIYI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169094; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=k9Mm2xBLn8Ufe39/+67RjiS06msB6AjL659puseOu/8=; b=HJkjzR62QkzyxVHQ1hcd/pLWrVFK0e2Xd5R81dP3ClKCqtnKBS4Yui9yHYxl2L2YcIpLYeHE6Wf0i0gPKZga0ulwVW5dwbgaMLm9+EgPU9NKvcwkXltDpogvRtiUNkxzKBLeRxL6s24b+hchoZeOqqYPEIgfmCRdsZsTZHpNBBI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169094919468.45932394464774; Fri, 5 Jul 2024 01:44:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVT-0000RB-Aj; Fri, 05 Jul 2024 04:41:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeV3-0008VH-MU for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:01 -0400 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeUx-0003BL-A7 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:01 -0400 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-58bac81f419so1968361a12.0 for ; Fri, 05 Jul 2024 01:40:53 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a75390ca05fsm349797666b.92.2024.07.05.01.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:50 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 293065F935; Fri, 5 Jul 2024 09:40:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168853; x=1720773653; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k9Mm2xBLn8Ufe39/+67RjiS06msB6AjL659puseOu/8=; b=z5s69qjXTsB5rWhOXDAiFMA5iNNm8R4hU9jBH7GNN9S4rfJ6JDrcu0SZfjMdMO/6/+ 52Bubn/a0KYskr4EgaPA3C0yFuYjjG9kFDWLHg6Jo9wgbLh1ecfmMYg86CTteWFUDeuC +mQNwP0S3aNDXMUU0g3uEFRrXDwOirayjOyYHPkEbYbarloqKlgbWiwjFmov9XS3VYBK TMBWDt+HtXEor/UvuDMxVMC3m8b7uqbO+TbaGe+joUIcH+z5KjZZQ7Dp2yhUCR8CiaaL g0Gdj9F5MjOD9x+zgWywOoTOIWLlBO278NM1cw56Rv0hsaaHHBq7EotdpuNU15B7Y/A1 3jmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168853; x=1720773653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k9Mm2xBLn8Ufe39/+67RjiS06msB6AjL659puseOu/8=; b=ZZLMHtk+HXFcRJ/Hvu4L2o4KcNnqOCxK9doQ9ay8wAQrWP2XYujQZHNQ/qNiaMK+yT Jpeo6AE3FeLBsseBQS001+KAeXkOixDXB/1OTdYOA+gX0aYV4yf2T6dXYwmRq4y/gnI8 nnSlLlbDPwV9MCyRSGXO6qDGvGp2WYH+4UQOYz6/dOCLUA0MbmDm4WEF+0AXLWeEuOgk HDu1X1CLYb2osCA/WaFPTwUT8CbVW13eULVnoKEQyPSxStPLSLB3dZ1RYTAZF5J3f2TW 7ClxA3hdj9wuCCCljtB3OCZuoDu5km9n3AIURb9lz6NloqhqeY+POTKhpn6Cbg3PhqQm EN2A== X-Gm-Message-State: AOJu0YzafUeij0xnqMvfqFzq9i7o33YE4RJ8OSts2ZpaRYCuKQTd4eIt LmYXi/KtMJXvPaMrfM4TtfGqZHp89WxP/NqAQV23Kiwc2pgqNvxR0SWLwijV5lU= X-Google-Smtp-Source: AGHT+IGKUDoIsj/94mIK7T0FryPpL7x1ITXmVtQ0E7yFz9LAM4mZ0DQkzZv185jjvMbyAmRj0Hh3Iw== X-Received: by 2002:a17:906:b894:b0:a6f:b9d3:343a with SMTP id a640c23a62f3a-a77ba72c652mr252802166b.71.1720168852406; Fri, 05 Jul 2024 01:40:52 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 05/40] tests/docker: Specify --userns keep-id for Podman Date: Fri, 5 Jul 2024 09:40:12 +0100 Message-Id: <20240705084047.857176-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169095107100001 From: Akihiko Odaki Previously we are always specifying -u $(UID) to match the UID in the container with one outside. This causes a problem with rootless Podman. Rootless Podman remaps user IDs in the container to ones controllable for the current user outside. The -u option instructs Podman to use a specified UID in the container but does not affect the UID remapping. Therefore, the UID in the container can be remapped to some other UID outside the container. This can make the access to bind-mounted volumes fail because the remapped UID mismatches with the owner of the directories. Replace -u $(UID) with --userns keep-id, which fixes the UID remapping. This change is limited to Podman because Docker does not support --userns keep-id. Signed-off-by: Akihiko Odaki Message-Id: <20240626-podman-v1-1-f8c8daf2bb0a@daynix.com> Signed-off-by: Alex Benn=C3=A9e --- tests/docker/Makefile.include | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 8df50a0ca0..708e3a72fb 100644 --- a/tests/docker/Makefile.include +++ b/tests/docker/Makefile.include @@ -207,7 +207,12 @@ docker-run: docker-qemu-src $(call quiet-command, \ $(RUNC) run \ --rm \ - $(if $(NOUSER),,-u $(UID)) \ + $(if $(NOUSER),, \ + $(if $(filter docker,$(RUNC)), \ + -u $(UID), \ + --userns keep-id \ + ) \ + ) \ --security-opt seccomp=3Dunconfined \ $(if $(DEBUG),-ti,) \ $(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=3D$(NETWORK)),--net= =3Dnone) \ --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169060; cv=none; d=zohomail.com; s=zohoarc; b=DfRQqyq31cA28e+z4ACcBuh3zSjwqDlyLzFRWtYBYF5gxGf8+WzfhI/i7H0UfmuRYQp6NPnutxQH+Yg7zE7dvikdfvdCYCB0jV7HXlMuEVNTEW9qVOxagDszrJzgLEGv+KrYT7lnz5+JKVBNKgcZud19KnNw06sgOdDn5jtXi/c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169060; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OZlcNQh9JE8A6UvoUX4jggiwG8ZzlIUOMNu3XJPgKMk=; b=M9Nh9io45qJdOgYlm/35s1CGA1woEKmZ/cklOOv17kEs9GqsFqohLriXSWUugCrd5jKUPNlVpdXMp316eVNEeIui/QoVruAngyXI2SqLWNeK0c/2WHEcWhKlhH81rWwbhAw6dwMuLNs63YHf5AkpINKMJ0NoXNxnKw9E53mI+P0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169060289598.1433194340299; Fri, 5 Jul 2024 01:44:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVN-0000Ek-CV; Fri, 05 Jul 2024 04:41:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeV3-0008VZ-T2 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:01 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeUx-0003Bp-AT for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:01 -0400 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a77c080b521so140625866b.3 for ; Fri, 05 Jul 2024 01:40:54 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77ae3f053esm156573066b.47.2024.07.05.01.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:50 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3E6D95F93A; Fri, 5 Jul 2024 09:40:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168853; x=1720773653; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OZlcNQh9JE8A6UvoUX4jggiwG8ZzlIUOMNu3XJPgKMk=; b=tqhwIlZ6i0zbhhO9DTrUgJdHJ24GekigPUC6We5IxpZ4bBNz/gnf/VhZG1bee99Vgq ALijQtHZYIsSAcjczuz3OXtjduLtEpBt9J1ckcSSQMKANOJVUKYsPFGt/hyeu1SOCUEq aS5jw5oJd7X3ug3o1NgHaSSO/+1zMH/Llo5QjfyRodAyPvON8InqKt0qe5tKtKu2QwnK sUCI1WKak2fMfX5+SiK/RD7JR0DFgd+uJkX7XGKvprroy/ArIwVa23Swf2W7LcA3SJr/ y++WuJEuNug0XP8rDWk+sp+Fg9a3FJzmiDm+IET9d/5WLSLh26j0njPZhVvL2tWHHZbu PIUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168853; x=1720773653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OZlcNQh9JE8A6UvoUX4jggiwG8ZzlIUOMNu3XJPgKMk=; b=aorJxnGcVfgYvBbICVExJwFSo7YzAd2CczDfWM7BHH5yvgxou03F/2up1rVdPtYCZl 1NDmx1VmqPebDt7BCsBRkwAIVDQq46pHlLxZe0JbU5atwtaa+qG3IXc34ckkYwkKFC+x 4DOfGlQ5iU/4FCmSg/bqXfAZBfxw041fe7UXsnqNZltIaNR/A5pDy1w/p3/QO4PeRdXo T+E1RzCzuCWN4pw9aCqOJ5jOpheda+6AplkDnJwA35jcxGjVeNbvJD8iNJSWY3RuPs/U zexjooSZYXG6tZjcHreI/FfdXNinCx42rL++ic0X/tbe07KId23vj0t4SgVdLKpnpomM AEmw== X-Gm-Message-State: AOJu0YxER4GBSm0H2hBjljYxd4iy92qZXEkSdoX+aEJD4SENY9akCcD3 P4Id75UZXtRJzpMrsRDTHpYMcOB/Guq//Apza9PX4swACvGR24B7dRqwkg7dIgk= X-Google-Smtp-Source: AGHT+IGEca9c2y5QxybSWiyxK5SfQYCByhlUDq0Jc+hVCy5ZX/RyNpkogt7N/MWgjassv6y6y/fkSA== X-Received: by 2002:a17:906:c1c4:b0:a77:d9d5:eb6d with SMTP id a640c23a62f3a-a77d9d5f2b4mr19526866b.61.1720168852782; Fri, 05 Jul 2024 01:40:52 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 06/40] tests/tcg/minilib: Constify digits in print_num Date: Fri, 5 Jul 2024 09:40:13 +0100 Message-Id: <20240705084047.857176-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169060962100001 From: Richard Henderson This avoids a memcpy to the stack when compiled with clang. Since we don't enable optimization, nor provide memcpy, this results in an undefined symbol error at link time. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-2-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/minilib/printf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/minilib/printf.c b/tests/tcg/minilib/printf.c index 10472b4f58..fb0189c2bb 100644 --- a/tests/tcg/minilib/printf.c +++ b/tests/tcg/minilib/printf.c @@ -27,7 +27,7 @@ static void print_str(char *s) =20 static void print_num(unsigned long long value, int base) { - char digits[] =3D "0123456789abcdef"; + static const char digits[] =3D "0123456789abcdef"; char buf[32]; int i =3D sizeof(buf) - 2, j; =20 --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720168917; cv=none; d=zohomail.com; s=zohoarc; b=PNS4eJ6+AjkUSoG7FMtkMK3QJLJkj5PPRhVMwzcU7qgW36FLuNqeIg21J3oz3BOHwILWufJ40/UYhSGvNYUNmnLjz9tVhVpOaqJdNHz7ZnHWtYcPz6Zc+ZgSEAeq2i/xyVtPCqVO4Ob7CFz/x/wpTILycA3/wbSarWXBnnaMsSs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720168917; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Gn4+e2+s4PmF4hbnzvZLoM3JOdLV8P43Drx86Z36Eh4=; b=G+NK+f1JIGf9WQ1jhJXiitCUO/MJu39a4uKKTA+6mK+4XhqiWra1CCPhMM1UPBrRIDkKZFwbeBsTqzXkRDfN7MxiUBqNOVtYTjjw5WVQB2D6d140e7vaZsQmWC4g2X441hZbI4FvUJh9x36fzxv93bmhzeeh3P+JJv15CQtN3M8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172016891721787.52554854318771; Fri, 5 Jul 2024 01:41:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVN-0000Fa-P1; Fri, 05 Jul 2024 04:41:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeV6-000055-Ub for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:05 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeUz-0003Dy-1n for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:03 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a77bf336171so193699366b.1 for ; Fri, 05 Jul 2024 01:40:56 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a76841c4ffcsm261248866b.41.2024.07.05.01.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:52 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 5BE075F9EB; Fri, 5 Jul 2024 09:40:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168856; x=1720773656; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gn4+e2+s4PmF4hbnzvZLoM3JOdLV8P43Drx86Z36Eh4=; b=WH79K5jt5VijLPJ9rYTfQ5s3rHxsY5YmItTG25tjZADPX6gA53NJU/UVlaQiiJVT6K L5GhlTaSfKPrjXNNHmCZVXsX8bnJCYDine826jncIsvFZm3uKtIRL8EsTWOzoAQyCLBb bkBrL/LiwvgXYM2We3f/6LBCVskQXZHSrUU3ORIHYrdevWWXzRPdYEz0mFS7uOcqS/Cg +y2cT1zPwf+qCdrXRa5dgQLsluMGWgkPvzT9DScis7NrJPVMf2/daI16DIKnJkVd9kEW WsXJLP2ROK6N6dyvJ2aSAA0LLOYbgbhDqamm3yI1f/LpnrN+lPg0nOtsUhspeTN7ryEF 32rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168856; x=1720773656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gn4+e2+s4PmF4hbnzvZLoM3JOdLV8P43Drx86Z36Eh4=; b=q9ix/iJI3USz6Gxr13cobukTH4yz2BU+bow/X+nVgC4fu4Cq8zpYiWrt3Xk9ttztM2 KHK2YVWAe2fLdEnivxaoUvHNlZGvD9Gal8L8bL2pTspBKp5QvzR3U6gXFsPZlCGMON0G PgIVpyQox2GB2RVpaK+n+eKdTlLecZqOiBXbgn+GchQqzHL7VHom8UpaqkY/xpc9b+iy vFqawCswpbsNuGyUPxq8FsID/cU0uKE8LZtSHFFV8n19P2K3hqc1mmReIiREuS3bJk5E NZhOninMfldLiOxdj7ykOGiu7HWy/ME56KPMustf411KlT+9QfmticV3Pm/ckn1rbWL9 LreA== X-Gm-Message-State: AOJu0Yz9q76A8V9fTcZjyd0egJnX3xn6wIGPdzSKt+ktvWP3ETfBoZOh lce4bc7pPJBFSxdMJmw6u49dLBiBkwn04MXt5eBK9R1HgCMXjgRm6e7KPxW5ru0= X-Google-Smtp-Source: AGHT+IHTYlUK1n7yHNtv5mm3fMcB/Kv3tpsapVRqNhoYCZNR1AFm2JCeHFCr1OeKJeAx8f4QU7MDOQ== X-Received: by 2002:a17:906:f8d4:b0:a77:ba4d:a4ea with SMTP id a640c23a62f3a-a77bda09b81mr283728566b.23.1720168855376; Fri, 05 Jul 2024 01:40:55 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 07/40] tests/tcg: Adjust variable defintion from cc-option Date: Fri, 5 Jul 2024 09:40:14 +0100 Message-Id: <20240705084047.857176-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720168918381100001 From: Richard Henderson Define the variable to the compiler flag used, not "y". This avoids replication of the compiler flag itself. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-3-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/Makefile.target | 2 +- tests/tcg/aarch64/Makefile.softmmu-target | 2 +- tests/tcg/aarch64/Makefile.target | 15 ++++++++------- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index f21be50d3b..cb8cfeb6da 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -49,7 +49,7 @@ quiet-command =3D $(call quiet-@,$2,$3)$1 =20 cc-test =3D $(CC) -Werror $1 -c -o /dev/null -xc /dev/null >/dev/null 2>&1 cc-option =3D if $(call cc-test, $1); then \ - echo "$(TARGET_PREFIX)$1 detected" && echo "$(strip $2)=3Dy" >&3; else= \ + echo "$(TARGET_PREFIX)$1 detected" && echo "$(strip $2)=3D$(strip $1)"= >&3; else \ echo "$(TARGET_PREFIX)$1 not detected"; fi =20 # $1 =3D test name, $2 =3D cmd, $3 =3D desc diff --git a/tests/tcg/aarch64/Makefile.softmmu-target b/tests/tcg/aarch64/= Makefile.softmmu-target index 4b03ef602e..39d3f961c5 100644 --- a/tests/tcg/aarch64/Makefile.softmmu-target +++ b/tests/tcg/aarch64/Makefile.softmmu-target @@ -81,7 +81,7 @@ run-memory-replay: memory-replay run-memory-record EXTRA_RUNS+=3Drun-memory-replay =20 ifneq ($(CROSS_CC_HAS_ARMV8_3),) -pauth-3: CFLAGS +=3D -march=3Darmv8.3-a +pauth-3: CFLAGS +=3D $(CROSS_CC_HAS_ARMV8_3) else pauth-3: $(call skip-test, "BUILD of $@", "missing compiler support") diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile= .target index 4ecbca6a41..11ccde5579 100644 --- a/tests/tcg/aarch64/Makefile.target +++ b/tests/tcg/aarch64/Makefile.target @@ -32,17 +32,17 @@ config-cc.mak: Makefile =20 ifneq ($(CROSS_CC_HAS_ARMV8_2),) AARCH64_TESTS +=3D dcpop -dcpop: CFLAGS +=3D -march=3Darmv8.2-a +dcpop: CFLAGS +=3D $(CROSS_CC_HAS_ARMV8_2) endif ifneq ($(CROSS_CC_HAS_ARMV8_5),) AARCH64_TESTS +=3D dcpodp -dcpodp: CFLAGS +=3D -march=3Darmv8.5-a +dcpodp: CFLAGS +=3D $(CROSS_CC_HAS_ARMV8_5) endif =20 # Pauth Tests ifneq ($(CROSS_CC_HAS_ARMV8_3),) AARCH64_TESTS +=3D pauth-1 pauth-2 pauth-4 pauth-5 test-2375 -pauth-%: CFLAGS +=3D -march=3Darmv8.3-a +pauth-%: CFLAGS +=3D $(CROSS_CC_HAS_ARMV8_3) test-2375: CFLAGS +=3D -march=3Darmv8.3-a run-pauth-1: QEMU_OPTS +=3D -cpu max run-pauth-2: QEMU_OPTS +=3D -cpu max @@ -55,7 +55,7 @@ endif # bti-1 tests the elf notes, so we require special compiler support. ifneq ($(CROSS_CC_HAS_ARMV8_BTI),) AARCH64_TESTS +=3D bti-1 bti-3 -bti-1 bti-3: CFLAGS +=3D -fno-stack-protector -mbranch-protection=3Dstanda= rd +bti-1 bti-3: CFLAGS +=3D -fno-stack-protector $(CROSS_CC_HAS_ARMV8_BTI) bti-1 bti-3: LDFLAGS +=3D -nostdlib endif # bti-2 tests PROT_BTI, so no special compiler support required. @@ -64,12 +64,13 @@ AARCH64_TESTS +=3D bti-2 # MTE Tests ifneq ($(CROSS_CC_HAS_ARMV8_MTE),) AARCH64_TESTS +=3D mte-1 mte-2 mte-3 mte-4 mte-5 mte-6 mte-7 -mte-%: CFLAGS +=3D -march=3Darmv8.5-a+memtag +mte-%: CFLAGS +=3D $(CROSS_CC_HAS_ARMV8_MTE) endif =20 # SME Tests ifneq ($(CROSS_AS_HAS_ARMV9_SME),) AARCH64_TESTS +=3D sme-outprod1 sme-smopa-1 sme-smopa-2 +sme-outprod1 sme-smopa-1 sme-smopa-2: CFLAGS +=3D $(CROSS_AS_HAS_ARMV9_SME) endif =20 # System Registers Tests @@ -99,7 +100,7 @@ TESTS +=3D sha512-vector ifneq ($(CROSS_CC_HAS_SVE),) # SVE ioctl test AARCH64_TESTS +=3D sve-ioctls -sve-ioctls: CFLAGS+=3D-march=3Darmv8.1-a+sve +sve-ioctls: CFLAGS +=3D $(CROSS_CC_HAS_SVE) =20 sha512-sve: CFLAGS=3D-O3 -march=3Darmv8.1-a+sve sha512-sve: sha512.c @@ -134,7 +135,7 @@ endif =20 ifneq ($(CROSS_CC_HAS_SVE2),) AARCH64_TESTS +=3D test-826 -test-826: CFLAGS+=3D-march=3Darmv8.1-a+sve2 +test-826: CFLAGS +=3D $(CROSS_CC_HAS_SVE2) endif =20 TESTS +=3D $(AARCH64_TESTS) --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169118; cv=none; d=zohomail.com; s=zohoarc; b=DuSBHvWbnIVcFkl3K6GDVo7verL+/NceEPjcdE/ANZPfebbhdBl3q9yH0sUWRihlQTeBrfej2RUxURMvLY942tXMeawChAHraDPR8yDgBd9mX5yKO/038BrLdH5mBAQduDReL0hM0oKtREcUDtMlwNEjbr0JeyrM1Sk88hY/XpQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169118; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5FfVguGP0p6xgM9XriF2Mad9KHJXeUAUG8KZ4GyS1NQ=; b=m8n9lImUbKrh7gz98Dj8g06UEI5zU4nOTjciV+w1phcEv23/Cl0cccpYaRB1sWRi+8S3YyqeFietvsH0x/ONYO8dHVjclF28YoNWYFs4EpSDaBbb4bLmjIZyHE2rbzSR1LvJSivUU6khnQY8PyPSFw67378biMAEXInfWVNdkHk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169118860797.2766829821222; Fri, 5 Jul 2024 01:45:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVT-0000ha-DV; Fri, 05 Jul 2024 04:41:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeV7-000059-Pd for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:05 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeUz-0003E4-F0 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:05 -0400 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-58b447c511eso1826305a12.2 for ; Fri, 05 Jul 2024 01:40:57 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58612c834e1sm9418172a12.1.2024.07.05.01.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:52 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 72CE65F9ED; Fri, 5 Jul 2024 09:40:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168856; x=1720773656; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5FfVguGP0p6xgM9XriF2Mad9KHJXeUAUG8KZ4GyS1NQ=; b=ea7ozpptbws+5K7sVD0qN2OvSgQof2ArzFRMQVJ8sHOfXdXUk0CP2Gm6m1sNCHdTSF uRsj8D33m6I+vhq+huwMOQw2VkFVZqlKsu1O85Qwo4yXea3txAtfpREAOm24qWHtV+wm ahBpohmM+MXyFO7LKys8ZceAlXSrj5MVJWaPscxlirOFp7rdSiuhdswQrmYrl4G/DV6B G8Ri2lB2aa7hg+ky98xXy6T4S/MfcIEhIibF161pvURDtv3oJrEHET1J32/hzUzEYUOd IwzaHi1DB+2dZBw7SwsMVRLnhns1+AJowYmwa3px+6+xG2UFGH8GDJ/1snashXsumlGx OD7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168856; x=1720773656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5FfVguGP0p6xgM9XriF2Mad9KHJXeUAUG8KZ4GyS1NQ=; b=cnsu2sp6lVgzkJgsKXp7diI9VGFZVBzOUk/TAEy25KfoPEkVmRG+rbj0WRfa1+upol GVnHSq4km9RIgZ3P9tvfgvPWNe96oCsaIryZJ9U1DkVGduiYGNaEXOc06cOuQIgWxCXv +x31u+k7KqbMc2wWBSVQAU2LPfhKfhXNNFy5ICMcG7smI+98Q1VfppmucmSBhJ5nU1N9 iHpk6HVfG6o2WIysq2xJGbCX7aITLl5VxuNQO/8mnJ4pVB3+K3W9KlamPdOxc/1BkUiQ P3Z2RsHTVs5jWsFPkiaADD5NEAmNHK6o2TNSqku03i6g+rGZiV8ePNzpqf4R2ufdiS+V 1jwA== X-Gm-Message-State: AOJu0Yx8kR/kAzYhxOtPJ/+Mx0alau1VrZjQjpZx+z+uUncTeVgURlgb SqYrG4JSEPel4zg9u4wvx4F+z0EhiCkGxhn+Q6MiUPJPMdqBCHhDen56z2bxxdo= X-Google-Smtp-Source: AGHT+IEWJTEbeYlTlz9FLng0GJ9cWgzVYh+mKF5kwzys5yCxHDoethpxpMHVSuur1WnYnMRq7mH+Xw== X-Received: by 2002:a05:6402:2747:b0:57a:33a5:9b71 with SMTP id 4fb4d7f45d1cf-58e5c8269e4mr3506527a12.33.1720168855792; Fri, 05 Jul 2024 01:40:55 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 08/40] tests/tcg/aarch64: Drop -fno-tree-loop-distribute-patterns Date: Fri, 5 Jul 2024 09:40:15 +0100 Message-Id: <20240705084047.857176-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169119204100001 From: Richard Henderson This option is not supported by clang, and is not required in order to get sve code generation with gcc 12. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-4-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/aarch64/Makefile.softmmu-target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/aarch64/Makefile.softmmu-target b/tests/tcg/aarch64/= Makefile.softmmu-target index 39d3f961c5..dd6d595830 100644 --- a/tests/tcg/aarch64/Makefile.softmmu-target +++ b/tests/tcg/aarch64/Makefile.softmmu-target @@ -39,7 +39,7 @@ memory: CFLAGS+=3D-DCHECK_UNALIGNED=3D1 memory-sve: memory.c $(LINK_SCRIPT) $(CRT_OBJS) $(MINILIB_OBJS) $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS) =20 -memory-sve: CFLAGS+=3D-DCHECK_UNALIGNED=3D1 -march=3Darmv8.1-a+sve -O3 -fn= o-tree-loop-distribute-patterns +memory-sve: CFLAGS+=3D-DCHECK_UNALIGNED=3D1 -march=3Darmv8.1-a+sve -O3 =20 TESTS+=3Dmemory-sve =20 --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169003; cv=none; d=zohomail.com; s=zohoarc; b=UneNowvQha1LxP5Ln41i/0hoSt/EZx6VI6d9IlVZCPkmb0bBNS0PePK/xX+D5lq0rrFW7rnPL6VmpuMaM2a8YIAxZTP0k5FFUPNpOD2T6KicJzdaX0oV0Xs9/XlpbG1fzMufJ8U0tjuTKUkviU+poPYofjCX1SJlnrxe2C+GB50= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eCIJ8bLXeHB17pKaSQdy+AoMR/5GJt+VWuDtEUviVm0=; b=FsG63CBqCu+hvFabgBj2LrQkusTSstE+Ct3go0WIvg3RrdPQa1EMxHljdqXCmIh/x9pS+u7GJLz+FNpNY77MpVOV/U6nKZVYCOZN2MxJsscQD7uRIoOsOXtXiH/pjfTlmIfFcO2407qiE5tSqYCSmo28Qz83QyHjA1aPJ0Tq1KQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169003460416.38357988332666; Fri, 5 Jul 2024 01:43:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVW-0000t9-QI; Fri, 05 Jul 2024 04:41:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeV6-000054-RS for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:05 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeUy-0003Df-1J for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:02 -0400 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a689ad8d1f6so150306566b.2 for ; Fri, 05 Jul 2024 01:40:55 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf5290dsm660596666b.48.2024.07.05.01.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:52 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 8CE49620ED; Fri, 5 Jul 2024 09:40:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168854; x=1720773654; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eCIJ8bLXeHB17pKaSQdy+AoMR/5GJt+VWuDtEUviVm0=; b=TSgbsHnue/E35OQm3GNoHsGWKMsPSjc1AKKYlr7r4Q/5Gus3VpQUWYOHHADr7yW/Xn 6KjH8fUtUm6ZZZpXdFsOJjKMtw8/JpU0fg7utjV71BEU6BS4AGXUfk3ADp/0cgNfPylo QtRwzcP3GMd3k3SoltUuDe5oT/tAANzyafEFrWI2N+plNIo35N81t5HTdwFu59BKKUVq ILtpLfNjERNyyYVTc1QHHpeB4GqgyjS4gcDAflKVEM9QqtoNQWsER0M4Xse8lSP6GU6i /SASMJB/KY7M4KMWl0xsqKOyJmUV9vnSmTdQ1TEiA280wx1AucBRwwo2VofemgL5fvW1 2A7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168854; x=1720773654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eCIJ8bLXeHB17pKaSQdy+AoMR/5GJt+VWuDtEUviVm0=; b=v15ccSoitYHTsDD/dNHwBzBLxOHPQQPoXd4zbz4RnLUyWAfTzEmzT2RAEPu1ZkJvpS wNX20LQmKU+n/TBdLhXv73f8/gnUnpzkjOrSnBr7rHRoAGMaWs9mftlTEAqk4toIGAfv emogo3VLfz68rkqGUdkj81Z11CKiT8c63IRlxoyZ3Y/6OTNLo2u4AcCnig5H4kRzOC+I 0gg6JG3fFoYh6mrbydFbj+WPBL4l2UvF9Zw4erpkQZXdF7Fegr0LcD1IltuuXLgSqOVm y1c78w6ubAY6Jf3jEL5hOx/CdvysIqp2a3oHhO1weRwR19iu0ndF4dNn8Jge8QSH0EeF euOg== X-Gm-Message-State: AOJu0Yy/CorWjCONmmVtZbS9VK4in7yAByOpMnU7nl55umaQ07w9dx1s pZqCiuu9XQL3lah7kIzJwdKhXrMPMiPs4Yo1tXBQIGA5UghrmL+JyPNiSloQ0K0= X-Google-Smtp-Source: AGHT+IGlinUwjXJ6GfTDJw/NBVSEcVveQTLNCCT+Qsw1HBCKNegSH/Ef/wK+SyMZuMrzmRuXjrkp6g== X-Received: by 2002:a17:906:5acd:b0:a77:b81a:2471 with SMTP id a640c23a62f3a-a77ba7115d5mr278975266b.49.1720168853661; Fri, 05 Jul 2024 01:40:53 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 09/40] tests/tcg/aarch64: Explicitly specify register width Date: Fri, 5 Jul 2024 09:40:16 +0100 Message-Id: <20240705084047.857176-10-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169004798100003 From: Akihiko Odaki clang version 18.1.6 assumes a register is 64-bit by default and complains if a 32-bit value is given. Explicitly specify register width when passing a 32-bit value. Signed-off-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20240627-tcg-v2-3-1690a813348e@daynix.com> Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-5-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/aarch64/bti-1.c | 6 +++--- tests/tcg/aarch64/bti-3.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/tcg/aarch64/bti-1.c b/tests/tcg/aarch64/bti-1.c index 99a879af23..1fada8108d 100644 --- a/tests/tcg/aarch64/bti-1.c +++ b/tests/tcg/aarch64/bti-1.c @@ -17,15 +17,15 @@ static void skip2_sigill(int sig, siginfo_t *info, ucon= text_t *uc) #define BTI_JC "hint #38" =20 #define BTYPE_1(DEST) \ - asm("mov %0,#1; adr x16, 1f; br x16; 1: " DEST "; mov %0,#0" \ + asm("mov %w0,#1; adr x16, 1f; br x16; 1: " DEST "; mov %w0,#0" \ : "=3Dr"(skipped) : : "x16") =20 #define BTYPE_2(DEST) \ - asm("mov %0,#1; adr x16, 1f; blr x16; 1: " DEST "; mov %0,#0" \ + asm("mov %w0,#1; adr x16, 1f; blr x16; 1: " DEST "; mov %w0,#0" \ : "=3Dr"(skipped) : : "x16", "x30") =20 #define BTYPE_3(DEST) \ - asm("mov %0,#1; adr x15, 1f; br x15; 1: " DEST "; mov %0,#0" \ + asm("mov %w0,#1; adr x15, 1f; br x15; 1: " DEST "; mov %w0,#0" \ : "=3Dr"(skipped) : : "x15") =20 #define TEST(WHICH, DEST, EXPECT) \ diff --git a/tests/tcg/aarch64/bti-3.c b/tests/tcg/aarch64/bti-3.c index 8c534c09d7..6a3bd037bc 100644 --- a/tests/tcg/aarch64/bti-3.c +++ b/tests/tcg/aarch64/bti-3.c @@ -11,15 +11,15 @@ static void skip2_sigill(int sig, siginfo_t *info, ucon= text_t *uc) } =20 #define BTYPE_1() \ - asm("mov %0,#1; adr x16, 1f; br x16; 1: hint #25; mov %0,#0" \ + asm("mov %w0,#1; adr x16, 1f; br x16; 1: hint #25; mov %w0,#0" \ : "=3Dr"(skipped) : : "x16", "x30") =20 #define BTYPE_2() \ - asm("mov %0,#1; adr x16, 1f; blr x16; 1: hint #25; mov %0,#0" \ + asm("mov %w0,#1; adr x16, 1f; blr x16; 1: hint #25; mov %w0,#0" \ : "=3Dr"(skipped) : : "x16", "x30") =20 #define BTYPE_3() \ - asm("mov %0,#1; adr x15, 1f; br x15; 1: hint #25; mov %0,#0" \ + asm("mov %w0,#1; adr x15, 1f; br x15; 1: hint #25; mov %w0,#0" \ : "=3Dr"(skipped) : : "x15", "x30") =20 #define TEST(WHICH, EXPECT) \ --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720168989; cv=none; d=zohomail.com; s=zohoarc; b=SFlWlsOZngiiI+6vynq2YN9kByXc6ZYVfWZPX40Y9hC7ojCpYZNXbrFEp6ZJqCJNr0NeaNBhacFXNs7fDUDJdHHhJb1rQyNHP9X0NX0GBnFY/vW1NhB1W0hQi+/Mr4qyiYTqw4lMkfT7j6y4iJKtqvlXeWnESQmI+hNdseTjFV4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720168989; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=J+f3EYij6+onpkKsDKRY7Afx2un37tsZeTZMpH2ViH0=; b=K3MoXbNcHKSWjAKxsJmtzU5LkFR3Wlbvs2moa1RUAzZlrGHB0Ai5lJojg91MC4/xLCzhlD8tah7RZkUIxmfRVhXtniKNpyZ2xnJcU+YEPkrDD4lIS2GzzgbD+v3iM1Z2kHfSN6+oJ7d9wqprmicNp4GQWicjLzkFps8Fw9J1QAY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720168989872835.5412616582552; Fri, 5 Jul 2024 01:43:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVW-0000tD-RG; Fri, 05 Jul 2024 04:41:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeV9-000071-CG for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:08 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeV0-0003EF-4n for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:06 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-58be2b8b6b2so1738750a12.3 for ; Fri, 05 Jul 2024 01:40:57 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58ffe0f88d0sm267919a12.85.2024.07.05.01.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:52 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id A43DA620F2; Fri, 5 Jul 2024 09:40:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168856; x=1720773656; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J+f3EYij6+onpkKsDKRY7Afx2un37tsZeTZMpH2ViH0=; b=H1Dbg14whFX++Vn4pAh2z11fejjgvvFKl2uJZ2JBLe5Pnw0gkE3p/k7VxE6dK0pj// bIA22s+1dAgFxTo34Jbb6tpvLjibmFbLRkIhNM0j5FuR1RLHYCsz3LApSK3w4i4qWc3x r3FzO1zWz6Y/AMSYuyIJSn4nilU2eUkUcw2Cbjg9xQCWzgUWv3sUu65d+KPL/sMuFEaa VM57haFcGvTdR04+ZzzCseYjsmWftnO8CyD11jNKWL5cY9+q1lzEJtvlWgSii4p9PZWl JxvrsVoIKcjOu9BaAu6H3wkOlnWBrfIKF7nxArwoNjAqbc1WK7pj9E8yObtLcR+48RQy +4Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168856; x=1720773656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J+f3EYij6+onpkKsDKRY7Afx2un37tsZeTZMpH2ViH0=; b=HeEajxzhVJSQuOVEedJNiHYNtgoxcqjrviCl3xKf6JSuhpDWFRfxiSKBBSTgyUcrr5 qTLQv5xa099b7JTsmxZ9hSFIuJJeh3vxrhrrpBTesUSPubWNYJ1wPZEuW7iFlLjLsZK9 f9IpiqPiJ2GfPCyjZixxqxkHuGUd9jxnnV4G4lYUxBjpIovhbEWLLlKn2oretJxZhHuI 5bJ9e3qhIFAKV5vgmPGimdeKJfSVm9YDpYZRGjDRfYIm5efa+V/e0afuPDYihw9obgVb 4C3fIGR7Np+UfTNUoZROB+Yzbrtl/Hn9kG41D91oKdcQgazW2fQ5FaBb78jHnPpM1xMi JtEg== X-Gm-Message-State: AOJu0YyupQaOBo2uIABUvCtEI1UKtYV715ufTno1hqFB7px4x16z5J+4 JKbQa76tIVXOPpjuBzu0r6WuNmAO5sfEsGT7ZyuvuS6+yzko8LEvF/axunvo3Ec= X-Google-Smtp-Source: AGHT+IFFjNmFaugNxWOwuSCArBG9LB7ZbMUXuEfL91kuc3JNc8SuixThQ4T42u1OgfHwk5UBmJO7sQ== X-Received: by 2002:a05:6402:13c8:b0:57a:3424:b36e with SMTP id 4fb4d7f45d1cf-58e596549admr2550505a12.13.1720168856187; Fri, 05 Jul 2024 01:40:56 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 10/40] tests/tcg/aarch64: Fix irg operand type Date: Fri, 5 Jul 2024 09:40:17 +0100 Message-Id: <20240705084047.857176-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720168990746100002 From: Akihiko Odaki irg expects 64-bit integers. Passing a 32-bit integer results in compilation failure with clang version 18.1.6. Signed-off-by: Akihiko Odaki Message-Id: <20240627-tcg-v2-4-1690a813348e@daynix.com> Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-6-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/aarch64/mte-1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/aarch64/mte-1.c b/tests/tcg/aarch64/mte-1.c index 88dcd617ad..146cad4a04 100644 --- a/tests/tcg/aarch64/mte-1.c +++ b/tests/tcg/aarch64/mte-1.c @@ -15,7 +15,7 @@ int main(int ac, char **av) enable_mte(PR_MTE_TCF_NONE); p0 =3D alloc_mte_mem(sizeof(*p0)); =20 - asm("irg %0,%1,%2" : "=3Dr"(p1) : "r"(p0), "r"(1)); + asm("irg %0,%1,%2" : "=3Dr"(p1) : "r"(p0), "r"(1l)); assert(p1 !=3D p0); asm("subp %0,%1,%2" : "=3Dr"(c) : "r"(p0), "r"(p1)); assert(c =3D=3D 0); --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720168910; cv=none; d=zohomail.com; s=zohoarc; b=Uj+MCEEL9UIpn5OW+H55O2Moe9BWBdeg+Xx4Z6gc9QRty7fMHkWKveNOm8LkfcoyJKWR2GIkS9xxOVjsEfLLXeo4tr8dFPyOXLt8fF0j2F9M/5Pe66jo/43HTc5BVfqBACMDLixlGfTwi3cA4Iey0UkZkIzh7jO6bYZ5+sWjg4g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720168910; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=E9EC0lfXh+UHwj/Mj/Qr0ZvYxRRdaiCBWTot1xCG3AQ=; b=lXR7Ea7XZw01gWJaN/VgbKaUafyM3E+f2VZi6KPRmCOB6X+67QgXN4/c++a274NCIsIBFzZ4ZBEgI0jpXEtfNPnyUW101SkKtw+/2VQ8dMZ50mxsYO/52UqPukOtwBe0KulTD8CrsJ7JuQuYn05eUFkpxJ7octU59YvbBXcykos= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720168909943705.3353365256007; Fri, 5 Jul 2024 01:41:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVk-0001FC-Us; Fri, 05 Jul 2024 04:41:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVA-000079-79 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:09 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeV1-0003EY-QX for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:07 -0400 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-58c947a6692so1848524a12.0 for ; Fri, 05 Jul 2024 01:40:59 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58dfd5aeda6sm2152144a12.78.2024.07.05.01.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:52 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id BCD8C620FA; Fri, 5 Jul 2024 09:40:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168858; x=1720773658; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E9EC0lfXh+UHwj/Mj/Qr0ZvYxRRdaiCBWTot1xCG3AQ=; b=loV4adKBgYpJ4yilSrIeWeDN6CUGH/xePzzQUj3ZaZ66SjRTk2BlyyXbrJek9UeW+N FDDXu4MhaznDozr2m5+MbFkslJynXmsxSrh0qqpFfH6ayS4j4SCAMA0LzfAUPHrkmngt wrpknjpX7osuoKGlCmDFFUQm5Ku3Ds7NifHf5OszstNydP5wHGrgPxSPhttKxKxfR2Yl q3pC5rzSpIrXYbbgjczaObNPGdJCycQ5m1GRL2QDMvqIZK+WLrM0LmoibheU/XZCeQAk 3sN4rDBrkiBhWd9ZOQu/wCaHKN+IeQ5gQooyO8CfAa08DnQ2TbliXAyZawxj7j6jVrps EBYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168858; x=1720773658; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E9EC0lfXh+UHwj/Mj/Qr0ZvYxRRdaiCBWTot1xCG3AQ=; b=u1JCmjwARZJ7guwGA6wk9drsV76DRlMOZvteY/wsxrDMEZUqxANcmFAbSIYQL7objM gcADfFEEDXbbqQgNWYc8rNl9nbBMA9IUOcnfcGKHHHi1wm4VcxGnpACFFMcoYKKMwfms 55MEOX+g2Tl+v14kadcqxw+4ELen3zONLY7+jH+6pbrp3SRnnqxRLPyxbK+I+DwmcSmZ LX34222hDoeWbmShfie/fifufoO2kBa5L08jmJf8KcEWIFnKYjEgYIDXy6SbZKxTEZNE U2zqVgaUJTz9dIPEeplHh5kgeGuhuJEdiAJPWrEo8fG6ubgmcIM74A542jNnFsgIYAqk CTCA== X-Gm-Message-State: AOJu0YxF6N1iBfJBD0T3IyJT2OyVpyQFcMexzp1+rWk/S61/lrSlIbeD fa0yYH+iBlSkBhNIA73Lcj+pFCDluIgPIGEeXSSYsPVZF5222CJGnM3DptJ8QfU= X-Google-Smtp-Source: AGHT+IFPlAe/yeqeeL+QyAkpgE+7BfOeR8amWIqalG4yBuICloPccHsHgl5nfezLRvWbep3j7Ua18g== X-Received: by 2002:a05:6402:348f:b0:58e:4088:ebd with SMTP id 4fb4d7f45d1cf-58e5a8e77admr3093639a12.9.1720168857963; Fri, 05 Jul 2024 01:40:57 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 11/40] tests/tcg/aarch64: Do not use x constraint Date: Fri, 5 Jul 2024 09:40:18 +0100 Message-Id: <20240705084047.857176-12-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720168912516100001 From: Akihiko Odaki clang version 18.1.6 does not support x constraint for AArch64. Use w instead. Signed-off-by: Akihiko Odaki Message-Id: <20240627-tcg-v2-5-1690a813348e@daynix.com> Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-7-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/arm/fcvt.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/tcg/arm/fcvt.c b/tests/tcg/arm/fcvt.c index 7ac47b564e..f631197287 100644 --- a/tests/tcg/arm/fcvt.c +++ b/tests/tcg/arm/fcvt.c @@ -126,7 +126,7 @@ static void convert_single_to_half(void) asm("vcvtb.f16.f32 %0, %1" : "=3Dt" (output) : "x" (input)); #else uint16_t output; - asm("fcvt %h0, %s1" : "=3Dw" (output) : "x" (input)); + asm("fcvt %h0, %s1" : "=3Dw" (output) : "w" (input)); #endif print_half_number(i, output); } @@ -149,7 +149,7 @@ static void convert_single_to_double(void) #if defined(__arm__) asm("vcvt.f64.f32 %P0, %1" : "=3Dw" (output) : "t" (input)); #else - asm("fcvt %d0, %s1" : "=3Dw" (output) : "x" (input)); + asm("fcvt %d0, %s1" : "=3Dw" (output) : "w" (input)); #endif print_double_number(i, output); } @@ -244,7 +244,7 @@ static void convert_double_to_half(void) /* asm("vcvtb.f16.f64 %0, %P1" : "=3Dt" (output) : "x" (input)); */ output =3D input; #else - asm("fcvt %h0, %d1" : "=3Dw" (output) : "x" (input)); + asm("fcvt %h0, %d1" : "=3Dw" (output) : "w" (input)); #endif print_half_number(i, output); } @@ -267,7 +267,7 @@ static void convert_double_to_single(void) #if defined(__arm__) asm("vcvt.f32.f64 %0, %P1" : "=3Dw" (output) : "x" (input)); #else - asm("fcvt %s0, %d1" : "=3Dw" (output) : "x" (input)); + asm("fcvt %s0, %d1" : "=3Dw" (output) : "w" (input)); #endif =20 print_single_number(i, output); @@ -335,7 +335,7 @@ static void convert_half_to_double(void) /* asm("vcvtb.f64.f16 %P0, %1" : "=3Dw" (output) : "t" (input)); */ output =3D input; #else - asm("fcvt %d0, %h1" : "=3Dw" (output) : "x" (input)); + asm("fcvt %d0, %h1" : "=3Dw" (output) : "w" (input)); #endif print_double_number(i, output); } @@ -357,7 +357,7 @@ static void convert_half_to_single(void) #if defined(__arm__) asm("vcvtb.f32.f16 %0, %1" : "=3Dw" (output) : "x" ((uint32_t)inpu= t)); #else - asm("fcvt %s0, %h1" : "=3Dw" (output) : "x" (input)); + asm("fcvt %s0, %h1" : "=3Dw" (output) : "w" (input)); #endif print_single_number(i, output); } @@ -380,7 +380,7 @@ static void convert_half_to_integer(void) /* asm("vcvt.s32.f16 %0, %1" : "=3Dt" (output) : "t" (input)); v8.= 2*/ output =3D input; #else - asm("fcvt %s0, %h1" : "=3Dw" (output) : "x" (input)); + asm("fcvt %s0, %h1" : "=3Dw" (output) : "w" (input)); #endif print_int64(i, output); } --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169014; cv=none; d=zohomail.com; s=zohoarc; b=Prw9Hx3TijRU2euXCHtZKvjprZ+jYecvYX38DmMW7y7jbbOFhxS9NUgNUpzg6JofaR9F4iDos2FFDklmdYpzgakIV5j3hSzFYjQAaISJdHDWeyvL+UD5bVhGJrDlmmLQ+Y+8qSZ8LbxQ4z4Npg3sCqPbSsCrvrz/v7CK49F5eHI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169014; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zbY/YLKB1TZRfCc9s0GoHFiRyDVXIqfIbqhNhcwYuuo=; b=jTCmDTCLGXbXv+idJL/Ed7lE4nqcbEYM5aYNTex5kjvROmiARyLAaR8LXRvU54Ht6215nB1tnwip+F5lj3i+SvLUBL4GKgPVXDMLFhQ0RnX5uqQtCxC4KhqiMkmQr5h9Jk9CnY6tStELgwebOa5U8uhfftFhi6gk3k7OJvv/1/E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169014134391.9318532981838; Fri, 5 Jul 2024 01:43:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVr-00025k-KZ; Fri, 05 Jul 2024 04:41:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVB-00007N-Fx for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:13 -0400 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeV2-0003Ey-DR for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:08 -0400 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-a77cc44f8aaso23791666b.3 for ; Fri, 05 Jul 2024 01:40:59 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58fb3ee74f6sm487375a12.68.2024.07.05.01.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:52 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id D4B0E620FD; Fri, 5 Jul 2024 09:40:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168859; x=1720773659; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zbY/YLKB1TZRfCc9s0GoHFiRyDVXIqfIbqhNhcwYuuo=; b=UNbMzYxdP2TF5GnSGX6Mf3SoaOdrV0kV4fQKOCRLqXq7c3nmgdCMzvU16JIHaZg40u 2vmevTiM2I/F2Ug8EZ0oYM/1MYecsdRmS4pyfFUawtevNW5vYvNXTg+FGXBIYtEvhvg6 oZJ2E/cbEtXRotV+tPZDcw2JsBNmpDhlhMxjFUAacqA+BDRBWTBi/X5kq4XR0Lnq2lAi ryZgUnV/e9fPwOQV45+iBeMQxytcN7xApEo5abtvcBnXcgEwWwMwcWNmDBDyLJtPqK8j M1C8JjFeIw040kkD/QwAI/PJD+82EE5FlaQr8YY1nPUoIknsPoE/14hyR9GGWucWZLCH aLOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168859; x=1720773659; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zbY/YLKB1TZRfCc9s0GoHFiRyDVXIqfIbqhNhcwYuuo=; b=wkbDuQFmIx2U+DkJyWSpsndRq+0OZwc2mRkMApzb4mtA1jpGs/Bgm2yV/07zmfnoTm 8dIKevXS05tx6l7W8cpVp4cNcusbmfobVdtf1EFNd6uyVDtM1eamNAksKkYWighUvXxp z7Hp6dcR3AwjCG3HY5Gv0mX8bLBCo2it4fqhttz8xWuk8QYPM5X6ec3dSKu+FetRdAcL UBts9HNldsFPtTbbXRSgSHipoRs7hBaiRQiSX6vZwXQJwuX8HEcdNsM/kSI+LvVRWLZB hFqkI3OAvoI2s6CohFlmzlUSYeWOsccI7aFOawjLEB6+FHlrwq8sscBW/4Dbg9S8pKDc AAZA== X-Gm-Message-State: AOJu0YyhgpvXylRwJYGQC/C79t1619LIBmXHuz2Lg7N2yqkvnRXdLzJF PDdAnOJNdCiiImB8sgU4lF7OdatRKMhulLl+aSyG+5SJE6G9yanWYKv9bSki4ko= X-Google-Smtp-Source: AGHT+IG5VwnWQZSOVHvQmdd+dCZuesnCXzuT/qM29WMvZywm4jL9nk/0ArH5UmJTKz6fmOhz6K5tww== X-Received: by 2002:a05:6402:1906:b0:57c:7c44:74df with SMTP id 4fb4d7f45d1cf-58e5b898d5cmr3663938a12.29.1720168858443; Fri, 05 Jul 2024 01:40:58 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 12/40] tests/tcg/aarch64: Add -fno-integrated-as for sme Date: Fri, 5 Jul 2024 09:40:19 +0100 Message-Id: <20240705084047.857176-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::631; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169014830100003 From: Richard Henderson The only use of SME is inline assembly. Both gcc and clang only support SME with very recent releases; by deferring detection to the assembler we get better test coverage. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-8-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/aarch64/Makefile.target | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile= .target index 11ccde5579..ad1774c2ce 100644 --- a/tests/tcg/aarch64/Makefile.target +++ b/tests/tcg/aarch64/Makefile.target @@ -20,6 +20,7 @@ run-fcvt: fcvt =20 config-cc.mak: Makefile $(quiet-@)( \ + fnia=3D`$(call cc-test,-fno-integrated-as) && echo -fno-integrated-as= `; \ $(call cc-option,-march=3Darmv8.1-a+sve, CROSS_CC_HAS_SVE); \ $(call cc-option,-march=3Darmv8.1-a+sve2, CROSS_CC_HAS_SVE2);= \ $(call cc-option,-march=3Darmv8.2-a, CROSS_CC_HAS_ARMV8_= 2); \ @@ -27,7 +28,7 @@ config-cc.mak: Makefile $(call cc-option,-march=3Darmv8.5-a, CROSS_CC_HAS_ARMV8_= 5); \ $(call cc-option,-mbranch-protection=3Dstandard, CROSS_CC_HAS_ARMV8_= BTI); \ $(call cc-option,-march=3Darmv8.5-a+memtag, CROSS_CC_HAS_ARMV8_= MTE); \ - $(call cc-option,-Wa$(COMMA)-march=3Darmv9-a+sme, CROSS_AS_HAS_ARMV9_= SME)) 3> config-cc.mak + $(call cc-option,-Wa$(COMMA)-march=3Darmv9-a+sme $$fnia, CROSS_AS_HAS= _ARMV9_SME)) 3> config-cc.mak -include config-cc.mak =20 ifneq ($(CROSS_CC_HAS_ARMV8_2),) --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169324; cv=none; d=zohomail.com; s=zohoarc; b=ggKH/saxeexXHB8joL+ATKs807wo4ZhRhjSkwd69kcjvKxXo4qhPTFdwPL10tutGag5+7NLwqvbfESsDlbEogGS3Pap+D9be1kfIWnkM4oaKAzwsj9JsHexR3dELnSHuUlzjIHfKX82al5VoHLwFM6uNIIrs6vwcTiLc4unDiFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169324; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cuYhllMhvBdmY7hDfUFKd/3xxlusKaLCU8Ysl8A4o6o=; b=DfHJG/yJA63kbIOMAOKWELJO4qS+xr4vv2abwgSdBz4qVE7pr6uMjiETv3tUM8YfHTMZD+6sQ9zF0hvfPNCWzleA4tOGJXf2ZfcAZKFlmSyH8mDl6ddymnlWmE+x22QvKuHRd4/2Re2imbN1FmU6326aEdjuOfPpb75edPjTcyg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172016932455484.1307707081993; Fri, 5 Jul 2024 01:48:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPecG-0002xD-5U; Fri, 05 Jul 2024 04:48:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebP-000109-OU for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:37 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeb8-0004Bo-Uw for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:35 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a77b550128dso175017966b.0 for ; Fri, 05 Jul 2024 01:47:18 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77cb6d3348sm43751066b.52.2024.07.05.01.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:11 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id F29BF62102; Fri, 5 Jul 2024 09:40:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169237; x=1720774037; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cuYhllMhvBdmY7hDfUFKd/3xxlusKaLCU8Ysl8A4o6o=; b=DPaKvjVD2OUSvl0dpBU2nH4fFi7nrC+iju7wPO9fS7fWpgjIHXlVxgX7BnkZnq+ZPS 4a62WyRqAUnFfrt0SMAXtQm3O7RjpraGgheVeJCQHFASuyNeONyU5DUczGWF7JRpeY3x LN0Dj+40Cdvc2HHwH2HIP3s/6jih7s5LUAvFiM7QCnbwV78M8SNUW5wQg2yrpEt6kd00 oHk0AHrH9d76LSiWO9IK7sLPxEmDbWapZBpX9qWeqDauowU6tFqW474Bv+jD/XWC4anY 7P8l6HztQ6/vKsyECHuTNkT/cP12pajDcMLS+lB7n7qCdu3GviiInKf9qx+OeQTHtK4x 7b6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169237; x=1720774037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cuYhllMhvBdmY7hDfUFKd/3xxlusKaLCU8Ysl8A4o6o=; b=K3FX2aUHy6IZtrLZIk/G9YwhguO8cIcBhzbJ8hq6cdXPpLdMW+BS/CZt5wrjMHJTOz K+xhikG18Ui49AR2xLLqIkzVVVkAMcclmF3auikGCO6KalFFUNuLYazWXwJvfyvx/QGd gtNeFGsjFr1KX1VcGLzHb9usXxOuBW3tJHUPMovcIiBmQYSth6eGcm2L0I0Y9fkFwu7y 3+r8Y9ylN547WS0XLDHKmIE+ZnwlvzN9KAvscVR2RkJ96hgVxC7SRgKitxJcvANdm1HG UQH3Ro7zKkAivUR+smtD6Aj5azTe/tB86K8zq71sJsZ09/aGndV6nl8gMv5QvYAU7LZD Op6g== X-Gm-Message-State: AOJu0Yw38VTCmHdBGl02VPPH1E+aOdOK2EHNVhUOcRkD6bP7ANuu4S1V TglfdtDREiqYDH9gQEUb1StFVsg9ow98ysoOnksuybt11N0DIVZB4BD8VvfPG7M= X-Google-Smtp-Source: AGHT+IEf4ce/BqQhjAEn7LTHuP7sxh/wuxJTOP7AxpMiEnidG6CqsvXTADTT0fnLdJSpJliT6Anl4w== X-Received: by 2002:a17:906:4794:b0:a6f:56d2:8f0d with SMTP id a640c23a62f3a-a77ba46ccf3mr328060566b.17.1720169236316; Fri, 05 Jul 2024 01:47:16 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 13/40] tests/tcg/arm: Fix fcvt result messages Date: Fri, 5 Jul 2024 09:40:20 +0100 Message-Id: <20240705084047.857176-14-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169326333100002 From: Akihiko Odaki The test cases for "converting double-precision to single-precision" emits float but the result variable was typed as uint32_t and corrupted the printed values. Propertly type it as float. Signed-off-by: Akihiko Odaki Fixes: 8ec8a55e3fc9 ("tests/tcg/arm: add fcvt test cases for AArch32/64") Message-Id: <20240627-tcg-v2-1-1690a813348e@daynix.com> [rth: Update arm ref file as well] Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-9-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/arm/fcvt.c | 2 +- tests/tcg/aarch64/fcvt.ref | 604 ++++++++++++++++++------------------- tests/tcg/arm/fcvt.ref | 604 ++++++++++++++++++------------------- 3 files changed, 605 insertions(+), 605 deletions(-) diff --git a/tests/tcg/arm/fcvt.c b/tests/tcg/arm/fcvt.c index f631197287..157790e679 100644 --- a/tests/tcg/arm/fcvt.c +++ b/tests/tcg/arm/fcvt.c @@ -258,7 +258,7 @@ static void convert_double_to_single(void) =20 for (i =3D 0; i < ARRAY_SIZE(double_numbers); ++i) { double input =3D double_numbers[i].d; - uint32_t output; + float output; =20 feclearexcept(FE_ALL_EXCEPT); =20 diff --git a/tests/tcg/aarch64/fcvt.ref b/tests/tcg/aarch64/fcvt.ref index e7af24dc58..2726b41063 100644 --- a/tests/tcg/aarch64/fcvt.ref +++ b/tests/tcg/aarch64/fcvt.ref @@ -211,45 +211,45 @@ Converting double-precision to half-precision 40 HALF: 0x7f00 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570815e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -inf / 0xff800000 (0x14 =3D> OVERFLOW INEXACT ) 04 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11100004769645909791e+31 / 0xf30c3a59 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999085e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11100003258488635273e+30 / 0xf1605d5b (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750797e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750797e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750797e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750797e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013061e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026624000000000000e+08 / 0x4e4e0000 (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005935e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994299e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015673e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013665e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851006e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -257,41 +257,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509080e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675456000000000000e+09 / 0x4e805bf1 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311600e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07853004800000000000e+09 / 0x4e809220 (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159274101257324219e+00 / 0x40490fdb (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32540006400000000000e+09 / 0x4e9e0000 (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570815e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: inf / 0x7f800000 (0x14 =3D> OVERFLOW INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -nan / 0xffffe000 (0 =3D> OK) @@ -574,87 +574,87 @@ Converting double-precision to half-precision 40 HALF: 0x7f00 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570814e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0x14 =3D> OVERFLOW = INEXACT ) 04 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766502400000000000e+09 / 0x4f730c3b (0x10 =3D> INEXACT ) +06 SINGLE: -1.11099992680387713644e+31 / 0xf30c3a58 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999084e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962457600000000000e+09 / 0x4f71605e (0x10 =3D> INEXACT ) +07 SINGLE: -1.11099995702702262681e+30 / 0xf1605d5a (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750796e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750796e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750797e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750797e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013061e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638080000000000000e+08 / 0x4e4c0001 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023259404089913006e-08 / 0x33000001 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015662e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026624000000000000e+08 / 0x4e4e0000 (0x10 =3D> INEXACT ) +15 SINGLE: 5.96046021428264793940e-08 / 0x337ffff4 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994299e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896384000000000000e+08 / 0x4e61ff01 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09756025369279086590e-05 / 0x387fc00e (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013665e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912768000000000000e+08 / 0x4e620001 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10352071817032992840e-05 / 0x38800007 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138310e-308 / 0x000010000000000000 (0 =3D> OK) -20 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +20 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282844e-308 / 0x000009ea82a2287680 (0 =3D> OK) -21 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +21 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 22 DOUBLE: 1.49147387366816238764e-308 / 0x00000ab98fba843210 (0 =3D> OK) -22 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +22 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509080e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675456000000000000e+09 / 0x4e805bf1 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828198432922363282e+00 / 0x402df855 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311600e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07853004800000000000e+09 / 0x4e809220 (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159274101257324219e+00 / 0x40490fdb (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32540006400000000000e+09 / 0x4e9e0000 (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570815e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: inf / 0x7f800000 (0x14 =3D> OVERFLOW INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -nan / 0xffffe000 (0 =3D> OK) @@ -937,45 +937,45 @@ Converting double-precision to half-precision 40 HALF: 0x7f00 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570815e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -inf / 0xff800000 (0x14 =3D> OVERFLOW INEXACT ) 04 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007530e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11100004769645909791e+31 / 0xf30c3a59 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999085e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11100003258488635273e+30 / 0xf1605d5b (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138310e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -1.40129846432481707093e-45 / 0x80000001 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750797e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750797e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750796e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750796e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013060e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026560000000000000e+08 / 0x4e4dffff (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005934e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994298e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015672e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013664e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851005e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -983,41 +983,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509079e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675443200000000000e+09 / 0x4e805bf0 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311599e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07852992000000000000e+09 / 0x4e80921f (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159250259399414062e+00 / 0x40490fda (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32539993600000000000e+09 / 0x4e9dffff (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748352000000000000e+09 / 0x4effffff (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570814e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0x14 =3D> OVERFLOW = INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -nan / 0xffffe000 (0 =3D> OK) @@ -1300,45 +1300,45 @@ Converting double-precision to half-precision 40 HALF: 0x7f00 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570814e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0x14 =3D> OVERFLOW = INEXACT ) 04 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11099992680387713644e+31 / 0xf30c3a58 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999084e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11099995702702262681e+30 / 0xf1605d5a (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750796e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750796e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750796e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750796e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013060e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026560000000000000e+08 / 0x4e4dffff (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005934e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994298e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015672e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013664e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851005e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -1346,41 +1346,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509079e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675443200000000000e+09 / 0x4e805bf0 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311599e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07852992000000000000e+09 / 0x4e80921f (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159250259399414062e+00 / 0x40490fda (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32539993600000000000e+09 / 0x4e9dffff (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748352000000000000e+09 / 0x4effffff (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570814e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0x14 =3D> OVERFLOW = INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -nan / 0xffffe000 (0 =3D> OK) @@ -1845,45 +1845,45 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570815e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -inf / 0xff800000 (0x14 =3D> OVERFLOW INEXACT ) 04 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11100004769645909791e+31 / 0xf30c3a59 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999085e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11100003258488635273e+30 / 0xf1605d5b (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750797e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750797e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750797e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750797e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013061e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026624000000000000e+08 / 0x4e4e0000 (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005935e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994299e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015673e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013665e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851006e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -1891,41 +1891,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509080e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675456000000000000e+09 / 0x4e805bf1 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311600e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07853004800000000000e+09 / 0x4e809220 (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159274101257324219e+00 / 0x40490fdb (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32540006400000000000e+09 / 0x4e9e0000 (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570815e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: inf / 0x7f800000 (0x14 =3D> OVERFLOW INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -1.31008000000000000000e+05 / 0xc7ffe000 (0 =3D> OK) @@ -2208,87 +2208,87 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570814e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0x14 =3D> OVERFLOW = INEXACT ) 04 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766502400000000000e+09 / 0x4f730c3b (0x10 =3D> INEXACT ) +06 SINGLE: -1.11099992680387713644e+31 / 0xf30c3a58 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999084e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962457600000000000e+09 / 0x4f71605e (0x10 =3D> INEXACT ) +07 SINGLE: -1.11099995702702262681e+30 / 0xf1605d5a (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750796e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750796e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750797e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750797e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013061e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638080000000000000e+08 / 0x4e4c0001 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023259404089913006e-08 / 0x33000001 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015662e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026624000000000000e+08 / 0x4e4e0000 (0x10 =3D> INEXACT ) +15 SINGLE: 5.96046021428264793940e-08 / 0x337ffff4 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994299e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896384000000000000e+08 / 0x4e61ff01 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09756025369279086590e-05 / 0x387fc00e (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013665e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912768000000000000e+08 / 0x4e620001 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10352071817032992840e-05 / 0x38800007 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138310e-308 / 0x000010000000000000 (0 =3D> OK) -20 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +20 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282844e-308 / 0x000009ea82a2287680 (0 =3D> OK) -21 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +21 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 22 DOUBLE: 1.49147387366816238764e-308 / 0x00000ab98fba843210 (0 =3D> OK) -22 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +22 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509080e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675456000000000000e+09 / 0x4e805bf1 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828198432922363282e+00 / 0x402df855 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311600e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07853004800000000000e+09 / 0x4e809220 (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159274101257324219e+00 / 0x40490fdb (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32540006400000000000e+09 / 0x4e9e0000 (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570815e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: inf / 0x7f800000 (0x14 =3D> OVERFLOW INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -1.31008000000000000000e+05 / 0xc7ffe000 (0 =3D> OK) @@ -2571,45 +2571,45 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570815e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -inf / 0xff800000 (0x14 =3D> OVERFLOW INEXACT ) 04 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007530e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11100004769645909791e+31 / 0xf30c3a59 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999085e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11100003258488635273e+30 / 0xf1605d5b (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138310e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -1.40129846432481707093e-45 / 0x80000001 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750797e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750797e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750796e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750796e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013060e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026560000000000000e+08 / 0x4e4dffff (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005934e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994298e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015672e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013664e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851005e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -2617,41 +2617,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509079e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675443200000000000e+09 / 0x4e805bf0 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311599e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07852992000000000000e+09 / 0x4e80921f (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159250259399414062e+00 / 0x40490fda (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32539993600000000000e+09 / 0x4e9dffff (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748352000000000000e+09 / 0x4effffff (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570814e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0x14 =3D> OVERFLOW = INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -1.31008000000000000000e+05 / 0xc7ffe000 (0 =3D> OK) @@ -2934,45 +2934,45 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570814e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0x14 =3D> OVERFLOW = INEXACT ) 04 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11099992680387713644e+31 / 0xf30c3a58 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999084e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11099995702702262681e+30 / 0xf1605d5a (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750796e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750796e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750796e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750796e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013060e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026560000000000000e+08 / 0x4e4dffff (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005934e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994298e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015672e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013664e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851005e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -2980,41 +2980,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509079e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675443200000000000e+09 / 0x4e805bf0 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311599e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07852992000000000000e+09 / 0x4e80921f (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159250259399414062e+00 / 0x40490fda (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32539993600000000000e+09 / 0x4e9dffff (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748352000000000000e+09 / 0x4effffff (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570814e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0x14 =3D> OVERFLOW = INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -1.31008000000000000000e+05 / 0xc7ffe000 (0 =3D> OK) diff --git a/tests/tcg/arm/fcvt.ref b/tests/tcg/arm/fcvt.ref index f052b6d7e5..8e007c3345 100644 --- a/tests/tcg/arm/fcvt.ref +++ b/tests/tcg/arm/fcvt.ref @@ -211,45 +211,45 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570815e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -inf / 0xff800000 (0x14 =3D> OVERFLOW INEXACT ) 04 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11100004769645909791e+31 / 0xf30c3a59 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999085e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11100003258488635273e+30 / 0xf1605d5b (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750797e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750797e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750797e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750797e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013061e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026624000000000000e+08 / 0x4e4e0000 (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005935e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994299e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015673e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013665e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851006e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -257,41 +257,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509080e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675456000000000000e+09 / 0x4e805bf1 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311600e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07853004800000000000e+09 / 0x4e809220 (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159274101257324219e+00 / 0x40490fdb (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32540006400000000000e+09 / 0x4e9e0000 (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570815e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: inf / 0x7f800000 (0x14 =3D> OVERFLOW INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -nan / 0xffffe000 (0 =3D> OK) @@ -574,87 +574,87 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570814e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0x14 =3D> OVERFLOW = INEXACT ) 04 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766502400000000000e+09 / 0x4f730c3b (0x10 =3D> INEXACT ) +06 SINGLE: -1.11099992680387713644e+31 / 0xf30c3a58 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999084e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962457600000000000e+09 / 0x4f71605e (0x10 =3D> INEXACT ) +07 SINGLE: -1.11099995702702262681e+30 / 0xf1605d5a (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750796e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750796e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750797e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750797e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013061e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638080000000000000e+08 / 0x4e4c0001 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023259404089913006e-08 / 0x33000001 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015662e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026624000000000000e+08 / 0x4e4e0000 (0x10 =3D> INEXACT ) +15 SINGLE: 5.96046021428264793940e-08 / 0x337ffff4 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994299e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896384000000000000e+08 / 0x4e61ff01 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09756025369279086590e-05 / 0x387fc00e (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013665e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912768000000000000e+08 / 0x4e620001 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10352071817032992840e-05 / 0x38800007 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138310e-308 / 0x000010000000000000 (0 =3D> OK) -20 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +20 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282844e-308 / 0x000009ea82a2287680 (0 =3D> OK) -21 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +21 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 22 DOUBLE: 1.49147387366816238764e-308 / 0x00000ab98fba843210 (0 =3D> OK) -22 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +22 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509080e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675456000000000000e+09 / 0x4e805bf1 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828198432922363282e+00 / 0x402df855 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311600e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07853004800000000000e+09 / 0x4e809220 (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159274101257324219e+00 / 0x40490fdb (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32540006400000000000e+09 / 0x4e9e0000 (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570815e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: inf / 0x7f800000 (0x14 =3D> OVERFLOW INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -nan / 0xffffe000 (0 =3D> OK) @@ -937,45 +937,45 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570815e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -inf / 0xff800000 (0x14 =3D> OVERFLOW INEXACT ) 04 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007530e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11100004769645909791e+31 / 0xf30c3a59 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999085e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11100003258488635273e+30 / 0xf1605d5b (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138310e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -1.40129846432481707093e-45 / 0x80000001 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750797e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750797e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750796e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750796e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013060e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026560000000000000e+08 / 0x4e4dffff (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005934e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994298e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015672e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013664e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851005e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -983,41 +983,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509079e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675443200000000000e+09 / 0x4e805bf0 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311599e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07852992000000000000e+09 / 0x4e80921f (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159250259399414062e+00 / 0x40490fda (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32539993600000000000e+09 / 0x4e9dffff (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748352000000000000e+09 / 0x4effffff (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570814e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0x14 =3D> OVERFLOW = INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -nan / 0xffffe000 (0 =3D> OK) @@ -1300,45 +1300,45 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570814e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0x14 =3D> OVERFLOW = INEXACT ) 04 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11099992680387713644e+31 / 0xf30c3a58 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999084e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11099995702702262681e+30 / 0xf1605d5a (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750796e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750796e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750796e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750796e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013060e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026560000000000000e+08 / 0x4e4dffff (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005934e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994298e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015672e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013664e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851005e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -1346,41 +1346,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509079e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675443200000000000e+09 / 0x4e805bf0 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311599e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07852992000000000000e+09 / 0x4e80921f (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159250259399414062e+00 / 0x40490fda (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32539993600000000000e+09 / 0x4e9dffff (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748352000000000000e+09 / 0x4effffff (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570814e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0x14 =3D> OVERFLOW = INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -nan / 0xffffe000 (0 =3D> OK) @@ -1845,45 +1845,45 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570815e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -inf / 0xff800000 (0x14 =3D> OVERFLOW INEXACT ) 04 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11100004769645909791e+31 / 0xf30c3a59 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999085e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11100003258488635273e+30 / 0xf1605d5b (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750797e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750797e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750797e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750797e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013061e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026624000000000000e+08 / 0x4e4e0000 (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005935e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994299e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015673e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013665e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851006e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -1891,41 +1891,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509080e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675456000000000000e+09 / 0x4e805bf1 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311600e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07853004800000000000e+09 / 0x4e809220 (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159274101257324219e+00 / 0x40490fdb (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32540006400000000000e+09 / 0x4e9e0000 (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570815e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: inf / 0x7f800000 (0x14 =3D> OVERFLOW INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -1.31008000000000000000e+05 / 0xc7ffe000 (0 =3D> OK) @@ -2208,87 +2208,87 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570814e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0x14 =3D> OVERFLOW = INEXACT ) 04 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766502400000000000e+09 / 0x4f730c3b (0x10 =3D> INEXACT ) +06 SINGLE: -1.11099992680387713644e+31 / 0xf30c3a58 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999084e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962457600000000000e+09 / 0x4f71605e (0x10 =3D> INEXACT ) +07 SINGLE: -1.11099995702702262681e+30 / 0xf1605d5a (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750796e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750796e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750797e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750797e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013061e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638080000000000000e+08 / 0x4e4c0001 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023259404089913006e-08 / 0x33000001 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015662e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026624000000000000e+08 / 0x4e4e0000 (0x10 =3D> INEXACT ) +15 SINGLE: 5.96046021428264793940e-08 / 0x337ffff4 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994299e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896384000000000000e+08 / 0x4e61ff01 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09756025369279086590e-05 / 0x387fc00e (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013665e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912768000000000000e+08 / 0x4e620001 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10352071817032992840e-05 / 0x38800007 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138310e-308 / 0x000010000000000000 (0 =3D> OK) -20 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +20 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282844e-308 / 0x000009ea82a2287680 (0 =3D> OK) -21 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +21 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 22 DOUBLE: 1.49147387366816238764e-308 / 0x00000ab98fba843210 (0 =3D> OK) -22 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0x18 =3D> UNDERFLOW = INEXACT ) +22 SINGLE: 1.40129846432481707093e-45 / 0x00000001 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509080e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675456000000000000e+09 / 0x4e805bf1 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828198432922363282e+00 / 0x402df855 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311600e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07853004800000000000e+09 / 0x4e809220 (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159274101257324219e+00 / 0x40490fdb (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32540006400000000000e+09 / 0x4e9e0000 (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859812e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859812e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570815e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: inf / 0x7f800000 (0x14 =3D> OVERFLOW INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -1.31008000000000000000e+05 / 0xc7ffe000 (0 =3D> OK) @@ -2571,45 +2571,45 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570815e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -inf / 0xff800000 (0x14 =3D> OVERFLOW INEXACT ) 04 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859812e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859812e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007530e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11100004769645909791e+31 / 0xf30c3a59 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999085e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11100003258488635273e+30 / 0xf1605d5b (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138310e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -1.40129846432481707093e-45 / 0x80000001 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750797e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750797e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750796e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750796e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013060e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026560000000000000e+08 / 0x4e4dffff (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005934e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994298e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015672e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013664e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851005e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -2617,41 +2617,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509079e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675443200000000000e+09 / 0x4e805bf0 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311599e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07852992000000000000e+09 / 0x4e80921f (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159250259399414062e+00 / 0x40490fda (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32539993600000000000e+09 / 0x4e9dffff (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748352000000000000e+09 / 0x4effffff (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570814e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0x14 =3D> OVERFLOW = INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -1.31008000000000000000e+05 / 0xc7ffe000 (0 =3D> OK) @@ -2934,45 +2934,45 @@ Converting double-precision to half-precision 40 HALF: 0000 (0x1 =3D> INVALID) Converting double-precision to single-precision 00 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -00 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +00 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) 01 DOUBLE: -nan / 0x00fff8000000000000 (0 =3D> OK) -01 SINGLE: 4.29077299200000000000e+09 / 0x4f7fc000 (0 =3D> OK) +01 SINGLE: -nan / 0xffc00000 (0 =3D> OK) 02 DOUBLE: -inf / 0x00fff0000000000000 (0 =3D> OK) -02 SINGLE: 4.28657868800000000000e+09 / 0x4f7f8000 (0 =3D> OK) +02 SINGLE: -inf / 0xff800000 (0 =3D> OK) 03 DOUBLE: -1.79769313486231570814e+308 / 0x00ffefffffffffffff (0 =3D> OK) -03 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x14 =3D> OVERFLOW = INEXACT ) +03 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0x14 =3D> OVERFLOW = INEXACT ) 04 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -04 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +04 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 05 DOUBLE: -3.40282346638528859811e+38 / 0x00c7efffffe0000000 (0 =3D> OK) -05 SINGLE: 4.28657843200000000000e+09 / 0x4f7f7fff (0x10 =3D> INEXACT ) +05 SINGLE: -3.40282346638528859811e+38 / 0xff7fffff (0 =3D> OK) 06 DOUBLE: -1.11100000000000007529e+31 / 0x00c661874b135ff654 (0 =3D> OK) -06 SINGLE: 4.07766476800000000000e+09 / 0x4f730c3a (0x10 =3D> INEXACT ) +06 SINGLE: -1.11099992680387713644e+31 / 0xf30c3a58 (0x10 =3D> INEXACT= ) 07 DOUBLE: -1.11099999999999999084e+30 / 0x00c62c0bab523323b9 (0 =3D> OK) -07 SINGLE: 4.04962432000000000000e+09 / 0x4f71605d (0x10 =3D> INEXACT ) +07 SINGLE: -1.11099995702702262681e+30 / 0xf1605d5a (0x10 =3D> INEXACT= ) 08 DOUBLE: -2.00000000000000000000e+00 / 0x00c000000000000000 (0 =3D> OK) -08 SINGLE: 3.22122547200000000000e+09 / 0x4f400000 (0 =3D> OK) +08 SINGLE: -2.00000000000000000000e+00 / 0xc0000000 (0 =3D> OK) 09 DOUBLE: -1.00000000000000000000e+00 / 0x00bff0000000000000 (0 =3D> OK) -09 SINGLE: 3.21283686400000000000e+09 / 0x4f3f8000 (0 =3D> OK) +09 SINGLE: -1.00000000000000000000e+00 / 0xbf800000 (0 =3D> OK) 10 DOUBLE: -2.22507385850720138309e-308 / 0x008010000000000000 (0 =3D> OK) -10 SINGLE: 2.14748364800000000000e+09 / 0x4f000000 (0x18 =3D> UNDERFLOW = INEXACT ) +10 SINGLE: -0.00000000000000000000e+00 / 0x80000000 (0x18 =3D> UNDERFLOW= INEXACT ) 11 DOUBLE: -1.17549435082228750796e-38 / 0x00b810000000000000 (0 =3D> OK) -11 SINGLE: 2.15587225600000000000e+09 / 0x4f008000 (0 =3D> OK) +11 SINGLE: -1.17549435082228750796e-38 / 0x80800000 (0 =3D> OK) 12 DOUBLE: 0.00000000000000000000e+00 / 00000000000000000000 (0 =3D> OK) 12 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0 =3D> OK) 13 DOUBLE: 1.17549435082228750796e-38 / 0x003810000000000000 (0 =3D> OK) -13 SINGLE: 8.38860800000000000000e+06 / 0x4b000000 (0 =3D> OK) +13 SINGLE: 1.17549435082228750796e-38 / 0x00800000 (0 =3D> OK) 14 DOUBLE: 2.98023224000000013060e-08 / 0x003e600000001c5f68 (0 =3D> OK) -14 SINGLE: 8.55638016000000000000e+08 / 0x4e4c0000 (0x10 =3D> INEXACT ) +14 SINGLE: 2.98023223876953125000e-08 / 0x33000000 (0x10 =3D> INEXACT ) 15 DOUBLE: 5.96046000000000015661e-08 / 0x003e6ffffe6cb2fa82 (0 =3D> OK) -15 SINGLE: 8.64026560000000000000e+08 / 0x4e4dffff (0x10 =3D> INEXACT ) +15 SINGLE: 5.96045985901128005934e-08 / 0x337ffff3 (0x10 =3D> INEXACT ) 16 DOUBLE: 6.09755999999999994298e-05 / 0x003f0ff801a9af58a1 (0 =3D> OK) -16 SINGLE: 9.47896320000000000000e+08 / 0x4e61ff00 (0x10 =3D> INEXACT ) +16 SINGLE: 6.09755988989491015672e-05 / 0x387fc00d (0x10 =3D> INEXACT ) 17 DOUBLE: 6.10352000000000013664e-05 / 0x003f100000c06a1ef5 (0 =3D> OK) -17 SINGLE: 9.47912704000000000000e+08 / 0x4e620000 (0x10 =3D> INEXACT ) +17 SINGLE: 6.10351999057456851005e-05 / 0x38800006 (0x10 =3D> INEXACT ) 18 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -18 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +18 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 19 DOUBLE: 1.00097656250000000000e+00 / 0x003ff0040000000000 (0 =3D> OK) -19 SINGLE: 1.06536140800000000000e+09 / 0x4e7e0080 (0 =3D> OK) +19 SINGLE: 1.00097656250000000000e+00 / 0x3f802000 (0 =3D> OK) 20 DOUBLE: 2.22507385850720138309e-308 / 0x000010000000000000 (0 =3D> OK) 20 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 21 DOUBLE: 1.37899728486072282843e-308 / 0x000009ea82a2287680 (0 =3D> OK) @@ -2980,41 +2980,41 @@ Converting double-precision to single-precision 22 DOUBLE: 1.49147387366816238763e-308 / 0x00000ab98fba843210 (0 =3D> OK) 22 SINGLE: 0.00000000000000000000e+00 / 0000000000 (0x18 =3D> UNDERFLOW = INEXACT ) 23 DOUBLE: 1.00000000000000000000e+00 / 0x003ff0000000000000 (0 =3D> OK) -23 SINGLE: 1.06535321600000000000e+09 / 0x4e7e0000 (0 =3D> OK) +23 SINGLE: 1.00000000000000000000e+00 / 0x3f800000 (0 =3D> OK) 24 DOUBLE: 2.00000000000000000000e+00 / 0x004000000000000000 (0 =3D> OK) -24 SINGLE: 1.07374182400000000000e+09 / 0x4e800000 (0 =3D> OK) +24 SINGLE: 2.00000000000000000000e+00 / 0x40000000 (0 =3D> OK) 25 DOUBLE: 2.71828182845904509079e+00 / 0x004005bf0a8b145769 (0 =3D> OK) -25 SINGLE: 1.07675443200000000000e+09 / 0x4e805bf0 (0x10 =3D> INEXACT ) +25 SINGLE: 2.71828174591064453125e+00 / 0x402df854 (0x10 =3D> INEXACT ) 26 DOUBLE: 3.14159265358979311599e+00 / 0x00400921fb54442d18 (0 =3D> OK) -26 SINGLE: 1.07852992000000000000e+09 / 0x4e80921f (0x10 =3D> INEXACT ) +26 SINGLE: 3.14159250259399414062e+00 / 0x40490fda (0x10 =3D> INEXACT ) 27 DOUBLE: 6.55030000000000000000e+04 / 0x0040effbe000000000 (0 =3D> OK) -27 SINGLE: 1.19956249600000000000e+09 / 0x4e8effbe (0 =3D> OK) +27 SINGLE: 6.55030000000000000000e+04 / 0x477fdf00 (0 =3D> OK) 28 DOUBLE: 6.55040000000000000000e+04 / 0x0040effc0000000000 (0 =3D> OK) -28 SINGLE: 1.19956275200000000000e+09 / 0x4e8effc0 (0 =3D> OK) +28 SINGLE: 6.55040000000000000000e+04 / 0x477fe000 (0 =3D> OK) 29 DOUBLE: 6.55050000000000000000e+04 / 0x0040effc2000000000 (0 =3D> OK) -29 SINGLE: 1.19956300800000000000e+09 / 0x4e8effc2 (0 =3D> OK) +29 SINGLE: 6.55050000000000000000e+04 / 0x477fe100 (0 =3D> OK) 30 DOUBLE: 1.31007000000000000000e+05 / 0x0040fffbf000000000 (0 =3D> OK) -30 SINGLE: 1.20795123200000000000e+09 / 0x4e8fffbf (0 =3D> OK) +30 SINGLE: 1.31007000000000000000e+05 / 0x47ffdf80 (0 =3D> OK) 31 DOUBLE: 1.31008000000000000000e+05 / 0x0040fffc0000000000 (0 =3D> OK) -31 SINGLE: 1.20795136000000000000e+09 / 0x4e8fffc0 (0 =3D> OK) +31 SINGLE: 1.31008000000000000000e+05 / 0x47ffe000 (0 =3D> OK) 32 DOUBLE: 1.31009000000000000000e+05 / 0x0040fffc1000000000 (0 =3D> OK) -32 SINGLE: 1.20795148800000000000e+09 / 0x4e8fffc1 (0 =3D> OK) +32 SINGLE: 1.31009000000000000000e+05 / 0x47ffe080 (0 =3D> OK) 33 DOUBLE: 2.14748364700000000000e+09 / 0x0041dfffffffc00000 (0 =3D> OK) -33 SINGLE: 1.32539993600000000000e+09 / 0x4e9dffff (0x10 =3D> INEXACT ) +33 SINGLE: 2.14748352000000000000e+09 / 0x4effffff (0x10 =3D> INEXACT ) 34 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -34 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +34 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 35 DOUBLE: 3.40282346638528859811e+38 / 0x0047efffffe0000000 (0 =3D> OK) -35 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x10 =3D> INEXACT ) +35 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0 =3D> OK) 36 DOUBLE: 1.79769313486231570814e+308 / 0x007fefffffffffffff (0 =3D> OK) -36 SINGLE: 2.13909491200000000000e+09 / 0x4efeffff (0x14 =3D> OVERFLOW = INEXACT ) +36 SINGLE: 3.40282346638528859811e+38 / 0x7f7fffff (0x14 =3D> OVERFLOW = INEXACT ) 37 DOUBLE: inf / 0x007ff0000000000000 (0 =3D> OK) -37 SINGLE: 2.13909504000000000000e+09 / 0x4eff0000 (0 =3D> OK) +37 SINGLE: inf / 0x7f800000 (0 =3D> OK) 38 DOUBLE: nan / 0x007ff8000000000000 (0 =3D> OK) -38 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0 =3D> OK) +38 SINGLE: nan / 0x7fc00000 (0 =3D> OK) 39 DOUBLE: nan / 0x007ff0000000000001 (0 =3D> OK) -39 SINGLE: 2.14328934400000000000e+09 / 0x4eff8000 (0x1 =3D> INVALID) +39 SINGLE: nan / 0x7fc00000 (0x1 =3D> INVALID) 40 DOUBLE: nan / 0x007ff4000000000000 (0 =3D> OK) -40 SINGLE: 2.14538649600000000000e+09 / 0x4effc000 (0x1 =3D> INVALID) +40 SINGLE: nan / 0x7fe00000 (0x1 =3D> INVALID) Converting half-precision to single-precision 00 HALF: 0xffff (0 =3D> OK) 00 SINGLE: -1.31008000000000000000e+05 / 0xc7ffe000 (0 =3D> OK) --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169405; cv=none; d=zohomail.com; s=zohoarc; b=lQDuiuCcYFOUX61NbSH/150uPf5U5BWNvHAK4qJVwxtVH/JnizwuOdhwOXGzNkTdW/d4f1lFg6pkb8CSr92LrbkSCIb7QTFteS82iRQoqJrTBCGn0yEMh+HV3CCqpB9Y5jr2rs/GCfJHLeLT5ZIB1XMKWSRhz7B6RaFUIzZVez4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169405; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FcTtzsKeBB4MlD0Q7gjS8cN5rY9ihom2n5xaHwaWlG4=; b=ivit47CNc/0LuyzM/bH4y9tHKptUGZsKz9NFNVtpaWNLh1C5dPp2ZLCu7zhF/onDisUzdhiO7TFEtQC2kVmVfU0giGI54zWdE8hlsObL3eWmaviVfbdZzW0XpDDqFHP62v8AWx9GtdXYePBtU7FO7UIOXqgLSyXMiV0/KfFccHI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172016940554685.13814226925865; Fri, 5 Jul 2024 01:50:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPecA-0002KW-GQ; Fri, 05 Jul 2024 04:48:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebO-0000yZ-VU for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:35 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPebA-0004C5-R1 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:34 -0400 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a77d85f7fa3so29608866b.0 for ; Fri, 05 Jul 2024 01:47:19 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72b033f3a3sm636125966b.187.2024.07.05.01.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:14 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 1ADC662107; Fri, 5 Jul 2024 09:40:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169238; x=1720774038; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FcTtzsKeBB4MlD0Q7gjS8cN5rY9ihom2n5xaHwaWlG4=; b=E6AjQ6/KC3wCia/eGNAZM4aTvg/WGIbN54MU4Aop0M58BW1I1MVXoGt0jRkT+Rb8ic AGTkjmsVvk8iQzQ33m1vx1os98kjombRNmequqjdYaZnIPhIIQAu58lhnk+TcxsAOJsz FtbnFodlf4WORp9VjR84pYV9q8ZJZdF1OGLXEoyfqM6dPdnKIdi56QfktvlEiEshYi6c EIZV9mEyNwA28YWH4mdloNHVYY6YgKhl2eBiQKJVWjTIvZIkmZvsqvHHLY0K7O6IS70l 4hk1YBqiI/XoHBlgIppgZyWAdVX8beosZDmRY4VGaKIQ+WtcWYRjbRPtxtCB+lfLIzhB z82g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169238; x=1720774038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FcTtzsKeBB4MlD0Q7gjS8cN5rY9ihom2n5xaHwaWlG4=; b=CJL8S2DQL752IDZVCQZZbE2jZh1sKfkfg21AJ4BxTblDUbrXcwlSAUwpO9UYSBYb0g uVz/FEETihBvSzBDHLkgukXgCIelJFMXS+b0RsYHxwRtUYAnjVT4ClG7arn+QEaiJjQJ YqjQv0ivefBjZbu9Cs8twuYmc7a00qo07nkOqobr9m+18OUSkvdvZfeIaXTjQ04mzbTP 5HkNNRpue6YAwE0dPCQ28HoxrTmJWMOsKCIoPg03GqsWI8QKmOS07n8z7G/C72MMCHAC VHUoyXROZbfEu90N/3Ge/YNxCplgDaQxler7IpoM4shUV/YuU5qSHAh4DTxO1PqPChC9 WPfQ== X-Gm-Message-State: AOJu0Yx5gemF5UE2Wvz+20t/Q36+uWBq7geIxc4+WhXFLRF8w9kvlwwA 1ldDuFcN0HwyDzI+6w++yJxB/QswGAcPcd72CF8w5DOre20ECkqoMlCurblnUmY= X-Google-Smtp-Source: AGHT+IE42LIRsJmCP8FHhJ0bNVrRawiv6myytSeD1SwwYw2X9Vdn/RKT3wpeAQ8rRgqvAkoXWhhZ/Q== X-Received: by 2002:a17:906:d1d2:b0:a77:cfe9:8ed5 with SMTP id a640c23a62f3a-a77cfe98f21mr73338466b.30.1720169237896; Fri, 05 Jul 2024 01:47:17 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 14/40] tests/tcg/arm: Drop -N from LDFLAGS Date: Fri, 5 Jul 2024 09:40:21 +0100 Message-Id: <20240705084047.857176-15-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169406505100006 From: Richard Henderson This is redudant with a linker script, and is not supported by clang. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-10-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/arm/Makefile.softmmu-target | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/tcg/arm/Makefile.softmmu-target b/tests/tcg/arm/Makefile= .softmmu-target index 39e01ce49d..547063c08c 100644 --- a/tests/tcg/arm/Makefile.softmmu-target +++ b/tests/tcg/arm/Makefile.softmmu-target @@ -13,7 +13,7 @@ VPATH +=3D $(ARM_SRC) test-armv6m-undef: test-armv6m-undef.S $(CC) -mcpu=3Dcortex-m0 -mfloat-abi=3Dsoft \ -Wl,--build-id=3Dnone -x assembler-with-cpp \ - $< -o $@ -nostdlib -N -static \ + $< -o $@ -nostdlib -static \ -T $(ARM_SRC)/$@.ld =20 run-test-armv6m-undef: QEMU_OPTS=3D-semihosting-config enable=3Don,target= =3Dnative,chardev=3Doutput -M microbit -kernel @@ -30,7 +30,7 @@ CRT_PATH=3D$(ARM_SRC) LINK_SCRIPT=3D$(ARM_SRC)/kernel.ld LDFLAGS=3D-Wl,-T$(LINK_SCRIPT) CFLAGS+=3D-nostdlib -ggdb -O0 $(MINILIB_INC) -LDFLAGS+=3D-static -nostdlib -N $(CRT_OBJS) $(MINILIB_OBJS) -lgcc +LDFLAGS+=3D-static -nostdlib $(CRT_OBJS) $(MINILIB_OBJS) -lgcc =20 # building head blobs .PRECIOUS: $(CRT_OBJS) --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169075; cv=none; d=zohomail.com; s=zohoarc; b=fSeZXCOJ1b7avo9uUKycxJAsAW0WYY9tv9PmiAQLOnQU00TSFGeijon1sW+Svfliasahv7uvbWdXXPO98eW0czKqJFzyKQSxMThLYy6roJysTI7k+XDSbGFJuwaVHBCVGD8ZNJYjiXaQdovBGq1/Go5ZvEYrQoZFsd1BF9jG9o4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169075; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yZmaG2CChCOyc5PFSRDoUdccfXw50o6nOO/sLxGnTzs=; b=fzLqt+a0+lEtdCR84mXQwZW0tp2RMXLKoRTk2mRL+n8RJe9T8FXCzw/StrvdTqqK3wMipcACLxzlZC9Sj3xMvThWNKVdXnLDI9KTzV9xTmTqN5GKTptdlUc9z3nh7+hJAU4PQ1vcgNeQcWxuGQLFOYiV2ZwzxfhmbUE6QxMDVF8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169075434627.3852489134001; Fri, 5 Jul 2024 01:44:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVT-0000jW-BS; Fri, 05 Jul 2024 04:41:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVB-00007t-MZ for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:12 -0400 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeV4-0003Fi-69 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:09 -0400 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a77c9d3e593so54847066b.0 for ; Fri, 05 Jul 2024 01:41:01 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab0651easm662620666b.137.2024.07.05.01.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:57 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3122D5F876; Fri, 5 Jul 2024 09:40:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168861; x=1720773661; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yZmaG2CChCOyc5PFSRDoUdccfXw50o6nOO/sLxGnTzs=; b=ke+RX4eT7CB4KrEl3t1jZstQnSltMnECh8kAEoz/ez+U97xm7bZLg2VVo4HK3Qhnhh 7YifdZCbpV5SlArmXTroll2yk7tjP1d+HeunxmiYyn/Rqx0SU9jSvaKM23YWHX8ENM/+ eNXfU81UIncjPykU5XYGgaDb8myrYXPsLkEvxu3KLZvz0pFGzYa9sxflSoZtY8TTw+Ak WpCaLQBTfyEruqFxMqqT0HpsijDSqh4AYPmv7r7fAOmCHhOSEDmZqpqVVlAPvq2GaDeN DdhZ3yObW/veUg0LVqQx8C0cuaDbWMrUZRzsx/Ab78GFssckURGMleDSOdZweevZlTsc D0Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168861; x=1720773661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yZmaG2CChCOyc5PFSRDoUdccfXw50o6nOO/sLxGnTzs=; b=HlsXofAxG5WGimWzQ2My1Abwwz06BlhUzBkj/mVo+DlQwxJwdqmtbZe+r8TfNFVKB/ G56mgYuJbTl73Qiu1UjhCT4cO+fN5Ivlek9YX/aeRWz5HvfmEFXE6LZp8MRunYeghQis bpZMa2BbIq1T9zfW/UXYZEFNedW65GL28ZIJfwoW9YqeJs8M1rAWOg8Vd1gf2xOie0Wn iOcSoZR1lv1NGkjCpFY7MpQFwJmq6GeiosnKG59T0zOQMkG5Yggp1wSBjvyja8dC8t1b B5I/y5VbAQJBRMFC0lf7G+OXnKtUmaAmruOHrz/wsmyKqmEYaSYWxXAyHv4XczV/FwCr dGKQ== X-Gm-Message-State: AOJu0YxoUY8eD9OlGCYha0hdpM+UMT42D6Crc10Choeui82Xu5YnKhx+ YrRFsk6f/Ht4CvDxtHShO9V+BoGfqiOvSreRugfK5M7JE+PicGr9GBAfVbukDuE= X-Google-Smtp-Source: AGHT+IH4YaGA3ScYPYfsLtQV4WtJ7voz4HJOvSoYLgpxmEBjTT5wWGNArU3sTYTQziSTSaBFGHKf9A== X-Received: by 2002:a17:907:104a:b0:a6f:ab9c:7778 with SMTP id a640c23a62f3a-a77ba4c949bmr247996366b.34.1720168860336; Fri, 05 Jul 2024 01:41:00 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 15/40] tests/tcg/arm: Use -fno-integrated-as for test-arm-iwmmxt Date: Fri, 5 Jul 2024 09:40:22 +0100 Message-Id: <20240705084047.857176-16-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169077073100001 From: Richard Henderson Clang does not support IWMXT instructions. Fall back to the external assembler. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-11-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/arm/Makefile.target | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/tcg/arm/Makefile.target b/tests/tcg/arm/Makefile.target index 0a1965fce7..95f891bf8c 100644 --- a/tests/tcg/arm/Makefile.target +++ b/tests/tcg/arm/Makefile.target @@ -8,6 +8,11 @@ ARM_SRC=3D$(SRC_PATH)/tests/tcg/arm # Set search path for all sources VPATH +=3D $(ARM_SRC) =20 +config-cc.mak: Makefile + $(quiet-@)( \ + $(call cc-option,-fno-integrated-as, CROSS_CC_HAS_FNIA)) 3> config-cc= .mak +-include config-cc.mak + float_madds: CFLAGS+=3D-mfpu=3Dneon-vfpv4 =20 # Basic Hello World @@ -17,7 +22,8 @@ hello-arm: LDFLAGS+=3D-nostdlib =20 # IWMXT floating point extensions ARM_TESTS +=3D test-arm-iwmmxt -test-arm-iwmmxt: CFLAGS+=3D-marm -march=3Diwmmxt -mabi=3Daapcs -mfpu=3Dfpv= 4-sp-d16 +# Clang assembler does not support IWMXT, so use the external assembler. +test-arm-iwmmxt: CFLAGS +=3D -marm -march=3Diwmmxt -mabi=3Daapcs -mfpu=3Df= pv4-sp-d16 $(CROSS_CC_HAS_FNIA) test-arm-iwmmxt: test-arm-iwmmxt.S $(CC) $(CFLAGS) $< -o $@ $(LDFLAGS) =20 --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169068; cv=none; d=zohomail.com; s=zohoarc; b=U/buy+Nr52eM1D3ayLIf8FWiEhbzfkNUmTBEKzX6seo524zhA+EWqfvMdVbLFztv61dp51/IkO+x1yug8rEmmqYbxhlFpKIFHms5oLH4pdw2dks7AuFu2Tv3fP4wQr7uTpPSyGpt+SrWe0I8iRZWvTiFfhmIL9Zw9+Jh0YQrpnU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169068; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=G+3mOXYCWAbpqiQ1tZVqIs8ST0t41HILKCllmhwUlz0=; b=UgxSsydOwWMiIRayqNWSwcP9uJSMVCwxaojYUSV7FDgmDAjnEDLyxlpZJ5BrvxuERWp5EW0DS+r22gT6Id9McmE0Fnu2Pfeib2MqY+KNUayES/vSz90AmqjMBLEW/Rhq25U1UPSr+5z6cxhVtcK52cpQ+PKvlwx8p8LqXLoICPk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169068930964.1069228298057; Fri, 5 Jul 2024 01:44:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVr-00025n-LA; Fri, 05 Jul 2024 04:41:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVD-00008Q-So for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:14 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeV6-0003G8-F3 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:09 -0400 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-58b0dddab63so2217290a12.3 for ; Fri, 05 Jul 2024 01:41:02 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5903c7ac61csm58765a12.4.2024.07.05.01.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:58 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 487E76211A; Fri, 5 Jul 2024 09:40:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168861; x=1720773661; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G+3mOXYCWAbpqiQ1tZVqIs8ST0t41HILKCllmhwUlz0=; b=VuNa4C+yO8VDHGIIv4NZAVoT52HoQePQYsJdsnkQMoQB94Ju0wp1jpas3qeHjkpvQN 9uxg80DGy5mrcc7fLZVibqDAySw5Pxjq3MY2XXT4ENEZ17WCu1ma1FZ4t0eB0dbqD514 3q9Cufmy0GblpyyGlCT/s+jbxQNticVquEjPeouGM68zyLdvLvNmyzfCl1azjAXlmY31 nEI+orXjWJJThLV36/2PxGBCpdaUIB6eLDqFErtup90eoCzfYxh0IbsmYPmOHSz/uCJ1 IHxDnKzgNJ2dpNYXHVJUFA4M1dgFcHs7m9vN6RpBfH1+Fy3+55kCPEWzc/nX2dLqwCPC LzCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168861; x=1720773661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G+3mOXYCWAbpqiQ1tZVqIs8ST0t41HILKCllmhwUlz0=; b=C1PlQhUB1T8/xh4Jv8gwWWXyKPlH0iGd8teZI5EP9JoF+oQ4xswLbz9N0JWKRwoyHQ cCqD4MF9ng0EMu2k9jOaY+ySEMa1norLJQJ8nT90gLKASqVxTs3Xu0y8SAAqQmTMuO91 quwHUq6QrabrJvFdvchRfALqyCz04AWZxfM3rv/OGpXFxaOxx6e9iULEP0CKuPEro9NG sok+q9mbioI593Qe+72lLAjddpxjKCKEPGUOGihGqYvQc3fWIITDbNZCT8KELaA3P/Yo 02A4jExScXb7tMFmulwEzxTVJMfCGEc42VWo+CaYVZi8m6iJDpTCy9/89MVk5L2hcqiE +lSA== X-Gm-Message-State: AOJu0YwxJztpu/+JjNAu+oRFCyAX6SuNxdqhf/uL2oIs/EwIMzOH8uup J8vmZZ64xOPCghPeQh9rhzOM7Vh9MJ57O/HhWy2HZfMngsS1BS61ipVOxmwMOhg= X-Google-Smtp-Source: AGHT+IFUk21V9WaKAhy3u46esCrErFQFDlsrV/K8Wyas7k8aBlqWhTjlyGZIuHcKZler4Kxab1gx7g== X-Received: by 2002:a05:6402:1254:b0:57c:7ed7:897a with SMTP id 4fb4d7f45d1cf-58e5c824ea4mr2469260a12.27.1720168861392; Fri, 05 Jul 2024 01:41:01 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 16/40] tests/tcg/arm: Manually register allocate half-precision numbers Date: Fri, 5 Jul 2024 09:40:23 +0100 Message-Id: <20240705084047.857176-17-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169071172100003 From: Akihiko Odaki Clang does not allow specifying an integer as the value of a single precision register. Explicitly move value from a general register. Signed-off-by: Akihiko Odaki [rth: Use one single inline asm block.] Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-12-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/arm/fcvt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/tcg/arm/fcvt.c b/tests/tcg/arm/fcvt.c index 157790e679..d8c61cd29f 100644 --- a/tests/tcg/arm/fcvt.c +++ b/tests/tcg/arm/fcvt.c @@ -355,7 +355,12 @@ static void convert_half_to_single(void) =20 print_half_number(i, input); #if defined(__arm__) - asm("vcvtb.f32.f16 %0, %1" : "=3Dw" (output) : "x" ((uint32_t)inpu= t)); + /* + * Clang refuses to allocate an integer to a fp register. + * Perform the move from a general register by hand. + */ + asm("vmov %0, %1\n\t" + "vcvtb.f32.f16 %0, %0" : "=3Dw" (output) : "r" (input)); #else asm("fcvt %s0, %h1" : "=3Dw" (output) : "w" (input)); #endif --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720168989; cv=none; d=zohomail.com; s=zohoarc; b=jtogfNpy7f3V0CD7l/A47Kuty965n4l9TZGfhNTPni5RpqnLwJa6oSlApmLqXQcjqdQbbX4kXxqZXWNJeBKO2YzzzFqBe/PAdv+JbZPkC7/E5Fb1flCIkfVyfuMnkz+kGyWqermVohzHk2fNiOTgQfE20YeUk8D0d79vbqFxwZA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720168989; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aiGk7AOsQ7y9imsMVDdBn97JRYhfShbL95x+ZPjiJBo=; b=XSzHziZEYDvHPot/EbNEku6HpQR16qgrQ7yxPDlVf8/BNqWd+LH/UDeJussV1b0KHvl37MNjtsqEwNDRby2vAVAY/VDPFz8hhuEcKSt0VeOHCtnnp8lB2/fapNm3GX2D1Q8sY7uZFCUOmbh4hK0kxwS1Mr4+ECfcOQcjmUZSKxQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172016898989053.80159278928238; Fri, 5 Jul 2024 01:43:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVo-0001mA-4p; Fri, 05 Jul 2024 04:41:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVD-00008P-Sq for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:14 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeV6-0003GR-OU for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:10 -0400 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-58b3fee65d8so1748269a12.3 for ; Fri, 05 Jul 2024 01:41:03 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58d0bfeec43sm3091667a12.48.2024.07.05.01.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:58 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 609A76211C; Fri, 5 Jul 2024 09:40:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168862; x=1720773662; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aiGk7AOsQ7y9imsMVDdBn97JRYhfShbL95x+ZPjiJBo=; b=p/3gBxFIjh80qa7vlvJ2cJ+1QGonFr8N5Cg7WhWmErqugR7NAywRVRqHuAcnBtZ/NP M13O/i9QCWfxyPAMh0kyZ2qhZn+as1vpNDr2PWzVS7sQBCt8CtmvICOFVKl2CJ60hF+M WPm2pQlkcUeU8+jSB1NmrdzO+FcN0DDi0K13CDrqXEw8622YLgp1zEmqtQ5msMvUVSwl q7ObMAQFltDsOUoYkKIjuma7G70VlAFbzZ6g/NBFEYZs+JxwV43EB8ly41eKMMIhB6cq F8mKYcjPJxyRFcCsaB4JDGEhMlO5j1KBjSTtv1y2xC1/j0Q9A6mXmZWrYZfrFzZ4Kapx aUyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168862; x=1720773662; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aiGk7AOsQ7y9imsMVDdBn97JRYhfShbL95x+ZPjiJBo=; b=cwb3E8b3h9qk4GrJDAH4ER8n1UQA43QXLWvPDFeMOu3866XMcjYkV5GmGGO4fF5X+a sY0zIuj6J9K++5zveWZrfAphe8UG2GVATR9D0gK9nGxpvf8Epk4W/cA7O+3MXI5K1TCD LWX3YuPqhtM9nOP90+e4CVNS9AKXnROAtpBsB7uQSvOz2aeA3NZbwxmhryx01wN84cmw k9tVgVSF9AvOXjVRWTYki9LW+e+4Z70o6YSK9o8H00UcnTfcoNf3EO9wp+nK0yO7ydYQ HdoStL12rIbMuPPUjz2/P7Rf0tlktERGa7YO72LY3Ys+y9zx/i7EHatF1+uHVv7aQx7V c/vQ== X-Gm-Message-State: AOJu0Yzy07tFqDEdQhyHTRIakVrWtd8uiKeLvAv6cnuhaCioytrBojfN UP5LLcA4x4SKr5lFTdpSPu9X8ZZK+isVi1ATWE8dBpZODjeCpg9ro0uoI7c0mQA= X-Google-Smtp-Source: AGHT+IH/B5mhOwdoz/raCdw2lG4JqJQGZOlNY8IvR/VgEFCYLeWZ3CaFIZVAp7CRKfwS8WiD9AF0Ew== X-Received: by 2002:a05:6402:2548:b0:57c:610a:6e7f with SMTP id 4fb4d7f45d1cf-58e5984c803mr3243200a12.11.1720168862360; Fri, 05 Jul 2024 01:41:02 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 17/40] tests/tcg/arm: Use -march and -mfpu for fcvt Date: Fri, 5 Jul 2024 09:40:24 +0100 Message-Id: <20240705084047.857176-18-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720168990718100001 From: Richard Henderson Clang requires the architecture to be set properly in order to assemble the half-precision instructions. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-13-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/arm/Makefile.target | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/tcg/arm/Makefile.target b/tests/tcg/arm/Makefile.target index 95f891bf8c..8e287191af 100644 --- a/tests/tcg/arm/Makefile.target +++ b/tests/tcg/arm/Makefile.target @@ -29,8 +29,8 @@ test-arm-iwmmxt: test-arm-iwmmxt.S =20 # Float-convert Tests ARM_TESTS +=3D fcvt -fcvt: LDFLAGS+=3D-lm -# fcvt: CFLAGS+=3D-march=3Darmv8.2-a+fp16 -mfpu=3Dneon-fp-armv8 +fcvt: LDFLAGS +=3D -lm +fcvt: CFLAGS +=3D -march=3Darmv8.2-a+fp16 -mfpu=3Dneon-fp-armv8 run-fcvt: fcvt $(call run-test,fcvt,$(QEMU) $<) $(call diff-out,fcvt,$(ARM_SRC)/fcvt.ref) --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169131; cv=none; d=zohomail.com; s=zohoarc; b=eJoqrsxIlhmlAilYx9ArupQXnBhZjQWvFaN9ZW7SoO/th/7ZTw0nsLRtxOZXlrFNapf5PGEZj9Aa0OKviSRRO5/8jHURwQd5owmi83DpacVzpysz+UeYH0Hpceqs/e/f3yQZQCaMVaSYV8kj67HTRLAc4nJB2eSPvUuip1s9YG8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169131; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iPz1sDK1Ip6ndIJH7eYfvSbU6ynrUeNTFBfJ1fhzt4s=; b=NygN3wLo9cjcH4FeNckGODb3e+OrhHF93Bx9KDFTYOB2Oyrp73R9Mylp7xGekQ7OI87stdqVNVDcJrg26EV7Gj+Km0hTR2WKeEYnwPvv/J6aqS3gHKkkCaAIbLdl4zJS1Wwp57DrdeTkC75Agz99AEyDEabovRqdQFRvRDc+iT0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172016913125242.86422397877436; Fri, 5 Jul 2024 01:45:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVm-0001YG-IL; Fri, 05 Jul 2024 04:41:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVB-00007M-Em for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:12 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeV4-0003Fq-Fn for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:08 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-58c2e5e8649so3656238a12.1 for ; Fri, 05 Jul 2024 01:41:01 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-59017354272sm192488a12.95.2024.07.05.01.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:58 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 760E95F8AF; Fri, 5 Jul 2024 09:40:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168861; x=1720773661; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iPz1sDK1Ip6ndIJH7eYfvSbU6ynrUeNTFBfJ1fhzt4s=; b=tTTiI2Qe5Ei0RcGFPJBZKxn9ZL/3vqCK969cHYKwywt4P1V1VOVwj+Ed7r0wQ+mIA+ wTAM6WzItd9GLLsVu2PHfjTvEruqUBafAXG0oQWYG80p68EasTyED2Mzd1e2J7Yu+c2R O4ys++ZL3um5d5z0gy8eu3CL82wMNuFXjbqlCKPZTvUuUncytZGDE5RY6q21tdaHAnVk MTsb9/FgBqCumn9JP4AH33v0RWztO4qDHDstjMyQReqAcRmMvD3nMfvOorJQcveTEqj7 fQ2H/NTPPRWkS0V75KFkW/goPMKx+R+DHgvi7LtXOHVYBglUf5U8EmKTa2EWrguCMQJv P2xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168861; x=1720773661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iPz1sDK1Ip6ndIJH7eYfvSbU6ynrUeNTFBfJ1fhzt4s=; b=lwznhT51wP0Eqz4xsXux4pvNNmUby09BypB2kB7PeXQyGj9BoOVThP8z0eMWHAqoPA QcBXzrn5FeNeIbxswMWg6ysoM9bVQBrJTLDgtezy6Kbkn2QN3eR+czMQNSmkQXVSsgFb jlR6ck+dHBMSTqRNI0u5Knh/AJ0nH4oRH6w+/0K8LJUOg9aMBnw3X260NLvKX2CKPGN/ 34GgYDQ1OosAnorjg4ZzIdSrInMFEMyAx7kVEu0+198yJRpIqM6riNgvwRu0MpXlqe5U nb8O1tdTcBSISk6kYuvYH2TvawMC6sZDG2yMzFHrN7lgBZU3RwZHlmldhllXa+RXtK+t dIWw== X-Gm-Message-State: AOJu0YzIJ1LhjBpP98vgw9dMMoRaMr4hxwMh3OP+8hPjxkQl5Qi9zAfm gqR4zSi2GMxnU7JNx8RA4zM809Q0uyHRFTSEBYrrOg4YhfbuzAAs9rFXXNYRhKE= X-Google-Smtp-Source: AGHT+IG+gK34PRVmXxXuvJXX6hUVJeUTLz/+JVXjEdbBuXKrw5q60Zft0qHevKaHEiOXw3ndjp/Qyg== X-Received: by 2002:a05:6402:50cd:b0:58c:77b4:404b with SMTP id 4fb4d7f45d1cf-58e7b6efab1mr2899517a12.15.1720168860829; Fri, 05 Jul 2024 01:41:00 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 18/40] tests/tcg/arm: Use vmrs/vmsr instead of mcr/mrc Date: Fri, 5 Jul 2024 09:40:25 +0100 Message-Id: <20240705084047.857176-19-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169133333100002 From: Richard Henderson Clang 14 generates /home/rth/qemu/src/tests/tcg/arm/fcvt.c:431:9: error: invalid operand for i= nstruction asm("mrc p10, 7, r1, cr1, cr0, 0\n\t" ^ :1:6: note: instantiated into assembly here mrc p10, 7, r1, cr1, cr0, 0 ^ /home/rth/qemu/src/tests/tcg/arm/fcvt.c:432:32: error: invalid operand for = instruction "orr r1, r1, %[flags]\n\t" ^ :3:6: note: instantiated into assembly here mcr p10, 7, r1, cr1, cr0, 0 ^ This is perhaps a clang bug, but using the neon mnemonic is clearer. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-14-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/arm/fcvt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/tcg/arm/fcvt.c b/tests/tcg/arm/fcvt.c index d8c61cd29f..ecebbb0247 100644 --- a/tests/tcg/arm/fcvt.c +++ b/tests/tcg/arm/fcvt.c @@ -427,10 +427,9 @@ int main(int argc, char *argv[argc]) =20 /* And now with ARM alternative FP16 */ #if defined(__arm__) - /* See glibc sysdeps/arm/fpu_control.h */ - asm("mrc p10, 7, r1, cr1, cr0, 0\n\t" + asm("vmrs r1, fpscr\n\t" "orr r1, r1, %[flags]\n\t" - "mcr p10, 7, r1, cr1, cr0, 0\n\t" + "vmsr fpscr, r1" : /* no output */ : [flags] "n" (1 << 26) : "r1" ); #else asm("mrs x1, fpcr\n\t" --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169351; cv=none; d=zohomail.com; s=zohoarc; b=DT32I5+4ZdT8NxiX55f1qt2DK8fGFRutmWZ5oNgOSlg3bk3LQ1jDc3gVtcful8AFeOo8ISQkrlvh/q1caPbfKkjzD8MqFzFnfoi/A6bbXQY/ohEvoeQNpxQIbSNF4WRg0RQxkfInrs0sQCQVtUQZ9+MLGh6dIdQGlW7RT1kX/Cc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169351; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=42dfRSdqLtSCAsO34FUpCEGuS1QIkfM9imEkVZpHhnU=; b=Tvfg+EOIDOtB49+U3ZWy68osxD93mTnJ+ihYpdtCUgQ3vaiZ5W8nL9k9J8JHjaWNGWtccd65tR64+drfUHFcKaIimIbWQNCnTqs0qetbVI/D5tyse4mtJaRKnPgEsOO9nsTU3rwhoeiPnJXdqd040S+LhumoQURPij3BOnI4+g8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169351476976.9445148422279; Fri, 5 Jul 2024 01:49:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPec6-0002BE-Dh; Fri, 05 Jul 2024 04:48:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebL-0000wg-NR for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:33 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeb7-0004BL-Au for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:30 -0400 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a77bf336171so194562066b.1 for ; Fri, 05 Jul 2024 01:47:14 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77dade9b61sm3514866b.160.2024.07.05.01.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:11 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 8B2346211E; Fri, 5 Jul 2024 09:40:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169234; x=1720774034; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=42dfRSdqLtSCAsO34FUpCEGuS1QIkfM9imEkVZpHhnU=; b=GfWbHettglD/1qZJ+xJdCZ4Prn2MdsbYFm4H9gVmVkC74u3N0jmiZ3/4SWsHuwlvIM xxywDdITQJyAEunfjBTpvZfz3L2Cys/AiyNNFN4eDPELh+ROI73+fSGfC6QXgL0uDs6E JlCWzBF2Bj4WiX1dKAX4T6ojOQH5CG+cx9XAyk++eS1n2D2g6K/AhPdtIcO2i83wlG0w N+O+0RyTdI6S2y2Th7Xe4zSBj89lWeCmUVfJUdwOPMFhw0rzikfkXm4I1vnkIqDLdQsF P1LNM+gRlljvmNrNVVmD9ESNn3VhhLQaxDuzE/UKUxmVIx4lHLsiyK8wG9lZf3Sue+a8 8KbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169234; x=1720774034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=42dfRSdqLtSCAsO34FUpCEGuS1QIkfM9imEkVZpHhnU=; b=PAGlG+eZE0j4DT/AGZlGEtcpLXsEEN5nmDUDsjMFxwW0hZm1lZWo4EAfdpfnwnedzy smRbmhgh7lfcSnt8AKqXY8xSd/4KMbhPR9EeGqP/gni2A+LgkmeEOPDxrErE9tScWVRy nb+sNrPQayJ2nM19VAliGN7YEOIeAfVeDTmUGWxTbKvlwLnG/2oBIn4pUUxh21Fn64eo oppRi7UuhCKS/uHf2+rB4HzTKM6v/pOQolNGRF0mPX5DyYf0F5qGvseQ7FsxPX9ISghx 8lMMOXoKh7gssmuRFyvQbBYB0B95GezGn/7ozxeHNQrFdoMpnvj3SWeEFGktdFKhWTu1 KRgg== X-Gm-Message-State: AOJu0Yy0rFJSmeu1hOXOierkcoLHPF9Q9zUznYsxZYbhRVnFgoCsA8fz a8EdFQdP+HNszyNSj+LYqu4TCPf7XSFnDX0afTRsZ443xnps5cObC/mlny2hYUM= X-Google-Smtp-Source: AGHT+IERQtXO/lSildv7YfdLiTQqGhIu/s50ufihwva0gyWZEBGvTmIMU0XYvjX4tHT7LWrcdNsuZA== X-Received: by 2002:a17:906:348c:b0:a6f:6337:1ad5 with SMTP id a640c23a62f3a-a77bda9cc3emr285297666b.27.1720169233689; Fri, 05 Jul 2024 01:47:13 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Akihiko Odaki Subject: [PATCH v2 19/40] linux-user/main: Suppress out-of-range comparison warning for clang Date: Fri, 5 Jul 2024 09:40:26 +0100 Message-Id: <20240705084047.857176-20-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169352265100003 From: Richard Henderson For arm32 host and arm64 guest we get .../main.c:851:32: error: result of comparison of constant 70368744177664 w= ith expression of type 'unsigned long' is always false [-Werror,-Wtautologi= cal-constant-out-of-range-compare] if (TASK_UNMAPPED_BASE < reserved_va) { ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ We already disable -Wtype-limits here, for this exact comparison, but that is not enough for clang. Disable -Wtautological-compare as well, which is a superset. GCC ignores the unknown warning flag. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-15-richard.henderson@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- linux-user/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/main.c b/linux-user/main.c index 94c99a1366..7d3cf45fa9 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -843,6 +843,7 @@ int main(int argc, char **argv, char **envp) */ #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wtype-limits" +#pragma GCC diagnostic ignored "-Wtautological-compare" =20 /* * Select an initial value for task_unmapped_base that is in range. --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169004; cv=none; d=zohomail.com; s=zohoarc; b=LIs++lNWhC96PPHVBk5lIHbc3tJagMv4n+sOlW8bMqz2rXmZPh2E8qgMg7yJdUKnLSIkz784Bj6TfCZPpBXJAnpRIiPMYh6VEVgW/AavkIHetPiQ+Uc1Z7JZPVApkI43vu/ih1NmN1dOtZB+GTNmMPWExBdFZLgVFSc6PLaZCSQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169004; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xGMwdrjzaVjDq8zEZYSVnqK2CyrYL4caV/sFBWJUwr8=; b=oKzAn3k1kIm50RSnpEEdyD2HKSd25FdoH7E57FeycWqpujo9ZhpWWGNGJHDtxkOLNvlTvpbQe5uJGWdeEwYpMoPWxPzS6cY4Ou+2Bk6TK61pLWtcDBmAKOrELPpoOmd1Rz1Gs+3ztNl6tMCKeCFtJaJQU9t6YpV+bp1k2EI/kIA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169004462161.04787437417133; Fri, 5 Jul 2024 01:43:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVW-0000t5-QN; Fri, 05 Jul 2024 04:41:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVE-00008W-89 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:14 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeV9-0003HT-TG for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:11 -0400 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-58bac81f419so1968677a12.0 for ; Fri, 05 Jul 2024 01:41:07 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a73e52c2cb5sm578758266b.16.2024.07.05.01.40.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:41:00 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id A390462139; Fri, 5 Jul 2024 09:40:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168866; x=1720773666; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xGMwdrjzaVjDq8zEZYSVnqK2CyrYL4caV/sFBWJUwr8=; b=Ak7jKdK4SNmN7ZUmF78STJF7G4GBBZ8fo+llHShZxXbtKsqUUynBtQa/2OMs2oVNXh QFRXG07XXL8su3CtknbFhWrbLbzKL3jmV/W2rHJ5I3MBO6LfGllkoES29D6IIQXa7JpW azT6LsVpXUj4NLHMId0ExvIGQbtEixOvurAdwM4P8vuPF7NnOJaq7PnKIshsYt1otdhz 2MEhgCDNj0GtDBmU9HJZxNiSmurJr61mBLG5MGSARvU3bi25HodsbIlbTaWt/Ghh08FI moZj3IOaQ/dzW7zcMaav6iH0mzF22G1hgAymLq3xAZ3UCbQSM13uO81PedBgPj4vrmWl H6ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168866; x=1720773666; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xGMwdrjzaVjDq8zEZYSVnqK2CyrYL4caV/sFBWJUwr8=; b=ND/nNf9A2Zb66BLknNyHeMtre8HT1Fnl3w6Ju7Xw3IlDlK1Ib4D5YOmUyjRsQslOCA inQhMu9LuimTB8GSU6Ff3kY6R3AoJqsahd/Tf3nVw4pbhvukk2qoj0GKcHyMAzQM6MP6 lwGgowYOHcGvoapmBBp3xvhlKeZTD+805UpKphawsNw4JBeUbigXNlilV6/cmBp4UH5m D4yFr7D/4SEs8Zfz2lHdotnkdSydELRH1lZn6dzBpPKYBOR0MQQU0tTw7pr6GSswrvgk BNv+Z+nrsCo+MjP36TnHeUtS+HboUK9QECv56veIV7P340l4sv2vA0re4rKLFvR9Iw26 p6aw== X-Gm-Message-State: AOJu0Yy1ZUM1HtsVJsUAVBjb0M659JaJSP1EmhQUrQGwmPqMCGHlXpLR QWg9TGEABd1GdW44nzGm9doOZp54MDXozf5n2qt3wF8SqFpiotJ+Kz+7An7iCf0= X-Google-Smtp-Source: AGHT+IG3ittBM/K9+GEuiAPuXbV5kJonx+k58MpQduMwZltZG15RemxO/mBmRFXnWoDn3Kr0/bwgSw== X-Received: by 2002:a17:906:605:b0:a6f:e47d:a965 with SMTP id a640c23a62f3a-a77ba4d146dmr238250066b.41.1720168866257; Fri, 05 Jul 2024 01:41:06 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 20/40] gitlab: don't bother with KVM for TCI builds Date: Fri, 5 Jul 2024 09:40:27 +0100 Message-Id: <20240705084047.857176-21-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169004746100001 In fact any other accelerator would be pointless as the point is to exercise the TCI accelerator anyway. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml | 2 +- .gitlab-ci.d/crossbuilds.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 425fc6479b..e3a0758bd9 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -635,7 +635,7 @@ build-tci: - TARGETS=3D"aarch64 arm hppa m68k microblaze ppc64 s390x x86_64" - mkdir build - cd build - - ../configure --enable-tcg-interpreter --disable-docs --disable-gtk -= -disable-vnc + - ../configure --enable-tcg-interpreter --disable-kvm --disable-docs -= -disable-gtk --disable-vnc --target-list=3D"$(for tg in $TARGETS; do echo -n ${tg}'-softmmu '= ; done)" || { cat config.log meson-logs/meson-log.txt && exit 1; } - make -j"$JOBS" diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml index 3de0341afe..cb499e4ee0 100644 --- a/.gitlab-ci.d/crossbuilds.yml +++ b/.gitlab-ci.d/crossbuilds.yml @@ -68,7 +68,7 @@ cross-i686-tci: variables: IMAGE: debian-i686-cross ACCEL: tcg-interpreter - EXTRA_CONFIGURE_OPTS: --target-list=3Di386-softmmu,i386-linux-user,aar= ch64-softmmu,aarch64-linux-user,ppc-softmmu,ppc-linux-user --disable-plugins + EXTRA_CONFIGURE_OPTS: --target-list=3Di386-softmmu,i386-linux-user,aar= ch64-softmmu,aarch64-linux-user,ppc-softmmu,ppc-linux-user --disable-plugin= s --disable-kvm MAKE_CHECK_ARGS: check check-tcg =20 cross-mipsel-system: --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169394; cv=none; d=zohomail.com; s=zohoarc; b=HwfifA6ZLqqczIZPEVaRJw9P9HZEBWAMsyX0PU0EERYBjyk0drGy6ORJWB4YwbTVgtAvU+b+sLD4hJiBc/ivvnEOJzLTHMGMfSSsFPrzzLxSNIO7uUIVsny4q+IvJKngSFY2BfRDnfhAzHYdKDRdAIpvsVosP1a0yU5440fqhRc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169394; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rvGmIc/IqaQmuLkCI/kfZ02beHV2np9KXDzigOomwVY=; b=ZS52JGHKDH1rJtpPRhO2nczUdPX8UzMToyXIZe4MSu4X37zQe4UxwHX6NPju5WLgrsjH1GOIVSMEYgnTipECTFVI2uUFivv/R6HaykTCl53ROjRhmu348RqEgAjKOmLOVdHpB8lRRgvPUsdKbLPjNL7yv5cxjVDwBGoW9A1a0MY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169394181625.3979059235518; Fri, 5 Jul 2024 01:49:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPecE-0002ki-Cb; Fri, 05 Jul 2024 04:48:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebR-000119-3j for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:37 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPebC-0004Ci-MK for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:36 -0400 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-58b5f7bf3edso880801a12.0 for ; Fri, 05 Jul 2024 01:47:21 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5902c5f74f6sm121979a12.88.2024.07.05.01.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:16 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id B9CF86213B; Fri, 5 Jul 2024 09:40:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169241; x=1720774041; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rvGmIc/IqaQmuLkCI/kfZ02beHV2np9KXDzigOomwVY=; b=in7Lqla4JNXzW8kXfO3Nux1UqsyAxl7Cf5LomM3LrtAPEZmx8Bdc4q2jVrTSa+teXc ZqY0hw45ZPKHkiBC5XUhIYtqo1b3ar3Ooh1hG/IMBRgw80zaLmkSn3HzAHiugrpdsA0e cwiRTq0AnvIfb/Te99du73U3Ak222kQ6Q8F6xz7fGPFjRH2rRYla2o8YSlqBpxOjKUxD k9pdbHsW0GG2iBNvCabLLd9Ee7gKsnI74YXw0uP3Pc/ro12ciSqS6ARudLNDmuQ/rpB6 WMyWnZa8AK3HLVuxtrR5VPkgFYPVOxsHkDEn17dsJmrpcN1nxD7/FrFQtkFZQp1dOBB6 2CsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169241; x=1720774041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rvGmIc/IqaQmuLkCI/kfZ02beHV2np9KXDzigOomwVY=; b=TiJN6bdhIMfLz/F0XBtC6VADO6rGtDX+kWmhMkj8qP43y0ctyUiipLMBU/Bfh9iAxR yKzxosTGMnTSK7MsyM8Fp1oyR1dc1/+imxpvxgH8RD7+H1qAEd/IF/yBbZM659UbllBc wSfxrhHEsl8EnFUemgYvvSoLVtZOmNBIkW6o+sJlhA7mAVeLCJj9dtaknS1Y6W6c5AW8 pLuK+K6n9HFX7G+A6e5IJZCkpiXZ81H+cRGNgQw9nRwkNaathkSWnc8R+BYztLrOiVfz eqi0H53ihwaAuTwHLuJ9EbKiaeA2a27Jtyj7L6UeDyOynarVhexYxYEcoJO3LHm907cm VCNQ== X-Gm-Message-State: AOJu0Yz+rHfXMaczTMItcgqki6CDgbeWgWHJ+ifWDKdQtuSgpag4pmvr OPVKiuFFSfD/vyWM0kxecXJP4l0RHUrp8WCV3hLvJWBOnjuaaWUyzaJh4Cx1mQk= X-Google-Smtp-Source: AGHT+IG7Y4c+2QbK60kabKShm7UnkToLD8lzkjlq/GeUVtXONwWYLR2/QV++lN1AaHduQj02lMoGJg== X-Received: by 2002:a05:6402:4312:b0:58f:44fa:a2b9 with SMTP id 4fb4d7f45d1cf-58f44faa6c8mr1665943a12.16.1720169240516; Fri, 05 Jul 2024 01:47:20 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 21/40] test/plugin: make insn plugin less noisy by default Date: Fri, 5 Jul 2024 09:40:28 +0100 Message-Id: <20240705084047.857176-22-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169394428100002 While the match functionality is useful lets make the verbosity optional while we are actually running. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Manos Pitsidianakis --- tests/plugin/insn.c | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/tests/plugin/insn.c b/tests/plugin/insn.c index 5e0aa03223..524f9ddde8 100644 --- a/tests/plugin/insn.c +++ b/tests/plugin/insn.c @@ -20,6 +20,7 @@ static qemu_plugin_u64 insn_count; =20 static bool do_inline; static bool do_size; +static bool do_trace; static GArray *sizes; =20 typedef struct { @@ -73,30 +74,30 @@ static void vcpu_insn_matched_exec_before(unsigned int = cpu_index, void *udata) MatchCount *match =3D qemu_plugin_scoreboard_find(insn_match->counts, cpu_index); =20 - g_autoptr(GString) ts =3D g_string_new(""); - insn->hits++; - g_string_append_printf(ts, "0x%" PRIx64 ", '%s', %"PRId64 " hits", - insn->vaddr, insn->disas, insn->hits); =20 uint64_t icount =3D qemu_plugin_u64_get(insn_count, cpu_index); uint64_t delta =3D icount - match->last_hit; =20 match->hits++; match->total_delta +=3D delta; - - g_string_append_printf(ts, - " , cpu %u," - " %"PRId64" match hits," - " =CE=94+%"PRId64 " since last match," - " %"PRId64 " avg insns/match\n", - cpu_index, - match->hits, delta, - match->total_delta / match->hits); - match->last_hit =3D icount; =20 - qemu_plugin_outs(ts->str); + if (do_trace) { + g_autoptr(GString) ts =3D g_string_new(""); + g_string_append_printf(ts, "0x%" PRIx64 ", '%s', %"PRId64 " hits", + insn->vaddr, insn->disas, insn->hits); + g_string_append_printf(ts, + " , cpu %u," + " %"PRId64" match hits," + " =CE=94+%"PRId64 " since last match," + " %"PRId64 " avg insns/match\n", + cpu_index, + match->hits, delta, + match->total_delta / match->hits); + + qemu_plugin_outs(ts->str); + } } =20 static void vcpu_tb_trans(qemu_plugin_id_t id, struct qemu_plugin_tb *tb) @@ -216,6 +217,11 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin= _id_t id, } } else if (g_strcmp0(tokens[0], "match") =3D=3D 0) { parse_match(tokens[1]); + } else if (g_strcmp0(tokens[0], "trace") =3D=3D 0) { + if (!qemu_plugin_bool_parse(tokens[0], tokens[1], &do_trace)) { + fprintf(stderr, "boolean argument parsing failed: %s\n", o= pt); + return -1; + } } else { fprintf(stderr, "option parsing failed: %s\n", opt); return -1; --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169003; cv=none; d=zohomail.com; s=zohoarc; b=e0FdCx3Cm0tBwPVuwBBMU32P0XAenjkcB6AiRK7cH9KldEUq1wKlU4kPm6BhOR34/7xeObg2lebUBVuuf3hGMhsPNnqE2uPxWgsW5Nl42V9HysaaB827Rp9Ug9ohanZLLJ1rgX8syn7GYfoeSpROWTHhFKdztIiJlaIsYhqMqA0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y1MGJW50FjVhjyrhFQsVUOHRmt7nlCHL11oCXI6mA2A=; b=eWQLJ7Z5qg0CTOV5BiL4i65C0X7lcoliv3yCIwuihA0p6H33PWDzq8vnJJEVk0Tvf5Bcer5xG6KkeP5wmrjqaJx55CwYtlekoC8rPjBE7+uoNRTLYhmnGjG7SPHKJ1c3+PqLs4iz4zWvn6GteEEijRAyNfpDJYbFqULmkUaUNGw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 172016900342088.91590960959581; Fri, 5 Jul 2024 01:43:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVn-0001hU-Dh; Fri, 05 Jul 2024 04:41:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVD-00008N-Rp for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:14 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeV7-0003Gl-SS for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:10 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a77b51631adso156476566b.3 for ; Fri, 05 Jul 2024 01:41:05 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77c69041f6sm61531166b.103.2024.07.05.01.40.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:40:58 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id CFEC75F92A; Fri, 5 Jul 2024 09:40:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168864; x=1720773664; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y1MGJW50FjVhjyrhFQsVUOHRmt7nlCHL11oCXI6mA2A=; b=Oz7D96m4ffwQ+TnEe2QTva841BsyXZNmUebwLGrQcN2iyigVc9QDn6tKflOwciaUYF TlezIijOkaM1eStDbeOt19jY8wGZmij9KJQnCllZf7nqa2P1wOJpU5YnaeFm1ftLyzuj mVmsxVo9TDL5xethBmpkjBhRuVL13kNJWQIgoJpGAjN0T0C805eX07diAGUatTi6JOPa r1IHOfHL8qURFJr00UrFY42c9SM2+zpxwUkvo1yniJyB4Dzq7mSZdCEj8acsPV2fxtzD CZR1EgG8Jp6MTH1C5LSMXkNXL7GPVCt9f5dJdw0S6qkgKDl6o6AooN0lVt1+/dkeMxjY NMXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168864; x=1720773664; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y1MGJW50FjVhjyrhFQsVUOHRmt7nlCHL11oCXI6mA2A=; b=l1PRO1v5hS5bC8Gm1zaYWHvZY51fX+BXl07FbGFKy4JG96bkUKrUoISIDPMhkodGav xn2hPBwVDY9AW3FolW6zhrsizSsIqMjF4/ISiFLCeChK/1b63FqkoFx7yC7H7LktvRpo 0EyuebGY6YBu0zrxkVqmvQpEyS04ia6FzMHye0Y8mObp3z8yf1aqCa/k1Sgb5N6l6+sL dlv4DVeOr7a/IGGSDLvJQpv7vmvMX4ZySl3zwwIsTsjym4IjoZ9OVcTCHG2csiVLAp7+ 2kLMODAMKhRzjBhrJT8ALVxwzi/nom4P0youpeumBzBtBhee03IxuaBtd606VuppWHOA 6b+w== X-Gm-Message-State: AOJu0Yw/cOwyMSd5mXTTlyIyuzQK4HWALmY/OpqQpMuyrRGt/nFPbBWN qqc5qsgnDGDlBnBsxHTXTmbjKLHgGWBzJ95MsAZoUFyflAB+4coL750p4RN7zvM= X-Google-Smtp-Source: AGHT+IFrwBmZxaytuPQjknYlD+FiDwmMIMeawSg3WNh1P+osY9pq+oFQazNvczk+PHx2IemdvxZt8g== X-Received: by 2002:a17:906:d8c8:b0:a77:daa9:402 with SMTP id a640c23a62f3a-a77daa9052bmr11169466b.35.1720168864058; Fri, 05 Jul 2024 01:41:04 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 22/40] test/plugins: preserve the instruction record over translations Date: Fri, 5 Jul 2024 09:40:29 +0100 Message-Id: <20240705084047.857176-23-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169004779100002 We are interested in the particular instruction so we should use a stable record for it. We could bring this down to physical address but for now vaddr + disas seems to do the trick. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Manos Pitsidianakis --- tests/plugin/insn.c | 76 ++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 71 insertions(+), 5 deletions(-) diff --git a/tests/plugin/insn.c b/tests/plugin/insn.c index 524f9ddde8..baf2d07205 100644 --- a/tests/plugin/insn.c +++ b/tests/plugin/insn.c @@ -43,6 +43,44 @@ typedef struct { char *disas; } Instruction; =20 +/* A hash table to hold matched instructions */ +static GHashTable *match_insn_records; +static GMutex match_hash_lock; + + +static Instruction * get_insn_record(const char *disas, uint64_t vaddr, Ma= tch *m) +{ + g_autofree char *str_hash =3D g_strdup_printf("%"PRIx64" %s", vaddr, d= isas); + Instruction *record; + + g_mutex_lock(&match_hash_lock); + + if (!match_insn_records) { + match_insn_records =3D g_hash_table_new(g_str_hash, g_str_equal); + } + + record =3D g_hash_table_lookup(match_insn_records, str_hash); + + if (!record) { + g_autoptr(GString) ts =3D g_string_new(str_hash); + + record =3D g_new0(Instruction, 1); + record->disas =3D g_strdup(disas); + record->vaddr =3D vaddr; + record->match =3D m; + + g_hash_table_insert(match_insn_records, str_hash, record); + + g_string_prepend(ts, "Created record for: "); + g_string_append(ts, "\n"); + qemu_plugin_outs(ts->str); + } + + g_mutex_unlock(&match_hash_lock); + + return record; +} + /* * Initialise a new vcpu with reading the register list */ @@ -131,16 +169,19 @@ static void vcpu_tb_trans(qemu_plugin_id_t id, struct= qemu_plugin_tb *tb) * If we are tracking certain instructions we will need more * information about the instruction which we also need to * save if there is a hit. + * + * We only want one record for each occurrence of the matched + * instruction. */ if (matches->len) { char *insn_disas =3D qemu_plugin_insn_disas(insn); for (int j =3D 0; j < matches->len; j++) { Match *m =3D &g_array_index(matches, Match, j); if (g_str_has_prefix(insn_disas, m->match_string)) { - Instruction *rec =3D g_new0(Instruction, 1); - rec->disas =3D g_strdup(insn_disas); - rec->vaddr =3D qemu_plugin_insn_vaddr(insn); - rec->match =3D m; + Instruction *rec =3D get_insn_record(insn_disas, + qemu_plugin_insn_va= ddr(insn), + m); + qemu_plugin_register_vcpu_insn_exec_cb( insn, vcpu_insn_matched_exec_before, QEMU_PLUGIN_CB_NO_REGS, rec); @@ -173,13 +214,38 @@ static void plugin_exit(qemu_plugin_id_t id, void *p) qemu_plugin_u64_sum(insn_count)); } qemu_plugin_outs(out->str); - qemu_plugin_scoreboard_free(insn_count.score); + + g_mutex_lock(&match_hash_lock); + for (i =3D 0; i < matches->len; ++i) { Match *m =3D &g_array_index(matches, Match, i); + GHashTableIter iter; + Instruction *record; + qemu_plugin_u64 hit_e =3D qemu_plugin_scoreboard_u64_in_struct(m->= counts, MatchCount, hits); + uint64_t hits =3D qemu_plugin_u64_sum(hit_e); + + g_string_printf(out, "Match: %s, hits %"PRId64"\n", m->match_strin= g, hits); + qemu_plugin_outs(out->str); + + g_hash_table_iter_init(&iter, match_insn_records); + while (g_hash_table_iter_next(&iter, NULL, (void **)&record)) { + if (record->match =3D=3D m) { + g_string_printf(out, + " %"PRIx64": %s (hits %"PRId64")\n", + record->vaddr, + record->disas, + record->hits); + qemu_plugin_outs(out->str); + } + } + g_free(m->match_string); qemu_plugin_scoreboard_free(m->counts); } + + g_mutex_unlock(&match_hash_lock); + g_array_free(matches, TRUE); g_array_free(sizes, TRUE); } --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169926; cv=none; d=zohomail.com; s=zohoarc; b=VCMJgXt4abVN8GpSuwAvH9QugfoRks0V+q3hJ+65bXTzlWb4pU6UKI1T/1nklSBpNCy36VCvCSu7toO3usUfq7MtbfVQcCwm/uoTiu0X3SLQkQt+1tbVEB48dfNfIWdorOWN6Joe0FuSLGZtkY55KcFZ6BhC2iUYOD3NMGobUQw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169926; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ho2Bfe7yXa5eu8lKetJ/WAF5D27mUTaA0a7vXnXcLIs=; b=Rj3q9RxA+62BikO01Ss2PPjYrNrx/kAuFb0GxIrjopQoFOJZUODWg29jRB3nzJdatKgC25OdG8LGbluQqrKJN81l1vnnW31eJMEqvXrzQnZ91u/pCImE9Rok65WFhaoDKa6ZnWeN+84OOkDVXjS84Zg6gu9+9G9SBTgmiFpiNyQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169926673312.2879290968431; Fri, 5 Jul 2024 01:58:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPel2-0002mt-78; Fri, 05 Jul 2024 04:57:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeky-0002f2-9m for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:57:28 -0400 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPekk-0001uW-1b for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:57:28 -0400 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2eaae2a6dc1so19930291fa.0 for ; Fri, 05 Jul 2024 01:57:13 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77c0117b15sm101350566b.43.2024.07.05.01.57.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:57:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id E720B6213D; Fri, 5 Jul 2024 09:40:49 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169832; x=1720774632; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ho2Bfe7yXa5eu8lKetJ/WAF5D27mUTaA0a7vXnXcLIs=; b=mFoAOdUB6/t3Vn+1zMnJuodmIonBo0cOUFmVGgdsJ6CjzgKySr0PU7L3q9nro14D7N RvuBDSvlKOIx8jgJ0N+sLC2ZI46AirP31A9g+W0KKDCutt0iBhSj8qFl3nkz1/3yk5h1 WuXsl/d+MwXddanKK6GnNFMclu+C+SM0zAkVyF9kgktll3L/cBCiVX7CJ5eXaSdZsSNi 0uzJ51pN6IcsPZxIMmJAm5RlTfnhg1sRzSGcGhMM78q3B+LH1GfOvpwn7CMxOuBGIpBG 4kqRQdWtzBgD0TDK2E9iXMxB/b+pMhxWG5PMtjxZF1/hTE6mj4YFmq5rV5QejjJPkHI5 NTeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169832; x=1720774632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ho2Bfe7yXa5eu8lKetJ/WAF5D27mUTaA0a7vXnXcLIs=; b=ZuyTe2/KtSI7K9aIQeo1KF1gSCU1+ywowzfkbB8Cmm3vH5fhM/4OUmDTjnHwsFLHWP mHLRxsuk2UsjtJOKxH7pu18W9Wib3s3pISoNG57aNNxhU06Sda8Ytsyr5z1O1VuwrIRY VNcBhdc9dsbH7MrT2rz7/4O1On12y802ZBFm551pP5snVCoUldF/LPsAqY/TmyRFUloj fhepCXVx2FdN2liB/5Wcg9wlkY9fq+2WFex4JON17QHETkkaGW8nzxYfwUN8KjJGdIhl oEqLWO6aA6nMvhJ0e4w5x91VCMewXgH8ymH+WYD9iYFpdQE+twTdxMuN52mf0SyC16wv npsA== X-Gm-Message-State: AOJu0YxZ0zjyarDfuKFq4O6mFcAV1E3+F20mJwHv9ldFLKO3U+w1qBi+ U0JuuC4EthTTiphjeY1XhEFo3OqxDrtTia94N7TD4Lu2bJEt9u23POb4/quj+uQ= X-Google-Smtp-Source: AGHT+IHfZol7NkpqhMgZI+ueTbQskITA3RtbBrKeyqRVZF47QARE14/7WoFDnDzuzhXOLEPchKKOpA== X-Received: by 2002:a2e:9c8a:0:b0:2ee:80b2:1ea9 with SMTP id 38308e7fff4ca-2ee8ee21297mr31636331fa.49.1720169831473; Fri, 05 Jul 2024 01:57:11 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 23/40] plugins/lockstep: preserve sock_path Date: Fri, 5 Jul 2024 09:40:30 +0100 Message-Id: <20240705084047.857176-24-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::22c; envelope-from=alex.bennee@linaro.org; helo=mail-lj1-x22c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169927410100001 We can't assign sock_path directly from the autofree'd GStrv, take a copy. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Manos Pitsidianakis --- contrib/plugins/lockstep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 237543b43a..111ec3fa27 100644 --- a/contrib/plugins/lockstep.c +++ b/contrib/plugins/lockstep.c @@ -347,7 +347,7 @@ QEMU_PLUGIN_EXPORT int qemu_plugin_install(qemu_plugin_= id_t id, return -1; } } else if (g_strcmp0(tokens[0], "sockpath") =3D=3D 0) { - sock_path =3D tokens[1]; + sock_path =3D strdup(tokens[1]); } else { fprintf(stderr, "option parsing failed: %s\n", p); return -1; --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169374; cv=none; d=zohomail.com; s=zohoarc; b=dEkyHFfkEJSswJHJAb15X3NgL4Yqv922eOXHl4cIFNMPVRWqFY8BCPMI8a+wDTSlisPlqvmh80CXx0YdF9vrB6aKDqDtGa/qTEfzO2bI9BEKXygBiqCdh+7w8EyyaXeJs3ET4VRPvP4hghxBD54givrqqCUyJR4DzqdqhE5dc2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169374; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wP7tDDLg44bwHUt8SqbYxvL0ekGWQNKDr20DKrRYxss=; b=HCTNE6t07ABops+vkEnwjQAmbOeRoSxktuE4lIUsSut1rmRlz+JYkEw/jy+ushueXSilXYrO9R3n/mmCnWcfM4RSW+9k3ZVZmxuqRvWCK6wrvSJgj3OyrJpJxdmZ0hKGExlI3TdzH0voX4VVZZfVmMFGyKmme2oP/rEO5c9Nuak= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169374648189.19324765941724; Fri, 5 Jul 2024 01:49:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPebb-00018A-Il; Fri, 05 Jul 2024 04:47:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebG-0000tm-Te for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:27 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeb5-0004Aa-8k for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:25 -0400 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-58b5f7bf3edso880706a12.0 for ; Fri, 05 Jul 2024 01:47:12 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58eeabbf108sm1247721a12.93.2024.07.05.01.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 085AA62142; Fri, 5 Jul 2024 09:40:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169232; x=1720774032; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wP7tDDLg44bwHUt8SqbYxvL0ekGWQNKDr20DKrRYxss=; b=oCRt8zXiielVnfGoVZacjZ6UYFMT3ewmaZh8tbnCS99ir/YPMpB7IKZBmTca0xLV0X jCEtgJftL9NF+LUE5viHwXkLYdw0ExmpvW+obOPNN9VYoxfTsrv2t8Fo52pZ/379soh4 0zOa0Nv+Oq4G0EhmIB94/Tuvsfw3X5Utq2D5aVXbSZ8XTM1zLX3rWmU45e3kamFw5F+C 2d3vEPiQvg2aIUQlpTY4Spk0eqNe7YWWs+x18Kayv2MhJZnOuazcpqMaxQlxZqqxDV2n NyxWLeWLoopiKoxbm+BCDCv6UfMsTyN+qusJFW3+FbCDY0BDUaYwPZKv9/WYKUYe0faZ KVdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169232; x=1720774032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wP7tDDLg44bwHUt8SqbYxvL0ekGWQNKDr20DKrRYxss=; b=HF2IzBbvvLhGG6xPqpPcfV1I3kS2efElf0CGHGBOzfhPK6g2E+kbFGoQ5yLYJW5qBb BdGdpbmB2e9JNcN3XTrwC9lbwJxkeuAAZqTIxC5RNV2aKBwIvoKv+4l36dbvQFlYX+qf d+E2CAA5tiNdjVdVW5g1H6d+0qneohiHskwSf6qsGJLPJ+G02Yvqs3d6PdV08rQDN8uY 0S57oGe3eGLZqgDmGWjeXZ/UbMuZSLzXFOQL56NirtYoWXByA8XrvAe4cKQiUWDKMKND PPznQ9gLFw6V2RqL/Ct7YJTbw0FoGSJ1zJoXfAUnvItLhCZfCM7zho4NtQ9WOstYS+KU 3ihQ== X-Gm-Message-State: AOJu0YwAt2YooqNFnhGpThSX+9YKKHl+OC05SoR1eaJeKpnM5yPb+Drb HPcJZUw1FsMxM6z2Fqs7PG7QioS0627lUoT3DXZRGkRxz7WhE/LTWvbvJVIOskA= X-Google-Smtp-Source: AGHT+IH6pqLRN2BJry8uihFs7eo43QrE13jE3wSumHFBZkfY5J/MUYf4TRrBpTsgmSGz+kGUd0z0AQ== X-Received: by 2002:a05:6402:5108:b0:58b:2d93:ad6c with SMTP id 4fb4d7f45d1cf-58e5a408b30mr4002966a12.19.1720169231495; Fri, 05 Jul 2024 01:47:11 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 24/40] plugins/lockstep: make mixed-mode safe Date: Fri, 5 Jul 2024 09:40:31 +0100 Message-Id: <20240705084047.857176-25-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169376351100003 The ExecState is shared across the socket and if we want to compare say 64 bit and 32 bit binaries we need the two to use the same sizes for things. Message-Id: <20240628124258.832466-11-alex.bennee@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e --- contrib/plugins/lockstep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 111ec3fa27..761bcdf363 100644 --- a/contrib/plugins/lockstep.c +++ b/contrib/plugins/lockstep.c @@ -57,7 +57,7 @@ typedef struct { /* The execution state we compare */ typedef struct { uint64_t pc; - unsigned long insn_count; + uint64_t insn_count; } ExecState; =20 typedef struct { @@ -148,7 +148,7 @@ static void report_divergance(ExecState *us, ExecState = *them) =20 g_string_printf(out, "=CE=94 insn_count @ 0x%016" PRIx64 - " (%ld) vs 0x%016" PRIx64 " (%ld)\n", + " (%"PRId64") vs 0x%016" PRIx64 " (%"PRId64")\n", us->pc, us->insn_count, them->pc, them->insn_count= ); =20 for (entry =3D log, i =3D 0; --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169287; cv=none; d=zohomail.com; s=zohoarc; b=UC5hrVLJqWCxakgon805JLugw2DdGQmBwPgcUTiCHQFrucxfOxe7t6Z+ZyZ2tSh6agE+t1XFYjPkbIxdurgFhJcowidcFGTWiGqHUqxv5F5+OXQJuOoGtn+PvnosFPwj9ShIsQ/YenijoNS4tog4/teOSgoHbCvn+53CMPFHKI4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169287; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/lQrpNj9Yq6e2VZHJs41tWCzx2SCmT2FMLZDJQM+poI=; b=azOgZvFjwwX0SaTfl6y5ByzKLnSCMfhbv4VPkYKw6doBIJrbDiNB1KTTXFiY0+8YgMXX6LDnsOCogT+OD72fl2wvmSk1BRxZwiGBFPZgSUKotCfuJVBZ1fUH2o77HqBsC1in+kJJs9u/dcba/Hyk23tVhI6ortKEe8BR9fvQMcI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169287692779.7325220934929; Fri, 5 Jul 2024 01:48:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPebk-0001Bd-Hy; Fri, 05 Jul 2024 04:47:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebL-0000wh-OI for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:33 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeb8-0004BD-V2 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:30 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a77b550128dso175010166b.0 for ; Fri, 05 Jul 2024 01:47:14 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72b19d9b62sm630605866b.130.2024.07.05.01.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:11 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 21A4A6214B; Fri, 5 Jul 2024 09:40:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169233; x=1720774033; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/lQrpNj9Yq6e2VZHJs41tWCzx2SCmT2FMLZDJQM+poI=; b=oG37dxXwk5vuKP2tLldFZ9w8iLZuAJguF4DWl50z1X3THqTvWmmOALLGKJ/Tny1rFf YOCFG3gnuqkZkIPPNuAlzTOJge2Wi/3BfNX58z/e8J6jujulDgJQ7tfy0I2NhXfCOos+ F9Vb2zLCUpj48qNDUOzRi7TMdlz7reTD67QAXYLvygqF8ZUrrS8QjKZhygm5Hd2V8e54 PdHQ3kvzS2UPG1U3/Uzh1uXDSIxUI0rvAeB6ksCCc1avY92fJ9JG8Shb+dG696CJ0otm lzqfInk3wKqXDxh4yC5XWDLnjC76q058U2xquuq4zP8P0MRhJ5Fi3YUBaPF34guA3o7C OhxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169233; x=1720774033; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/lQrpNj9Yq6e2VZHJs41tWCzx2SCmT2FMLZDJQM+poI=; b=PDdudxiWN8AFX5OVXLli9zhW+pOv9jgZDoA9u3nHGYqL1aLHENo0jn6HuwpkQlwQzX aMhh9RVej3MlX/dvwf0fcuuqV74mPx2N7XotqtqIxchs5TFinSbrtr0dTlubm/jIChUb iJqGA1DFMENNQRKJ0ehamId+98wY7Le6Mf1+zKP+QMEogdZoVQEGbrQEImY/sI8xy6SE /qbETqWLCHsAJoeKFCAk7nCl5m/bvHnL8eO3591axTGQlzGpi5FZjbzzxZ8EXEOk4Cbt IBnqQMZVXd8RmKo77hpiDc8fieyU3bc2Za3tAhTcc09Wz+0gYriVzPTKx0ndtjiUE43N 2CXQ== X-Gm-Message-State: AOJu0YxYHJAJ0QGgQurlLESGcSt1yBvqyfbE0mfsiNBgR7QTop8WrvUm koGg72rAdVdUvhI+f4H3hO6PodXAY+3jBTeqPQide5FMuOJjRMwoVRvr62dXELg= X-Google-Smtp-Source: AGHT+IGdDQdvYQW/Eg4YM6ALwJo3mPLl9gsHQOQNAU81B1D6gECjzwAQ0okTX93dgHhOUQSazOC6Tg== X-Received: by 2002:a17:907:6e8d:b0:a68:b73d:30d0 with SMTP id a640c23a62f3a-a77ba45577emr318787266b.6.1720169233321; Fri, 05 Jul 2024 01:47:13 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 25/40] plugins/lockstep: mention the one-insn-per-tb option Date: Fri, 5 Jul 2024 09:40:32 +0100 Message-Id: <20240705084047.857176-26-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169287947100002 This really helps with lockstep although its super slow on big jobs. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Manos Pitsidianakis --- contrib/plugins/lockstep.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 761bcdf363..353bf12dfb 100644 --- a/contrib/plugins/lockstep.c +++ b/contrib/plugins/lockstep.c @@ -14,7 +14,8 @@ * particular run may execute the exact same sequence of blocks. An * asynchronous event (for example X11 graphics update) may cause a * block to end early and a new partial block to start. This means - * serial only test cases are a better bet. -d nochain may also help. + * serial only test cases are a better bet. -d nochain may also help + * as well as -accel tcg,one-insn-per-tb=3Don * * This code is not thread safe! * --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169326; cv=none; d=zohomail.com; s=zohoarc; b=iY9FJWzNiBQu4Nn8gDjK7vtg0OuIeigVOYgFEsIpwNySOVLKraJQX7cpm0CE+3t/1RneBPc4xijZYS8mX/EDvFM5Yd4t4SflY0GOhP9y2HIT0CbL2VeyHTt+4QGKbahmgjE1E+mzZIg+gfIRPoUEzRHimEovrWiMPNW9QPsV9h0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169326; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MXuTP0GCGD1U2EC0jCbVCWmWTWrrWZHqHe3306YwCaE=; b=X+TuWQ+jDZSbuEwcdoeumTQ9wxCjjR98MGONCQ9pDNNTasLkvmQcZe63rjbGiNjcjgqfbAAVhzgRb64xml/7BfwZqGxTIdSNJyIlv7aIxQ4sQXIsH6ghIAEz3V2HdO78jNyDPiQIwY9w6othABn6wNwPFFMWzpPrQcnI71Nil9c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169326977660.4539737890473; Fri, 5 Jul 2024 01:48:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPebr-0001Wu-Vk; Fri, 05 Jul 2024 04:48:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebO-0000yB-6D for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:35 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPebA-0004Bw-QO for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:33 -0400 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-58b966b4166so1703069a12.1 for ; Fri, 05 Jul 2024 01:47:18 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58fb3ee74f6sm493139a12.68.2024.07.05.01.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:16 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 37EA062152; Fri, 5 Jul 2024 09:40:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169238; x=1720774038; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MXuTP0GCGD1U2EC0jCbVCWmWTWrrWZHqHe3306YwCaE=; b=RRZnb2GUQhy61z+qWf+Rx3ER0q7PL+L7miqdTgAKbVUUsb30ASE2wamM85iLjy6jo+ k/gCHsLO1Ycv5kMDgdIO2zA+yvnoEQ46qcxH14LUIAZ6jWmsOdpxdS33wbNauJtiu8ty 59zLi2RAI9PFmlWgz6IE80fVkbNKvFHO9J4ljUX2G/HwQ1yRqLPv7Uuf5YWYUn7ocPK9 3EV6gu5zZXE64mNDTQ49qgWU1s0hidDu4pVuQ/vylfGK60YC1BYrHJbB3kIUTdwoCVc7 Z/uUiqKYWCURfEDAKSnB1KsIKKkzswNdLRiPiq8o0kf1TtH2L3Rb56jaMRjO1lAl3+JX jtDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169238; x=1720774038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MXuTP0GCGD1U2EC0jCbVCWmWTWrrWZHqHe3306YwCaE=; b=e2TB7zJc8ykOE/nCERlhiko7CaRv9FupP1VLaVYZJbIYUyojZ+ITAZFe0qk79c6DrE oXUFf29pXI9AIBqkUcnbabdEOafNHzlTq0YxbjY2MEzvAUGL5l5rCTj5vnmjeDpI1JHe eahPWsWOnSGH9B2grudIQPDyyRLS9YB7IT0bPmNNmAig2fHxcJwe91OSjlEQ519k/Dsd RYTwdSWO0IWXGuptFvx55VlheZ9C/SKO16o/wLGzNNBc++G5Im3wmqoS6dn3Zb+PjZbN 04MqafKpJZmxE6sp92NlXklM1DZXvCiTGlkmiqSizUh8j09toXYACC6fIlb2adj4Ew4h CBig== X-Gm-Message-State: AOJu0YxyLOPqpxlZuhwPPDnkzKM0q59ycjYjuuls9RCYABZsaRwpTnCX WKD3zDr6h5wrTyE3c/0ifqIM+YQTrjZzh2IXZO/ukZh25557FSIIeb5/2S5Qbco= X-Google-Smtp-Source: AGHT+IHW9KiHz33DZOiQ1P/zJcB5THfCLhw9h/N1JFfzRGzsRsTEIYccfvxOFuQ90S0y6vbL4TU61A== X-Received: by 2002:a05:6402:2105:b0:58c:2a57:b230 with SMTP id 4fb4d7f45d1cf-58e5955a333mr3220448a12.13.1720169237559; Fri, 05 Jul 2024 01:47:17 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 26/40] plugins/lockstep: clean-up output Date: Fri, 5 Jul 2024 09:40:33 +0100 Message-Id: <20240705084047.857176-27-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169328147100006 We were repeating information which wasn't super clear. As we already will have dumped the last failing PC just note the divergence and dump the previous instruction log. Signed-off-by: Alex Benn=C3=A9e --- contrib/plugins/lockstep.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 353bf12dfb..5b7dfc9c06 100644 --- a/contrib/plugins/lockstep.c +++ b/contrib/plugins/lockstep.c @@ -135,10 +135,13 @@ static void report_divergance(ExecState *us, ExecStat= e *them) =20 /* Output short log entry of going out of sync... */ if (verbose || divrec.distance =3D=3D 1 || diverged) { - g_string_printf(out, - "@ 0x%016" PRIx64 " vs 0x%016" PRIx64 + g_string_printf(out, "@ " + "0x%016" PRIx64 " (%" PRId64 ") vs " + "0x%016" PRIx64 " (%" PRId64 ")" " (%d/%d since last)\n", - us->pc, them->pc, g_slist_length(divergence_log), + us->pc, us->insn_count, + them->pc, them->insn_count, + g_slist_length(divergence_log), divrec.distance); qemu_plugin_outs(out->str); } @@ -147,10 +150,7 @@ static void report_divergance(ExecState *us, ExecState= *them) int i; GSList *entry; =20 - g_string_printf(out, - "=CE=94 insn_count @ 0x%016" PRIx64 - " (%"PRId64") vs 0x%016" PRIx64 " (%"PRId64")\n", - us->pc, us->insn_count, them->pc, them->insn_count= ); + g_string_printf(out, "=CE=94 too high, we have diverged, previous = insns\n"); =20 for (entry =3D log, i =3D 0; g_slist_next(entry) && i < 5; @@ -163,7 +163,7 @@ static void report_divergance(ExecState *us, ExecState = *them) prev->insn_count); } qemu_plugin_outs(out->str); - qemu_plugin_outs("too much divergence... giving up."); + qemu_plugin_outs("giving up\n"); qemu_plugin_uninstall(our_id, plugin_cleanup); } } --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169043; cv=none; d=zohomail.com; s=zohoarc; b=kDu1wT6zUCXkn0gyJCHXyv596BUhH8ZF2aOmWtiEv8GrfQcB03mDQlkc6qBUCMjwlGWSh4locTeCr1U3j/9uB8ig9tY2/MuJm3KkNRN73WCHu/zzN46JXo/+StQNY8F67COVx1ktylrHtHQAOu6S4x9YUDB7NUD8U/5iz4fHRBE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169043; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DnXg+HsT3zKonIJOFIVyarDg9njum4HQEtwWGbAQUUg=; b=H1eTPJtraFqVBlSe8fAtXZmZaF2WkSTRyqnPN0CiW74lNn1F0dkQGr3lSHxmAkwGXDQl3wNMBslsexLn8thCEP1VKc8p1f5vZU1SrMJ5KaB9x/WpSmjohdjwgu56gkGsYMKGz4lpDeCNcwOlNJja11m00YfvGn0AxfQ/pmapqew= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169043945526.9524684130859; Fri, 5 Jul 2024 01:44:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVp-0001xP-L8; Fri, 05 Jul 2024 04:41:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVD-00008O-Ri for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:14 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeV8-0003H8-W8 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:11 -0400 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-58ba3e37feeso1909379a12.3 for ; Fri, 05 Jul 2024 01:41:06 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf61f69sm662766266b.67.2024.07.05.01.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:41:00 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 4CA5E5F92B; Fri, 5 Jul 2024 09:40:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168865; x=1720773665; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DnXg+HsT3zKonIJOFIVyarDg9njum4HQEtwWGbAQUUg=; b=aaYtWWiRKdFMOIdK1e9Xp6hwbd5H4eAXmpamesPTHTUTlvjWsAfTXkFjf3p8ASCKGv 0SX1DpMrob7FRpK3BBnR/XoYTOnK4qcy5gYZZ3/O9Y6pGOEHcVT/ooqITU/lM2hqx/Ek Ny8RdaHDeeJvYsAfT8GzZuAdR3kW2u7dhXcJ69u5y869v7vXH0Mo97cUeiJ6Rn8ucz/H uP07QMVmkfwfLOVKjb+X9l34IX6av09kcsjAoUeAqMVrRZq77kn2LBoXyT1n7umo9fI1 jiuB6yhVwJB1cvr6eIgFZWUH0f/bS5Ah5wcFMnqusUhi74xXGDaK7T4OgAebJQvy9dux l8dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168865; x=1720773665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DnXg+HsT3zKonIJOFIVyarDg9njum4HQEtwWGbAQUUg=; b=H7G4Zcbg7DeksTGaFHUZcqyYfkkTQOTsxDSgvJdDpqcNc8UP0n8DX2QZ7E3tEmDh1V 3LUax1fJThNkFr1gQCdsefGbaGpdih5Dnz/BcbvUnDu8Ou/c2sddGRxkeIxYu1bsk2Ip cFPx8encSgLqjvRDaRBWwfpo69h18XZR5Lul4NYn91DH/RtN8ePbadcXfs6KCSRAclPc GQi0ThAISG0NG0aIsp6AMYSGkcdJ3Asd63t2vFTRDy/jSR2LsRhV1nYHL4aiyDosJ8XM CLUthUdpAwL5NP3pD75ZcYLcxMkGi0JyQwZLsHNFnJto6alkCc5CYCeadGQePUP08Gqt v2Cg== X-Gm-Message-State: AOJu0Yw3YzQKxlUeuxOBk4mDjV/QeN/lUJDZL9AI89/WIrk1Ve4ilrJW SwcRbuJPagmUvB+I0sLODCh3cE+207QhEgZbYvHs319GrfLcxwcqGbGb0nfezoM= X-Google-Smtp-Source: AGHT+IFSSIbUcVdXgZp8yK2AWZCWQeltbYQ1mRgfBAYE/Pdm2b1OFf1TJephjonlDcK0naIC81q5zQ== X-Received: by 2002:a17:906:d8c8:b0:a77:daa9:402 with SMTP id a640c23a62f3a-a77daa9052bmr11171666b.35.1720168865014; Fri, 05 Jul 2024 01:41:05 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 27/40] plugins: Ensure vCPU index is assigned in init/exit hooks Date: Fri, 5 Jul 2024 09:40:34 +0100 Message-Id: <20240705084047.857176-28-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169044919100001 From: Philippe Mathieu-Daud=C3=A9 Since vCPUs are hashed by their index, this index can't be uninitialized (UNASSIGNED_CPU_INDEX). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Message-Id: <20240606124010.2460-2-philmd@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- plugins/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/core.c b/plugins/core.c index 9d737d8278..a864275ae7 100644 --- a/plugins/core.c +++ b/plugins/core.c @@ -245,6 +245,7 @@ void qemu_plugin_vcpu_init_hook(CPUState *cpu) { bool success; =20 + assert(cpu->cpu_index !=3D UNASSIGNED_CPU_INDEX); qemu_rec_mutex_lock(&plugin.lock); plugin.num_vcpus =3D MAX(plugin.num_vcpus, cpu->cpu_index + 1); plugin_cpu_update__locked(&cpu->cpu_index, NULL, NULL); @@ -263,6 +264,7 @@ void qemu_plugin_vcpu_exit_hook(CPUState *cpu) =20 plugin_vcpu_cb__simple(cpu, QEMU_PLUGIN_EV_VCPU_EXIT); =20 + assert(cpu->cpu_index !=3D UNASSIGNED_CPU_INDEX); qemu_rec_mutex_lock(&plugin.lock); success =3D g_hash_table_remove(plugin.cpu_ht, &cpu->cpu_index); g_assert(success); --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169048; cv=none; d=zohomail.com; s=zohoarc; b=gtoJf/41XUr04PSqDwkTIl8HddPZ8oPihnrdTTY+iJao55+9TUPZtTmhTTjXbcESqztiUk+eQ6JyziIXBaP9kxwO4O4TdNRfVT5cOSHZ4W+PzsuRXECJMjrkddMVZaEU8C5REKSaMffbzS2GVAjyUK9ZBxB6LSXYQ47D09Dp/xI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169048; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lvuQOiGW9BFlfC8YjQOeAwRsNcaM68CdeZDfIgp7wbI=; b=CEjUU+oeYivt3ylSCbvvUTlgd+8fdWBmFPLiob/WFrIejrMdGHMkEC7GQduL19A1uA2V+FT4Mq/Fzja/ytSBLZVODPlOCVT0Pebpv/ke75LtwdLCg97V3RZdrLzeQaR5kX97t4597imJmESOdBFcQyULa+foeAYhtM1kM7APoT4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169048721458.2379142477931; Fri, 5 Jul 2024 01:44:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVo-0001rF-Tm; Fri, 05 Jul 2024 04:41:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVH-0000B2-Q5 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:17 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeVD-0003I2-LR for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:14 -0400 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a77baa87743so154558866b.3 for ; Fri, 05 Jul 2024 01:41:09 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77c3ef218bsm76340466b.71.2024.07.05.01.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:41:01 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 6572862155; Fri, 5 Jul 2024 09:40:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168868; x=1720773668; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lvuQOiGW9BFlfC8YjQOeAwRsNcaM68CdeZDfIgp7wbI=; b=pb/TUa4p8EIwBtGtYE14DnQa/qmg3QKIbizRuIy8zZpEuJqEtswRYIiURfcyOeGUV+ DLvEkl5igHp+A2b34hsOGgxJVD+WkwMVdMQWmKAA2levolWYzDro1Yb/p/+5QNp36ggM AhTvt3NW8qZVEDiD3Xh+W0E009iXX/mineUG5TPzb2wYWYU3kYw+X0cL1TkvpmswEccx Sl0dmt0APJ9GRzlUE5vP4vl+R2Gwp2C1izP3Qd9JHkav1xSbAhL9yf+9h7Tvn5SVhRdS MI39GK0clq4FPJkaM92sDEW847rz4Oc4y9a0CQ7LSdybMC5MmVxVJq7npyBiR2RgoutJ S9BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168868; x=1720773668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lvuQOiGW9BFlfC8YjQOeAwRsNcaM68CdeZDfIgp7wbI=; b=JUNtVZtMnBT4MXZfXgtFjmDdCZZ37Ct3/ac41s4QjcZg0M+QSUDixlvy4kT9JL5gYY eNJg4V7OwDSKCpJp50GkRLK412W915Gobu3sqjlLFzR6F+/lfJ0Bhg6ujZRPCiKeMYny 2BP2LkId1uQ+Dg3jmrZ9yRVEeoNmNFePaW3RWNXzm5yE+eoynArONFDCrKf09A22wx3V NNcbrnmqHIqKxS3B3yPnP9fdB9vbF14knD8aNlUUJSTgWZD0tkI9tgxxi4n7d0XTlG+x c97gXaTv3O+k2Q9KQ1jlZm/IYcaIk65XCJj5sdX3XZT3Xo1H1R4aarTxZa8JWAhrSOt2 R4Nw== X-Gm-Message-State: AOJu0YxfYilBMNHI5Fk+xz5ZxbTpoxjyQU1WgDWEi3cYRE8QGh9kTxBQ 0sXWAy85TthA/85UOCaHBL+mQYgkS8qCD8XmhF7ubZ8781LVAMACigV2bKikK4o= X-Google-Smtp-Source: AGHT+IEEeCMWOVzRLbNVbM2FEBrAPwUAOjM9enpMEEM6qfqWvnFtjEcdslg6UkgYLyB4ykj0j3iOOA== X-Received: by 2002:a17:906:34d3:b0:a72:a05a:6601 with SMTP id a640c23a62f3a-a77ba455f83mr340685566b.14.1720168868164; Fri, 05 Jul 2024 01:41:08 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 28/40] plugins: Free CPUPluginState before destroying vCPU state Date: Fri, 5 Jul 2024 09:40:35 +0100 Message-Id: <20240705084047.857176-29-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169048957100001 From: Philippe Mathieu-Daud=C3=A9 cpu::plugin_state is allocated in cpu_common_initfn() when the vCPU state is created. Release it in cpu_common_finalize() when we are done. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Message-Id: <20240606124010.2460-3-philmd@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- include/qemu/plugin.h | 3 +++ hw/core/cpu-common.c | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index bc5aef979e..af5f9db469 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -149,6 +149,9 @@ struct CPUPluginState { =20 /** * qemu_plugin_create_vcpu_state: allocate plugin state + * + * The returned data must be released with g_free() + * when no longer required. */ CPUPluginState *qemu_plugin_create_vcpu_state(void); =20 diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index f131cde2c0..8f6cb64da3 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -283,6 +283,11 @@ static void cpu_common_finalize(Object *obj) { CPUState *cpu =3D CPU(obj); =20 +#ifdef CONFIG_PLUGIN + if (tcg_enabled()) { + g_free(cpu->plugin_state); + } +#endif g_array_free(cpu->gdb_regs, TRUE); qemu_lockcnt_destroy(&cpu->in_ioctl_lock); qemu_mutex_destroy(&cpu->work_mutex); --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169050; cv=none; d=zohomail.com; s=zohoarc; b=NAySK2Z4chlGzjGY4J+r0fHz7rH8V1l85lAhg99XQ8KAhcSy0qJQi96IUWPEGkZ3hApqALnqPoYkza/Ks4rqTTqfkMK0UUqzNC8v7rllsx6ClFL2DCH8j+yISGo97tZDUWHC2Y4izbGi8mtSHbT2PWZP0NCjnOagv3oke8+I1qU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169050; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=z+z1akQCdvD4EPIckgvY2ywucJ1AQ3R2DHXwf7IjKDc=; b=KRNiWn4B0aVRLuS8qaLKyIx8ypl+HqGOV8SnR+P4AUwM9RdoTOfehGbjPLd8P0kCGkWJsQzRpHq87sG+3WqFxhYI9lZgBsvBTLRJl8aKZIdKU+j2jpAxZqEgzJH9R9VcX8AwUv+8ndUtvXTR5OPEUiOYw29ZqrB5AXnGuzSvLO0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169050413216.7054150765399; Fri, 5 Jul 2024 01:44:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVq-00021r-Ie; Fri, 05 Jul 2024 04:41:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVG-00009h-FT for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:16 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeVD-0003IH-In for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:14 -0400 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-58b447c51bfso1786014a12.2 for ; Fri, 05 Jul 2024 01:41:09 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58fbfccf0f9sm444538a12.75.2024.07.05.01.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:41:04 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 7D4CF62156; Fri, 5 Jul 2024 09:40:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168869; x=1720773669; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z+z1akQCdvD4EPIckgvY2ywucJ1AQ3R2DHXwf7IjKDc=; b=ndxaD3ACtGucNmxTduEJYr7U1uNmPv+WMKgXwsqf0o4Tn9HDH4+rspT45KH7wheQ8+ z5Un7TXQPgIfasrBZMBpxgNjGVvTPcIr0lzn/hAIeU3ooRXQwzPMwXawUePmg6Ylr74G tj7idwWtD6EbAheulxdsFKbFfSoPopJsVSMwV3lEnknm7Pu+M+Q73qaspuxFeOL7KwFL nR0780dOSn/DiHSerwZE1LMdnpdMXcJ28tWhLT8yKld0xvWVxeo/9G7tnuHbzOX0BTft s2fGo33ab7xq/h/QaRTxVMMjVynyxUcqNFfGw4zuOKCl+TgfQpiELDr4WLUFw6SVAPd7 D6eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168869; x=1720773669; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z+z1akQCdvD4EPIckgvY2ywucJ1AQ3R2DHXwf7IjKDc=; b=OWO5quiJPjWH5hcoWCM5pRNP5Kz5TRR1aptjjt3da2HJV/Lq6kKsscx6ws98W82hnM ZwjyJgrtTMhtmo/i++azWCJESyJjF3i2RyMqPXKkh6pzoufP9Obfjuc/XEUBNh44J+X/ GxoWYBwl01ibek3O2td4d/OiIK+mQYcoYIqOaBeJxUAYeknh8QQ/6CfLrxuI8spsQeLN AUI6pJ2uCkbNl0HL86bu2MxQ4fcjN/5e/8ZILY9foFx6TfZnI7AivyWsBHK0Yc9YScXo dFKBjgRdEzlDAr9WM03TgSao8p6ncHSejUQCA5XPKgT6PBnu91xRzjc039vsh8KNODTR HZIA== X-Gm-Message-State: AOJu0YwvSh+HneYxAxmBZvCikcxoUQu6mym2BKwthGQkDzp8XlN1fWs1 +PYBSY0BKTm/c9yKcvjFDwm/vZ6uYi7fj8gCrxd78+b3MWLWnME7Ha+yeMv4QyM= X-Google-Smtp-Source: AGHT+IFyHg2rkZgGiY42rqPAYRhZULZTk8PAfnHDMb2P387ScVI/ThA5hJE8jhCFt/yupzymWrXSyQ== X-Received: by 2002:a05:6402:5ce:b0:58e:dbd:65cd with SMTP id 4fb4d7f45d1cf-58e5b5a68b0mr2957743a12.26.1720168868595; Fri, 05 Jul 2024 01:41:08 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Subject: [PATCH v2 29/40] accel/tcg: Move qemu_plugin_vcpu_init__async() to plugins/ Date: Fri, 5 Jul 2024 09:40:36 +0100 Message-Id: <20240705084047.857176-30-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::535; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x535.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169051069100007 From: Philippe Mathieu-Daud=C3=A9 Calling qemu_plugin_vcpu_init__async() on the vCPU thread is a detail of plugins, not relevant to TCG vCPU management. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Pierrick Bouvier Message-Id: <20240606124010.2460-4-philmd@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- hw/core/cpu-common.c | 9 +-------- plugins/core.c | 8 +++++++- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index 8f6cb64da3..b19e1fdacf 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -192,13 +192,6 @@ static void cpu_common_parse_features(const char *type= name, char *features, } } =20 -#ifdef CONFIG_PLUGIN -static void qemu_plugin_vcpu_init__async(CPUState *cpu, run_on_cpu_data un= used) -{ - qemu_plugin_vcpu_init_hook(cpu); -} -#endif - static void cpu_common_realizefn(DeviceState *dev, Error **errp) { CPUState *cpu =3D CPU(dev); @@ -274,7 +267,7 @@ static void cpu_common_initfn(Object *obj) #ifdef CONFIG_PLUGIN if (tcg_enabled()) { cpu->plugin_state =3D qemu_plugin_create_vcpu_state(); - async_run_on_cpu(cpu, qemu_plugin_vcpu_init__async, RUN_ON_CPU_NUL= L); + qemu_plugin_vcpu_init_hook(cpu); } #endif } diff --git a/plugins/core.c b/plugins/core.c index a864275ae7..12c67b4b4e 100644 --- a/plugins/core.c +++ b/plugins/core.c @@ -241,7 +241,7 @@ static void plugin_grow_scoreboards__locked(CPUState *c= pu) end_exclusive(); } =20 -void qemu_plugin_vcpu_init_hook(CPUState *cpu) +static void qemu_plugin_vcpu_init__async(CPUState *cpu, run_on_cpu_data un= used) { bool success; =20 @@ -258,6 +258,12 @@ void qemu_plugin_vcpu_init_hook(CPUState *cpu) plugin_vcpu_cb__simple(cpu, QEMU_PLUGIN_EV_VCPU_INIT); } =20 +void qemu_plugin_vcpu_init_hook(CPUState *cpu) +{ + /* Plugin initialization must wait until the cpu start executing code = */ + async_run_on_cpu(cpu, qemu_plugin_vcpu_init__async, RUN_ON_CPU_NULL); +} + void qemu_plugin_vcpu_exit_hook(CPUState *cpu) { bool success; --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720168924; cv=none; d=zohomail.com; s=zohoarc; b=RN7TgMqn2qm29Kjkb5ehLxhr7tYNcubK3nUz7XKh65kmPhqxhI9CjWKAi3jG/YxaOiQwLAkLkxGlSijF5SyFMbt0gzck15j5ukgOhfpo3THRIDmJe+VB8YalBrq6CujzZElNCwxlpjvhKjD64kyLI1OaVQeA+tgAf+NsfQ8oMvQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720168924; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=n7/WIgjhiNKuvbrWJzfyGMGasKiffFNGnc0cAcukpvo=; b=bg+3Nk1A0/s2KHR6LQqX46uiHo+PVmfYljgTKOTcwtTggQcg2rgshKX9XIIKAvcVgrGL//b/VDY1c4CgGUyrd3snedPhbsp817lIfFC1asBusMHAKQQi4+08YlIPPIzbO7DSGXFUMXMgIcACr7EU0HtiunZwUO2zuj0MBZgzWrs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720168924589900.3441887550453; Fri, 5 Jul 2024 01:42:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVr-00026K-Sa; Fri, 05 Jul 2024 04:41:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVH-0000B1-Or for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:17 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeVD-0003Ii-KI for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:14 -0400 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a77baa87743so154559966b.3 for ; Fri, 05 Jul 2024 01:41:10 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf18933sm668677766b.13.2024.07.05.01.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:41:04 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 9461162157; Fri, 5 Jul 2024 09:40:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168869; x=1720773669; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n7/WIgjhiNKuvbrWJzfyGMGasKiffFNGnc0cAcukpvo=; b=RZ6ju7fIZhHAnlNc3hviFnG3Ms0Ttx4OC2Hft5JZi4fKYm4lT9/aI3P8NtWkfSmiWe tdfMoLIAJqFUogWXN17FYyhVussQEWzfeFV0Py/bhiCBrhCxezXt1eTjynHgHR92sW5/ aF1ahvzMxuTtwTQlIMABmOj8yBM/3RDU3U2F2mgI40jk1EkVamlJjmQqRfWNC8it06vK h4ItX73KiMZQbAO/xUZcovmTLkpNQHzPm4Z/9TGRT4vZqYzuxaFB8lr7JRe2N+KYxjl/ NL+xDWPhq/ed9rSOEurIiw+T9/1rZNUzaLocK3R1/LT/syjYxgT2AZTt3czk/8V34/L6 N/Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168869; x=1720773669; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n7/WIgjhiNKuvbrWJzfyGMGasKiffFNGnc0cAcukpvo=; b=Z13JkJELskZHDe0aGeajfY5kItrdaFq+kcSX21qUeJcNK/IUcrh2kzQxBykIVdsrTQ 8gMf+sKU8G2z7GbXw5cH4SSqtdAHmqbXGdXXli01X9M0PLFH41y6yDLV4tzqzlrh2WSm kZCk/Xu6PDe/qLyBIflu4qDkaDktHCsOT0zRrx2Po0fMg5Mq/DX2xqDF6GygtQPXbc9N aaFPdVZUEJvih3VKOztZvyVbX1OoraHgazFuotSaNEmvv/PGiHoJ7OPl5krBGTPXMwEQ VJR3KvOIJDbuGKycHVBmgOmskAnKe9jZvmK16WJrEzqdj0KAGyiqaqneES8I3vqWGNqE ZpNQ== X-Gm-Message-State: AOJu0YwdIOTkXm9zREwi1zjSBec30snT5HL57obU12bB+n70kxWUkXAz 963gC1ZbrC6Ft14bXQIYDK+G5E9RrMosFJuKr1LT5YAFEsi3n3VhReL6o1jjvgY= X-Google-Smtp-Source: AGHT+IHHvDecRfbh/FrhD0fTeHK/XRfCXPO616Gx3CpYamFKgCABcpgsCQ3FWeD8qFBa6oFpzecxrA== X-Received: by 2002:a17:906:f296:b0:a77:cdaa:88aa with SMTP id a640c23a62f3a-a77cdaa8b23mr68176466b.4.1720168869010; Fri, 05 Jul 2024 01:41:09 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 30/40] gdbstub: Clean up process_string_cmd Date: Fri, 5 Jul 2024 09:40:37 +0100 Message-Id: <20240705084047.857176-31-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720168926386100001 From: Gustavo Romero Change 'process_string_cmd' to return true on success and false on failure, instead of 0 and -1. Signed-off-by: Gustavo Romero Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240628050850.536447-2-gustavo.romero@linaro.org> --- gdbstub/gdbstub.c | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index b3574997ea..37314b92e5 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -962,14 +962,14 @@ static inline int startswith(const char *string, cons= t char *pattern) return !strncmp(string, pattern, strlen(pattern)); } =20 -static int process_string_cmd(const char *data, - const GdbCmdParseEntry *cmds, int num_cmds) +static bool process_string_cmd(const char *data, + const GdbCmdParseEntry *cmds, int num_cmds) { int i; g_autoptr(GArray) params =3D g_array_new(false, true, sizeof(GdbCmdVar= iant)); =20 if (!cmds) { - return -1; + return false; } =20 for (i =3D 0; i < num_cmds; i++) { @@ -984,16 +984,16 @@ static int process_string_cmd(const char *data, if (cmd->schema) { if (cmd_parse_params(&data[strlen(cmd->cmd)], cmd->schema, params)) { - return -1; + return false; } } =20 gdbserver_state.allow_stop_reply =3D cmd->allow_stop_reply; cmd->handler(params, NULL); - return 0; + return true; } =20 - return -1; + return false; } =20 static void run_cmd_parser(const char *data, const GdbCmdParseEntry *cmd) @@ -1007,7 +1007,7 @@ static void run_cmd_parser(const char *data, const Gd= bCmdParseEntry *cmd) =20 /* In case there was an error during the command parsing we must * send a NULL packet to indicate the command is not supported */ - if (process_string_cmd(data, cmd, 1)) { + if (!process_string_cmd(data, cmd, 1)) { gdb_put_packet(""); } } @@ -1523,9 +1523,9 @@ static void handle_v_commands(GArray *params, void *u= ser_ctx) return; } =20 - if (process_string_cmd(get_param(params, 0)->data, - gdb_v_commands_table, - ARRAY_SIZE(gdb_v_commands_table))) { + if (!process_string_cmd(get_param(params, 0)->data, + gdb_v_commands_table, + ARRAY_SIZE(gdb_v_commands_table))) { gdb_put_packet(""); } } @@ -1889,15 +1889,15 @@ static void handle_gen_query(GArray *params, void *= user_ctx) return; } =20 - if (!process_string_cmd(get_param(params, 0)->data, - gdb_gen_query_set_common_table, - ARRAY_SIZE(gdb_gen_query_set_common_table))) { + if (process_string_cmd(get_param(params, 0)->data, + gdb_gen_query_set_common_table, + ARRAY_SIZE(gdb_gen_query_set_common_table))) { return; } =20 - if (process_string_cmd(get_param(params, 0)->data, - gdb_gen_query_table, - ARRAY_SIZE(gdb_gen_query_table))) { + if (!process_string_cmd(get_param(params, 0)->data, + gdb_gen_query_table, + ARRAY_SIZE(gdb_gen_query_table))) { gdb_put_packet(""); } } @@ -1908,13 +1908,13 @@ static void handle_gen_set(GArray *params, void *us= er_ctx) return; } =20 - if (!process_string_cmd(get_param(params, 0)->data, - gdb_gen_query_set_common_table, - ARRAY_SIZE(gdb_gen_query_set_common_table))) { + if (process_string_cmd(get_param(params, 0)->data, + gdb_gen_query_set_common_table, + ARRAY_SIZE(gdb_gen_query_set_common_table))) { return; } =20 - if (process_string_cmd(get_param(params, 0)->data, + if (!process_string_cmd(get_param(params, 0)->data, gdb_gen_set_table, ARRAY_SIZE(gdb_gen_set_table))) { gdb_put_packet(""); --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169024; cv=none; d=zohomail.com; s=zohoarc; b=GIarIcCjADUpFJrCxXkDBSpPhQNkWuvRc9cN66tQ+34HA2Dls01lu6XZozk6Sw2eA9zKHbnMzuGY12VQvcPRrROa7LysOcNxQSNwdzIdKsbEdNxBFZ4P4H+u00op6+gjVYi1VuXO5sURButMNsv4WFO2Z+3coTng4n0hQ66/W9k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169024; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Flimb3UI3TQzVMfgDrGkQu518umUuIDBbLTxXTs9H8k=; b=a2Q74Ei+gKN+oWb1ILU/LRR3Ynw5Vztvqjez9DnoND6xcvLpeHHa0Prjz1f0y5kAbGGfOtWv8m+G6oNObCAa9rThSzhDNFo8DFYr8DSiViY+YojyyJMtXezC+NsnUIhrgmJmGKrcjCNn04hrfcT/vG8OYAg+SVrfLq5uLLCaqIg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169024430109.87180639266069; Fri, 5 Jul 2024 01:43:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVo-0001mP-5A; Fri, 05 Jul 2024 04:41:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVJ-0000Cg-Ie for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:19 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeVE-0003Jf-S0 for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:16 -0400 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-57cd26347d3so1895548a12.1 for ; Fri, 05 Jul 2024 01:41:12 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58d0bfeec43sm3091786a12.48.2024.07.05.01.41.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:41:05 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id B4D6B62159; Fri, 5 Jul 2024 09:40:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168871; x=1720773671; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Flimb3UI3TQzVMfgDrGkQu518umUuIDBbLTxXTs9H8k=; b=IRil544nYxSXIs2PHs5dNBwmrDeWNhO3kxLHU+aZs+9ETA8jrNT2tdvf/yAQ2CH6Gf P7JtUlnts7HIY7wDhDbbYhdodm4xhQQG16rp4na0GKzyqfuWUxR0EHO98d03ErcDvKfo ISiqpoUwKSGHEGFvrtVybb2Kg0/sYcIVi/FZWY4z50r6Zcz/jmHIFSD9C3Mgwu0R/I/4 HZbvCSOlaguYBJsp8PvyZtarZF+1xWIlJscr4W35tcnIePze5C7dfKn1IhH/4CJF31nR x7r5BqdPUldRQY/0uKbt5Us9WSGtq52gGXYDd/qRsfAk3hUlvNKEyEq5e8//JUtK84gf Gfjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168871; x=1720773671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Flimb3UI3TQzVMfgDrGkQu518umUuIDBbLTxXTs9H8k=; b=qBl/oVCPyxVO6Rxq/XD3f1Pka7Kh4EqTDBnEMyX1U59eUYsoNXVBljDht+tJ0YP43g Hu0HwX1NE1accDv6tPFiqYPn/hrqQdP8Qa4CBzv/lCTBH2wS/8G+z/fOiqGgP9q2O5Pg Fe53oNcGgT+8cC/QwSwErDAJKJrNgdCNU86kJau4+gIdNo3UO1uPcWrTHpa1ZdolFeha Ti63MkVVDSu2NwJkVnU350iXPLDgdvTq2HMy4wjd6/TvN3ohIMiaT+pkA7ldpyk4iuRq vB9HPd4Gf5jE2v88LgMpBziQdAsFC1DzibNRQ7bi6STue5XUPvTZdqEvXRMrnD8TVsad vY3Q== X-Gm-Message-State: AOJu0YxxxrgIKsUtUl+Ahc3WkX7L8AhCdP+niBoPwbx5p3LFTi/Us77w XLadtQM/nfrU/8W9vXZFpv9NrTQWwBWojk6N6KL2RCX2K25UuKMID1H9+sOX1m4= X-Google-Smtp-Source: AGHT+IHmNd7RFINgs8kBbI+p58z58vddeEEH/h79MiDmZGPE9VcJD6PZYLBDE34rJWv4wnT7XDVNiQ== X-Received: by 2002:a05:6402:5111:b0:584:8fcd:260d with SMTP id 4fb4d7f45d1cf-58e5a7e8b7emr3118108a12.3.1720168870969; Fri, 05 Jul 2024 01:41:10 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 31/40] gdbstub: Move GdbCmdParseEntry into a new header file Date: Fri, 5 Jul 2024 09:40:38 +0100 Message-Id: <20240705084047.857176-32-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169025021100002 From: Gustavo Romero Move GdbCmdParseEntry and its associated types into a separate header file to allow the use of GdbCmdParseEntry and other gdbstub command functions outside of gdbstub.c. Since GdbCmdParseEntry and get_param are now public, kdoc GdbCmdParseEntry and rename get_param to gdb_get_cmd_param. This commit also makes gdb_put_packet public since is used in gdbstub command handling. Signed-off-by: Gustavo Romero Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240628050850.536447-3-gustavo.romero@linaro.org> --- gdbstub/internals.h | 22 ------ include/gdbstub/commands.h | 72 ++++++++++++++++++++ gdbstub/gdbstub.c | 134 ++++++++++++++----------------------- gdbstub/syscalls.c | 7 +- gdbstub/system.c | 7 +- gdbstub/user-target.c | 25 +++---- gdbstub/user.c | 7 +- 7 files changed, 146 insertions(+), 128 deletions(-) create mode 100644 include/gdbstub/commands.h diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 32f9f63297..34121dc61a 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -106,7 +106,6 @@ static inline int tohex(int v) */ =20 void gdb_put_strbuf(void); -int gdb_put_packet(const char *buf); int gdb_put_packet_binary(const char *buf, int len, bool dump); void gdb_hextomem(GByteArray *mem, const char *buf, int len); void gdb_memtohex(GString *buf, const uint8_t *mem, int len); @@ -166,27 +165,6 @@ void gdb_put_buffer(const uint8_t *buf, int len); */ void gdb_init_gdbserver_state(void); =20 -typedef enum GDBThreadIdKind { - GDB_ONE_THREAD =3D 0, - GDB_ALL_THREADS, /* One process, all threads */ - GDB_ALL_PROCESSES, - GDB_READ_THREAD_ERR -} GDBThreadIdKind; - -typedef union GdbCmdVariant { - const char *data; - uint8_t opcode; - unsigned long val_ul; - unsigned long long val_ull; - struct { - GDBThreadIdKind kind; - uint32_t pid; - uint32_t tid; - } thread_id; -} GdbCmdVariant; - -#define get_param(p, i) (&g_array_index(p, GdbCmdVariant, i)) - void gdb_handle_query_rcmd(GArray *params, void *ctx); /* system */ void gdb_handle_query_offsets(GArray *params, void *user_ctx); /* user */ void gdb_handle_query_xfer_auxv(GArray *params, void *user_ctx); /*user */ diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h new file mode 100644 index 0000000000..639257493e --- /dev/null +++ b/include/gdbstub/commands.h @@ -0,0 +1,72 @@ +#ifndef GDBSTUB_COMMANDS_H +#define GDBSTUB + +typedef void (*GdbCmdHandler)(GArray *params, void *user_ctx); + +typedef enum GDBThreadIdKind { + GDB_ONE_THREAD =3D 0, + GDB_ALL_THREADS, /* One process, all threads */ + GDB_ALL_PROCESSES, + GDB_READ_THREAD_ERR +} GDBThreadIdKind; + +typedef union GdbCmdVariant { + const char *data; + uint8_t opcode; + unsigned long val_ul; + unsigned long long val_ull; + struct { + GDBThreadIdKind kind; + uint32_t pid; + uint32_t tid; + } thread_id; +} GdbCmdVariant; + +#define gdb_get_cmd_param(p, i) (&g_array_index(p, GdbCmdVariant, i)) + +/** + * typedef GdbCmdParseEntry - gdb command parser + * + * This structure keeps the information necessary to match a gdb command, + * parse it (extract its parameters), and select the correct handler for i= t. + * + * @cmd: The command to be matched + * @cmd_startswith: If true, @cmd is compared using startswith + * @schema: Each schema for the command parameter entry consists of 2 char= s, + * the first char represents the parameter type handling the second char + * represents the delimiter for the next parameter. + * + * Currently supported schema types: + * 'l' -> unsigned long (stored in .val_ul) + * 'L' -> unsigned long long (stored in .val_ull) + * 's' -> string (stored in .data) + * 'o' -> single char (stored in .opcode) + * 't' -> thread id (stored in .thread_id) + * '?' -> skip according to delimiter + * + * Currently supported delimiters: + * '?' -> Stop at any delimiter (",;:=3D\0") + * '0' -> Stop at "\0" + * '.' -> Skip 1 char unless reached "\0" + * Any other value is treated as the delimiter value itself + * + * @allow_stop_reply: True iff the gdbstub can respond to this command wit= h a + * "stop reply" packet. The list of commands that accept such response is + * defined at the GDB Remote Serial Protocol documentation. See: + * https://sourceware.org/gdb/onlinedocs/gdb/Stop-Reply-Packets.html#Stop-= Reply-Packets. + */ +typedef struct GdbCmdParseEntry { + GdbCmdHandler handler; + const char *cmd; + bool cmd_startswith; + const char *schema; + bool allow_stop_reply; +} GdbCmdParseEntry; + +/** + * gdb_put_packet() - put string into gdb server's buffer so it is sent + * to the client + */ +int gdb_put_packet(const char *buf); + +#endif /* GDBSTUB_COMMANDS_H */ diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 37314b92e5..9ff2f4177d 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -30,6 +30,7 @@ #include "qemu/error-report.h" #include "trace.h" #include "exec/gdbstub.h" +#include "gdbstub/commands.h" #include "gdbstub/syscalls.h" #ifdef CONFIG_USER_ONLY #include "accel/tcg/vcpu-state.h" @@ -920,43 +921,6 @@ static int cmd_parse_params(const char *data, const ch= ar *schema, return 0; } =20 -typedef void (*GdbCmdHandler)(GArray *params, void *user_ctx); - -/* - * cmd_startswith -> cmd is compared using startswith - * - * allow_stop_reply -> true iff the gdbstub can respond to this command wi= th a - * "stop reply" packet. The list of commands that accept such response is - * defined at the GDB Remote Serial Protocol documentation. see: - * https://sourceware.org/gdb/onlinedocs/gdb/Stop-Reply-Packets.html#Sto= p-Reply-Packets. - * - * schema definitions: - * Each schema parameter entry consists of 2 chars, - * the first char represents the parameter type handling - * the second char represents the delimiter for the next parameter - * - * Currently supported schema types: - * 'l' -> unsigned long (stored in .val_ul) - * 'L' -> unsigned long long (stored in .val_ull) - * 's' -> string (stored in .data) - * 'o' -> single char (stored in .opcode) - * 't' -> thread id (stored in .thread_id) - * '?' -> skip according to delimiter - * - * Currently supported delimiters: - * '?' -> Stop at any delimiter (",;:=3D\0") - * '0' -> Stop at "\0" - * '.' -> Skip 1 char unless reached "\0" - * Any other value is treated as the delimiter value itself - */ -typedef struct GdbCmdParseEntry { - GdbCmdHandler handler; - const char *cmd; - bool cmd_startswith; - const char *schema; - bool allow_stop_reply; -} GdbCmdParseEntry; - static inline int startswith(const char *string, const char *pattern) { return !strncmp(string, pattern, strlen(pattern)); @@ -1023,7 +987,7 @@ static void handle_detach(GArray *params, void *user_c= tx) return; } =20 - pid =3D get_param(params, 0)->val_ul; + pid =3D gdb_get_cmd_param(params, 0)->val_ul; } =20 #ifdef CONFIG_USER_ONLY @@ -1061,13 +1025,13 @@ static void handle_thread_alive(GArray *params, voi= d *user_ctx) return; } =20 - if (get_param(params, 0)->thread_id.kind =3D=3D GDB_READ_THREAD_ERR) { + if (gdb_get_cmd_param(params, 0)->thread_id.kind =3D=3D GDB_READ_THREA= D_ERR) { gdb_put_packet("E22"); return; } =20 - cpu =3D gdb_get_cpu(get_param(params, 0)->thread_id.pid, - get_param(params, 0)->thread_id.tid); + cpu =3D gdb_get_cpu(gdb_get_cmd_param(params, 0)->thread_id.pid, + gdb_get_cmd_param(params, 0)->thread_id.tid); if (!cpu) { gdb_put_packet("E22"); return; @@ -1079,7 +1043,7 @@ static void handle_thread_alive(GArray *params, void = *user_ctx) static void handle_continue(GArray *params, void *user_ctx) { if (params->len) { - gdb_set_cpu_pc(get_param(params, 0)->val_ull); + gdb_set_cpu_pc(gdb_get_cmd_param(params, 0)->val_ull); } =20 gdbserver_state.signal =3D 0; @@ -1095,7 +1059,7 @@ static void handle_cont_with_sig(GArray *params, void= *user_ctx) * omit the addr parameter */ if (params->len) { - signal =3D get_param(params, 0)->val_ul; + signal =3D gdb_get_cmd_param(params, 0)->val_ul; } =20 gdbserver_state.signal =3D gdb_signal_to_target(signal); @@ -1115,18 +1079,18 @@ static void handle_set_thread(GArray *params, void = *user_ctx) return; } =20 - if (get_param(params, 1)->thread_id.kind =3D=3D GDB_READ_THREAD_ERR) { + if (gdb_get_cmd_param(params, 1)->thread_id.kind =3D=3D GDB_READ_THREA= D_ERR) { gdb_put_packet("E22"); return; } =20 - if (get_param(params, 1)->thread_id.kind !=3D GDB_ONE_THREAD) { + if (gdb_get_cmd_param(params, 1)->thread_id.kind !=3D GDB_ONE_THREAD) { gdb_put_packet("OK"); return; } =20 - pid =3D get_param(params, 1)->thread_id.pid; - tid =3D get_param(params, 1)->thread_id.tid; + pid =3D gdb_get_cmd_param(params, 1)->thread_id.pid; + tid =3D gdb_get_cmd_param(params, 1)->thread_id.tid; #ifdef CONFIG_USER_ONLY if (gdb_handle_set_thread_user(pid, tid)) { return; @@ -1142,7 +1106,7 @@ static void handle_set_thread(GArray *params, void *u= ser_ctx) * Note: This command is deprecated and modern gdb's will be using the * vCont command instead. */ - switch (get_param(params, 0)->opcode) { + switch (gdb_get_cmd_param(params, 0)->opcode) { case 'c': gdbserver_state.c_cpu =3D cpu; gdb_put_packet("OK"); @@ -1167,9 +1131,9 @@ static void handle_insert_bp(GArray *params, void *us= er_ctx) } =20 res =3D gdb_breakpoint_insert(gdbserver_state.c_cpu, - get_param(params, 0)->val_ul, - get_param(params, 1)->val_ull, - get_param(params, 2)->val_ull); + gdb_get_cmd_param(params, 0)->val_ul, + gdb_get_cmd_param(params, 1)->val_ull, + gdb_get_cmd_param(params, 2)->val_ull); if (res >=3D 0) { gdb_put_packet("OK"); return; @@ -1191,9 +1155,9 @@ static void handle_remove_bp(GArray *params, void *us= er_ctx) } =20 res =3D gdb_breakpoint_remove(gdbserver_state.c_cpu, - get_param(params, 0)->val_ul, - get_param(params, 1)->val_ull, - get_param(params, 2)->val_ull); + gdb_get_cmd_param(params, 0)->val_ul, + gdb_get_cmd_param(params, 1)->val_ull, + gdb_get_cmd_param(params, 2)->val_ull); if (res >=3D 0) { gdb_put_packet("OK"); return; @@ -1225,10 +1189,10 @@ static void handle_set_reg(GArray *params, void *us= er_ctx) return; } =20 - reg_size =3D strlen(get_param(params, 1)->data) / 2; - gdb_hextomem(gdbserver_state.mem_buf, get_param(params, 1)->data, reg_= size); + reg_size =3D strlen(gdb_get_cmd_param(params, 1)->data) / 2; + gdb_hextomem(gdbserver_state.mem_buf, gdb_get_cmd_param(params, 1)->da= ta, reg_size); gdb_write_register(gdbserver_state.g_cpu, gdbserver_state.mem_buf->dat= a, - get_param(params, 0)->val_ull); + gdb_get_cmd_param(params, 0)->val_ull); gdb_put_packet("OK"); } =20 @@ -1243,7 +1207,7 @@ static void handle_get_reg(GArray *params, void *user= _ctx) =20 reg_size =3D gdb_read_register(gdbserver_state.g_cpu, gdbserver_state.mem_buf, - get_param(params, 0)->val_ull); + gdb_get_cmd_param(params, 0)->val_ull); if (!reg_size) { gdb_put_packet("E14"); return; @@ -1264,16 +1228,16 @@ static void handle_write_mem(GArray *params, void *= user_ctx) } =20 /* gdb_hextomem() reads 2*len bytes */ - if (get_param(params, 1)->val_ull > - strlen(get_param(params, 2)->data) / 2) { + if (gdb_get_cmd_param(params, 1)->val_ull > + strlen(gdb_get_cmd_param(params, 2)->data) / 2) { gdb_put_packet("E22"); return; } =20 - gdb_hextomem(gdbserver_state.mem_buf, get_param(params, 2)->data, - get_param(params, 1)->val_ull); + gdb_hextomem(gdbserver_state.mem_buf, gdb_get_cmd_param(params, 2)->da= ta, + gdb_get_cmd_param(params, 1)->val_ull); if (gdb_target_memory_rw_debug(gdbserver_state.g_cpu, - get_param(params, 0)->val_ull, + gdb_get_cmd_param(params, 0)->val_ull, gdbserver_state.mem_buf->data, gdbserver_state.mem_buf->len, true)) { gdb_put_packet("E14"); @@ -1291,16 +1255,16 @@ static void handle_read_mem(GArray *params, void *u= ser_ctx) } =20 /* gdb_memtohex() doubles the required space */ - if (get_param(params, 1)->val_ull > MAX_PACKET_LENGTH / 2) { + if (gdb_get_cmd_param(params, 1)->val_ull > MAX_PACKET_LENGTH / 2) { gdb_put_packet("E22"); return; } =20 g_byte_array_set_size(gdbserver_state.mem_buf, - get_param(params, 1)->val_ull); + gdb_get_cmd_param(params, 1)->val_ull); =20 if (gdb_target_memory_rw_debug(gdbserver_state.g_cpu, - get_param(params, 0)->val_ull, + gdb_get_cmd_param(params, 0)->val_ull, gdbserver_state.mem_buf->data, gdbserver_state.mem_buf->len, false)) { gdb_put_packet("E14"); @@ -1324,8 +1288,8 @@ static void handle_write_all_regs(GArray *params, voi= d *user_ctx) } =20 cpu_synchronize_state(gdbserver_state.g_cpu); - len =3D strlen(get_param(params, 0)->data) / 2; - gdb_hextomem(gdbserver_state.mem_buf, get_param(params, 0)->data, len); + len =3D strlen(gdb_get_cmd_param(params, 0)->data) / 2; + gdb_hextomem(gdbserver_state.mem_buf, gdb_get_cmd_param(params, 0)->da= ta, len); registers =3D gdbserver_state.mem_buf->data; for (reg_id =3D 0; reg_id < gdbserver_state.g_cpu->gdb_num_g_regs && len > 0; @@ -1360,7 +1324,7 @@ static void handle_read_all_regs(GArray *params, void= *user_ctx) static void handle_step(GArray *params, void *user_ctx) { if (params->len) { - gdb_set_cpu_pc(get_param(params, 0)->val_ull); + gdb_set_cpu_pc(gdb_get_cmd_param(params, 0)->val_ull); } =20 cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags); @@ -1373,7 +1337,7 @@ static void handle_backward(GArray *params, void *use= r_ctx) gdb_put_packet("E22"); } if (params->len =3D=3D 1) { - switch (get_param(params, 0)->opcode) { + switch (gdb_get_cmd_param(params, 0)->opcode) { case 's': if (replay_reverse_step()) { gdb_continue(); @@ -1408,7 +1372,7 @@ static void handle_v_cont(GArray *params, void *user_= ctx) return; } =20 - res =3D gdb_handle_vcont(get_param(params, 0)->data); + res =3D gdb_handle_vcont(gdb_get_cmd_param(params, 0)->data); if ((res =3D=3D -EINVAL) || (res =3D=3D -ERANGE)) { gdb_put_packet("E22"); } else if (res) { @@ -1426,7 +1390,7 @@ static void handle_v_attach(GArray *params, void *use= r_ctx) goto cleanup; } =20 - process =3D gdb_get_process(get_param(params, 0)->val_ul); + process =3D gdb_get_process(gdb_get_cmd_param(params, 0)->val_ul); if (!process) { goto cleanup; } @@ -1523,7 +1487,7 @@ static void handle_v_commands(GArray *params, void *u= ser_ctx) return; } =20 - if (!process_string_cmd(get_param(params, 0)->data, + if (!process_string_cmd(gdb_get_cmd_param(params, 0)->data, gdb_v_commands_table, ARRAY_SIZE(gdb_v_commands_table))) { gdb_put_packet(""); @@ -1555,7 +1519,7 @@ static void handle_set_qemu_sstep(GArray *params, voi= d *user_ctx) return; } =20 - new_sstep_flags =3D get_param(params, 0)->val_ul; + new_sstep_flags =3D gdb_get_cmd_param(params, 0)->val_ul; =20 if (new_sstep_flags & ~gdbserver_state.supported_sstep_flags) { gdb_put_packet("E22"); @@ -1615,13 +1579,13 @@ static void handle_query_thread_extra(GArray *param= s, void *user_ctx) CPUState *cpu; =20 if (!params->len || - get_param(params, 0)->thread_id.kind =3D=3D GDB_READ_THREAD_ERR) { + gdb_get_cmd_param(params, 0)->thread_id.kind =3D=3D GDB_READ_THREA= D_ERR) { gdb_put_packet("E22"); return; } =20 - cpu =3D gdb_get_cpu(get_param(params, 0)->thread_id.pid, - get_param(params, 0)->thread_id.tid); + cpu =3D gdb_get_cpu(gdb_get_cmd_param(params, 0)->thread_id.pid, + gdb_get_cmd_param(params, 0)->thread_id.tid); if (!cpu) { return; } @@ -1673,7 +1637,7 @@ static void handle_query_supported(GArray *params, vo= id *user_ctx) #endif =20 if (params->len) { - const char *gdb_supported =3D get_param(params, 0)->data; + const char *gdb_supported =3D gdb_get_cmd_param(params, 0)->data; =20 if (strstr(gdb_supported, "multiprocess+")) { gdbserver_state.multiprocess =3D true; @@ -1707,15 +1671,15 @@ static void handle_query_xfer_features(GArray *para= ms, void *user_ctx) return; } =20 - p =3D get_param(params, 0)->data; + p =3D gdb_get_cmd_param(params, 0)->data; xml =3D get_feature_xml(p, &p, process); if (!xml) { gdb_put_packet("E00"); return; } =20 - addr =3D get_param(params, 1)->val_ul; - len =3D get_param(params, 2)->val_ul; + addr =3D gdb_get_cmd_param(params, 1)->val_ul; + len =3D gdb_get_cmd_param(params, 2)->val_ul; total_len =3D strlen(xml); if (addr > total_len) { gdb_put_packet("E00"); @@ -1889,13 +1853,13 @@ static void handle_gen_query(GArray *params, void *= user_ctx) return; } =20 - if (process_string_cmd(get_param(params, 0)->data, + if (process_string_cmd(gdb_get_cmd_param(params, 0)->data, gdb_gen_query_set_common_table, ARRAY_SIZE(gdb_gen_query_set_common_table))) { return; } =20 - if (!process_string_cmd(get_param(params, 0)->data, + if (!process_string_cmd(gdb_get_cmd_param(params, 0)->data, gdb_gen_query_table, ARRAY_SIZE(gdb_gen_query_table))) { gdb_put_packet(""); @@ -1908,13 +1872,13 @@ static void handle_gen_set(GArray *params, void *us= er_ctx) return; } =20 - if (process_string_cmd(get_param(params, 0)->data, + if (process_string_cmd(gdb_get_cmd_param(params, 0)->data, gdb_gen_query_set_common_table, ARRAY_SIZE(gdb_gen_query_set_common_table))) { return; } =20 - if (!process_string_cmd(get_param(params, 0)->data, + if (!process_string_cmd(gdb_get_cmd_param(params, 0)->data, gdb_gen_set_table, ARRAY_SIZE(gdb_gen_set_table))) { gdb_put_packet(""); diff --git a/gdbstub/syscalls.c b/gdbstub/syscalls.c index 02e3a8f74c..4e1295b782 100644 --- a/gdbstub/syscalls.c +++ b/gdbstub/syscalls.c @@ -16,6 +16,7 @@ #include "sysemu/runstate.h" #include "gdbstub/user.h" #include "gdbstub/syscalls.h" +#include "gdbstub/commands.h" #include "trace.h" #include "internals.h" =20 @@ -154,9 +155,9 @@ void gdb_handle_file_io(GArray *params, void *user_ctx) uint64_t ret; int err; =20 - ret =3D get_param(params, 0)->val_ull; + ret =3D gdb_get_cmd_param(params, 0)->val_ull; if (params->len >=3D 2) { - err =3D get_param(params, 1)->val_ull; + err =3D gdb_get_cmd_param(params, 1)->val_ull; } else { err =3D 0; } @@ -196,7 +197,7 @@ void gdb_handle_file_io(GArray *params, void *user_ctx) gdbserver_syscall_state.current_syscall_cb =3D NULL; } =20 - if (params->len >=3D 3 && get_param(params, 2)->opcode =3D=3D (uint8_t= )'C') { + if (params->len >=3D 3 && gdb_get_cmd_param(params, 2)->opcode =3D=3D = (uint8_t)'C') { gdb_put_packet("T02"); return; } diff --git a/gdbstub/system.c b/gdbstub/system.c index d235403855..1ad87fe7fd 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -16,6 +16,7 @@ #include "qemu/cutils.h" #include "exec/gdbstub.h" #include "gdbstub/syscalls.h" +#include "gdbstub/commands.h" #include "exec/hwaddr.h" #include "exec/tb-flush.h" #include "sysemu/cpus.h" @@ -501,7 +502,7 @@ void gdb_handle_set_qemu_phy_mem_mode(GArray *params, v= oid *ctx) return; } =20 - if (!get_param(params, 0)->val_ul) { + if (!gdb_get_cmd_param(params, 0)->val_ul) { phy_memory_mode =3D 0; } else { phy_memory_mode =3D 1; @@ -519,7 +520,7 @@ void gdb_handle_query_rcmd(GArray *params, void *ctx) return; } =20 - len =3D strlen(get_param(params, 0)->data); + len =3D strlen(gdb_get_cmd_param(params, 0)->data); if (len % 2) { gdb_put_packet("E01"); return; @@ -527,7 +528,7 @@ void gdb_handle_query_rcmd(GArray *params, void *ctx) =20 g_assert(gdbserver_state.mem_buf->len =3D=3D 0); len =3D len / 2; - gdb_hextomem(gdbserver_state.mem_buf, get_param(params, 0)->data, len); + gdb_hextomem(gdbserver_state.mem_buf, gdb_get_cmd_param(params, 0)->da= ta, len); g_byte_array_append(gdbserver_state.mem_buf, &zero, 1); qemu_chr_be_write(gdbserver_system_state.mon_chr, gdbserver_state.mem_buf->data, diff --git a/gdbstub/user-target.c b/gdbstub/user-target.c index a9c6c64512..b5e01fd8b0 100644 --- a/gdbstub/user-target.c +++ b/gdbstub/user-target.c @@ -9,6 +9,7 @@ =20 #include "qemu/osdep.h" #include "exec/gdbstub.h" +#include "gdbstub/commands.h" #include "qemu.h" #include "internals.h" #ifdef CONFIG_LINUX @@ -250,8 +251,8 @@ void gdb_handle_query_xfer_auxv(GArray *params, void *u= ser_ctx) return; } =20 - offset =3D get_param(params, 0)->val_ul; - len =3D get_param(params, 1)->val_ul; + offset =3D gdb_get_cmd_param(params, 0)->val_ul; + len =3D gdb_get_cmd_param(params, 1)->val_ul; ts =3D get_task_state(gdbserver_state.c_cpu); saved_auxv =3D ts->info->saved_auxv; auxv_len =3D ts->info->auxv_len; @@ -288,7 +289,7 @@ void gdb_handle_query_xfer_auxv(GArray *params, void *u= ser_ctx) =20 static const char *get_filename_param(GArray *params, int i) { - const char *hex_filename =3D get_param(params, i)->data; + const char *hex_filename =3D gdb_get_cmd_param(params, i)->data; gdb_hextomem(gdbserver_state.mem_buf, hex_filename, strlen(hex_filename) / 2); g_byte_array_append(gdbserver_state.mem_buf, (const guint8 *)"", 1); @@ -306,8 +307,8 @@ static void hostio_reply_with_data(const void *buf, siz= e_t n) void gdb_handle_v_file_open(GArray *params, void *user_ctx) { const char *filename =3D get_filename_param(params, 0); - uint64_t flags =3D get_param(params, 1)->val_ull; - uint64_t mode =3D get_param(params, 2)->val_ull; + uint64_t flags =3D gdb_get_cmd_param(params, 1)->val_ull; + uint64_t mode =3D gdb_get_cmd_param(params, 2)->val_ull; =20 #ifdef CONFIG_LINUX int fd =3D do_guest_openat(cpu_env(gdbserver_state.g_cpu), 0, filename, @@ -325,7 +326,7 @@ void gdb_handle_v_file_open(GArray *params, void *user_= ctx) =20 void gdb_handle_v_file_close(GArray *params, void *user_ctx) { - int fd =3D get_param(params, 0)->val_ul; + int fd =3D gdb_get_cmd_param(params, 0)->val_ul; =20 if (close(fd) =3D=3D -1) { g_string_printf(gdbserver_state.str_buf, "F-1,%d", errno); @@ -338,9 +339,9 @@ void gdb_handle_v_file_close(GArray *params, void *user= _ctx) =20 void gdb_handle_v_file_pread(GArray *params, void *user_ctx) { - int fd =3D get_param(params, 0)->val_ul; - size_t count =3D get_param(params, 1)->val_ull; - off_t offset =3D get_param(params, 2)->val_ull; + int fd =3D gdb_get_cmd_param(params, 0)->val_ul; + size_t count =3D gdb_get_cmd_param(params, 1)->val_ull; + off_t offset =3D gdb_get_cmd_param(params, 2)->val_ull; =20 size_t bufsiz =3D MIN(count, BUFSIZ); g_autofree char *buf =3D g_try_malloc(bufsiz); @@ -383,9 +384,9 @@ void gdb_handle_v_file_readlink(GArray *params, void *u= ser_ctx) =20 void gdb_handle_query_xfer_exec_file(GArray *params, void *user_ctx) { - uint32_t pid =3D get_param(params, 0)->val_ul; - uint32_t offset =3D get_param(params, 1)->val_ul; - uint32_t length =3D get_param(params, 2)->val_ul; + uint32_t pid =3D gdb_get_cmd_param(params, 0)->val_ul; + uint32_t offset =3D gdb_get_cmd_param(params, 1)->val_ul; + uint32_t length =3D gdb_get_cmd_param(params, 2)->val_ul; =20 GDBProcess *process =3D gdb_get_process(pid); if (!process) { diff --git a/gdbstub/user.c b/gdbstub/user.c index e34b58b407..b36033bc7a 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -16,6 +16,7 @@ #include "exec/hwaddr.h" #include "exec/tb-flush.h" #include "exec/gdbstub.h" +#include "gdbstub/commands.h" #include "gdbstub/syscalls.h" #include "gdbstub/user.h" #include "gdbstub/enums.h" @@ -793,7 +794,7 @@ void gdb_syscall_return(CPUState *cs, int num) =20 void gdb_handle_set_catch_syscalls(GArray *params, void *user_ctx) { - const char *param =3D get_param(params, 0)->data; + const char *param =3D gdb_get_cmd_param(params, 0)->data; GDBSyscallsMask catch_syscalls_mask; bool catch_all_syscalls; unsigned int num; @@ -858,8 +859,8 @@ void gdb_handle_query_xfer_siginfo(GArray *params, void= *user_ctx) unsigned long offset, len; uint8_t *siginfo_offset; =20 - offset =3D get_param(params, 0)->val_ul; - len =3D get_param(params, 1)->val_ul; + offset =3D gdb_get_cmd_param(params, 0)->val_ul; + len =3D gdb_get_cmd_param(params, 1)->val_ul; =20 if (offset + len > gdbserver_user_state.siginfo_len) { /* Invalid offset and/or requested length. */ --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169357; cv=none; d=zohomail.com; s=zohoarc; b=nXFpaKjUPr4drMwRh22PUFsVbugmFXG/4ko9VlEKUR2jB/dEwf2RIaBvvSMj8pwYoGA9rAreNGoPjuby8pgMTyq+jBWGPvdlzsKwZAS4lgzimMJxQwsF9Pb+TtRHpJWaSXIBy0711zZZKCYjahmR6QtKHJEAspW9igltcjNP7SQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169357; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nwVSmZAL2EMRgtufrZz5eEfwgUoJxg5fsgWWCXA8eHs=; b=DFBKQ4vvz6J3OZc9FujIrj5bV95dEGUD66qApE1EZalLSAvWTWNopi76As37We+Jp46UsQC5fV3u14VJpwgU+sgk7fYRYrGCeyw40KubYOO26eEvQ2oxNwHlQccnvZUYpFxbi2AoZrVJW4BHBzoI4ODEUdQtSnorSiqh4uBJwVM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169357658290.8037921616218; Fri, 5 Jul 2024 01:49:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPebk-0001GP-Ou; Fri, 05 Jul 2024 04:47:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebM-0000wo-Pu for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:33 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeb9-0004Bq-0f for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:32 -0400 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a7527afa23cso166209666b.2 for ; Fri, 05 Jul 2024 01:47:18 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab0652d8sm667329766b.98.2024.07.05.01.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:16 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id CEFF46216F; Fri, 5 Jul 2024 09:40:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169237; x=1720774037; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nwVSmZAL2EMRgtufrZz5eEfwgUoJxg5fsgWWCXA8eHs=; b=DzTgHPdI6MBQ00F3bRh+gkd8b3RzOzD+hz63FZfJB1h7SkU7I1OkmPfxcybXvEke2M 0+Bmu0TdbAzK/UZs6INdIbT9M1p2w9f0LGZuSqZv6g4Z4eemJ09UMWndzegJhDQHC0X/ U2tg/2gMXNj872lxwtYd9Jsr6F9GxC1/9xQX8FIVpXJA6gP4C8ADqspfcbKtRdOvwfYP PuYmwtSrTL4iZNo+YXl2LrYMe1xxKXCaPAwNcW1CWq2Zb6ji1RDUDfZhZvghp6re8beW riwsd6QSYAidHv5APhdMQspIXpEBgcvcTAMRJYGclep3eE1gHqqlIWrF5tHduCX4qpxC q5eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169237; x=1720774037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nwVSmZAL2EMRgtufrZz5eEfwgUoJxg5fsgWWCXA8eHs=; b=pJM6QKJNmPGcSga/Z+OCMsbaqvnW67jW6fONb2gTDbp3MJvmdywDBeToYcTO8xpnk0 XQVvzJx+GDFR7duOIygi5yCn1lO75SncZucI/QBj77ItWnJBBiRJtMeqd7MXxIKmK6KG IaokOXNxc+mMYtNSf9dmOVzrKvUt5TQl+IqTDssa5ypCi16LkNVddp1FhT21WudSCE6n SXUh1fH1MhEPBstRbPMcArQp1xoLeW78zUcuNcJdntOH/aRwG7DiAwv0hy6t7eEtMpHW EyYbiQi26Ojv4y2ZQ1QfiO2OgK2kVdZHuaFYO7Vs7MCIkMg7Uf26/cmiRQX39netDleg b2mw== X-Gm-Message-State: AOJu0YyqlD5nltQ1NOMN5imwZ/6Zjj34Ke+2PxbfbmICqzWk6rIi92vM LWYbNATtXbeceBxtZ24zXA0C8IeKPUS9mTsPJjGawCHtgY6l3WYtoZJxCuX7yQ8= X-Google-Smtp-Source: AGHT+IHnFspcX3sxf/9SpxDwcek/1hdl+zUDJyj7IBnF/kFH6mSHEOYBoLRXmKD4vdXbc4r4WRkYdw== X-Received: by 2002:a17:906:88f:b0:a6f:b0d0:1beb with SMTP id a640c23a62f3a-a77ba46e0bamr307099466b.24.1720169237237; Fri, 05 Jul 2024 01:47:17 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 32/40] gdbstub: Add support for target-specific stubs Date: Fri, 5 Jul 2024 09:40:39 +0100 Message-Id: <20240705084047.857176-33-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169358337100001 From: Gustavo Romero Currently, it's not possible to have stubs specific to a given target, even though there are GDB features which are target-specific, like, for instance, memory tagging. This commit introduces gdb_extend_qsupported_features, gdb_extend_query_table, and gdb_extend_set_table functions as interfaces to extend the qSupported string, the query handler table, and the set handler table, allowing target-specific stub implementations. Signed-off-by: Gustavo Romero Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240628050850.536447-4-gustavo.romero@linaro.org> --- include/gdbstub/commands.h | 22 ++++++++ gdbstub/gdbstub.c | 102 ++++++++++++++++++++++++++++++++++--- 2 files changed, 118 insertions(+), 6 deletions(-) diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h index 639257493e..306dfdef97 100644 --- a/include/gdbstub/commands.h +++ b/include/gdbstub/commands.h @@ -69,4 +69,26 @@ typedef struct GdbCmdParseEntry { */ int gdb_put_packet(const char *buf); =20 +/** + * gdb_extend_query_table() - Extend query table. + * @table: The table with the additional query packet handlers. + * @size: The number of handlers to be added. + */ +void gdb_extend_query_table(GdbCmdParseEntry *table, int size); + +/** + * gdb_extend_set_table() - Extend set table. + * @table: The table with the additional set packet handlers. + * @size: The number of handlers to be added. + */ +void gdb_extend_set_table(GdbCmdParseEntry *table, int size); + +/** + * gdb_extend_qsupported_features() - Extend the qSupported features strin= g. + * @qsupported_features: The additional qSupported feature(s) string. The = string + * should start with a semicolon and, if there are more than one feature, = the + * features should be separate by a semiocolon. + */ +void gdb_extend_qsupported_features(char *qsupported_features); + #endif /* GDBSTUB_COMMANDS_H */ diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 9ff2f4177d..b1ca253f97 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1609,6 +1609,20 @@ static void handle_query_thread_extra(GArray *params= , void *user_ctx) gdb_put_strbuf(); } =20 +static char *extended_qsupported_features; +void gdb_extend_qsupported_features(char *qsupported_features) +{ + /* + * We don't support different sets of CPU gdb features on different CP= Us yet + * so assert the feature strings are the same on all CPUs, or is set o= nly + * once (1 CPU). + */ + g_assert(extended_qsupported_features =3D=3D NULL || + g_strcmp0(extended_qsupported_features, qsupported_features) = =3D=3D 0); + + extended_qsupported_features =3D qsupported_features; +} + static void handle_query_supported(GArray *params, void *user_ctx) { CPUClass *cc; @@ -1648,6 +1662,11 @@ static void handle_query_supported(GArray *params, v= oid *user_ctx) } =20 g_string_append(gdbserver_state.str_buf, ";vContSupported+;multiproces= s+"); + + if (extended_qsupported_features) { + g_string_append(gdbserver_state.str_buf, extended_qsupported_featu= res); + } + gdb_put_strbuf(); } =20 @@ -1729,6 +1748,41 @@ static const GdbCmdParseEntry gdb_gen_query_set_comm= on_table[] =3D { }, }; =20 +/* Compares if a set of command parsers is equal to another set of parsers= . */ +static bool cmp_cmds(GdbCmdParseEntry *c, GdbCmdParseEntry *d, int size) +{ + for (int i =3D 0; i < size; i++) { + if (!(c[i].handler =3D=3D d[i].handler && + g_strcmp0(c[i].cmd, d[i].cmd) =3D=3D 0 && + c[i].cmd_startswith =3D=3D d[i].cmd_startswith && + g_strcmp0(c[i].schema, d[i].schema) =3D=3D 0)) { + + /* Sets are different. */ + return false; + } + } + + /* Sets are equal, i.e. contain the same command parsers. */ + return true; +} + +static GdbCmdParseEntry *extended_query_table; +static int extended_query_table_size; +void gdb_extend_query_table(GdbCmdParseEntry *table, int size) +{ + /* + * We don't support different sets of CPU gdb features on different CP= Us yet + * so assert query table is the same on all CPUs, or is set only once + * (1 CPU). + */ + g_assert(extended_query_table =3D=3D NULL || + (extended_query_table_size =3D=3D size && + cmp_cmds(extended_query_table, table, size))); + + extended_query_table =3D table; + extended_query_table_size =3D size; +} + static const GdbCmdParseEntry gdb_gen_query_table[] =3D { { .handler =3D handle_query_curr_tid, @@ -1821,6 +1875,22 @@ static const GdbCmdParseEntry gdb_gen_query_table[] = =3D { #endif }; =20 +static GdbCmdParseEntry *extended_set_table; +static int extended_set_table_size; +void gdb_extend_set_table(GdbCmdParseEntry *table, int size) +{ + /* + * We don't support different sets of CPU gdb features on different CP= Us yet + * so assert set table is the same on all CPUs, or is set only once (1= CPU). + */ + g_assert(extended_set_table =3D=3D NULL || + (extended_set_table_size =3D=3D size && + cmp_cmds(extended_set_table, table, size))); + + extended_set_table =3D table; + extended_set_table_size =3D size; +} + static const GdbCmdParseEntry gdb_gen_set_table[] =3D { /* Order is important if has same prefix */ { @@ -1859,11 +1929,21 @@ static void handle_gen_query(GArray *params, void *= user_ctx) return; } =20 - if (!process_string_cmd(gdb_get_cmd_param(params, 0)->data, - gdb_gen_query_table, - ARRAY_SIZE(gdb_gen_query_table))) { - gdb_put_packet(""); + if (process_string_cmd(gdb_get_cmd_param(params, 0)->data, + gdb_gen_query_table, + ARRAY_SIZE(gdb_gen_query_table))) { + return; + } + + if (extended_query_table && + process_string_cmd(gdb_get_cmd_param(params, 0)->data, + extended_query_table, + extended_query_table_size)) { + return; } + + /* Can't handle query, return Empty response. */ + gdb_put_packet(""); } =20 static void handle_gen_set(GArray *params, void *user_ctx) @@ -1878,11 +1958,21 @@ static void handle_gen_set(GArray *params, void *us= er_ctx) return; } =20 - if (!process_string_cmd(gdb_get_cmd_param(params, 0)->data, + if (process_string_cmd(gdb_get_cmd_param(params, 0)->data, gdb_gen_set_table, ARRAY_SIZE(gdb_gen_set_table))) { - gdb_put_packet(""); + return; } + + if (extended_set_table && + process_string_cmd(gdb_get_cmd_param(params, 0)->data, + extended_set_table, + extended_set_table_size)) { + return; + } + + /* Can't handle set, return Empty response. */ + gdb_put_packet(""); } =20 static void handle_target_halt(GArray *params, void *user_ctx) --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169928; cv=none; d=zohomail.com; s=zohoarc; b=R5rh2VAik4Q2f7GRv0cTPX+5bJAX74ix4eKHDkbiHSM1mLCSgUUp9OFJ5l+3Fuj6QhbreSBhzxulbAqUSYaz6SkRbCS6W7PTuwQpg13/fXATYMBvHlMgxCkxu5IoaI77jIsCN00Ze+ViLFFVIXeEcfL6FJKIbu0WcdmKAwnXDwk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169928; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=k7K4IeYpitk17HZKWz2pT/RDMTcnxc4LGSaBH5+Jfr4=; b=mXrmb8S/qQqnGTXfu3QRuhH306xhooCmcvdHFAYB8mh4MTvrkLvT5MtuHc8+d+P0UBqEq7PIBdGZWDbxyK4gi7WRSfHmB+D+r5PTO2Z/DncUxBU/LmQ8xf+Vt9CYfgm/MnI+e7520L1MCrOxrROT6js+7u+Pz2GkWD6kpBxIOGA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169928523474.49135582248744; Fri, 5 Jul 2024 01:58:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPel3-0002oa-3y; Fri, 05 Jul 2024 04:57:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPekz-0002gd-Fl for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:57:30 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPekk-0001ug-Ej for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:57:29 -0400 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a72517e6225so153704766b.0 for ; Fri, 05 Jul 2024 01:57:14 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab08cea1sm662435366b.156.2024.07.05.01.57.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:57:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id E52E662170; Fri, 5 Jul 2024 09:40:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169833; x=1720774633; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k7K4IeYpitk17HZKWz2pT/RDMTcnxc4LGSaBH5+Jfr4=; b=C46NtmjitnL4t4ALGC5GJjTp5H8snTN0tRTMz5Ni5xp5uikAAwdVW71adnm2jiT5Aw 1uwtzvf+IdVahFHbnBagZ1ZntXImS60LPCQW8URdDHzvrPpBkosR/y3p/V5Ns7Ge5uZM NHAtPVlur01fPyg7jdAwPpcS2PQFE1SC4Fk7vkzcf4Ne/GCmueUJn27NKP0g+MyxlaJn KJ1Z8qi1694XxPVE5eTw70Ct5AwrC/qrfP4S7DINF2KP790MDl56gNGEblxxEcoJitpP RPZIqKHWq4LQ9ECFmMBuneoexhNtSgWJQXZtdFXe7X76nUgRjg5E9CW11qNpcZqnn0eN ffjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169833; x=1720774633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k7K4IeYpitk17HZKWz2pT/RDMTcnxc4LGSaBH5+Jfr4=; b=u1NE2QmcMZHkI1bKstjLZG/0lNHk/APzBNqYe1pxktAoAE6LDpZWxEgvMZBHNRBdFc VwrHG0tz1YXxtcczlDp2tFVRkzDkusrAu6uDjQ9uGxLD2s8E7lWjrRnimyHlbokW7mX/ HE2D0P82mQPGwqJdHh5jAx3PAPCUFSEuovEUtv+1D61K0NPGzSDcVL82uuaUMbim/Mli E8rxTtpCEeeJ3vMM7OChwinQVS97zGAmeg2c6HKzBQUsJJ5n+v5P30NaCNEJW6HFagt2 nDcrGhARHktY9hhcA4FBPb0M/+fFGIam+26uIoYXo+npblIVk/hdzih33h2SiGXj/Wbc sW0Q== X-Gm-Message-State: AOJu0YwV69lGFRuOo+gpY4mnU55CJ8BFbca1F/EmsIpJUbHk9LO4eodr blygSg12lutuSMzCir9mDc8LDpIVieu5Hk0JmQ5Wo9WNEVJfyskx4QfBZcOjc9Y= X-Google-Smtp-Source: AGHT+IHfh4gTsJT5+Azs0y4pggC7rqwjuJHmyWw3CHPh24bpITXZ4C0HH1X5sp393zxeSc/wLL4Qbw== X-Received: by 2002:a17:906:494e:b0:a77:cf09:9c70 with SMTP id a640c23a62f3a-a77cf099d0emr55373966b.43.1720169832778; Fri, 05 Jul 2024 01:57:12 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 33/40] target/arm: Fix exception case in allocation_tag_mem_probe Date: Fri, 5 Jul 2024 09:40:40 +0100 Message-Id: <20240705084047.857176-34-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169929357100009 From: Gustavo Romero If page in 'ptr_access' is inaccessible and probe is 'true' allocation_tag_mem_probe should not throw an exception, but currently it does, so fix it. Signed-off-by: Gustavo Romero Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240628050850.536447-5-gustavo.romero@linaro.org> --- target/arm/tcg/mte_helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/arm/tcg/mte_helper.c b/target/arm/tcg/mte_helper.c index 037ac6dd60..a50d576294 100644 --- a/target/arm/tcg/mte_helper.c +++ b/target/arm/tcg/mte_helper.c @@ -96,6 +96,9 @@ static uint8_t *allocation_tag_mem_probe(CPUARMState *env= , int ptr_mmu_idx, assert(!(probe && ra)); =20 if (!(flags & (ptr_access =3D=3D MMU_DATA_STORE ? PAGE_WRITE_ORG : PAG= E_READ))) { + if (probe) { + return NULL; + } cpu_loop_exit_sigsegv(env_cpu(env), ptr, ptr_access, !(flags & PAGE_VALID), ra); } --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169413; cv=none; d=zohomail.com; s=zohoarc; b=NX7VscREfTDPQuhdReG2wHazwrz0nYhZekHIA6Eto49x8U8xxZOOIjaD2oCl4OLNknX4pBDlYs+SPO8RWlxspFEZmjeMY3mESygk4tWsAN2p3AaZe6Uyja824tEYqpbgAWPr2kQH30I5KqUhg7Qnj4MXsbrq74nf1XmW5GVVlm0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169413; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hQv+Mlkm0fENnTpRztWa6cDoMD7HcYttxyaEWM0xMk0=; b=EO+0tnRf7GuZ4i5gnw38Y092TIl0csqJg9EF7haX68hMeASWRMlhRHOlGyBLfmGNRdGCDvB8Uh2Wp900VVI646ZusDlNQbb5JMrfoMSAcj1Q/NWQemxEL0rdgEP6SGEakAbiSXu/H9he1XdfWmKD9sL4ML6BxuuXKc0y/60CGG8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169413350160.04372741966336; Fri, 5 Jul 2024 01:50:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPec3-00023z-HC; Fri, 05 Jul 2024 04:48:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebI-0000vD-Qi for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:30 -0400 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeb5-0004AZ-AM for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:27 -0400 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a77c349bb81so89549866b.3 for ; Fri, 05 Jul 2024 01:47:12 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab08cfc1sm661124466b.163.2024.07.05.01.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 0831062174; Fri, 5 Jul 2024 09:40:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169231; x=1720774031; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hQv+Mlkm0fENnTpRztWa6cDoMD7HcYttxyaEWM0xMk0=; b=G2X+oM2F4JrYOPziRcA0dH3fs6hmY4YsmgYCankKw+f0WBvEXWGmstYrM+uGc4Ft5c Oc/CjzsSQO3r2l0DDIkskA9o0m00TT5cyckVqp8+l8PsfkUZZH8da9d/zh1RE32YgrHQ d8GE+FTY4nZUwFCwyCizkuAA+qcMxQb+d31PTLt52UPvfMbZuTggxVtMFy5CnXjFSTTC pqCGpjxb5+8pdKSmn1bXdIY/go0qbEZX40w9LBLzOVj/WdayVscG8CV66IXusTDQMt4e +zOmMMynWzG3F9LY+BR7KuvMdo9UaUbE9kawZDdCPJt/S+HddZpzBHknWJBJFDOns5Or zpdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169231; x=1720774031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hQv+Mlkm0fENnTpRztWa6cDoMD7HcYttxyaEWM0xMk0=; b=KNK2ZWHaUi2L4Kb2cDgR2tm79qKhMkI3GBWCvHo2RkgD7XBK72wLZG3rRRoWR9CKsJ pVJmr6QiN74IrTaSqgjxbmNjK3AyNrKpOq8RUiDaSNNDc/9zVDBPP+HtXr4qUjhKcmfn mIdgOrK5ksu1z8O6AMc1ijON6PBEd8EvVVzMt6Pm+z4x+CR2hd5EC1Y6rmAP8j4s5LLj 9SPy6ZR13QDPpLV0+NAvyX1QsEw2VDY7WEpj/j3nMwK32qxy/pBUDzPVg/t+HbXe5xFW vl6oWQM6Vt6/lHP9Apl5WDMj0leI2g+a2CtpQMrFsAqW88cW1a0F/h+bzl6RtXTncBLG 3RNA== X-Gm-Message-State: AOJu0YymBucBwFDBEakOOH9D3ljgjh0oSmBDyYKb1IG7gvwsiDavL/Ss nI9kQm1d7YGsZ66Hn+ALYOVc4QoXRlt+L+oPeSjrH5p0CG/F8vwOPj0R8v7dX0g= X-Google-Smtp-Source: AGHT+IFvD5yZrNmnbPSMFZPj5+KUonTUp7w/h/VQHX4Vm2CQ96i7C8IO4Wi8s7IOaCmyzr19iL8V0Q== X-Received: by 2002:a17:907:6e8d:b0:a77:b788:d760 with SMTP id a640c23a62f3a-a77ba72c299mr291211566b.76.1720169231163; Fri, 05 Jul 2024 01:47:11 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 34/40] target/arm: Make some MTE helpers widely available Date: Fri, 5 Jul 2024 09:40:41 +0100 Message-Id: <20240705084047.857176-35-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169414550100001 From: Gustavo Romero Make the MTE helpers allocation_tag_mem_probe, load_tag1, and store_tag1 available to other subsystems. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240628050850.536447-6-gustavo.romero@linaro.org> --- target/arm/tcg/mte_helper.h | 66 +++++++++++++++++++++++++++++++++++++ target/arm/tcg/mte_helper.c | 45 ++++--------------------- 2 files changed, 73 insertions(+), 38 deletions(-) create mode 100644 target/arm/tcg/mte_helper.h diff --git a/target/arm/tcg/mte_helper.h b/target/arm/tcg/mte_helper.h new file mode 100644 index 0000000000..1f471fb69b --- /dev/null +++ b/target/arm/tcg/mte_helper.h @@ -0,0 +1,66 @@ +/* + * ARM MemTag operation helpers. + * + * This code is licensed under the GNU GPL v2 or later. + * + * SPDX-License-Identifier: LGPL-2.1-or-later + */ + +#ifndef TARGET_ARM_MTE_H +#define TARGET_ARM_MTE_H + +#include "exec/mmu-access-type.h" + +/** + * allocation_tag_mem_probe: + * @env: the cpu environment + * @ptr_mmu_idx: the addressing regime to use for the virtual address + * @ptr: the virtual address for which to look up tag memory + * @ptr_access: the access to use for the virtual address + * @ptr_size: the number of bytes in the normal memory access + * @tag_access: the access to use for the tag memory + * @probe: true to merely probe, never taking an exception + * @ra: the return address for exception handling + * + * Our tag memory is formatted as a sequence of little-endian nibbles. + * That is, the byte at (addr >> (LOG2_TAG_GRANULE + 1)) contains two + * tags, with the tag at [3:0] for the lower addr and the tag at [7:4] + * for the higher addr. + * + * Here, resolve the physical address from the virtual address, and return + * a pointer to the corresponding tag byte. + * + * If there is no tag storage corresponding to @ptr, return NULL. + * + * If the page is inaccessible for @ptr_access, or has a watchpoint, there= are + * three options: + * (1) probe =3D true, ra =3D 0 : pure probe -- we return NULL if the page= is not + * accessible, and do not take watchpoint traps. The calling code must + * handle those cases in the right priority compared to MTE traps. + * (2) probe =3D false, ra =3D 0 : probe, no fault expected -- the caller = guarantees + * that the page is going to be accessible. We will take watchpoint tr= aps. + * (3) probe =3D false, ra !=3D 0 : non-probe -- we will take both memory = access + * traps and watchpoint traps. + * (probe =3D true, ra !=3D 0 is invalid and will assert.) + */ +uint8_t *allocation_tag_mem_probe(CPUARMState *env, int ptr_mmu_idx, + uint64_t ptr, MMUAccessType ptr_access, + int ptr_size, MMUAccessType tag_access, + bool probe, uintptr_t ra); + +/** + * load_tag1 - Load 1 tag (nibble) from byte + * @ptr: The tagged address + * @mem: The tag address (packed, 2 tags in byte) + */ +int load_tag1(uint64_t ptr, uint8_t *mem); + +/** + * store_tag1 - Store 1 tag (nibble) into byte + * @ptr: The tagged address + * @mem: The tag address (packed, 2 tags in byte) + * @tag: The tag to be stored in the nibble + */ +void store_tag1(uint64_t ptr, uint8_t *mem, int tag); + +#endif /* TARGET_ARM_MTE_H */ diff --git a/target/arm/tcg/mte_helper.c b/target/arm/tcg/mte_helper.c index a50d576294..9d2ba287ee 100644 --- a/target/arm/tcg/mte_helper.c +++ b/target/arm/tcg/mte_helper.c @@ -29,6 +29,7 @@ #include "hw/core/tcg-cpu-ops.h" #include "qapi/error.h" #include "qemu/guest-random.h" +#include "mte_helper.h" =20 =20 static int choose_nonexcluded_tag(int tag, int offset, uint16_t exclude) @@ -50,42 +51,10 @@ static int choose_nonexcluded_tag(int tag, int offset, = uint16_t exclude) return tag; } =20 -/** - * allocation_tag_mem_probe: - * @env: the cpu environment - * @ptr_mmu_idx: the addressing regime to use for the virtual address - * @ptr: the virtual address for which to look up tag memory - * @ptr_access: the access to use for the virtual address - * @ptr_size: the number of bytes in the normal memory access - * @tag_access: the access to use for the tag memory - * @probe: true to merely probe, never taking an exception - * @ra: the return address for exception handling - * - * Our tag memory is formatted as a sequence of little-endian nibbles. - * That is, the byte at (addr >> (LOG2_TAG_GRANULE + 1)) contains two - * tags, with the tag at [3:0] for the lower addr and the tag at [7:4] - * for the higher addr. - * - * Here, resolve the physical address from the virtual address, and return - * a pointer to the corresponding tag byte. - * - * If there is no tag storage corresponding to @ptr, return NULL. - * - * If the page is inaccessible for @ptr_access, or has a watchpoint, there= are - * three options: - * (1) probe =3D true, ra =3D 0 : pure probe -- we return NULL if the page= is not - * accessible, and do not take watchpoint traps. The calling code must - * handle those cases in the right priority compared to MTE traps. - * (2) probe =3D false, ra =3D 0 : probe, no fault expected -- the caller = guarantees - * that the page is going to be accessible. We will take watchpoint tr= aps. - * (3) probe =3D false, ra !=3D 0 : non-probe -- we will take both memory = access - * traps and watchpoint traps. - * (probe =3D true, ra !=3D 0 is invalid and will assert.) - */ -static uint8_t *allocation_tag_mem_probe(CPUARMState *env, int ptr_mmu_idx, - uint64_t ptr, MMUAccessType ptr_a= ccess, - int ptr_size, MMUAccessType tag_a= ccess, - bool probe, uintptr_t ra) +uint8_t *allocation_tag_mem_probe(CPUARMState *env, int ptr_mmu_idx, + uint64_t ptr, MMUAccessType ptr_access, + int ptr_size, MMUAccessType tag_access, + bool probe, uintptr_t ra) { #ifdef CONFIG_USER_ONLY uint64_t clean_ptr =3D useronly_clean_ptr(ptr); @@ -287,7 +256,7 @@ uint64_t HELPER(addsubg)(CPUARMState *env, uint64_t ptr, return address_with_allocation_tag(ptr + offset, rtag); } =20 -static int load_tag1(uint64_t ptr, uint8_t *mem) +int load_tag1(uint64_t ptr, uint8_t *mem) { int ofs =3D extract32(ptr, LOG2_TAG_GRANULE, 1) * 4; return extract32(*mem, ofs, 4); @@ -321,7 +290,7 @@ static void check_tag_aligned(CPUARMState *env, uint64_= t ptr, uintptr_t ra) } =20 /* For use in a non-parallel context, store to the given nibble. */ -static void store_tag1(uint64_t ptr, uint8_t *mem, int tag) +void store_tag1(uint64_t ptr, uint8_t *mem, int tag) { int ofs =3D extract32(ptr, LOG2_TAG_GRANULE, 1) * 4; *mem =3D deposit32(*mem, ofs, 4, tag); --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169270; cv=none; d=zohomail.com; s=zohoarc; b=NwcHrCSLvgkJA6KphVkx81OCDqWsC+HWczRMsTiROfQ51UV3WuvK524rddv2JKR1RjOHxbgzPd/ml//sN+B3cicpW5we7oZfi5vTXo7doPR1yLADiK1eQudV4/zBGjMFOBuBZKEOQQ2qJdzACYHcZiWK+WylPIc4ZABd99+V/cw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169270; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=U6hurhQTjp832TOlAx+LCodgHfvL9JAd0ZCjMoFRr6I=; b=fPM/wM7pMij8+wKOXe2lHl2ywkke+Lu76jp8mAG2VUoD0iMJjbf9MaxBywlUOhclDihrw30eNgoreMZ5sPZPRRSTW4kS3+YGYHvSmgDuxNn1gF63oLNCA0T2TPMY7PITMhIL6j2hK5RsKfOw5EvxMfL9xnEoL6PVeqVvwT3xWlk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169270121448.7862187389753; Fri, 5 Jul 2024 01:47:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPebT-00010a-8T; Fri, 05 Jul 2024 04:47:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebE-0000tP-PY for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:27 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeb2-0004AU-RS for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:24 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a7541fad560so157277566b.0 for ; Fri, 05 Jul 2024 01:47:12 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77cd9637f4sm30271366b.57.2024.07.05.01.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 2244A62176; Fri, 5 Jul 2024 09:40:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169231; x=1720774031; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U6hurhQTjp832TOlAx+LCodgHfvL9JAd0ZCjMoFRr6I=; b=tloXcRzD/TdeBgMvGcAJw7duetYDQWUVFysuCIMfYrG9Kjeku+naNCo53+rdsr/w2r 7u2rotExWPqrDmprKCDnG+sUIDvAIW37KUO8tNcTFndzYBnGm0gLeAW0MPsX5C3kv8ep yOnu5fkhvPMjc+t5C8R7LLdep/AcnU1xu9DO8td8iCSYKYXhM18QSx9JO7JQF1b5pZZt cgru0a8gGyMwUfm87Q7SgSLozGRhgnX32sSK1WKREX0u3YF5X3W/ICD0Q7iSa5RFilaB KWjEatUVAWxbvj/SRm8GTnoySSFpPF+i1lptDyZ+/17sTAZQxH1r9JRnibk6IxDbqlJK coVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169231; x=1720774031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U6hurhQTjp832TOlAx+LCodgHfvL9JAd0ZCjMoFRr6I=; b=hjOr/kfLvTJSRQWEzm6dXEEukvn02Z2bv31/UtwSYuE68hseAOz7DDojKVxZDwaSnc aWLoD79jiev+CFxxHqxas+fXOQOmMu/BOVW36IYgWKN03DXmfs1aBBKpRhMIIkwtIWlZ 4JJPcfLjJWvsauUuFoEoebZO454v5gE64uytE4UCwVqlhLDKT4sYC2N3B+U6WE238ze+ Zz+DC2ACQjYRZEKV8kRc913cm7pbwcodPqlqczzQmRzwccJGGclEyzbLBqMm+8soWahc BGsLsERkRko3FBeGoW5jDdzkCaFIwY21FeYuCEKjDfvYjK08ztScIe8Ft+kUxd1xMwIE 8qDw== X-Gm-Message-State: AOJu0YwmKu+xTB8rM5utbBxkvmiFLcWCnu+810IYQWgaZLsEV2u87eJo c9NB9fCFjsYB/aCO5aR/tPpb47n7bbG4TmnqJ/ThDCH/2rnUZv417FZYx+aWsi4= X-Google-Smtp-Source: AGHT+IEubJGY+NDAKB0/iFr5NUae5zedXOgoBWbSGzbBjmJUi4vwkha4pOXNA4h47JqROyILcck8cg== X-Received: by 2002:a17:907:97c8:b0:a77:a58f:7f6a with SMTP id a640c23a62f3a-a77ba70e417mr395665766b.38.1720169230781; Fri, 05 Jul 2024 01:47:10 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 35/40] target/arm: Factor out code for setting MTE TCF0 field Date: Fri, 5 Jul 2024 09:40:42 +0100 Message-Id: <20240705084047.857176-36-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169271935100001 From: Gustavo Romero Factor out the code used for setting the MTE TCF0 field from the prctl code into a convenient function. Other subsystems, like gdbstub, need to set this field as well, so keep it as a separate function to avoid duplication and ensure consistency in how this field is set across the board. Signed-off-by: Gustavo Romero Message-Id: <20240628050850.536447-7-gustavo.romero@linaro.org> [AJB: clean-up includes, move MTE defines] Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Manos Pitsidianakis --- vAJB: - clean-up includes, move MTE defines --- linux-user/aarch64/mte_user_helper.h | 32 +++++++++++++++++++++++++ linux-user/aarch64/target_prctl.h | 22 ++--------------- linux-user/aarch64/mte_user_helper.c | 35 ++++++++++++++++++++++++++++ linux-user/syscall.c | 9 ------- linux-user/aarch64/meson.build | 2 ++ 5 files changed, 71 insertions(+), 29 deletions(-) create mode 100644 linux-user/aarch64/mte_user_helper.h create mode 100644 linux-user/aarch64/mte_user_helper.c diff --git a/linux-user/aarch64/mte_user_helper.h b/linux-user/aarch64/mte_= user_helper.h new file mode 100644 index 0000000000..8685e5175a --- /dev/null +++ b/linux-user/aarch64/mte_user_helper.h @@ -0,0 +1,32 @@ +/* + * ARM MemTag convenience functions. + * + * This code is licensed under the GNU GPL v2 or later. + * + * SPDX-License-Identifier: LGPL-2.1-or-later + */ + +#ifndef AARCH64_MTE_USER_HELPER_H +#define AARCH64_MTE USER_HELPER_H + +#ifndef PR_MTE_TCF_SHIFT +# define PR_MTE_TCF_SHIFT 1 +# define PR_MTE_TCF_NONE (0UL << PR_MTE_TCF_SHIFT) +# define PR_MTE_TCF_SYNC (1UL << PR_MTE_TCF_SHIFT) +# define PR_MTE_TCF_ASYNC (2UL << PR_MTE_TCF_SHIFT) +# define PR_MTE_TCF_MASK (3UL << PR_MTE_TCF_SHIFT) +# define PR_MTE_TAG_SHIFT 3 +# define PR_MTE_TAG_MASK (0xffffUL << PR_MTE_TAG_SHIFT) +#endif + +/** + * arm_set_mte_tcf0 - Set TCF0 field in SCTLR_EL1 register + * @env: The CPU environment + * @value: The value to be set for the Tag Check Fault in EL0 field. + * + * Only SYNC and ASYNC modes can be selected. If ASYMM mode is given, the = SYNC + * mode is selected instead. So, there is no way to set the ASYMM mode. + */ +void arm_set_mte_tcf0(CPUArchState *env, abi_long value); + +#endif /* AARCH64_MTE_USER_HELPER_H */ diff --git a/linux-user/aarch64/target_prctl.h b/linux-user/aarch64/target_= prctl.h index aa8e203c15..ed75b9e4b5 100644 --- a/linux-user/aarch64/target_prctl.h +++ b/linux-user/aarch64/target_prctl.h @@ -7,6 +7,7 @@ #define AARCH64_TARGET_PRCTL_H =20 #include "target/arm/cpu-features.h" +#include "mte_user_helper.h" =20 static abi_long do_prctl_sve_get_vl(CPUArchState *env) { @@ -173,26 +174,7 @@ static abi_long do_prctl_set_tagged_addr_ctrl(CPUArchS= tate *env, abi_long arg2) env->tagged_addr_enable =3D arg2 & PR_TAGGED_ADDR_ENABLE; =20 if (cpu_isar_feature(aa64_mte, cpu)) { - /* - * Write PR_MTE_TCF to SCTLR_EL1[TCF0]. - * - * The kernel has a per-cpu configuration for the sysadmin, - * /sys/devices/system/cpu/cpu/mte_tcf_preferred, - * which qemu does not implement. - * - * Because there is no performance difference between the modes, a= nd - * because SYNC is most useful for debugging MTE errors, choose SY= NC - * as the preferred mode. With this preference, and the way the A= PI - * uses only two bits, there is no way for the program to select - * ASYMM mode. - */ - unsigned tcf =3D 0; - if (arg2 & PR_MTE_TCF_SYNC) { - tcf =3D 1; - } else if (arg2 & PR_MTE_TCF_ASYNC) { - tcf =3D 2; - } - env->cp15.sctlr_el[1] =3D deposit64(env->cp15.sctlr_el[1], 38, 2, = tcf); + arm_set_mte_tcf0(env, arg2); =20 /* * Write PR_MTE_TAG to GCR_EL1[Exclude]. diff --git a/linux-user/aarch64/mte_user_helper.c b/linux-user/aarch64/mte_= user_helper.c new file mode 100644 index 0000000000..a5b1c8503b --- /dev/null +++ b/linux-user/aarch64/mte_user_helper.c @@ -0,0 +1,35 @@ +/* + * ARM MemTag convenience functions. + * + * This code is licensed under the GNU GPL v2 or later. + * + * SPDX-License-Identifier: LGPL-2.1-or-later + */ + +#include "qemu/osdep.h" +#include "qemu.h" +#include "mte_user_helper.h" + +void arm_set_mte_tcf0(CPUArchState *env, abi_long value) +{ + /* + * Write PR_MTE_TCF to SCTLR_EL1[TCF0]. + * + * The kernel has a per-cpu configuration for the sysadmin, + * /sys/devices/system/cpu/cpu/mte_tcf_preferred, + * which qemu does not implement. + * + * Because there is no performance difference between the modes, and + * because SYNC is most useful for debugging MTE errors, choose SYNC + * as the preferred mode. With this preference, and the way the API + * uses only two bits, there is no way for the program to select + * ASYMM mode. + */ + unsigned tcf =3D 0; + if (value & PR_MTE_TCF_SYNC) { + tcf =3D 1; + } else if (value & PR_MTE_TCF_ASYNC) { + tcf =3D 2; + } + env->cp15.sctlr_el[1] =3D deposit64(env->cp15.sctlr_el[1], 38, 2, tcf); +} diff --git a/linux-user/syscall.c b/linux-user/syscall.c index e2804312fc..b8c278b91d 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6281,15 +6281,6 @@ abi_long do_arch_prctl(CPUX86State *env, int code, a= bi_ulong addr) # define PR_GET_TAGGED_ADDR_CTRL 56 # define PR_TAGGED_ADDR_ENABLE (1UL << 0) #endif -#ifndef PR_MTE_TCF_SHIFT -# define PR_MTE_TCF_SHIFT 1 -# define PR_MTE_TCF_NONE (0UL << PR_MTE_TCF_SHIFT) -# define PR_MTE_TCF_SYNC (1UL << PR_MTE_TCF_SHIFT) -# define PR_MTE_TCF_ASYNC (2UL << PR_MTE_TCF_SHIFT) -# define PR_MTE_TCF_MASK (3UL << PR_MTE_TCF_SHIFT) -# define PR_MTE_TAG_SHIFT 3 -# define PR_MTE_TAG_MASK (0xffffUL << PR_MTE_TAG_SHIFT) -#endif #ifndef PR_SET_IO_FLUSHER # define PR_SET_IO_FLUSHER 57 # define PR_GET_IO_FLUSHER 58 diff --git a/linux-user/aarch64/meson.build b/linux-user/aarch64/meson.build index 248c578d15..f75bb3cd75 100644 --- a/linux-user/aarch64/meson.build +++ b/linux-user/aarch64/meson.build @@ -9,3 +9,5 @@ vdso_le_inc =3D gen_vdso.process('vdso-le.so', extra_args: ['-r', '__kernel_rt_sigreturn']) =20 linux_user_ss.add(when: 'TARGET_AARCH64', if_true: [vdso_be_inc, vdso_le_i= nc]) + +linux_user_ss.add(when: 'TARGET_AARCH64', if_true: [files('mte_user_helper= .c')]) --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169323; cv=none; d=zohomail.com; s=zohoarc; b=hiuoaO6xVQb2HbwSc4wpBWXfujXuKfIDLiGtWfP6dbhqTG/FG5ygiV4M193wnD8YyMMsgcZO1JZ9Hxo465jMG9RTdrBSEZaiM7CTKnO+KCORn6Du+Rl1nsPpzZARlUpg+kaa9DYWG6af/XpwQVlnqhmozywkHfEoqUMEFfPdHoU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169323; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1i+oRffwUlRN86HbVYMqaafbL1Oir7rskJUuAdQaFjw=; b=LxNj/rDtw40+AnZr/ajS5lyeAjHd3z8Lwotb7sch4e+baQ8ED0Os/mtGFX7l+KRaC1OHZEH0zTad+CrZOnaVU69pWpOkXZRWuOI/6zNyfv7mvlbD7Qrz8B9ecZSFWzBYff+6NCuxceUeFrSGP+jZe6ZjVvdLH43hZIb/sVQu7zc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169323575927.0039094926931; Fri, 5 Jul 2024 01:48:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPecC-0002YJ-I8; Fri, 05 Jul 2024 04:48:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebP-0000yr-3D for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:35 -0400 Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeb8-0004BV-UX for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:34 -0400 Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2ebe40673e8so18483871fa.3 for ; Fri, 05 Jul 2024 01:47:15 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58ea536b05dsm1530036a12.8.2024.07.05.01.47.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:11 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3C3C662177; Fri, 5 Jul 2024 09:40:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169234; x=1720774034; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1i+oRffwUlRN86HbVYMqaafbL1Oir7rskJUuAdQaFjw=; b=ppwm+SJsomM+1lbrpmkabKEHNZ4qNKJsnvC7Vp4rrNsFNd9FH5h5la6ZL4UX2cDE/g 4R+M0FTrGJT5eRclbxMe0ki4iSyTHzPLZICIjZFs29Ozp/oWzWXUxN1eCJMTTR+9QOQ2 gidjEVPCE0OZ6SKYDkk4ZVg4TzWIahLp8VUxZscBX5ODiMpG/chF2z+ZisgHwcFcHQEH Mv+NKPkA+2YfHQGb5LOuxZA3cgFrF/4ecnvfaCOokSdRYsib8s8Xp/xTnBCXG+qiG9Du OVGG6YQyEmipdT5Xw9nlwWZHz2JM/VihxKn8rCZ/yy+XOFAVd5gtL1BH7xhNpXvOQthW +nMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169234; x=1720774034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1i+oRffwUlRN86HbVYMqaafbL1Oir7rskJUuAdQaFjw=; b=flJZomAnAqdjqXtSjnLHkrapYHSZS27xaYMrR+rIGdx17Z6YYsJ8dnUHxm67L/bCTY 1wQt2v4taKoti44gSwbhYXIZ+sAt+7Fp/jwPi8NjUpTB0kqaCHc3qwqs1V+k1Nv6kVId dgya4/1Ljg1V+NiPo2/KqfOklB8FNMjHrSPUXGkQlMZGFrn7K+cmONOsFzz/wK2ZQLya 9A0ITcEuZXjNwSy8xc4ohtbGx8qZ5P8Mgdx6LrCGzyMZ8FIiayLf0zTMrG2vk54ezrzy 6YxBPDZUgBa1D7kxb8Kfnt9bQz0UF/LFmDqHKc7SOvpTQb1CoKKMq5cgPW4eEceXk4st KB4A== X-Gm-Message-State: AOJu0Yw+/XrTTxRta/bAIIN9MgbsIu3h7XFzHdImNs8qqepnc3Itgf1G So5xzREoWELndKbXeb7pt4/JSpQPHfzhBTAvJqcd8jQJk9iAoij5yK6nhTEjaWk= X-Google-Smtp-Source: AGHT+IEGm064V0QCGpWjJY6+PWDvIDXdJSVlgntXRI1y+n4/3hPExEwt+0OzAzz73AOFRhlJ05lDIQ== X-Received: by 2002:a19:ca13:0:b0:52c:9421:2739 with SMTP id 2adb3069b0e04-52ea061b1bemr2470634e87.9.1720169234057; Fri, 05 Jul 2024 01:47:14 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 36/40] gdbstub: Make hex conversion function non-internal Date: Fri, 5 Jul 2024 09:40:43 +0100 Message-Id: <20240705084047.857176-37-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::234; envelope-from=alex.bennee@linaro.org; helo=mail-lj1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169324162100003 From: Gustavo Romero Make gdb_hextomem non-internal so it's not confined to use only in gdbstub.c. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240628050850.536447-8-gustavo.romero@linaro.org> --- gdbstub/internals.h | 1 - include/gdbstub/commands.h | 6 ++++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 34121dc61a..bf5a5c6302 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -107,7 +107,6 @@ static inline int tohex(int v) =20 void gdb_put_strbuf(void); int gdb_put_packet_binary(const char *buf, int len, bool dump); -void gdb_hextomem(GByteArray *mem, const char *buf, int len); void gdb_memtohex(GString *buf, const uint8_t *mem, int len); void gdb_memtox(GString *buf, const char *mem, int len); void gdb_read_byte(uint8_t ch); diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h index 306dfdef97..e51f276b40 100644 --- a/include/gdbstub/commands.h +++ b/include/gdbstub/commands.h @@ -91,4 +91,10 @@ void gdb_extend_set_table(GdbCmdParseEntry *table, int s= ize); */ void gdb_extend_qsupported_features(char *qsupported_features); =20 +/** + * Convert a hex string to bytes. Conversion is done per byte, so 2 hex di= gits + * are converted to 1 byte. Invalid hex digits are treated as 0 digits. + */ +void gdb_hextomem(GByteArray *mem, const char *buf, int len); + #endif /* GDBSTUB_COMMANDS_H */ --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169263; cv=none; d=zohomail.com; s=zohoarc; b=oCQutYDfBNe7vVRgKJzQtb9Wtjm2x5FlYQshJmFjoI0izoFUvA8V1zRsxsZxzZi+GqwPq2Fh0ebrg/Xj0dNJbv753jh9t9OUDfI6d3QJ+5lloD42Po2gDnaWSUdzlA656G9Qw4mhVsaGdkyvKh9x3pGXZpxqrQJj6AyA9Ie+eDg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169263; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JoliEJsSzkKhZQwY3f6Epel/jCgNkpeyE6ZHVJ+pXJo=; b=W6pKq1Z0ig5KWEUHGIeH/MExZRjo9ddBZ53HAtZKGy+hqsGJ9/fybC7prIR/IgjQkL9EygHhlxAuFWsxCHz5WyzLis4P+srzdaWJDROc1bidTtMiwDVdEQJhB3tIGmadNoRSBHWMZjolZZ/jdme6LlYYbIuIfylL2MV3Q/ACTTY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169263754506.7969600323852; Fri, 5 Jul 2024 01:47:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPebK-0000vV-Rg; Fri, 05 Jul 2024 04:47:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebG-0000tl-Td for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:27 -0400 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeb3-0004Ax-OI for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:26 -0400 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-58b966b4166so1702972a12.1 for ; Fri, 05 Jul 2024 01:47:13 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58f9d3f11ffsm573363a12.67.2024.07.05.01.47.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 5527F6217D; Fri, 5 Jul 2024 09:40:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169232; x=1720774032; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JoliEJsSzkKhZQwY3f6Epel/jCgNkpeyE6ZHVJ+pXJo=; b=Qvi2a9XjpxLe5AkyUofn6/LikWpfyagKI2mRbm40T+GS1gFCTMTdMgOyqo1AA9ydVP TbCfsDJ41dylcx+WGxPCbh7pUA72WPa5bpwoq7mxiuT551yZ/+oo2w9FwzQV2ZLb8jEJ S05s7reCIgFIgRKICG0DFYhfr/B3jZyFBjV+NqklnBc+Q0qIGaD1uQe88EMk3PL3/r4N XuLYnfESkOYhJzlNErEBwEToWjdhsLLYZ35mm+VOFofFMiPglrQx4+mfpvbHdHbF4Boy +0NvRmrEbHGQLVcA6IJcaGBWHA41sWRU6x2+FbDNPqyhKb3WClXFTxppRlxeGBVDe8bJ xseg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169232; x=1720774032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JoliEJsSzkKhZQwY3f6Epel/jCgNkpeyE6ZHVJ+pXJo=; b=sq+BzcHXwCL9S5d4t8addtNZzcW8Pkt3CkAFqErmz00w75rBSoBnGcX14sUG096/en tsWsIvaLxwi0CZc+ED9wgZ61xfarFQsgvFzmubBt7pgS+FYmxHkSkHeyzTkOophxtoWS kzEZShoNZHnIqO7QdKMdMPvUtcSODH4nDMposODDrp1bHDDApIQlfROtpvhOwfkqPzh+ R7inbuHMpLyzRsWscbZvOqEQQ7QEFJ9+dpX475CcuIkDYBCNR4bb48wNca6n00RzWFdM wMO/Drotl1qfQSl+wDJYBpQ9UrjNrOa5N++GgDGActZ2ctyC3XTekKSlX/s9528uYafW oSog== X-Gm-Message-State: AOJu0YzTOJ/GBSG/D2Tm8w/ndSXPt+UHnKQHRs8uq875nzpsQtHmFWni M5xL09EavA6uhbnNSz3I33tsTGDykYzOMsbNuE+wCYowxlU3XCE1lX9yE80g5dA= X-Google-Smtp-Source: AGHT+IF5VPLchM8xkt4tOfpWY9w6IdBRhKtzuufLUL6EXMGsg8G6JvkrPJpaKA75LaO44V8otM3+gA== X-Received: by 2002:a05:6402:17c4:b0:585:3a33:9de0 with SMTP id 4fb4d7f45d1cf-58e5aecb62cmr2266271a12.26.1720169231829; Fri, 05 Jul 2024 01:47:11 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 37/40] gdbstub: Pass CPU context to command handler Date: Fri, 5 Jul 2024 09:40:44 +0100 Message-Id: <20240705084047.857176-38-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x534.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169265885100001 From: Gustavo Romero Allow passing the current CPU context to command handlers via user_ctx when the handler requires it. Signed-off-by: Gustavo Romero Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240628050850.536447-9-gustavo.romero@linaro.org> Reviewed-by: Manos Pitsidianakis --- include/gdbstub/commands.h | 3 +++ gdbstub/gdbstub.c | 7 ++++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/include/gdbstub/commands.h b/include/gdbstub/commands.h index e51f276b40..f3058f9dda 100644 --- a/include/gdbstub/commands.h +++ b/include/gdbstub/commands.h @@ -54,6 +54,8 @@ typedef union GdbCmdVariant { * "stop reply" packet. The list of commands that accept such response is * defined at the GDB Remote Serial Protocol documentation. See: * https://sourceware.org/gdb/onlinedocs/gdb/Stop-Reply-Packets.html#Stop-= Reply-Packets. + * + * @need_cpu_context: Pass current CPU context to command handler via user= _ctx. */ typedef struct GdbCmdParseEntry { GdbCmdHandler handler; @@ -61,6 +63,7 @@ typedef struct GdbCmdParseEntry { bool cmd_startswith; const char *schema; bool allow_stop_reply; + bool need_cpu_context; } GdbCmdParseEntry; =20 /** diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index b1ca253f97..5c1612ed2a 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -938,6 +938,7 @@ static bool process_string_cmd(const char *data, =20 for (i =3D 0; i < num_cmds; i++) { const GdbCmdParseEntry *cmd =3D &cmds[i]; + void *user_ctx =3D NULL; g_assert(cmd->handler && cmd->cmd); =20 if ((cmd->cmd_startswith && !startswith(data, cmd->cmd)) || @@ -952,8 +953,12 @@ static bool process_string_cmd(const char *data, } } =20 + if (cmd->need_cpu_context) { + user_ctx =3D (void *)gdbserver_state.g_cpu; + } + gdbserver_state.allow_stop_reply =3D cmd->allow_stop_reply; - cmd->handler(params, NULL); + cmd->handler(params, user_ctx); return true; } =20 --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169385; cv=none; d=zohomail.com; s=zohoarc; b=T9xprK1935U7WZxnmivgYZCGuMTkRu15koeAK1D5QHS/LckTMRE4MqSr0iPcIEt7s9t1r2RNJve7ejkPDUsMp9vyoyt94aC7sCJyrGpOaVLqD1VeF03nBxKiWBBhslTajxhbRbnJza1+DwjJLh0R4vxCyys9B4KsGww5IyD0xfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169385; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=77YvatHWOR33cTX9z3lD3BFIb9bFvCKghDfoEWx4ifM=; b=TmYaprRBe89Fw3mwMJl9O5WtWRQ9zDoVlxDTlh4ovbJd+2LOPxOcPGf3cWk4MwX+KAS8rJolncuz4TCQVA/ehg6MeRMvdsmiRv/UByzv+5RCrQoClLHtWlRgMs+LqzmJDIgna5Ohv7Hj4UhdUQ8135Zvk1r9WNXBMm9PywM0BL4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169385875949.9093756534535; Fri, 5 Jul 2024 01:49:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPecI-00035q-Kz; Fri, 05 Jul 2024 04:48:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPebR-00011A-4S for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:37 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPebA-0004CP-RN for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:47:36 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-52ea2f58448so1290408e87.1 for ; Fri, 05 Jul 2024 01:47:19 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58c9061becfsm3499904a12.83.2024.07.05.01.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:47:16 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 6D9E9621AC; Fri, 5 Jul 2024 09:40:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169238; x=1720774038; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=77YvatHWOR33cTX9z3lD3BFIb9bFvCKghDfoEWx4ifM=; b=YxgaobAkELsg/R7aYC8kgWRAOGKUmEcWuLAQS1qvktdmE2YnzYMY2Pg2F9pdBGgfov /AjjTPx1eobbI5gdgvtN4ql+u97iHPMw4qwqaQossAU3fLrFAraYHQhYQqvU0n35ejEt vwBLgBBe6EYeGLueE7CVZOXqrQeJjl9IvNEJLm0iVF45ByVBz6xcti0BUy5qIQuz9g04 vmWUX9xq04qLbV0/PBQ6A4BgkvCXevDsu4JDz9Jx5Ysg5ib+kd38q07cgFzTbApUt2Kj s75TcjD8T3Tni+BWVQRkacRZJVu6G1dr5vBNkHPs046uTBolRW07mJYSSAZ909J4oB3/ WL2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169238; x=1720774038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=77YvatHWOR33cTX9z3lD3BFIb9bFvCKghDfoEWx4ifM=; b=r0aKpilZA6Y5S3UHBHHZiTtQ8yRbQgd4dRsUb/6O+yd2x0Zp8m10iRiNr6czNiw3GJ ovxAO0gmfxHrsx5v0mLGE/WSE7N0Lj2qwCiuWR4ye0BYSMS2gEYY1bvta0qYkYFuhvgP orBCYT9Es+kqVDwX3VAX4YGvtMoRt3z6VvZ/6tvIKDONZciR4GdpNTOhlDAjMw49OCmg e451P2ml0sZ6Un+bDGCbqgY5B3/tXV1bWokAvkzfd0rtNJVw14WsylxPZjhqrl1jSGkJ ERQzO2rapPHSNvie4Ey4cXBQKC6OmS1NiA4RIP/X4ZiGoc5npMW/GtRl7parIdidFDeB rFhA== X-Gm-Message-State: AOJu0YzfN6NtqGMqygCHR33QE/AI9G11x73CaM1Oqi+UH0qXoCXd62Kz 5zx0IePTFE4j7LNpx79FzefoQhp20gIxJiwm+cAr4tsoq9O9jymT4ChOeT/9isc= X-Google-Smtp-Source: AGHT+IFg1/+kF3iTierx2fmPEuZ+gpoRIneMJUDTMazG/hSFaQyo9o15Q648oMk5deFvwrCi4aiyxg== X-Received: by 2002:a05:6512:15a9:b0:52e:a60e:3a0e with SMTP id 2adb3069b0e04-52ea60e3b9cmr1232186e87.0.1720169238294; Fri, 05 Jul 2024 01:47:18 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 38/40] gdbstub: Use true to set cmd_startswith Date: Fri, 5 Jul 2024 09:40:45 +0100 Message-Id: <20240705084047.857176-39-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=alex.bennee@linaro.org; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169386454100004 From: Gustavo Romero cmd_startswith is a boolean so use 'true' to set it instead of 1. Signed-off-by: Gustavo Romero Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240628050850.536447-10-gustavo.romero@linaro.org> Reviewed-by: Manos Pitsidianakis --- gdbstub/gdbstub.c | 80 +++++++++++++++++++++++------------------------ 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 5c1612ed2a..b9ad0a063e 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1433,26 +1433,26 @@ static const GdbCmdParseEntry gdb_v_commands_table[= ] =3D { { .handler =3D handle_v_cont_query, .cmd =3D "Cont?", - .cmd_startswith =3D 1 + .cmd_startswith =3D true }, { .handler =3D handle_v_cont, .cmd =3D "Cont", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .allow_stop_reply =3D true, .schema =3D "s0" }, { .handler =3D handle_v_attach, .cmd =3D "Attach;", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .allow_stop_reply =3D true, .schema =3D "l0" }, { .handler =3D handle_v_kill, .cmd =3D "Kill;", - .cmd_startswith =3D 1 + .cmd_startswith =3D true }, #ifdef CONFIG_USER_ONLY /* @@ -1462,25 +1462,25 @@ static const GdbCmdParseEntry gdb_v_commands_table[= ] =3D { { .handler =3D gdb_handle_v_file_open, .cmd =3D "File:open:", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "s,L,L0" }, { .handler =3D gdb_handle_v_file_close, .cmd =3D "File:close:", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "l0" }, { .handler =3D gdb_handle_v_file_pread, .cmd =3D "File:pread:", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "l,L,L0" }, { .handler =3D gdb_handle_v_file_readlink, .cmd =3D "File:readlink:", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "s0" }, #endif @@ -1748,7 +1748,7 @@ static const GdbCmdParseEntry gdb_gen_query_set_commo= n_table[] =3D { { .handler =3D handle_set_qemu_sstep, .cmd =3D "qemu.sstep=3D", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "l0" }, }; @@ -1804,7 +1804,7 @@ static const GdbCmdParseEntry gdb_gen_query_table[] = =3D { { .handler =3D handle_query_thread_extra, .cmd =3D "ThreadExtraInfo,", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "t0" }, #ifdef CONFIG_USER_ONLY @@ -1816,14 +1816,14 @@ static const GdbCmdParseEntry gdb_gen_query_table[]= =3D { { .handler =3D gdb_handle_query_rcmd, .cmd =3D "Rcmd,", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "s0" }, #endif { .handler =3D handle_query_supported, .cmd =3D "Supported:", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "s0" }, { @@ -1834,7 +1834,7 @@ static const GdbCmdParseEntry gdb_gen_query_table[] = =3D { { .handler =3D handle_query_xfer_features, .cmd =3D "Xfer:features:read:", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "s:l,l0" }, #if defined(CONFIG_USER_ONLY) @@ -1842,27 +1842,27 @@ static const GdbCmdParseEntry gdb_gen_query_table[]= =3D { { .handler =3D gdb_handle_query_xfer_auxv, .cmd =3D "Xfer:auxv:read::", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "l,l0" }, { .handler =3D gdb_handle_query_xfer_siginfo, .cmd =3D "Xfer:siginfo:read::", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "l,l0" }, #endif { .handler =3D gdb_handle_query_xfer_exec_file, .cmd =3D "Xfer:exec-file:read:", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "l:l,l0" }, #endif { .handler =3D gdb_handle_query_attached, .cmd =3D "Attached:", - .cmd_startswith =3D 1 + .cmd_startswith =3D true }, { .handler =3D gdb_handle_query_attached, @@ -1901,14 +1901,14 @@ static const GdbCmdParseEntry gdb_gen_set_table[] = =3D { { .handler =3D handle_set_qemu_sstep, .cmd =3D "qemu.sstep:", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "l0" }, #ifndef CONFIG_USER_ONLY { .handler =3D gdb_handle_set_qemu_phy_mem_mode, .cmd =3D "qemu.PhyMemMode:", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "l0" }, #endif @@ -1916,7 +1916,7 @@ static const GdbCmdParseEntry gdb_gen_set_table[] =3D= { { .handler =3D gdb_handle_set_catch_syscalls, .cmd =3D "CatchSyscalls:", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "s0", }, #endif @@ -2012,7 +2012,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry target_halted_cmd_desc =3D { .handler =3D handle_target_halt, .cmd =3D "?", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .allow_stop_reply =3D true, }; cmd_parser =3D &target_halted_cmd_desc; @@ -2023,7 +2023,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry continue_cmd_desc =3D { .handler =3D handle_continue, .cmd =3D "c", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .allow_stop_reply =3D true, .schema =3D "L0" }; @@ -2035,7 +2035,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry cont_with_sig_cmd_desc =3D { .handler =3D handle_cont_with_sig, .cmd =3D "C", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .allow_stop_reply =3D true, .schema =3D "l0" }; @@ -2047,7 +2047,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry v_cmd_desc =3D { .handler =3D handle_v_commands, .cmd =3D "v", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "s0" }; cmd_parser =3D &v_cmd_desc; @@ -2064,7 +2064,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry detach_cmd_desc =3D { .handler =3D handle_detach, .cmd =3D "D", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "?.l0" }; cmd_parser =3D &detach_cmd_desc; @@ -2075,7 +2075,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry step_cmd_desc =3D { .handler =3D handle_step, .cmd =3D "s", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .allow_stop_reply =3D true, .schema =3D "L0" }; @@ -2087,7 +2087,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry backward_cmd_desc =3D { .handler =3D handle_backward, .cmd =3D "b", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .allow_stop_reply =3D true, .schema =3D "o0" }; @@ -2099,7 +2099,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry file_io_cmd_desc =3D { .handler =3D gdb_handle_file_io, .cmd =3D "F", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "L,L,o0" }; cmd_parser =3D &file_io_cmd_desc; @@ -2110,7 +2110,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry read_all_regs_cmd_desc =3D { .handler =3D handle_read_all_regs, .cmd =3D "g", - .cmd_startswith =3D 1 + .cmd_startswith =3D true }; cmd_parser =3D &read_all_regs_cmd_desc; } @@ -2120,7 +2120,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry write_all_regs_cmd_desc =3D { .handler =3D handle_write_all_regs, .cmd =3D "G", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "s0" }; cmd_parser =3D &write_all_regs_cmd_desc; @@ -2131,7 +2131,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry read_mem_cmd_desc =3D { .handler =3D handle_read_mem, .cmd =3D "m", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "L,L0" }; cmd_parser =3D &read_mem_cmd_desc; @@ -2142,7 +2142,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry write_mem_cmd_desc =3D { .handler =3D handle_write_mem, .cmd =3D "M", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "L,L:s0" }; cmd_parser =3D &write_mem_cmd_desc; @@ -2153,7 +2153,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry get_reg_cmd_desc =3D { .handler =3D handle_get_reg, .cmd =3D "p", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "L0" }; cmd_parser =3D &get_reg_cmd_desc; @@ -2164,7 +2164,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry set_reg_cmd_desc =3D { .handler =3D handle_set_reg, .cmd =3D "P", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "L?s0" }; cmd_parser =3D &set_reg_cmd_desc; @@ -2175,7 +2175,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry insert_bp_cmd_desc =3D { .handler =3D handle_insert_bp, .cmd =3D "Z", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "l?L?L0" }; cmd_parser =3D &insert_bp_cmd_desc; @@ -2186,7 +2186,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry remove_bp_cmd_desc =3D { .handler =3D handle_remove_bp, .cmd =3D "z", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "l?L?L0" }; cmd_parser =3D &remove_bp_cmd_desc; @@ -2197,7 +2197,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry set_thread_cmd_desc =3D { .handler =3D handle_set_thread, .cmd =3D "H", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "o.t0" }; cmd_parser =3D &set_thread_cmd_desc; @@ -2208,7 +2208,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry thread_alive_cmd_desc =3D { .handler =3D handle_thread_alive, .cmd =3D "T", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "t0" }; cmd_parser =3D &thread_alive_cmd_desc; @@ -2219,7 +2219,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry gen_query_cmd_desc =3D { .handler =3D handle_gen_query, .cmd =3D "q", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "s0" }; cmd_parser =3D &gen_query_cmd_desc; @@ -2230,7 +2230,7 @@ static int gdb_handle_packet(const char *line_buf) static const GdbCmdParseEntry gen_set_cmd_desc =3D { .handler =3D handle_gen_set, .cmd =3D "Q", - .cmd_startswith =3D 1, + .cmd_startswith =3D true, .schema =3D "s0" }; cmd_parser =3D &gen_set_cmd_desc; --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169131; cv=none; d=zohomail.com; s=zohoarc; b=NkSdZMry/yLZdIYon19QhYfRkba+jC5ITsVcyXduFSNAT/cXbkF4yzOSa8QSNaCSv777MEkl856bsd1noQxmGns3k1VTdXjdWr2cwcrwIFnYnrihj40dXrmhrIpI1MCrkaQLi3uSOl9QpNTVZ5SBj0lLv45zK3LGGDkZxsm2Q9E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169131; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WvX7+SgECJPhb0T5tWrIRbH04Gv0AGqro5YYirQFxyg=; b=RIQyD/8cZSQoVh+hnTMY8UPSkzmBLeWkIBr4xkj++d+MEurbFgDXFZ36m1Eq/WsW/dn13IqX2RexF+vz/Nk8+crcmMmVRVnn0cI5ymp5L3yZR2+tBnbTa26djBhKB6WCDaTnAfwJhxFCuyxASeyiRtNdn8T4n2hm3v8tOh8IS6E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169131980338.4835558738298; Fri, 5 Jul 2024 01:45:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPeVs-00026x-Dg; Fri, 05 Jul 2024 04:41:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPeVJ-0000Cj-Nn for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:19 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPeVG-0003Jt-9R for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:41:17 -0400 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-58b447c513aso1603682a12.2 for ; Fri, 05 Jul 2024 01:41:13 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58d75e20c30sm2718149a12.43.2024.07.05.01.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:41:06 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 8A4BE621B4; Fri, 5 Jul 2024 09:40:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720168872; x=1720773672; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WvX7+SgECJPhb0T5tWrIRbH04Gv0AGqro5YYirQFxyg=; b=L6MF1EHgBWcQcLw2SdqnhtDnOiqUi+b3NrurTwtiv25p7lVHijxk+nN/UlwBH5/lA9 GvRalrmqHwVoMBwCUocuC/WUTh4PTSQeKB/rNHBbv0KPhLuHYIYmtSFKoktOE15bNmHU eRTDZotm6VfHxZJKhgE/+jLo2dFtDuLRfsFImHg4WvRqqoSFOS2TquncRVrcef4hsDhw CWvmUkPiM5x++8mI/kAV/UbOaV4nRTPpzRPHyEurhQAnXOLU7qa8168h17izwtIpCv9N Pb4obYFS1HS4+Af9G7ZyZRVTli8WM4OyMuKJKDMeYb5+5wHlYEZrzbXmLTLkUGM3/nwR pedg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720168872; x=1720773672; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WvX7+SgECJPhb0T5tWrIRbH04Gv0AGqro5YYirQFxyg=; b=Wsolt8YIvJr2dbun3BY+/bCqbdTTHY48YknOXVCu/iorOP7kTM4WtB8kL1dLvw3Xw/ m7HCAa8Qi9mgWWnM2tjjIi+v/Lun2dSf0R61TtvezhwFC4LFdZPsTLZqKrhsB1hGWq+C OpWKbbXf0es5lbECRTKpwY1sx7HuZ71sz6E2idD2YANA8VS+UyWg9ldvKXtL5RyjAIsm HjSR0Ui6v9jlEylTGBMOUt+G8zk8hYorrm9mxN+T0lnRMnt/B6p1c9Po18WBV2cnL98x fDz/EWoDooV8QyTNMjXBXIqrxWXKNSesm9OdRLRzQtETQuny0Ckq174grNr9Sr9y/cty jCWQ== X-Gm-Message-State: AOJu0YyD+jq4ug5PW/3dZBrKgv4n+pbIkXOkBTYmtAOO3xZUKwgtWf3g dVRMB7tnEjUi0hfGnbguDwlf0o7TRqViJYsuRx0MP61Qq3PkwQd1htlHDRmK2lg= X-Google-Smtp-Source: AGHT+IFrpiaAN3+feRSdRsvnCvArcCwzJ1Q9bU/rUzThQ6cok8wKc04usnuqU91fT6rVmyhBE7/uwA== X-Received: by 2002:a05:6402:909:b0:57d:1e27:65ea with SMTP id 4fb4d7f45d1cf-58e5c824bc7mr3161580a12.34.1720168871463; Fri, 05 Jul 2024 01:41:11 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 39/40] gdbstub: Add support for MTE in user mode Date: Fri, 5 Jul 2024 09:40:46 +0100 Message-Id: <20240705084047.857176-40-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169133373100006 From: Gustavo Romero This commit implements the stubs to handle the qIsAddressTagged, qMemTag, and QMemTag GDB packets, allowing all GDB 'memory-tag' subcommands to work with QEMU gdbstub on aarch64 user mode. It also implements the get/set functions for the special GDB MTE register 'tag_ctl', used to control the MTE fault type at runtime. Signed-off-by: Gustavo Romero Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240628050850.536447-11-gustavo.romero@linaro.org> --- configs/targets/aarch64-linux-user.mak | 2 +- target/arm/internals.h | 6 + target/arm/cpu.c | 1 + target/arm/gdbstub.c | 46 +++++ target/arm/gdbstub64.c | 223 +++++++++++++++++++++++++ gdb-xml/aarch64-mte.xml | 11 ++ 6 files changed, 288 insertions(+), 1 deletion(-) create mode 100644 gdb-xml/aarch64-mte.xml diff --git a/configs/targets/aarch64-linux-user.mak b/configs/targets/aarch= 64-linux-user.mak index ba8bc5fe3f..8f0ed21d76 100644 --- a/configs/targets/aarch64-linux-user.mak +++ b/configs/targets/aarch64-linux-user.mak @@ -1,6 +1,6 @@ TARGET_ARCH=3Daarch64 TARGET_BASE_ARCH=3Darm -TARGET_XML_FILES=3D gdb-xml/aarch64-core.xml gdb-xml/aarch64-fpu.xml gdb-x= ml/aarch64-pauth.xml +TARGET_XML_FILES=3D gdb-xml/aarch64-core.xml gdb-xml/aarch64-fpu.xml gdb-x= ml/aarch64-pauth.xml gdb-xml/aarch64-mte.xml TARGET_HAS_BFLT=3Dy CONFIG_SEMIHOSTING=3Dy CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy diff --git a/target/arm/internals.h b/target/arm/internals.h index 11b5da2562..e1aa1a63b9 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -358,6 +358,10 @@ void init_cpreg_list(ARMCPU *cpu); void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu); void arm_translate_init(void); =20 +void arm_cpu_register_gdb_commands(ARMCPU *cpu); +void aarch64_cpu_register_gdb_commands(ARMCPU *cpu, GString *, GArray *, + GArray *); + void arm_restore_state_to_opc(CPUState *cs, const TranslationBlock *tb, const uint64_t *data); @@ -1640,6 +1644,8 @@ int aarch64_gdb_get_fpu_reg(CPUState *cs, GByteArray = *buf, int reg); int aarch64_gdb_set_fpu_reg(CPUState *cs, uint8_t *buf, int reg); int aarch64_gdb_get_pauth_reg(CPUState *cs, GByteArray *buf, int reg); int aarch64_gdb_set_pauth_reg(CPUState *cs, uint8_t *buf, int reg); +int aarch64_gdb_get_tag_ctl_reg(CPUState *cs, GByteArray *buf, int reg); +int aarch64_gdb_set_tag_ctl_reg(CPUState *cs, uint8_t *buf, int reg); void arm_cpu_sve_finalize(ARMCPU *cpu, Error **errp); void arm_cpu_sme_finalize(ARMCPU *cpu, Error **errp); void arm_cpu_pauth_finalize(ARMCPU *cpu, Error **errp); diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 35fa281f1b..14d4eca127 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -2518,6 +2518,7 @@ static void arm_cpu_realizefn(DeviceState *dev, Error= **errp) =20 register_cp_regs_for_features(cpu); arm_cpu_register_gdb_regs_for_features(cpu); + arm_cpu_register_gdb_commands(cpu); =20 init_cpreg_list(cpu); =20 diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c index a3bb73cfa7..c3a9b5eb1e 100644 --- a/target/arm/gdbstub.c +++ b/target/arm/gdbstub.c @@ -21,6 +21,7 @@ #include "cpu.h" #include "exec/gdbstub.h" #include "gdbstub/helpers.h" +#include "gdbstub/commands.h" #include "sysemu/tcg.h" #include "internals.h" #include "cpu-features.h" @@ -474,6 +475,41 @@ static GDBFeature *arm_gen_dynamic_m_secextreg_feature= (CPUState *cs, #endif #endif /* CONFIG_TCG */ =20 +void arm_cpu_register_gdb_commands(ARMCPU *cpu) +{ + GArray *query_table =3D + g_array_new(FALSE, FALSE, sizeof(GdbCmdParseEntry)); + GArray *set_table =3D + g_array_new(FALSE, FALSE, sizeof(GdbCmdParseEntry)); + GString *qsupported_features =3D g_string_new(NULL); + + if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) { + #ifdef TARGET_AARCH64 + aarch64_cpu_register_gdb_commands(cpu, qsupported_features, query_= table, + set_table); + #endif + } + + /* Set arch-specific handlers for 'q' commands. */ + if (query_table->len) { + gdb_extend_query_table(&g_array_index(query_table, + GdbCmdParseEntry, 0), + query_table->len); + } + + /* Set arch-specific handlers for 'Q' commands. */ + if (set_table->len) { + gdb_extend_set_table(&g_array_index(set_table, + GdbCmdParseEntry, 0), + set_table->len); + } + + /* Set arch-specific qSupported feature. */ + if (qsupported_features->len) { + gdb_extend_qsupported_features(qsupported_features->str); + } +} + void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu) { CPUState *cs =3D CPU(cpu); @@ -507,6 +543,16 @@ void arm_cpu_register_gdb_regs_for_features(ARMCPU *cp= u) gdb_find_static_feature("aarch64-paut= h.xml"), 0); } + +#ifdef CONFIG_USER_ONLY + /* Memory Tagging Extension (MTE) 'tag_ctl' pseudo-register. */ + if (cpu_isar_feature(aa64_mte, cpu)) { + gdb_register_coprocessor(cs, aarch64_gdb_get_tag_ctl_reg, + aarch64_gdb_set_tag_ctl_reg, + gdb_find_static_feature("aarch64-mte.= xml"), + 0); + } +#endif #endif } else { if (arm_feature(env, ARM_FEATURE_NEON)) { diff --git a/target/arm/gdbstub64.c b/target/arm/gdbstub64.c index caa31ff3fa..2e2bc2700b 100644 --- a/target/arm/gdbstub64.c +++ b/target/arm/gdbstub64.c @@ -21,6 +21,12 @@ #include "cpu.h" #include "internals.h" #include "gdbstub/helpers.h" +#include "gdbstub/commands.h" +#include "tcg/mte_helper.h" +#if defined(CONFIG_USER_ONLY) && defined(CONFIG_LINUX) +#include +#include "mte_user_helper.h" +#endif =20 int aarch64_cpu_gdb_read_register(CPUState *cs, GByteArray *mem_buf, int n) { @@ -381,3 +387,220 @@ GDBFeature *arm_gen_dynamic_svereg_feature(CPUState *= cs, int base_reg) =20 return &cpu->dyn_svereg_feature.desc; } + +#ifdef CONFIG_USER_ONLY +int aarch64_gdb_get_tag_ctl_reg(CPUState *cs, GByteArray *buf, int reg) +{ + ARMCPU *cpu =3D ARM_CPU(cs); + CPUARMState *env =3D &cpu->env; + uint64_t tcf0; + + assert(reg =3D=3D 0); + + tcf0 =3D extract64(env->cp15.sctlr_el[1], 38, 2); + + return gdb_get_reg64(buf, tcf0); +} + +int aarch64_gdb_set_tag_ctl_reg(CPUState *cs, uint8_t *buf, int reg) +{ + ARMCPU *cpu =3D ARM_CPU(cs); + CPUARMState *env =3D &cpu->env; + + uint8_t tcf; + + assert(reg =3D=3D 0); + + tcf =3D *buf << PR_MTE_TCF_SHIFT; + + if (!tcf) { + return 0; + } + + /* + * 'tag_ctl' register is actually a "pseudo-register" provided by GDB = to + * expose options regarding the type of MTE fault that can be controll= ed at + * runtime. + */ + arm_set_mte_tcf0(env, tcf); + + return 1; +} + +static void handle_q_memtag(GArray *params, void *user_ctx) +{ + ARMCPU *cpu =3D ARM_CPU(user_ctx); + CPUARMState *env =3D &cpu->env; + + uint64_t addr =3D gdb_get_cmd_param(params, 0)->val_ull; + uint64_t len =3D gdb_get_cmd_param(params, 1)->val_ul; + int type =3D gdb_get_cmd_param(params, 2)->val_ul; + + uint8_t *tags; + uint8_t addr_tag; + + g_autoptr(GString) str_buf =3D g_string_new(NULL); + + /* + * GDB does not query multiple tags for a memory range on remote targe= ts, so + * that's not supported either by gdbstub. + */ + if (len !=3D 1) { + gdb_put_packet("E02"); + } + + /* GDB never queries a tag different from an allocation tag (type 1). = */ + if (type !=3D 1) { + gdb_put_packet("E03"); + } + + /* Note that tags are packed here (2 tags packed in one byte). */ + tags =3D allocation_tag_mem_probe(env, 0, addr, MMU_DATA_LOAD, 8 /* 64= -bit */, + MMU_DATA_LOAD, true, 0); + if (!tags) { + /* Address is not in a tagged region. */ + gdb_put_packet("E04"); + return; + } + + /* Unpack tag from byte. */ + addr_tag =3D load_tag1(addr, tags); + g_string_printf(str_buf, "m%.2x", addr_tag); + + gdb_put_packet(str_buf->str); +} + +static void handle_q_isaddresstagged(GArray *params, void *user_ctx) +{ + ARMCPU *cpu =3D ARM_CPU(user_ctx); + CPUARMState *env =3D &cpu->env; + + uint64_t addr =3D gdb_get_cmd_param(params, 0)->val_ull; + + uint8_t *tags; + const char *reply; + + tags =3D allocation_tag_mem_probe(env, 0, addr, MMU_DATA_LOAD, 8 /* 64= -bit */, + MMU_DATA_LOAD, true, 0); + reply =3D tags ? "01" : "00"; + + gdb_put_packet(reply); +} + +static void handle_Q_memtag(GArray *params, void *user_ctx) +{ + ARMCPU *cpu =3D ARM_CPU(user_ctx); + CPUARMState *env =3D &cpu->env; + + uint64_t start_addr =3D gdb_get_cmd_param(params, 0)->val_ull; + uint64_t len =3D gdb_get_cmd_param(params, 1)->val_ul; + int type =3D gdb_get_cmd_param(params, 2)->val_ul; + char const *new_tags_str =3D gdb_get_cmd_param(params, 3)->data; + + uint64_t end_addr; + + int num_new_tags; + uint8_t *tags; + + g_autoptr(GByteArray) new_tags =3D g_byte_array_new(); + + /* + * Only the allocation tag (i.e. type 1) can be set at the stub side. + */ + if (type !=3D 1) { + gdb_put_packet("E02"); + return; + } + + end_addr =3D start_addr + (len - 1); /* 'len' is always >=3D 1 */ + /* Check if request's memory range does not cross page boundaries. */ + if ((start_addr ^ end_addr) & TARGET_PAGE_MASK) { + gdb_put_packet("E03"); + return; + } + + /* + * Get all tags in the page starting from the tag of the start address. + * Note that there are two tags packed into a single byte here. + */ + tags =3D allocation_tag_mem_probe(env, 0, start_addr, MMU_DATA_STORE, + 8 /* 64-bit */, MMU_DATA_STORE, true, = 0); + if (!tags) { + /* Address is not in a tagged region. */ + gdb_put_packet("E04"); + return; + } + + /* Convert tags provided by GDB, 2 hex digits per tag. */ + num_new_tags =3D strlen(new_tags_str) / 2; + gdb_hextomem(new_tags, new_tags_str, num_new_tags); + + uint64_t address =3D start_addr; + int new_tag_index =3D 0; + while (address <=3D end_addr) { + uint8_t new_tag; + int packed_index; + + /* + * Find packed tag index from unpacked tag index. There are two ta= gs + * in one packed index (one tag per nibble). + */ + packed_index =3D new_tag_index / 2; + + new_tag =3D new_tags->data[new_tag_index % num_new_tags]; + store_tag1(address, tags + packed_index, new_tag); + + address +=3D TAG_GRANULE; + new_tag_index++; + } + + gdb_put_packet("OK"); +} + +enum Command { + qMemTags, + qIsAddressTagged, + QMemTags, + NUM_CMDS +}; + +static GdbCmdParseEntry cmd_handler_table[NUM_CMDS] =3D { + [qMemTags] =3D { + .handler =3D handle_q_memtag, + .cmd_startswith =3D true, + .cmd =3D "MemTags:", + .schema =3D "L,l:l0", + .need_cpu_context =3D true + }, + [qIsAddressTagged] =3D { + .handler =3D handle_q_isaddresstagged, + .cmd_startswith =3D true, + .cmd =3D "IsAddressTagged:", + .schema =3D "L0", + .need_cpu_context =3D true + }, + [QMemTags] =3D { + .handler =3D handle_Q_memtag, + .cmd_startswith =3D true, + .cmd =3D "MemTags:", + .schema =3D "L,l:l:s0", + .need_cpu_context =3D true + }, +}; +#endif /* CONFIG_USER_ONLY */ + +void aarch64_cpu_register_gdb_commands(ARMCPU *cpu, GString *qsupported, + GArray *qtable, GArray *stable) +{ +#ifdef CONFIG_USER_ONLY + /* MTE */ + if (cpu_isar_feature(aa64_mte, cpu)) { + g_string_append(qsupported, ";memory-tagging+"); + + g_array_append_val(qtable, cmd_handler_table[qMemTags]); + g_array_append_val(qtable, cmd_handler_table[qIsAddressTagged]); + + g_array_append_val(stable, cmd_handler_table[QMemTags]); + } +#endif +} diff --git a/gdb-xml/aarch64-mte.xml b/gdb-xml/aarch64-mte.xml new file mode 100644 index 0000000000..4b70b4f17a --- /dev/null +++ b/gdb-xml/aarch64-mte.xml @@ -0,0 +1,11 @@ + + + + + + + --=20 2.39.2 From nobody Mon Sep 16 19:30:13 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1720169926; cv=none; d=zohomail.com; s=zohoarc; b=nGmvKTeFR8wvCId2csKtreZaff8V525FA7hdzdjN4ZLpWjcSJs+FY3dgn06yecqY55e8An2ta9rZybDnce9Y8eC8CEJv7H7F/4KKpXYZUa8pRq4RDmK75+/niyKbrOCUdmA0CSbntHygNUs/gHx0qYKHzwRBF8cWfxUwAcF4ojQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1720169926; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xHVmIVyayxMegyw4DIBt6qb94HY2QGzdUFBwfR+82mg=; b=aKjh0TbDJ4XG8uXPe1csqgRvyVD/KWH/GxIXIdqe415UlUt2FgZDgRAnGjxAIVg9Ue9HAicbPmWYA0ok/cYj18qRklLoguDyHn1FXPXevqcw8bhnNai/0MpnMmidJ8WlssqoQv5G3k6Z0BKTtBOYY7zBwsKdvzi5wrV9ee700bw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1720169926897222.2676829294045; Fri, 5 Jul 2024 01:58:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPel6-0002rx-1w; Fri, 05 Jul 2024 04:57:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPekz-0002gU-0O for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:57:29 -0400 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPekk-0001ub-WD for qemu-devel@nongnu.org; Fri, 05 Jul 2024 04:57:28 -0400 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-a77cc44f8aaso24662366b.3 for ; Fri, 05 Jul 2024 01:57:13 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-58ec828b34asm1409751a12.15.2024.07.05.01.57.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jul 2024 01:57:10 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id A9090621BD; Fri, 5 Jul 2024 09:40:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720169832; x=1720774632; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xHVmIVyayxMegyw4DIBt6qb94HY2QGzdUFBwfR+82mg=; b=dK7SCVit6m1StJhockaYw5PYTEoZAAL3qSQFnrumEL/lie86AUtbateL9G8hW4ZDai NylvBChVBkOx+TArxRLrDpl5Cf5bV1+V9HeJECMpl4Z8b4DwBNBQP4mIlwgBsB/+/qI8 2en7M1yY9Uw01TaggYJn3Ueg+sIWrcNPwJMfzFUxRPl/WzKd93HuyrR9r9nuAMZFznk4 Qoo+WaSsMueHH6cb6x79iQlg8ew1JRuSkZe7mR+SFItyCwrmaFE638fGei9OOX2RDaJY IuB6SbPOXpJLmzMck4RGRXbDDhPQhsoWViEdOQOFloRqX5zLdnZXOe3cnjf3vVXAiRIZ WdUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720169832; x=1720774632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xHVmIVyayxMegyw4DIBt6qb94HY2QGzdUFBwfR+82mg=; b=joDB5ONs4K/e9Uu2F/fygiu1I2v4B84byNxAX8t8/UzrWs5gHqsfyODNnonCZqsxUC UewoD/fs2rjddP2Gn2XZMwfLD6w93pOhbLul3ZgAFOswJ8xvHCU2SMekeNF9QM+oeYU7 I0SGC4/2xfxeucO9MLOnQB6EuaLhAcwakiXNIHXKPm9i10LuMhTW6FeSCu2iOyUu4d2r oczvnvTkTaM2BtD+W9FGO4uDohOQm1RfigBSpV/eFfcblNLkaMmqpe8XJB9O2tyrgY5F NmbMB1AlgU4H4H8EH6JPYu5m1rrMabS6ejVAnHVvFv8cwuhGpzjto/V0EKpQAWUY91Hs vJ6A== X-Gm-Message-State: AOJu0Yxu4+owANVRcJJ5mMbXXS7DKNLBQhFcclj1Kt+VrltsAsWKO5dd luZxt5TutobF+PsoaBlMmd3vHYk+K0/0LGIyh+g59zdrI436VOL7CfRhHv2dglA= X-Google-Smtp-Source: AGHT+IF0S1SAtjKEPlawYgOMJ7oBq5SMiWvZHMyIfFOlr9i8TGWD3CzlvxOEF4HF4AhpyxeKeRTf6Q== X-Received: by 2002:a05:6402:34c4:b0:57c:5f77:1136 with SMTP id 4fb4d7f45d1cf-58e5a4fe82bmr3759660a12.24.1720169832181; Fri, 05 Jul 2024 01:57:12 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Beraldo Leal , David Hildenbrand , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Alexandre Iooss , Thomas Huth , Mahmoud Mandour , Peter Maydell , qemu-arm@nongnu.org, Aleksandar Rikalo , Mads Ynddal , Yanan Wang , Eduardo Habkost , Peter Xu , Richard Henderson , Marcel Apfelbaum , Paul Burton , Stefan Hajnoczi , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , Gustavo Romero Subject: [PATCH v2 40/40] tests/tcg/aarch64: Add MTE gdbstub tests Date: Fri, 5 Jul 2024 09:40:47 +0100 Message-Id: <20240705084047.857176-41-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240705084047.857176-1-alex.bennee@linaro.org> References: <20240705084047.857176-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1720169927460100003 From: Gustavo Romero Add tests to exercise the MTE stubs. The tests will only run if a version of GDB that supports MTE is available in the test environment. Signed-off-by: Gustavo Romero [AJB: re-base and checkpatch fixes] Signed-off-by: Alex Benn=C3=A9e Message-Id: <20240628050850.536447-12-gustavo.romero@linaro.org> --- configure | 4 ++ tests/tcg/aarch64/mte-8.c | 99 +++++++++++++++++++++++++++ tests/tcg/aarch64/Makefile.target | 14 +++- tests/tcg/aarch64/gdbstub/test-mte.py | 86 +++++++++++++++++++++++ 4 files changed, 202 insertions(+), 1 deletion(-) create mode 100644 tests/tcg/aarch64/mte-8.c create mode 100644 tests/tcg/aarch64/gdbstub/test-mte.py diff --git a/configure b/configure index 8b6a2f16ce..019fcbd0ef 100755 --- a/configure +++ b/configure @@ -1673,6 +1673,10 @@ for target in $target_list; do echo "GDB=3D$gdb_bin" >> $config_target_mak fi =20 + if test "${arch}" =3D "aarch64" && version_ge ${gdb_version##* } 15.= 0; then + echo "GDB_HAS_MTE=3Dy" >> $config_target_mak + fi + echo "run-tcg-tests-$target: $qemu\$(EXESUF)" >> Makefile.prereqs tcg_tests_targets=3D"$tcg_tests_targets $target" fi diff --git a/tests/tcg/aarch64/mte-8.c b/tests/tcg/aarch64/mte-8.c new file mode 100644 index 0000000000..808135ba43 --- /dev/null +++ b/tests/tcg/aarch64/mte-8.c @@ -0,0 +1,99 @@ +/* + * To be compiled with -march=3Darmv8.5-a+memtag + * + * This test is adapted from a Linux test. Please see: + * + * https://www.kernel.org/doc/html/next/arch/arm64/memory-tagging-extensio= n.html#example-of-correct-usage + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +/* + * From arch/arm64/include/uapi/asm/hwcap.h + */ +#define HWCAP2_MTE (1 << 18) + +/* + * From arch/arm64/include/uapi/asm/mman.h + */ +#define PROT_MTE 0x20 + +/* + * Insert a random logical tag into the given pointer. + */ +#define insert_random_tag(ptr) ({ \ + uint64_t __val; \ + asm("irg %0, %1" : "=3Dr" (__val) : "r" (ptr)); \ + __val; \ +}) + +/* + * Set the allocation tag on the destination address. + */ +#define set_tag(tagged_addr) do { \ + asm volatile("stg %0, [%0]" : : "r" (tagged_addr) : "memory"); \ +} while (0) + + +int main(int argc, char *argv[]) +{ + unsigned char *a; + unsigned long page_sz =3D sysconf(_SC_PAGESIZE); + unsigned long hwcap2 =3D getauxval(AT_HWCAP2); + + /* check if MTE is present */ + if (!(hwcap2 & HWCAP2_MTE)) { + return EXIT_FAILURE; + } + + /* + * Enable the tagged address ABI, synchronous or asynchronous MTE + * tag check faults (based on per-CPU preference) and allow all + * non-zero tags in the randomly generated set. + */ + if (prctl(PR_SET_TAGGED_ADDR_CTRL, + PR_TAGGED_ADDR_ENABLE | PR_MTE_TCF_SYNC | PR_MTE_TCF_ASYNC | + (0xfffe << PR_MTE_TAG_SHIFT), + 0, 0, 0)) { + perror("prctl() failed"); + return EXIT_FAILURE; + } + + a =3D mmap(0, page_sz, PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + if (a =3D=3D MAP_FAILED) { + perror("mmap() failed"); + return EXIT_FAILURE; + } + + printf("a[] address is %p\n", a); + + /* + * Enable MTE on the above anonymous mmap. The flag could be passed + * directly to mmap() and skip this step. + */ + if (mprotect(a, page_sz, PROT_READ | PROT_WRITE | PROT_MTE)) { + perror("mprotect() failed"); + return EXIT_FAILURE; + } + + /* access with the default tag (0) */ + a[0] =3D 1; + a[1] =3D 2; + + printf("a[0] =3D %hhu a[1] =3D %hhu\n", a[0], a[1]); + + /* set the logical and allocation tags */ + a =3D (unsigned char *)insert_random_tag(a); + set_tag(a); + + printf("%p\n", a); + + return 0; +} diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile= .target index ad1774c2ce..b53218e115 100644 --- a/tests/tcg/aarch64/Makefile.target +++ b/tests/tcg/aarch64/Makefile.target @@ -64,7 +64,7 @@ AARCH64_TESTS +=3D bti-2 =20 # MTE Tests ifneq ($(CROSS_CC_HAS_ARMV8_MTE),) -AARCH64_TESTS +=3D mte-1 mte-2 mte-3 mte-4 mte-5 mte-6 mte-7 +AARCH64_TESTS +=3D mte-1 mte-2 mte-3 mte-4 mte-5 mte-6 mte-7 mte-8 mte-%: CFLAGS +=3D $(CROSS_CC_HAS_ARMV8_MTE) endif =20 @@ -131,6 +131,18 @@ run-gdbstub-sve-ioctls: sve-ioctls basic gdbstub SVE ZLEN support) =20 EXTRA_RUNS +=3D run-gdbstub-sysregs run-gdbstub-sve-ioctls + +ifeq ($(GDB_HAS_MTE),y) +run-gdbstub-mte: mte-8 + $(call run-test, $@, $(GDB_SCRIPT) \ + --gdb $(GDB) \ + --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \ + --bin $< --test $(AARCH64_SRC)/gdbstub/test-mte.py, \ + gdbstub MTE support) + +EXTRA_RUNS +=3D run-gdbstub-mte +endif + endif endif =20 diff --git a/tests/tcg/aarch64/gdbstub/test-mte.py b/tests/tcg/aarch64/gdbs= tub/test-mte.py new file mode 100644 index 0000000000..2db0663c1a --- /dev/null +++ b/tests/tcg/aarch64/gdbstub/test-mte.py @@ -0,0 +1,86 @@ +from __future__ import print_function +# +# Test GDB memory-tag commands that exercise the stubs for the qIsAddressT= agged, +# qMemTag, and QMemTag packets. Logical tag-only commands rely on local +# operations, hence don't exercise any stub. +# +# The test consists in breaking just after a atag() call (which sets the +# allocation tag -- see mte-8.c for details) and setting/getting tags in +# different memory locations and ranges starting at the address of the arr= ay +# 'a'. +# +# This is launched via tests/guest-debug/run-test.py +# + + +import gdb +import re +from test_gdbstub import main, report + + +PATTERN_0 =3D "Memory tags for address 0x[0-9a-f]+ match \(0x[0-9a-f]+\)." +PATTERN_1 =3D ".*(0x[0-9a-f]+)" + + +def run_test(): + gdb.execute("break 95", False, True) + gdb.execute("continue", False, True) + try: + # Test if we can check correctly that the allocation tag for + # array 'a' matches the logical tag after atag() is called. + co =3D gdb.execute("memory-tag check a", False, True) + tags_match =3D re.findall(PATTERN_0, co, re.MULTILINE) + if tags_match: + report(True, f"{tags_match[0]}") + else: + report(False, "Logical and allocation tags don't match!") + + # Test allocation tag 'set and print' commands. Commands on logical + # tags rely on local operation and so don't exercise any stub. + + # Set the allocation tag for the first granule (16 bytes) of + # address starting at 'a' address to a known value, i.e. 0x04. + gdb.execute("memory-tag set-allocation-tag a 1 04", False, True) + + # Then set the allocation tag for the second granule to a known + # value, i.e. 0x06. This tests that contiguous tag granules are + # set correct and don't run over each other. + gdb.execute("memory-tag set-allocation-tag a+16 1 06", False, True) + + # Read the known values back and check if they remain the same. + + co =3D gdb.execute("memory-tag print-allocation-tag a", False, Tru= e) + first_tag =3D re.match(PATTERN_1, co)[1] + + co =3D gdb.execute("memory-tag print-allocation-tag a+16", False, = True) + second_tag =3D re.match(PATTERN_1, co)[1] + + if first_tag =3D=3D "0x4" and second_tag =3D=3D "0x6": + report(True, "Allocation tags are correctly set/printed.") + else: + report(False, "Can't set/print allocation tags!") + + # Now test fill pattern by setting a whole page with a pattern. + gdb.execute("memory-tag set-allocation-tag a 4096 0a0b", False, Tr= ue) + + # And read back the tags of the last two granules in page so + # we also test if the pattern is set correctly up to the end of + # the page. + co =3D gdb.execute("memory-tag print-allocation-tag a+4096-32", Fa= lse, True) + tag =3D re.match(PATTERN_1, co)[1] + + co =3D gdb.execute("memory-tag print-allocation-tag a+4096-16", Fa= lse, True) + last_tag =3D re.match(PATTERN_1, co)[1] + + if tag =3D=3D "0xa" and last_tag =3D=3D "0xb": + report(True, "Fill pattern is ok.") + else: + report(False, "Fill pattern failed!") + + except gdb.error: + # This usually happens because a GDB version that does not + # support memory tagging was used to run the test. + report(False, "'memory-tag' command failed!") + + +main(run_test, expected_arch=3D"aarch64") --=20 2.39.2