From nobody Mon Sep 16 19:05:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1719930948; cv=none; d=zohomail.com; s=zohoarc; b=ZRxl0E8igqyKecirc50AvaOXh1ER66qUNckWqGotaP+m1yBhH/zpeF/QGHYKhIj/IX7YH4hmgqy6HvavBTMWxkxcjLn1zV9tTdcwagpUDGcU7h4qD0QmEsAsPyHmztkIFUPklJskYS6TmY2R5gHt0bqLFZb3FuJ87/HO2hskC9k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1719930948; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=GC88M6r/mFeFhLYygwJDnw3HUWPW4o1zOcDJY7H5vEM=; b=DfxISuPOu+/wVVdSL75sP7Wq0EHjD8+6TebWSGeRRgwINtzz7vO2vHVCQ41rpIQ82ppTnxQYVzPDglwayK9PGvQ7Dj/LlOaBpd9xm/9CNpnAOeAdO9muk+FEIwgjquEmxkYzgaAfLFZYZCI99EKN8zyORbqt6qFymBeqUzk0Ai4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1719930948777130.73254893485364; Tue, 2 Jul 2024 07:35:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOebG-00058Y-Lk; Tue, 02 Jul 2024 10:35:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOeb3-00055z-Ly for qemu-devel@nongnu.org; Tue, 02 Jul 2024 10:35:11 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOeaz-0007hU-4k for qemu-devel@nongnu.org; Tue, 02 Jul 2024 10:35:05 -0400 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WD54z63qGz6J6pg; Tue, 2 Jul 2024 22:33:55 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 96733140B55; Tue, 2 Jul 2024 22:34:56 +0800 (CST) Received: from SecurePC-101-06.china.huawei.com (10.122.19.247) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 2 Jul 2024 15:34:56 +0100 To: , , Markus Armbruster , , Li Zhijian CC: Subject: [PATCH 1/3] hw/cxl: Get rid of unused cfmw_list Date: Tue, 2 Jul 2024 15:34:23 +0100 Message-ID: <20240702143425.717452-2-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240702143425.717452-1-Jonathan.Cameron@huawei.com> References: <20240702143425.717452-1-Jonathan.Cameron@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.122.19.247] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1719930950773100006 Content-Type: text/plain; charset="utf-8" From: Li Zhijian There is no user for this member. All '-M cxl-fmw.N' options have been parsed and saved to CXLState.fixed_windows. Signed-off-by: Li Zhijian Signed-off-by: Jonathan Cameron --- include/hw/cxl/cxl.h | 1 - hw/cxl/cxl-host.c | 1 - 2 files changed, 2 deletions(-) diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h index 75e47b6864..e3ecbef038 100644 --- a/include/hw/cxl/cxl.h +++ b/include/hw/cxl/cxl.h @@ -43,7 +43,6 @@ typedef struct CXLState { MemoryRegion host_mr; unsigned int next_mr_idx; GList *fixed_windows; - CXLFixedMemoryWindowOptionsList *cfmw_list; } CXLState; =20 struct CXLHost { diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c index c5f5fcfd64..926d3d3da7 100644 --- a/hw/cxl/cxl-host.c +++ b/hw/cxl/cxl-host.c @@ -335,7 +335,6 @@ static void machine_set_cfmw(Object *obj, Visitor *v, c= onst char *name, for (it =3D cfmw_list; it; it =3D it->next) { cxl_fixed_memory_window_config(state, it->value, errp); } - state->cfmw_list =3D cfmw_list; } =20 void cxl_machine_init(Object *obj, CXLState *state) --=20 2.43.0 From nobody Mon Sep 16 19:05:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1719930973; cv=none; d=zohomail.com; s=zohoarc; b=nvRHRykA/VrSoMPZVQcvca41DI98abb5gx+8StLcGuTKXBPIQBhEG2e06wskwhT4mnElxtX/MAwLzqrpftPfI+KCsBgKAToLsIHUyBu1M8vS1oSHtx5/6HfnOTTZrSci01zpwI7UL28nQD7YiHdmbStPrvuRPvbfwkb2d2frtiQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1719930973; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=qoQCLTiCvLjzick9gjZ/fPOpP/eE2PhJruwd54W2UdE=; b=gUlONqYMuyoWbKdxtloPXX0W77jzz7AVUz59TeZZ2dfy1+/H6Xz+0Z7p6jtGAfxhnouvOCxh8DLflovh+0ARskydNQvn62xD6MEas4wn2tmPNDs3Yd4yH9iLr8sTyGJ96308KSatc3pLVHwdStvh6Yd1o9UNciO7fGyS+2AVXb4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1719930973786785.54303836015; Tue, 2 Jul 2024 07:36:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOebd-0005ix-E6; Tue, 02 Jul 2024 10:35:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOeba-0005hf-FV for qemu-devel@nongnu.org; Tue, 02 Jul 2024 10:35:38 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOebY-00081p-5j for qemu-devel@nongnu.org; Tue, 02 Jul 2024 10:35:37 -0400 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WD56850lFz6JBYT; Tue, 2 Jul 2024 22:34:56 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 95B04140684; Tue, 2 Jul 2024 22:35:32 +0800 (CST) Received: from SecurePC-101-06.china.huawei.com (10.122.19.247) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 2 Jul 2024 15:35:27 +0100 To: , , Markus Armbruster , , Li Zhijian CC: Subject: [PATCH 2/3] hw/cxl/cxl-mailbox-utils: remove unneeded mailbox output payload space zeroing Date: Tue, 2 Jul 2024 15:34:24 +0100 Message-ID: <20240702143425.717452-3-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240702143425.717452-1-Jonathan.Cameron@huawei.com> References: <20240702143425.717452-1-Jonathan.Cameron@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.122.19.247] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1719930974908100003 Content-Type: text/plain; charset="utf-8" From: Fan Ni The whole mailbox output payload space is already zeroed after copying out the input payload, which happens before processing the specific mailbox command: https://elixir.bootlin.com/qemu/v8.2.1/source/hw/cxl/cxl-device-utils.c#L204 Signed-off-by: Fan Ni Link: https://lore.kernel.org/r/20240221221824.1092966-1-nifan.cxl@gmail.com Signed-off-by: Jonathan Cameron --- hw/cxl/cxl-mailbox-utils.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c index 74eeb6fde7..facec42dc8 100644 --- a/hw/cxl/cxl-mailbox-utils.c +++ b/hw/cxl/cxl-mailbox-utils.c @@ -235,7 +235,6 @@ static CXLRetCode cmd_events_get_records(const struct c= xl_cmd *cmd, log_type =3D payload_in[0]; =20 pl =3D (CXLGetEventPayload *)payload_out; - memset(pl, 0, sizeof(*pl)); =20 max_recs =3D (cxlds->payload_size - CXL_EVENT_PAYLOAD_HDR_SIZE) / CXL_EVENT_RECORD_SIZE; @@ -273,7 +272,6 @@ static CXLRetCode cmd_events_get_interrupt_policy(const= struct cxl_cmd *cmd, CXLEventLog *log; =20 policy =3D (CXLEventInterruptPolicy *)payload_out; - memset(policy, 0, sizeof(*policy)); =20 log =3D &cxlds->event_logs[CXL_EVENT_TYPE_INFO]; if (log->irq_enabled) { @@ -372,7 +370,6 @@ static CXLRetCode cmd_infostat_identify(const struct cx= l_cmd *cmd, QEMU_BUILD_BUG_ON(sizeof(*is_identify) !=3D 18); =20 is_identify =3D (void *)payload_out; - memset(is_identify, 0, sizeof(*is_identify)); is_identify->pcie_vid =3D class->vendor_id; is_identify->pcie_did =3D class->device_id; if (object_dynamic_cast(OBJECT(cci->d), TYPE_CXL_USP)) { @@ -606,7 +603,6 @@ static CXLRetCode cmd_infostat_bg_op_sts(const struct c= xl_cmd *cmd, QEMU_BUILD_BUG_ON(sizeof(*bg_op_status) !=3D 8); =20 bg_op_status =3D (void *)payload_out; - memset(bg_op_status, 0, sizeof(*bg_op_status)); bg_op_status->status =3D cci->bg.complete_pct << 1; if (cci->bg.runtime > 0) { bg_op_status->status |=3D 1U << 0; @@ -647,7 +643,6 @@ static CXLRetCode cmd_firmware_update_get_info(const st= ruct cxl_cmd *cmd, } =20 fw_info =3D (void *)payload_out; - memset(fw_info, 0, sizeof(*fw_info)); =20 fw_info->slots_supported =3D 2; fw_info->slot_info =3D BIT(0) | BIT(3); @@ -805,7 +800,6 @@ static CXLRetCode cmd_identify_memory_device(const stru= ct cxl_cmd *cmd, } =20 id =3D (void *)payload_out; - memset(id, 0, sizeof(*id)); =20 snprintf(id->fw_revision, 0x10, "BWFW VERSION %02d", 0); =20 @@ -1095,7 +1089,6 @@ static CXLRetCode cmd_media_get_poison_list(const str= uct cxl_cmd *cmd, out_pl_len =3D sizeof(*out) + record_count * sizeof(out->records[0]); assert(out_pl_len <=3D CXL_MAILBOX_MAX_PAYLOAD_SIZE); =20 - memset(out, 0, out_pl_len); QLIST_FOREACH(ent, poison_list, node) { uint64_t start, stop; =20 --=20 2.43.0 From nobody Mon Sep 16 19:05:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1719931011; cv=none; d=zohomail.com; s=zohoarc; b=GAU4qw/jSlDZ2B8y4b5HHDjru3X/GLieEtkioeTjuFUbxdxexsA1/fh2PhPFlDbEAyoqtPgG827WSp7eaw1kZpFBLGkMNlGej+LymmMJQ8KjIRV7i/XUzt5lus1dEN84w2eF6qdkQ6O+7lq0VqBcdlPgjjmMZ7zy6am1zDLUKi0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1719931011; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=EvGKvhpwb1yrIUBhZHyVVFwSh/1Yx0uuWr84I4ka6ME=; b=FE4yn0/Pz50auILHUSwWY7yVBexMn27DRozQ48nQu4WsKGwJ7w5jCbMXTvE37nbUoSEYRONfelNYPeHiKFJo4MG+eTACOMKynT/ZbT0TRfKIccBrJG9UKt3ZNzc3h93lVjUaQyQ+nNXbWiIwooth2+TsWnm548w7V0iq3RxeQ50= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 171993101144835.578467047931554; Tue, 2 Jul 2024 07:36:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOec6-0006y0-3f; Tue, 02 Jul 2024 10:36:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOec1-0006oI-JZ for qemu-devel@nongnu.org; Tue, 02 Jul 2024 10:36:06 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOeby-0000Kl-3x for qemu-devel@nongnu.org; Tue, 02 Jul 2024 10:36:05 -0400 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WD5692g20z6J6pg; Tue, 2 Jul 2024 22:34:57 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 21F16140A70; Tue, 2 Jul 2024 22:35:58 +0800 (CST) Received: from SecurePC-101-06.china.huawei.com (10.122.19.247) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 2 Jul 2024 15:35:57 +0100 To: , , Markus Armbruster , , Li Zhijian CC: Subject: [PATCH 3/3] hw/cxl: Check for multiple mappings of memory backends. Date: Tue, 2 Jul 2024 15:34:25 +0100 Message-ID: <20240702143425.717452-4-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240702143425.717452-1-Jonathan.Cameron@huawei.com> References: <20240702143425.717452-1-Jonathan.Cameron@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.122.19.247] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1719931013060100002 Content-Type: text/plain; charset="utf-8" Similar protection to that provided for -numa memdev=3Dx to make sure that memory used to back a type3 device is not also mapped as normal RAM, or for multiple type3 devices. This is an easy footgun to remove and seems multiple people have run into it. Signed-off-by: Jonathan Cameron --- hw/mem/cxl_type3.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/hw/mem/cxl_type3.c b/hw/mem/cxl_type3.c index 35ac59883a..e7fbbb4d51 100644 --- a/hw/mem/cxl_type3.c +++ b/hw/mem/cxl_type3.c @@ -737,6 +737,11 @@ static bool cxl_setup_memory(CXLType3Dev *ct3d, Error = **errp) error_setg(errp, "volatile memdev must have backing device"); return false; } + if (host_memory_backend_is_mapped(ct3d->hostvmem)) { + error_setg(errp, "memory backend %s can't be used multiple tim= es.", + object_get_canonical_path_component(OBJECT(ct3d->hostvmem))= ); + return false; + } memory_region_set_nonvolatile(vmr, false); memory_region_set_enabled(vmr, true); host_memory_backend_set_mapped(ct3d->hostvmem, true); @@ -760,6 +765,11 @@ static bool cxl_setup_memory(CXLType3Dev *ct3d, Error = **errp) error_setg(errp, "persistent memdev must have backing device"); return false; } + if (host_memory_backend_is_mapped(ct3d->hostpmem)) { + error_setg(errp, "memory backend %s can't be used multiple tim= es.", + object_get_canonical_path_component(OBJECT(ct3d->hostpmem))= ); + return false; + } memory_region_set_nonvolatile(pmr, true); memory_region_set_enabled(pmr, true); host_memory_backend_set_mapped(ct3d->hostpmem, true); @@ -790,6 +800,11 @@ static bool cxl_setup_memory(CXLType3Dev *ct3d, Error = **errp) return false; } =20 + if (host_memory_backend_is_mapped(ct3d->dc.host_dc)) { + error_setg(errp, "memory backend %s can't be used multiple tim= es.", + object_get_canonical_path_component(OBJECT(ct3d->dc.host_dc= ))); + return false; + } /* * Set DC regions as volatile for now, non-volatile support can * be added in the future if needed. --=20 2.43.0