From nobody Mon Sep 16 19:46:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=swemel.ru ARC-Seal: i=1; a=rsa-sha256; t=1719578476; cv=none; d=zohomail.com; s=zohoarc; b=LhqDuwn3Nk5XUR+xHQ4DYKFR8QbqVFEjUTBPAPx32tjxzyMCnNLaPpMNm/CaI5oBv150aOGjyMkuAFbpJeXyePHUWv6TuZpshhrzzJfwUaGcknBMnoE+snLksnholuljAq2kImHEY9h1i1Jc4B5sRT25OftrWdl8+H/i1lt7JyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1719578476; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RBKPpqL4X2xpKp8Vmq6/rIAYUG5RSond9CQ6kAwwBbc=; b=oGJk2mwFpb1PIfTg5ROyEJ9VkzRNFLUZB85iRS6h6a3Stk/zEIQieOgHnoUkEgGq+IcuoGx40kWz54tjH7nhPKcACQcucry7kSOjM96tpE3WxIFHoGurIsIjPnESKUMVktzpda96XAH7laFBi9mf1oDFFwH2Zv0QtzvAe20wMnw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1719578475569470.6723240919349; Fri, 28 Jun 2024 05:41:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNAtg-0003xX-Mh; Fri, 28 Jun 2024 08:40:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNAtf-0003x5-AY for qemu-devel@nongnu.org; Fri, 28 Jun 2024 08:40:11 -0400 Received: from mx.swemel.ru ([95.143.211.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNAta-0005Ct-T0 for qemu-devel@nongnu.org; Fri, 28 Jun 2024 08:40:11 -0400 From: Dmitry Frolov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1719578400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=RBKPpqL4X2xpKp8Vmq6/rIAYUG5RSond9CQ6kAwwBbc=; b=LKUzAej1gzY8rcebGIRG2VP8Zx2MDSuJJe0Gpb7j2/GulzNrzFzy7MLOqzLKrRzDwRZiUB P/aAT+avD03SJ5dALVx6EOW+3hgvnDlRn5/bzvQVlsTlxDIoysWLALD0XJnDJ5z5s9poar X/NbsygahbUVCMcXnPmuCkDC6n4ieWY= To: gaosong@loongson.cn Cc: sdl.qemu@linuxtesting.org, qemu-devel@nongnu.org, Dmitry Frolov Subject: [PATCH] hw/loongarch/boot.c: fix out-of-bound reading Date: Fri, 28 Jun 2024 15:39:10 +0300 Message-ID: <20240628123910.577740-1-frolov@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=95.143.211.150; envelope-from=frolov@swemel.ru; helo=mx.swemel.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @swemel.ru) X-ZM-MESSAGEID: 1719578479342100002 Content-Type: text/plain; charset="utf-8" memcpy() is trying to READ 512 bytes from memory, pointed by info->kernel_cmdline, which was (presumable) allocated by g_strdup(""); Found with ASAN, making check with enabled sanitizers. Signed-off-by: Dmitry Frolov Reviewed-by: Song Gao --- hw/loongarch/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/loongarch/boot.c b/hw/loongarch/boot.c index b8e1aa18d5..cb668703bd 100644 --- a/hw/loongarch/boot.c +++ b/hw/loongarch/boot.c @@ -163,7 +163,7 @@ static void init_cmdline(struct loongarch_boot_info *in= fo, void *p, void *start) info->a0 =3D 1; info->a1 =3D cmdline_addr; =20 - memcpy(p, info->kernel_cmdline, COMMAND_LINE_SIZE); + g_strlcpy(p, info->kernel_cmdline, COMMAND_LINE_SIZE); } =20 static uint64_t cpu_loongarch_virt_to_phys(void *opaque, uint64_t addr) --=20 2.43.0