From nobody Mon Nov 25 02:57:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1719058156; cv=none; d=zohomail.com; s=zohoarc; b=EqFvpY7jNACR4vD5+/KnY+sHgd3xIvHCz3r4IEH9SsvUG1seZi557zcG5wbFxid63uOxEEBrK8zJ48PzKbslw+seyBLeKUHDUrRuKkiXzGZgXqybfE1XF0ZMvMR4TOM7NE1AihtNaYNKk73SPAQ+3/QndDYvrneS50MhlJxip2g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1719058156; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=jve18Aw+DXElxImmNe3vbSqsQnw0nVV2aO+SXUToPbM=; b=R2+8YR623YLZQTc0Ez+jpOPLlyrTjZpuKI3VMzIczY7sJn+M0AdIeh3Erswlv+N5T6lYqCa8iOFha1z61y52lETPOLmgj4/3BbNlAmfdNHG8HlTbCs5gBiluwnKLNeZ/5SoS4++Guc7XeefVd6v4es6ljJeFkbCNSOORmwIA2Kc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1719058156346185.458634392774; Sat, 22 Jun 2024 05:09:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKzWN-00081h-Hk; Sat, 22 Jun 2024 08:07:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKzWG-0007vq-Ve for qemu-devel@nongnu.org; Sat, 22 Jun 2024 08:07:00 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sKzWB-0000LL-8l for qemu-devel@nongnu.org; Sat, 22 Jun 2024 08:06:57 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-36226e98370so1740883f8f.3 for ; Sat, 22 Jun 2024 05:06:54 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3663a2f698dsm4393006f8f.70.2024.06.22.05.06.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jun 2024 05:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719058013; x=1719662813; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=jve18Aw+DXElxImmNe3vbSqsQnw0nVV2aO+SXUToPbM=; b=sbw789IcYF3R8wzS31wP0RDIyyGSMcepyBcofqor9WEGE4HRaU/AdUGhmjKEmO8wqr H514et12k7O8li8jc6BG1EoIdEjjGW8bI+ymPzz/9PQodvo3iAyYR0SB8rHuhZhxkXIH Soj8bCoAU5G3QOT4RBeUkMoqIi9oE7tqdp5WctEErH7VVh6w17eG644Z3YfvqCk7dHKz mwQ2pl7s7r75eWL5maVjWJGsnnvVkzzprLeEzG+S5+V1CKa2SjIt1XXzELtPhi6p27ke 9qRkFSbo2gydnPG+DlieBglW+/hOu7xgP1lfVC0qcQEjKfrZXFWZEleL9GqKa+OmFDeC /pYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719058013; x=1719662813; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jve18Aw+DXElxImmNe3vbSqsQnw0nVV2aO+SXUToPbM=; b=vAYrOCJ/Kz7wDhfK7w0l37qBoE1z81r/d11FjtVNDRsqbt3gIQcQfNwbRmtHgkf4KO OSO1Em4r71PD0d0yAYF2UJowNiruwL8uAObwljCKFB3YQQ76NM2/7VWRSdhpgjDmHG8w 46hmF3Kyz2xSMv1F6OYUhrhv0yc8/7wJjuruILJRgyyBfDW2cslv2dtmfEhF+io3CjBe 6qaHSWV3MJMC5569HNbMbo8P8UWiATztS36kUdMLeoG0BFdGOWzlgNr6oE9ZC3QWA2gW DKcibJOX9jHteuCnRdHpTZnvvbxfFD9q2Q+Nn9PVUI8YaWgsomV4BY0cpB2I+mRBrKXM 1xMw== X-Gm-Message-State: AOJu0YwjQpF6PDTE7mD8MfMMhkkDv5PkdNU4n7574rPniHecDILT6gt6 /o3EBAc1ucAOlzbFst25pg64fRAgcOJqnsYkPuOvgZ4pCq64AbhaLthb6zd94ELFs1X08WjgEZl ZA30= X-Google-Smtp-Source: AGHT+IGS+laLieagrKLQYNNUzqTRRlO/ERjiD26KXil9cLAvRRkTpBocgWsMqKrZV6psScvYJeBbng== X-Received: by 2002:adf:fc11:0:b0:35f:2364:f1d9 with SMTP id ffacd0b85a97d-363199906fbmr7478812f8f.61.1719058013115; Sat, 22 Jun 2024 05:06:53 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 17/18] hw/usb/hcd-ohci: Fix ohci_service_td: accept zero-length TDs where CBP=BE+1 Date: Sat, 22 Jun 2024 13:06:42 +0100 Message-Id: <20240622120643.3797539-18-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240622120643.3797539-1-peter.maydell@linaro.org> References: <20240622120643.3797539-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1719058157124100001 From: David Hubbard This changes the way the ohci emulation handles a Transfer Descriptor with "Buffer End" set to "Current Buffer Pointer" - 1, specifically in the case of a zero-length packet. The OHCI spec 4.3.1.2 Table 4-2 specifies td.cbp to be zero for a zero-length packet. Peter Maydell tracked down commit 1328fe0c32 (hw: usb: hcd-ohci: check len and frame_number variables) where qemu started checking this according to the spec. What this patch does is loosen the qemu ohci implementation to allow a zero-length packet if td.be (Buffer End) is set to td.cbp - 1, and with a non-zero td.cbp value. The spec is unclear whether this is valid or not -- it is not the clearly documented way to send a zero length TD (which is CBP=3DBE=3D0), but it isn't specifically forbidden. Actual hw seems to be ok with it. Does any OS rely on this behavior? There have been no reports to qemu-devel of this problem. This is attempting to have qemu behave like actual hardware, but this is just a minor change. With a tiny OS[1] that boots and executes a test, the issue can be seen: * OS that sends USB requests to a USB mass storage device but sends td.cbp =3D td.be + 1 * qemu 4.2 * qemu HEAD (4e66a0854) * Actual OHCI controller (hardware) Command line: qemu-system-x86_64 -m 20 \ -device pci-ohci,id=3Dohci \ -drive if=3Dnone,format=3Draw,id=3Dd,file=3Dtestmbr.raw \ -device usb-storage,bus=3Dohci.0,drive=3Dd \ --trace "usb_*" --trace "ohci_*" -D qemu.log Results are: qemu 4.2 | qemu HEAD | actual HW -----------+------------+----------- works fine | ohci_die() | works fine Tip: if the flags "-serial pty -serial stdio" are added to the command line the test will output USB requests like this: Testing qemu HEAD: > Free mem 2M ohci port2 conn FS > setup { 80 6 0 1 0 0 8 0 } > ED info=3D80000 { mps=3D8 en=3D0 d=3D0 } tail=3Dc20920 > td0 c20880 nxt=3Dc20960 f2000000 setup cbp=3Dc20900 be=3Dc20907 > td1 c20960 nxt=3Dc20980 f3140000 in cbp=3Dc20908 be=3Dc2090f > td2 c20980 nxt=3Dc20920 f3080000 out cbp=3Dc20910 be=3Dc2090f ohci20 = host err > usb stopped And in qemu.log: usb_ohci_iso_td_bad_cc_overrun ISO_TD start_offset=3D0x00c20910 > next_offs= et=3D0x00c2090f Testing qemu 4.2: > Free mem 2M ohci port2 conn FS > setup { 80 6 0 1 0 0 8 0 } > ED info=3D80000 { mps=3D8 en=3D0 d=3D0 } tail=3D620920 > td0 620880 nxt=3D620960 f2000000 setup cbp=3D620900 be=3D620907 c= bp=3D0 be=3D620907 > td1 620960 nxt=3D620980 f3140000 in cbp=3D620908 be=3D62090f c= bp=3D0 be=3D62090f > td2 620980 nxt=3D620920 f3080000 out cbp=3D620910 be=3D62090f c= bp=3D0 be=3D62090f > rx { 12 1 0 2 0 0 0 8 } > setup { 0 5 1 0 0 0 0 0 } tx {} > ED info=3D80000 { mps=3D8 en=3D0 d=3D0 } tail=3D620880 > td0 620920 nxt=3D620960 f2000000 setup cbp=3D620900 be=3D620907 c= bp=3D0 be=3D620907 > td1 620960 nxt=3D620880 f3100000 in cbp=3D620908 be=3D620907 c= bp=3D0 be=3D620907 > setup { 80 6 0 1 0 0 12 0 } > ED info=3D80001 { mps=3D8 en=3D0 d=3D1 } tail=3D620960 > td0 620880 nxt=3D6209c0 f2000000 setup cbp=3D620920 be=3D620927 c= bp=3D0 be=3D620927 > td1 6209c0 nxt=3D6209e0 f3140000 in cbp=3D620928 be=3D620939 c= bp=3D0 be=3D620939 > td2 6209e0 nxt=3D620960 f3080000 out cbp=3D62093a be=3D620939 c= bp=3D0 be=3D620939 > rx { 12 1 0 2 0 0 0 8 f4 46 1 0 0 0 1 2 3 1 } > setup { 80 6 0 2 0 0 0 1 } > ED info=3D80001 { mps=3D8 en=3D0 d=3D1 } tail=3D620880 > td0 620960 nxt=3D6209a0 f2000000 setup cbp=3D620a20 be=3D620a27 c= bp=3D0 be=3D620a27 > td1 6209a0 nxt=3D6209c0 f3140004 in cbp=3D620a28 be=3D620b27 c= bp=3D620a48 be=3D620b27 > td2 6209c0 nxt=3D620880 f3080000 out cbp=3D620b28 be=3D620b27 c= bp=3D0 be=3D620b27 > rx { 9 2 20 0 1 1 4 c0 0 9 4 0 0 2 8 6 50 0 7 5 81 2 40 0 0 7 5 2 2 40= 0 0 } > setup { 0 9 1 0 0 0 0 0 } tx {} > ED info=3D80001 { mps=3D8 en=3D0 d=3D1 } tail=3D620900 > td0 620880 nxt=3D620940 f2000000 setup cbp=3D620a00 be=3D620a07 c= bp=3D0 be=3D620a07 > td1 620940 nxt=3D620900 f3100000 in cbp=3D620a08 be=3D620a07 c= bp=3D0 be=3D620a07 [1] The OS disk image has been emailed to philmd@linaro.org, mjt@tls.msk.ru, and kraxel@redhat.com: * testCbpOffBy1.img.xz * sha256: f87baddcb86de845de12f002c698670a426affb40946025cc32694f9daa3abed Signed-off-by: David Hubbard Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/usb/hcd-ohci.c | 4 ++-- hw/usb/trace-events | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index acd60169802..71b54914d32 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@ -941,8 +941,8 @@ static int ohci_service_td(OHCIState *ohci, struct ohci= _ed *ed) if ((td.cbp & 0xfffff000) !=3D (td.be & 0xfffff000)) { len =3D (td.be & 0xfff) + 0x1001 - (td.cbp & 0xfff); } else { - if (td.cbp > td.be) { - trace_usb_ohci_iso_td_bad_cc_overrun(td.cbp, td.be); + if (td.cbp - 1 > td.be) { /* rely on td.cbp !=3D 0 */ + trace_usb_ohci_td_bad_buf(td.cbp, td.be); ohci_die(ohci); return 1; } diff --git a/hw/usb/trace-events b/hw/usb/trace-events index 46732717a95..dd04f14add1 100644 --- a/hw/usb/trace-events +++ b/hw/usb/trace-events @@ -29,6 +29,7 @@ usb_ohci_iso_td_data_underrun(int ret) "DataUnderrun %d" usb_ohci_iso_td_nak(int ret) "got NAK/STALL %d" usb_ohci_iso_td_bad_response(int ret) "Bad device response %d" usb_ohci_td_bad_pid(const char *s, uint32_t edf, uint32_t tdf) "Bad pid %s= : ed.flags 0x%x td.flags 0x%x" +usb_ohci_td_bad_buf(uint32_t cbp, uint32_t be) "Bad cbp =3D 0x%x > be =3D = 0x%x" usb_ohci_port_attach(int index) "port #%d" usb_ohci_port_detach(int index) "port #%d" usb_ohci_port_wakeup(int index) "port #%d" --=20 2.34.1