From nobody Mon Nov 25 04:40:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1718322177; cv=none; d=zohomail.com; s=zohoarc; b=GbK/wN/3Fxgnwoc0cKsm5fze6YI5njxUVzdyl95lixtZhoGt4tXpe+8mDkL6oca5Y9bIr16rRNmeXk1Skp/apcJCErS4DN6k0tXmECVxZgPXP4q/FWmoPYgVNDp3dptdehkZSDNek8DyL23KXMnbiMEpnCp9lihTBYCt/0ZC5+c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1718322177; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=+0KVE6y/18J9lK6KuLQsmigwJAN5jFZQNAjsdcsISBI=; b=YS6SGvpw68dlZP5/2m1xh/IFdynnN5nNfxdguuOieI7b2OWLkdfHmiq0MQOME0Lx+Yr43N65KyjyAsL2C6o3PXXXsQv6u3MCJXfCK5KX96WO/dIdF2FtI+a55vy42HN8xoHPQmACBb1IUtXn2e7eJTFuaQG8f4XAXsVgWkpJ9q4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17183221770361002.022992017823; Thu, 13 Jun 2024 16:42:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHu5n-0005yG-G4; Thu, 13 Jun 2024 19:42:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHu5l-0005o5-2u; Thu, 13 Jun 2024 19:42:53 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHu5j-0003zc-5d; Thu, 13 Jun 2024 19:42:52 -0400 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4W0f921SBRz6K62D; Fri, 14 Jun 2024 07:42:46 +0800 (CST) Received: from lhrpeml500001.china.huawei.com (unknown [7.191.163.213]) by mail.maildlp.com (Postfix) with ESMTPS id 10EC3140594; Fri, 14 Jun 2024 07:42:49 +0800 (CST) Received: from 00293818-MRGF.china.huawei.com (10.195.245.24) by lhrpeml500001.china.huawei.com (7.191.163.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 14 Jun 2024 00:42:26 +0100 To: , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH RFC V3 13/29] arm/virt: Make ARM vCPU *present* status ACPI *persistent* Date: Fri, 14 Jun 2024 00:36:23 +0100 Message-ID: <20240613233639.202896-14-salil.mehta@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240613233639.202896-1-salil.mehta@huawei.com> References: <20240613233639.202896-1-salil.mehta@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.195.245.24] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To lhrpeml500001.china.huawei.com (7.191.163.213) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.176.79.56; envelope-from=salil.mehta@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Salil Mehta From: Salil Mehta via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1718322177762100001 Content-Type: text/plain; charset="utf-8" ARM arch does not allow CPUs presence to be changed [1] after kernel has bo= oted. Hence, firmware/ACPI/Qemu must ensure persistent view of the vCPUs to the G= uest kernel even when they are not present in the QoM i.e. are unplugged or are yet-to-be-plugged References: [1] Check comment 5 in the bugzilla entry Link: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4481#c5 Signed-off-by: Salil Mehta --- cpu-common.c | 6 ++++++ hw/arm/virt.c | 7 +++++++ include/hw/core/cpu.h | 21 +++++++++++++++++++++ 3 files changed, 34 insertions(+) diff --git a/cpu-common.c b/cpu-common.c index 49d2a50835..e4b4dee99a 100644 --- a/cpu-common.c +++ b/cpu-common.c @@ -128,6 +128,12 @@ bool qemu_enabled_cpu(CPUState *cpu) return cpu && !cpu->disabled; } =20 +bool qemu_persistent_cpu(CPUState *cpu) +{ + /* cpu state can be faked to the guest via acpi */ + return cpu && cpu->acpi_persistent; +} + uint64_t qemu_get_cpu_archid(int cpu_index) { MachineState *ms =3D MACHINE(qdev_get_machine()); diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 5f98162587..9d33f30a6a 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -3016,6 +3016,13 @@ static void virt_cpu_pre_plug(HotplugHandler *hotplu= g_dev, DeviceState *dev, return; } virt_cpu_set_properties(OBJECT(cs), cpu_slot, errp); + + /* + * To give persistent presence view of vCPUs to the guest, ACPI might = need + * to fake the presence of the vCPUs to the guest but keep them disabl= ed. + * This shall be used during the init of ACPI Hotplug state and hot-un= plug + */ + cs->acpi_persistent =3D true; } =20 static void virt_cpu_plug(HotplugHandler *hotplug_dev, DeviceState *dev, diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 62e68611c0..e13e542177 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -540,6 +540,14 @@ struct CPUState { * every CPUState is enabled across all architectures. */ bool disabled; + /* + * On certain architectures, to provide a persistent view of the 'pres= ence' + * of vCPUs to the guest, ACPI might need to fake the 'presence' of the + * vCPUs but keep them ACPI-disabled for the guest. This is achieved by + * returning `_STA.PRES=3DTrue` and `_STA.Ena=3DFalse` for the unplugg= ed vCPUs + * in QEMU QoM. + */ + bool acpi_persistent; =20 /* TODO Move common fields from CPUArchState here. */ int cpu_index; @@ -959,6 +967,19 @@ bool qemu_present_cpu(CPUState *cpu); */ bool qemu_enabled_cpu(CPUState *cpu); =20 +/** + * qemu_persistent_cpu: + * @cpu: The vCPU to check + * + * Checks if the vCPU state should always be reflected as *present* via AC= PI + * to the Guest. By default, this is False on all architectures and has to= be + * explicity set during initialization. + * + * Returns: True if it is ACPI 'persistent' CPU + * + */ +bool qemu_persistent_cpu(CPUState *cpu); + /** * qemu_get_cpu_archid: * @cpu_index: possible vCPU for which arch-id needs to be retreived --=20 2.34.1