From nobody Fri Oct 25 19:34:36 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1718302969; cv=none; d=zohomail.com; s=zohoarc; b=gPnG4WqufJhEphWX6wTbDplbwF0GAe+xr25wAz1IrgT0ix6mLHBmi2+VRDoDT0UTn8Q0mOis5cJ6rFthJnslTwytorwjUUG+zQw+sf7/cER11PQNrpwmiDhne8pb/TsDFCrBfq7oGCTsKN+/Jl0ENCyW8IQc5fYCIbxssf1enzA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1718302969; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kCpo0zZ6kE/Q+vBxYhhWYBls384Ap/5dTXIlSCzJozk=; b=FnelIeOzjx4iSsL/W9Ru5sNUmZWLMj8jvo5Tpqinq1QqBjD6QLXaTTIlaZw6c6hK2y1pxtW+oVRtTdqxL8EX9DOkSFDdM3GxrP0QhUgelR2AnN9T16TsIf05FUt+m6shQrmqRkb1U6P7R8DSXXa9pHVcWFJOu1q5TzA6XSiUL88= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1718302969325426.9561826286533; Thu, 13 Jun 2024 11:22:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHp5V-000693-O6; Thu, 13 Jun 2024 14:22:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHp5U-00068p-A2 for qemu-devel@nongnu.org; Thu, 13 Jun 2024 14:22:16 -0400 Received: from mail-il1-x12c.google.com ([2607:f8b0:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHp5R-0007TQ-Uu for qemu-devel@nongnu.org; Thu, 13 Jun 2024 14:22:16 -0400 Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-375df5af253so1828575ab.0 for ; Thu, 13 Jun 2024 11:22:13 -0700 (PDT) Received: from taylor-ubuntu.hsd1.co.comcast.net (c-73-169-12-54.hsd1.co.comcast.net. [73.169.12.54]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4b95674315fsm485444173.0.2024.06.13.11.22.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 11:22:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718302932; x=1718907732; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kCpo0zZ6kE/Q+vBxYhhWYBls384Ap/5dTXIlSCzJozk=; b=Y+hbZq2vKwrWZ0mXdC+qthITBgKUO4AeaupG6+gs0sHygjsRV87fQJ0mMFjPuE8KWX DwWEZHaYmckvH1HoC2Nr94Dg0Ur75vn4UmlYWedpyqgliJvhw2QWRKDWA+4HhBNlB8pg YbdsXzMaPNA/VAsD0eWwodyGApgUd1735OcbGWtu4I6hKUDhIzB91J15bKvCZvA9IdF4 ppQSOAWzdsNQ7FNOdxOlGlF+UOx0xyiaC31XtKT8Xlm7AJUcCJYLqvC3iYYbEOCsz5vh y3z10Vrkhyr1O+mzVwrymAMFZw7k9I9zm7mqF2O9ifm6qDjlz0pNeAir5NKwfDJ8y61g IYdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718302932; x=1718907732; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kCpo0zZ6kE/Q+vBxYhhWYBls384Ap/5dTXIlSCzJozk=; b=f3NGjblFP/UnRtPCVlpvZ+biuUrk/6RggRy9vmXG0Fj2l6GINw8tu8qegYY7UzENDA ddI19DeSCNzEV+HtsVQlbFc4snrnJXjwh3sLbh7sPlJ4HkVw5QUK/X6qWFaLBVPkEdIX F2nxNsAPEb8+aNmozh0wEAKN8arXcpS1qX7IpQdYb3pCRIQSc0Sjzy8IW32pghovd4Dh wu6EMrYnbnsDtdwp3vUd4g4Sbv49Dz89RY40+pJnHQogRPZUr6bQfkBt1G82/4SXG2Sk LmSzad8igs1aOK7e6WT4hCrkW0xpKOBcv76xDVBsY7q4G0TM+I9hq0J46yQo1JL0ZxN8 zBYg== X-Gm-Message-State: AOJu0YwR9jq42Pv0zER+OtgvtKPA0JF18Wz+FllbXJ53wfGfB/Awj2MP POllC9+d2mTu9Y+ECTx6QEH6yum1SzOYyt5ERiJ72BtpI0FRHzS/EiMyNjoY X-Google-Smtp-Source: AGHT+IH5HrA90eEROcFvON8jC8a8mi6TElns9kMF/3pi6zfDAoxVzZoTcqK1WxwzqR88JdcPfAi8aA== X-Received: by 2002:a05:6e02:1a8a:b0:375:86c9:9ec9 with SMTP id e9e14a558f8ab-375e0e2865bmr4059495ab.11.1718302931669; Thu, 13 Jun 2024 11:22:11 -0700 (PDT) From: Taylor Simpson To: qemu-devel@nongnu.org Cc: bcain@quicinc.com, tedwood@quicinc.com, alex.benee@linaro.org, quic_mathbern@quicinc.com, sidneym@quicinc.com, quic_mliebel@quicinc.com, richard.henderson@linaro.org, philmd@linaro.org, ale@rev.ng, anjo@rev.ng, ltaylorsimpson@gmail.com Subject: [PATCH v2] Hexagon: lldb read/write predicate registers p0/p1/p2/p3 Date: Thu, 13 Jun 2024 12:22:09 -0600 Message-Id: <20240613182209.140082-1-ltaylorsimpson@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::12c; envelope-from=ltaylorsimpson@gmail.com; helo=mail-il1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1718302970277100001 hexagon-core.xml only exposes register p3_0 which is an alias that aggregates the predicate registers. It is more convenient for users to interact directly with the predicate registers. Tested with lldb downloaded from this location https://github.com/llvm/llvm-project/releases/download/llvmorg-18.1.4/clang= +llvm-18.1.4-x86_64-linux-gnu-ubuntu-18.04.tar.xz BEFORE: (lldb) reg read p3_0 p3_0 =3D 0x00000000 (lldb) reg read p0 error: Invalid register name 'p0'. (lldb) reg write p1 0xf error: Register not found for 'p1'. AFTER: (lldb) reg read p3_0 p3_0 =3D 0x00000000 (lldb) reg read p0 p0 =3D 0x00 (lldb) reg read -s 1 Predicate Registers: p0 =3D 0x00 p1 =3D 0x00 p2 =3D 0x00 p3 =3D 0x00 (lldb) reg write p1 0xf (lldb) reg read p3_0 p3_0 =3D 0x00000f00 (lldb) reg write p3_0 0xff00ff00 (lldb) reg read -s 1 Predicate Registers: p0 =3D 0x00 p1 =3D 0xff p2 =3D 0x00 p3 =3D 0xff Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain Reviewed-by: Matheus Tavares Bernardino --- target/hexagon/gdbstub.c | 19 ++++++++++++++++++- gdb-xml/hexagon-core.xml | 6 +++++- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/target/hexagon/gdbstub.c b/target/hexagon/gdbstub.c index 502c6987f0..94e1db8ef8 100644 --- a/target/hexagon/gdbstub.c +++ b/target/hexagon/gdbstub.c @@ -1,5 +1,5 @@ /* - * Copyright(c) 2019-2021 Qualcomm Innovation Center, Inc. All Rights Res= erved. + * Copyright(c) 2019-2024 Qualcomm Innovation Center, Inc. All Rights Res= erved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -36,6 +36,14 @@ int hexagon_gdb_read_register(CPUState *cs, GByteArray *= mem_buf, int n) return gdb_get_regl(mem_buf, env->gpr[n]); } =20 + n -=3D TOTAL_PER_THREAD_REGS; + + if (n < NUM_PREGS) { + return gdb_get_reg8(mem_buf, env->pred[n]); + } + + n -=3D NUM_PREGS; + g_assert_not_reached(); } =20 @@ -56,6 +64,15 @@ int hexagon_gdb_write_register(CPUState *cs, uint8_t *me= m_buf, int n) return sizeof(target_ulong); } =20 + n -=3D TOTAL_PER_THREAD_REGS; + + if (n < NUM_PREGS) { + env->pred[n] =3D ldtul_p(mem_buf) & 0xff; + return sizeof(uint8_t); + } + + n -=3D NUM_PREGS; + g_assert_not_reached(); } =20 diff --git a/gdb-xml/hexagon-core.xml b/gdb-xml/hexagon-core.xml index e181163cff..b94378112a 100644 --- a/gdb-xml/hexagon-core.xml +++ b/gdb-xml/hexagon-core.xml @@ -1,6 +1,6 @@