From nobody Mon Nov 25 02:52:14 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1718299367; cv=none; d=zohomail.com; s=zohoarc; b=ddKC0k09h/rjU2GmuYTdI/xCnuSNYaO7EQ1r4DFzj2yi+gwJpXNsE7IVthGDkhoT9YscQIkEO2C2vgiHOOls/+2Z+vndIx/bzNdhj/STVWZCKaedFwXZu/jQoarwYxdrXwbCd8b70apz74qB1YBX67R4JA1lqYy4NsBBlbMtByw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1718299367; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PquiuMp1JH1T0sH0/rv5hP1UkVOfgmDk9Oiumx90w18=; b=NkZ2rG/t9L8o+NAKLW1czsv7rsJLLG0RNHD11ftltLJ3kVUqH29TsYU6aAtcaVeyczDhxdrGf84KMTgp9f1Ka/w3rCn3//DjcM097XpXgDE3W0RuSCe9+GyheAZEEpkZjRzgy1SUdRLGHM6FtrNkdgO8hgN0pVswdfyMRE6q9IQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1718299367302750.0484993581574; Thu, 13 Jun 2024 10:22:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHo91-0000kc-IO; Thu, 13 Jun 2024 13:21:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHo90-0000k7-8J for qemu-devel@nongnu.org; Thu, 13 Jun 2024 13:21:50 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHo8y-0005rh-4g for qemu-devel@nongnu.org; Thu, 13 Jun 2024 13:21:50 -0400 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1f7028196f2so11157565ad.2 for ; Thu, 13 Jun 2024 10:21:47 -0700 (PDT) Received: from amd.. ([2804:7f0:b400:8dcb:3e7c:3fff:fe7a:e83b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855e5b85bsm16443885ad.32.2024.06.13.10.21.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 10:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718299306; x=1718904106; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PquiuMp1JH1T0sH0/rv5hP1UkVOfgmDk9Oiumx90w18=; b=bkH+qrw7Lk/StkKFrgJvx7QYmA/d6qH0anJ/h6klr6a1+sirm3aJl/z8kDK4c4aXth 4rxSzdc06aDzviFyV3a8TPMx6opgXU7yxFwMfwZJ3kMOmkoWDuTNlnxEPJ/YHUGbJVrf nR3TyQes9hvxChp8luyK1PjBZ1rdFWbAEHx8VRU62AUgmn6QlfeTGu8yOMCgjzasJSkX 7qFik2y7TUeifDU7+WD49xoIwO+KxfEpmrawOYwp5sH03HT0a14BJLmbQ0KcwL/CxkDd ZMP+LE7p3eT6K/+QdkcCZ8iSqg27RxMOABQ2lLc9OB5m1uhzq30ISor2xbUGbeOEd5EG qS2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718299306; x=1718904106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PquiuMp1JH1T0sH0/rv5hP1UkVOfgmDk9Oiumx90w18=; b=BcVIa9OR2daJbXUbYhS921K/LsPWc8goHQn4LXx1/VQkan9kOdf0pTEcN1luHcQG7F e3kvpKFReRrMHBfiGFr+aE4LJ9M477BeTNGpdRe4GdBOoqvwGVE/c9dSxoF96YX7heN7 zDQDUupDLR+0hNe1GH6pCFO0aeZd8EEd52Z4g9+H5uXxBgS2ccnYMdm1fW6LPA2+I2qL wO5r3+yQrVNmhcDm0xCDwMCKBOEN03PVVOGL3o7Z1T4aYGsQJISMWX2iEXatp2rB+vs7 2eHNyJZMNuX6Kj4q2X4JDMJKnawV1r7XDsVtRCgrjjJGZohvuRTP/hHPwpj2y+z6Ox+c V3sA== X-Gm-Message-State: AOJu0YzXTEsLM3zxeJwrlnoOwmHZtJ5Bwrh94fsNlrhjbQ1q4Jseq89V KYuPTBka8F41wVYQn5YP9OaNR0/g7l9NpTWItEdsIwdzvA4doFCl6P0h44m8p4iWPrxQhlE9CDR W X-Google-Smtp-Source: AGHT+IHwnWXARqUHIY2AZcW4+VPaOi0tuovceA1R1hFlgoDlEuCmUyEKDSa//ApjJplGtovmgsRtsw== X-Received: by 2002:a17:902:f545:b0:1f7:1ba5:85ff with SMTP id d9443c01a7336-1f8629fee71mr2807435ad.57.1718299306474; Thu, 13 Jun 2024 10:21:46 -0700 (PDT) From: Gustavo Romero To: qemu-devel@nongnu.org, philmd@linaro.org, peter.maydell@linaro.org, alex.bennee@linaro.org, richard.henderson@linaro.org Cc: gustavo.romero@linaro.org Subject: [PATCH v2 9/9] tests/tcg/aarch64: Add MTE gdbstub tests Date: Thu, 13 Jun 2024 17:21:03 +0000 Message-Id: <20240613172103.2987519-10-gustavo.romero@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240613172103.2987519-1-gustavo.romero@linaro.org> References: <20240613172103.2987519-1-gustavo.romero@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=gustavo.romero@linaro.org; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1718299368466100007 Content-Type: text/plain; charset="utf-8" Add tests to exercise the MTE stubs. Signed-off-by: Gustavo Romero --- tests/tcg/aarch64/Makefile.target | 11 ++- tests/tcg/aarch64/gdbstub/test-mte.py | 86 ++++++++++++++++++++++ tests/tcg/aarch64/mte-8.c | 102 ++++++++++++++++++++++++++ 3 files changed, 197 insertions(+), 2 deletions(-) create mode 100644 tests/tcg/aarch64/gdbstub/test-mte.py create mode 100644 tests/tcg/aarch64/mte-8.c diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile= .target index 70d728ae9a..d2e3f251eb 100644 --- a/tests/tcg/aarch64/Makefile.target +++ b/tests/tcg/aarch64/Makefile.target @@ -62,7 +62,7 @@ AARCH64_TESTS +=3D bti-2 =20 # MTE Tests ifneq ($(CROSS_CC_HAS_ARMV8_MTE),) -AARCH64_TESTS +=3D mte-1 mte-2 mte-3 mte-4 mte-5 mte-6 mte-7 +AARCH64_TESTS +=3D mte-1 mte-2 mte-3 mte-4 mte-5 mte-6 mte-7 mte-8 mte-%: CFLAGS +=3D -march=3Darmv8.5-a+memtag endif =20 @@ -127,7 +127,14 @@ run-gdbstub-sve-ioctls: sve-ioctls --bin $< --test $(AARCH64_SRC)/gdbstub/test-sve-ioctl.py, \ basic gdbstub SVE ZLEN support) =20 -EXTRA_RUNS +=3D run-gdbstub-sysregs run-gdbstub-sve-ioctls +run-gdbstub-mte: mte-8 + $(call run-test, $@, $(GDB_SCRIPT) \ + --gdb $(GDB) \ + --qemu $(QEMU) --qargs "$(QEMU_OPTS)" \ + --bin "$< -s" --test $(AARCH64_SRC)/gdbstub/test-mte.py, \ + gdbstub MTE support) + +EXTRA_RUNS +=3D run-gdbstub-sysregs run-gdbstub-sve-ioctls run-gdbstub-mte endif endif =20 diff --git a/tests/tcg/aarch64/gdbstub/test-mte.py b/tests/tcg/aarch64/gdbs= tub/test-mte.py new file mode 100644 index 0000000000..ec49eb8d2b --- /dev/null +++ b/tests/tcg/aarch64/gdbstub/test-mte.py @@ -0,0 +1,86 @@ +from __future__ import print_function +# +# Test GDB memory-tag commands that exercise the stubs for the qIsAddressT= agged, +# qMemTag, and QMemTag packets. Logical tag-only commands rely on local +# operations, hence don't exercise any stub. +# +# The test consists in breaking just after a atag() call (which sets the +# allocation tag -- see mte-8.c for details) and setting/getting tags in +# different memory locations and ranges starting at the address of the arr= ay +# 'a'. +# +# This is launched via tests/guest-debug/run-test.py +# + + +import gdb +import re +from test_gdbstub import main, report + + +PATTERN_0 =3D "Memory tags for address 0x[0-9a-f]+ match \(0x[0-9a-f]+\)." +PATTERN_1 =3D ".*(0x[0-9a-f]+)" + + +def run_test(): + gdb.execute("break 99", False, True) + gdb.execute("continue", False, True) + try: + # Test if we can check correctly that the allocation tag for + # array 'a' matches the logical tag after atag() is called. + co =3D gdb.execute("memory-tag check a", False, True) + tags_match =3D re.findall(PATTERN_0, co, re.MULTILINE) + if tags_match: + report(True, f"{tags_match[0]}") + else: + report(False, "Logical and allocation tags don't match!") + + # Test allocation tag 'set and print' commands. Commands on logical + # tags rely on local operation and so don't exercise any stub. + + # Set the allocation tag for the first granule (16 bytes) of + # address starting at 'a' address to a known value, i.e. 0x04. + gdb.execute("memory-tag set-allocation-tag a 1 04", False, True) + + # Then set the allocation tag for the second granule to a known + # value, i.e. 0x06. This tests that contiguous tag granules are + # set correct and don't run over each other. + gdb.execute("memory-tag set-allocation-tag a+16 1 06", False, True) + + # Read the known values back and check if they remain the same. + + co =3D gdb.execute("memory-tag print-allocation-tag a", False, Tru= e) + first_tag =3D re.match(PATTERN_1, co)[1] + + co =3D gdb.execute("memory-tag print-allocation-tag a+16", False, = True) + second_tag =3D re.match(PATTERN_1, co)[1] + + if first_tag =3D=3D "0x4" and second_tag =3D=3D "0x6": + report(True, "Allocation tags are correctly set/printed.") + else: + report(False, "Can't set/print allocation tags!") + + # Now test fill pattern by setting a whole page with a pattern. + gdb.execute("memory-tag set-allocation-tag a 4096 0a0b", False, Tr= ue) + + # And read back the tags of the last two granules in page so + # we also test if the pattern is set correctly up to the end of + # the page. + co =3D gdb.execute("memory-tag print-allocation-tag a+4096-32", Fa= lse, True) + tag =3D re.match(PATTERN_1, co)[1] + + co =3D gdb.execute("memory-tag print-allocation-tag a+4096-16", Fa= lse, True) + last_tag =3D re.match(PATTERN_1, co)[1] + + if tag =3D=3D "0xa" and last_tag =3D=3D "0xb": + report(True, "Fill pattern is ok.") + else: + report(False, "Fill pattern failed!") + + except gdb.error: + # This usually happens because a GDB version that does not + # support memory tagging was used to run the test. + report(False, "'memory-tag' command failed!") + + +main(run_test, expected_arch=3D"aarch64") diff --git a/tests/tcg/aarch64/mte-8.c b/tests/tcg/aarch64/mte-8.c new file mode 100644 index 0000000000..367768e6b6 --- /dev/null +++ b/tests/tcg/aarch64/mte-8.c @@ -0,0 +1,102 @@ +/* + * To be compiled with -march=3Darmv8.5-a+memtag + * + * This test is adapted from a Linux test. Please see: + * + * https://www.kernel.org/doc/html/next/arch/arm64/memory-tagging-extensio= n.html#example-of-correct-usage + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +/* + * From arch/arm64/include/uapi/asm/hwcap.h + */ +#define HWCAP2_MTE (1 << 18) + +/* + * From arch/arm64/include/uapi/asm/mman.h + */ +#define PROT_MTE 0x20 + +/* + * Insert a random logical tag into the given pointer. + */ +#define insert_random_tag(ptr) ({ \ + uint64_t __val; \ + asm("irg %0, %1" : "=3Dr" (__val) : "r" (ptr)); \ + __val; \ +}) + +/* + * Set the allocation tag on the destination address. + */ +#define set_tag(tagged_addr) do { \ + asm volatile("stg %0, [%0]" : : "r" (tagged_addr) : "memory"); \ +} while (0) + + +int main(int argc, char *argv[]) +{ + unsigned char *a; + unsigned long page_sz =3D sysconf(_SC_PAGESIZE); + unsigned long hwcap2 =3D getauxval(AT_HWCAP2); + + if (!(argc =3D=3D 2 && strcmp(argv[1], "-s") =3D=3D 0)) { + return 0; + } + + /* check if MTE is present */ + if (!(hwcap2 & HWCAP2_MTE)) + return EXIT_FAILURE; + + /* + * Enable the tagged address ABI, synchronous or asynchronous MTE + * tag check faults (based on per-CPU preference) and allow all + * non-zero tags in the randomly generated set. + */ + if (prctl(PR_SET_TAGGED_ADDR_CTRL, + PR_TAGGED_ADDR_ENABLE | PR_MTE_TCF_SYNC | PR_MTE_TCF_ASYNC | + (0xfffe << PR_MTE_TAG_SHIFT), + 0, 0, 0)) { + perror("prctl() failed"); + return EXIT_FAILURE; + } + + a =3D mmap(0, page_sz, PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + if (a =3D=3D MAP_FAILED) { + perror("mmap() failed"); + return EXIT_FAILURE; + } + + printf("a[] address is %p\n", a); + + /* + * Enable MTE on the above anonymous mmap. The flag could be passed + * directly to mmap() and skip this step. + */ + if (mprotect(a, page_sz, PROT_READ | PROT_WRITE | PROT_MTE)) { + perror("mprotect() failed"); + return EXIT_FAILURE; + } + + /* access with the default tag (0) */ + a[0] =3D 1; + a[1] =3D 2; + + printf("a[0] =3D %hhu a[1] =3D %hhu\n", a[0], a[1]); + + /* set the logical and allocation tags */ + a =3D (unsigned char *)insert_random_tag(a); + set_tag(a); + + printf("%p\n", a); + + return 0; +} --=20 2.34.1