From nobody Mon Nov 25 01:41:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=swemel.ru ARC-Seal: i=1; a=rsa-sha256; t=1718289598; cv=none; d=zohomail.com; s=zohoarc; b=VKKvowZVjCZ6BprI89qLUCSTqYnKJtHRK7BBsc3mPGv9/d4g9dVr0+pIfMOb9O6B1zD+YN5VYs2eeanYbpo5Z3bsKPbuknBIOpVxQCQ0A+HkCB2KFGfc8iERAt6vwIpOM47p9qCuNerzFrvFo280KKaoB6ov5zn5JL852h7goB0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1718289598; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=i/77icK6mJkKkLEes/QqYC63apt9ksn6Cppnf30pEcA=; b=bc4fq5C86hV8ttLpw/F4yYM7/i35ZTK1kBVWZjmtvOsM6+eEBfE3Qrmvszqq2Dv3ttcABV1SHJRw1GQAXYBAzAAFcOItdyalwaotaNSmpzeXv7Q/LYOGPSjrKTzhkm7B/4jjllNVMFuMMeapBYCGQlscxb1sU6B7pBD306AP3Pc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1718289597477688.9419079705535; Thu, 13 Jun 2024 07:39:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHlbY-0005KJ-Fp; Thu, 13 Jun 2024 10:39:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHlbU-0005Jn-Vg for qemu-devel@nongnu.org; Thu, 13 Jun 2024 10:39:04 -0400 Received: from mx.swemel.ru ([95.143.211.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHlbR-0007Um-2B for qemu-devel@nongnu.org; Thu, 13 Jun 2024 10:39:04 -0400 From: Dmitry Frolov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1718289535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=i/77icK6mJkKkLEes/QqYC63apt9ksn6Cppnf30pEcA=; b=SOwSJ/wNHmcZqjfLkKAiy8uHp8ctVeWc+sMfEk40/jsCBrNS/P0ImcLIV/SG0a+DBfIwNq 7b0bsT21MfkYY8/uaCIzOFTHICUV9u6sEZ+bbtIhBenSbQgpYIU8KTVqCIuFnhahc9bEsB 3UUaIXwAR3oQ5Y4kQDpfIY9BGDve8Eg= To: mst@redhat.com Cc: sdl.qemu@linuxtesting.org, qemu-devel@nongnu.org, Dmitry Frolov Subject: [PATCH v3] hw/net/virtio-net.c: fix crash in iov_copy() Date: Thu, 13 Jun 2024 17:35:30 +0300 Message-ID: <20240613143529.602591-2-frolov@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=95.143.211.150; envelope-from=frolov@swemel.ru; helo=mx.swemel.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @swemel.ru) X-ZM-MESSAGEID: 1718289605291100001 Content-Type: text/plain; charset="utf-8" A crash found while fuzzing device virtio-net-socket-check-used. Assertion "offset =3D=3D 0" in iov_copy() fails if less than guest_hdr_len = bytes were transmited. Signed-off-by: Dmitry Frolov Reviewed-by: Michael S. Tsirkin --- v1: https://patchew.org/QEMU/20240527133140.218300-2-frolov@swemel.ru/ v2: broken v3: goto instead of repeating code --- hw/net/virtio-net.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 9c7e85caea..8f30972708 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -2735,6 +2735,10 @@ static int32_t virtio_net_flush_tx(VirtIONetQueue *q) */ assert(n->host_hdr_len <=3D n->guest_hdr_len); if (n->host_hdr_len !=3D n->guest_hdr_len) { + if (iov_size(out_sg, out_num) < n->guest_hdr_len) { + virtio_error(vdev, "virtio-net header is invalid"); + goto detach; + } unsigned sg_num =3D iov_copy(sg, ARRAY_SIZE(sg), out_sg, out_num, 0, n->host_hdr_len); --=20 2.43.0