From nobody Mon Nov 25 07:44:59 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1717486783; cv=none; d=zohomail.com; s=zohoarc; b=LDQD/SP7xSTLF+FJz2yfnEwoHEiXeAPCHwIRuaP2+bSIQodjZ7EuyTun0xQNWUArFwXQtJHQXKp1bFUPYeLFGiaI77D7qwcGn4t6+J2W45ra3X5ErN/iowQwy43BRyvsCaeAGoE0sas+SW8pI9HcSPp9iLDZ21IIGpa/NymNEdo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1717486783; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ja8wt4NEc3iEA/jlkH1B8whZ/a9+UOEgw14GUxqaDuo=; b=FSI8HZwkLtSA+1VZbDCPiZv2m6SnvhDjMpJ2NEWDl6i0TxctPgjIKvPVrY1ppQuhyE/iClq4oDoobFW/g3II5jNOYSv50UX9YZ5wTDKaJ28hS9zhkv564GSw78+vODZw76D/JYf82mZbNzPErmJFYw5j+U0YprPVqbF7xJmc3WY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1717486783861462.71517057508106; Tue, 4 Jun 2024 00:39:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEOkb-00008T-VH; Tue, 04 Jun 2024 03:38:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEOkZ-0008Sx-Nm for qemu-devel@nongnu.org; Tue, 04 Jun 2024 03:38:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEOkY-0006Kb-6R for qemu-devel@nongnu.org; Tue, 04 Jun 2024 03:38:31 -0400 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-5wb8On6BPKOD9ebSlNyIgw-1; Tue, 04 Jun 2024 03:38:20 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EDA123C025CE; Tue, 4 Jun 2024 07:38:19 +0000 (UTC) Received: from localhost.localdomain (unknown [10.72.112.238]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DE5B492BD4; Tue, 4 Jun 2024 07:38:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717486709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ja8wt4NEc3iEA/jlkH1B8whZ/a9+UOEgw14GUxqaDuo=; b=APCFXkecxr+cvjR44xh2b7iYFTlLeCYmUh3+uCYFkUN3xCWjsaZesjQqONpfzEoNPz6qbh mkK4U4qQqgvAQsgpEafaTA9MfCX4AKT/QeVFHHtr2lWXDKpHA9M+WtosIinOFrSty9sZ6I 1NNIjdFXAQXF+37LYy1ObhCVyw79SQY= X-MC-Unique: 5wb8On6BPKOD9ebSlNyIgw-1 From: Jason Wang To: peter.maydell@linaro.org, qemu-devel@nongnu.org Cc: Akihiko Odaki , Jason Wang Subject: [PULL 06/20] tap: Shrink zeroed virtio-net header Date: Tue, 4 Jun 2024 15:37:41 +0800 Message-ID: <20240604073755.1859-7-jasowang@redhat.com> In-Reply-To: <20240604073755.1859-1-jasowang@redhat.com> References: <20240604073755.1859-1-jasowang@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1717486784168100001 Content-Type: text/plain; charset="utf-8" From: Akihiko Odaki tap prepends a zeroed virtio-net header when writing a packet to a tap with virtio-net header enabled but not in use. This only happens when s->host_vnet_hdr_len =3D=3D sizeof(struct virtio_net_hdr). Signed-off-by: Akihiko Odaki Signed-off-by: Jason Wang --- net/tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tap.c b/net/tap.c index 9825518ff1..51f7aec39d 100644 --- a/net/tap.c +++ b/net/tap.c @@ -119,7 +119,7 @@ static ssize_t tap_receive_iov(NetClientState *nc, cons= t struct iovec *iov, TAPState *s =3D DO_UPCAST(TAPState, nc, nc); const struct iovec *iovp =3D iov; g_autofree struct iovec *iov_copy =3D NULL; - struct virtio_net_hdr_mrg_rxbuf hdr =3D { }; + struct virtio_net_hdr hdr =3D { }; =20 if (s->host_vnet_hdr_len && !s->using_vnet_hdr) { iov_copy =3D g_new(struct iovec, iovcnt + 1); --=20 2.42.0