From nobody Tue Nov 18 16:07:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1716890177; cv=none; d=zohomail.com; s=zohoarc; b=NdhPXVB9K0d/SmWqsRwq4/ZD4B42ToR6kxqHf0qldH9RfTSYWR0qe7SvzkSXG/2lXCCyrKO/p2KnPLFcj+fEpmzilOPgw1V8NIe4GHXbvtNhu3v7Drdp6X3BgmLKO5jH9bnzzb9jM80NXXHu2tKRa6pGiZkeIFW3Mk5GaSTmxMQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716890177; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Md1MVArHUd05WOeyAIhNVCIfQzrbfrJLv5muxML0fkM=; b=PpT7x4mXaYzOcCXJLDnD6rl2+oD4HmI056PRysNT6T9BIY1jSW0LtkiQXydli1O36U2mFfzwn0Mm/XB424N4UuenVeNmYY1QUIeZCADor0mGveEfsd7kg/HnaGttNAUeLjiIJJmxOB9tBqa47Ric82DkkkvpQ4usSwj2SA+wHhs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716890177775536.7192877809327; Tue, 28 May 2024 02:56:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBtXz-0008AP-7Z; Tue, 28 May 2024 05:55:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBtXw-000881-EB for qemu-devel@nongnu.org; Tue, 28 May 2024 05:55:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBtXu-0001RM-6g for qemu-devel@nongnu.org; Tue, 28 May 2024 05:55:07 -0400 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-CCX3byV-OxSXCRpd5gx7vw-1; Tue, 28 May 2024 05:55:02 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0355B29AA390; Tue, 28 May 2024 09:55:02 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 738911C00047; Tue, 28 May 2024 09:55:00 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id DD0BC1800DCA; Tue, 28 May 2024 11:54:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716890104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Md1MVArHUd05WOeyAIhNVCIfQzrbfrJLv5muxML0fkM=; b=E37cjacs/+U3gzCvacHES/9atABoeBKsmWtXY6oHBcRoYOaa42JpHu8zTEBKltEXKiIcst fagh1dcoMQ48GfISjKbY7PRTvz05s19pm801KZUlaR0wAsCFslheyJ/m2p5HRIM6Bg3ekA ENpmUl8/CDSEXfI6BYYYpG7N0IrLxiU= X-MC-Unique: CCX3byV-OxSXCRpd5gx7vw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Markus Armbruster , Paolo Bonzini , Eric Blake , Eduardo Habkost , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 1/4] qom: allow to mark objects (including devices) as deprecated. Date: Tue, 28 May 2024 11:54:56 +0200 Message-ID: <20240528095459.896594-2-kraxel@redhat.com> In-Reply-To: <20240528095459.896594-1-kraxel@redhat.com> References: <20240528095459.896594-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.034, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1716890178889100005 Content-Type: text/plain; charset="utf-8" Add deprecation_note field (string) to ObjectClass. Add deprecated bool to ObjectTypeInfo, report in 'qom-list-types'. Print the note when listing devices via '-device help'. Signed-off-by: Gerd Hoffmann --- include/qom/object.h | 1 + qom/qom-qmp-cmds.c | 4 ++++ system/qdev-monitor.c | 5 +++++ qapi/qom.json | 4 +++- 4 files changed, 13 insertions(+), 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/object.h index 13d3a655ddf9..6c682aa0135f 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@ -136,6 +136,7 @@ struct ObjectClass ObjectUnparent *unparent; =20 GHashTable *properties; + const char *deprecation_note; }; =20 /** diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c index e91a2353472a..43de9c9ae141 100644 --- a/qom/qom-qmp-cmds.c +++ b/qom/qom-qmp-cmds.c @@ -101,6 +101,10 @@ static void qom_list_types_tramp(ObjectClass *klass, v= oid *data) if (parent) { info->parent =3D g_strdup(object_class_get_name(parent)); } + if (klass->deprecation_note) { + info->has_deprecated =3D true; + info->deprecated =3D true; + } =20 QAPI_LIST_PREPEND(*pret, info); } diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c index 6af6ef7d667f..704be312e1a7 100644 --- a/system/qdev-monitor.c +++ b/system/qdev-monitor.c @@ -144,6 +144,8 @@ static bool qdev_class_has_alias(DeviceClass *dc) =20 static void qdev_print_devinfo(DeviceClass *dc) { + ObjectClass *klass =3D OBJECT_CLASS(dc); + qemu_printf("name \"%s\"", object_class_get_name(OBJECT_CLASS(dc))); if (dc->bus_type) { qemu_printf(", bus %s", dc->bus_type); @@ -157,6 +159,9 @@ static void qdev_print_devinfo(DeviceClass *dc) if (!dc->user_creatable) { qemu_printf(", no-user"); } + if (klass->deprecation_note) { + qemu_printf(", deprecated \"%s\"", klass->deprecation_note); + } qemu_printf("\n"); } =20 diff --git a/qapi/qom.json b/qapi/qom.json index 38dde6d785ac..bd062feabaf7 100644 --- a/qapi/qom.json +++ b/qapi/qom.json @@ -163,10 +163,12 @@ # # @parent: Name of parent type, if any (since 2.10) # +# @deprecated: the type is deprecated (since 9.1) +# # Since: 1.1 ## { 'struct': 'ObjectTypeInfo', - 'data': { 'name': 'str', '*abstract': 'bool', '*parent': 'str' } } + 'data': { 'name': 'str', '*abstract': 'bool', '*parent': 'str', '*deprec= ated': 'bool' } } =20 ## # @qom-list-types: --=20 2.45.1 From nobody Tue Nov 18 16:07:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1716890177; cv=none; d=zohomail.com; s=zohoarc; b=S01uM4AIabXHG0iwMROGIMsLsqrwIBYWWuKgBEQKlJ9Q1Q4lo/G/CaUQFhnuHhqv+LTTY/IjuK7awC2IRU+6obK8auMAdMsIk6BgWEO/cZsRubXYGwBhAWxwuK/1BI1EmuOSWFsjt7UAMlsllh+1n1rt0BYdQ2mt6oAPKAZF4TI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716890177; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cFTCmUFTq0etV9FkONdvPeX/q8fDJcblUNNL6MpibeY=; b=DvV4onyrSPj4Pqg6nhtuLCFfy39zUcJFdRq4AuOE3rB5qt0H+vGXKHZJFG9AClejh2RE5Z+B9J/qK5ecTe5gnT10kja+8SSI/h8jFym8dzT0rZuK2GudqglKW1B+GF/fssMVhKsMU/+Vey8yBR6F1d+OBSwN4rowB8RZ+p0haXk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716890177630869.0688642833614; Tue, 28 May 2024 02:56:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBtY8-0008CD-SI; Tue, 28 May 2024 05:55:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBtY7-0008Bt-Sm for qemu-devel@nongnu.org; Tue, 28 May 2024 05:55:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBtXv-0001Rf-TH for qemu-devel@nongnu.org; Tue, 28 May 2024 05:55:19 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-yqYPJChMNLa2NlmKynpSsg-1; Tue, 28 May 2024 05:55:03 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 949D7101A525; Tue, 28 May 2024 09:55:03 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EF6FC15BB9; Tue, 28 May 2024 09:55:03 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id EDC2C1800DDA; Tue, 28 May 2024 11:54:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716890106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cFTCmUFTq0etV9FkONdvPeX/q8fDJcblUNNL6MpibeY=; b=MMNFU/smj8uo1A5y5p9MWraxea7WcojCeH3xko0dS6N2NWBrEfd5EfXRwI/CtetjMJ5gjm FNk4nid7MNqyt3GkcFONw/lLbh+l6uSAga5gGW0x6Yz4fILOcuUuvRQJWB+OxynmbOPz+M JiHODrCP+5oeE6uhFELmkwk/Sq8v4mY= X-MC-Unique: yqYPJChMNLa2NlmKynpSsg-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Markus Armbruster , Paolo Bonzini , Eric Blake , Eduardo Habkost , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 2/4] usb: add config options for the hub and hid devices Date: Tue, 28 May 2024 11:54:57 +0200 Message-ID: <20240528095459.896594-3-kraxel@redhat.com> In-Reply-To: <20240528095459.896594-1-kraxel@redhat.com> References: <20240528095459.896594-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.034, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1716890178894100007 Content-Type: text/plain; charset="utf-8" Signed-off-by: Gerd Hoffmann Reviewed-by: Thomas Huth --- hw/usb/Kconfig | 10 ++++++++++ hw/usb/meson.build | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index f569ed7eeaa1..84bc7fbe36cd 100644 --- a/hw/usb/Kconfig +++ b/hw/usb/Kconfig @@ -65,6 +65,16 @@ config TUSB6010 bool select USB_MUSB =20 +config USB_HUB + bool + default y + depends on USB + +config USB_HID + bool + default y + depends on USB + config USB_TABLET_WACOM bool default y diff --git a/hw/usb/meson.build b/hw/usb/meson.build index 23f7f7acb50b..d7de1003e3db 100644 --- a/hw/usb/meson.build +++ b/hw/usb/meson.build @@ -35,8 +35,8 @@ system_ss.add(when: 'CONFIG_XLNX_VERSAL', if_true: files(= 'xlnx-versal-usb2-ctrl- system_ss.add(when: 'CONFIG_XLNX_USB_SUBSYS', if_true: files('xlnx-usb-sub= system.c')) =20 # emulated usb devices -system_ss.add(when: 'CONFIG_USB', if_true: files('dev-hub.c')) -system_ss.add(when: 'CONFIG_USB', if_true: files('dev-hid.c')) +system_ss.add(when: 'CONFIG_USB_HUB', if_true: files('dev-hub.c')) +system_ss.add(when: 'CONFIG_USB_HID', if_true: files('dev-hid.c')) system_ss.add(when: 'CONFIG_USB_TABLET_WACOM', if_true: files('dev-wacom.c= ')) system_ss.add(when: 'CONFIG_USB_STORAGE_CORE', if_true: files('dev-storage= .c')) system_ss.add(when: 'CONFIG_USB_STORAGE_BOT', if_true: files('dev-storage-= bot.c')) --=20 2.45.1 From nobody Tue Nov 18 16:07:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1716890177; cv=none; d=zohomail.com; s=zohoarc; b=i9yEyUAq12UUiE9YObxrH87v6Rcr78OS5inMXeBgtt7mH6gsaKGLQgpXlLz05K9ArlLxzDHc+pKqAnNqZcxFpIKWxoOcQtYPuEgFF1CgV5VlF5bNMnc8n2pMeE5S0A9R6kfs/sosxYWTCtPLp58C31yqGj0puYC5AC2UCVsQZ2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716890177; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eSUR6yJIh5CLY06QkHtdoSOCrvKSmrrUkKorZXrTtpo=; b=KZPYQg3Cr2PwX668vUz2W8W5dKGYLrKL6fo2hRjiYQHrY9xCWdjh/ukzjr2Ocf0jV44a/OF0fqSMebkdQRRhHjdfEDPZ9TsK5xS6iqJoPI3gkwedKWTjIICJR8lZHwMjXSPAUitBb/UGz4+pgRyi8INM3P702kDrXXtoQbAAfYk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716890177640403.99569873015844; Tue, 28 May 2024 02:56:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBtYB-0008Dk-Hy; Tue, 28 May 2024 05:55:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBtY9-0008CT-IM for qemu-devel@nongnu.org; Tue, 28 May 2024 05:55:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBtXw-0001Rh-FI for qemu-devel@nongnu.org; Tue, 28 May 2024 05:55:21 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-flxc865FPlaNGVNk2IECuw-1; Tue, 28 May 2024 05:55:03 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 770C081227E; Tue, 28 May 2024 09:55:03 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FBB41C00A8E; Tue, 28 May 2024 09:55:03 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0DDA11800DEB; Tue, 28 May 2024 11:55:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716890106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eSUR6yJIh5CLY06QkHtdoSOCrvKSmrrUkKorZXrTtpo=; b=NFlZ4WsUqbivWL4oiXUyzX9K91bWOb3Chk4l4u7Fq3Dk79whBW0R3coEz9GcoKVpiXOwpx 4of7cAiFwx1XAa2EFRMjnFhBfNwC5Tn8CoCT61E2eaooF9HchZ+CCFvW9qKWKudTbc7HOY 4EurRCgoaN09FXe4mbFv7CYgjYTpNLQ= X-MC-Unique: flxc865FPlaNGVNk2IECuw-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Markus Armbruster , Paolo Bonzini , Eric Blake , Eduardo Habkost , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 3/4] usb/ohci-pci: deprecate, don't build by default Date: Tue, 28 May 2024 11:54:58 +0200 Message-ID: <20240528095459.896594-4-kraxel@redhat.com> In-Reply-To: <20240528095459.896594-1-kraxel@redhat.com> References: <20240528095459.896594-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.034, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1716890178891100006 Content-Type: text/plain; charset="utf-8" The xhci host adapter is the much better choice. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ohci-pci.c | 1 + hw/usb/Kconfig | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci-pci.c b/hw/usb/hcd-ohci-pci.c index 33ed9b6f5a52..88de657def71 100644 --- a/hw/usb/hcd-ohci-pci.c +++ b/hw/usb/hcd-ohci-pci.c @@ -143,6 +143,7 @@ static void ohci_pci_class_init(ObjectClass *klass, voi= d *data) dc->hotpluggable =3D false; dc->vmsd =3D &vmstate_ohci; dc->reset =3D usb_ohci_reset_pci; + klass->deprecation_note =3D "use qemu-xhci instead"; } =20 static const TypeInfo ohci_pci_info =3D { diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index 84bc7fbe36cd..c4a6ea5a687f 100644 --- a/hw/usb/Kconfig +++ b/hw/usb/Kconfig @@ -17,7 +17,6 @@ config USB_OHCI_SYSBUS =20 config USB_OHCI_PCI bool - default y if PCI_DEVICES depends on PCI select USB_OHCI =20 --=20 2.45.1 From nobody Tue Nov 18 16:07:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1716890151; cv=none; d=zohomail.com; s=zohoarc; b=ACzjZkv6h9waRFLRCSazEHDOhU9ZXycBnSYjq7SIumvWi03pvmHSkXFZbnUo8sfNh7IQ21YplQmlam5T8hdEMLpmwaislPjnNh4thOd8T0rzK//sjZKV8mTG+vUNpueuTvtPatbYRaVaUJOABGeOaM9MQ7J+nNv8Sh5HJvGMw+s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716890151; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VbjWTX0IAyGFh5ROBlKm+brQjNdOElgFKhl1FyIFjwM=; b=DHRRQ29XPTBKloIaysfhYBl6IuFNRnbAo/sqYpt4loGW7lTJvBy43c1TTiqDe8QZwNrEoJLMp3SgPZqaBUhn6byD5AY1WkoFRTH65lGS/K2mPZozA9QrI1mzPAMVZBoIYfG6EAH39hBWLUTvGG7OCACnnwf45LBSVTUaDynisi0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716890151131584.3350959272622; Tue, 28 May 2024 02:55:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBtYC-0008Dm-77; Tue, 28 May 2024 05:55:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBtYA-0008Cs-92 for qemu-devel@nongnu.org; Tue, 28 May 2024 05:55:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBtXz-0001Th-Sv for qemu-devel@nongnu.org; Tue, 28 May 2024 05:55:22 -0400 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-481-oNxVmxAsNNqV0F2uhqS7oA-1; Tue, 28 May 2024 05:55:05 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 027B53806711; Tue, 28 May 2024 09:55:05 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.232]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8C97440004D; Tue, 28 May 2024 09:55:04 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1EC491800DFF; Tue, 28 May 2024 11:55:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716890109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VbjWTX0IAyGFh5ROBlKm+brQjNdOElgFKhl1FyIFjwM=; b=cD989NCIsElO/ri6xSQ+0nVnB4yrXqmxxUbEVRhZ3QBc2D2lI5tqjed50a+37hW4PeTgrZ 9U5yUbBzD+GbNwDm3fo/gZW/CEY9tVtp3uZEjGgKol838AESNHefZxnz3SHN+KYRwLR6BN KjhBrwHZzfyCJD/kAGrzPhxUXjUnFvo= X-MC-Unique: oNxVmxAsNNqV0F2uhqS7oA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Markus Armbruster , Paolo Bonzini , Eric Blake , Eduardo Habkost , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 4/4] usb/hub: deprecate, don't build by default Date: Tue, 28 May 2024 11:54:59 +0200 Message-ID: <20240528095459.896594-5-kraxel@redhat.com> In-Reply-To: <20240528095459.896594-1-kraxel@redhat.com> References: <20240528095459.896594-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.034, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1716890153241100003 Content-Type: text/plain; charset="utf-8" The hub supports only USB 1.1. When running out of usb ports it is in almost all cases the much better choice to add another usb host adapter (or increase the number of root ports when using xhci) instead of using the usb hub. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 1 + hw/usb/Kconfig | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-hub.c b/hw/usb/dev-hub.c index 06e9537d0356..68444d39534f 100644 --- a/hw/usb/dev-hub.c +++ b/hw/usb/dev-hub.c @@ -686,6 +686,7 @@ static void usb_hub_class_initfn(ObjectClass *klass, vo= id *data) set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "hub"; dc->vmsd =3D &vmstate_usb_hub; + klass->deprecation_note =3D "use more root ports or additional hostada= pters instead"; device_class_set_props(dc, usb_hub_properties); } =20 diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index c4a6ea5a687f..a8644c43296b 100644 --- a/hw/usb/Kconfig +++ b/hw/usb/Kconfig @@ -66,7 +66,6 @@ config TUSB6010 =20 config USB_HUB bool - default y depends on USB =20 config USB_HID --=20 2.45.1