From nobody Mon Nov 25 11:45:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1716881031; cv=none; d=zohomail.com; s=zohoarc; b=LqI3id/mp9c/l9Klh7eEnBHYLUGhoOVL0jquJyQah28bhTy6xELieqEvq0Mnr2HbFdYfLMk2IL4IVKBFN1jU9ZhdqUYIm2vEQMh2newNtzKOzJaLCY/wnqTsmsL9uRwQtiwp2BW5+a85BmHZandjkIBC3vKIlWG3bJ/HXGwtKxE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716881031; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TAaKM7oNW2kfuuMU7XNgq042NkYzt80TZZlAadgwwQ8=; b=YSKfN364LOkB0uKMpJINwSzWjMQMBsUmemIPgNPVOwx05G//ADu0zpy0cQtZTb9kp0aiZNks5t/Y6epek/zTCVxfdkUJwMAHIpIFil6LfpO6/FS1C8pKhTT13aAoxrJcU5ysgbVLq+kE4uPrWddvNJ5HAQS6A0hecllf3IQlJZ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 171688103145056.79697959650423; Tue, 28 May 2024 00:23:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBrBD-0006jG-Kk; Tue, 28 May 2024 03:23:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBrB8-0006im-Tn for qemu-devel@nongnu.org; Tue, 28 May 2024 03:23:28 -0400 Received: from forwardcorp1c.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBrB7-0008Gh-69 for qemu-devel@nongnu.org; Tue, 28 May 2024 03:23:26 -0400 Received: from mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:6401:0:640:7e6f:0]) by forwardcorp1c.mail.yandex.net (Yandex) with ESMTPS id 50EAA60C3F; Tue, 28 May 2024 10:23:22 +0300 (MSK) Received: from d-tatianin-lin.yandex-team.ru (unknown [2a02:6b8:b081:b72a::1:2c]) by mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id DNKXtm1ixqM0-1WcFOYja; Tue, 28 May 2024 10:23:21 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1716881001; bh=TAaKM7oNW2kfuuMU7XNgq042NkYzt80TZZlAadgwwQ8=; h=Message-Id:Date:Cc:Subject:To:From; b=BEyxjY4itUSX0MPff2Mnt0KX0EgXGWu7wgco1NcKmUJisS9+Ue9bU26p8YeCxqaQL PHphEuuDOrl+zzdu5PEzbMmhwgtlUDptYhVHt785424+JV+khnL5BzJSHTALoj3uds zUZXcZzkFh0eja53B6+d1CUiZapgSj0pYrbTmeos= Authentication-Results: mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Daniil Tatianin To: "Michael S. Tsirkin" Cc: Daniil Tatianin , Paolo Bonzini , Eric Blake , Markus Armbruster , qemu-devel@nongnu.org, philmd@linaro.org Subject: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP Date: Tue, 28 May 2024 10:22:42 +0300 Message-Id: <20240528072242.493056-1-d-tatianin@yandex-team.ru> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.200; envelope-from=d-tatianin@yandex-team.ru; helo=forwardcorp1c.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1716881033828100001 This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Also add a comment to highlight the fact that this (and one other QMP command) only works for the MC146818 RTC controller. Acked-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Daniil Tatianin --- Changes since v0: - Rename to rtc-inject-irq to match other similar API - Add a comment to highlight that this only works for the I386 RTC Changes since v1: - Added a description below the QMP command to explain how it can be used and what it does. Changes since v2: - Add a 'broadcast' suffix. - Change the comments to explain the flags we're setting. - Change the command description to fix styling & explain that it's a broad= cast command. Changes since v3: - Fix checkpatch complaints about usage of C99 comments --- hw/rtc/mc146818rtc.c | 20 ++++++++++++++++++++ include/hw/rtc/mc146818rtc.h | 1 + qapi/misc-target.json | 19 +++++++++++++++++++ 3 files changed, 40 insertions(+) diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c index 3379f92748..96ecd43036 100644 --- a/hw/rtc/mc146818rtc.c +++ b/hw/rtc/mc146818rtc.c @@ -107,6 +107,11 @@ static void rtc_coalesced_timer_update(MC146818RtcStat= e *s) static QLIST_HEAD(, MC146818RtcState) rtc_devices =3D QLIST_HEAD_INITIALIZER(rtc_devices); =20 +/* + * NOTE: + * The two QMP functions below are _only_ implemented for the MC146818. + * All other RTC devices ignore this. + */ void qmp_rtc_reset_reinjection(Error **errp) { MC146818RtcState *s; @@ -116,6 +121,21 @@ void qmp_rtc_reset_reinjection(Error **errp) } } =20 +void qmp_rtc_inject_irq_broadcast(Error **errp) +{ + MC146818RtcState *s; + + QLIST_FOREACH(s, &rtc_devices, link) { + /* Update-ended interrupt enable */ + s->cmos_data[RTC_REG_B] |=3D REG_B_UIE; + + /* Interrupt request flag | update interrupt flag */ + s->cmos_data[RTC_REG_C] |=3D REG_C_IRQF | REG_C_UF; + + qemu_irq_raise(s->irq); + } +} + static bool rtc_policy_slew_deliver_irq(MC146818RtcState *s) { kvm_reset_irq_delivered(); diff --git a/include/hw/rtc/mc146818rtc.h b/include/hw/rtc/mc146818rtc.h index 97cec0b3e8..e9dd0f9c72 100644 --- a/include/hw/rtc/mc146818rtc.h +++ b/include/hw/rtc/mc146818rtc.h @@ -56,5 +56,6 @@ MC146818RtcState *mc146818_rtc_init(ISABus *bus, int base= _year, void mc146818rtc_set_cmos_data(MC146818RtcState *s, int addr, int val); int mc146818rtc_get_cmos_data(MC146818RtcState *s, int addr); void qmp_rtc_reset_reinjection(Error **errp); +void qmp_rtc_inject_irq_broadcast(Error **errp); =20 #endif /* HW_RTC_MC146818RTC_H */ diff --git a/qapi/misc-target.json b/qapi/misc-target.json index 4e0a6492a9..7d388a3753 100644 --- a/qapi/misc-target.json +++ b/qapi/misc-target.json @@ -19,6 +19,25 @@ { 'command': 'rtc-reset-reinjection', 'if': 'TARGET_I386' } =20 +## +# @rtc-inject-irq-broadcast: +# +# Inject an RTC interrupt for all existing RTCs on the system. +# The interrupt forces the guest to synchronize the time with RTC. +# This is useful after a long stop-cont pause, which is common for +# serverless-type workload. +# +# Since: 9.1 +# +# Example: +# +# -> { "execute": "rtc-inject-irq-broadcast" } +# <- { "return": {} } +# +## +{ 'command': 'rtc-inject-irq-broadcast', + 'if': 'TARGET_I386' } + ## # @SevState: # --=20 2.34.1