From nobody Tue Nov 18 16:07:24 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1716815020; cv=none; d=zohomail.com; s=zohoarc; b=N/WOS1RC024xQhLNgTAWpfUapiRqpxTHYcrthzWfLBe+bVt3D8s/bQZ//R5J8qCIzzlmDaa1E/LYOPmGFqdpNffAgqTYs2RNmI/p/4Zy6uw5IIDMtP7dMMGteDwWEILkct/hMDSvrtFwAz0nfdJb1Bb/HaCq5d4JOLFWcIRcsDc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716815020; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HL8GMo/NFMT21br8KoNS2y/blXdUpDaNwXKQDmgxm3g=; b=SWcKAmHx4AkP4rma4QoP3f8SEWxpCWicm8E+087SZ5pkxYfS2jcwFqLwjydB+mug2UxZqASDravR1ehKycT//spTk7zHhSYRND8Ajly5TDZKUzIKRlzuiBuc7YuKIeA+OrHP3b5DwOXOjAY31BSXXd/mxceJ6jAZjo3Ml9BUabk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716815020525910.2590710331785; Mon, 27 May 2024 06:03:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBa0b-0004EB-Jl; Mon, 27 May 2024 09:03:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBa0a-0004Dx-P4 for qemu-devel@nongnu.org; Mon, 27 May 2024 09:03:24 -0400 Received: from mgamail.intel.com ([192.198.163.17]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBa0X-00027l-4T for qemu-devel@nongnu.org; Mon, 27 May 2024 09:03:23 -0400 Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2024 06:03:18 -0700 Received: from liuzhao-optiplex-7080.sh.intel.com ([10.239.160.36]) by fmviesa006.fm.intel.com with ESMTP; 27 May 2024 06:03:16 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716815001; x=1748351001; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=NBxTVic0omPJuYm887+8KTZTarZM0b+ftsU4yFUekEs=; b=T+Q1A/yfe7OQ85Zs6PLX0CDyTq9n4zaRtAco+dKqhjifCDgwwhI9vhc3 4UtAGBauGck7zPyxoAMDTWmTIhK2LlIpgorfc/4tHhd3ttv7jTAIXibpZ bjqIqkDB4kaPQbNaV8PwPnvd38MrFeCBMgutoi8Y+MRrtRQ0mUm5TXphr 9iFPIaNgQbV0yTB0Bs1zurkeA319xDWeYkxr+Uq7CBpMPsFsh8zRhr5Tl i0KOUZyKgXMN95abML7f6lisU9j1CibdndGLJxbIqJ2I2UZsEyZqOk5bG thKe+ONL2u+gDcqFNV/91OCj2VdDsqZyCdTp5UaR43Xz31cEo+CIuy3V3 g==; X-CSE-ConnectionGUID: NsG4u8HHSpWPnhTvCDCe0Q== X-CSE-MsgGUID: W3DAZp3jQqazpEStJNyM5w== X-IronPort-AV: E=McAfee;i="6600,9927,11084"; a="13004272" X-IronPort-AV: E=Sophos;i="6.08,192,1712646000"; d="scan'208";a="13004272" X-CSE-ConnectionGUID: LJcfWO4jRsqvZ6EGVsE/1Q== X-CSE-MsgGUID: Nui9ANEARgq94C3nHHN/Cw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,192,1712646000"; d="scan'208";a="34783161" From: Zhao Liu To: Eduardo Habkost , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Yanan Wang , Thomas Huth , qemu-devel@nongnu.org Cc: Zhao Liu Subject: [PATCH] hw/core: Rename CpuTopology to CPUTopology Date: Mon, 27 May 2024 21:18:37 +0800 Message-Id: <20240527131837.2630961-1-zhao1.liu@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.17; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.034, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1716815021525100003 Content-Type: text/plain; charset="utf-8" Use CPUTopology to honor the generic style of CPU capitalization abbreviations. Signed-off-by: Zhao Liu Acked-by: Thomas Huth --- * Split from the previous SMP cache RFC: https://lore.kernel.org/qemu-devel/20240220092504.726064-2-zhao1.liu@lin= ux.intel.com/ --- hw/s390x/cpu-topology.c | 6 +++--- include/hw/boards.h | 8 ++++---- include/hw/s390x/cpu-topology.h | 6 +++--- tests/unit/test-smp-parse.c | 14 +++++++------- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/hw/s390x/cpu-topology.c b/hw/s390x/cpu-topology.c index f16bdf65faa0..016f6c1c15ac 100644 --- a/hw/s390x/cpu-topology.c +++ b/hw/s390x/cpu-topology.c @@ -86,7 +86,7 @@ bool s390_has_topology(void) */ static void s390_topology_init(MachineState *ms) { - CpuTopology *smp =3D &ms->smp; + CPUTopology *smp =3D &ms->smp; =20 s390_topology.cores_per_socket =3D g_new0(uint8_t, smp->sockets * smp->books * smp->drawers); @@ -181,7 +181,7 @@ void s390_topology_reset(void) */ static bool s390_topology_cpu_default(S390CPU *cpu, Error **errp) { - CpuTopology *smp =3D ¤t_machine->smp; + CPUTopology *smp =3D ¤t_machine->smp; CPUS390XState *env =3D &cpu->env; =20 /* All geometry topology attributes must be set or all unset */ @@ -234,7 +234,7 @@ static bool s390_topology_check(uint16_t socket_id, uin= t16_t book_id, uint16_t drawer_id, uint16_t entitlement, bool dedicated, Error **errp) { - CpuTopology *smp =3D ¤t_machine->smp; + CPUTopology *smp =3D ¤t_machine->smp; =20 if (socket_id >=3D smp->sockets) { error_setg(errp, "Unavailable socket: %d", socket_id); diff --git a/include/hw/boards.h b/include/hw/boards.h index 2fa800f11ae4..c1737f2a5736 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -334,7 +334,7 @@ typedef struct DeviceMemoryState { } DeviceMemoryState; =20 /** - * CpuTopology: + * CPUTopology: * @cpus: the number of present logical processors on the machine * @drawers: the number of drawers on the machine * @books: the number of books in one drawer @@ -346,7 +346,7 @@ typedef struct DeviceMemoryState { * @threads: the number of threads in one core * @max_cpus: the maximum number of logical processors on the machine */ -typedef struct CpuTopology { +typedef struct CPUTopology { unsigned int cpus; unsigned int drawers; unsigned int books; @@ -357,7 +357,7 @@ typedef struct CpuTopology { unsigned int cores; unsigned int threads; unsigned int max_cpus; -} CpuTopology; +} CPUTopology; =20 /** * MachineState: @@ -409,7 +409,7 @@ struct MachineState { const char *cpu_type; AccelState *accelerator; CPUArchIdList *possible_cpus; - CpuTopology smp; + CPUTopology smp; struct NVDIMMState *nvdimms_state; struct NumaState *numa_state; }; diff --git a/include/hw/s390x/cpu-topology.h b/include/hw/s390x/cpu-topolog= y.h index c064f427e948..ff09c57a4428 100644 --- a/include/hw/s390x/cpu-topology.h +++ b/include/hw/s390x/cpu-topology.h @@ -63,17 +63,17 @@ static inline void s390_topology_reset(void) =20 extern S390Topology s390_topology; =20 -static inline int s390_std_socket(int n, CpuTopology *smp) +static inline int s390_std_socket(int n, CPUTopology *smp) { return (n / smp->cores) % smp->sockets; } =20 -static inline int s390_std_book(int n, CpuTopology *smp) +static inline int s390_std_book(int n, CPUTopology *smp) { return (n / (smp->cores * smp->sockets)) % smp->books; } =20 -static inline int s390_std_drawer(int n, CpuTopology *smp) +static inline int s390_std_drawer(int n, CPUTopology *smp) { return (n / (smp->cores * smp->sockets * smp->books)) % smp->drawers; } diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c index 9fdba24fce56..f51138794ca1 100644 --- a/tests/unit/test-smp-parse.c +++ b/tests/unit/test-smp-parse.c @@ -120,8 +120,8 @@ */ typedef struct SMPTestData { SMPConfiguration config; - CpuTopology expect_prefer_sockets; - CpuTopology expect_prefer_cores; + CPUTopology expect_prefer_sockets; + CPUTopology expect_prefer_cores; const char *expect_error; } SMPTestData; =20 @@ -643,7 +643,7 @@ static char *smp_config_to_string(const SMPConfiguratio= n *config) } =20 /* Use the different calculation than machine_topo_get_threads_per_socket(= ). */ -static unsigned int cpu_topology_get_threads_per_socket(const CpuTopology = *topo) +static unsigned int cpu_topology_get_threads_per_socket(const CPUTopology = *topo) { /* Check the divisor to avoid invalid topology examples causing SIGFPE= . */ if (!topo->drawers || !topo->books || !topo->sockets) { @@ -654,7 +654,7 @@ static unsigned int cpu_topology_get_threads_per_socket= (const CpuTopology *topo) } =20 /* Use the different calculation than machine_topo_get_cores_per_socket().= */ -static unsigned int cpu_topology_get_cores_per_socket(const CpuTopology *t= opo) +static unsigned int cpu_topology_get_cores_per_socket(const CPUTopology *t= opo) { /* Check the divisor to avoid invalid topology examples causing SIGFPE= . */ if (!topo->threads) { @@ -664,13 +664,13 @@ static unsigned int cpu_topology_get_cores_per_socket= (const CpuTopology *topo) } } =20 -static char *cpu_topology_to_string(const CpuTopology *topo, +static char *cpu_topology_to_string(const CPUTopology *topo, unsigned int threads_per_socket, unsigned int cores_per_socket, bool has_clusters) { return g_strdup_printf( - "(CpuTopology) {\n" + "(CPUTopology) {\n" " .cpus =3D %u,\n" " .drawers =3D %u,\n" " .books =3D %u,\n" @@ -692,7 +692,7 @@ static char *cpu_topology_to_string(const CpuTopology *= topo, } =20 static void check_parse(MachineState *ms, const SMPConfiguration *config, - const CpuTopology *expect_topo, const char *expect= _err, + const CPUTopology *expect_topo, const char *expect= _err, bool is_valid) { MachineClass *mc =3D MACHINE_GET_CLASS(ms); --=20 2.34.1