From nobody Mon Nov 25 09:47:18 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1716580966; cv=none; d=zohomail.com; s=zohoarc; b=L7wODI4v0OeQy4R1oAzQioeVLmIDLfSVl1XTsPWL5DaKUmijM4PGjEhPhyB4yf8NeeVcdbdc+jErSvnVDnKrHgUb9OPct7g+5pmhUpD/90k/Xcc8DIxau+GfoDKwQZOg2KfvqjZc1n3BUKbhujQBCx8N6mwtyPJLOidrjZ888E0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716580966; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uTCHMDUdeCRcyWCyrSXYIjqyr1/ThcP1TvvRyAEC8z8=; b=PpXdCS0N/LMkQBASi3F9f44VnQfKG68kkOSu9lQ8N2qAjheP6FVB3aeJbRyWYtjQQ1IGny5VNHibzAqane9d6aFeMrZYmcGoJkQFeVVeAJ4cdmPqtDAAUgua4bQ96mFPnUEz0J4hLvJC7ywR/OkHjtMVKBULK9rwo73zMwCzS+0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 171658096693037.91647081202552; Fri, 24 May 2024 13:02:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAb6J-0002Ir-EF; Fri, 24 May 2024 16:01:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAb63-00025z-2V; Fri, 24 May 2024 16:01:05 -0400 Received: from mgamail.intel.com ([192.198.163.13]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAb5v-00051T-BG; Fri, 24 May 2024 16:00:57 -0400 Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2024 13:00:46 -0700 Received: from 9cc2c43eec6b.jf.intel.com ([10.54.77.100]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2024 13:00:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716580851; x=1748116851; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TxxJnHMBaLnho+/05QzctY86Y8OJz5CyPdX6d6Cev54=; b=mpc7+m/xQcJ6WPiCT51isNdMEuCxTL4UxaC0YY3gkwZIx7dvZBul7Yy/ mTgKbMliNpxJONpwDb3fTlgRAmldT4Mo2f/rghn5FS37TyGq87wKjBdOt kc1p9BwCPrWSBeR0BqremjPS+XLPBK3pYjYFeemX5ZeQj2gAfAHTUONxc AvdO5O7j5sBMgQQKhA3Qg/h1TdKIZIZELYofw4ZwR+Zutx9lSfjvRpOox BM1eSVP35KqBdq7szE5VT5zj1OIAzf/6GX2R9h1PuZidye/P/YWvrUJmn WXO1Nobucpd7w9oZmxtoydcKLrlrpWILUx508SrwZSxHtrsyLEMM7l6zC w==; X-CSE-ConnectionGUID: fDUc9Ub2T8GW/KyPXa54dA== X-CSE-MsgGUID: TUBMBPzISOm312cGEK8guQ== X-IronPort-AV: E=McAfee;i="6600,9927,11082"; a="15918263" X-IronPort-AV: E=Sophos;i="6.08,186,1712646000"; d="scan'208";a="15918263" X-CSE-ConnectionGUID: PG9RzVkzT4We7qa5u0gq5A== X-CSE-MsgGUID: i5LmdFabSFm3uuxpa4R3OA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,186,1712646000"; d="scan'208";a="39108906" From: Zide Chen To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, mst@redhat.com, thuth@redhat.com, cfontana@suse.de, xiaoyao.li@intel.com, qemu-trivial@nongnu.org, Zide Chen Subject: [PATCH V2 1/3] vl: Allow multiple -overcommit commands Date: Fri, 24 May 2024 13:00:15 -0700 Message-Id: <20240524200017.150339-2-zide.chen@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240524200017.150339-1-zide.chen@intel.com> References: <20240524200017.150339-1-zide.chen@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.13; envelope-from=zide.chen@intel.com; helo=mgamail.intel.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1716580968316100001 Content-Type: text/plain; charset="utf-8" Both cpu-pm and mem-lock are related to system resource overcommit, but they are separate from each other, in terms of how they are realized, and of course, they are applied to different system resources. It's tempting to use separate command lines to specify their behavior. e.g., in the following example, the cpu-pm command is quietly overwritten, and it's not easy to notice it without careful inspection. --overcommit mem-lock=3Don --overcommit cpu-pm=3Don Fixes: c8c9dc42b7ca ("Remove the deprecated -realtime option") Suggested-by: Thomas Huth Signed-off-by: Zide Chen Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu --- v2: Thanks to Thomas' suggestion, changed to this better approach, which is more generic and can handle situations like: "enabled the option in the config file, and now you'd like to disable it on the command line again". system/vl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/system/vl.c b/system/vl.c index a3eede5fa5b8..dfa6cdd9283b 100644 --- a/system/vl.c +++ b/system/vl.c @@ -3545,8 +3545,8 @@ void qemu_init(int argc, char **argv) if (!opts) { exit(1); } - enable_mlock =3D qemu_opt_get_bool(opts, "mem-lock", false= ); - enable_cpu_pm =3D qemu_opt_get_bool(opts, "cpu-pm", false); + enable_mlock =3D qemu_opt_get_bool(opts, "mem-lock", enabl= e_mlock); + enable_cpu_pm =3D qemu_opt_get_bool(opts, "cpu-pm", enable= _cpu_pm); break; case QEMU_OPTION_compat: { --=20 2.34.1