From nobody Mon Nov 25 10:22:25 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1716491289; cv=none; d=zohomail.com; s=zohoarc; b=RtEd9Kxd/gBfbDfik0UoL1TjN4QruP9NLW/luRImOT1WCx7dEEIZ3hjwpmPODznKt1nUagRx0+UCGPqh/my/HmqZXyOVWEkVIBEqE+lQCVxh2ZEs1FF0gckjbR1e+nKw0W8yO63KG21P65+Bt+OA14O+r5CZOn1494SFYzyUOeQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716491289; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rLoeI57E2p6A0O3qEBvqik55xUqwKlM7a7ONvohzAaA=; b=KB5lGor0zSYdKGXGy3MwGLjXrMF14n8dH7Qz/KcPZOsuhWK0ybelZEmMHjOcrQZZAnvhZd7CjZ8seJX/RuU5KtEXJ0Dqb0YpBLm5ECxP9H3LrI0uTYM06qi0lUXlD3KbLo1KVLkZV5DLDaMJVLnRgbpBQZg/HSbgMiCelRA1QSo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716491289685477.37825318361456; Thu, 23 May 2024 12:08:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sADlz-0002IM-JQ; Thu, 23 May 2024 15:06:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sADls-0002G2-1W for qemu-devel@nongnu.org; Thu, 23 May 2024 15:06:36 -0400 Received: from smtp-out1.suse.de ([2a07:de40:b251:101:10:150:64:1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sADlj-0004K5-5U for qemu-devel@nongnu.org; Thu, 23 May 2024 15:06:35 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F1FCC22B7E; Thu, 23 May 2024 19:06:25 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 271D413A6B; Thu, 23 May 2024 19:06:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 2CSeN6+TT2bUEQAAD6G6ig (envelope-from ); Thu, 23 May 2024 19:06:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716491186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rLoeI57E2p6A0O3qEBvqik55xUqwKlM7a7ONvohzAaA=; b=lebN6kUyDGyx5tHaTZIUPPO575NSitOLczZ9Ca7eWoiZGzyteoogwQP9OlsXsZOSaVTbGg JipJsoqie7/XNZZ47ObhW0KVu6aJsMpnyub7aCzjkx6NDu3ybpd9Vylw9cKAdETStPQM6T V4gfRNLJwrvkq1dmreSDgaUltyGs+FI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716491186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rLoeI57E2p6A0O3qEBvqik55xUqwKlM7a7ONvohzAaA=; b=wpatSGTDtjMRQf3S8NnBQ9EYSrXsJN9nCfEg8O1J90kvqRlRDtrIMK9eqWH8hesMBQ4mn6 8v/FmUAvgC1vEVDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716491186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rLoeI57E2p6A0O3qEBvqik55xUqwKlM7a7ONvohzAaA=; b=lebN6kUyDGyx5tHaTZIUPPO575NSitOLczZ9Ca7eWoiZGzyteoogwQP9OlsXsZOSaVTbGg JipJsoqie7/XNZZ47ObhW0KVu6aJsMpnyub7aCzjkx6NDu3ybpd9Vylw9cKAdETStPQM6T V4gfRNLJwrvkq1dmreSDgaUltyGs+FI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716491186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rLoeI57E2p6A0O3qEBvqik55xUqwKlM7a7ONvohzAaA=; b=wpatSGTDtjMRQf3S8NnBQ9EYSrXsJN9nCfEg8O1J90kvqRlRDtrIMK9eqWH8hesMBQ4mn6 8v/FmUAvgC1vEVDw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: berrange@redhat.com, armbru@redhat.com, Peter Xu , Claudio Fontana , Jim Fehlig Subject: [PATCH v2 13/18] monitor: fdset: Match against O_DIRECT Date: Thu, 23 May 2024 16:05:43 -0300 Message-Id: <20240523190548.23977-14-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20240523190548.23977-1-farosas@suse.de> References: <20240523190548.23977-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email]; RCVD_TLS_ALL(0.00)[] X-Spam-Score: -2.80 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a07:de40:b251:101:10:150:64:1; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1716491290171100001 Content-Type: text/plain; charset="utf-8" We're about to enable the use of O_DIRECT in the migration code and due to the alignment restrictions imposed by filesystems we need to make sure the flag is only used when doing aligned IO. The migration will do parallel IO to different regions of a file, so we need to use more than one file descriptor. Those cannot be obtained by duplicating (dup()) since duplicated file descriptors share the file status flags, including O_DIRECT. If one migration channel does unaligned IO while another sets O_DIRECT to do aligned IO, the filesystem would fail the unaligned operation. The add-fd QMP command along with the fdset code are specifically designed to allow the user to pass a set of file descriptors with different access flags into QEMU to be later fetched by code that needs to alternate between those flags when doing IO. Extend the fdset matching to behave the same with the O_DIRECT flag. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu --- monitor/fds.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/monitor/fds.c b/monitor/fds.c index d93d2e695b..a6580e215e 100644 --- a/monitor/fds.c +++ b/monitor/fds.c @@ -419,6 +419,11 @@ int monitor_fdset_dup_fd_add(int64_t fdset_id, int fla= gs, Error **errp) int fd =3D -1; int dup_fd; int mon_fd_flags; + int mask =3D O_ACCMODE; + +#ifdef O_DIRECT + mask |=3D O_DIRECT; +#endif =20 if (mon_fdset->id !=3D fdset_id) { continue; @@ -432,7 +437,7 @@ int monitor_fdset_dup_fd_add(int64_t fdset_id, int flag= s, Error **errp) return -1; } =20 - if ((flags & O_ACCMODE) =3D=3D (mon_fd_flags & O_ACCMODE)) { + if ((flags & mask) =3D=3D (mon_fd_flags & mask)) { fd =3D mon_fdset_fd->fd; break; } --=20 2.35.3