From nobody Mon Nov 25 07:59:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=samsung.com ARC-Seal: i=1; a=rsa-sha256; t=1716290287; cv=none; d=zohomail.com; s=zohoarc; b=PcRUQSkXunfaicZzZ2OAijGB0CfdTYAtkqWKx2NGa/8PXcRg/+Bz72gkHbPUbhfEBWSkAV1Be4vwDl4+5coeHZqLWV/+gYeaFmPBqVKg//vG/3WHlgfwjjIiYTPoRBK6eDkL5Lf0U/6XydrgvkDovjUIy4Ss9jo9nu5n+/fO3KA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716290287; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kCvxzvP6Xbera+pHcnuspK3z4sIcQXnqJeN7D2vphYk=; b=JaNTK+VOQ7rsvBz4XMsZoeR8zJDuUfes6ymaCnifPOlcdy3sg5gKqpelPYB0/SvJaR2PzSiS0XWmKsJ1hZdXdj28cBF6KvDq3OcEtKJsZNT9PtzG0g4ofWMtM/a6ySOgntIV4yZrcaIogSHiXjr7XZldR6cmbt4TPPXOgw2Ziw0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 171629028711757.15301310438508; Tue, 21 May 2024 04:18:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9NUG-0007hB-2u; Tue, 21 May 2024 07:16:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9NUE-0007gU-VV for qemu-devel@nongnu.org; Tue, 21 May 2024 07:16:55 -0400 Received: from mailout2.samsung.com ([203.254.224.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9NUA-0003wT-OF for qemu-devel@nongnu.org; Tue, 21 May 2024 07:16:54 -0400 Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20240521111646epoutp023ea1bef416696a305b1fcefa36905575~RfNlumG361629516295epoutp02a for ; Tue, 21 May 2024 11:16:46 +0000 (GMT) Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20240521111645epcas2p4ea5d73692cb473adb206fc83b108ec2e~RfNknovlc2788927889epcas2p4b; Tue, 21 May 2024 11:16:45 +0000 (GMT) Received: from epsmges2p1.samsung.com (unknown [182.195.36.100]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4VkBhr2jhwz4x9Q1; Tue, 21 May 2024 11:16:44 +0000 (GMT) Received: from epcas2p1.samsung.com ( [182.195.41.53]) by epsmges2p1.samsung.com (Symantec Messaging Gateway) with SMTP id 66.D7.09673.C928C466; Tue, 21 May 2024 20:16:44 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPA id 20240521111643epcas2p3c86343fde1fdd6dbd868d09188084ae0~RfNjT7xdN1548015480epcas2p39; Tue, 21 May 2024 11:16:43 +0000 (GMT) Received: from epsmgmc1p1new.samsung.com (unknown [182.195.42.40]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240521111643epsmtrp281298f9c9e1c76e171581635e995645a~RfNjRzWjK2930529305epsmtrp2Q; Tue, 21 May 2024 11:16:43 +0000 (GMT) Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgmc1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 10.B4.09238.B928C466; Tue, 21 May 2024 20:16:43 +0900 (KST) Received: from localhost.dsn.sec.samsung.com (unknown [10.229.54.230]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20240521111643epsmtip154abce00e64ac948f102a5b557835308~RfNjJLw6u0137501375epsmtip10; Tue, 21 May 2024 11:16:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20240521111646epoutp023ea1bef416696a305b1fcefa36905575~RfNlumG361629516295epoutp02a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1716290206; bh=kCvxzvP6Xbera+pHcnuspK3z4sIcQXnqJeN7D2vphYk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c01CSocVwBcZA2NdmAMT2m86d7wbRyne8hAkwZxiHkkxiMWJmjZwikQAFT+/ChTCm LyKeIKSkglSu9D5Sn6lGjoKYzLm/ZHaTK7kqV82poKkDfsOYNrmOO+6dMkV7V0KD5w GFVu0NQ0rgMkB7l5M6X0BC5Fcqk+dA6ulu4Gmy2A= X-AuditID: b6c32a45-82dff700000025c9-29-664c829c49d4 From: Minwoo Im To: Jeuk Kim , Kevin Wolf , Hanna Reitz Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, gost.dev@samsung.com, Minwoo Im Subject: [PATCH 1/2] hw/ufs: Update MCQ-related fields to block/ufs.h Date: Tue, 21 May 2024 20:05:43 +0900 Message-Id: <20240521110544.258772-2-minwoo.im@samsung.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240521110544.258772-1-minwoo.im@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHKsWRmVeSWpSXmKPExsWy7bCmqe6cJp80g6dfBC1uHtjJZPHgbj+j xf2t1xgtllxMtXh2+gCzxax37WwWx3t3sDiwezy5tpnJ4/2+q2wefVtWMQYwR2XbZKQmpqQW KaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gAtV1IoS8wpBQoFJBYX K+nb2RTll5akKmTkF5fYKqUWpOQUmBfoFSfmFpfmpevlpZZYGRoYGJkCFSZkZ/zctZa14IlO xeuW5ewNjH+Uuhg5OCQETCTmfWXtYuTiEBLYwSgxYWcLE4TziVHi95l17BDON0aJlvuH2boY OcE6Nv3aDpXYyyhx8+ocKOc3o8T+zS9YQarYBNQlGqa+YgGxRQTSJS6/W8kKso9ZIFvi4Q09 kLCwgKvE/z9N7CA2i4CqxIz/ixlBbF4Ba4mO1d+YIJbJS+w/eJYZpJVTwEbi1Hs5iBJBiZMz n4BNZwYqad46mxnkBAmBW+wSp9ZsYITodZG40LkU6mhhiVfHt7BD2FISn9/thYqXS/x8Mwmq vkLi4KzbbJBgsZe49jwF4mJNifW79CGiyhJHbkFt5ZPoOPyXHSLMK9HRJgQxQ1ni46FDzBC2 pMTyS6+h9nhI/Lv8ERrO/YwSPyb9ZpzAqDALyTOzkDwzC2HxAkbmVYxiqQXFuempxUYFhvDY Tc7P3cQIToharjsYJ7/9oHeIkYmD8RCjBAezkgjvpi2eaUK8KYmVValF+fFFpTmpxYcYTYEh PZFZSjQ5H5iS80riDU0sDUzMzAzNjUwNzJXEee+1zk0REkhPLEnNTk0tSC2C6WPi4JRqYKo5 flMrheWb0K93FhoTz9QyWLDVy2Q/vHzg5YPKJWzPVA1vlr817Y5YW/h66tZkbh23H6FfMthW he0WzklK/imw6WlT756j56L+BvGafW3kPG5mOqPnQ85tmc/G3580TH/38JHLlOcdR2QurlBa 8nmlRIXRtvN/WBdJO4cVTjE7p3GIo0Ln8q1mg0lxZ37XH3h/5nv2vC3lS649zFGV9LZcZXkx IVyhQdhNx+/rMSt1h0ST7Up3H28+utBi2eaQ50uVdzzpVmJuT8/75xr/ZFGIm2Jgv4hWamd4 YOG3vu+r3i+dHLvzzOWdwnbqmv0aF55Ol/kuEcF3tPHQ9Dl3rbWv+b3sk3DyV9tf9zSXRUiJ pTgj0VCLuag4EQDkIBgCEQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNLMWRmVeSWpSXmKPExsWy7bCSnO7sJp80gxcz1CxuHtjJZPHgbj+j xf2t1xgtllxMtXh2+gCzxax37WwWx3t3sDiwezy5tpnJ4/2+q2wefVtWMQYwR3HZpKTmZJal FunbJXBl/Ny1lrXgiU7F65bl7A2Mf5S6GDk5JARMJDb92s7excjFISSwm1Fi3f3VLBAJSYl9 p2+yQtjCEvdbjrBCFP1klFi14D1YEZuAukTD1FdgtohApsTCVx3sIDazQL5EV8cCJhBbWMBV 4v+fJrA4i4CqxIz/ixlBbF4Ba4mO1d+YIBbIS+w/eJa5i5GDg1PARuLUezkQUwio5GobN0S1 oMTJmU9YIKbLSzRvnc08gVFgFpLULCSpBYxMqxglUwuKc9Nzkw0LDPNSy/WKE3OLS/PS9ZLz czcxgsNXS2MH4735//QOMTJxMB5ilOBgVhLh3bTFM02INyWxsiq1KD++qDQntfgQozQHi5I4 r+GM2SlCAumJJanZqakFqUUwWSYOTqkGpmX66cLvF/27qrLN6uF5FzvHrsa1m14plWRovPhx 8PNKC523R24uLDeRvLNHeFqedtTrZdKSp5aJdE5UX/OpIfFz0tWl19de1zfh+y9y+bCcyKHP vQ/qap9HFNvLbW/RnqQez/Ys7W+M5nl/8TcR9tHsGjsnRe2RFzuXsXVj00Sr4E3BtU/MPl1/ 1lbYsi5WMtf05cr8Lf9FNbed+LP0UeEa26fBP/wyFvpclV/sNWfR+g239H0ytDdM1ft6edn+ jrV2Eto7gme+vxr+U+ea92qmfNGcH5eCTy5ZOk3tpu6KlU9qNiW1vNlrMn1ZW4RqdnT+kV1O l0RTNWQUUoz+pnOnVPZPmqVX5HKAqdtty0IlluKMREMt5qLiRAD0b6fgzgIAAA== X-CMS-MailID: 20240521111643epcas2p3c86343fde1fdd6dbd868d09188084ae0 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20240521111643epcas2p3c86343fde1fdd6dbd868d09188084ae0 References: <20240521110544.258772-1-minwoo.im@samsung.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.254.224.25; envelope-from=minwoo.im@samsung.com; helo=mailout2.samsung.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @samsung.com) X-ZM-MESSAGEID: 1716290288512100003 This patch is a prep patch for the following MCQ support patch for hw/ufs. This patch updated minimal mandatory fields to support MCQ based on UFSHCI 4.0. Signed-off-by: Minwoo Im --- include/block/ufs.h | 108 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 106 insertions(+), 2 deletions(-) diff --git a/include/block/ufs.h b/include/block/ufs.h index d61598b8f3..3513b6e772 100644 --- a/include/block/ufs.h +++ b/include/block/ufs.h @@ -7,7 +7,7 @@ =20 typedef struct QEMU_PACKED UfsReg { uint32_t cap; - uint32_t rsvd0; + uint32_t mcqcap; uint32_t ver; uint32_t rsvd1; uint32_t hcpid; @@ -46,6 +46,13 @@ typedef struct QEMU_PACKED UfsReg { uint32_t rsvd7[4]; uint32_t rsvd8[16]; uint32_t ccap; + uint32_t rsvd9[127]; + uint32_t config; + uint32_t rsvd10[3]; + uint32_t rsvd11[28]; + uint32_t mcqconfig; + uint32_t esilba; + uint32_t esiuba; } UfsReg; =20 REG32(CAP, offsetof(UfsReg, cap)) @@ -57,6 +64,15 @@ REG32(CAP, offsetof(UfsReg, cap)) FIELD(CAP, OODDS, 25, 1) FIELD(CAP, UICDMETMS, 26, 1) FIELD(CAP, CS, 28, 1) + FIELD(CAP, LSDBS, 29, 1) + FIELD(CAP, MCQS, 30, 1) +REG32(MCQCAP, offsetof(UfsReg, mcqcap)) + FIELD(MCQCAP, MAXQ, 0, 8) + FIELD(MCQCAP, SP, 8, 1) + FIELD(MCQCAP, RRP, 9, 1) + FIELD(MCQCAP, EIS, 10, 1) + FIELD(MCQCAP, QCFGPTR, 16, 8) + FIELD(MCQCAP, MIAG, 24, 8) REG32(VER, offsetof(UfsReg, ver)) REG32(HCPID, offsetof(UfsReg, hcpid)) REG32(HCMID, offsetof(UfsReg, hcmid)) @@ -78,6 +94,7 @@ REG32(IS, offsetof(UfsReg, is)) FIELD(IS, HCFES, 16, 1) FIELD(IS, SBFES, 17, 1) FIELD(IS, CEFES, 18, 1) + FIELD(IS, CQES, 20, 1) REG32(IE, offsetof(UfsReg, ie)) FIELD(IE, UTRCE, 0, 1) FIELD(IE, UDEPRIE, 1, 1) @@ -95,6 +112,7 @@ REG32(IE, offsetof(UfsReg, ie)) FIELD(IE, HCFEE, 16, 1) FIELD(IE, SBFEE, 17, 1) FIELD(IE, CEFEE, 18, 1) + FIELD(IE, CQEE, 20, 1) REG32(HCS, offsetof(UfsReg, hcs)) FIELD(HCS, DP, 0, 1) FIELD(HCS, UTRLRDY, 1, 1) @@ -128,6 +146,10 @@ REG32(UCMDARG1, offsetof(UfsReg, ucmdarg1)) REG32(UCMDARG2, offsetof(UfsReg, ucmdarg2)) REG32(UCMDARG3, offsetof(UfsReg, ucmdarg3)) REG32(CCAP, offsetof(UfsReg, ccap)) +REG32(CONFIG, offsetof(UfsReg, config)) + FIELD(CONFIG, QT, 0, 1) +REG32(MCQCONFIG, offsetof(UfsReg, mcqconfig)) + FIELD(MCQCONFIG, MAC, 8, 8) =20 #define UFS_INTR_MASK \ ((1 << R_IS_CEFES_SHIFT) | (1 << R_IS_SBFES_SHIFT) | \ @@ -157,6 +179,69 @@ REG32(CCAP, offsetof(UfsReg, ccap)) ((be32_to_cpu(dword2) >> UFS_UPIU_HEADER_DATA_SEGMENT_LENGTH_SHIFT) & \ UFS_UPIU_HEADER_DATA_SEGMENT_LENGTH_MASK) =20 +typedef struct QEMU_PACKED UfsMcqReg { + uint32_t sqattr; + uint32_t sqlba; + uint32_t squba; + uint32_t sqdao; + uint32_t sqisao; + uint32_t sqcfg; + uint32_t rsvd0[2]; + uint32_t cqattr; + uint32_t cqlba; + uint32_t cquba; + uint32_t cqdao; + uint32_t cqisao; + uint32_t cqcfg; + uint32_t rsvd1[2]; +} UfsMcqReg; + +REG32(SQATTR, offsetof(UfsMcqReg, sqattr)) + FIELD(SQATTR, SIZE, 0, 16) + FIELD(SQATTR, CQID, 16, 8) + FIELD(SQATTR, SQPL, 28, 3) + FIELD(SQATTR, SQEN, 31, 1) +REG32(SQLBA, offsetof(UfsMcqReg, sqlba)) +REG32(SQUBA, offsetof(UfsMcqReg, squba)) +REG32(SQDAO, offsetof(UfsMcqReg, sqdao)) +REG32(SQISAO, offsetof(UfsMcqReg, sqisao)) +REG32(SQCFG, offsetof(UfsMcqReg, sqcfg)) +REG32(CQATTR, offsetof(UfsMcqReg, cqattr)) + FIELD(CQATTR, SIZE, 0, 16) + FIELD(CQATTR, CQEN, 31, 1) +REG32(CQLBA, offsetof(UfsMcqReg, cqlba)) +REG32(CQUBA, offsetof(UfsMcqReg, cquba)) +REG32(CQDAO, offsetof(UfsMcqReg, cqdao)) +REG32(CQISAO, offsetof(UfsMcqReg, cqisao)) +REG32(CQCFG, offsetof(UfsMcqReg, cqcfg)) + +typedef struct QEMU_PACKED UfsMcqSqReg { + uint32_t hp; + uint32_t tp; + uint32_t rtc; + uint32_t cti; + uint32_t rts; +} UfsMcqSqReg; + +typedef struct QEMU_PACKED UfsMcqCqReg { + uint32_t hp; + uint32_t tp; +} UfsMcqCqReg; + +typedef struct QEMU_PACKED UfsMcqSqIntReg { + uint32_t is; + uint32_t ie; +} UfsMcqSqIntReg; + +typedef struct QEMU_PACKED UfsMcqCqIntReg { + uint32_t is; + uint32_t ie; + uint32_t iacr; +} UfsMcqCqIntReg; + +REG32(CQIS, offsetof(UfsMcqCqIntReg, is)) + FIELD(CQIS, TEPS, 0, 1) + typedef struct QEMU_PACKED DeviceDescriptor { uint8_t length; uint8_t descriptor_idn; @@ -1064,9 +1149,26 @@ typedef struct QEMU_PACKED UtpUpiuRsp { }; } UtpUpiuRsp; =20 +/* + * MCQ Completion Queue Entry + */ +typedef UtpTransferReqDesc UfsSqEntry; +typedef struct QEMU_PACKED UfsCqEntry { + uint64_t utp_addr; + uint16_t resp_len; + uint16_t resp_off; + uint16_t prdt_len; + uint16_t prdt_off; + uint8_t status; + uint8_t error; + uint16_t rsvd1; + uint32_t rsvd2[3]; +} UfsCqEntry; + static inline void _ufs_check_size(void) { - QEMU_BUILD_BUG_ON(sizeof(UfsReg) !=3D 0x104); + QEMU_BUILD_BUG_ON(sizeof(UfsReg) !=3D 0x38C); + QEMU_BUILD_BUG_ON(sizeof(UfsMcqReg) !=3D 64); QEMU_BUILD_BUG_ON(sizeof(DeviceDescriptor) !=3D 89); QEMU_BUILD_BUG_ON(sizeof(GeometryDescriptor) !=3D 87); QEMU_BUILD_BUG_ON(sizeof(UnitDescriptor) !=3D 45); @@ -1086,5 +1188,7 @@ static inline void _ufs_check_size(void) QEMU_BUILD_BUG_ON(sizeof(UtpTaskReqDesc) !=3D 80); QEMU_BUILD_BUG_ON(sizeof(UtpCmdRsp) !=3D 40); QEMU_BUILD_BUG_ON(sizeof(UtpUpiuRsp) !=3D 288); + QEMU_BUILD_BUG_ON(sizeof(UfsSqEntry) !=3D 32); + QEMU_BUILD_BUG_ON(sizeof(UfsCqEntry) !=3D 32); } #endif --=20 2.34.1 From nobody Mon Nov 25 07:59:26 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=samsung.com ARC-Seal: i=1; a=rsa-sha256; t=1716290264; cv=none; d=zohomail.com; s=zohoarc; b=aX4wo/Je5bX3j5OW0WFiXwsTtqa86J0V3yhSJI9orVCF5woMOO+ECZoTAChyaz3Y6Bf38cf1VtZNyAZTGutfNdSlco7tF6xKsUJ5+VKzjCJ16RnoBzZBDqAr7pefianzlhaAZ41WnmOcBJ4J+ikmwm0t58i5TOqF7SB8tGdYOpM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716290264; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HFQu6GWXz7aOOCEF9QSREk2falkXs0AMJY2xiYpyXQ4=; b=l9RWvZiXwvPSouVNvPD55m7L4w6y1qWDyXBC8ynDwQO0ocoUOWQWn/0fpHzb24o/IfiG5yM54ZsO6NHttkeBMwPUV9rfIGl/jB7g0QM8CoDoZReCaP+FUVfbk+5kq2p+Ljwi7qPy6V9Gn+Or1/Qy2tkqtPJLqj3DYm9B0UKphX8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716290264115356.978281984505; Tue, 21 May 2024 04:17:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9NUF-0007gf-Fi; Tue, 21 May 2024 07:16:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9NUD-0007fx-KJ for qemu-devel@nongnu.org; Tue, 21 May 2024 07:16:53 -0400 Received: from mailout4.samsung.com ([203.254.224.34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9NU8-0003wF-Vq for qemu-devel@nongnu.org; Tue, 21 May 2024 07:16:53 -0400 Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20240521111645epoutp043d51ef74258f2b4ef34d287f77f33947~RfNkwveak3165831658epoutp04N for ; Tue, 21 May 2024 11:16:45 +0000 (GMT) Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20240521111644epcas2p456b9bcfaac169280d09899b70fb2079c~RfNkcTjIB1106811068epcas2p4B; Tue, 21 May 2024 11:16:44 +0000 (GMT) Received: from epsmges2p3.samsung.com (unknown [182.195.36.68]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4VkBhr1Fsmz4x9Pw; Tue, 21 May 2024 11:16:44 +0000 (GMT) Received: from epcas2p4.samsung.com ( [182.195.41.56]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id B2.2C.09665.B928C466; Tue, 21 May 2024 20:16:44 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPA id 20240521111643epcas2p4ab1c2610d26878c405288e9006bc4f92~RfNjYEfz02788927889epcas2p4V; Tue, 21 May 2024 11:16:43 +0000 (GMT) Received: from epsmgmc1p1new.samsung.com (unknown [182.195.42.40]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240521111643epsmtrp23aa01e0ad3ecb421c891950f2a9c5654~RfNjXMo8y2930529305epsmtrp2R; Tue, 21 May 2024 11:16:43 +0000 (GMT) Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgmc1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 20.B4.09238.B928C466; Tue, 21 May 2024 20:16:43 +0900 (KST) Received: from localhost.dsn.sec.samsung.com (unknown [10.229.54.230]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20240521111643epsmtip170062d38760434fe028016e2e64fdc78~RfNjLuOWB0093400934epsmtip1m; Tue, 21 May 2024 11:16:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20240521111645epoutp043d51ef74258f2b4ef34d287f77f33947~RfNkwveak3165831658epoutp04N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1716290205; bh=HFQu6GWXz7aOOCEF9QSREk2falkXs0AMJY2xiYpyXQ4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mt7P19fmyPvDiD/07bBV73P0uDzrJO+q0JNqNnaihEuXB+dV+3LMXn8WzRX6vI4/P qbkhiOux6hhc366eIZRXLitmf/UeJlpV2Ts/GtRYlx/+4cnDBotAK3vfSq+ZYE6LIG 0/pRaJ5SFCWzJgZOKY8EHRQE2kbDFGxQJCEToz1A= X-AuditID: b6c32a47-93fff700000025c1-ca-664c829b920e From: Minwoo Im To: Jeuk Kim , Kevin Wolf , Hanna Reitz Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, gost.dev@samsung.com, Minwoo Im Subject: [PATCH 2/2] hw/ufs: Add support MCQ of UFSHCI 4.0 Date: Tue, 21 May 2024 20:05:44 +0900 Message-Id: <20240521110544.258772-3-minwoo.im@samsung.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240521110544.258772-1-minwoo.im@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPKsWRmVeSWpSXmKPExsWy7bCmhe6cJp80g2WnmSxuHtjJZPHgbj+j xf2t1xgtllxMtXh2+gCzxax37WwWx3t3sDiwezy5tpnJ4/2+q2wefVtWMQYwR2XbZKQmpqQW KaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gAtV1IoS8wpBQoFJBYX K+nb2RTll5akKmTkF5fYKqUWpOQUmBfoFSfmFpfmpevlpZZYGRoYGJkCFSZkZ6w9fZSx4NQd xor5OxawNTAeWsrYxcjJISFgIjH15EEgm4tDSGAHo8SH7S3sEM4nRokFN7ZCZb4xSnxZdR2u 5XjTQVaIxF5Gia9/l7KBJIQEfjNKnF5cBmKzCahLNEx9xQJiiwikS1x+txKogYODWSBb4uEN PRBTWMBKovevOkgFi4CqxP37b8GqeQWsJU597GKFWCUvsf/gWWaQck4BG4lT7+UgSgQlTs58 AlbODFTSvHU2M8g1EgLX2CWe/WyG6nWRuNS4EcoWlnh1fAs7hC0l8fndXjYIu1zi55tJUG9V SBycdZsNZJeEgL3EtecpEAdrSqzfpQ8RVZY4cgtqK59Ex+G/7BBhXomONiGIGcoSHw8dYoaw JSWWX3oNtcdD4umE/9Cw7GeUePrjH8sERoVZSJ6ZheSZWQiLFzAyr2IUSy0ozk1PLTYqMIZH b3J+7iZGcErUct/BOOPtB71DjEwcjIcYJTiYlUR4N23xTBPiTUmsrEotyo8vKs1JLT7EaAoM 6YnMUqLJ+cCknFcSb2hiaWBiZmZobmRqYK4kznuvdW6KkEB6YklqdmpqQWoRTB8TB6dUA1OF i/HqKFHZx2f6f4rm/2eY7Mtjxr6kzktxUuptSc8zq1dO0JDpmOjq77+88lu/2hHp5QZfTZYv em4hqxthO+mRa6Bywc0mgWhbwxDJTn8Ju8Oi+a/4D4S8lqm01ncJD+u9eFoi+a9x5JwJq4wN 9j3QXtAqM0GNk5Vng8iKMrbAy5onuia/MY4s8Xzl8/H7n0T1JEkV1sLueInJZ1Unb10hN7/M rU9AuYHhnvS9hwm9HHq8z1l9a1ki5tcpn4oLzo+XifnJk/nQm8MjuvtUKxeL8fwNSmJJzHMO SCw42N23/8OxPwXrs3u2Vu32c3xndjVzL7vh/eLTNkfPt3MarVnRecTQ5//95J4ZPV+UWIoz Eg21mIuKEwHLMxpyEgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDLMWRmVeSWpSXmKPExsWy7bCSnO7sJp80g3+tmhY3D+xksnhwt5/R 4v7Wa4wWSy6mWjw7fYDZYta7djaL4707WBzYPZ5c28zk8X7fVTaPvi2rGAOYo7hsUlJzMstS i/TtErgy1p4+ylhw6g5jxfwdC9gaGA8tZexi5OSQEDCRON50kLWLkYtDSGA3o8TcVW9YIBKS EvtO32SFsIUl7rccgSr6ySgx+c9hsCI2AXWJhqmvwGwRgUyJha862EFsZoF8ia6OBUxdjBwc wgJWEr1/1UHCLAKqEvfvvwUr5xWwljj1sQtqvrzE/oNnmUHKOQVsJE69lwMxhYBKrrZxQ1QL Spyc+YQFYri8RPPW2cwTGAVmIUnNQpJawMi0ilEytaA4Nz032bDAMC+1XK84Mbe4NC9dLzk/ dxMjOIC1NHYw3pv/T+8QIxMH4yFGCQ5mJRHeTVs804R4UxIrq1KL8uOLSnNSiw8xSnOwKInz Gs6YnSIkkJ5YkpqdmlqQWgSTZeLglGpg8mtYIeW4UD39ROHqbH3P99PmTD2a2zg/rzVDW3Ja JeOb07+1nGXffCmf5qX/KbDbqs3j5rqMLbF7pvy+sLjf/2hh593NRrzLOKfvS97StbHHi62S KyFH5FlmzcM3ZsFvLn1hOqDNtyf5m8fCvcp7d4ifi5a9aC2g22l+UKppubL/jeInfikVk6pf R704rywaPmt6veueiCda787U8TyyP/7Yvf6mj1zb3LaPBvwLTFcfTLrdHGL6XNFaUu7pnQly c1Z0yPYkOr20DOaZJqS3IGtbnWfZ0lCjDYWJda+kV9ya9HLK/BWvLt0t4LI8rPKlzGHG87/O d7JeZOxgf73aSDEqgVGe+eyqzXknlgRrKLEUZyQaajEXFScCADCfAiDPAgAA X-CMS-MailID: 20240521111643epcas2p4ab1c2610d26878c405288e9006bc4f92 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20240521111643epcas2p4ab1c2610d26878c405288e9006bc4f92 References: <20240521110544.258772-1-minwoo.im@samsung.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=203.254.224.34; envelope-from=minwoo.im@samsung.com; helo=mailout4.samsung.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @samsung.com) X-ZM-MESSAGEID: 1716290264400100001 This patch adds support for MCQ defined in UFSHCI 4.0. This patch utilized the legacy I/O codes as much as possible to support MCQ. MCQ operation & runtime register is placed at 0x1000 offset of UFSHCI register statically with no spare space among four registers (48B): UfsMcqSqReg, UfsMcqSqIntReg, UfsMcqCqReg, UfsMcqCqIntReg The maxinum number of queue is 32 as per spec, and the default MAC(Multiple Active Commands) are 32 in the device. Example: -device ufs,serial=3Dfoo,id=3Dufs0,mcq=3Dtrue,mcq-maxq=3D8 Signed-off-by: Minwoo Im --- hw/ufs/trace-events | 17 ++ hw/ufs/ufs.c | 474 ++++++++++++++++++++++++++++++++++++++++++-- hw/ufs/ufs.h | 98 ++++++++- include/block/ufs.h | 23 ++- 4 files changed, 592 insertions(+), 20 deletions(-) diff --git a/hw/ufs/trace-events b/hw/ufs/trace-events index 665e1a942b..dda7f8a2e5 100644 --- a/hw/ufs/trace-events +++ b/hw/ufs/trace-events @@ -11,13 +11,18 @@ ufs_exec_nop_cmd(uint32_t slot) "UTRLDBR slot %"PRIu32"" ufs_exec_scsi_cmd(uint32_t slot, uint8_t lun, uint8_t opcode) "slot %"PRIu= 32", lun 0x%"PRIx8", opcode 0x%"PRIx8"" ufs_exec_query_cmd(uint32_t slot, uint8_t opcode) "slot %"PRIu32", opcode = 0x%"PRIx8"" ufs_process_uiccmd(uint32_t uiccmd, uint32_t ucmdarg1, uint32_t ucmdarg2, = uint32_t ucmdarg3) "uiccmd 0x%"PRIx32", ucmdarg1 0x%"PRIx32", ucmdarg2 0x%"= PRIx32", ucmdarg3 0x%"PRIx32"" +ufs_mcq_complete_req(uint8_t qid) "sqid %"PRIu8"" +ufs_mcq_create_sq(uint8_t sqid, uint8_t cqid, uint64_t addr, uint16_t size= ) "mcq create sq sqid %"PRIu8", cqid %"PRIu8", addr 0x%"PRIx64", size %"PRI= u16"" +ufs_mcq_create_cq(uint8_t cqid, uint64_t addr, uint16_t size) "mcq create = cq cqid %"PRIu8", addr 0x%"PRIx64", size %"PRIu16"" =20 # error condition ufs_err_dma_read_utrd(uint32_t slot, uint64_t addr) "failed to read utrd. = UTRLDBR slot %"PRIu32", UTRD dma addr %"PRIu64"" ufs_err_dma_read_req_upiu(uint32_t slot, uint64_t addr) "failed to read re= q upiu. UTRLDBR slot %"PRIu32", request upiu addr %"PRIu64"" ufs_err_dma_read_prdt(uint32_t slot, uint64_t addr) "failed to read prdt. = UTRLDBR slot %"PRIu32", prdt addr %"PRIu64"" +ufs_err_dma_read_sq(uint8_t qid, uint64_t addr) "failed to read sqe. SQ qi= d %"PRIu8", sqe addr %"PRIu64"" ufs_err_dma_write_utrd(uint32_t slot, uint64_t addr) "failed to write utrd= . UTRLDBR slot %"PRIu32", UTRD dma addr %"PRIu64"" ufs_err_dma_write_rsp_upiu(uint32_t slot, uint64_t addr) "failed to write = rsp upiu. UTRLDBR slot %"PRIu32", response upiu addr %"PRIu64"" +ufs_err_dma_write_cq(uint32_t cqid, uint64_t addr) "failed to write cq ent= ry. cqid %"PRIu8", hwaddr %"PRIu64"" ufs_err_utrl_slot_error(uint32_t slot) "UTRLDBR slot %"PRIu32" is in error" ufs_err_utrl_slot_busy(uint32_t slot) "UTRLDBR slot %"PRIu32" is busy" ufs_err_unsupport_register_offset(uint32_t offset) "Register offset 0x%"PR= Ix32" is not yet supported" @@ -31,3 +36,15 @@ ufs_err_query_invalid_opcode(uint8_t opcode) "query requ= est has invalid opcode. ufs_err_query_invalid_idn(uint8_t opcode, uint8_t idn) "query request has = invalid idn. opcode: 0x%"PRIx8", idn 0x%"PRIx8"" ufs_err_query_invalid_index(uint8_t opcode, uint8_t index) "query request = has invalid index. opcode: 0x%"PRIx8", index 0x%"PRIx8"" ufs_err_invalid_trans_code(uint32_t slot, uint8_t trans_code) "request upi= u has invalid transaction code. slot: %"PRIu32", trans_code: 0x%"PRIx8"" +ufs_err_mcq_db_wr_invalid_sqid(uint8_t qid) "invalid mcq sqid %"PRIu8"" +ufs_err_mcq_db_wr_invalid_db(uint8_t qid, uint32_t db) "invalid mcq doorbe= ll sqid %"PRIu8", db %"PRIu32"" +ufs_err_mcq_create_sq_invalid_sqid(uint8_t qid) "invalid mcq sqid %"PRIu8"" +ufs_err_mcq_create_sq_invalid_cqid(uint8_t qid) "invalid mcq cqid %"PRIu8"" +ufs_err_mcq_create_sq_already_exists(uint8_t qid) "mcq sqid %"PRIu8 "alrea= dy exists" +ufs_err_mcq_delete_sq_invalid_sqid(uint8_t qid) "invalid mcq sqid %"PRIu8"" +ufs_err_mcq_delete_sq_not_exists(uint8_t qid) "mcq sqid %"PRIu8 "not exist= s" +ufs_err_mcq_create_cq_invalid_cqid(uint8_t qid) "invalid mcq cqid %"PRIu8"" +ufs_err_mcq_create_cq_already_exists(uint8_t qid) "mcq cqid %"PRIu8 "alrea= dy exists" +ufs_err_mcq_delete_cq_invalid_cqid(uint8_t qid) "invalid mcq cqid %"PRIu8"" +ufs_err_mcq_delete_cq_not_exists(uint8_t qid) "mcq cqid %"PRIu8 "not exist= s" +ufs_err_mcq_delete_cq_sq_not_deleted(uint8_t sqid, uint8_t cqid) "mcq sq %= "PRIu8" still has cq %"PRIu8"" diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c index bac78a32bb..d8b301f12d 100644 --- a/hw/ufs/ufs.c +++ b/hw/ufs/ufs.c @@ -9,7 +9,7 @@ */ =20 /** - * Reference Specs: https://www.jedec.org/, 3.1 + * Reference Specs: https://www.jedec.org/, 4.0 * * Usage * ----- @@ -28,10 +28,45 @@ #include "trace.h" #include "ufs.h" =20 -/* The QEMU-UFS device follows spec version 3.1 */ -#define UFS_SPEC_VER 0x0310 +/* The QEMU-UFS device follows spec version 4.0 */ +#define UFS_SPEC_VER 0x0400 #define UFS_MAX_NUTRS 32 #define UFS_MAX_NUTMRS 8 +#define UFS_MCQ_QCFGPTR 2 + +static void ufs_exec_req(UfsRequest *req); +static void ufs_clear_req(UfsRequest *req); + +static inline uint64_t ufs_mcq_reg_addr(UfsHc *u, int qid) +{ + /* Submission Queue MCQ Registers offset (400h) */ + return (UFS_MCQ_QCFGPTR * 0x200) + qid * 0x40; +} + +static inline uint64_t ufs_mcq_op_reg_addr(UfsHc *u, int qid) +{ + /* MCQ Operation & Runtime Registers offset (1000h) */ + return UFS_MCQ_OPR_START + qid * 48; +} + +static inline uint64_t ufs_reg_size(UfsHc *u) +{ + /* Total UFS HCI Register size in bytes */ + return ufs_mcq_op_reg_addr(u, 0) + sizeof(u->mcq_op_reg); +} + +static inline bool ufs_is_mcq_reg(UfsHc *u, uint64_t addr) +{ + uint64_t mcq_reg_addr =3D ufs_mcq_reg_addr(u, 0); + return addr >=3D mcq_reg_addr && addr < mcq_reg_addr + sizeof(u->mcq_r= eg); +} + +static inline bool ufs_is_mcq_op_reg(UfsHc *u, uint64_t addr) +{ + uint64_t mcq_op_reg_addr =3D ufs_mcq_op_reg_addr(u, 0); + return (addr >=3D mcq_op_reg_addr && + addr < mcq_op_reg_addr + sizeof(u->mcq_op_reg)); +} =20 static MemTxResult ufs_addr_read(UfsHc *u, hwaddr addr, void *buf, int siz= e) { @@ -181,9 +216,14 @@ static MemTxResult ufs_dma_read_upiu(UfsRequest *req) { MemTxResult ret; =20 - ret =3D ufs_dma_read_utrd(req); - if (ret) { - return ret; + /* + * In case of MCQ, UTRD has already been read from a SQ, so skip it. + */ + if (!ufs_mcq_req(req)) { + ret =3D ufs_dma_read_utrd(req); + if (ret) { + return ret; + } } =20 ret =3D ufs_dma_read_req_upiu(req); @@ -335,6 +375,221 @@ static void ufs_process_uiccmd(UfsHc *u, uint32_t val) ufs_irq_check(u); } =20 +static void ufs_mcq_init_req(UfsHc *u, UfsRequest *req, UfsSq *sq) +{ + memset(req, 0, sizeof(*req)); + + req->hc =3D u; + req->state =3D UFS_REQUEST_IDLE; + req->slot =3D UFS_INVALID_SLOT; + req->sq =3D sq; +} + +static void ufs_mcq_process_sq(void *opaque) +{ + UfsSq *sq =3D opaque; + UfsHc *u =3D sq->u; + UfsSqEntry sqe; + UfsRequest *req; + hwaddr addr; + uint16_t head =3D ufs_mcq_sq_head(u, sq->sqid); + int err; + + while (!(ufs_mcq_sq_empty(u, sq->sqid) || QTAILQ_EMPTY(&sq->req_list))= ) { + addr =3D sq->addr + head; + err =3D ufs_addr_read(sq->u, addr, (void *)&sqe, sizeof(sqe)); + if (err) { + trace_ufs_err_dma_read_sq(sq->sqid, addr); + return; + } + + head =3D (head + sizeof(sqe)) % (sq->size * sizeof(sqe)); + ufs_mcq_update_sq_head(u, sq->sqid, head); + + req =3D QTAILQ_FIRST(&sq->req_list); + QTAILQ_REMOVE(&sq->req_list, req, entry); + + ufs_mcq_init_req(sq->u, req, sq); + memcpy(&req->utrd, &sqe, sizeof(req->utrd)); + + req->state =3D UFS_REQUEST_RUNNING; + ufs_exec_req(req); + } +} + +static void ufs_mcq_process_cq(void *opaque) +{ + UfsCq *cq =3D opaque; + UfsHc *u =3D cq->u; + UfsRequest *req, *next; + MemTxResult ret; + uint32_t tail =3D ufs_mcq_cq_tail(u, cq->cqid); + + QTAILQ_FOREACH_SAFE(req, &cq->req_list, entry, next) { + ufs_dma_write_rsp_upiu(req); + + req->cqe.utp_addr =3D + ((uint64_t)req->utrd.command_desc_base_addr_hi << 32ULL) | + req->utrd.command_desc_base_addr_lo; + req->cqe.utp_addr |=3D req->sq->sqid; + req->cqe.resp_len =3D req->utrd.response_upiu_length; + req->cqe.resp_off =3D req->utrd.response_upiu_offset; + req->cqe.prdt_len =3D req->utrd.prd_table_length; + req->cqe.prdt_off =3D req->utrd.prd_table_offset; + req->cqe.status =3D req->utrd.header.dword_2 & 0xf; + req->cqe.error =3D 0; + + ret =3D ufs_addr_write(u, cq->addr + tail, &req->cqe, + sizeof(req->cqe)); + if (ret) { + trace_ufs_err_dma_write_cq(cq->cqid, cq->addr + tail); + } + QTAILQ_REMOVE(&cq->req_list, req, entry); + + tail =3D (tail + sizeof(req->cqe)) % (cq->size * sizeof(req->cqe)); + ufs_mcq_update_cq_tail(u, cq->cqid, tail); + + ufs_clear_req(req); + QTAILQ_INSERT_TAIL(&req->sq->req_list, req, entry); + } + + if (!ufs_mcq_cq_empty(u, cq->cqid)) { + u->mcq_op_reg[cq->cqid].cq_int.is =3D + FIELD_DP32(u->mcq_op_reg[cq->cqid].cq_int.is, CQIS, TEPS, 1); + + u->reg.is =3D FIELD_DP32(u->reg.is, IS, CQES, 1); + ufs_irq_check(u); + } +} + +static bool ufs_mcq_create_sq(UfsHc *u, uint8_t qid, uint32_t attr) +{ + UfsMcqReg *reg =3D &u->mcq_reg[qid]; + UfsSq *sq; + uint8_t cqid =3D FIELD_EX32(attr, SQATTR, CQID); + + if (qid >=3D u->params.mcq_maxq) { + trace_ufs_err_mcq_create_sq_invalid_sqid(qid); + return false; + } + + if (u->sq[qid]) { + trace_ufs_err_mcq_create_sq_already_exists(qid); + return false; + } + + if (!u->cq[cqid]) { + trace_ufs_err_mcq_create_sq_invalid_cqid(qid); + return false; + } + + sq =3D g_malloc0(sizeof(*sq)); + sq->u =3D u; + sq->sqid =3D qid; + sq->cq =3D u->cq[cqid]; + sq->addr =3D ((uint64_t)reg->squba << 32) | reg->sqlba; + sq->size =3D + ((FIELD_EX32(attr, SQATTR, SIZE) + 1) << 2) / sizeof(UfsSqEntry); + + sq->bh =3D qemu_bh_new_guarded(ufs_mcq_process_sq, sq, + &DEVICE(u)->mem_reentrancy_guard); + sq->req =3D g_new0(UfsRequest, sq->size); + QTAILQ_INIT(&sq->req_list); + for (int i =3D 0; i < sq->size; i++) { + ufs_mcq_init_req(u, &sq->req[i], sq); + QTAILQ_INSERT_TAIL(&sq->req_list, &sq->req[i], entry); + } + + u->sq[qid] =3D sq; + + trace_ufs_mcq_create_sq(sq->sqid, sq->cq->cqid, sq->addr, sq->size); + return true; +} + +static bool ufs_mcq_delete_sq(UfsHc *u, uint8_t qid) +{ + UfsSq *sq; + + if (qid >=3D u->params.mcq_maxq) { + trace_ufs_err_mcq_delete_sq_invalid_sqid(qid); + return false; + } + + if (!u->sq[qid]) { + trace_ufs_err_mcq_delete_sq_not_exists(qid); + return false; + } + + sq =3D u->sq[qid]; + + qemu_bh_delete(sq->bh); + g_free(sq->req); + g_free(sq); + u->sq[qid] =3D NULL; + return true; +} + +static bool ufs_mcq_create_cq(UfsHc *u, uint8_t qid, uint32_t attr) +{ + UfsMcqReg *reg =3D &u->mcq_reg[qid]; + UfsCq *cq; + + if (qid >=3D u->params.mcq_maxq) { + trace_ufs_err_mcq_create_cq_invalid_cqid(qid); + return false; + } + + if (u->cq[qid]) { + trace_ufs_err_mcq_create_cq_already_exists(qid); + return false; + } + + cq =3D g_malloc0(sizeof(*cq)); + cq->u =3D u; + cq->cqid =3D qid; + cq->addr =3D ((uint64_t)reg->cquba << 32) | reg->cqlba; + cq->size =3D + ((FIELD_EX32(attr, CQATTR, SIZE) + 1) << 2) / sizeof(UfsCqEntry); + + cq->bh =3D qemu_bh_new_guarded(ufs_mcq_process_cq, cq, + &DEVICE(u)->mem_reentrancy_guard); + QTAILQ_INIT(&cq->req_list); + + u->cq[qid] =3D cq; + + trace_ufs_mcq_create_cq(cq->cqid, cq->addr, cq->size); + return true; +} + +static bool ufs_mcq_delete_cq(UfsHc *u, uint8_t qid) +{ + UfsCq *cq; + + if (qid >=3D u->params.mcq_maxq) { + trace_ufs_err_mcq_delete_cq_invalid_cqid(qid); + return false; + } + + if (!u->cq[qid]) { + trace_ufs_err_mcq_delete_cq_not_exists(qid); + return false; + } + + for (int i =3D 0; i < ARRAY_SIZE(u->sq); i++) { + if (u->sq[i] && u->sq[i]->cq->cqid =3D=3D qid) { + trace_ufs_err_mcq_delete_cq_sq_not_deleted(i, qid); + return false; + } + } + + cq =3D u->cq[qid]; + + qemu_bh_delete(cq->bh); + g_free(cq); + u->cq[qid] =3D NULL; + return true; +} + static void ufs_write_reg(UfsHc *u, hwaddr offset, uint32_t data, unsigned= size) { switch (offset) { @@ -390,6 +645,12 @@ static void ufs_write_reg(UfsHc *u, hwaddr offset, uin= t32_t data, unsigned size) case A_UCMDARG3: u->reg.ucmdarg3 =3D data; break; + case A_CONFIG: + u->reg.config =3D data; + break; + case A_MCQCONFIG: + u->reg.mcqconfig =3D data; + break; case A_UTRLCLR: case A_UTMRLDBR: case A_UTMRLCLR: @@ -402,18 +663,138 @@ static void ufs_write_reg(UfsHc *u, hwaddr offset, u= int32_t data, unsigned size) } } =20 +static void ufs_write_mcq_reg(UfsHc *u, hwaddr offset, uint32_t data, + unsigned size) +{ + int qid =3D offset / sizeof(UfsMcqReg); + UfsMcqReg *reg =3D &u->mcq_reg[qid]; + + switch (offset % sizeof(UfsMcqReg)) { + case A_SQATTR: + if (!FIELD_EX32(reg->sqattr, SQATTR, SQEN) && + FIELD_EX32(data, SQATTR, SQEN)) { + if (!ufs_mcq_create_sq(u, qid, data)) { + break; + } + } else if (FIELD_EX32(reg->sqattr, SQATTR, SQEN) && + !FIELD_EX32(data, SQATTR, SQEN)) { + if (!ufs_mcq_delete_sq(u, qid)) { + break; + } + } + reg->sqattr =3D data; + break; + case A_SQLBA: + reg->sqlba =3D data; + break; + case A_SQUBA: + reg->squba =3D data; + break; + case A_SQCFG: + reg->sqcfg =3D data; + break; + case A_CQATTR: + if (!FIELD_EX32(reg->cqattr, CQATTR, CQEN) && + FIELD_EX32(data, CQATTR, CQEN)) { + if (!ufs_mcq_create_cq(u, qid, data)) { + break; + } + } else if (FIELD_EX32(reg->cqattr, CQATTR, CQEN) && + !FIELD_EX32(data, CQATTR, CQEN)) { + if (!ufs_mcq_delete_cq(u, qid)) { + break; + } + } + reg->cqattr =3D data; + break; + case A_CQLBA: + reg->cqlba =3D data; + break; + case A_CQUBA: + reg->cquba =3D data; + break; + case A_CQCFG: + reg->cqcfg =3D data; + break; + case A_SQDAO: + case A_SQISAO: + case A_CQDAO: + case A_CQISAO: + trace_ufs_err_unsupport_register_offset(offset); + break; + default: + trace_ufs_err_invalid_register_offset(offset); + break; + } +} + +static void ufs_mcq_process_db(UfsHc *u, uint8_t qid, uint32_t db) +{ + UfsSq *sq; + + if (qid >=3D u->params.mcq_maxq) { + trace_ufs_err_mcq_db_wr_invalid_sqid(qid); + return; + } + + sq =3D u->sq[qid]; + if (sq->size * sizeof(UfsSqEntry) <=3D db) { + trace_ufs_err_mcq_db_wr_invalid_db(qid, db); + return; + } + + ufs_mcq_update_sq_tail(u, sq->sqid, db); + qemu_bh_schedule(sq->bh); +} + +static void ufs_write_mcq_op_reg(UfsHc *u, hwaddr offset, uint32_t data, + unsigned size) +{ + int qid =3D offset / sizeof(UfsMcqOpReg); + UfsMcqOpReg *opr =3D &u->mcq_op_reg[qid]; + + switch (offset % sizeof(UfsMcqOpReg)) { + case offsetof(UfsMcqOpReg, sq.tp): + if (opr->sq.tp !=3D data) { + ufs_mcq_process_db(u, qid, data); + } + opr->sq.tp =3D data; + break; + case offsetof(UfsMcqOpReg, cq.hp): + opr->cq.hp =3D data; + ufs_mcq_update_cq_head(u, qid, data); + break; + case offsetof(UfsMcqOpReg, cq_int.is): + opr->cq_int.is &=3D ~data; + break; + default: + trace_ufs_err_invalid_register_offset(offset); + break; + } +} + static uint64_t ufs_mmio_read(void *opaque, hwaddr addr, unsigned size) { UfsHc *u =3D (UfsHc *)opaque; - uint8_t *ptr =3D (uint8_t *)&u->reg; + uint8_t *ptr; uint64_t value; - - if (addr > sizeof(u->reg) - size) { + uint64_t offset; + + if (addr < sizeof(u->reg)) { + offset =3D addr; + ptr =3D (uint8_t *)&u->reg; + } else if (ufs_is_mcq_reg(u, addr)) { + offset =3D addr - ufs_mcq_reg_addr(u, 0); + ptr =3D (uint8_t *)&u->mcq_reg; + } else if (ufs_is_mcq_op_reg(u, addr)) { + offset =3D addr - ufs_mcq_op_reg_addr(u, 0); + ptr =3D (uint8_t *)&u->mcq_op_reg; + } else { trace_ufs_err_invalid_register_offset(addr); return 0; } =20 - value =3D *(uint32_t *)(ptr + addr); + value =3D *(uint32_t *)(ptr + offset); trace_ufs_mmio_read(addr, value, size); return value; } @@ -423,13 +804,18 @@ static void ufs_mmio_write(void *opaque, hwaddr addr,= uint64_t data, { UfsHc *u =3D (UfsHc *)opaque; =20 - if (addr > sizeof(u->reg) - size) { + trace_ufs_mmio_write(addr, data, size); + + if (addr < sizeof(u->reg)) { + ufs_write_reg(u, addr, data, size); + } else if (ufs_is_mcq_reg(u, addr)) { + ufs_write_mcq_reg(u, addr - ufs_mcq_reg_addr(u, 0), data, size); + } else if (ufs_is_mcq_op_reg(u, addr)) { + ufs_write_mcq_op_reg(u, addr - ufs_mcq_op_reg_addr(u, 0), + data, size); + } else { trace_ufs_err_invalid_register_offset(addr); - return; } - - trace_ufs_mmio_write(addr, data, size); - ufs_write_reg(u, addr, data, size); } =20 static const MemoryRegionOps ufs_mmio_ops =3D { @@ -1086,9 +1472,16 @@ void ufs_complete_req(UfsRequest *req, UfsReqResult = req_result) req->utrd.header.dword_2 =3D cpu_to_le32(UFS_OCS_INVALID_CMD_TABLE= _ATTR); } =20 - trace_ufs_complete_req(req->slot); req->state =3D UFS_REQUEST_COMPLETE; - qemu_bh_schedule(u->complete_bh); + + if (ufs_mcq_req(req)) { + trace_ufs_mcq_complete_req(req->sq->sqid); + QTAILQ_INSERT_TAIL(&req->sq->cq->req_list, req, entry); + qemu_bh_schedule(req->sq->cq->bh); + } else { + trace_ufs_complete_req(req->slot); + qemu_bh_schedule(u->complete_bh); + } } =20 static void ufs_clear_req(UfsRequest *req) @@ -1158,6 +1551,11 @@ static bool ufs_check_constraints(UfsHc *u, Error **= errp) return false; } =20 + if (u->params.mcq_maxq >=3D UFS_MAX_MCQ_QNUM) { + error_setg(errp, "mcq-maxq must be less than %d", UFS_MAX_MCQ_QNUM= ); + return false; + } + return true; } =20 @@ -1189,15 +1587,24 @@ static void ufs_init_state(UfsHc *u) &DEVICE(u)->mem_reentrancy_guard); u->complete_bh =3D qemu_bh_new_guarded(ufs_sendback_req, u, &DEVICE(u)->mem_reentrancy_guard); + + if (u->params.mcq) { + memset(u->sq, 0, sizeof(u->sq)); + memset(u->cq, 0, sizeof(u->cq)); + } } =20 static void ufs_init_hc(UfsHc *u) { uint32_t cap =3D 0; + uint32_t mcqconfig =3D 0; + uint32_t mcqcap =3D 0; =20 - u->reg_size =3D pow2ceil(sizeof(UfsReg)); + u->reg_size =3D pow2ceil(ufs_reg_size(u)); =20 memset(&u->reg, 0, sizeof(u->reg)); + memset(&u->mcq_reg, 0, sizeof(u->mcq_reg)); + memset(&u->mcq_op_reg, 0, sizeof(u->mcq_op_reg)); cap =3D FIELD_DP32(cap, CAP, NUTRS, (u->params.nutrs - 1)); cap =3D FIELD_DP32(cap, CAP, RTT, 2); cap =3D FIELD_DP32(cap, CAP, NUTMRS, (u->params.nutmrs - 1)); @@ -1206,7 +1613,29 @@ static void ufs_init_hc(UfsHc *u) cap =3D FIELD_DP32(cap, CAP, OODDS, 0); cap =3D FIELD_DP32(cap, CAP, UICDMETMS, 0); cap =3D FIELD_DP32(cap, CAP, CS, 0); + cap =3D FIELD_DP32(cap, CAP, LSDBS, 1); + cap =3D FIELD_DP32(cap, CAP, MCQS, u->params.mcq); u->reg.cap =3D cap; + + if (u->params.mcq) { + mcqconfig =3D FIELD_DP32(mcqconfig, MCQCONFIG, MAC, 0x1f); + u->reg.mcqconfig =3D mcqconfig; + + mcqcap =3D FIELD_DP32(mcqcap, MCQCAP, MAXQ, u->params.mcq_maxq - 1= ); + mcqcap =3D FIELD_DP32(mcqcap, MCQCAP, RRP, 1); + mcqcap =3D FIELD_DP32(mcqcap, MCQCAP, QCFGPTR, UFS_MCQ_QCFGPTR); + u->reg.mcqcap =3D mcqcap; + + for (int i =3D 0; i < ARRAY_SIZE(u->mcq_reg); i++) { + uint64_t addr =3D ufs_mcq_op_reg_addr(u, i); + u->mcq_reg[i].sqdao =3D addr; + u->mcq_reg[i].sqisao =3D addr + sizeof(UfsMcqSqReg); + addr +=3D sizeof(UfsMcqSqReg); + u->mcq_reg[i].cqdao =3D addr + sizeof(UfsMcqSqIntReg); + addr +=3D sizeof(UfsMcqSqIntReg); + u->mcq_reg[i].cqisao =3D addr + sizeof(UfsMcqCqReg); + } + } u->reg.ver =3D UFS_SPEC_VER; =20 memset(&u->device_desc, 0, sizeof(DeviceDescriptor)); @@ -1288,12 +1717,21 @@ static void ufs_exit(PCIDevice *pci_dev) ufs_clear_req(&u->req_list[i]); } g_free(u->req_list); + + for (int i =3D 0; i < ARRAY_SIZE(u->sq); i++) { + ufs_mcq_delete_sq(u, i); + } + for (int i =3D 0; i < ARRAY_SIZE(u->cq); i++) { + ufs_mcq_delete_cq(u, i); + } } =20 static Property ufs_props[] =3D { DEFINE_PROP_STRING("serial", UfsHc, params.serial), DEFINE_PROP_UINT8("nutrs", UfsHc, params.nutrs, 32), DEFINE_PROP_UINT8("nutmrs", UfsHc, params.nutmrs, 8), + DEFINE_PROP_BOOL("mcq", UfsHc, params.mcq, false), + DEFINE_PROP_UINT8("mcq-maxq", UfsHc, params.mcq_maxq, 1), DEFINE_PROP_END_OF_LIST(), }; =20 diff --git a/hw/ufs/ufs.h b/hw/ufs/ufs.h index 8fda94f4ef..6c9382cbc4 100644 --- a/hw/ufs/ufs.h +++ b/hw/ufs/ufs.h @@ -16,6 +16,7 @@ #include "block/ufs.h" =20 #define UFS_MAX_LUS 32 +#define UFS_MAX_MCQ_QNUM 32 #define UFS_BLOCK_SIZE_SHIFT 12 #define UFS_BLOCK_SIZE (1 << UFS_BLOCK_SIZE_SHIFT) =20 @@ -45,10 +46,11 @@ typedef enum UfsReqResult { UFS_REQUEST_NO_COMPLETE =3D 2, } UfsReqResult; =20 +#define UFS_INVALID_SLOT (-1) typedef struct UfsRequest { struct UfsHc *hc; UfsRequestState state; - int slot; + int slot; /* -1 when it's a MCQ request */ =20 UtpTransferReqDesc utrd; UtpUpiuReq req_upiu; @@ -57,8 +59,18 @@ typedef struct UfsRequest { /* for scsi command */ QEMUSGList *sg; uint32_t data_len; + + /* for MCQ */ + struct UfsSq *sq; + struct UfsCqEntry cqe; + QTAILQ_ENTRY(UfsRequest) entry; } UfsRequest; =20 +static inline bool ufs_mcq_req(UfsRequest *req) +{ + return req->sq !=3D NULL; +} + struct UfsLu; typedef UfsReqResult (*UfsScsiOp)(struct UfsLu *, UfsRequest *); =20 @@ -76,13 +88,43 @@ typedef struct UfsParams { char *serial; uint8_t nutrs; /* Number of UTP Transfer Request Slots */ uint8_t nutmrs; /* Number of UTP Task Management Request Slots */ + bool mcq; /* Multiple Command Queue support */ + uint8_t mcq_qcfgptr; /* MCQ Queue Configuration Pointer in MCQCAP */ + uint8_t mcq_maxq; /* MCQ Maximum number of Queues */ } UfsParams; =20 +/* + * MCQ Properties + */ +typedef struct UfsSq { + struct UfsHc *u; + uint8_t sqid; + struct UfsCq *cq; + uint64_t addr; + uint16_t size; /* A number of entries (qdepth) */ + + QEMUBH *bh; /* Bottom half to process requests in async */ + UfsRequest *req; + QTAILQ_HEAD(, UfsRequest) req_list; /* Free request list */ +} UfsSq; + +typedef struct UfsCq { + struct UfsHc *u; + uint8_t cqid; + uint64_t addr; + uint16_t size; /* A number of entries (qdepth) */ + + QEMUBH *bh; + QTAILQ_HEAD(, UfsRequest) req_list; +} UfsCq; + typedef struct UfsHc { PCIDevice parent_obj; UfsBus bus; MemoryRegion iomem; UfsReg reg; + UfsMcqReg mcq_reg[UFS_MAX_MCQ_QNUM]; + UfsMcqOpReg mcq_op_reg[UFS_MAX_MCQ_QNUM]; UfsParams params; uint32_t reg_size; UfsRequest *req_list; @@ -100,8 +142,62 @@ typedef struct UfsHc { qemu_irq irq; QEMUBH *doorbell_bh; QEMUBH *complete_bh; + + /* MCQ properties */ + UfsSq *sq[UFS_MAX_MCQ_QNUM]; + UfsCq *cq[UFS_MAX_MCQ_QNUM]; } UfsHc; =20 +static inline uint32_t ufs_mcq_sq_tail(UfsHc *u, uint32_t qid) +{ + return u->mcq_op_reg[qid].sq.tp; +} + +static inline void ufs_mcq_update_sq_tail(UfsHc *u, uint32_t qid, uint32_t= db) +{ + u->mcq_op_reg[qid].sq.tp =3D db; +} + +static inline uint32_t ufs_mcq_sq_head(UfsHc *u, uint32_t qid) +{ + return u->mcq_op_reg[qid].sq.hp; +} + +static inline void ufs_mcq_update_sq_head(UfsHc *u, uint32_t qid, uint32_t= db) +{ + u->mcq_op_reg[qid].sq.hp =3D db; +} + +static inline bool ufs_mcq_sq_empty(UfsHc *u, uint32_t qid) +{ + return ufs_mcq_sq_tail(u, qid) =3D=3D ufs_mcq_sq_head(u, qid); +} + +static inline uint32_t ufs_mcq_cq_tail(UfsHc *u, uint32_t qid) +{ + return u->mcq_op_reg[qid].cq.tp; +} + +static inline void ufs_mcq_update_cq_tail(UfsHc *u, uint32_t qid, uint32_t= db) +{ + u->mcq_op_reg[qid].cq.tp =3D db; +} + +static inline uint32_t ufs_mcq_cq_head(UfsHc *u, uint32_t qid) +{ + return u->mcq_op_reg[qid].cq.hp; +} + +static inline void ufs_mcq_update_cq_head(UfsHc *u, uint32_t qid, uint32_t= db) +{ + u->mcq_op_reg[qid].cq.hp =3D db; +} + +static inline bool ufs_mcq_cq_empty(UfsHc *u, uint32_t qid) +{ + return ufs_mcq_cq_tail(u, qid) =3D=3D ufs_mcq_cq_head(u, qid); +} + #define TYPE_UFS "ufs" #define UFS(obj) OBJECT_CHECK(UfsHc, (obj), TYPE_UFS) =20 diff --git a/include/block/ufs.h b/include/block/ufs.h index 3513b6e772..92da7a89b9 100644 --- a/include/block/ufs.h +++ b/include/block/ufs.h @@ -152,7 +152,8 @@ REG32(MCQCONFIG, offsetof(UfsReg, mcqconfig)) FIELD(MCQCONFIG, MAC, 8, 8) =20 #define UFS_INTR_MASK \ - ((1 << R_IS_CEFES_SHIFT) | (1 << R_IS_SBFES_SHIFT) | \ + ((1 << R_IS_CQES_SHIFT) | \ + (1 << R_IS_CEFES_SHIFT) | (1 << R_IS_SBFES_SHIFT) | \ (1 << R_IS_HCFES_SHIFT) | (1 << R_IS_UTPES_SHIFT) | \ (1 << R_IS_DFES_SHIFT) | (1 << R_IS_UCCS_SHIFT) | \ (1 << R_IS_UTMRCS_SHIFT) | (1 << R_IS_ULSS_SHIFT) | \ @@ -242,6 +243,21 @@ typedef struct QEMU_PACKED UfsMcqCqIntReg { REG32(CQIS, offsetof(UfsMcqCqIntReg, is)) FIELD(CQIS, TEPS, 0, 1) =20 +/* + * Provide MCQ Operation & Runtime Registers as a contiguous addressed + * registers for the simplicity. + * DAO(Doorbell Address Offset) and ISAO(Interrupt Status Register Address + * Offset) registers should be properly configured with the following + * structure. + */ +#define UFS_MCQ_OPR_START 0x1000 +typedef struct QEMU_PACKED UfsMcqOpReg { + UfsMcqSqReg sq; + UfsMcqSqIntReg sq_int; + UfsMcqCqReg cq; + UfsMcqCqIntReg cq_int; +} UfsMcqOpReg; + typedef struct QEMU_PACKED DeviceDescriptor { uint8_t length; uint8_t descriptor_idn; @@ -1169,6 +1185,11 @@ static inline void _ufs_check_size(void) { QEMU_BUILD_BUG_ON(sizeof(UfsReg) !=3D 0x38C); QEMU_BUILD_BUG_ON(sizeof(UfsMcqReg) !=3D 64); + QEMU_BUILD_BUG_ON(sizeof(UfsMcqSqReg) !=3D 20); + QEMU_BUILD_BUG_ON(sizeof(UfsMcqCqReg) !=3D 8); + QEMU_BUILD_BUG_ON(sizeof(UfsMcqSqIntReg) !=3D 8); + QEMU_BUILD_BUG_ON(sizeof(UfsMcqCqIntReg) !=3D 12); + QEMU_BUILD_BUG_ON(sizeof(UfsMcqOpReg) !=3D 48); QEMU_BUILD_BUG_ON(sizeof(DeviceDescriptor) !=3D 89); QEMU_BUILD_BUG_ON(sizeof(GeometryDescriptor) !=3D 87); QEMU_BUILD_BUG_ON(sizeof(UnitDescriptor) !=3D 45); --=20 2.34.1