From nobody Mon Nov 25 10:52:01 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1715762973; cv=none; d=zohomail.com; s=zohoarc; b=bU9pGMreHt8Mv8JcfTM+ceMmvYC2gmBsz71XZkzzHoMe487+mIzp9AkDkV+L0rX1AY09EbXWXtW+AbzcVT+cjog81o/lHBL/WXGwTkuCgcCeELa2pSZ9VBRJyF8QL406N/uOg88cW44a3PXKk1SOW84avX3iyP0we/iuB7dcTUM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1715762973; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pRSpzd+93LzeF6qjSfwPRwH497r4UDxXF8gop/KnEos=; b=b0rv79vi0ctIh6DRi9ZLR+UQvlh1hn+UQsWlkgGnBeT+JcpRXZBq4K5OT7JcQHE5SxkvJFPInVQ7Tz2BVPi8SnDtONSYgnowvdRL5ZVys+AfCqpok+K2Ur4OK/danEWFs0ffcrz7eGALfcXY1IjfWskmwMzYl4QEAdFLsBQSRyQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1715762973831827.7451863401212; Wed, 15 May 2024 01:49:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7AJj-0007aS-83; Wed, 15 May 2024 04:48:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7AJg-0007Lq-8A for qemu-devel@nongnu.org; Wed, 15 May 2024 04:48:52 -0400 Received: from mgamail.intel.com ([192.198.163.16]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7AJd-0003uo-AA for qemu-devel@nongnu.org; Wed, 15 May 2024 04:48:52 -0400 Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 01:48:47 -0700 Received: from unknown (HELO SPR-S2600BT.bj.intel.com) ([10.240.192.124]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 01:48:44 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715762929; x=1747298929; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=KDxv+dBO3SG077TMC+Biinv0oixhCPXOyWdnTVtAwRs=; b=HxZne39YlW5DzyL/OaOHqE4UzfmWRkfMiVznI3Yab/a4jfsVWiUB0JUW kUqgtOVaKsN4pkeP70RPMP5wI0LP5f0pZaXnev5L/6KVwRAHs6/wVs78V AjFgJCYVEY7dZsmGPsAPPU+Ci3YXuS/VMDCOWj9RrnodDiQOSEsEa6ppE JtWSiLFHTIWwTn1uEqecWWYi6KMEoTeBkkzruVoFKxQkgMe+r/lGfGJvQ Jcl3tNX1PQYyM2Gu+vpzX//txwoIncsINV9d4fk6sy3UJ1zyJrqHrbZWz V4/ajwPlgVNA6aNnPKI877MUfIWYx09kIwuf4JqFzy1Xcr5ZJ2TD0Fq4a A==; X-CSE-ConnectionGUID: n41abcoDQoaZVdtzGulr/A== X-CSE-MsgGUID: vxcF9B78TVi6O248jx0gPg== X-IronPort-AV: E=McAfee;i="6600,9927,11073"; a="11535096" X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208";a="11535096" X-CSE-ConnectionGUID: xQ2x0Bs9QHy1lz1CUxKVPQ== X-CSE-MsgGUID: V2WVeeGtSOuLe7J9APbI2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208";a="31012952" From: Zhenzhong Duan To: qemu-devel@nongnu.org Cc: yi.l.liu@intel.com, chao.p.peng@intel.com, Zhenzhong Duan , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Marcel Apfelbaum Subject: [PATCH] intel_iommu: Make pasid entry type check accurate Date: Wed, 15 May 2024 16:46:20 +0800 Message-Id: <20240515084620.636016-1-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=192.198.163.16; envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.974, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1715762974696100001 Content-Type: text/plain; charset="utf-8" When guest configures Nested Translation(011b) or First-stage Translation o= nly (001b), type check passed unaccurately. Fails the type check in those cases as their simulation isn't supported yet. Fixes: fb43cf739e1 ("intel_iommu: scalable mode emulation") Suggested-by: Yi Liu Signed-off-by: Zhenzhong Duan --- hw/i386/intel_iommu.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index cc8e59674e..990cfa87f2 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -734,20 +734,16 @@ static inline bool vtd_pe_type_check(X86IOMMUState *x= 86_iommu, VTDPASIDEntry *pe) { switch (VTD_PE_GET_TYPE(pe)) { - case VTD_SM_PASID_ENTRY_FLT: case VTD_SM_PASID_ENTRY_SLT: - case VTD_SM_PASID_ENTRY_NESTED: - break; + return true; case VTD_SM_PASID_ENTRY_PT: - if (!x86_iommu->pt_supported) { - return false; - } - break; + return x86_iommu->pt_supported; + case VTD_SM_PASID_ENTRY_FLT: + case VTD_SM_PASID_ENTRY_NESTED: default: /* Unknown type */ return false; } - return true; } =20 static inline bool vtd_pdire_present(VTDPASIDDirEntry *pdire) --=20 2.34.1