From nobody Mon Nov 25 11:55:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1715759861; cv=none; d=zohomail.com; s=zohoarc; b=G0NAjF3thzXjBbpd1vQS26WXcv8kPnp/j33tBiHU8pM91xgk4e+2//XsuE7FKnDgrsjV2BxIu8OcbCT8NB8vLEm8f54ksArnRgxvhZRf+wG2XjvZ+PvOhxlxRYBb7SgAeIOjSjYMhSjBxN+TED3BradTYSwtkjKqn1pdLAuQcAs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1715759861; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oqU8ItNdi4m1XZTYvDwRO0vv7Nr1dGEj2Szzh23jUJo=; b=ZdgbK8+8yxT+QvV9/p0ue0YB4f5ugGsejd9q99KT9eLBf8nqJ7djf7aTdX/NtgzY2HqU0J25Kw08yYUsUItX9BhFU7G2Aw6PZrq+jJh6r0xKJeTykgu0XDat6uGnMYooGJSauaCMCnds26w2h1yRgavucB0YjATHC2cxEsSqQos= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1715759861436393.7128429145439; Wed, 15 May 2024 00:57:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s79Rk-0004B6-7A; Wed, 15 May 2024 03:53:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s79Rb-00044o-Hq for qemu-devel@nongnu.org; Wed, 15 May 2024 03:53:00 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s79RZ-0001Yr-5s for qemu-devel@nongnu.org; Wed, 15 May 2024 03:52:59 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-41ffad2426eso48853725e9.3 for ; Wed, 15 May 2024 00:52:55 -0700 (PDT) Received: from stoup.. ([149.14.240.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccee9292sm222611855e9.37.2024.05.15.00.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 00:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715759574; x=1716364374; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oqU8ItNdi4m1XZTYvDwRO0vv7Nr1dGEj2Szzh23jUJo=; b=oJ1tXAq1cmxTT+P3SsDtAGK7w69uZvAZqT5xlZn2XaXMGkU0W+1Dgm53Nm9MUSC1w6 oxQKE1ybxaDfGmrkGYhji1XUQz09lqs2JBxwzrRzIdtAXQBku8FYkjNhyT7+84z3Zl8d I2B+rMaV0j4HHfy/zsGxvCZPEr7Gfp1ah5h7UKr3rI1lxVnKVELeVShxFIP0R64zTJp6 PWUuIiXQfWZGuPbK5uJjQU4ONDB9nENCrp1cA5tTLZbfj5J2N89Ho1h33zHvepWBur67 qzg8AA8c/SZfgG9KIpU6ToOWvkt6QfZfcFLqLZCRmmINcoLUi9zLBI2IAP/AZRftCGT8 +QAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715759574; x=1716364374; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oqU8ItNdi4m1XZTYvDwRO0vv7Nr1dGEj2Szzh23jUJo=; b=J6nnbNOQ9QFSPUPdMLJsmb5m2E4SWkkBrqto+r05/2GujW9htNleGPQUYLwT5NczJm D1Emx7fPVZf6e6HVb+VKuGgMG2FH3njNQCxIQffLNLdEV3sstRpA9wqAdi7e+ct7JxeK rqg94/xfdFjKhyIqF6NUOM+nFStPokk41yUQKAqx+rp52egDR0g/o0SLrqa60zArIwEw CMnrAIJ7F44IXSW2WDPj51OsylpEmoOe0QJ9hVmQs4+KGf+rO8n6k4Mmuji06RD+ipID vv+wyXg4iEQR4jTF8kASnFgoNX+BA98jibV8cZOFvao0KsghJLnMXkMwqCmMJ1aJgu0Z 6H9w== X-Gm-Message-State: AOJu0Yxk2QLt80geGmG0PPZhboDIzMuNFAl/sOJQseTVfY7JXH7V4FDT wPuVprZ7pJqvSzqklt1DVRvJmEfZ4z1M/ZGTtRlYSe6R+FJgaXs9Vn9gOkt+gUvVwLznCnGv3UR M1v4= X-Google-Smtp-Source: AGHT+IHEbxIPwdrzJMO9q2gwXYeDQd77ATDKAt6/xn1pjSBHJAuyqRGE3BptY36EBAWgEuYAQt2XUQ== X-Received: by 2002:a05:600c:444e:b0:41b:e244:164a with SMTP id 5b1f17b1804b1-41fea9324cemr156127495e9.6.1715759574662; Wed, 15 May 2024 00:52:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 07/34] accel/tcg: Record when translator_fake_ldb is used Date: Wed, 15 May 2024 09:52:20 +0200 Message-Id: <20240515075247.68024-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240515075247.68024-1-richard.henderson@linaro.org> References: <20240515075247.68024-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1715759861633100005 Remove left-over comment from commit dcd092a063 ("accel/tcg: Improve can_do_io management"). Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson --- include/exec/translator.h | 3 ++- accel/tcg/translator.c | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/exec/translator.h b/include/exec/translator.h index 4a86907ecc..70cef2c0be 100644 --- a/include/exec/translator.h +++ b/include/exec/translator.h @@ -72,8 +72,8 @@ typedef enum DisasJumpType { * @num_insns: Number of translated instructions (including current). * @max_insns: Maximum number of instructions to be translated in this TB. * @singlestep_enabled: "Hardware" single stepping enabled. - * @saved_can_do_io: Known value of cpu->neg.can_do_io, or -1 for unknown. * @plugin_enabled: TCG plugin enabled in this TB. + * @fake_insn: True if translator_fake_ldb used. * @insn_start: The last op emitted by the insn_start hook, * which is expected to be INDEX_op_insn_start. * @@ -88,6 +88,7 @@ typedef struct DisasContextBase { int max_insns; bool singlestep_enabled; bool plugin_enabled; + bool fake_insn; struct TCGOp *insn_start; void *host_addr[2]; =20 diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c index 86a1fe17a0..aa9f36aaa0 100644 --- a/accel/tcg/translator.c +++ b/accel/tcg/translator.c @@ -130,6 +130,7 @@ void translator_loop(CPUState *cpu, TranslationBlock *t= b, int *max_insns, db->max_insns =3D *max_insns; db->singlestep_enabled =3D cflags & CF_SINGLE_STEP; db->insn_start =3D NULL; + db->fake_insn =3D false; db->host_addr[0] =3D host_pc; db->host_addr[1] =3D NULL; db->record_start =3D 0; @@ -434,6 +435,7 @@ uint64_t translator_ldq(CPUArchState *env, DisasContext= Base *db, vaddr pc) void translator_fake_ldb(DisasContextBase *db, vaddr pc, uint8_t insn8) { assert(pc >=3D db->pc_first); + db->fake_insn =3D true; record_save(db, pc, &insn8, sizeof(insn8)); plugin_insn_append(pc, &insn8, sizeof(insn8)); } --=20 2.34.1