From nobody Mon Feb 9 22:54:30 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1714377566; cv=none; d=zohomail.com; s=zohoarc; b=c3egk30VIhZ6/f5WSRUVAMcC0AUBEyu3YhV/gSfDge1HKo0Bh+yBYee78Qd5R+SQ3GdhojDgglTeGOUQCqrPZfZX2x2coXkcELDaf4B9WC7A8SUWf/pDIEj9V5GAqVShKZ/I18xVmp+7WFOFiq4M1U0/+hKNNiXg3ZlHX50wmPg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1714377566; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=y14kT3to8gmEzHZb6tZDDijnuELitRC4BVu6UM95dms=; b=j98JHeFLINBccXBL46yPVLV+OwLDkmcp3NSrGen7wJzj9oxXmL63oBWpzy3U76Q0zK+NTGSm5ATuxVquI+VVTDIIAjle+CO0slPIn+02PemCMpaM7EMIswd+ninPrqXZoWraKNqpEdgQgUzC+Utpp6MoTUd5FbHmWxL/cTg9K28= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1714377566182577.1115193884477; Mon, 29 Apr 2024 00:59:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1Lv1-0000wy-Ra; Mon, 29 Apr 2024 03:59:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1Luy-0000qT-3U for qemu-devel@nongnu.org; Mon, 29 Apr 2024 03:59:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1Luw-0004D8-Ig for qemu-devel@nongnu.org; Mon, 29 Apr 2024 03:59:19 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-vpMbdjVfN22Bcsqz2amiAQ-1; Mon, 29 Apr 2024 03:59:11 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 23DE28032FA; Mon, 29 Apr 2024 07:59:11 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C4452166B31; Mon, 29 Apr 2024 07:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714377557; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=y14kT3to8gmEzHZb6tZDDijnuELitRC4BVu6UM95dms=; b=dV1+Mmw6zMvMKpBG9eazTMgGmHTQWN9evw6PHoJA6N8ggXdT5WhUxUnqCUtZQ/mdfY8ZE1 1yM4ADE4eLk3zjc6KIKVV4sb42vM6RVBOmf+oO0yM2vOwPuIY6LEiXfyBagSgTIqzVSAxM qfnDsyNn/FbQjc8HwN9KNbUU2p6fLNY= X-MC-Unique: vpMbdjVfN22Bcsqz2amiAQ-1 From: Thomas Huth To: Arnaud Minier , =?UTF-8?q?In=C3=A8s=20Varhol?= , qemu-arm@nongnu.org, Peter Maydell Cc: qemu-devel@nongnu.org Subject: [PATCH] hw/char/stm32l4x5_usart: Fix memory corruption by adding correct class_size Date: Mon, 29 Apr 2024 09:59:08 +0200 Message-ID: <20240429075908.36302-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.114, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1714377572737100003 Content-Type: text/plain; charset="utf-8" "make check-qtest-aarch64" recently started failing on FreeBSD builds, and valgrind on Linux also detected that there is something fishy with the new stm32l4x5-usart: The code forgot to set the correct class_size here, so the various class_init functions in this file wrote beyond the allocated buffer when setting the subc->type field. Fixes: 4fb37aea7e ("hw/char: Implement STM32L4x5 USART skeleton") Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/char/stm32l4x5_usart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/char/stm32l4x5_usart.c b/hw/char/stm32l4x5_usart.c index 2627aab832..02f666308c 100644 --- a/hw/char/stm32l4x5_usart.c +++ b/hw/char/stm32l4x5_usart.c @@ -617,6 +617,7 @@ static const TypeInfo stm32l4x5_usart_types[] =3D { .parent =3D TYPE_SYS_BUS_DEVICE, .instance_size =3D sizeof(Stm32l4x5UsartBaseState), .instance_init =3D stm32l4x5_usart_base_init, + .class_size =3D sizeof(Stm32l4x5UsartBaseClass), .class_init =3D stm32l4x5_usart_base_class_init, .abstract =3D true, }, { --=20 2.44.0