From nobody Sat May 18 18:27:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1713447650; cv=none; d=zohomail.com; s=zohoarc; b=gI8i+ARgJlWRLkMTQoeYDFZHoBgj5oYKuEy1ZPVHnjiiNhbej1ioJZfZk6hzZ4PgqPH5fIq+NQe6P3W7oWekGT/Y5EkT9Er1K7WqiKyhLDh2Swx8MOLug+gHK9u+XbFPNrAYfBIQCbcvn2K54TyX6ubWpDzeS23KP6rbWMN1e1U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1713447650; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WjHQJQZNZICF88PlAwO3VUB5/lIfOhrUFroeeBB9BBQ=; b=En9f9wasVTwceIZphpJrrukf4csjGw+c7CqpSjiP3BYi3TqbFXN6d65XyxsEpBfxoVU9Yu8uJdMsFVAMOZFz9kOv7+eTUYNobHA0hscSdbbzGW5XTFKPwq9cvCasszaj2JN0AgZGHtQJLty/Ow/W6Apyv0nLM8tiMJfP3u9XZVM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1713447650469347.53886901216777; Thu, 18 Apr 2024 06:40:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxRz7-00051j-4T; Thu, 18 Apr 2024 09:39:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxRz5-000510-RX for qemu-devel@nongnu.org; Thu, 18 Apr 2024 09:39:27 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxRz2-00024w-8s for qemu-devel@nongnu.org; Thu, 18 Apr 2024 09:39:27 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-345606e8ac0so116368f8f.0 for ; Thu, 18 Apr 2024 06:39:23 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:7b64:4d1d:16d8:e38b]) by smtp.gmail.com with ESMTPSA id je12-20020a05600c1f8c00b004183edc31adsm6554015wmb.44.2024.04.18.06.39.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 06:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713447563; x=1714052363; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WjHQJQZNZICF88PlAwO3VUB5/lIfOhrUFroeeBB9BBQ=; b=GKDe6AB7VJxpaYpHNF+VNL3pP5KfQ2ARMJPb3gDqPcuLszJGirHWZODV1M2Q6suowQ rUZ3TWbvJoDUY8kHs426C4G8LJ7CdTSyqG0H7IQc5QCjyOgSp+iBPQonAjHJHuLHGUnc QOByURWFSqpOCZ5vEEk2A9W1BcEdus51YRyxUFdE4CrT2wmsgVQTWslYhZnEsvHxNJji piOtBHmbswrwja9N/NFj/kbFwCgrAnY+GZezQY7UWTiW/z7n0+8tD6bqoH3o670KkA8F HzwU58diR4FolbqPlPE6jUbVF0VM0RAFAqqt6bwqbC1RcCE0JaMsZwVDzWqWl58jnnu4 7PPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713447563; x=1714052363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WjHQJQZNZICF88PlAwO3VUB5/lIfOhrUFroeeBB9BBQ=; b=gBRuqly5XYOr37CzCX1852zHfWkwcndd9t0mzJFezW9V/tqGXGO7p86tYekiK5lJ9J 4T0LphTr3wTAaRwXISptVMJkQ6MFExCT0wtcoDmtad5mJPQg45YhZ73PZebkL4TiljGA AQ39gUD4Mzq1q+fRoGZK9qh8nMyyQ+5GgaQWdjsPRQ+8ZUIycSpbez438uO3gJdLL6hz OhuvfcXpjNkjUTJ+F/r5UQBYY9p4BgzTgJtEKw+X+izTuSFhz1QXMFK5MKArmnTQXQsO ZjYPShBlnMUI18+XO5wclSrbIcxfGBXDH6jrFLxMMimSrJ2+Lm0PwQKx8nw/jvUa8M+S cOKg== X-Forwarded-Encrypted: i=1; AJvYcCXwvoDyfZqdG1CgNbKpmPOJmKnGUC1Miw3enB6E8XKYFWdX75B7K1mTqqVBdCN2gyvSIWXQMcVCB/u7lKaPeAP9BIvZK8A= X-Gm-Message-State: AOJu0Yxf5ciFgrEflDBb/jXtZTiSNlQGkgfyuNQrDWF8N0niCLML0YWo Ah7TKGShJLuCxvyF5HTde3bwODG0ITd0iNGKZG25Dj379LNk8eaJmeQjiCmHtaE= X-Google-Smtp-Source: AGHT+IFMasossRnBNIpG7q9He62WzWqQA+ovDN9S+Rmn63CTuQuCjAVP3ID6znvNQfztRaVWtPFGjQ== X-Received: by 2002:a05:600c:474b:b0:416:ac21:9666 with SMTP id w11-20020a05600c474b00b00416ac219666mr1963016wmo.4.1713447563084; Thu, 18 Apr 2024 06:39:23 -0700 (PDT) From: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= To: qemu-riscv@nongnu.org, Palmer Dabbelt , Alistair Francis , Bin Meng Cc: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Ved Shanbhogue , Atish Patra , qemu-devel@nongnu.org Subject: [RFC PATCH 1/3] target/riscv: change RISCV_EXCP_SEMIHOST exception number Date: Thu, 18 Apr 2024 15:39:13 +0200 Message-ID: <20240418133916.1442471-2-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240418133916.1442471-1-cleger@rivosinc.com> References: <20240418133916.1442471-1-cleger@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=cleger@rivosinc.com; helo=mail-wr1-x430.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @rivosinc-com.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1713447652257100003 The double trap specification defines the double trap exception number to be 16 which is actually used by the internal semihosting one. Change it to some other value. Signed-off-by: Cl=C3=A9ment L=C3=A9ger Reviewed-by: Alistair Francis --- target/riscv/cpu_bits.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index fc2068ee4d..9ade72ff31 100644 --- a/target/riscv/cpu_bits.h +++ b/target/riscv/cpu_bits.h @@ -670,7 +670,7 @@ typedef enum RISCVException { RISCV_EXCP_INST_PAGE_FAULT =3D 0xc, /* since: priv-1.10.0 */ RISCV_EXCP_LOAD_PAGE_FAULT =3D 0xd, /* since: priv-1.10.0 */ RISCV_EXCP_STORE_PAGE_FAULT =3D 0xf, /* since: priv-1.10.0 */ - RISCV_EXCP_SEMIHOST =3D 0x10, + RISCV_EXCP_SEMIHOST =3D 0x11, RISCV_EXCP_INST_GUEST_PAGE_FAULT =3D 0x14, RISCV_EXCP_LOAD_GUEST_ACCESS_FAULT =3D 0x15, RISCV_EXCP_VIRT_INSTRUCTION_FAULT =3D 0x16, --=20 2.43.0 From nobody Sat May 18 18:27:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1713447621; cv=none; d=zohomail.com; s=zohoarc; b=ZVmQLVcEi3A2n04zifmrKRYZi+6hkMcxBZAvfG6xnHZX9H4dV0FgXL+7OA0XdLAUrOCAQoa6GXZcYMo1aYli8Y21wVMEXM+msWjzsrXyIvhoDRQoPNxnHu1uw6Ukvyta2JV6bRH12UShRPqI3cvflW/6Rl+vVfE/L2cs/G4kpno= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1713447621; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pO7LS/k18aEMfmefTAm+1eefP6v3g2LchVKZ6Hn8oTc=; b=abx8OR8KaNifHAEUkw4meblIZ5JFtvKILbp0xMYiv7t2x9P7Mx6hxN5k6aKuYURbdEiWm3uEZzuClkgbGaudZXL3eA/y2ZnymgqKkdUmnW2Q1T6OneqcExsgvxTRHbM3dWOl+ek10KT5UOaGjcoSzHmpIEWLBKl5Qi+9XbBvMCE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1713447621694362.35509376631194; Thu, 18 Apr 2024 06:40:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxRzB-00053b-RK; Thu, 18 Apr 2024 09:39:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxRz8-00052R-1J for qemu-devel@nongnu.org; Thu, 18 Apr 2024 09:39:30 -0400 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxRz4-00025P-8l for qemu-devel@nongnu.org; Thu, 18 Apr 2024 09:39:29 -0400 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-34801b1bc4aso160382f8f.0 for ; Thu, 18 Apr 2024 06:39:25 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:7b64:4d1d:16d8:e38b]) by smtp.gmail.com with ESMTPSA id je12-20020a05600c1f8c00b004183edc31adsm6554015wmb.44.2024.04.18.06.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 06:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713447564; x=1714052364; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pO7LS/k18aEMfmefTAm+1eefP6v3g2LchVKZ6Hn8oTc=; b=X6UvU5g3B/JC3e9gJVHEqxAI1v8jycTb2v/+M8GKV3xo4KKAndZa+an1nlClgPY+8J HZu3lO5FvNCpOhaf1UYW8ewNEBqtrdIkdsRqAjBIBWmROyeKD/6vafTOzdbxXSUVjawW EmCJtAXdSy8tmfC5uCPSQGVYkZcWOmqAVRq9RfvPEzAyeosR7HhZ9dbEGODdReEl9m0T M5ky0SLn4DzPJ9XH476Ixk+ce2SlPGd4dXQIeQ2sfEljr+RZepeLdr5VnAemqPWALdVR gA44pLvcvvlaskz0t/nzbg0Fz4sf/QWre7ignib3HuB9bZy3Me2B6vwk21ZmNF+Gneqs l22A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713447564; x=1714052364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pO7LS/k18aEMfmefTAm+1eefP6v3g2LchVKZ6Hn8oTc=; b=M6/fFKl1kThYqZOS1AQ01qGHW4DO9L+Lp5TTMuxm1QI9FX7Bj9XsBk2wkI5R0bt/ix 3hck3CtPKG/w+pw9vJGb7Y2YhxZ2/8h78XUQ3y3swjmwi1RaPeHPvl4rWuDKsaMqCGL5 JWtcIYBHaABK6LhAUaB7jA6ctG82j0d/cnpwW/xvA46Kh1twVAVCSWIOg0e/PEjuxr0G Q00mVn6aRHJTaiyyNRlxH9iJzN/vgwgMkn59iA0+b/9uW/MYSfgBpUgSrW1DDP8Th1YJ WnHX0H9ks64LlMj59F6oPT25fZj4X9/15WQvyTTJnoqIsjAcbpf9rrS08lMOIg3SFXaS YNRg== X-Forwarded-Encrypted: i=1; AJvYcCXXlOidtsICSFsY2ui5hAhTqMugn0Pd9JHyxxzh8Pt/gi9rIQO0Z9l5pbqc6ikia43hKOZuORjxC0Q123wFJ5/fpiUgWBI= X-Gm-Message-State: AOJu0YyEBztDtFej+4q9vr6GyvTBPMRWhRp3O4UNNTsd/L6dw8qJbHp4 KLNzl0vAq8E87SXvS/KHrS+9BFFMm6WWSuuKgi2fuwrtOWJmNJSo354Njk9MriA= X-Google-Smtp-Source: AGHT+IFhibjecyBWFAeG8nP+QDv82cogczbJ4TghhUiKTWecUu0hs7EorrbhbcR9Rpy5CZuBvAmAHg== X-Received: by 2002:a05:600c:4f51:b0:418:73d1:94e9 with SMTP id m17-20020a05600c4f5100b0041873d194e9mr1911488wmq.4.1713447564546; Thu, 18 Apr 2024 06:39:24 -0700 (PDT) From: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= To: qemu-riscv@nongnu.org, Palmer Dabbelt , Alistair Francis , Bin Meng Cc: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Ved Shanbhogue , Atish Patra , qemu-devel@nongnu.org Subject: [RFC PATCH 2/3] target/riscv: add Ssdbltrp extension support Date: Thu, 18 Apr 2024 15:39:14 +0200 Message-ID: <20240418133916.1442471-3-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240418133916.1442471-1-cleger@rivosinc.com> References: <20240418133916.1442471-1-cleger@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=cleger@rivosinc.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @rivosinc-com.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1713447622314100006 The Ssdbltrp extension allows handling trap when being in non-reentrant state (mainly during exception handling) for S-mode [1]. This patch add support for this extension as an experimental extension. Link: https://github.com/riscv/riscv-double-trap/releases/download/v0.56/ri= scv-double-trap.pdf [1] Signed-off-by: Cl=C3=A9ment L=C3=A9ger --- target/riscv/cpu.c | 4 ++- target/riscv/cpu.h | 1 + target/riscv/cpu_bits.h | 7 +++++ target/riscv/cpu_cfg.h | 1 + target/riscv/cpu_helper.c | 60 ++++++++++++++++++++++++++++++++++----- target/riscv/csr.c | 44 +++++++++++++++++++++------- target/riscv/op_helper.c | 11 +++++++ 7 files changed, 110 insertions(+), 18 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 36e3e5fdaf..d159b0c6b6 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -182,6 +182,7 @@ const RISCVIsaExtData isa_edata_arr[] =3D { ISA_EXT_DATA_ENTRY(ssccptr, PRIV_VERSION_1_11_0, has_priv_1_11), ISA_EXT_DATA_ENTRY(sscofpmf, PRIV_VERSION_1_12_0, ext_sscofpmf), ISA_EXT_DATA_ENTRY(sscounterenw, PRIV_VERSION_1_12_0, has_priv_1_12), + ISA_EXT_DATA_ENTRY(ssdbltrp, PRIV_VERSION_1_12_0, ext_ssdbltrp), ISA_EXT_DATA_ENTRY(sstc, PRIV_VERSION_1_12_0, ext_sstc), ISA_EXT_DATA_ENTRY(sstvala, PRIV_VERSION_1_12_0, has_priv_1_12), ISA_EXT_DATA_ENTRY(sstvecd, PRIV_VERSION_1_12_0, has_priv_1_12), @@ -276,7 +277,7 @@ static const char * const riscv_excp_names[] =3D { "load_page_fault", "reserved", "store_page_fault", - "reserved", + "double_trap", "reserved", "reserved", "reserved", @@ -1572,6 +1573,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_vendor_exts[] = =3D { =20 /* These are experimental so mark with 'x-' */ const RISCVCPUMultiExtConfig riscv_cpu_experimental_exts[] =3D { + MULTI_EXT_CFG_BOOL("x-ssdbltrp", ext_ssdbltrp, false), DEFINE_PROP_END_OF_LIST(), }; =20 diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 3b1a02b944..14f83d4f05 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -505,6 +505,7 @@ void riscv_cpu_set_geilen(CPURISCVState *env, target_ul= ong geilen); bool riscv_cpu_vector_enabled(CPURISCVState *env); void riscv_cpu_set_virt_enabled(CPURISCVState *env, bool enable); int riscv_env_mmu_index(CPURISCVState *env, bool ifetch); +bool riscv_env_smode_dbltrp_enabled(CPURISCVState *env); G_NORETURN void riscv_cpu_do_unaligned_access(CPUState *cs, vaddr addr, MMUAccessType access_type, int mmu_idx, uintptr_t reta= ddr); diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index 9ade72ff31..494a036f6e 100644 --- a/target/riscv/cpu_bits.h +++ b/target/riscv/cpu_bits.h @@ -542,6 +542,7 @@ #define MSTATUS_TVM 0x00100000 /* since: priv-1.10 */ #define MSTATUS_TW 0x00200000 /* since: priv-1.10 */ #define MSTATUS_TSR 0x00400000 /* since: priv-1.10 */ +#define MSTATUS_SDT 0x01000000 /* Ssdbltrp extension */ #define MSTATUS_GVA 0x4000000000ULL #define MSTATUS_MPV 0x8000000000ULL =20 @@ -572,6 +573,7 @@ typedef enum { #define SSTATUS_XS 0x00018000 #define SSTATUS_SUM 0x00040000 /* since: priv-1.10 */ #define SSTATUS_MXR 0x00080000 +#define SSTATUS_SDT 0x01000000 /* Ssdbltrp extension */ =20 #define SSTATUS64_UXL 0x0000000300000000ULL =20 @@ -670,6 +672,7 @@ typedef enum RISCVException { RISCV_EXCP_INST_PAGE_FAULT =3D 0xc, /* since: priv-1.10.0 */ RISCV_EXCP_LOAD_PAGE_FAULT =3D 0xd, /* since: priv-1.10.0 */ RISCV_EXCP_STORE_PAGE_FAULT =3D 0xf, /* since: priv-1.10.0 */ + RISCV_EXCP_DOUBLE_TRAP =3D 0x10, /* Ssdbltrp extension */ RISCV_EXCP_SEMIHOST =3D 0x11, RISCV_EXCP_INST_GUEST_PAGE_FAULT =3D 0x14, RISCV_EXCP_LOAD_GUEST_ACCESS_FAULT =3D 0x15, @@ -744,11 +747,13 @@ typedef enum RISCVException { #define MENVCFG_CBIE (3UL << 4) #define MENVCFG_CBCFE BIT(6) #define MENVCFG_CBZE BIT(7) +#define MENVCFG_DTE (1ULL << 59) /* Ssdbltrp extens= ion */ #define MENVCFG_ADUE (1ULL << 61) #define MENVCFG_PBMTE (1ULL << 62) #define MENVCFG_STCE (1ULL << 63) =20 /* For RV32 */ +#define MENVCFGH_DTE BIT(27) /* Ssdbltrp extension */ #define MENVCFGH_ADUE BIT(29) #define MENVCFGH_PBMTE BIT(30) #define MENVCFGH_STCE BIT(31) @@ -762,11 +767,13 @@ typedef enum RISCVException { #define HENVCFG_CBIE MENVCFG_CBIE #define HENVCFG_CBCFE MENVCFG_CBCFE #define HENVCFG_CBZE MENVCFG_CBZE +#define HENVCFG_DTE MENVCFG_DTE #define HENVCFG_ADUE MENVCFG_ADUE #define HENVCFG_PBMTE MENVCFG_PBMTE #define HENVCFG_STCE MENVCFG_STCE =20 /* For RV32 */ +#define HENVCFGH_DTE MENVCFGH_DTE #define HENVCFGH_ADUE MENVCFGH_ADUE #define HENVCFGH_PBMTE MENVCFGH_PBMTE #define HENVCFGH_STCE MENVCFGH_STCE diff --git a/target/riscv/cpu_cfg.h b/target/riscv/cpu_cfg.h index cb750154bd..a149c08167 100644 --- a/target/riscv/cpu_cfg.h +++ b/target/riscv/cpu_cfg.h @@ -74,6 +74,7 @@ struct RISCVCPUConfig { bool ext_ztso; bool ext_smstateen; bool ext_sstc; + bool ext_ssdbltrp; bool ext_svadu; bool ext_svinval; bool ext_svnapot; diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index fc090d729a..3d747e5bfc 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -62,6 +62,15 @@ int riscv_env_mmu_index(CPURISCVState *env, bool ifetch) #endif } =20 +bool riscv_env_smode_dbltrp_enabled(CPURISCVState *env) +{ + if (env->virt_enabled) { + return (env->henvcfg & HENVCFG_DTE) !=3D 0; + } else { + return (env->menvcfg & MENVCFG_DTE) !=3D 0; + } +} + void cpu_get_tb_cpu_state(CPURISCVState *env, vaddr *pc, uint64_t *cs_base, uint32_t *pflags) { @@ -544,7 +553,12 @@ void riscv_cpu_swap_hypervisor_regs(CPURISCVState *env) mstatus_mask |=3D MSTATUS_FS; } bool current_virt =3D env->virt_enabled; + uint64_t dte =3D current_virt ? env->menvcfg & MENVCFG_DTE : + env->henvcfg & HENVCFG_DTE; =20 + if (riscv_cpu_cfg(env)->ext_ssdbltrp && dte) { + mstatus_mask |=3D MSTATUS_SDT; + } g_assert(riscv_has_ext(env, RVH)); =20 if (current_virt) { @@ -1648,7 +1662,10 @@ void riscv_cpu_do_interrupt(CPUState *cs) =20 RISCVCPU *cpu =3D RISCV_CPU(cs); CPURISCVState *env =3D &cpu->env; + const RISCVCPUConfig *cfg =3D riscv_cpu_cfg(env); bool write_gva =3D false; + bool smode_exception; + bool vsmode_exception; uint64_t s; =20 /* @@ -1662,6 +1679,8 @@ void riscv_cpu_do_interrupt(CPUState *cs) !(env->mip & (1 << cause)); bool vs_injected =3D env->hvip & (1 << cause) & env->hvien && !(env->mip & (1 << cause)); + bool smode_double_trap =3D false; + uint64_t hdeleg =3D async ? env->hideleg : env->hedeleg; target_ulong tval =3D 0; target_ulong tinst =3D 0; target_ulong htval =3D 0; @@ -1750,14 +1769,33 @@ void riscv_cpu_do_interrupt(CPUState *cs) __func__, env->mhartid, async, cause, env->pc, tval, riscv_cpu_get_trap_name(cause, async)); =20 - if (env->priv <=3D PRV_S && cause < 64 && - (((deleg >> cause) & 1) || s_injected || vs_injected)) { - /* handle the trap in S-mode */ + smode_exception =3D env->priv <=3D PRV_S && cause < 64 && + (((deleg >> cause) & 1) || s_injected || vs_injected= ); + vsmode_exception =3D env->virt_enabled && + (((hdeleg >> cause) & 1) || vs_injected); + /* Check S-mode double trap condition */ + if (cfg->ext_ssdbltrp && smode_exception) { + uint64_t dte =3D env->menvcfg & MENVCFG_DTE; if (riscv_has_ext(env, RVH)) { - uint64_t hdeleg =3D async ? env->hideleg : env->hedeleg; + if (vsmode_exception) { + /* Trap to VS mode, use henvcfg instead of menvcfg*/ + dte =3D env->henvcfg & HENVCFG_DTE; + } else if (env->virt_enabled) { + /* Trap into HS mode, from virt + * We can not have a double trap when switching from one m= ode to + * another since sret clears the SDT flag, so when trappin= g in + * S-mode, SDT is cleared + * */ + dte =3D 0; + } + } + smode_double_trap =3D dte && (env->mstatus & MSTATUS_SDT); + } =20 - if (env->virt_enabled && - (((hdeleg >> cause) & 1) || vs_injected)) { + if (smode_exception && !smode_double_trap) { + /* handle the trap in S-mode */ + if (riscv_has_ext(env, RVH)) { + if (vsmode_exception) { /* Trap to VS mode */ /* * See if we need to adjust cause. Yes if its VS mode inte= rrupt @@ -1790,6 +1828,9 @@ void riscv_cpu_do_interrupt(CPUState *cs) s =3D set_field(s, MSTATUS_SPIE, get_field(s, MSTATUS_SIE)); s =3D set_field(s, MSTATUS_SPP, env->priv); s =3D set_field(s, MSTATUS_SIE, 0); + if (riscv_env_smode_dbltrp_enabled(env)) { + s =3D set_field(s, MSTATUS_SDT, 1); + } env->mstatus =3D s; env->scause =3D cause | ((target_ulong)async << (TARGET_LONG_BITS = - 1)); env->sepc =3D env->pc; @@ -1823,9 +1864,14 @@ void riscv_cpu_do_interrupt(CPUState *cs) s =3D set_field(s, MSTATUS_MIE, 0); env->mstatus =3D s; env->mcause =3D cause | ~(((target_ulong)-1) >> async); + if (smode_double_trap) { + env->mtval2 =3D env->mcause; + env->mcause =3D RISCV_EXCP_DOUBLE_TRAP; + } else { + env->mtval2 =3D mtval2; + } env->mepc =3D env->pc; env->mtval =3D tval; - env->mtval2 =3D mtval2; env->mtinst =3D tinst; env->pc =3D (env->mtvec >> 2 << 2) + ((async && (env->mtvec & 3) =3D=3D 1) ? cause * 4 : 0); diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 726096444f..1a2e739947 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -514,6 +514,15 @@ static RISCVException aia_hmode32(CPURISCVState *env, = int csrno) return hmode32(env, csrno); } =20 +static RISCVException dbltrp_hmode(CPURISCVState *env, int csrno) +{ + if (riscv_cpu_cfg(env)->ext_ssdbltrp) { + return RISCV_EXCP_NONE; + } + + return hmode(env, csrno); +} + static RISCVException pmp(CPURISCVState *env, int csrno) { if (riscv_cpu_cfg(env)->pmp) { @@ -1182,7 +1191,7 @@ static const target_ulong vs_delegable_excps =3D DELE= GABLE_EXCPS & (1ULL << (RISCV_EXCP_STORE_GUEST_AMO_ACCESS_FAULT))); static const target_ulong sstatus_v1_10_mask =3D SSTATUS_SIE | SSTATUS_SPI= E | SSTATUS_UIE | SSTATUS_UPIE | SSTATUS_SPP | SSTATUS_FS | SSTATUS_XS | - SSTATUS_SUM | SSTATUS_MXR | SSTATUS_VS; + SSTATUS_SUM | SSTATUS_MXR | SSTATUS_VS | SSTATUS_SDT; =20 /* * Spec allows for bits 13:63 to be either read-only or writable. @@ -1380,6 +1389,13 @@ static RISCVException write_mstatus(CPURISCVState *e= nv, int csrno, mask |=3D MSTATUS_VS; } =20 + if (riscv_env_smode_dbltrp_enabled(env)) { + mask |=3D MSTATUS_SDT; + if ((val & MSTATUS_SDT) !=3D 0) { + mask &=3D ~MSTATUS_SIE; + } + } + if (xl !=3D MXL_RV32 || env->debugger) { if (riscv_has_ext(env, RVH)) { mask |=3D MSTATUS_MPV | MSTATUS_GVA; @@ -2089,7 +2105,8 @@ static RISCVException write_menvcfg(CPURISCVState *en= v, int csrno, if (riscv_cpu_mxl(env) =3D=3D MXL_RV64) { mask |=3D (cfg->ext_svpbmt ? MENVCFG_PBMTE : 0) | (cfg->ext_sstc ? MENVCFG_STCE : 0) | - (cfg->ext_svadu ? MENVCFG_ADUE : 0); + (cfg->ext_svadu ? MENVCFG_ADUE : 0) | + (cfg->ext_ssdbltrp ? MENVCFG_DTE : 0); } env->menvcfg =3D (env->menvcfg & ~mask) | (val & mask); =20 @@ -2109,7 +2126,8 @@ static RISCVException write_menvcfgh(CPURISCVState *e= nv, int csrno, const RISCVCPUConfig *cfg =3D riscv_cpu_cfg(env); uint64_t mask =3D (cfg->ext_svpbmt ? MENVCFG_PBMTE : 0) | (cfg->ext_sstc ? MENVCFG_STCE : 0) | - (cfg->ext_svadu ? MENVCFG_ADUE : 0); + (cfg->ext_svadu ? MENVCFG_ADUE : 0) | + (cfg->ext_ssdbltrp ? MENVCFG_DTE : 0); uint64_t valh =3D (uint64_t)val << 32; =20 env->menvcfg =3D (env->menvcfg & ~mask) | (valh & mask); @@ -2160,9 +2178,10 @@ static RISCVException read_henvcfg(CPURISCVState *en= v, int csrno, * henvcfg.pbmte is read_only 0 when menvcfg.pbmte =3D 0 * henvcfg.stce is read_only 0 when menvcfg.stce =3D 0 * henvcfg.adue is read_only 0 when menvcfg.adue =3D 0 + * henvcfg.dte is read_only 0 when menvcfg.dte =3D 0 */ - *val =3D env->henvcfg & (~(HENVCFG_PBMTE | HENVCFG_STCE | HENVCFG_ADUE= ) | - env->menvcfg); + *val =3D env->henvcfg & (~(HENVCFG_PBMTE | HENVCFG_STCE | HENVCFG_ADUE= | + HENVCFG_DTE) | env->menvcfg); return RISCV_EXCP_NONE; } =20 @@ -2170,6 +2189,7 @@ static RISCVException write_henvcfg(CPURISCVState *en= v, int csrno, target_ulong val) { uint64_t mask =3D HENVCFG_FIOM | HENVCFG_CBIE | HENVCFG_CBCFE | HENVCF= G_CBZE; + uint64_t menvcfg_mask; RISCVException ret; =20 ret =3D smstateen_acc_ok(env, 0, SMSTATEEN0_HSENVCFG); @@ -2178,7 +2198,11 @@ static RISCVException write_henvcfg(CPURISCVState *e= nv, int csrno, } =20 if (riscv_cpu_mxl(env) =3D=3D MXL_RV64) { - mask |=3D env->menvcfg & (HENVCFG_PBMTE | HENVCFG_STCE | HENVCFG_A= DUE); + menvcfg_mask =3D HENVCFG_PBMTE | HENVCFG_STCE | HENVCFG_ADUE; + if (riscv_cpu_cfg(env)->ext_ssdbltrp) { + menvcfg_mask |=3D HENVCFG_DTE; + } + mask |=3D env->menvcfg & menvcfg_mask; } =20 env->henvcfg =3D (env->henvcfg & ~mask) | (val & mask); @@ -2196,8 +2220,8 @@ static RISCVException read_henvcfgh(CPURISCVState *en= v, int csrno, return ret; } =20 - *val =3D (env->henvcfg & (~(HENVCFG_PBMTE | HENVCFG_STCE | HENVCFG_ADU= E) | - env->menvcfg)) >> 32; + *val =3D (env->henvcfg & (~(HENVCFG_PBMTE | HENVCFG_STCE | HENVCFG_ADU= E | + HENVCFG_DTE) | env->menvcfg)) >> 32; return RISCV_EXCP_NONE; } =20 @@ -2205,7 +2229,7 @@ static RISCVException write_henvcfgh(CPURISCVState *e= nv, int csrno, target_ulong val) { uint64_t mask =3D env->menvcfg & (HENVCFG_PBMTE | HENVCFG_STCE | - HENVCFG_ADUE); + HENVCFG_ADUE | HENVCFG_DTE); uint64_t valh =3D (uint64_t)val << 32; RISCVException ret; =20 @@ -4801,7 +4825,7 @@ riscv_csr_operations csr_ops[CSR_TABLE_SIZE] =3D { [CSR_VSATP] =3D { "vsatp", hmode, read_vsatp, write_v= satp, .min_priv_ver =3D PRIV_VERSION_1_12_0 = }, =20 - [CSR_MTVAL2] =3D { "mtval2", hmode, read_mtval2, write_m= tval2, + [CSR_MTVAL2] =3D { "mtval2", dbltrp_hmode, read_mtval2, = write_mtval2, .min_priv_ver =3D PRIV_VERSION_1_12_0 = }, [CSR_MTINST] =3D { "mtinst", hmode, read_mtinst, write_m= tinst, .min_priv_ver =3D PRIV_VERSION_1_12_0 = }, diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c index f414aaebdb..468ee58a00 100644 --- a/target/riscv/op_helper.c +++ b/target/riscv/op_helper.c @@ -289,6 +289,17 @@ target_ulong helper_sret(CPURISCVState *env) get_field(mstatus, MSTATUS_SPIE)); mstatus =3D set_field(mstatus, MSTATUS_SPIE, 1); mstatus =3D set_field(mstatus, MSTATUS_SPP, PRV_U); + if (riscv_cpu_cfg(env)->ext_ssdbltrp) { + if (env->virt_enabled) { + if (get_field(env->henvcfg, HENVCFG_DTE)) { + mstatus =3D set_field(mstatus, MSTATUS_SDT, 0); + } + } else { + if (get_field(env->menvcfg, MENVCFG_DTE)) { + mstatus =3D set_field(mstatus, MSTATUS_SDT, 0); + } + } + } if (env->priv_ver >=3D PRIV_VERSION_1_12_0) { mstatus =3D set_field(mstatus, MSTATUS_MPRV, 0); } --=20 2.43.0 From nobody Sat May 18 18:27:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1713447621; cv=none; d=zohomail.com; s=zohoarc; b=mkv1NnsWdQDKzXsOWNZjiInAogsohJXuR93zlLEv4DhX5r6cETi6k+cOEa2A+vjvPZ87XpMkWRvg9vL2TXsLd/kP09a+uq05Q+uy6KfgnYXIRwf0Ycs8vWzDpOtJFYdYJfufFJCQMc91DHvJlz6B5fMwN+bHi409J1qjlJ8WyTo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1713447621; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XrM/ng6nAhBYvP+9WXpoWnqe8/L1gEhRX1pjDUM4u8w=; b=QMDPPVmdqFIQhmGSsJ5TX4kzIHJoE3Tz5jIli8CJoqDATzoqvBrst0BKLsgFAa4l+YdCHFiz7NxJjoF5UmU52Q3kb9zG9xYRj4WqAzXfdl5BicxSWyZEJesR5RPkeXTx4sfoHJeT5jWwxDKZLEy4GdTUPTlW/4z0Lfg7VfSzleE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1713447621594942.2566785842886; Thu, 18 Apr 2024 06:40:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxRz9-00053A-3o; Thu, 18 Apr 2024 09:39:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxRz7-000525-Jo for qemu-devel@nongnu.org; Thu, 18 Apr 2024 09:39:29 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxRz5-00025z-Hx for qemu-devel@nongnu.org; Thu, 18 Apr 2024 09:39:29 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-347c6d6fc02so126558f8f.1 for ; Thu, 18 Apr 2024 06:39:27 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:999:a3a0:7b64:4d1d:16d8:e38b]) by smtp.gmail.com with ESMTPSA id je12-20020a05600c1f8c00b004183edc31adsm6554015wmb.44.2024.04.18.06.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 06:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1713447566; x=1714052366; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XrM/ng6nAhBYvP+9WXpoWnqe8/L1gEhRX1pjDUM4u8w=; b=vD576SW4nyzUI5zIY6HQdYYDdWHRHPweaoUp9/EYLkfv0DpvfnbsX5pKx9JIeXoHws 6JVgQ0T2ytJLFcSIVPibgoNmTfLLb9ylIBvg8ERPVP0cT2Kn1rEs+4Ie+X72t7F7+dd2 vPH+p27whQ5+RslQwfIZhpqygd/oMd24pvUcEshDBlWkQllnBGyfvykvKXnQXPsIPvRV iwxcLaNIUkqukwsPRH7ah5OgE2vnwQskNzl7/yXbSfmaj+SgAasyGSEYC+TPgpW1kUH9 uwyW57bU7qKrR0lAAEIC2xfiAb6GCdS4egWII/xbHFw3Nvv88vx79/cKQR2ddMvhTNmG YlLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713447566; x=1714052366; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XrM/ng6nAhBYvP+9WXpoWnqe8/L1gEhRX1pjDUM4u8w=; b=OPFVQp+0Dye+ftoQVB35yrdf3PJTQIxgUkIhfknZ9OCbRx1JQ/jGqOrJMrHiI5gPk4 e5SIKlHpPrLCUTFyMTqW1oH1H5/4icRTn5rnauDL/3BV7jWCQPCFpFtZ0HYw/SvJGRpp 2YvRgD9F1ynyAuK94BMVaH41iZkeDV3enTsj9gcqGd0xhW5fD7PIUWULU5kiaSIAElX0 +2BZmIM4eM/bFFpiMBsRBFg4Ud/E8sIriE1S5SCltfj26AtXzJ56KdOmMyS2h3VExlny VDNG7/n7aNjjVvJ0kecNTyQx0xMqlIstJShRhXk5YtL9vhnWZc9rxW+o3l++15gcU08t pLUg== X-Forwarded-Encrypted: i=1; AJvYcCWkCEGfTqdYXz81HTibt7gRaQHiJUfY2o537iBSpTHAnvPMtKMRc4sJ4YfFj1tZS0nZ+iQtQA3Q5NA8e1218vZNDGNLHiA= X-Gm-Message-State: AOJu0YwnCS2gSFCkew+Xy3LoMTgEki/e+S8rNme3FrMrZKxOZ6z9vcre Po2+PX8xKdyMf6niGdB41hp5QMjmPFfeNq6yKfWQHm6y3p3yoFwBJZFdN8GghqfAqeJVcJvz4Hl 5DW0= X-Google-Smtp-Source: AGHT+IEP4ek/5m4WhGkJQA3sOLeNTlx12O6AxG3WlYydEEzPVyT7hRFBsBRpvd1+hAHL0lk+Bwloqg== X-Received: by 2002:a05:600c:35ca:b0:418:9941:ca28 with SMTP id r10-20020a05600c35ca00b004189941ca28mr2013226wmq.2.1713447566158; Thu, 18 Apr 2024 06:39:26 -0700 (PDT) From: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= To: qemu-riscv@nongnu.org, Palmer Dabbelt , Alistair Francis , Bin Meng Cc: =?UTF-8?q?Cl=C3=A9ment=20L=C3=A9ger?= , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Ved Shanbhogue , Atish Patra , qemu-devel@nongnu.org Subject: [RFC PATCH 3/3] target/riscv: add Smdbltrp extension support Date: Thu, 18 Apr 2024 15:39:15 +0200 Message-ID: <20240418133916.1442471-4-cleger@rivosinc.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240418133916.1442471-1-cleger@rivosinc.com> References: <20240418133916.1442471-1-cleger@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=cleger@rivosinc.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @rivosinc-com.20230601.gappssmtp.com) X-ZM-MESSAGEID: 1713447622272100003 The Smdbltrp extension allows to generate M-mode targeted double trap exceptions [1]. Such exceptions are generated if a trap is taken while mstatus.sdt is set to 1. The specification states that if the Smnrmi extension is implemented, then the hart enters a critical-error state and generate a critical-error signal. Since there is no Smrnmi support, the implementation generates a cpu abort. Link: https://github.com/riscv/riscv-double-trap/releases/download/v0.56/ri= scv-double-trap.pdf [1] Signed-off-by: Cl=C3=A9ment L=C3=A9ger --- target/riscv/cpu.c | 5 +++++ target/riscv/cpu_bits.h | 1 + target/riscv/cpu_cfg.h | 1 + target/riscv/cpu_helper.c | 6 ++++++ target/riscv/csr.c | 12 ++++++++++++ target/riscv/op_helper.c | 3 +++ 6 files changed, 28 insertions(+) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index d159b0c6b6..98f04ecb8c 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -176,6 +176,7 @@ const RISCVIsaExtData isa_edata_arr[] =3D { ISA_EXT_DATA_ENTRY(zhinx, PRIV_VERSION_1_12_0, ext_zhinx), ISA_EXT_DATA_ENTRY(zhinxmin, PRIV_VERSION_1_12_0, ext_zhinxmin), ISA_EXT_DATA_ENTRY(smaia, PRIV_VERSION_1_12_0, ext_smaia), + ISA_EXT_DATA_ENTRY(smdbltrp, PRIV_VERSION_1_12_0, ext_smdbltrp), ISA_EXT_DATA_ENTRY(smepmp, PRIV_VERSION_1_12_0, ext_smepmp), ISA_EXT_DATA_ENTRY(smstateen, PRIV_VERSION_1_12_0, ext_smstateen), ISA_EXT_DATA_ENTRY(ssaia, PRIV_VERSION_1_12_0, ext_ssaia), @@ -954,6 +955,9 @@ static void riscv_cpu_reset_hold(Object *obj) env->mstatus_hs =3D set_field(env->mstatus_hs, MSTATUS64_UXL, env->misa_mxl); } + if (riscv_cpu_cfg(env)->ext_smdbltrp) { + env->mstatus =3D set_field(env->mstatus, MSTATUS_MDT, 1); + } } env->mcause =3D 0; env->miclaim =3D MIP_SGEIP; @@ -1574,6 +1578,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_vendor_exts[] = =3D { /* These are experimental so mark with 'x-' */ const RISCVCPUMultiExtConfig riscv_cpu_experimental_exts[] =3D { MULTI_EXT_CFG_BOOL("x-ssdbltrp", ext_ssdbltrp, false), + MULTI_EXT_CFG_BOOL("x-smdbltrp", ext_smdbltrp, false), DEFINE_PROP_END_OF_LIST(), }; =20 diff --git a/target/riscv/cpu_bits.h b/target/riscv/cpu_bits.h index 494a036f6e..660f2eed5b 100644 --- a/target/riscv/cpu_bits.h +++ b/target/riscv/cpu_bits.h @@ -545,6 +545,7 @@ #define MSTATUS_SDT 0x01000000 /* Ssdbltrp extension */ #define MSTATUS_GVA 0x4000000000ULL #define MSTATUS_MPV 0x8000000000ULL +#define MSTATUS_MDT 0x200000000000ULL /* Smdbltrp extension */ =20 #define MSTATUS64_UXL 0x0000000300000000ULL #define MSTATUS64_SXL 0x0000000C00000000ULL diff --git a/target/riscv/cpu_cfg.h b/target/riscv/cpu_cfg.h index a149c08167..cf6a802502 100644 --- a/target/riscv/cpu_cfg.h +++ b/target/riscv/cpu_cfg.h @@ -75,6 +75,7 @@ struct RISCVCPUConfig { bool ext_smstateen; bool ext_sstc; bool ext_ssdbltrp; + bool ext_smdbltrp; bool ext_svadu; bool ext_svinval; bool ext_svnapot; diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 3d747e5bfc..5ce0982f2f 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -1862,6 +1862,12 @@ void riscv_cpu_do_interrupt(CPUState *cs) s =3D set_field(s, MSTATUS_MPIE, get_field(s, MSTATUS_MIE)); s =3D set_field(s, MSTATUS_MPP, env->priv); s =3D set_field(s, MSTATUS_MIE, 0); + if (riscv_cpu_cfg(env)->ext_smdbltrp) { + if (env->mstatus & MSTATUS_MDT) + cpu_abort(CPU(cpu), "M-mode double trap\n"); + + s =3D set_field(s, MSTATUS_MDT, 1); + } env->mstatus =3D s; env->mcause =3D cause | ~(((target_ulong)-1) >> async); if (smode_double_trap) { diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 1a2e739947..200b06e320 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -1363,6 +1363,7 @@ static target_ulong legalize_mpp(CPURISCVState *env, = target_ulong old_mpp, static RISCVException write_mstatus(CPURISCVState *env, int csrno, target_ulong val) { + const RISCVCPUConfig *cfg =3D riscv_cpu_cfg(env); uint64_t mstatus =3D env->mstatus; uint64_t mask =3D 0; RISCVMXL xl =3D riscv_cpu_mxl(env); @@ -1396,6 +1397,12 @@ static RISCVException write_mstatus(CPURISCVState *e= nv, int csrno, } } =20 + if (cfg->ext_smdbltrp) { + mask |=3D MSTATUS_MDT; + if ((val & MSTATUS_MDT) !=3D 0) + mask &=3D ~MSTATUS_MIE; + } + if (xl !=3D MXL_RV32 || env->debugger) { if (riscv_has_ext(env, RVH)) { mask |=3D MSTATUS_MPV | MSTATUS_GVA; @@ -1434,6 +1441,11 @@ static RISCVException write_mstatush(CPURISCVState *= env, int csrno, uint64_t valh =3D (uint64_t)val << 32; uint64_t mask =3D riscv_has_ext(env, RVH) ? MSTATUS_MPV | MSTATUS_GVA = : 0; =20 + if (riscv_cpu_cfg(env)->ext_smdbltrp) { + mask |=3D MSTATUS_MDT; + if ((val & MSTATUS_MDT) !=3D 0) + mask |=3D MSTATUS_MIE; + } env->mstatus =3D (env->mstatus & ~mask) | (valh & mask); =20 return RISCV_EXCP_NONE; diff --git a/target/riscv/op_helper.c b/target/riscv/op_helper.c index 468ee58a00..d289d14237 100644 --- a/target/riscv/op_helper.c +++ b/target/riscv/op_helper.c @@ -354,6 +354,9 @@ target_ulong helper_mret(CPURISCVState *env) mstatus =3D set_field(mstatus, MSTATUS_MPP, riscv_has_ext(env, RVU) ? PRV_U : PRV_M); mstatus =3D set_field(mstatus, MSTATUS_MPV, 0); + if (riscv_cpu_cfg(env)->ext_smdbltrp) { + mstatus =3D set_field(mstatus, MSTATUS_MDT, 0); + } if ((env->priv_ver >=3D PRIV_VERSION_1_12_0) && (prev_priv !=3D PRV_M)= ) { mstatus =3D set_field(mstatus, MSTATUS_MPRV, 0); } --=20 2.43.0