From nobody Fri May 17 08:39:15 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1712832417; cv=none; d=zohomail.com; s=zohoarc; b=ecK0dlCRJQChuByS263onwOucHegqw1EFEm9Vuy9XWhpcDuXbMeIZ0xWL17Heqeht3NwhTrL9y0AmUI116shI2M5djYrYBCCx+gHWrnUc5pPNb3O0N51nfSZX9JmxUJe+XEfp5O/Sp1BSzgC/Wj71SVHAO+5O5P5uu7kWqVmKEE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1712832417; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ru9saU1iDfz4qwFM9pZtgFWpVV+tgMJTqfv3heZtoxI=; b=QtHaG3fRJIyViuFwHPUmT8bLW6MpAyxKYn+u858kZFm4RUi5A1bVRhnfk6sHYf6sbUeDxgQmV9Dz6XMOd80/UZdzIIwWj505XeJ+9KrsWoz3OlBYS3sD/O1sP9CpKFXg1cuhqX1BrUJeNXpS+Zd9E6/TkyFUes4FrLBxjkUDz2U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1712832417884584.0139683528246; Thu, 11 Apr 2024 03:46:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rurwl-0005JF-Pk; Thu, 11 Apr 2024 06:46:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rurwD-0004oX-VS for qemu-devel@nongnu.org; Thu, 11 Apr 2024 06:46:06 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rurw0-0004sp-QC for qemu-devel@nongnu.org; Thu, 11 Apr 2024 06:45:49 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-516dbc36918so6494985e87.0 for ; Thu, 11 Apr 2024 03:45:35 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id z17-20020a05600c0a1100b00416b8da335esm1924848wmp.48.2024.04.11.03.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 03:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712832334; x=1713437134; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ru9saU1iDfz4qwFM9pZtgFWpVV+tgMJTqfv3heZtoxI=; b=ITHW2fuzf4CcSbcYP/dbh0c72SqhGrEXaZJtY9Z6lxDxC8EnTMbFNt7vWzv8a1YO8J HbhlOtUegkG4V/QJbbo/jmHnRdz5Wj47fCPo8Di8kXZ8jac/ql7qPP+RNzMkILYYwLjS VWOIQsy7aIPYkZfu2VZat/+HQXh82i/GHzdfUG11x1a1ZLlXZVdQtFFXYRUeu2a/j3/i RjIQJv6uaNFHZNBMKI4JSJrCi9G/K/BZPGaEUXroKqBZRCueqEL+rpZ39V0lwTUP/agO LPM4tuhZpAQIJWqp5fYGXkJ6ItMnimLToT6tYBKyIKYEGBfvRPGQuRhKfLnXwBOzhUoJ XHpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712832334; x=1713437134; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ru9saU1iDfz4qwFM9pZtgFWpVV+tgMJTqfv3heZtoxI=; b=Rs1vH4ZKzzbnvShdygqoQq6Wx8nyXjeVcsAakjV+nnnY/SGMOxRb7rbE8Jdnpu+sLR N7d868DGfLu8E7WMJ+Xjf5fr9MqBMoT/KsC9o+4QqJukf/2zzsJBZOpqiZof+CW/DpTA azl0vmmxdxkE/Xfr0fKUBeE1PgmbKYtnasavrusuRvYds9x22ieYO4VxWMQYxF5w5je2 dewyxpGtmuV1LOpXAbEWiixt9g5IeXy+drdKVKnpwR235nET3EesH6l2HuaUQ855PBG7 fsnMY4i/M+XVhXubzHY1ZIEdClb2Nmbtq7h9Ww/1I9d+y8Bbrp69yoE1nV89Zgqnpdx5 6REA== X-Forwarded-Encrypted: i=1; AJvYcCUcFgLMW+MFHfH6dnBYgMugOh42RSD/IQB5KdITBWcxZGRP3Cco28HixQVbtSSWJorjPW1SadnT8MF+r5wfBNFfVVHN58c= X-Gm-Message-State: AOJu0YxiYo2yEgiLSbhWfcjIfoOddy/n2h5dvQYMU9MZ0acmsbJgsAYy P1jGCUy7x4Q5txLkZWELgjm/7cEh87vDrf2gmDAS3DBxmd3UB3J/yJg9blxU9J8= X-Google-Smtp-Source: AGHT+IFmRAoKPGwINq3tRDr0jvluIwYCRLvDyGj2tNyCb1AA9n9hQleBlxnK575dcjdh/363deXHPA== X-Received: by 2002:a19:ac07:0:b0:516:d482:d720 with SMTP id g7-20020a19ac07000000b00516d482d720mr3334647lfc.30.1712832334366; Thu, 11 Apr 2024 03:45:34 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jean-Christophe Dubois , Andrey Smirnov Subject: [PATCH] hw/misc: Avoid sprintf() in the imx devices Date: Thu, 11 Apr 2024 11:45:32 +0100 Message-Id: <20240411104532.588170-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=peter.maydell@linaro.org; helo=mail-lf1-x136.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1712832418263100001 Content-Type: text/plain; charset="utf-8" Various imx devices in hw/misc have a pattern in the debug logging where a function which prints register names has a fallback case for an unknown offset that uses sprintf(). Use snprintf() instead to avoid warnings on macos. (The buffer could never overflow because it is 20 bytes and we will write at most 10 digits plus 4 nondigits plus NUL.) Commit created with: sed -i -e 's/sprintf(unknown/snprintf(unknown, sizeof(unknown)/' hw/misc/im= x* Signed-off-by: Peter Maydell --- Philippe: here's an easy sprintf->snprintf conversion for your pile :-) hw/misc/imx25_ccm.c | 2 +- hw/misc/imx31_ccm.c | 2 +- hw/misc/imx6_ccm.c | 4 ++-- hw/misc/imx6_src.c | 2 +- hw/misc/imx6ul_ccm.c | 4 ++-- hw/misc/imx7_src.c | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/misc/imx25_ccm.c b/hw/misc/imx25_ccm.c index d888966014d..faa726a86ac 100644 --- a/hw/misc/imx25_ccm.c +++ b/hw/misc/imx25_ccm.c @@ -91,7 +91,7 @@ static const char *imx25_ccm_reg_name(uint32_t reg) case IMX25_CCM_LPIMR1_REG: return "lpimr1"; default: - sprintf(unknown, "[%u ?]", reg); + snprintf(unknown, sizeof(unknown), "[%u ?]", reg); return unknown; } } diff --git a/hw/misc/imx31_ccm.c b/hw/misc/imx31_ccm.c index a9059bb1f72..125d4fceebb 100644 --- a/hw/misc/imx31_ccm.c +++ b/hw/misc/imx31_ccm.c @@ -89,7 +89,7 @@ static const char *imx31_ccm_reg_name(uint32_t reg) case IMX31_CCM_PDR2_REG: return "PDR2"; default: - sprintf(unknown, "[%u ?]", reg); + snprintf(unknown, sizeof(unknown), "[%u ?]", reg); return unknown; } } diff --git a/hw/misc/imx6_ccm.c b/hw/misc/imx6_ccm.c index 56489d8b57b..b1def7f05b9 100644 --- a/hw/misc/imx6_ccm.c +++ b/hw/misc/imx6_ccm.c @@ -85,7 +85,7 @@ static const char *imx6_ccm_reg_name(uint32_t reg) case CCM_CMEOR: return "CMEOR"; default: - sprintf(unknown, "%u ?", reg); + snprintf(unknown, sizeof(unknown), "%u ?", reg); return unknown; } } @@ -224,7 +224,7 @@ static const char *imx6_analog_reg_name(uint32_t reg) case USB_ANALOG_DIGPROG: return "USB_ANALOG_DIGPROG"; default: - sprintf(unknown, "%u ?", reg); + snprintf(unknown, sizeof(unknown), "%u ?", reg); return unknown; } } diff --git a/hw/misc/imx6_src.c b/hw/misc/imx6_src.c index 0c6003559f5..3766bdf5619 100644 --- a/hw/misc/imx6_src.c +++ b/hw/misc/imx6_src.c @@ -68,7 +68,7 @@ static const char *imx6_src_reg_name(uint32_t reg) case SRC_GPR10: return "SRC_GPR10"; default: - sprintf(unknown, "%u ?", reg); + snprintf(unknown, sizeof(unknown), "%u ?", reg); return unknown; } } diff --git a/hw/misc/imx6ul_ccm.c b/hw/misc/imx6ul_ccm.c index bbc0be99211..0ac49ea34b3 100644 --- a/hw/misc/imx6ul_ccm.c +++ b/hw/misc/imx6ul_ccm.c @@ -143,7 +143,7 @@ static const char *imx6ul_ccm_reg_name(uint32_t reg) case CCM_CMEOR: return "CMEOR"; default: - sprintf(unknown, "%u ?", reg); + snprintf(unknown, sizeof(unknown), "%u ?", reg); return unknown; } } @@ -274,7 +274,7 @@ static const char *imx6ul_analog_reg_name(uint32_t reg) case USB_ANALOG_DIGPROG: return "USB_ANALOG_DIGPROG"; default: - sprintf(unknown, "%u ?", reg); + snprintf(unknown, sizeof(unknown), "%u ?", reg); return unknown; } } diff --git a/hw/misc/imx7_src.c b/hw/misc/imx7_src.c index b3725ff6e72..d19f0450d4a 100644 --- a/hw/misc/imx7_src.c +++ b/hw/misc/imx7_src.c @@ -75,7 +75,7 @@ static const char *imx7_src_reg_name(uint32_t reg) case SRC_GPR10: return "SRC_GPR10"; default: - sprintf(unknown, "%u ?", reg); + snprintf(unknown, sizeof(unknown), "%u ?", reg); return unknown; } } --=20 2.34.1