From nobody Fri May 17 08:39:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1712569959; cv=none; d=zohomail.com; s=zohoarc; b=Y4U42So9uwuNH0+fuQS7dCSrk62zV1ftRkICaD5uZhRBjI8tU+o04p3Lrnf0K8EgitRMxbSzYkQgEtWbisQGFk7C+m7CJ20Rb3zk4EhO7hSHtDnZalP062v774CJRF4G24GejVBlw0IguyCAxoHMZsrmNXPjNpDrBCrofH8PTVg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1712569959; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=R4JOGeyk5Il5mqTCfLsLzu8RX0JVQXq+A+QA9fciUu0=; b=j5cC5J+r2nj1Wa4VAj9yMu1I4MJceuf9b6ucEMB/BzAb9zwxb0XUP6ITjiNCMS5MRClot4VNT89uhbsuvjJDyIX8lcE9JCboZk2oVbXXMnmZ1/qYa/iFWoICuPHRKS0BKBaADm5qdBBRoHpD5GG0RbbIC/cqdso0zpOmTcokq7A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 171256995914919.133618585195336; Mon, 8 Apr 2024 02:52:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtlfz-0004Rt-HQ; Mon, 08 Apr 2024 05:52:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtlfx-0004QZ-I4 for qemu-devel@nongnu.org; Mon, 08 Apr 2024 05:52:29 -0400 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtlfw-0006MB-2x for qemu-devel@nongnu.org; Mon, 08 Apr 2024 05:52:29 -0400 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a4644bde1d4so592263766b.3 for ; Mon, 08 Apr 2024 02:52:26 -0700 (PDT) Received: from m1x-phil.lan ([176.176.144.67]) by smtp.gmail.com with ESMTPSA id y15-20020a170906448f00b00a51d250a1a4sm1479813ejo.80.2024.04.08.02.52.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 08 Apr 2024 02:52:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712569945; x=1713174745; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R4JOGeyk5Il5mqTCfLsLzu8RX0JVQXq+A+QA9fciUu0=; b=TM52845524jWjlnRBakbvN0Hn9ZKgWByVTXME3aFau1ijlitIZsJ8qTFGGlf+zlAe9 HNPYaaiqnxPz7OrTyCwouxXabidz0uSjh+zrIMUgpOTG9WOHv+8Q3BXW5hYnXN4lcxWW OOEUA+eCYcSMFZSVbcMA/qY6R38X99TskbYpm04izBbNf8cAorIUvPta3ox9aOYZxqrI 4KgC9AVsrl/Vu9NsrWwiGI6hit/zAwYKAYq49uT3i7r3jsKepmObwfHwLQKDYpxcSkoy GqRnfCz5rSfw1jVvrDn+64f0brgV0CSKIlIka+acYqvFJsNjM3n9NNn69odrt6xNzH0z ev4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712569945; x=1713174745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R4JOGeyk5Il5mqTCfLsLzu8RX0JVQXq+A+QA9fciUu0=; b=UPz8cB0QBj9vaWaUhO9rIk+H8nTkAzka+OfK3oO5/XUDhWOMvzVAdeBlJ6xVjM3hkW t6Ad83CYMj5Tr5Y/aedJXI5e9LTTJwylW1rk2wjJ6zt81M4IvNpkBOpv54PQOEHe5kuD UZJEr7tH4T+7UnPXNM/RQCjj7UHMvCi63SoSXIxk3HBybD9izYklBILVsrho+Gtcdt+F GH4/ihzPNKRFewhZVGIL5QKjbLtp19Z9rApCeohREqNafoFNwtqMdTiiALv7RKkdWlR4 +pEjN5bO6xqaqXIoUq8XRfBiYusPa0MsHL25ioh1g1FblKItnc9Fak97iWGMsu1+RwFW /yoA== X-Gm-Message-State: AOJu0YxCxFFRMPf7m41CYnTeKdE2Qa4yoc0gl+4LY3j9sh4gRlOtyAGk 1B8HWevoWGIAhTKou7Il3Skq65Quua1EQ7WjeL4QydWI+9He2CWcR3VwPm0ptBH6NKu6sbhsJo/ x X-Google-Smtp-Source: AGHT+IG+f9Fn93QtWqqaJemFcWRSpxGYywb81KX3iIBxGkLMFKLTS9QJhI2w4/Im1sD3UNb14a31QQ== X-Received: by 2002:a17:906:c109:b0:a51:b36e:61c7 with SMTP id do9-20020a170906c10900b00a51b36e61c7mr5234689ejc.13.1712569945094; Mon, 08 Apr 2024 02:52:25 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alexander Graf , Zheyu Ma , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.0? 1/2] hw/misc/applesmc: Do not call DeviceReset() from DeviceRealize() Date: Mon, 8 Apr 2024 11:52:15 +0200 Message-ID: <20240408095217.57239-2-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240408095217.57239-1-philmd@linaro.org> References: <20240408095217.57239-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62f; envelope-from=philmd@linaro.org; helo=mail-ej1-x62f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1712569961795100003 QDev core layer always call DeviceReset() after DeviceRealize(), no need to do it manually. Remove the extra call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/misc/applesmc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 72300d0cbc..8e65816da6 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c @@ -342,7 +342,6 @@ static void applesmc_isa_realize(DeviceState *dev, Erro= r **errp) } =20 QLIST_INIT(&s->data_def); - qdev_applesmc_isa_reset(dev); } =20 static Property applesmc_isa_properties[] =3D { --=20 2.41.0 From nobody Fri May 17 08:39:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1712570003; cv=none; d=zohomail.com; s=zohoarc; b=SRQ68jEPvN60C8Z8rmNmBr3vRCWPZByD7Bn/Ta3dQWs0EjF9uS7ETxu7hH+u72d44IjDTC91pCz0O006P29dGqEcjFycgzoRkbFvcUQek36hGRnHqx3/PBmnykkmFpF1nS8suGQihwIUS7N+jSIr+FaoCT6qkeN2SyHWqoAB9zI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1712570003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SX5xakbdEor+CW8HJ6tUewkIqcSRy/qmJlj1fBtPDng=; b=URn1eUNwTST9qBLXJhUr54Y71uoeUj1ruP5R5X++jCL2Wsok7kv7SIwy4SQ95xxL6EUkNs8Sc2WRMB9sWUa618pL3chcWYMksHBlBXDFG+JVlCZzMGZ0IAa4R5OYZpVltIc7cjgc6cbnZh+TP7p50Z55nMma6gaGs4XfowdmVB0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1712570003460960.6639838534724; Mon, 8 Apr 2024 02:53:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtlgA-0004cu-JP; Mon, 08 Apr 2024 05:52:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtlg3-0004Uw-Mo for qemu-devel@nongnu.org; Mon, 08 Apr 2024 05:52:36 -0400 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtlg0-0006MX-J6 for qemu-devel@nongnu.org; Mon, 08 Apr 2024 05:52:34 -0400 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-56e47843cc7so1237815a12.0 for ; Mon, 08 Apr 2024 02:52:32 -0700 (PDT) Received: from m1x-phil.lan ([176.176.144.67]) by smtp.gmail.com with ESMTPSA id ck20-20020a170906c45400b00a4e23400982sm4250084ejb.95.2024.04.08.02.52.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 08 Apr 2024 02:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712569950; x=1713174750; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SX5xakbdEor+CW8HJ6tUewkIqcSRy/qmJlj1fBtPDng=; b=aJfW2gG5FbdRsMCASpI0isTwKKbSIUr1bRkAbYbTkQIDM826KzZ90wh2zd50kHQPif oj6NWIqltICwqdVwMhtOC6UPSNgWNnddvcDp4+WkkJKhL8Tx/sJvMr9cEXdEfFMZRlGC u58JkyC/d4Ma/ijLmfjBqmcNl6CLfAY4L+ahfbqQGDqQNGjW1uUEleDi5LmqHq2X8klh +1Qf63zYZUtbV9ivWAbKVdln8mj/uspX+Wtj0lIDfVtTPLt2yaYTm1mtJKy8BayPoZaV WFNrFkyRubc/mopUKTlbTfqvAm7tv8IokgXBTWNU7vdPfKwvbFve/aZ8UsfxGFX0TQMm I/0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712569950; x=1713174750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SX5xakbdEor+CW8HJ6tUewkIqcSRy/qmJlj1fBtPDng=; b=s1M28E3VbLYWbaUgL6bJykBAYjRHZYYYM307Ih96uEePVzsnSm6ChtLow0kPs/ShG8 Zwi/+AxhNr0SvkSwOAW7FxXR6bMxX4DuIEg2Nttt++UhDLHGB2I7JkImlUFwsAmVRcY2 sx5LMh9gxnxiD3nS9nRMVB4cq7KNTq6aumHQ6Tjj1bYkXjfybo78PSF/bAA2UaORYqBX 79cNWI4Vf6drrgzxsRwsW5BKdK6pN1RBIAmLcq8x/exGEkdyNSkOulI8o94YORGV47JU gRKEi9D8HV/z3QtV6f4JTNwJXRwoBjlKNFLZwTEoT9zRc+uP883uZZXVzfZFFl0zcvD8 S21A== X-Gm-Message-State: AOJu0YwbqekxePbWUWryhe+GSqmGTZxSXceybBeUfWvY3VXGUgmrzsEa uN20FBDkNjypjj+D2RsTI5GX169FcQEHebDg5zL2zYP1a+e6OzkxnIA+jwNxi4fIggngliM9uqc 4 X-Google-Smtp-Source: AGHT+IE9zdnbDSjX5h8fQtyGnepEYWsOFE0Qaa2SFl1gvr0OWlqkoFPHn7rlUFY6wkM4JXxDHkEYpA== X-Received: by 2002:a17:907:7ea4:b0:a51:c975:f02a with SMTP id qb36-20020a1709077ea400b00a51c975f02amr2584452ejc.65.1712569950602; Mon, 08 Apr 2024 02:52:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alexander Graf , Zheyu Ma , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.0? 2/2] hw/misc/applesmc: Fix memory leak in reset() handler Date: Mon, 8 Apr 2024 11:52:16 +0200 Message-ID: <20240408095217.57239-3-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240408095217.57239-1-philmd@linaro.org> References: <20240408095217.57239-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=philmd@linaro.org; helo=mail-ed1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1712570005655100003 AppleSMCData is allocated with g_new0() in applesmc_add_key(): release it with g_free(). Leaked since commit 1ddda5cd36 ("AppleSMC device emulation"). Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2272 Reported-by: Zheyu Ma Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/misc/applesmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 8e65816da6..14e3ef667d 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c @@ -274,6 +274,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev) /* Remove existing entries */ QLIST_FOREACH_SAFE(d, &s->data_def, node, next) { QLIST_REMOVE(d, node); + g_free(d); } s->status =3D 0x00; s->status_1e =3D 0x00; --=20 2.41.0