From nobody Fri May 17 11:28:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1712492936; cv=none; d=zohomail.com; s=zohoarc; b=LiRMZhhRdSRNFVXax38qN1Qa51THam2B63/LfDARiYohdymUB8KMZ/F8AKuOzPhZ/hqX0T49r32+3Y4eJmdwTVG/lF+CdBsLvPqry6gNlJoQkAVskqc506QVusY9IVRyj8ojzHFNCD2wZO3ymk7B59LbHtrHnF1YtcoIqWpMwVc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1712492936; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4f7TSRBbgfkLgOcVoI4QIjA+BkbLTOmgyh2hhWCMGvw=; b=OFTZuy8Cn5Amc1aD5xPKmmmwsqACg1nbM1eCa7ItY1rGRDs+oNDIajn+zK2SUBMobzusqKEVb13lpfcVOBny4gqbCqjldQgzQLQaCIqmANG1qndBYmDkb3KggU2azjEY9b2G/yO9FVwP6yJ+D+7aRlJ+/y0nY7h/NxItpTY0y2s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1712492936958164.2529881103402; Sun, 7 Apr 2024 05:28:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtRd9-00041L-Mo; Sun, 07 Apr 2024 08:28:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtJVi-0005uS-6N; Sat, 06 Apr 2024 23:48:02 -0400 Received: from m16.mail.163.com ([220.197.31.2]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtJVc-0005om-Gm; Sat, 06 Apr 2024 23:48:01 -0400 Received: from yangzhang2020.localdomain (unknown [60.27.226.9]) by gzga-smtp-mta-g3-1 (Coremail) with SMTP id _____wDHp_crFxJmajFNAQ--.60835S2; Sun, 07 Apr 2024 11:46:52 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=4f7TS RBbgfkLgOcVoI4QIjA+BkbLTOmgyh2hhWCMGvw=; b=HjnbinctP2VL5JlGEvzzX d18f3oU1ysZ77D9ie6bgDNAXLORScAz/X4KfOAYawPiKD7MgmBP8dcEaoZUY5RzX L5c67i++VTSS5sEf70sR7+Ry3SIsaK0EehFtz8OWIE4TUGn14B7aC+WTRtZ/jjlL 5C4Oit1wArunk6K3jVS1nE= From: "yang.zhang" To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org, zhiwei_liu@linux.alibaba.com, dbarboza@ventanamicro.com, liwei1518@gmail.com, bin.meng@windriver.com, alistair.francis@wdc.com, palmer@dabbelt.com, anup@brainfault.org Cc: "yang.zhang" Subject: [PATCH] hw/intc/riscv_aplic: APLICs should add child earlier than realize Date: Sun, 7 Apr 2024 11:46:52 +0800 Message-Id: <20240407034652.25739-1-gaoshanliukou@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDHp_crFxJmajFNAQ--.60835S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrKF1rGr4fWw13tr18uFW3ZFb_yoWDCrb_GF 9ak3s7GrWrXF4fAayDCF4UGFyvv34rurW3ZFWSvF43tr4UKr98twnFgr9xtrW09rW7Wr93 GFyvvr93AryUGjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUn8gAUUUUUU== X-Originating-IP: [60.27.226.9] X-CM-SenderInfo: pjdr2x5dqox3xnrxqiywtou0bp/1tbiRAGv8mVOCD0wFAABsj Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=220.197.31.2; envelope-from=gaoshanliukou@163.com; helo=m16.mail.163.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 07 Apr 2024 08:27:52 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @163.com) X-ZM-MESSAGEID: 1712492937955100001 Content-Type: text/plain; charset="utf-8" From: "yang.zhang" Since only root APLICs can have hw IRQ lines, aplic->parent should be initialized first. Signed-off-by: yang.zhang Reviewed-by: Daniel Henrique Barboza --- hw/intc/riscv_aplic.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/intc/riscv_aplic.c b/hw/intc/riscv_aplic.c index fc5df0d598..32edd6d07b 100644 --- a/hw/intc/riscv_aplic.c +++ b/hw/intc/riscv_aplic.c @@ -1000,16 +1000,16 @@ DeviceState *riscv_aplic_create(hwaddr addr, hwaddr= size, qdev_prop_set_bit(dev, "msimode", msimode); qdev_prop_set_bit(dev, "mmode", mmode); =20 + if (parent) { + riscv_aplic_add_child(parent, dev); + } + sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); =20 if (!is_kvm_aia(msimode)) { sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, addr); } =20 - if (parent) { - riscv_aplic_add_child(parent, dev); - } - if (!msimode) { for (i =3D 0; i < num_harts; i++) { CPUState *cpu =3D cpu_by_arch_id(hartid_base + i); --=20 2.25.1