From nobody Mon Feb 9 07:35:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1712233603; cv=none; d=zohomail.com; s=zohoarc; b=nRc0fEaA+qwkdd83ZlIoErzfk/IZ+Ax8OY1zA5a9xXtCrps6FzwmmfJxrIAHEsemLhJ7tkrPVW1Uojhx8pa3EhUBW919l+UVdJXbI0zi3FVX4ZPdymNt5Cf07ojNK8IkhK1RNsFBBMgQ55xWVUGoJqkbfHv4Fq9kZoG5osHgws8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1712233603; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=a31EVxox+uEf/JvzH//LShQvlLk4Tanal3CfBj7bgpw=; b=Lf9b0530WkY2gLBJoGfZ68WEqUrpYsePyT8BeDahYZ5ee6J9YS4v+e5L4qdYa/t2Av3JHR0MMyGk2fIpA6n6ttz9LwUdUamVEDTs5a9ID/KDZcXR/0/37xMWDyQESTNwpFRKyrA+FhE5eHxL+Hcn3T2qWQZQqG2btqZzR92tElo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1712233603251806.9735454127043; Thu, 4 Apr 2024 05:26:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsM8s-0000yB-B8; Thu, 04 Apr 2024 08:24:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsM8q-0000wc-O3 for qemu-devel@nongnu.org; Thu, 04 Apr 2024 08:24:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsM8n-00014T-Qv for qemu-devel@nongnu.org; Thu, 04 Apr 2024 08:24:28 -0400 Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-634-qrBQwBT9MCCCttF5nWOxrA-1; Thu, 04 Apr 2024 08:24:23 -0400 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a4e9636661eso63913366b.1 for ; Thu, 04 Apr 2024 05:24:23 -0700 (PDT) Received: from localhost.localdomain (host-87-12-25-33.business.telecomitalia.it. [87.12.25.33]) by smtp.gmail.com with ESMTPSA id qf4-20020a1709077f0400b00a5195edf8e8sm174517ejc.62.2024.04.04.05.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 05:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712233465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a31EVxox+uEf/JvzH//LShQvlLk4Tanal3CfBj7bgpw=; b=R8I3un0wTct1U6ES223AO7B0L4cZ1yx2kk+5X+8flT+d1cid45KADNHSAwsVPzyxql5FP0 oWa30fJ+HCjdkwNz1nFM63bAkLH/gqOkG1gKadLCoujGvxKsxOWRfTdv96h6/UIGDSlYby HyvTAgvpBYMzdBbkRfpgaMDavg4TG6o= X-MC-Unique: qrBQwBT9MCCCttF5nWOxrA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712233462; x=1712838262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a31EVxox+uEf/JvzH//LShQvlLk4Tanal3CfBj7bgpw=; b=rU7MCfwAb89Z7KYI86aN38HHVxeoWxb6A8fDpI9me7KTLBIq2MX4/4hVxsesRcNGZm SdUFvBOiLVOCxEybAYNqNQRP57NpG1mHZmuFJW8F0UC5OUHJUetQQaC/b8+yIWS3yoLL Brj8ISa9swYXQ7RtD6m8DQoaQj8jacNEAC+MroAKWtOltGViG7lDKMMsFjN88Y8l8aIe o4BIa+j92M8Vn2taZXq5N1eAs8MlVrq0VAGUGha1yhkqRpfZjGbp9b3rfZl1c6mp397i G+DjbXa1MYUjixIe0gUBVyfJxdQ+EOvgQHSOqlp7q0KvWhyvyDoJV9d6PRgZSTPTp5mN 2MDg== X-Gm-Message-State: AOJu0YzyWF525nuwxKCwXBYkFGllUWNP1k8Y0Xk6VR8+vug6qBQVI/FN luRFhU4PH5ypMiWZsH2M3T91w9vnAD9Pwl8E9kngo833Hfukmov2XaYhle9F3K457W5+f59ZjwI kP105PC4bGpkp9gcMdly6Ax2QyszDQ7awCikt/GXYeMtFyi/gyUoSz9UzYtuuwMqKgNmTa9zc8p Da/nD714MMSuk2PognqO/thqMb+W008y/D1Xqm X-Received: by 2002:a17:906:1956:b0:a4a:aa3b:8002 with SMTP id b22-20020a170906195600b00a4aaa3b8002mr1485742eje.15.1712233461710; Thu, 04 Apr 2024 05:24:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5yuDCHj61XKP+6xN1UroYtqXFtcA32EQMQT2scH8qJyhRE3qsgdCdlgWysAROmnSaHUiVtQ== X-Received: by 2002:a17:906:1956:b0:a4a:aa3b:8002 with SMTP id b22-20020a170906195600b00a4aaa3b8002mr1485704eje.15.1712233461311; Thu, 04 Apr 2024 05:24:21 -0700 (PDT) From: Stefano Garzarella To: qemu-devel@nongnu.org Cc: Coiby Xu , "Michael S. Tsirkin" , qemu-block@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , slp@redhat.com, Eduardo Habkost , Kevin Wolf , Hanna Reitz , Igor Mammedov , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Thomas Huth , Raphael Norwitz , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Brad Smith , stefanha@redhat.com, Eric Blake , Paolo Bonzini , Laurent Vivier , David Hildenbrand , Markus Armbruster , gmaglione@redhat.com, Jason Wang , Stefano Garzarella Subject: [PATCH for-9.1 v3 09/11] hostmem: add a new memory backend based on POSIX shm_open() Date: Thu, 4 Apr 2024 14:23:28 +0200 Message-ID: <20240404122330.92710-10-sgarzare@redhat.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240404122330.92710-1-sgarzare@redhat.com> References: <20240404122330.92710-1-sgarzare@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=sgarzare@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1712233605087100004 Content-Type: text/plain; charset="utf-8" shm_open() creates and opens a new POSIX shared memory object. A POSIX shared memory object allows creating memory backend with an associated file descriptor that can be shared with external processes (e.g. vhost-user). The new `memory-backend-shm` can be used as an alternative when `memory-backend-memfd` is not available (Linux only), since shm_open() should be provided by any POSIX-compliant operating system. This backend mimics memfd, allocating memory that is practically anonymous. In theory shm_open() requires a name, but this is allocated for a short time interval and shm_unlink() is called right after shm_open(). After that, only fd is shared with external processes (e.g., vhost-user) as if it were associated with anonymous memory. In the future we may also allow the user to specify the name to be passed to shm_open(), but for now we keep the backend simple, mimicking anonymous memory such as memfd. Signed-off-by: Stefano Garzarella Acked-by: David Hildenbrand --- v3 - enriched commit message and documentation to highlight that we want to mimic memfd (David) --- docs/system/devices/vhost-user.rst | 5 +- qapi/qom.json | 17 +++++ backends/hostmem-shm.c | 118 +++++++++++++++++++++++++++++ backends/meson.build | 1 + qemu-options.hx | 11 +++ 5 files changed, 150 insertions(+), 2 deletions(-) create mode 100644 backends/hostmem-shm.c diff --git a/docs/system/devices/vhost-user.rst b/docs/system/devices/vhost= -user.rst index 9b2da106ce..35259d8ec7 100644 --- a/docs/system/devices/vhost-user.rst +++ b/docs/system/devices/vhost-user.rst @@ -98,8 +98,9 @@ Shared memory object =20 In order for the daemon to access the VirtIO queues to process the requests it needs access to the guest's address space. This is -achieved via the ``memory-backend-file`` or ``memory-backend-memfd`` -objects. A reference to a file-descriptor which can access this object +achieved via the ``memory-backend-file``, ``memory-backend-memfd``, or +``memory-backend-shm`` objects. +A reference to a file-descriptor which can access this object will be passed via the socket as part of the protocol negotiation. =20 Currently the shared memory object needs to match the size of the main diff --git a/qapi/qom.json b/qapi/qom.json index 85e6b4f84a..5252ec69e3 100644 --- a/qapi/qom.json +++ b/qapi/qom.json @@ -721,6 +721,19 @@ '*hugetlbsize': 'size', '*seal': 'bool' } } =20 +## +# @MemoryBackendShmProperties: +# +# Properties for memory-backend-shm objects. +# +# The @share boolean option is true by default with shm. +# +# Since: 9.1 +## +{ 'struct': 'MemoryBackendShmProperties', + 'base': 'MemoryBackendProperties', + 'data': { } } + ## # @MemoryBackendEpcProperties: # @@ -976,6 +989,8 @@ { 'name': 'memory-backend-memfd', 'if': 'CONFIG_LINUX' }, 'memory-backend-ram', + { 'name': 'memory-backend-shm', + 'if': 'CONFIG_POSIX' }, 'pef-guest', { 'name': 'pr-manager-helper', 'if': 'CONFIG_LINUX' }, @@ -1047,6 +1062,8 @@ 'memory-backend-memfd': { 'type': 'MemoryBackendMemfdPropertie= s', 'if': 'CONFIG_LINUX' }, 'memory-backend-ram': 'MemoryBackendProperties', + 'memory-backend-shm': { 'type': 'MemoryBackendShmProperties', + 'if': 'CONFIG_POSIX' }, 'pr-manager-helper': { 'type': 'PrManagerHelperProperties', 'if': 'CONFIG_LINUX' }, 'qtest': 'QtestProperties', diff --git a/backends/hostmem-shm.c b/backends/hostmem-shm.c new file mode 100644 index 0000000000..7595204d29 --- /dev/null +++ b/backends/hostmem-shm.c @@ -0,0 +1,118 @@ +/* + * QEMU host POSIX shared memory object backend + * + * Copyright (C) 2024 Red Hat Inc + * + * Authors: + * Stefano Garzarella + * + * This work is licensed under the terms of the GNU GPL, version 2 or late= r. + * See the COPYING file in the top-level directory. + */ + +#include "qemu/osdep.h" +#include "sysemu/hostmem.h" +#include "qapi/error.h" + +#define TYPE_MEMORY_BACKEND_SHM "memory-backend-shm" + +OBJECT_DECLARE_SIMPLE_TYPE(HostMemoryBackendShm, MEMORY_BACKEND_SHM) + +struct HostMemoryBackendShm { + HostMemoryBackend parent_obj; +}; + +static bool +shm_backend_memory_alloc(HostMemoryBackend *backend, Error **errp) +{ + g_autoptr(GString) shm_name =3D g_string_new(NULL); + g_autofree char *backend_name =3D NULL; + uint32_t ram_flags; + int fd, oflag; + mode_t mode; + + if (!backend->size) { + error_setg(errp, "can't create backend with size 0"); + return false; + } + + /* + * Let's use `mode =3D 0` because we don't want other processes to ope= n our + * memory unless we share the file descriptor with them. + */ + mode =3D 0; + oflag =3D O_RDWR | O_CREAT | O_EXCL; + backend_name =3D host_memory_backend_get_name(backend); + + /* + * Some operating systems allow creating anonymous POSIX shared memory + * objects (e.g. FreeBSD provides the SHM_ANON constant), but this is = not + * defined by POSIX, so let's create a unique name. + * + * From Linux's shm_open(3) man-page: + * For portable use, a shared memory object should be identified + * by a name of the form /somename;" + */ + g_string_printf(shm_name, "/qemu-" FMT_pid "-shm-%s", getpid(), + backend_name); + + fd =3D shm_open(shm_name->str, oflag, mode); + if (fd < 0) { + error_setg_errno(errp, errno, + "failed to create POSIX shared memory"); + return false; + } + + /* + * We have the file descriptor, so we no longer need to expose the + * POSIX shared memory object. However it will remain allocated as lon= g as + * there are file descriptors pointing to it. + */ + shm_unlink(shm_name->str); + + if (ftruncate(fd, backend->size) =3D=3D -1) { + error_setg_errno(errp, errno, + "failed to resize POSIX shared memory to %" PRIu6= 4, + backend->size); + close(fd); + return false; + } + + ram_flags =3D backend->share ? RAM_SHARED : 0; + ram_flags |=3D backend->reserve ? 0 : RAM_NORESERVE; + + return memory_region_init_ram_from_fd(&backend->mr, OBJECT(backend), + backend_name, backend->size, + ram_flags, fd, 0, errp); +} + +static void +shm_backend_instance_init(Object *obj) +{ + HostMemoryBackendShm *m =3D MEMORY_BACKEND_SHM(obj); + + MEMORY_BACKEND(m)->share =3D true; +} + +static void +shm_backend_class_init(ObjectClass *oc, void *data) +{ + HostMemoryBackendClass *bc =3D MEMORY_BACKEND_CLASS(oc); + + bc->alloc =3D shm_backend_memory_alloc; +} + +static const TypeInfo shm_backend_info =3D { + .name =3D TYPE_MEMORY_BACKEND_SHM, + .parent =3D TYPE_MEMORY_BACKEND, + .instance_init =3D shm_backend_instance_init, + .class_init =3D shm_backend_class_init, + .instance_size =3D sizeof(HostMemoryBackendShm), +}; + +static void register_types(void) +{ + type_register_static(&shm_backend_info); +} + +type_init(register_types); diff --git a/backends/meson.build b/backends/meson.build index 8b2b111497..3867b0d363 100644 --- a/backends/meson.build +++ b/backends/meson.build @@ -13,6 +13,7 @@ system_ss.add([files( if host_os !=3D 'windows' system_ss.add(files('rng-random.c')) system_ss.add(files('hostmem-file.c')) + system_ss.add([files('hostmem-shm.c'), rt]) endif if host_os =3D=3D 'linux' system_ss.add(files('hostmem-memfd.c')) diff --git a/qemu-options.hx b/qemu-options.hx index 7fd1713fa8..02783803aa 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -5230,6 +5230,17 @@ SRST =20 The ``share`` boolean option is on by default with memfd. =20 + ``-object memory-backend-shm,id=3Did,merge=3Don|off,dump=3Don|off,shar= e=3Don|off,prealloc=3Don|off,size=3Dsize,host-nodes=3Dhost-nodes,policy=3Dd= efault|preferred|bind|interleave`` + Creates a POSIX shared memory backend object, which allows + QEMU to share the memory with an external process (e.g. when + using vhost-user). This backend mimics memfd, allocating memory th= at is + practically anonymous. This is useful when memfd is not available. + + Please refer to ``memory-backend-file`` for a description of the + options. + + The ``share`` boolean option is on by default with shm. + ``-object iommufd,id=3Did[,fd=3Dfd]`` Creates an iommufd backend which allows control of DMA mapping through the ``/dev/iommu`` device. --=20 2.44.0