From nobody Fri May 10 04:24:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1711132360; cv=none; d=zohomail.com; s=zohoarc; b=Fef/BBVfsFPth8n/sNPb/dy/+M8mIS7gOXdtORS2rJHrcNN/DOVqE4iILAM36uYmlVlvfZQT199Didguhy7Q/TPgEgrX4TBjkhrIU9ORFE0Iei3UButQr7GU0yMohQReTReY/LiL878TVCW+XlbJNzczOaMTNdHyvumLYgU4T88= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1711132360; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sLGalgY5t/gt4o5h6PjzJhOOljlrIDNBuY8bQcdGuLA=; b=DEV0cLnrGsi5vXlGtdkKzFvOpnaC870qTkpJQzKreG+bbJU/xHp7+ueObFgewpKXvWxLrGhA48d1kBgjKkAaqkSVwVKsriO5ZtSV1M9I+3KlRcrSzqspCFZTqHLUxPUN1uAjri2+lLQxqGLBXle/tCu3R+sKZP+2H+/Q9btt4i0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1711132360503847.9441380883352; Fri, 22 Mar 2024 11:32:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rnjgg-00049O-Ds; Fri, 22 Mar 2024 14:32:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnjgZ-00048B-01 for qemu-devel@nongnu.org; Fri, 22 Mar 2024 14:32:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnjgW-0003ve-QF for qemu-devel@nongnu.org; Fri, 22 Mar 2024 14:32:10 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-8P3MZXtcPv-dn8TGqCo2CQ-1; Fri, 22 Mar 2024 14:32:00 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7D6C2185A781; Fri, 22 Mar 2024 18:32:00 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0614D8173; Fri, 22 Mar 2024 18:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711132324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=sLGalgY5t/gt4o5h6PjzJhOOljlrIDNBuY8bQcdGuLA=; b=JVLQPwb4Z4CTpvEDqxBPPFWvsQ6GYNHxAz0KzrF3sibjFqBtxaYC0Ff5BDYe3W8FiSkiQ0 Tszbbs1FqzylRX8aofGIt5ucS5az6/d0GKvnw9IGv1Ozi1tDaoory6cWm0vxk9oLTpxMQD YdbrpU72IsVraMlKq4mL1NZlnXvlbxg= X-MC-Unique: 8P3MZXtcPv-dn8TGqCo2CQ-1 From: Thomas Huth To: Alistair Francis , "Edgar E. Iglesias" , qemu-devel@nongnu.org Cc: Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] hw/microblaze: Do not allow xlnx-zynqmp-pmu-soc to be created by the user Date: Fri, 22 Mar 2024 19:31:53 +0100 Message-ID: <20240322183153.1023359-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.222, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1711132365460100001 Content-Type: text/plain; charset="utf-8" Using xlnx-zynqmp-pmu-soc on the command line causes QEMU to crash: ./qemu-system-microblazeel -M petalogix-ml605 -device xlnx-zynqmp-pmu-soc ** ERROR:tcg/tcg.c:813:tcg_register_thread: assertion failed: (n < tcg_max_ct= xs) Bail out! Aborted (core dumped) Mark the device with "user_creatable =3D false" to avoid that this can happ= en. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2229 Signed-off-by: Thomas Huth --- hw/microblaze/xlnx-zynqmp-pmu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/microblaze/xlnx-zynqmp-pmu.c b/hw/microblaze/xlnx-zynqmp-pm= u.c index 5a2016672a..1bfc9641d2 100644 --- a/hw/microblaze/xlnx-zynqmp-pmu.c +++ b/hw/microblaze/xlnx-zynqmp-pmu.c @@ -125,6 +125,8 @@ static void xlnx_zynqmp_pmu_soc_class_init(ObjectClass = *oc, void *data) { DeviceClass *dc =3D DEVICE_CLASS(oc); =20 + /* xlnx-zynqmp-pmu-soc causes crashes when cold-plugged twice */ + dc->user_creatable =3D false; dc->realize =3D xlnx_zynqmp_pmu_soc_realize; } =20 --=20 2.44.0