From nobody Wed May 15 12:51:39 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1710993547; cv=none; d=zohomail.com; s=zohoarc; b=iFheRXA5wcEaVIuq1pQz0qrVJxNvTLOQej2D1FBYKoq+HzMZBCgvsrIjlTLCq+pTI+69xMRqReFz93FpaXBaUNmaXuOVMTpEbRu0vMGFwCWjRJ8nd16v8QEdU6wwuBIBvt4I+vLi33xah+RbKgPAqOWHiCJYflI+W7rImrjwH+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710993547; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Pug4F6r1CfiMSzEkl8em54qDpzwKLGZq/dMlcjabCJA=; b=VKUyyEo8QpbHqce2TdBgsuN72VNWOAYDnawVNQzCfLxJW4HF2A+TNn8B9DZ2A0z1guYPranX0Sy7Ro2mqdHiYsNZEz8zdboja2+nyXvT7sgKCEygzdAOvl76Sn88pdqvMZebIl8LfMt7KfGlVMU+weHZ1rJfOmqZIgR/ZiE79Pg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710993547668785.4374677499653; Wed, 20 Mar 2024 20:59:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rn9Zl-0000gs-VD; Wed, 20 Mar 2024 23:58:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rn9Zj-0000gK-QT; Wed, 20 Mar 2024 23:58:43 -0400 Received: from out30-113.freemail.mail.aliyun.com ([115.124.30.113]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rn9Zf-0001xm-Sn; Wed, 20 Mar 2024 23:58:43 -0400 Received: from localhost.localdomain(mailfrom:eric.huang@linux.alibaba.com fp:SMTPD_---0W2zHuTn_1710993503) by smtp.aliyun-inc.com; Thu, 21 Mar 2024 11:58:24 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1710993506; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=Pug4F6r1CfiMSzEkl8em54qDpzwKLGZq/dMlcjabCJA=; b=xS2xahhFsoFmeaDqF5guawDaa5UHu70/zbQmOnVFYENvB4ifHfOn+rZnhOyddVTD07tLl7i8O5W98Et3BmFeQ8fIVi8XV8X+yqaFGgzsGxiwIzkGNF78C0dm0ZyZdTpvfI0oThsIlTghkc1Lj/5kVZvSQC6cMexSa4hV8AbkU30= X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R811e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=ay29a033018046049; MF=eric.huang@linux.alibaba.com; NM=1; PH=DS; RN=10; SR=0; TI=SMTPD_---0W2zHuTn_1710993503; From: Huang Tao To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, zhiwei_liu@linux.alibaba.com, dbarboza@ventanamicro.com, liwei1518@gmail.com, bin.meng@windriver.com, alistair.francis@wdc.com, palmer@dabbelt.com, Huang Tao , Richard Henderson Subject: [PATCH v2] target/riscv: Fix the element agnostic function problem Date: Thu, 21 Mar 2024 11:58:16 +0800 Message-ID: <20240321035816.99983-1-eric.huang@linux.alibaba.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=115.124.30.113; envelope-from=eric.huang@linux.alibaba.com; helo=out30-113.freemail.mail.aliyun.com X-Spam_score_int: -174 X-Spam_score: -17.5 X-Spam_bar: ----------------- X-Spam_report: (-17.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.alibaba.com) X-ZM-MESSAGEID: 1710993548298100003 Content-Type: text/plain; charset="utf-8" In RVV and vcrypto instructions, the masked and tail elements are set to 1s using vext_set_elems_1s function if the vma/vta bit is set. It is the eleme= nt agnostic policy. However, this function can't deal the big endian situation. This patch fixes the problem by adding handling of such case. Signed-off-by: Huang Tao Suggested-by: Richard Henderson Reviewed-by: LIU Zhiwei --- Changes in v2: - Keep the api of vext_set_elems_1s - Reduce the number of patches. --- target/riscv/vector_internals.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/target/riscv/vector_internals.c b/target/riscv/vector_internal= s.c index 12f5964fbb..3e45b9b4a7 100644 --- a/target/riscv/vector_internals.c +++ b/target/riscv/vector_internals.c @@ -30,6 +30,28 @@ void vext_set_elems_1s(void *base, uint32_t is_agnostic,= uint32_t cnt, if (tot - cnt =3D=3D 0) { return ; } + +#if HOST_BIG_ENDIAN + /* + * Deal the situation when the elements are insdie + * only one uint64 block including setting the + * masked-off element. + */ + if ((tot - 1) ^ cnt < 8) { + memset(base + H1(tot - 1), -1, tot - cnt); + return; + } + /* + * Otherwise, at least cross two uint64_t blocks. + * Set first unaligned block. + */ + if (cnt % 8 !=3D 0) { + uint32_t j =3D ROUND_UP(cnt, 8); + memset(base + H1(j - 1), -1, j - cnt); + cnt =3D j; + } + /* Set other 64bit aligend blocks */ +#endif memset(base + cnt, -1, tot - cnt); } =20 --=20 2.41.0