From nobody Mon Feb 9 21:36:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass(p=quarantine dis=none) header.from=amd.com ARC-Seal: i=2; a=rsa-sha256; t=1710924500; cv=pass; d=zohomail.com; s=zohoarc; b=i1DWX75Bv7QDX0LWLCoXAXEhz/16m5xxItJlyI9thpo0Z9IA3JPvTva0ROndSM3TfGTesX5edt1breynRR7vsCwiIjQ1iQXoclDz41K6OqvjgVsVbQ+65wgLVr/l/UxTWlV5BedNMKNNGWmt2RoaM973+eKQQMnaHiH8xMmCOS0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710924500; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/yKiAMs6y17O5kmKwFQUlz87KwThdrdL0Q1XulVXP24=; b=drUdcpGUsPAxaxRHteZSm3tozxol2/5ujc9YT/AxCpJy0zWGj9JIP38NBhl+vTge5tJlR3ogqNAkuDsd0Gd3Uz0gc3J6pJmJtkWA9Ovt6rrdpnHsyygZ5Uxz7SQpwMhfxPn37oD+AGzZwp4OJXbE81rLh/hfxWZ94q+rfdJMW54= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=amd.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710924500387660.68211477919; Wed, 20 Mar 2024 01:48:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmrcN-00063d-Jq; Wed, 20 Mar 2024 04:48:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmrbz-0005uU-To for qemu-devel@nongnu.org; Wed, 20 Mar 2024 04:47:52 -0400 Received: from mail-bn8nam12on20600.outbound.protection.outlook.com ([2a01:111:f403:2418::600] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmrby-0000Ry-3o for qemu-devel@nongnu.org; Wed, 20 Mar 2024 04:47:51 -0400 Received: from BYAPR08CA0045.namprd08.prod.outlook.com (2603:10b6:a03:117::22) by PH7PR12MB6539.namprd12.prod.outlook.com (2603:10b6:510:1f0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.22; Wed, 20 Mar 2024 08:47:47 +0000 Received: from MWH0EPF000A6733.namprd04.prod.outlook.com (2603:10b6:a03:117:cafe::9c) by BYAPR08CA0045.outlook.office365.com (2603:10b6:a03:117::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.26 via Frontend Transport; Wed, 20 Mar 2024 08:47:47 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000A6733.mail.protection.outlook.com (10.167.249.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7409.10 via Frontend Transport; Wed, 20 Mar 2024 08:47:46 +0000 Received: from localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 20 Mar 2024 03:47:46 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fsHyjXN6/Lo33kpj3Zp6kzdUjzsWhMNAiw/+ArgY0fzxkBwKLfPj7rSZJvzHau3+LSg9Dc+t3ST92pL4X/36Eam8HptTqG9ZVBb5s/UycbHGhKJC/k23cDM4ePMkx8FeDhBJGR4eHNAYDa7rRdEuV9TPNN3C9VBnDfHeHyKpMRVCMCRabXYkv1oOiW65QHhE2bnQXXSNmAvVrPSbJ+yYFLdMV+TbPZtjlANSu5OevMvjarvO2WuTswfR9DkOcBh8lla+sw7I1/wZOdAU43n+d4XX2CC0ft3PXa2F4T52OCabKm7iiknCWrX+9dnuv48xb0qt3sHe7ZYcScdQD8nvfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/yKiAMs6y17O5kmKwFQUlz87KwThdrdL0Q1XulVXP24=; b=AyqdIrANNpG/aILRp1mTtQNadlJOAiakZmRnfosuoHCx8PvyML9twPLuEJKtm9cxSi1fSy9LIL7oV6aiwVXlEjBLtuYkTZ3Ojm0YBUToBZwaShr1Agao8H+65aYajWrBDlHKz/q2EWKK0yIR8USvleT7nBBNljQY1EKDRDkH/uwmCdDatW8ii9Sxe5j6ve+/QCUiUwzvD1OdBYub9QBSAadL83itx55XBvk3G6XxBxWIcwwxuWc265aKaMo5zrrV4UKFbCHbpJ+DyLYNT9pQrNoUnoa4DaZPyeANG7r2oGC/B+zR8Vfim4hz5MlaCDl5q4J4YyyX3/zr67SnmfNFTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=nongnu.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/yKiAMs6y17O5kmKwFQUlz87KwThdrdL0Q1XulVXP24=; b=Q0krMyYpqhmFR6L8iYUVMgCxYRsHPv1UWYdwXexHJ8GaL45D63Tn4l3rIct86BOPO0vH2MagmDsOqCzezcU0vYR+nPBUzAc1HnEsgiditz0yU4dgQb4gbxWxdTmbA6PauTXX1TTiZJa52SkDScEYnGsWsuS7ZkyVCtNJnRhS2Ks= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Michael Roth To: CC: , Tom Lendacky , "Paolo Bonzini" , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Markus Armbruster , Pankaj Gupta , Xiaoyao Li , Isaku Yamahata Subject: [PATCH v3 26/49] i386/sev: Skip machine-init-done notifiers for SNP Date: Wed, 20 Mar 2024 03:39:22 -0500 Message-ID: <20240320083945.991426-27-michael.roth@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240320083945.991426-1-michael.roth@amd.com> References: <20240320083945.991426-1-michael.roth@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000A6733:EE_|PH7PR12MB6539:EE_ X-MS-Office365-Filtering-Correlation-Id: 46b603f5-16fd-43eb-dc3c-08dc48ba6ab4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b6wCCzyxr8hwsDnAjV1Y5N71P3UWNnP+cnOyTLiJk6S9H4VV5sefrxhTtC2IJ1dv8BFTuKuoc6DqNrYtt1Moz9thSzsZpL/5d55qjMpjkxmJQQyth79nisDZsf5ecIHwcdcHZl5whGV3adhewmEZsd+ifHBGSCfUM2f0Y/L7GQx8pW2sa4F6W9WAMuLi6P7bfjrfC4uWBX/5LidE5hS87egB5l9XrQKWJpKiUd+U0+u4LCsqiQHN89aBZOgH5XslT1hFffE28Yc7eVCuFUzj7fbGieyz3I/7J+ekP6BlNtI6FVqW4Snz/l4x6ceN+nOVzGK5fp/JkEUTlmqsPVHF2ERApIBgrr4uiaSSucgVl4LsOkAfzutYnX0CCAdihwlbfH1eU/8MjfqD8Gb46H53oo5MJ9vhDRkqGB++c4X2ME5DlvjwEWZYGREQ5TJo7SW2CEp954srlHF26FIAARjSu7R5L7XSALIzZ3kBWdrGKzKLSjBcqLY0ewm/HBirfrqwrDucGT4tQpUlVU7w9QnR1zvEanJSyFDe4Ocb4YH+UYQBxQInSrkAycsYj0QdU+HYnxGzw9fJ/LgHf1bKK4PpDfgn4/YNUecf9eh1qOfu/cRYdki6BkKZ4xcUB5zJHKyRk7fySbbkacn2vUx3kcSD/ux/ei3dOuzTxgTgrzb/GWRCy9fExVdfJdismwkRE7wvgpwUYtUsZxRLCtEXVEpGkWCfVOxKLQj9h7R5aWPGLyHziaeKtWe6IpgUYgMcPFv/ X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(376005)(82310400014)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2024 08:47:46.9403 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46b603f5-16fd-43eb-dc3c-08dc48ba6ab4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000A6733.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6539 Received-SPF: permerror client-ip=2a01:111:f403:2418::600; envelope-from=Michael.Roth@amd.com; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.422, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @amd.com) X-ZM-MESSAGEID: 1710924501064100003 Content-Type: text/plain; charset="utf-8" The machine done notify event is used for SEV guests to get the measurement of the encrypted images. When SEV-SNP is enabled, the measurement is part of the guest attestation process where it can be collected without any reliance on the VMM. So skip registering the notifier for SNP in favor of using guest attestation instead. Signed-off-by: Michael Roth --- target/i386/sev.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/target/i386/sev.c b/target/i386/sev.c index 774262d834..e4deb7b41e 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -989,9 +989,17 @@ static int sev_kvm_init(ConfidentialGuestSupport *cgs,= Error **errp) * own internal mechanisms for registering/pinning private memory. */ ram_block_notifier_add(&sev_ram_notifier); + + /* + * The machine done notify event is used for SEV guests to get the + * measurement of the encrypted images. When SEV-SNP is enabled, t= he + * measurement is part of the guest attestation process where it c= an + * be collected without any reliance on the VMM. So skip registeri= ng + * the notifier for SNP in favor of using guest attestation instea= d. + */ + qemu_add_machine_init_done_notifier(&sev_machine_done_notify); } =20 - qemu_add_machine_init_done_notifier(&sev_machine_done_notify); qemu_add_vm_change_state_handler(sev_vm_state_change, sev_common); =20 cgs->ready =3D true; --=20 2.25.1