From nobody Mon Feb 9 23:02:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1710857198; cv=none; d=zohomail.com; s=zohoarc; b=M/jER4+a2F6bWTckFojL6oDOGozuldeEdQu4bHKx23v0ph90LFmnzZwkXNz6kzeQl2uSe58+0s/piEfJiobE+wEyCYjXBV9Bh6qsz8AJC6OWtJKpJy5d7KjZYKE/ft7E5n4h6hu/R9t2hLeSuutdsvc766o7qd+DCsYusw+1C/Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710857198; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GeuJyXmk87ew7gCuQ5ySXtgH3p1fHidr/s3r/qeVRMI=; b=UkQrxcAVJF64ikKCTBYtD6xOUYE2YzQoY4XMOWxEKYT8Jy1UPmZbv3tVAuZ+mH1VH2/cUrYCgYgkB/mQ9gE/CEyAKwAfwtRRUP9dKcnqLKhqdR4QnlgEJkZb+tMJbcs2rCeTFLjaISrL72CYYTs9n+b0fIHAc33hfoFKJlGmM9g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710857198089204.98687488237897; Tue, 19 Mar 2024 07:06:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rma6E-0004Va-Un; Tue, 19 Mar 2024 10:05:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rma68-0004Pj-Tq for qemu-devel@nongnu.org; Tue, 19 Mar 2024 10:05:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rma67-0008Ng-FR for qemu-devel@nongnu.org; Tue, 19 Mar 2024 10:05:48 -0400 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-163-WGZLw505Okya4wVKHccKhg-1; Tue, 19 Mar 2024 10:05:42 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BAA041C04B5B; Tue, 19 Mar 2024 14:05:41 +0000 (UTC) Received: from corto.redhat.com (unknown [10.39.192.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id A4DBB3C21; Tue, 19 Mar 2024 14:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710857146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GeuJyXmk87ew7gCuQ5ySXtgH3p1fHidr/s3r/qeVRMI=; b=P/oc62qXbsaannbhCjIPESS40TPVjNrkCpKqv6MKPCI9gteUKRZNQSPk1h4mO1Tllnl+AA XXu3PfcJ6XCKa1Lb+96Mj1icNu997uVF1pkBcI1zCO6tKMpl9+MRjZ4OVWvNWLdZhL75oC AkgfKUhbPmXlYHZbl5R6x2BjybpQHf4= X-MC-Unique: WGZLw505Okya4wVKHccKhg-1 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Glenn Miles , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 2/3] ppc/pnv: I2C controller is not user creatable Date: Tue, 19 Mar 2024 15:05:15 +0100 Message-ID: <20240319140516.392542-3-clg@redhat.com> In-Reply-To: <20240319140516.392542-1-clg@redhat.com> References: <20240319140516.392542-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.422, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1710857200088100003 The I2C controller is a subunit of the processor. Make it so and avoid QEMU crashes. $ build/qemu-system-ppc64 -S -machine powernv9 -device pnv-i2c qemu-system-ppc64: ../hw/ppc/pnv_i2c.c:521: pnv_i2c_realize: Assertion `i= 2c->chip' failed. Aborted (core dumped) Fixes: 263b81ee15af ("ppc/pnv: Add an I2C controller model") Cc: Glenn Miles Reported-by: Thomas Huth Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Glenn Miles Signed-off-by: C=C3=A9dric Le Goater --- hw/ppc/pnv_i2c.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ppc/pnv_i2c.c b/hw/ppc/pnv_i2c.c index 4581cc5e5d4645ab3e358d983a633e33a214c425..eec5047ce83f842108b53a6e2bd= 9869a81f14ac1 100644 --- a/hw/ppc/pnv_i2c.c +++ b/hw/ppc/pnv_i2c.c @@ -557,6 +557,9 @@ static void pnv_i2c_class_init(ObjectClass *klass, void= *data) =20 xscomc->dt_xscom =3D pnv_i2c_dt_xscom; =20 + /* Reason: This device is part of the CPU and cannot be used separatel= y */ + dc->user_creatable =3D false; + dc->desc =3D "PowerNV I2C"; dc->realize =3D pnv_i2c_realize; device_class_set_props(dc, pnv_i2c_properties); --=20 2.44.0