From nobody Fri May 10 07:56:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710829777; cv=none; d=zohomail.com; s=zohoarc; b=Al4sLkKEu5SVUGn91hrPYL3nVYShBUWdkHZOKQZVSKM4zJnkk5Rcz/mx9N8DZtS3IsFiCbvyErfUxo2G1zQs/Khth2R80wHN4ErHbAhDz81cLdSQNVmr2tcGVWTf6dnl378FPZlENEo4pMwokLVR3qgjTujmH/s8lDS5LtqSAA4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710829777; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+Ob9p1550HNpZVGfZEzfCR7AGiyEKvTVPMJN9EmG2s0=; b=mkXQmIzSjvoDIfPy2/8VJawyEwBN/XoVTtJQslpvHj3byh640mrHIposqaGprBXlSD6aDRzggM5nkvwTH4EqtvEkHT0b2ZZ27jdJBMDMuw1dH1N1SmiEgUflehhq3gnI+u4S7rl0frJTqO6Ho4HyW0wOHtrkfODovW34Xq4LNcQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710829777920977.0886090674755; Mon, 18 Mar 2024 23:29:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmSyF-00053K-Pe; Tue, 19 Mar 2024 02:29:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmSyE-00052t-CZ for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:10 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmSy9-0005cE-LU for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:10 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-4146172fb7eso8502275e9.1 for ; Mon, 18 Mar 2024 23:29:05 -0700 (PDT) Received: from m1x-phil.lan ([176.176.166.129]) by smtp.gmail.com with ESMTPSA id fl25-20020a05600c0b9900b004140a3d34fasm8493344wmb.41.2024.03.18.23.29.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 18 Mar 2024 23:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710829744; x=1711434544; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+Ob9p1550HNpZVGfZEzfCR7AGiyEKvTVPMJN9EmG2s0=; b=vzDqpreD66K6NJnqr1M9le42pTHHgLvlcyNXh3pa++DyQZZFtSsHINXGd7Gp5TKSzS GhAcasSABzjEcCfzdOIOl/iT+af+D5tKVSiUnWCuzIW/odjMdZVZG/qhlIbs4Xhcb8Lx lGiy+B4BgazQaWE1X2EDKXq7C84Jp/o2lZihjEKHk8G6QFEcRLG7Fk7SAgHBXvmiig3M Qkj6syj+S/EpUtg1x89CFdemu9YpfZfUkydYvMBWyoFDehnR/bEaiXnA34wQ6XnvWdTG D30p79wgMq2ManseWAK7rT9REh3XK38u41674WAhcDEXt+VhXBrABaL1x0Ifbmjl+rhs 1MqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710829744; x=1711434544; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+Ob9p1550HNpZVGfZEzfCR7AGiyEKvTVPMJN9EmG2s0=; b=rp8geKI5vFWe7iqRJOu39AqQPahYjb1DpxIK7b0uvtSKmjxbMMBRF/eBq+WJpU/BLw Jn0KL/KRBxQDJ/C/eoC7gp3vdOfh3wDpubqPNSHIHYMTmzy+ebhF+v+nS0k2PhY3zMKr FrQDvb8vCMSf83JXmxVrTUCJ7tuZwwtU0oI/Ud5jXX9fLRqBEhRWbYOEf902uY6/rrU0 iqucnxh5sStqekTPqzRcgDF8kTGd0CK4COS0e7+/LiP+gUr/2QlOFgRvSv3CSqjBqFPE F1P0N1gXFHL2OvBIcT0CDvqxJHhxVgZRkhvrp43DvbREZmfRc7Ongy1haGdWYRQarcXq tstg== X-Gm-Message-State: AOJu0YxAupwdMKxJbvuGw1kocLah3bkLJordJJh/tNLbZa8Cb8Gel4Dz 1C9WZvfxERhwgA86hlZKviEdkDtWHsIBKgPPRGVK7d9pfjBuzhl2fy+jHN5dONHzrlMGtug3wBA U X-Google-Smtp-Source: AGHT+IEjnqEUlNURVey1aOE5055K+aMav+7H9x6mLZbfKzt6r/i54rrpymfDix6Jevsmh9WLAb+g9g== X-Received: by 2002:a05:600c:1914:b0:413:ff13:cd8e with SMTP id j20-20020a05600c191400b00413ff13cd8emr8004849wmq.5.1710829743802; Mon, 18 Mar 2024 23:29:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , "Edgar E. Iglesias" , Laurent Vivier , Anton Johansson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.1 1/8] target/microblaze: Use correct string format in do_unaligned_access() Date: Tue, 19 Mar 2024 07:28:48 +0100 Message-ID: <20240319062855.8025-2-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240319062855.8025-1-philmd@linaro.org> References: <20240319062855.8025-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710829779803100001 'addr' is of type 'vaddr'; no need to cast, use the corresponding format string. Fixes: ab0c8d0f5b ("target/microblaze: Use cc->do_unaligned_access") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Reviewed-by: Edgar E. Iglesias --- target/microblaze/helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/microblaze/helper.c b/target/microblaze/helper.c index d25c9eb4d3..0a12c4ea94 100644 --- a/target/microblaze/helper.c +++ b/target/microblaze/helper.c @@ -279,8 +279,8 @@ void mb_cpu_do_unaligned_access(CPUState *cs, vaddr add= r, iflags =3D cpu->env.iflags; =20 qemu_log_mask(CPU_LOG_INT, - "Unaligned access addr=3D" TARGET_FMT_lx " pc=3D%x iflag= s=3D%x\n", - (target_ulong)addr, cpu->env.pc, iflags); + "Unaligned access addr=3D0x%"VADDR_PRIx" pc=3D0x%x iflag= s=3D0x%x\n", + addr, cpu->env.pc, iflags); =20 esr =3D ESR_EC_UNALIGNED_DATA; if (likely(iflags & ESR_ESS_FLAG)) { --=20 2.41.0 From nobody Fri May 10 07:56:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710829872; cv=none; d=zohomail.com; s=zohoarc; b=jgYRpQDx67hupCUmBJTDLqXK+HGtq0Yjza0DoMuM50X2iWQdWC1YqmlWhnZi8k4NM77JUTPVkQIBbuZ5eh7TBiwCj7eaOrR7VdO8IRNKJpB97enYTnV2VLCIQkNTLCPKhgaKJACvJXp0rCcfPUjRyM4awgGC1OFc5x7ni/iZoc0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710829872; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fCgoP8SLDbVfo8JThgfHljHZ06CYNyRI0w/tkagv/vk=; b=kgqrKM8Xl2FNKUDc77d5RyKSL/42QQ1BDsU7W+TZE3hmUagRA4La6tmxJMJAK/sqnSJLz/kxYuH9/FqKBxps/CdPa3fqVz9W6B4aZssNNkLKzAf2RRcfUfBz54s8Hc4Rhi/HKNim7N0Qljx1L4kLVTAr/OMV84ibWDCORX/6edw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710829872180599.4846330106586; Mon, 18 Mar 2024 23:31:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmSyH-00053h-HJ; Tue, 19 Mar 2024 02:29:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmSyG-00053S-Jh for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:12 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmSyF-0005cc-4a for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:12 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-414676fe047so33825e9.2 for ; Mon, 18 Mar 2024 23:29:10 -0700 (PDT) Received: from m1x-phil.lan ([176.176.166.129]) by smtp.gmail.com with ESMTPSA id a26-20020a5d457a000000b0033e7e9c8657sm11509428wrc.45.2024.03.18.23.29.08 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 18 Mar 2024 23:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710829749; x=1711434549; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fCgoP8SLDbVfo8JThgfHljHZ06CYNyRI0w/tkagv/vk=; b=wUnKRgthxzgT02Sh3wX8JlB+5GL0xjfZLXYWbk2xjF/7ScZibTId4wZ9oGxV2I2yWv tyMOH047uFHB4+xPAx+kmrnXvyFyW2i+2EcTh/vlk/3NchIbAuKjDV4/seA0JwbokST5 2ymU6KXJa4FsWBH33fA6qvJJ2Qf99MReCv0YNPsE9SEps7NfOIVYJNREC18Mi4LfzDAD F9aEOtaaNhEP8akEAhMPanK7IpWOrW3xCPpQAanUMxRNrlFBTzB3gq1iKTFAZ99iTFD7 KA+Y6uGFMS7s2ndawmpUEX4U9BZ+3uo2JS35WayLq+d8BlF7nC5RWOeA/qMPxt6ep4HJ w4UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710829749; x=1711434549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fCgoP8SLDbVfo8JThgfHljHZ06CYNyRI0w/tkagv/vk=; b=VpGsNaEh6QcPbGyNrecr/eeJOh+UcnVkFNkOGkWUag5IfEjZthaYQcTbZVQ3QO4Z5R hqx4ZtXNc/U0vIKdyOL5bdsgM89NLBTu797X8e39NVDJog/eXuxHeqiszwpP5ZXkp43K UqgWXhyELnQ2dEYUL4OUME3CrJkNdW/udDHbrP7dX5BP+Ch03B9+guZ8o1nB6XwjoTWN SDoLWXmCXaieSeIh2LEfyO10V4LO7bSPLf7Jvv0SzxPi7Nb6HXV9Mb/pnMay015hfTg0 Bp2qztqV1fFe9NuDONpTbazlZfkQyFyBdLs/f7/uv1lM2eBzwsCmud28wxH7ljvivvYf I8tw== X-Gm-Message-State: AOJu0YwP9MEbNH9IUoYTjDHEtVbc9mzOEPGSkexHA6WTbMrYLg+E65Di stBbdeYA7Hv05jI3cMxeC+mym6QG1d1SDJxwJEOxQx2S1Xd2FzPteRiOOKxKVwk5sSjh/xgN3Xo 9 X-Google-Smtp-Source: AGHT+IH9yYR3wHc4A7BV0vTOaHo7L5x2ZMnwbyp5OrS/LN4HeNT8AR8GkI1oriDv1jpFspkfI4nXKg== X-Received: by 2002:a5d:4590:0:b0:33e:cf68:7345 with SMTP id p16-20020a5d4590000000b0033ecf687345mr8214247wrq.61.1710829749489; Mon, 18 Mar 2024 23:29:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , "Edgar E. Iglesias" , Laurent Vivier , Anton Johansson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.1 2/8] target/microblaze: Use hwaddr/vaddr in cpu_get_phys_page_attrs_debug() Date: Tue, 19 Mar 2024 07:28:49 +0100 Message-ID: <20240319062855.8025-3-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240319062855.8025-1-philmd@linaro.org> References: <20240319062855.8025-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710829873972100007 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Reviewed-by: Edgar E. Iglesias --- target/microblaze/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/microblaze/helper.c b/target/microblaze/helper.c index 0a12c4ea94..3f410fc7b5 100644 --- a/target/microblaze/helper.c +++ b/target/microblaze/helper.c @@ -228,7 +228,8 @@ hwaddr mb_cpu_get_phys_page_attrs_debug(CPUState *cs, v= addr addr, MemTxAttrs *attrs) { MicroBlazeCPU *cpu =3D MICROBLAZE_CPU(cs); - target_ulong vaddr, paddr =3D 0; + vaddr vaddr; + hwaddr paddr =3D 0; MicroBlazeMMULookup lu; int mmu_idx =3D cpu_mmu_index(cs, false); unsigned int hit; --=20 2.41.0 From nobody Fri May 10 07:56:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710829879; cv=none; d=zohomail.com; s=zohoarc; b=Pkvns2H8dm4VYs7E3Y0B7EkgExTvskAjyZGpwTknKF17C8M6/TesMVVtFe0bgMVzF2C9va04xD5jIKrKVAboB3q90IrxOUtJNVlauy4JIMXd2V+GuPoiWsvjNWi+GOFohZHf7krCK2p+Tzea+hqJhxVW2ekir1Cl2MhYmDz/xn4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710829879; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zLi8HPYzQKK0ulsJCWUrgKiQfFdRxTHI+3UszDXzaTk=; b=SSGy39wxpmrM1rvEN8TqIWw+fbzrroU/aVmCt51l7WiFwqvJrYuf7Kw2NIGoV9lo1reesUrlRUwKO3ysiTqQpdFqZItLxdCw9yXbsQc0rBSFuB7yZwUE7vAxpwOMSKmHmbJQtnjtuKyApzXDiYR2Ko7vNx1J2G33K6VQQTGzkzU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710829879354989.7571689562049; Mon, 18 Mar 2024 23:31:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmSyQ-00056k-5w; Tue, 19 Mar 2024 02:29:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmSyN-000540-Il for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:19 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmSyM-0005dC-6H for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:19 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-513e14b2bd9so3256018e87.2 for ; Mon, 18 Mar 2024 23:29:17 -0700 (PDT) Received: from m1x-phil.lan ([176.176.166.129]) by smtp.gmail.com with ESMTPSA id k3-20020adff5c3000000b0033e7eba040dsm11624669wrp.97.2024.03.18.23.29.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 18 Mar 2024 23:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710829755; x=1711434555; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zLi8HPYzQKK0ulsJCWUrgKiQfFdRxTHI+3UszDXzaTk=; b=oYEfSHzdZLrDQZlnB93SNcjUv1dBWlwx9Bg1DE1rosXuNVy9OT9Y024aZB3KSBTwqZ dxSh8lcy7xnJlyzLlcpS6vAM/17lRu/dGoraOalZVQ9dGAnV2F2YGxzirqsV8IDwxco3 cjh60n/rouRFfk9c3QTgLaeSs00svvfeP7IWKno1ApuW1Hn3S6Kl6v1Mz378MfOJmbQx sPvYl/swyCNq7ZHgHq1sj/1KAPxEB8c9/sowOxTCFuErJD1TjrD9Ja6pYsweoyj/n7wo 1aD7d05CUkAzxLBgWHAvQkdQx07Dt33y0ANtSoRfRbqtAQFAVAv1+ZeDZ4U0g06CaMpV YsPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710829755; x=1711434555; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zLi8HPYzQKK0ulsJCWUrgKiQfFdRxTHI+3UszDXzaTk=; b=Jb8pRa3Y6Gu7oq4synAy4/U0ba0z0ISx+H+0Ynu9MeYIHEi6anXGw0cLUNCS98YfCc mH76Zoe2ypbiCYYqHwcLuBlVlt8VmAXnSHICWi5gefziQHdpyRdnwy5v2DqWCthFr+iQ akak3WF5r0/IGVKgUhR0JGhmUS6GWHma8wuc2NL6butvGtXatmxL6EHBwlX8VSrYU7mb HzYMGDmNOr7lfCZpKEQI306tH+Zl1wsvwxMug7YxRZJWUMLBBywlHRDUVpv9q7qey99C I8Y+t6PwaUiXQSx2T4KluYNaB/FhpDlo1BQbhmkN5YaYVeKwXp3JkAeUWtR/wvC8TH4A T7OA== X-Gm-Message-State: AOJu0YyVHJYNL3Kq+IXwC4qrp8tGhCVv1damZnZEVaIAxubzndCM82L8 sjeAn/ltBTpP67k0nkCDBKmV63oWeSIPj+ONIbzdmmgtvkSrs0c59+sy9tkA9pkcCru53Wxk2jY o X-Google-Smtp-Source: AGHT+IH990QOXS0xm+rmL/RFHVv4DCA1J7clmAFB+CoDE2gDtWceUhfA0KWECfXWbhnAhWN8ZdSmWw== X-Received: by 2002:a19:8c4d:0:b0:513:cc24:c464 with SMTP id i13-20020a198c4d000000b00513cc24c464mr9866935lfj.15.1710829754972; Mon, 18 Mar 2024 23:29:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , "Edgar E. Iglesias" , Laurent Vivier , Anton Johansson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.1 3/8] target/microblaze: Widen vaddr in mmu_translate() Date: Tue, 19 Mar 2024 07:28:50 +0100 Message-ID: <20240319062855.8025-4-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240319062855.8025-1-philmd@linaro.org> References: <20240319062855.8025-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=philmd@linaro.org; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710829880037100005 Use 'vaddr' type for virtual addresses. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Reviewed-by: Edgar E. Iglesias --- target/microblaze/mmu.h | 2 +- target/microblaze/mmu.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/microblaze/mmu.h b/target/microblaze/mmu.h index 1068bd2d52..2aca39c923 100644 --- a/target/microblaze/mmu.h +++ b/target/microblaze/mmu.h @@ -86,7 +86,7 @@ typedef struct { } MicroBlazeMMULookup; =20 unsigned int mmu_translate(MicroBlazeCPU *cpu, MicroBlazeMMULookup *lu, - target_ulong vaddr, MMUAccessType rw, int mmu_i= dx); + vaddr vaddr, MMUAccessType rw, int mmu_idx); uint32_t mmu_read(CPUMBState *env, bool ea, uint32_t rn); void mmu_write(CPUMBState *env, bool ea, uint32_t rn, uint32_t v); void mmu_init(MicroBlazeMMU *mmu); diff --git a/target/microblaze/mmu.c b/target/microblaze/mmu.c index 234006634e..eb7c683020 100644 --- a/target/microblaze/mmu.c +++ b/target/microblaze/mmu.c @@ -75,7 +75,7 @@ static void mmu_change_pid(CPUMBState *env, unsigned int = newpid) =20 /* rw - 0 =3D read, 1 =3D write, 2 =3D fetch. */ unsigned int mmu_translate(MicroBlazeCPU *cpu, MicroBlazeMMULookup *lu, - target_ulong vaddr, MMUAccessType rw, int mmu_i= dx) + vaddr vaddr, MMUAccessType rw, int mmu_idx) { MicroBlazeMMU *mmu =3D &cpu->env.mmu; unsigned int i, hit =3D 0; --=20 2.41.0 From nobody Fri May 10 07:56:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710829784; cv=none; d=zohomail.com; s=zohoarc; b=VAf5bWbKMVXjfya9CURrspwajA+2hQi2EEYPagipme3Pvmw1VSTPFoV9CWVid41xUou8GZTpdmcFTQhHjUEF4sLhDGoYyS/D5FCFKsryuQfELU4t5BYw8hIvd0BvvaU5cPaqIpwiRQ7O2dQcnxPRHB9DpV7FUvf0lVNLXlqkfeU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710829784; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OUMu/SnjGuIrmF5U5VN8reZH7HV2LtE5n6DxI3xZ0h0=; b=HRC7khNEdeoSRaoXDAJbESt8dFR0l+ILdE3vm20XRJLzaWx6maTuOuAln692hhvyob1K2nWSBQuagJEmBRVBVKksPqFFVxRiKBMrbxPyZQC5AjoXD+iifEPKnQR3hYbRXwAQsn+zOmkfK7pHulg1mJCbVoSyzWYuQrJQ4QeAGNg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710829784982594.3405141861097; Mon, 18 Mar 2024 23:29:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmSyW-000596-Et; Tue, 19 Mar 2024 02:29:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmSyU-00058R-7N for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:26 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmSyQ-0005dh-MC for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:25 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-41461c256c4so5249425e9.0 for ; Mon, 18 Mar 2024 23:29:22 -0700 (PDT) Received: from m1x-phil.lan ([176.176.166.129]) by smtp.gmail.com with ESMTPSA id t6-20020a05600c450600b004133365bbc6sm20189118wmo.19.2024.03.18.23.29.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 18 Mar 2024 23:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710829760; x=1711434560; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OUMu/SnjGuIrmF5U5VN8reZH7HV2LtE5n6DxI3xZ0h0=; b=plwc0dqHA3AAP69WtK89dB9Fxl5671UXEgvyOfgBFEuM0sSHjjO6kydLN/MTb7/a/X 0ir43r0E7gUd1AE7+rb8cykUPLCD2uFq3Osqtt8MDpy7pUOb7EbV6KRXR8MlsIpcVlq0 X4k87UCgvJUf1xMhudJDZ/kuK9UuAIV7UnBYPkt3nA9aUiH0FfVl92B3hSjf3c6Gp5+H VfFnW+b6nUfbKCQu3YVv9xXCp1WtM2gOUfYSCdcMTQ+Ut+wkW1T2M3cT0MbHtqPRcwok U+NONCg1rZS0QtFk2alGozJV599qc/Dsx+eHv2+apNM9DcJ7gCbMQ71SC0lyHXo7oWA8 NlHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710829760; x=1711434560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OUMu/SnjGuIrmF5U5VN8reZH7HV2LtE5n6DxI3xZ0h0=; b=nJ2Cxc3UT3ABm8JAqQiy7636BR4ikjJGJ71BpJorZVsjhKo6htWxvIodDfKtzAdKYl peoeTqMcZEqHXCcFT+BGQvMcT+FkRTWT290OC25lvNCfxuUj9kxitGAZtnkVczcf+BxF Y9ZIZdSXgIfDzxSnEidZW19QEiVKpLF1msmF82khYL347Zext9QkD4jTcBoiU76017xZ ZGcxhGbBPoGCZNANZNfEh1FfBWBvHB+6HxuiMUqf1y/QssUa5xyN1tJPEICoeX8Qtrid Upb5Yrh8WPLDhcVMCYJw28DcUS/GMgj4s+EQ0XVXXOpHwNG4UOUJuK3Uu3lzieMGmkCm s92w== X-Gm-Message-State: AOJu0YxkaPKkX0mU5Jna9y42nTpyPVFS0cjkJr+nTh3pdhLFGCH0KkNI wJYMidIS5cA+zyKS/oBjWuD/+h5YUXcgcGO+cXquvxqX1cAcFm7PdBXSmpyfzs8Hp/KTO9m0Moc A X-Google-Smtp-Source: AGHT+IHP//CRIEiNinf9+UhocTaax5slUcGi81qSrKwN1DEZtshK6yksOSk63XTSyfk7Dol9GWtjlA== X-Received: by 2002:a05:600c:5494:b0:414:624c:aaf with SMTP id iv20-20020a05600c549400b00414624c0aafmr866477wmb.35.1710829760636; Mon, 18 Mar 2024 23:29:20 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , "Edgar E. Iglesias" , Laurent Vivier , Anton Johansson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.1 4/8] target/microblaze: Use 32-bit destination in gen_goto_tb() Date: Tue, 19 Mar 2024 07:28:51 +0100 Message-ID: <20240319062855.8025-5-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240319062855.8025-1-philmd@linaro.org> References: <20240319062855.8025-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710829785713100001 cpu_pc and jmp_dest are 32-bit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Reviewed-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 4e52ef32db..d6a42381bb 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -121,7 +121,7 @@ static void gen_raise_hw_excp(DisasContext *dc, uint32_= t esr_ec) gen_raise_exception_sync(dc, EXCP_HW_EXCP); } =20 -static void gen_goto_tb(DisasContext *dc, int n, target_ulong dest) +static void gen_goto_tb(DisasContext *dc, int n, uint32_t dest) { if (translator_use_goto_tb(&dc->base, dest)) { tcg_gen_goto_tb(n); --=20 2.41.0 From nobody Fri May 10 07:56:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710829883; cv=none; d=zohomail.com; s=zohoarc; b=Yc40fxnNXxGSk77DVjYyd1y0JdpTInCh0YG8sC/OXEdMUFK01qHxjAYmvUFXLH5ocLi9AI7lQlEDXFT8Zc3rMp1R4YxLDC7HU4cYhTFBB4j8EC7BkN2MKY13vPjH42JvR3m4mMCB+L73pBa75r5Ig5uf+AoSOgG/AiMrNWhZvuc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710829883; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=n1MPot1rwOH2sHZ4KnXL6/xrTAyUEmTpRKdgwXMTPjQ=; b=mexcT0og5kVR7z0jO/m0mXsMXK8+cGwnmVjuZXF6szd7iU8Qhg7b2HY03vvwZf59otC0I4alqy8BwZ19lNZOxn51qYI0GdqX5MSKk2sIVbaAWE1Epr+w2C5uZXbE+7ew7aaE5qUnuwIOuheuakI/KnvVsGFNwr6mHXvCi4nYs48= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710829883116113.51783011599434; Mon, 18 Mar 2024 23:31:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmSya-0005Dx-QN; Tue, 19 Mar 2024 02:29:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmSyY-00059B-HL for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:30 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmSyW-0005e9-U0 for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:30 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-414618e6820so5819905e9.0 for ; Mon, 18 Mar 2024 23:29:27 -0700 (PDT) Received: from m1x-phil.lan ([176.176.166.129]) by smtp.gmail.com with ESMTPSA id j17-20020a05600c191100b00414659ba8c2sm650763wmq.37.2024.03.18.23.29.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 18 Mar 2024 23:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710829766; x=1711434566; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n1MPot1rwOH2sHZ4KnXL6/xrTAyUEmTpRKdgwXMTPjQ=; b=owwEE06FNiM1zIBP72Rs2G0t0/gN4g4bRK+GvvWAg29woDcH9ua4qOphaS5MSdsSIR 7NVr8JuTTX3OcH9CGZ/1kSCC2ZLbYjQZHfX4gCAKF2kRP+2thVlIQac/KS1KFvdiTxHj T/6Lodr+CUvICEtcDaQ1zUiT6fZNVnQsTK8D++3fUAg1s23CoMklEGChN1wO02fXsj4/ XKyTS0x3h0gmFWoBm6xm/n04cz2HrU2F6MWtQgmgcZGzQnpcjbT0otRRLxKtTkI04soR ZNlOfIwQ5I6CHVKX8x2BQenvYfLA4Hz8k3oK6IGfdutunUeZpBYfoMSI8lXmixIaDUhW GI5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710829766; x=1711434566; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n1MPot1rwOH2sHZ4KnXL6/xrTAyUEmTpRKdgwXMTPjQ=; b=sO6HR+30Ln0h6q74QSYiPGE+GbnGzDFAhbZUhiMnoWd8tJ5KuFdJqIX6mHL8bW41J+ 5N/XhV1sYUFAtHrDGLp17lJt8en4vJFaoqh1t6jsL0mSmOGSFFaNkyjKl9Ka4SRcTzLe Q+XY0kbakOMUhuqyNvpsa+BFcpZGGpVEqI6zhXUpr5hKcEPZDsqpcZXWQfHny3AcmlXp qj2B0LHjkJ8+ZZZKGqBqUo4vQEQ1t/X4Ayn0hJc6IjaXpsz0c4uBRClm72qHh+RtIrN4 DpqLcJzK/bS/7BFZGmTar+AEmH1NIBCLtpiqvxKKrhRlJRO8asGN6W4xQUeMq4p2esjS QpyQ== X-Gm-Message-State: AOJu0Ywi07YiGDvodmwsPzY1q5WSqlDCshMHQr8MawEakEejmwDlnn9Q f5ADzF3ujxZLxOsoChiVdJIrAOseAtpKXhFYMdOxdW7KtRr/c0adZS7Jo3/JmSq/c1NrsJU9xZK e X-Google-Smtp-Source: AGHT+IGyFHLXXW0HyzGyYV1/M1fhBfxn2ypbm2zCFU9F3y9AQOSSlXYYFkseD3Hg8quM0HV4dPJMAA== X-Received: by 2002:a05:600c:4fc8:b0:414:6172:8366 with SMTP id o8-20020a05600c4fc800b0041461728366mr1300185wmq.15.1710829766185; Mon, 18 Mar 2024 23:29:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , "Edgar E. Iglesias" , Laurent Vivier , Anton Johansson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.1 5/8] target/microblaze: Restrict 64-bit 'res_addr' to system emulation Date: Tue, 19 Mar 2024 07:28:52 +0100 Message-ID: <20240319062855.8025-6-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240319062855.8025-1-philmd@linaro.org> References: <20240319062855.8025-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710829883986100013 'res_addr' is only used in system emulation, where we have TARGET_LONG_BITS =3D 64, so we can directly use the native uint64_t type instead of target_ulong. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson --- target/microblaze/cpu.h | 10 +++++----- target/microblaze/cpu.c | 2 ++ target/microblaze/machine.c | 2 +- target/microblaze/translate.c | 9 +++++++-- 4 files changed, 15 insertions(+), 8 deletions(-) diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index c0c7574dbd..c3e2aba0ec 100644 --- a/target/microblaze/cpu.h +++ b/target/microblaze/cpu.h @@ -260,11 +260,6 @@ struct CPUArchState { /* Stack protectors. Yes, it's a hw feature. */ uint32_t slr, shr; =20 - /* lwx/swx reserved address */ -#define RES_ADDR_NONE 0xffffffff /* Use 0xffffffff to indicate no reservat= ion */ - target_ulong res_addr; - uint32_t res_val; - /* Internal flags. */ #define IMM_FLAG (1 << 0) #define BIMM_FLAG (1 << 1) @@ -286,6 +281,11 @@ struct CPUArchState { uint32_t iflags; =20 #if !defined(CONFIG_USER_ONLY) + /* lwx/swx reserved address */ +#define RES_ADDR_NONE 0xffffffff /* Use 0xffffffff to indicate no reservat= ion */ + uint64_t res_addr; + uint32_t res_val; + /* Unified MMU. */ MicroBlazeMMU mmu; #endif diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 96c2b71f7f..9e393cf217 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze/cpu.c @@ -193,7 +193,9 @@ static void mb_cpu_reset_hold(Object *obj) } =20 memset(env, 0, offsetof(CPUMBState, end_reset_fields)); +#ifndef CONFIG_USER_ONLY env->res_addr =3D RES_ADDR_NONE; +#endif =20 /* Disable stack protector. */ env->shr =3D ~0; diff --git a/target/microblaze/machine.c b/target/microblaze/machine.c index 51705e4f5c..4daf8a2471 100644 --- a/target/microblaze/machine.c +++ b/target/microblaze/machine.c @@ -78,7 +78,7 @@ static const VMStateField vmstate_env_fields[] =3D { VMSTATE_UINT32(iflags, CPUMBState), =20 VMSTATE_UINT32(res_val, CPUMBState), - VMSTATE_UINTTL(res_addr, CPUMBState), + VMSTATE_UINT64(res_addr, CPUMBState), =20 VMSTATE_STRUCT(mmu, CPUMBState, 0, vmstate_mmu, MicroBlazeMMU), =20 diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index d6a42381bb..493850c544 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1872,7 +1872,9 @@ void mb_tcg_init(void) SP(iflags), SP(bvalue), SP(btarget), +#if !defined(CONFIG_USER_ONLY) SP(res_val), +#endif }; =20 #undef R @@ -1883,6 +1885,9 @@ void mb_tcg_init(void) tcg_global_mem_new_i32(tcg_env, i32s[i].ofs, i32s[i].name); } =20 - cpu_res_addr =3D - tcg_global_mem_new(tcg_env, offsetof(CPUMBState, res_addr), "res_a= ddr"); +#if !defined(CONFIG_USER_ONLY) + cpu_res_addr =3D tcg_global_mem_new_i64(tcg_env, + offsetof(CPUMBState, res_addr), + "res_addr"); +#endif } --=20 2.41.0 From nobody Fri May 10 07:56:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710829853; cv=none; d=zohomail.com; s=zohoarc; b=HL22v1h0K0OXB7VtwjFCY0Lbxo4m5pGXm52173vgORlefx8DTqp1cZkqnbspvlg3BDh2RolVUWBBfX225H6n/0BgHYbWk17S7gzEPTnuDDfk8zDaG7NQeHj3HE11TFRyPW5oqB4knHcajzjkgSV3H+AyYuRtLiHpWwFINfIHSmU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710829853; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jaSTDZWCvnDQFHGWaMWeelLWgiRSqaaIXlBIS7H4n9A=; b=UVsvCVlnxuNCYUM/mPncgLXZSTOqa/dHW26J02V6qi0gu5ohuMin8TrIBe72qlLuVjdGo8Afy+LsAjnuS2VwqoFb5fz7P0ZecPv5xqTKAKnFlmFQyWgs/TbgiCd4k10fmk50RW9WFWwda1X0chswtDPG7Jq/vTkKDJhPxYgZHn4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710829853806516.465403967629; Mon, 18 Mar 2024 23:30:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmSyk-0005Yh-IK; Tue, 19 Mar 2024 02:29:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmSye-0005Lb-Bo for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:37 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmSyb-0005ea-Lx for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:36 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-41461c256c4so5250185e9.0 for ; Mon, 18 Mar 2024 23:29:33 -0700 (PDT) Received: from m1x-phil.lan ([176.176.166.129]) by smtp.gmail.com with ESMTPSA id bw28-20020a0560001f9c00b003418364032asm1933168wrb.112.2024.03.18.23.29.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 18 Mar 2024 23:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710829772; x=1711434572; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jaSTDZWCvnDQFHGWaMWeelLWgiRSqaaIXlBIS7H4n9A=; b=heLJNLTVIkvO4B3F7/mDF8jdEk0hazqFz3rTaMhKKxf4SlX4XCC/i/JoSaDCKwOJyA LDQzE0LJJExZeFNVxHNxXmqvBowtQA+L3h5dTKC0y3Nsc3DysqIOQa9CmVAXNywhXSMo yPhUGoSp7HPtB3HGYS8cpDUx0gYIoc3AcvJZmGYa77zP5FSr1WQR7r4O6JnTVin87CQM COuq51VESAm8PaA8VPKltrbprNDGJy4O60xtvW0yf1ZPGhjjI1apYT2frYjygdVIEWCy uo68xaIRryvBL6WxCWDA3aqPlSALSrZ/lxUMNuX/wN4fK1ScnAZ4z5F1APiZYdj2tHzM Ii0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710829772; x=1711434572; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jaSTDZWCvnDQFHGWaMWeelLWgiRSqaaIXlBIS7H4n9A=; b=TCpa8E9YhVk2fIlZ8FpNJ087GtciaJQMmqHFHGGxb2I7XgEJ3Jr1yM8wztbCmh6eIG FboPQT1m1pFuiVZ2H7miIlu9loCpu+uU41/ayf4en6+oD8sqTCMDh4r8zFOME90l+LJQ LXzhuZgdIt+JFh1juHmxdFa4YJi/hgcg+loqb1uaRnPOCF1BZfLsVxK8acZ0XpUaqoS1 q7SGN4gotxY5oo4OcBR3iUwmnu6vpEmsdN9Jns0hjkCRKv3D3ZFpuWN6sd2OU3DKemS8 zCls2sbBvEI5lHQ0xIKU7dt0e5OuJGR76/P3GQScz5zgpRPKefusWwWqXPrYk5nnXiyW qrhQ== X-Gm-Message-State: AOJu0YxJD2R3gsIXmu4IWMxjQ5Ny71EuQAZc/pyR7+7DATMvuY1zWQ8p 0RyCzNhvYA8jVoWQw+F5B+9RwgTcv2O9gmqIHoAZgIrj+TM2DfauAYcOGGEp333392dQlfBQ6mj 7 X-Google-Smtp-Source: AGHT+IHjYWZSLPC41rGSe/+3IByzDksAKUwsz+iLZr3iscOG8H5/z+G8wbNHPGjXWH1a4YJjaV4YWQ== X-Received: by 2002:adf:e392:0:b0:33d:746b:f360 with SMTP id e18-20020adfe392000000b0033d746bf360mr939268wrm.51.1710829771832; Mon, 18 Mar 2024 23:29:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , "Edgar E. Iglesias" , Laurent Vivier , Anton Johansson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.1 6/8] target/microblaze: Rename helper.c -> sys_helper.c Date: Tue, 19 Mar 2024 07:28:53 +0100 Message-ID: <20240319062855.8025-7-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240319062855.8025-1-philmd@linaro.org> References: <20240319062855.8025-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710829855931100003 helper.c only contains system emulation helpers, rename it as sys_helper.c. Adapt meson and remove pointless #ifdef'ry. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Reviewed-by: Edgar E. Iglesias --- target/microblaze/{helper.c =3D> sys_helper.c} | 5 +---- target/microblaze/meson.build | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) rename target/microblaze/{helper.c =3D> sys_helper.c} (99%) diff --git a/target/microblaze/helper.c b/target/microblaze/sys_helper.c similarity index 99% rename from target/microblaze/helper.c rename to target/microblaze/sys_helper.c index 3f410fc7b5..5180500354 100644 --- a/target/microblaze/helper.c +++ b/target/microblaze/sys_helper.c @@ -1,5 +1,5 @@ /* - * MicroBlaze helper routines. + * MicroBlaze system helper routines. * * Copyright (c) 2009 Edgar E. Iglesias * Copyright (c) 2009-2012 PetaLogix Qld Pty Ltd. @@ -24,7 +24,6 @@ #include "qemu/host-utils.h" #include "exec/log.h" =20 -#ifndef CONFIG_USER_ONLY static bool mb_cpu_access_is_secure(MicroBlazeCPU *cpu, MMUAccessType access_type) { @@ -266,8 +265,6 @@ bool mb_cpu_exec_interrupt(CPUState *cs, int interrupt_= request) return false; } =20 -#endif /* !CONFIG_USER_ONLY */ - void mb_cpu_do_unaligned_access(CPUState *cs, vaddr addr, MMUAccessType access_type, int mmu_idx, uintptr_t retaddr) diff --git a/target/microblaze/meson.build b/target/microblaze/meson.build index 3ed4fbb67a..013ea542be 100644 --- a/target/microblaze/meson.build +++ b/target/microblaze/meson.build @@ -5,7 +5,6 @@ microblaze_ss.add(gen) microblaze_ss.add(files( 'cpu.c', 'gdbstub.c', - 'helper.c', 'op_helper.c', 'translate.c', )) @@ -14,6 +13,7 @@ microblaze_system_ss =3D ss.source_set() microblaze_system_ss.add(files( 'mmu.c', 'machine.c', + 'sys_helper.c', )) =20 target_arch +=3D {'microblaze': microblaze_ss} --=20 2.41.0 From nobody Fri May 10 07:56:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710829831; cv=none; d=zohomail.com; s=zohoarc; b=GwojYn5tt1SwOx3EjVsMbVzrV0KMqICRPR3izMzYVLvMfn6TknHhzldFInuEcRTS0qQopqNsBa/JoacS2NHam2Gx0vEkIKTV5flF6j+AE7c3SUw7VVVTXXxW7j32cagjy6L0qct7AU+c60b/w6BWOgrQ1bHrKLe5k0D23DHHoRc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710829831; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qcBm1WCPymqKaSwa7fzwzI3+ewkz+Zw4jwIqPMQqMRg=; b=HlDi39fOhcy8smTI6a58rz+s7WbNJOIjqhswVjdQItRLarL+RwOrNoNWvto+gQ1t61EpK/OeaV1+pr7KyW1P9VC+xtEtCXPBA2ba0CKtkz9NVUb/5zfHiJ4Nn7j+zax3R8v2RTdKksn6/GrBJ0QB1RpSi54xk9Z1djZOULO83kk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710829831432990.1434840428692; Mon, 18 Mar 2024 23:30:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmSyy-0006X0-SU; Tue, 19 Mar 2024 02:29:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmSyw-0006Mp-TT for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:54 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmSyh-0005gL-Ib for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:54 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-41461c256c4so5250535e9.0 for ; Mon, 18 Mar 2024 23:29:38 -0700 (PDT) Received: from m1x-phil.lan ([176.176.166.129]) by smtp.gmail.com with ESMTPSA id y4-20020a5d4704000000b0033e7603987dsm11513647wrq.12.2024.03.18.23.29.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 18 Mar 2024 23:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710829777; x=1711434577; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qcBm1WCPymqKaSwa7fzwzI3+ewkz+Zw4jwIqPMQqMRg=; b=W7OcNObLAT1qv5oSj4Lvp4rPID97WylZ1KXmKJOGcK21H13v9FkkMLH4gllWemOenr U1f9BKLEIAf7bO0gynpf/CsJH/tk7nf0CuNmSSi/3XLm1VZyGwmA+lrFQ4VkJpAK4IhG dJTkVKqNFE0O6lyXM1XJHCtSuBgtj1Sz30fTdxUQJU224hIGck4rHGFaIOpQHqKMJRmC 98MKHE4b3YF6EXi6ArKBv8wKsiD2ixOmNT/VZiGqDmgg43rPvnE/kdEZhmu81dXVjqFB 20DuOE5DshAsAJVBaEWeiQSbp9ksmK5341O9bqBfFIEkahJnoYGy5Bb/XWiCUXHlwX4z Gb/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710829777; x=1711434577; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qcBm1WCPymqKaSwa7fzwzI3+ewkz+Zw4jwIqPMQqMRg=; b=W6Ih8otiw/ZUHW97AD8iH75W/Zt4RFtbBue+aCaeJtYEaq0sekRZJLHnD72Ci4S/VG 4wO6f21Gi1xUBmD+xysXIIP55H8yJCf4VSBW/52CFYqEjpqQ6ruPvoqJFDB+Ant68Xz0 TYMcGRiMM/AO0iSQn4ambWC9HXM6UXojWukB7oB3BPfqetcD8XyQ57mIU/C++ga47cMm Enq0GzQNQjV7FeDeHntOcHFyjsCxiHB3V98izQ5O5AXWAUeIvGJuJTCQwPs29igPiL2w swd8If0VmXyanPewolZwKYaYohXdvW4nNRNZiUGIYG9N9EUmnRVEitU7dKqD/XMtHTJZ iI4w== X-Gm-Message-State: AOJu0Yy4gxZF7VCTePEUFHBuTPyru/337ubFk7YmT8I7lg6r95I1Q7ig ur5Dehqbrzkw3FHav9gr1mcn5zJT7X+vhuSyXDPcAtKUdnKYs8AW3TflCcPbtZa1XjWSngWGKFF w X-Google-Smtp-Source: AGHT+IFA9Pc4RYrnUJoxJSw4zZvp9hFZUiqVU/oZX3Uj7ejQzCg1KvulmHGK9Q04q0jvZnFtdSmFXg== X-Received: by 2002:a5d:4112:0:b0:33e:48f9:169d with SMTP id l18-20020a5d4112000000b0033e48f9169dmr944178wrp.31.1710829777460; Mon, 18 Mar 2024 23:29:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , "Edgar E. Iglesias" , Laurent Vivier , Anton Johansson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.1 7/8] target/microblaze: Move MMU helpers to sys_helper.c Date: Tue, 19 Mar 2024 07:28:54 +0100 Message-ID: <20240319062855.8025-8-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240319062855.8025-1-philmd@linaro.org> References: <20240319062855.8025-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710829831862100001 MMU helpers are only used during system emulation, move them to sys_helper.c. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Reviewed-by: Edgar E. Iglesias --- target/microblaze/op_helper.c | 48 ---------------------------------- target/microblaze/sys_helper.c | 47 +++++++++++++++++++++++++++++++++ 2 files changed, 47 insertions(+), 48 deletions(-) diff --git a/target/microblaze/op_helper.c b/target/microblaze/op_helper.c index f6378030b7..45dbed4aaa 100644 --- a/target/microblaze/op_helper.c +++ b/target/microblaze/op_helper.c @@ -381,51 +381,3 @@ void helper_stackprot(CPUMBState *env, target_ulong ad= dr) cpu_loop_exit_restore(cs, GETPC()); } } - -#if !defined(CONFIG_USER_ONLY) -/* Writes/reads to the MMU's special regs end up here. */ -uint32_t helper_mmu_read(CPUMBState *env, uint32_t ext, uint32_t rn) -{ - return mmu_read(env, ext, rn); -} - -void helper_mmu_write(CPUMBState *env, uint32_t ext, uint32_t rn, uint32_t= v) -{ - mmu_write(env, ext, rn, v); -} - -void mb_cpu_transaction_failed(CPUState *cs, hwaddr physaddr, vaddr addr, - unsigned size, MMUAccessType access_type, - int mmu_idx, MemTxAttrs attrs, - MemTxResult response, uintptr_t retaddr) -{ - MicroBlazeCPU *cpu =3D MICROBLAZE_CPU(cs); - CPUMBState *env =3D &cpu->env; - - qemu_log_mask(CPU_LOG_INT, "Transaction failed: vaddr 0x%" VADDR_PRIx - " physaddr 0x" HWADDR_FMT_plx " size %d access type %s\n= ", - addr, physaddr, size, - access_type =3D=3D MMU_INST_FETCH ? "INST_FETCH" : - (access_type =3D=3D MMU_DATA_LOAD ? "DATA_LOAD" : "DATA_= STORE")); - - if (!(env->msr & MSR_EE)) { - return; - } - - if (access_type =3D=3D MMU_INST_FETCH) { - if (!cpu->cfg.iopb_bus_exception) { - return; - } - env->esr =3D ESR_EC_INSN_BUS; - } else { - if (!cpu->cfg.dopb_bus_exception) { - return; - } - env->esr =3D ESR_EC_DATA_BUS; - } - - env->ear =3D addr; - cs->exception_index =3D EXCP_HW_EXCP; - cpu_loop_exit_restore(cs, retaddr); -} -#endif diff --git a/target/microblaze/sys_helper.c b/target/microblaze/sys_helper.c index 5180500354..7531f95ca7 100644 --- a/target/microblaze/sys_helper.c +++ b/target/microblaze/sys_helper.c @@ -21,6 +21,7 @@ #include "qemu/osdep.h" #include "cpu.h" #include "exec/exec-all.h" +#include "exec/helper-proto.h" #include "qemu/host-utils.h" #include "exec/log.h" =20 @@ -292,3 +293,49 @@ void mb_cpu_do_unaligned_access(CPUState *cs, vaddr ad= dr, cs->exception_index =3D EXCP_HW_EXCP; cpu_loop_exit(cs); } + +/* Writes/reads to the MMU's special regs end up here. */ +uint32_t helper_mmu_read(CPUMBState *env, uint32_t ext, uint32_t rn) +{ + return mmu_read(env, ext, rn); +} + +void helper_mmu_write(CPUMBState *env, uint32_t ext, uint32_t rn, uint32_t= v) +{ + mmu_write(env, ext, rn, v); +} + +void mb_cpu_transaction_failed(CPUState *cs, hwaddr physaddr, vaddr addr, + unsigned size, MMUAccessType access_type, + int mmu_idx, MemTxAttrs attrs, + MemTxResult response, uintptr_t retaddr) +{ + MicroBlazeCPU *cpu =3D MICROBLAZE_CPU(cs); + CPUMBState *env =3D &cpu->env; + + qemu_log_mask(CPU_LOG_INT, "Transaction failed: vaddr 0x%" VADDR_PRIx + " physaddr 0x" HWADDR_FMT_plx " size %d access type %s\n= ", + addr, physaddr, size, + access_type =3D=3D MMU_INST_FETCH ? "INST_FETCH" : + (access_type =3D=3D MMU_DATA_LOAD ? "DATA_LOAD" : "DATA_= STORE")); + + if (!(env->msr & MSR_EE)) { + return; + } + + if (access_type =3D=3D MMU_INST_FETCH) { + if (!cpu->cfg.iopb_bus_exception) { + return; + } + env->esr =3D ESR_EC_INSN_BUS; + } else { + if (!cpu->cfg.dopb_bus_exception) { + return; + } + env->esr =3D ESR_EC_DATA_BUS; + } + + env->ear =3D addr; + cs->exception_index =3D EXCP_HW_EXCP; + cpu_loop_exit_restore(cs, retaddr); +} --=20 2.41.0 From nobody Fri May 10 07:56:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1710829871; cv=none; d=zohomail.com; s=zohoarc; b=lo8e4mmypl4G65jGq6PkIXcf3zm+tjq5i/gFv+Uu7YBcOJd+ccyJFK6ouiP90R6E1qMmojDAmWtHD364WhSOATjj4B55uX4E0vfGQUNSj0HuEw/amOFJnmVBGLgfEKZbCV5spKzfREfm4fuItQUj9douSJqpmGoD9lZZnzMiTtU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710829871; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ioEuKggDYI9Ff6Tz/WlVRONFn4WVhfyxodNulYLHoYg=; b=CG26swjgxsmkSPUTAEeBtCdOsKlo01P6dXbRrdWh46vamFJj0mBxV1S2ZvPPHMJHZr38EKgXTeSzdknZu7nDhygnm/zvmRmr9gPRix8DP4+gWd9FFPXPbwrmLTaApxceM3rbEjRtiiAU43M1sGrntYK9u//e4/9Uc0IlshK9z9c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710829871268852.6526181579418; Mon, 18 Mar 2024 23:31:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rmSyq-00068l-Oo; Tue, 19 Mar 2024 02:29:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rmSyp-00064e-KI for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:47 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rmSym-0005ge-S2 for qemu-devel@nongnu.org; Tue, 19 Mar 2024 02:29:47 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-41409fd8b6bso18479615e9.1 for ; Mon, 18 Mar 2024 23:29:44 -0700 (PDT) Received: from m1x-phil.lan ([176.176.166.129]) by smtp.gmail.com with ESMTPSA id f1-20020a5d4dc1000000b0033e99b7cfa8sm6353382wru.13.2024.03.18.23.29.41 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 18 Mar 2024 23:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710829783; x=1711434583; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ioEuKggDYI9Ff6Tz/WlVRONFn4WVhfyxodNulYLHoYg=; b=u4b51JvOpgJlLelLd4XOlSrmP5nBL1RaoQru3+FWnFkSrEJvPe1qqeiK877AmBaGxk +qpzfx3ftWuy7XKPLjPN8sIJvbLl6sZKIT9fuaWw2UmdajIla13XyAdhzGiMbz/n8MoM pF6vhIbO7cviT3aHqy+5ttrKzXsxk12cRkPCIcv3oBHTcPjujtphZwvG7Txeb1lvxu42 QJN/LvnkVSP8XZD9lqkZ+Vgz3FLJPdPeMxeubhLJAgorrc1hlO4UnmVP1TZfzgs61cJR 1lmRp3z5Jg5p4QHUcPvMUecFAR/7Gy3efrhTK2cPIY/q73y/0GhDEfCI2PH+D2nt3w99 b4sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710829783; x=1711434583; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ioEuKggDYI9Ff6Tz/WlVRONFn4WVhfyxodNulYLHoYg=; b=rlCb94kcSs6/WIE3sU4VdasBtT0HOjV0lZAmN/fTlXs4lsg0YYs6pFyArpvTNoAv1+ i2w1UT1UYR0pecrKWzuYKIiOJ5PY/GjPf5aLmchOkgyHeAYmy1qEdcZSUMa8tZj4zT61 n/FZ1cHbUnYnINhVRBar6Kx2TPfs6Cl6OCbM22Mha+J8xrYyEL/IsaQOyycylo7ugSO3 PpqlnSa9NfnoOhEqosDlrfBrLXddo34T5jJhnr5SbKyRcCORt8zy4yPoumAkw7SoCq4a msChcOlbAGQ3svNkCF36yDYiPnK1jd37QX7Kaz59YRWlPk61beKtMOEGi5pGfKudlST1 fpTA== X-Gm-Message-State: AOJu0Yze7Bzg0uVEASc19zAV3WJ+PovdY8IkRYz/ImZDteKh21IgqflB ro+K1tqd4hMORFh5jceRdnGpzz3/TlAvT/ouZLJ0IRLy7z70dGWjx406xpOkh+ICGLPOAy7zJRw O X-Google-Smtp-Source: AGHT+IFt0w/yQtP/92+2ssXuMyzs5I8HpsPU6alFwtMOYeIkHHdmAGPOeY5ZUSgYaI005s5ciyZzEA== X-Received: by 2002:a5d:6803:0:b0:33d:fb3:9021 with SMTP id w3-20020a5d6803000000b0033d0fb39021mr8936257wru.54.1710829783095; Mon, 18 Mar 2024 23:29:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , "Edgar E. Iglesias" , Laurent Vivier , Anton Johansson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH-for-9.1 8/8] target/microblaze: Widen $ear to 64-bit Date: Tue, 19 Mar 2024 07:28:55 +0100 Message-ID: <20240319062855.8025-9-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240319062855.8025-1-philmd@linaro.org> References: <20240319062855.8025-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1710829871965100001 The Exception Address Register is 64-bit wide. User emulation only access the 32 lower bits. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Anton Johansson Reviewed-by: Edgar E. Iglesias --- target/microblaze/cpu.h | 2 +- linux-user/elfload.c | 2 +- target/microblaze/gdbstub.c | 2 +- target/microblaze/translate.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/microblaze/cpu.h b/target/microblaze/cpu.h index c3e2aba0ec..a9f93b37b7 100644 --- a/target/microblaze/cpu.h +++ b/target/microblaze/cpu.h @@ -251,7 +251,7 @@ struct CPUArchState { uint32_t pc; uint32_t msr; /* All bits of MSR except MSR[C] and MSR[CC] */ uint32_t msr_c; /* MSR[C], in low bit; other bits must be 0 */ - target_ulong ear; + uint64_t ear; uint32_t esr; uint32_t fsr; uint32_t btr; diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 60cf55b36c..4612aef95a 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1498,7 +1498,7 @@ static void elf_core_copy_regs(target_elf_gregset_t *= regs, const CPUMBState *env (*regs)[pos++] =3D tswapreg(env->pc); (*regs)[pos++] =3D tswapreg(mb_cpu_read_msr(env)); (*regs)[pos++] =3D 0; - (*regs)[pos++] =3D tswapreg(env->ear); + (*regs)[pos++] =3D tswapreg((uint32_t)env->ear); (*regs)[pos++] =3D 0; (*regs)[pos++] =3D tswapreg(env->esr); } diff --git a/target/microblaze/gdbstub.c b/target/microblaze/gdbstub.c index 09d74e164d..147d20c3e4 100644 --- a/target/microblaze/gdbstub.c +++ b/target/microblaze/gdbstub.c @@ -63,7 +63,7 @@ int mb_cpu_gdb_read_register(CPUState *cs, GByteArray *me= m_buf, int n) val =3D mb_cpu_read_msr(env); break; case GDB_EAR: - val =3D env->ear; + val =3D (uint32_t)env->ear; break; case GDB_ESR: val =3D env->esr; diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 493850c544..19b180501f 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1835,7 +1835,7 @@ void mb_cpu_dump_state(CPUState *cs, FILE *f, int fla= gs) } =20 qemu_fprintf(f, "\nesr=3D0x%04x fsr=3D0x%02x btr=3D0x%08x edr=3D0x%x\n" - "ear=3D0x" TARGET_FMT_lx " slr=3D0x%x shr=3D0x%x\n", + "ear=3D0x%" PRIx64 " slr=3D0x%x shr=3D0x%x\n", env->esr, env->fsr, env->btr, env->edr, env->ear, env->slr, env->shr); =20 --=20 2.41.0