From nobody Sat Feb 7 08:58:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1710439169; cv=none; d=zohomail.com; s=zohoarc; b=V9yd1uTo1pBhxYcUZqbW8CpmK2hJ/Zk4wVhp1A/2+a83hh59tVIEjcpxvZA/phgabLKxn1jXBvs49t0SbLULwl1gvENwGkFn9sD9jrCFK2ApuNNV8uIJrvPp6sS0Cl95lCJVVizfFpbl/mXlBy6Yz/IlH+ypMsCV9KnrOCakM5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710439169; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IYSTwBGPj/oxmbTdp2L/GD1aYwJzZ4jHQBeRBe8DJNg=; b=exuk9V7SB3BiYls2AQiBxL5CxRNrdK8bOZQ60K5yI/pmyM1V5PchuNRW153hmk4+vuJCBjtDQrlUGB1IKv2s8ZQurANf1LzFkd2V9NlQi4CJ3jgt/kGZyfitjE2C77b9Bvbmq/GCvT92SKFcu1pWAh+CORDQjhf0FMx023xLWDI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710439169476567.4724912514897; Thu, 14 Mar 2024 10:59:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkpL3-0005dr-Gq; Thu, 14 Mar 2024 13:57:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkpKn-0005Wd-U4 for qemu-devel@nongnu.org; Thu, 14 Mar 2024 13:57:43 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkpKl-0005aL-Qt for qemu-devel@nongnu.org; Thu, 14 Mar 2024 13:57:41 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1dddb160a37so9320765ad.2 for ; Thu, 14 Mar 2024 10:57:39 -0700 (PDT) Received: from grind.dc1.ventanamicro.com ([177.94.15.159]) by smtp.gmail.com with ESMTPSA id i7-20020a170902c94700b001db717d2dbbsm1991776pla.210.2024.03.14.10.57.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 10:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1710439058; x=1711043858; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IYSTwBGPj/oxmbTdp2L/GD1aYwJzZ4jHQBeRBe8DJNg=; b=HrQR4gpqQvuRfghwFjuRbMebkzUJ9FGOYzoSNo8zkCK+bBdyCxss8Es7iLsCeqGfeq WRDUgNwuh2xE0gV4PqDw8KWKy0BqL0OH2ZSAELzEYvTZqrG2zUwueqUUW96QwlOFd4IQ TmB0fV+OJRc0ZrC7f+n6kOK3kMhQ5PtkTlvsB7M/oISniRiqaH8tOkbqfrYoKrW6MFLu EoG2GFnGIZQlbufK9ivLZtUpcUHkM+tduzEMarR7l47OFr5mNXqP0IOs7WxHLzK6zAMe vhLcLYoN29r/qeeZbU328uQ5LUkY+JonVoiHK5G0Fv5IhLfq023hLYu7uvxbyff3LEkx S+Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710439058; x=1711043858; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IYSTwBGPj/oxmbTdp2L/GD1aYwJzZ4jHQBeRBe8DJNg=; b=iqdqRqK08SyepXgosGh2XkL8XLcUb46VOA4UtWzm20YjDxOECtRQ4iydoRNEwSE+au weeAaAUOM1shIKa2mtzJZBAutWA2HGhTrcRXx9FK+1JJ/LJFtiWMVieAs++hmGkaxSE0 nHPN2jgIdpPrrV9yv3/uSttniYFI9UsysQSegREpBW+DAR1PwNVwLwsR+usCjCdwwi6u 7AdHYYBmYkYcA2dUcW3C4bZSWghFwmcgCje2yy6Af7csCbdvDOrP/DvsdZdL7sYkKrSC b2nhdiuaXtauL1ApQRHOZUNm+uxf/nF4OUgW67pJtar3LujUDprSlo0wS6NTvt/AIn9M YTpA== X-Gm-Message-State: AOJu0YyS5aRrgSlIxi3XcLYdv5X4s/F9UmTDeKgI645d/kOHUYd04uWf sPoZRkSp+bXT7g8wxE10Mw0tVC+MaLRmVhUWKJVIj8D3aWUYJ+C0QJ4mAzIIcZP1ily9MVZHwEe t X-Google-Smtp-Source: AGHT+IFfFUXOaLLvbBLvgv9ud3b45x+IOG+jgvWp5JqdpgfXLnrF4tCg985vTkLqh675VXGuwbUYJw== X-Received: by 2002:a17:902:e811:b0:1db:fa72:25eb with SMTP id u17-20020a170902e81100b001dbfa7225ebmr3489094plg.52.1710439057858; Thu, 14 Mar 2024 10:57:37 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, bmeng@tinylab.org, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@rivosinc.com, max.chou@sifive.com, richard.henderson@linaro.org, Daniel Henrique Barboza , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH for 9.0 v15 08/10] trans_rvv.c.inc: remove redundant mark_vs_dirty() calls Date: Thu, 14 Mar 2024 14:57:02 -0300 Message-ID: <20240314175704.478276-9-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240314175704.478276-1-dbarboza@ventanamicro.com> References: <20240314175704.478276-1-dbarboza@ventanamicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=dbarboza@ventanamicro.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ventanamicro.com) X-ZM-MESSAGEID: 1710439171141100003 trans_vmv_v_i , trans_vfmv_v_f and the trans_##NAME macro from GEN_VMV_WHOLE_TRANS() are calling mark_vs_dirty() in both branches of their 'ifs'. conditionals. Call it just once in the end like other functions are doing. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/riscv/insn_trans/trans_rvv.c.inc | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_tr= ans/trans_rvv.c.inc index 7931fb2f3f..401ee939b8 100644 --- a/target/riscv/insn_trans/trans_rvv.c.inc +++ b/target/riscv/insn_trans/trans_rvv.c.inc @@ -2065,7 +2065,6 @@ static bool trans_vmv_v_i(DisasContext *s, arg_vmv_v_= i *a) if (s->vl_eq_vlmax && !(s->vta && s->lmul < 0)) { tcg_gen_gvec_dup_imm(s->sew, vreg_ofs(s, a->rd), MAXSZ(s), MAXSZ(s), simm); - mark_vs_dirty(s); } else { TCGv_i32 desc; TCGv_i64 s1; @@ -2083,9 +2082,8 @@ static bool trans_vmv_v_i(DisasContext *s, arg_vmv_v_= i *a) s->cfg_ptr->vlenb, data)); tcg_gen_addi_ptr(dest, tcg_env, vreg_ofs(s, a->rd)); fns[s->sew](dest, s1, tcg_env, desc); - - mark_vs_dirty(s); } + mark_vs_dirty(s); return true; } return false; @@ -2612,7 +2610,6 @@ static bool trans_vfmv_v_f(DisasContext *s, arg_vfmv_= v_f *a) =20 tcg_gen_gvec_dup_i64(s->sew, vreg_ofs(s, a->rd), MAXSZ(s), MAXSZ(s), t1); - mark_vs_dirty(s); } else { TCGv_ptr dest; TCGv_i32 desc; @@ -2635,9 +2632,8 @@ static bool trans_vfmv_v_f(DisasContext *s, arg_vfmv_= v_f *a) tcg_gen_addi_ptr(dest, tcg_env, vreg_ofs(s, a->rd)); =20 fns[s->sew - 1](dest, t1, tcg_env, desc); - - mark_vs_dirty(s); } + mark_vs_dirty(s); return true; } return false; @@ -3560,12 +3556,11 @@ static bool trans_##NAME(DisasContext *s, arg_##NAM= E * a) \ if (s->vstart_eq_zero) { \ tcg_gen_gvec_mov(s->sew, vreg_ofs(s, a->rd), \ vreg_ofs(s, a->rs2), maxsz, maxsz); \ - mark_vs_dirty(s); \ } else { \ tcg_gen_gvec_2_ptr(vreg_ofs(s, a->rd), vreg_ofs(s, a->rs2), \ tcg_env, maxsz, maxsz, 0, gen_helper_vmvr_v= ); \ - mark_vs_dirty(s); \ } \ + mark_vs_dirty(s); \ return true; \ } \ return false; \ --=20 2.44.0