From nobody Sat May 11 15:40:09 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1710319836; cv=none; d=zohomail.com; s=zohoarc; b=mw0D4sbDGjZn/TDBxTBR5VGG5SiiDVvjNMGOLCy40EZYxqSPm+KghAthlrdI0HXM65l3MzTxZ0VTPyAh4IRSsVuL7UEicbO1f2INpXoNRc592/kzemLIFH8S+FGgUp0PEKIkxFVWsLPeW0USOxFXZbYLQ7OgbkmVuwtTCE8TBBo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710319836; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nak0yr6B3kWAnErxNK2rR0lCio2XzH+ueyZd9XmZcIQ=; b=DUvU1hI1dhQN2sCTqnF8yAoxJqwE4h1NBpbBArxyQ5c5yQhfMkYg1H4Omdmlxadui0r/jSebe/c01yHphPbLDzx7OO35C7ky7iWYtJdddJFZNpUkkuEBc03J9eaj+Wny9COnAKpFwzodVR3tYvGpstq/NlryZZA93tdKOayrPkc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1710319836219778.9588387071072; Wed, 13 Mar 2024 01:50:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkKJF-0002n7-GX; Wed, 13 Mar 2024 04:50:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkKJ3-0002jE-I3 for qemu-devel@nongnu.org; Wed, 13 Mar 2024 04:49:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkKJ1-0000DA-KW for qemu-devel@nongnu.org; Wed, 13 Mar 2024 04:49:49 -0400 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-u_PmLlb_O_6gG8VO9zmm9w-1; Wed, 13 Mar 2024 04:49:44 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DBC04380228B; Wed, 13 Mar 2024 08:49:43 +0000 (UTC) Received: from kaapi.redhat.com (unknown [10.67.24.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C63F7492BC6; Wed, 13 Mar 2024 08:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710319785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=nak0yr6B3kWAnErxNK2rR0lCio2XzH+ueyZd9XmZcIQ=; b=aaB8EWS5+mdu1YmNQ2fR9F8aQB6dzGMbJQZuLvdkKrYcDgS8/kIkhZ+NpfGvfr9Sd1MjBR N41ySPWxDdw3CLyVB4ZHXsBda4A8nQgNtHF4gdAjEstOIi4CdW26IgYVukKyH61yJ7Ms22 wnrFkiuRTu73Xzg6eup3bgumv5VdIvQ= X-MC-Unique: u_PmLlb_O_6gG8VO9zmm9w-1 From: Prasad Pandit To: stefanha@redhat.com Cc: kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, mtosatti@redhat.com, Prasad Pandit Subject: [PATCH v3] linux-aio: add IO_CMD_FDSYNC command support Date: Wed, 13 Mar 2024 14:19:35 +0530 Message-ID: <20240313084935.1412274-1-ppandit@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=ppandit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.687, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1710319836751100001 Content-Type: text/plain; charset="utf-8" From: Prasad Pandit Libaio defines IO_CMD_FDSYNC command to sync all outstanding asynchronous I/O operations, by flushing out file data to the disk storage. Enable linux-aio to submit such aio request. This helps to reduce latency induced via pthread_create calls by thread-pool (aio=3Dthreads). Signed-off-by: Prasad Pandit --- block/file-posix.c | 7 +++++++ block/linux-aio.c | 22 +++++++++++++++++++++- 2 files changed, 28 insertions(+), 1 deletion(-) v3: check if host kernel supports aio_fsync call -> https://lists.nongnu.org/archive/html/qemu-devel/2024-03/msg03210.html diff --git a/block/file-posix.c b/block/file-posix.c index 35684f7e21..a30494d1a8 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -2453,6 +2453,8 @@ static inline bool raw_check_linux_io_uring(BDRVRawSt= ate *s) #endif =20 #ifdef CONFIG_LINUX_AIO +extern bool laio_has_fdsync(int); + static inline bool raw_check_linux_aio(BDRVRawState *s) { Error *local_err =3D NULL; @@ -2599,6 +2601,11 @@ static int coroutine_fn raw_co_flush_to_disk(BlockDr= iverState *bs) if (raw_check_linux_io_uring(s)) { return luring_co_submit(bs, s->fd, 0, NULL, QEMU_AIO_FLUSH); } +#endif +#ifdef CONFIG_LINUX_AIO + if (raw_check_linux_aio(s) && laio_has_fdsync(s->fd)) { + return laio_co_submit(s->fd, 0, NULL, QEMU_AIO_FLUSH, 0); + } #endif return raw_thread_pool_submit(handle_aiocb_flush, &acb); } diff --git a/block/linux-aio.c b/block/linux-aio.c index ec05d946f3..ed20a503e9 100644 --- a/block/linux-aio.c +++ b/block/linux-aio.c @@ -67,6 +67,7 @@ struct LinuxAioState { int event_max; }; =20 +bool laio_has_fdsync(int); static void ioq_submit(LinuxAioState *s); =20 static inline ssize_t io_event_ret(struct io_event *ev) @@ -384,6 +385,9 @@ static int laio_do_submit(int fd, struct qemu_laiocb *l= aiocb, off_t offset, case QEMU_AIO_READ: io_prep_preadv(iocbs, fd, qiov->iov, qiov->niov, offset); break; + case QEMU_AIO_FLUSH: + io_prep_fdsync(iocbs, fd); + break; /* Currently Linux kernel does not support other operations */ default: fprintf(stderr, "%s: invalid AIO request type 0x%x.\n", @@ -412,7 +416,7 @@ int coroutine_fn laio_co_submit(int fd, uint64_t offset= , QEMUIOVector *qiov, AioContext *ctx =3D qemu_get_current_aio_context(); struct qemu_laiocb laiocb =3D { .co =3D qemu_coroutine_self(), - .nbytes =3D qiov->size, + .nbytes =3D qiov ? qiov->size : 0, .ctx =3D aio_get_linux_aio(ctx), .ret =3D -EINPROGRESS, .is_read =3D (type =3D=3D QEMU_AIO_READ), @@ -486,3 +490,19 @@ void laio_cleanup(LinuxAioState *s) } g_free(s); } + +bool laio_has_fdsync(int fd) +{ + struct iocb cb; + struct iocb *cbs[] =3D {&cb, NULL}; + + io_context_t ctx =3D 0; + io_setup(1, &ctx); + + /* check if host kernel supports IO_CMD_FDSYNC */ + io_prep_fdsync(&cb, fd); + int ret =3D io_submit(ctx, 1, cbs); + + io_destroy(ctx); + return (ret =3D=3D -EINVAL) ? false : true; +} --=20 2.44.0