From nobody Tue Nov 26 04:46:20 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1710252908; cv=none; d=zohomail.com; s=zohoarc; b=O8lgTz62WozRoG350Fji16wG3piSHjEduvwr714HjI1z4nsUA378rZw/HyBkpsJ2NOEQLUqGOImsTLc1Gr4odf9qlWY9CkNf/V5/eFTUHMAQvXru+Cmqwu8e0sKqc7yFPa1e+CfvY36fESCKVp4TrvcRKN+ByfSQ/vkVTP1jlL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710252908; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hYHFCmgJJWnJymuPOM0Fiymm9aw+gWR/Ejg103QqNto=; b=eakRTcBVwL3B9eVw03RdDvxqq4pRlzrKauJ78SjYmhAZjAdiWgo5U0SLWjBRNfWpxb7Wzk8ZnH+2w48iuHCMTTv2Au8osujFstoJMZ6nhDfDoAx2tHgnlRtERJubQQ3VDVJmNy66uoF82p6ldc4HKUV5FVdjM4Z3J0PBehYxUuI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 171025290822558.65875823592114; Tue, 12 Mar 2024 07:15:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rk2tw-0001GF-KL; Tue, 12 Mar 2024 10:14:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rk2tK-0000fE-6b for qemu-devel@nongnu.org; Tue, 12 Mar 2024 10:14:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rk2t6-0002Bn-3u for qemu-devel@nongnu.org; Tue, 12 Mar 2024 10:14:05 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-363-XI1gPPs_O9OCQJEbt6DXQw-1; Tue, 12 Mar 2024 10:13:46 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BE451100DE81; Tue, 12 Mar 2024 14:13:45 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99E133C85; Tue, 12 Mar 2024 14:13:45 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3E68021E68B2; Tue, 12 Mar 2024 15:13:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710252831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hYHFCmgJJWnJymuPOM0Fiymm9aw+gWR/Ejg103QqNto=; b=Fm2Hvbvrv3Bm/jizPgXwZ98Xdofsm6Owb5i1a+j+8WZdcjxl4IJ4JTY/7K1ozhAAAglW92 yKP73+xupxV/TkavapJ58Wa241oMb6EQE/2iCX4aJmhn0o+rFvvqRR68/ygqNqCSOwNEzs o6B5nu1oaao90P02LAaKnStpaOrYJNQ= X-MC-Unique: XI1gPPs_O9OCQJEbt6DXQw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-block@nongnu.org, philmd@linaro.org, Juan Quintela Subject: [PATCH 08/10] qapi: Correct error message for 'vcpu_dirty_limit' parameter Date: Tue, 12 Mar 2024 15:13:41 +0100 Message-ID: <20240312141343.3168265-9-armbru@redhat.com> In-Reply-To: <20240312141343.3168265-1-armbru@redhat.com> References: <20240312141343.3168265-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.687, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1710252909732100003 From: Philippe Mathieu-Daud=C3=A9 QERR_INVALID_PARAMETER_VALUE is defined as: #define QERR_INVALID_PARAMETER_VALUE \ "Parameter '%s' expects %s" The current error is formatted as: "Parameter 'vcpu_dirty_limit' expects is invalid, it must greater then 1 = MB/s" Replace by: "Parameter 'vcpu_dirty_limit' is invalid, it must greater than 1 MB/s" Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Juan Quintela Signed-off-by: Markus Armbruster Reviewed-by: Zhao Liu --- migration/options.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/migration/options.c b/migration/options.c index 40eb930940..c5115f1b5c 100644 --- a/migration/options.c +++ b/migration/options.c @@ -1264,9 +1264,8 @@ bool migrate_params_check(MigrationParameters *params= , Error **errp) =20 if (params->has_vcpu_dirty_limit && (params->vcpu_dirty_limit < 1)) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, - "vcpu_dirty_limit", - "is invalid, it must greater then 1 MB/s"); + error_setg(errp, "Parameter 'vcpu_dirty_limit' is invalid," + " it must greater than 1 MB/s"); return false; } =20 --=20 2.44.0