From nobody Tue Nov 26 04:19:37 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1710145639; cv=none; d=zohomail.com; s=zohoarc; b=QfabiZi/4/0ATXZ5cRBJaPJ1vxu1vfQqF0fuNCOJtd3ZdUCcGNWYxpDXe5Qm2FnNlIdJZcCV+hTUk1rMWyNxoJMGXCiClOxpnJGyVDBVghr6UkW3xGlml+SdyOFjWX43Pv0GVUJV7AjaW6MQeqxx1OKNPcPJEV/G9NKplSyEG+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1710145639; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jPTNsNYlyuoCf/nljvZGZg2h6owx+osOv81jUJ76EfM=; b=n8N96v3jWo+pcL72Wt59Rp8zLZw0bv7O55sx+x/5JMD0f/DY0udQnlLjcIx2INasSkAfaF8dKuAwvivQZDAT0z04rMUCGB5BzrLGuUZ5pLbNM5n72O65rR47RwmZm+OmhDIjpbzyzHRr77Q8D5S3nDAm3WrYvPuGTTGBmqf1FN0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 171014563929863.833842444235074; Mon, 11 Mar 2024 01:27:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjazn-0002Jf-K9; Mon, 11 Mar 2024 04:26:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjazj-0002JF-3z for qemu-devel@nongnu.org; Mon, 11 Mar 2024 04:26:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjazV-0008JJ-Ru for qemu-devel@nongnu.org; Mon, 11 Mar 2024 04:26:50 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-iXJJu7lFPcWepVpUbfL69w-1; Mon, 11 Mar 2024 04:26:35 -0400 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a45ac612a4dso532721366b.0 for ; Mon, 11 Mar 2024 01:26:35 -0700 (PDT) Received: from [192.168.10.118] ([151.49.77.21]) by smtp.gmail.com with ESMTPSA id mm5-20020a170906cc4500b00a3d11feb32esm2635201ejb.186.2024.03.11.01.26.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 01:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710145597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jPTNsNYlyuoCf/nljvZGZg2h6owx+osOv81jUJ76EfM=; b=WrnajpoOICYYKm97VZVZyT8Cv+sRHVhJnlFWoQUMeIGv6k+uv9s82scZhLsjO635Q6LYsk xTFgyLjF2w8n34S50rOWBT8cribJnUho1u6DTfdkDkRpiyYtvZaSf3X2q58NoQGoaxJrgj dnk0fBj7uwaOrDMRB43ztXi8XS7Bzkw= X-MC-Unique: iXJJu7lFPcWepVpUbfL69w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710145594; x=1710750394; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jPTNsNYlyuoCf/nljvZGZg2h6owx+osOv81jUJ76EfM=; b=CVjFL3RwJryY346LeD/T2jPwT8bIjY/DitkTgqm/rz2Imurg441v5HHQ+Ix+i//7OH rFC/dD+O4evY9nsqLitgFzM1QmlkgYpeV+kQEf0Fsf8XbizgMcPeYp6P6UN0UX2c7sBW AVa6oDg7klOvOZnMngkWH+Se9vRcFPrxhOmKvH6LhXEYeCuyR7x/UcdX82vC2q8WLvjc KKLtbSE9V1XxT66zJa0Fz9x2TyccUg7/BqnFClU7Kq+DQ0xngEhFeoSMxs/xNETdvx5f Z5UhnSdzDLv0ZYQ7GvVhjBOJnp/bMl/PWloYT2UYqV3hRhIxBaVi1MawGp2q1m1E2wAQ lGMA== X-Gm-Message-State: AOJu0Yzg3AImaIvmeosqha9JRWR0Xgp3uec9uWHNqhGsmBkw96lHGddC UykZqC4H+Z1oQrzWhlPNAqh2LsZF9KBCKuP5kgiai780Rna/KS4S33xJViZ/G/qCGcUxEf8/jqb 2GGG8ZWsw5PhgvXDoDJppyj+XsmOkUnt6qsHRI2EZr/v85wndNQt3dRIMJx5vkIeQHnSPmzQwv9 Zcz4GxUy6WQXuasbvbiCmFN0SJN/sH4uXN8aIW X-Received: by 2002:a17:907:6d0e:b0:a46:2e1c:2a6f with SMTP id sa14-20020a1709076d0e00b00a462e1c2a6fmr1378682ejc.2.1710145593969; Mon, 11 Mar 2024 01:26:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFMON1WTLCytqCh/hpBNuQ5jbRhIo0rQjPGv80ymxuy6X5g/+8OTqBKwAjokAKnmFRjzmWAGA== X-Received: by 2002:a17:907:6d0e:b0:a46:2e1c:2a6f with SMTP id sa14-20020a1709076d0e00b00a462e1c2a6fmr1378669ejc.2.1710145593590; Mon, 11 Mar 2024 01:26:33 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH] tcg/aarch64: fix assertion failure on TSTxx of UINT32_MAX Date: Mon, 11 Mar 2024 09:26:32 +0100 Message-ID: <20240311082632.671163-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.945, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1710145641154100003 These are translated to CBZ and CBNZ instructions, and the code generation = part of tcg_out_brcond checks that c is one of TCG_COND_EQ or TCG_COND_NE. Fixes: 34aff3c2e06 ("tcg/aarch64: Generate CBNZ for TSTNE of UINT32_MAX", 2= 024-02-03) Cc: Philippe Mathieu-Daud=C3=A9 Cc: Richard Henderson Signed-off-by: Paolo Bonzini --- tcg/aarch64/tcg-target.c.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/tcg/aarch64/tcg-target.c.inc b/tcg/aarch64/tcg-target.c.inc index dec8ecc1b65..6ed174bd172 100644 --- a/tcg/aarch64/tcg-target.c.inc +++ b/tcg/aarch64/tcg-target.c.inc @@ -1465,6 +1465,7 @@ static void tcg_out_brcond(TCGContext *s, TCGType ext= , TCGCond c, TCGArg a, case TCG_COND_TSTNE: /* tst xN,0xffffffff; b.ne L -> cbnz wN,L */ if (b_const && b =3D=3D UINT32_MAX) { + c =3D (c =3D=3D TCG_COND_TSTEQ ? TCG_COND_EQ : TCG_COND_NE); ext =3D TCG_TYPE_I32; need_cmp =3D false; break; --=20 2.43.2