From nobody Mon Feb 9 08:11:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1709825916; cv=none; d=zohomail.com; s=zohoarc; b=fJCEswEFSgoY4uUExmMb4Z4Khx8QBQYMFopwQ39v0N4ABexeo9UBfJp347M3vIYk5n4zbJDZWWXINYu+Z8navEVBg86KO/iE5Vr52M1qfPSqYRHBxW0grkX4XD5ssqaRWk6y+M4Wwf78sQf3diUyUJkg2hULXKrQFELXnBZlqp8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1709825916; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=moHLI4z1p6XAA6rPXmiVmAbuiC9UqZ41CAmdgAXJ0XI=; b=ncC8klvJ7x6BxN3H76/7r34NqQBmYTUMr+agn9+wqUbebKTz82+bhpJtuJchVIxBfFmjP4jkArewLcqJtwU85BBGjiEqaMPGSFTiJIFosG2ofjFBTcL7d65SO8B3twoPbn8z9c/m6MtJWCLqohJpBexTE3OS6VRVZrFW1mpD2aw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1709825916272205.23964093809707; Thu, 7 Mar 2024 07:38:36 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1riFp0-0002GF-EN; Thu, 07 Mar 2024 10:38:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1riFoz-0002Dq-G1 for qemu-devel@nongnu.org; Thu, 07 Mar 2024 10:38:13 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1riFox-0001kP-F6 for qemu-devel@nongnu.org; Thu, 07 Mar 2024 10:38:13 -0500 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4TrD3227kmz6D8dd; Thu, 7 Mar 2024 23:38:06 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 9C809140736; Thu, 7 Mar 2024 23:38:09 +0800 (CST) Received: from SecurePC-101-06.china.huawei.com (10.122.247.231) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 7 Mar 2024 15:38:09 +0000 To: Paolo Bonzini , Peter Xu , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , CC: Subject: [PATCH v2 2/4] physmem: Reduce local variable scope in flatview_read/write_continue() Date: Thu, 7 Mar 2024 15:37:08 +0000 Message-ID: <20240307153710.30907-3-Jonathan.Cameron@huawei.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240307153710.30907-1-Jonathan.Cameron@huawei.com> References: <20240307153710.30907-1-Jonathan.Cameron@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.122.247.231] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1709825917395100003 Content-Type: text/plain; charset="utf-8" Precursor to factoring out the inner loops for reuse. Reviewed-by: Peter Xu Signed-off-by: Jonathan Cameron Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- v2: Picked up tag from Peter. system/physmem.c | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/system/physmem.c b/system/physmem.c index 2704b780f6..a64a96a3e5 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -2688,10 +2688,7 @@ static MemTxResult flatview_write_continue(FlatView = *fv, hwaddr addr, hwaddr len, hwaddr mr_addr, hwaddr l, MemoryRegion *mr) { - uint8_t *ram_ptr; - uint64_t val; MemTxResult result =3D MEMTX_OK; - bool release_lock =3D false; const uint8_t *buf =3D ptr; =20 for (;;) { @@ -2699,7 +2696,9 @@ static MemTxResult flatview_write_continue(FlatView *= fv, hwaddr addr, result |=3D MEMTX_ACCESS_ERROR; /* Keep going. */ } else if (!memory_access_is_direct(mr, true)) { - release_lock |=3D prepare_mmio_access(mr); + uint64_t val; + bool release_lock =3D prepare_mmio_access(mr); + l =3D memory_access_size(mr, l, mr_addr); /* XXX: could force current_cpu to NULL to avoid potential bugs */ @@ -2717,18 +2716,21 @@ static MemTxResult flatview_write_continue(FlatView= *fv, hwaddr addr, val =3D ldn_he_p(buf, l); result |=3D memory_region_dispatch_write(mr, mr_addr, val, size_memop(l), attrs); + if (release_lock) { + bql_unlock(); + } + + } else { /* RAM case */ - ram_ptr =3D qemu_ram_ptr_length(mr->ram_block, mr_addr, &l, fa= lse); + + uint8_t *ram_ptr =3D qemu_ram_ptr_length(mr->ram_block, mr_add= r, &l, + false); + memmove(ram_ptr, buf, l); invalidate_and_set_dirty(mr, mr_addr, l); } =20 - if (release_lock) { - bql_unlock(); - release_lock =3D false; - } - len -=3D l; buf +=3D l; addr +=3D l; @@ -2767,10 +2769,7 @@ MemTxResult flatview_read_continue(FlatView *fv, hwa= ddr addr, hwaddr len, hwaddr mr_addr, hwaddr l, MemoryRegion *mr) { - uint8_t *ram_ptr; - uint64_t val; MemTxResult result =3D MEMTX_OK; - bool release_lock =3D false; uint8_t *buf =3D ptr; =20 fuzz_dma_read_cb(addr, len, mr); @@ -2780,7 +2779,9 @@ MemTxResult flatview_read_continue(FlatView *fv, hwad= dr addr, /* Keep going. */ } else if (!memory_access_is_direct(mr, false)) { /* I/O case */ - release_lock |=3D prepare_mmio_access(mr); + uint64_t val; + bool release_lock =3D prepare_mmio_access(mr); + l =3D memory_access_size(mr, l, mr_addr); result |=3D memory_region_dispatch_read(mr, mr_addr, &val, size_memop(l), attrs); @@ -2796,17 +2797,16 @@ MemTxResult flatview_read_continue(FlatView *fv, hw= addr addr, (l =3D=3D 8 && len >=3D 8)); #endif stn_he_p(buf, l, val); + if (release_lock) { + bql_unlock(); + } } else { /* RAM case */ - ram_ptr =3D qemu_ram_ptr_length(mr->ram_block, mr_addr, &l, fa= lse); + uint8_t *ram_ptr =3D qemu_ram_ptr_length(mr->ram_block, mr_add= r, &l, + false); memcpy(buf, ram_ptr, l); } =20 - if (release_lock) { - bql_unlock(); - release_lock =3D false; - } - len -=3D l; buf +=3D l; addr +=3D l; --=20 2.39.2