From nobody Tue Nov 26 08:44:02 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1709549135; cv=none; d=zohomail.com; s=zohoarc; b=Eeega+sjCHJ7D1L5mUBZdX7Lbr9SrsdDZGo6khFbZBk0h9kJhmGQM7M9xxZw+NmfH/Aw62K9xvpBM+QEsWOw7FX2nG2UWi7Ick9oP0IFMfHpnzdWDRT3bbsslQzkE6DU5C9H1J+iNGj/VSoW+8ySRSJcLqwTSTLG191hWWSffOg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1709549135; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=njyBLCIS4gewEjmYCVl3Zq3Lwp00j5JPg6RIx/fhaRY=; b=ObFoyhHQ5/8vOFPWB1Q6E4N77dmOofudzn4SB0VNoB1iRssVTMGimx1J0SWEm0jglPcKf3JX/QWRXUR1ww83rsKX/eu6YL9jJK8LD6I0vGBLPvL7GBSM/TFUyu6hkrW18yzx7dgzdt0aPZiH2/2UBXzmRY0SIa/THmfbxAcbpBQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1709549135207487.48895490060636; Mon, 4 Mar 2024 02:45:35 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rh5ny-0006MK-Rz; Mon, 04 Mar 2024 05:44:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh5nx-0006LY-FN for qemu-devel@nongnu.org; Mon, 04 Mar 2024 05:44:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rh5nt-00046m-6T for qemu-devel@nongnu.org; Mon, 04 Mar 2024 05:44:21 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-YmGVHIYBOAyJ_p30_4UQWQ-1; Mon, 04 Mar 2024 05:44:13 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CD7641C0BA40; Mon, 4 Mar 2024 10:44:12 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id D36031C060B1; Mon, 4 Mar 2024 10:44:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709549056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=njyBLCIS4gewEjmYCVl3Zq3Lwp00j5JPg6RIx/fhaRY=; b=JP2NOm/xtWbQrI+aU7Cjsini2N2whK1R2zF2EpxkZS+E0Ct9/oma5k0gM0kPSPLTq4v0Qv xHSGFf0fgb/oHgh8mPvJ5Q7/Q8NpHn0ke81xclzEu3MNI4Wn5apQYulla/QH3IoIwmJijV uAGDU45dC2VaS3CJJAqSFOGBFWvg7+E= X-MC-Unique: YmGVHIYBOAyJ_p30_4UQWQ-1 From: Thomas Huth To: Jonathan Cameron , qemu-devel@nongnu.org Cc: Fan Ni , "Michael S. Tsirkin" , Marcel Apfelbaum , qemu-trivial@nongnu.org Subject: [PATCH 1/3] hw/cxl/cxl-cdat: Fix type of buf in ct3_load_cdat() Date: Mon, 4 Mar 2024 11:44:04 +0100 Message-ID: <20240304104406.59855-2-thuth@redhat.com> In-Reply-To: <20240304104406.59855-1-thuth@redhat.com> References: <20240304104406.59855-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.589, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1709549136401100007 Content-Type: text/plain; charset="utf-8" When setting GLIB_VERSION_MAX_ALLOWED to GLIB_VERSION_2_58 or higher (which we'll certainly do in the not too distant future), glib adds type safety checks to the g_steal_pointer() macro. This trigger an error in the ct3_load_cdat() function: The local char *buf variable is assigned to uint8_t *buf in CDATObject, i.e. a pointer of a different type. Change the local variable to the same type as buf in CDATObject to avoid the error. Signed-off-by: Thomas Huth Reviewed-by: Jonathan Cameron --- hw/cxl/cxl-cdat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/cxl/cxl-cdat.c b/hw/cxl/cxl-cdat.c index 2fea975671..551545f782 100644 --- a/hw/cxl/cxl-cdat.c +++ b/hw/cxl/cxl-cdat.c @@ -114,7 +114,7 @@ static void ct3_build_cdat(CDATObject *cdat, Error **er= rp) static void ct3_load_cdat(CDATObject *cdat, Error **errp) { g_autofree CDATEntry *cdat_st =3D NULL; - g_autofree char *buf =3D NULL; + g_autofree uint8_t *buf =3D NULL; uint8_t sum =3D 0; int num_ent; int i =3D 0, ent =3D 1; @@ -171,7 +171,7 @@ static void ct3_load_cdat(CDATObject *cdat, Error **err= p) cdat_st[ent].base =3D hdr; cdat_st[ent].length =3D hdr->length; =20 - while (buf + i < (char *)cdat_st[ent].base + cdat_st[ent].length) { + while (buf + i < (uint8_t *)cdat_st[ent].base + cdat_st[ent].lengt= h) { assert(i < file_size); sum +=3D buf[i++]; } --=20 2.44.0