From nobody Tue Nov 26 06:55:24 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1709203449; cv=none; d=zohomail.com; s=zohoarc; b=j8tuMdW35/v0T0mViEQYlkC36jkYB5oLmQqDnKQFbUwIkO3Ps6OYDD7Rh1I/HpeKKBPSE0gFInBFfIriM8tqPr/e6h0dqlPiWRNSWmrl9iNTV5inSTNJE1G7BApVsPFB37UZ2ZNy95Bl1bcxwSTc54MnWu60wMc8zCdItEx1P6E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1709203449; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=i63b46w1LySKhhFANiCq+HAyYOnafoHBsZu2zDiOK9s=; b=kX3FTDo0R8gG+f9ljiI2FOylIYnEJTtnLys9yIXMMSdcACYxZkJeYpQuEDUVnJX6OVdRfQVG9fr+AlJrv7D1/8QZGIsvymnp8IGkgvdpj9hGHhf7Bmv0KrIF6vJfX8J2hoKfSs9ovEQeLjepBnRfk8YZAmrdZ+LwOrymlRfWknw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1709203449397191.46275533572782; Thu, 29 Feb 2024 02:44:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfdtJ-00025A-TA; Thu, 29 Feb 2024 05:43:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfdtI-000251-Fl for qemu-devel@nongnu.org; Thu, 29 Feb 2024 05:43:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfdtG-0002II-Au for qemu-devel@nongnu.org; Thu, 29 Feb 2024 05:43:52 -0500 Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-197-VLOgZqEGP4urXiIRRklBGQ-1; Thu, 29 Feb 2024 05:43:43 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1C1BD29AC00F; Thu, 29 Feb 2024 10:43:43 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2DD941BDB1; Thu, 29 Feb 2024 10:43:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709203427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=i63b46w1LySKhhFANiCq+HAyYOnafoHBsZu2zDiOK9s=; b=VUnJvNRewrrfkv4su76oPcYeIjnPXsqCn2AHLVGjkKW4+UjfBJHN1lZZ1z7vExULpAq7tv 811V50sws2hksLmchtDpeO25acMpZITLj+N4NJgYnKsrIY0WgCqG9g/s8xmfueCJOSTA57 s/fhlqA/tHoNCAUyorLgYjgjRYodBBQ= X-MC-Unique: VLOgZqEGP4urXiIRRklBGQ-1 From: Thomas Huth To: qemu-devel@nongnu.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Cc: Paolo Bonzini , Antoine Damhet , Charles Frey Subject: [PATCH] chardev/char-socket: Fix TLS io channels sending too much data to the backend Date: Thu, 29 Feb 2024 11:43:37 +0100 Message-ID: <20240229104339.42574-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.102, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1709203451158100001 Commit ffda5db65a ("io/channel-tls: fix handling of bigger read buffers") changed the behavior of the TLS io channels to schedule a second reading attempt if there is still incoming data pending. This caused a regression with backends like the sclpconsole that check in their read function that the sender does not try to write more bytes to it than the device can currently handle. The problem can be reproduced like this: 1) In one terminal, do this: mkdir qemu-pki cd qemu-pki openssl genrsa 2048 > ca-key.pem openssl req -new -x509 -nodes -days 365000 -key ca-key.pem -out ca-cert.p= em # enter some dummy value for the cert openssl genrsa 2048 > server-key.pem openssl req -new -x509 -nodes -days 365000 -key server-key.pem \ -out server-cert.pem # enter some other dummy values for the cert gnutls-serv --echo --x509cafile ca-cert.pem --x509keyfile server-key.pem \ --x509certfile server-cert.pem -p 8338 2) In another terminal, do this: wget https://download.fedoraproject.org/pub/fedora-secondary/releases/39/= Cloud/s390x/images/Fedora-Cloud-Base-39-1.5.s390x.qcow2 qemu-system-s390x -nographic -nodefaults \ -hda Fedora-Cloud-Base-39-1.5.s390x.qcow2 \ -object tls-creds-x509,id=3Dtls0,endpoint=3Dclient,verify-peer=3Dfalse,= dir=3D$PWD/qemu-pki \ -chardev socket,id=3Dtls_chardev,host=3Dlocalhost,port=3D8338,tls-creds= =3Dtls0 \ -device sclpconsole,chardev=3Dtls_chardev,id=3Dtls_serial QEMU then aborts after a second or two with: qemu-system-s390x: ../hw/char/sclpconsole.c:73: chr_read: Assertion `size <=3D SIZE_BUFFER_VT220 - scon->iov_data_len' failed. Aborted (core dumped) It looks like the second read does not trigger the chr_can_read() function to be called before the second read, which should normally always be done before sending bytes to a character device to see how much it can handle, so the s->max_size in tcp_chr_read() still contains the old value from the previous read. Let's make sure that we use the up-to-date value by calling tcp_chr_read_poll() again here. Fixes: ffda5db65a ("io/channel-tls: fix handling of bigger read buffers") Buglink: https://issues.redhat.com/browse/RHEL-24614 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Thomas Huth Reviewed-by: Antoine Damhet Reviewed-by: Marc-Andr=C3=A9 Lureau Tested-by: Antoine Damhet --- Sorry if you've got this mail twice - I forgot to CC: qemu-devel when I sent it out the first time ... *facepalm* chardev/char-socket.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 67e3334423..8a0406cc1e 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -496,9 +496,9 @@ static gboolean tcp_chr_read(QIOChannel *chan, GIOCondi= tion cond, void *opaque) s->max_size <=3D 0) { return TRUE; } - len =3D sizeof(buf); - if (len > s->max_size) { - len =3D s->max_size; + len =3D tcp_chr_read_poll(opaque); + if (len > sizeof(buf)) { + len =3D sizeof(buf); } size =3D tcp_chr_recv(chr, (void *)buf, len); if (size =3D=3D 0 || (size =3D=3D -1 && errno !=3D EAGAIN)) { --=20 2.44.0